[Freeciv-Dev] [patch #1617] Release script objects for removed units and cities

2010-04-12 Thread Matthias Pfafferodt 

Follow-up Comment #1, patch #1617 (project freeciv):

I think something similar is needed for struct player as it is also exported
to lua and can be freed

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1582] UTF-8 utilities

2010-04-12 Thread pepeto 

Update of patch #1582 (project freeciv):

  Status:  Ready For Test => None   

___

Follow-up Comment #5:

> ATM there is an issue with MAX_LEN_NAME. This is supposed to
> limit city names, for instance, at 32 characters. Instead it
> limits then at 32 bytes which is incorrect. Most places which
> use it should instead use a longer or malloc'd buffer, and use
> fc_utf8_strlen() to make sure the name isn't too long.

A problem would be for the packets. The packet size seems to need a byte
limit, not in characters.

> How do we know just because a character is 4 bytes long that
> bytes 2-4 are valid? Does UTF-8 allow any byte sequence in
> here? What about malicious chats from the client?

It is the role of base_fc_utf8_char_validate() called by
fc_utf8_char_validate() and fc_utf8_validate(), then
fc_utf8_validate_trunc().

> Casts should not be needed in passing values to these
> functions. Doing so is a sign the parameters used are not
> right. In fact I think one such case is quite wrong.

I am not sure to understand what do you criticize here. The only casts are to
unsure the calculation is done with unsigned characters. There are also some
casts to (char *) which are used to do internally tricky things (e.g. in
fc_utf8_validate_trunc()).

> Each function provided should do everything that it needs to.
> Specifically, fc_utf8_char_size is not a useful function in
> its current form (except for internal usage). 

I agree, this function was needed for defining fc_utf8_char_next() in the
first patch, I forgot to remove it from the header file in the second.

> Are we sure that using these variants everywhere is easier
> than converting all freeciv to wide characters?

I don't know.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15747] bizarre compile error in gtk2 popup_pillage_dialog

2010-04-12 Thread pepeto 

Update of bug #15747 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15810] Sanity check should use fc_assert()

2010-04-12 Thread pepeto 

Update of bug #15810 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15816] add a comment about a needed empty line in the nation.ruleset file

2010-04-12 Thread pepeto 

Update of bug #15816 (project freeciv):

 Assigned to:None => pepeto 

___

Follow-up Comment #5:

I intent to commit my fixes in the listed branch by 'Planned Release'.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15841] API: Do not use tolua_outside

2010-04-12 Thread Ulrik Sverdrup 

Follow-up Comment #1, bug #15841 (project freeciv):

Updated patch, this way it's even better/easier. Will commit soon.

(file #8928)
___

Additional Item Attachment:

File name: 2010041201-API-Do-not-use-tolua_outside.patch Size:6 KB


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1617] Release script objects for removed units and cities

2010-04-12 Thread Ulrik Sverdrup 

Follow-up Comment #2, patch #1617 (project freeciv):

Ah ok. I'll look at player in a followup patch. It seems players are never
released, but they are put into an unusable state after being removed so it's
similar.

Attached patch has minor update for change in tolua_outside patch.

(file #8929)
___

Additional Item Attachment:

File name: 2010041207-Release-script-objects-for-removed-units-and-c.patch
Size:6 KB


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1621] API: [2.2] Protect string arguments with SCRIPT_ASSERT

2010-04-12 Thread Ulrik Sverdrup 

URL:
  

 Summary: API: [2.2] Protect string arguments with
SCRIPT_ASSERT
 Project: Freeciv
Submitted by: englabenny
Submitted on: måndag 2010-04-12 den 11:12
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: englabenny
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.2.1

___

Details:

For the 2.2 branch, we protect string arguments with SCRIPT_ASSERT.

tolua-5.1 allows 'nil' for string arguments, unlike toluaxx. We need these to
not segfault in almost all of the cases.




___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1621] API: [2.2] Protect string arguments with SCRIPT_ASSERT

2010-04-12 Thread Ulrik Sverdrup 

Additional Item Attachment, patch #1621 (project freeciv):

File name: 2010041201-API-Protect-string-arguments-with-SCRIPT_ASSER.patch
Size:4 KB


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1617] Release script objects for removed units and cities

2010-04-12 Thread Matthias Pfafferodt 

Follow-up Comment #3, patch #1617 (project freeciv):

At the moment an array of 32 players is allocated at the start. So the number
of players is fixed. Perhaps someday the players will be a dynamically
allocated list ...

But you are right. Especially in that case, a player will never be deleted /
removed but only marked as dead.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15857] Fix buggy find_transport_from_tile

2010-04-12 Thread Ulrik Sverdrup 

URL:
  

 Summary: Fix buggy find_transport_from_tile
 Project: Freeciv
Submitted by: englabenny
Submitted on: måndag 2010-04-12 den 14:05
Category: general
Severity: 3 - Normal
Priority: 1 - Later
  Status: Ready For Test
 Assigned to: englabenny
Originator Email: 
 Open/Closed: Open
 Release: 2.2
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.1, 2.3.0

___

Details:

find_transport_from_tile reversed the order of the cargo and
transporter unit arguments.

Fix for 2.2 and trunk attached.



___

File Attachments:


---
Date: måndag 2010-04-12 den 14:05  Name:
2010041201-Fix-movmement.c-find_transport_from_tile-use-o.patch  Size: 912 B 
 By: englabenny



___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15841] API: Do not use tolua_outside

2010-04-12 Thread Ulrik Sverdrup 

Update of bug #15841 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b

2010-04-12 Thread Ulrik Sverdrup 

Update of bug #13709 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #10:

Switched to tolua-5.1 (tolua 5.1.3)

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b

2010-04-12 Thread Matthias Pfafferodt 

Follow-up Comment #11, bug #13709 (project freeciv):

I get errors trying to compile S2_2 and trunk

S2_2:

dependencies/Makefile.am:3: required directory dependencies/tolua-5.1 does
not exist
utility/Makefile.am:60: `%'-style pattern rules are a GNU make extension
configure.ac:942: required file `dependencies/tolua-5.1/Makefile.in' not
found
configure.ac:942: required file `dependencies/tolua-5.1/src/Makefile.in' not
found
configure.ac:942: required file `dependencies/tolua-5.1/src/lib/Makefile.in'
not found
configure.ac:942: required file `dependencies/tolua-5.1/src/bin/Makefile.in'
not found
make: *** [Makefile.in] Error 1


here it is the directory tolua-5.1b

trunk:

tolua.c: In function ‘main’:
tolua.c:109: error: nested extern declaration of ‘tolua_tolua_open’
make[5]: *** [tolua.o] Error 1
make[5]: Leaving directory
`/home/matthias/data/git/freeciv.svn/trunk/dependencies/tolua-5.1/src/bin'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory
`/home/matthias/data/git/freeciv.svn/trunk/dependencies/tolua-5.1/src'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory
`/home/matthias/data/git/freeciv.svn/trunk/dependencies/tolua-5.1'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/home/matthias/data/git/freeciv.svn/trunk/dependencies'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/matthias/data/git/freeciv.svn/trunk'
make: *** [all] Error 2


This function is defined in a tolua.c and toluabind.c with different
definitions?


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1574] add a player to a running game

2010-04-12 Thread Matthias Pfafferodt 

Follow-up Comment #10, patch #1574 (project freeciv):

I think the interface could be

create_player(, )

with both arguments as string. Is it possible to set  to nil to
get a NULL pointer in freeciv? This way it would be possible to define a
nation but also a random nation can be set.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b

2010-04-12 Thread Ulrik Sverdrup 

Follow-up Comment #12, bug #13709 (project freeciv):

I made a rather massive error on the 2.2 branch, since tolua-5.1 does not
even exist there.

I'm sorry for that.

I don't understand the trunk error at all. It compiled without warnings.

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15844] Crash upon connecting to a game

2010-04-12 Thread Matthias Pfafferodt 

Update of bug #15844 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1582] UTF-8 utilities

2010-04-12 Thread Matthias Pfafferodt 

Follow-up Comment #6, patch #1582 (project freeciv):

> A problem would be for the packets. The packet size seems to need a byte
limit, not in characters. 

This could be solved by multiplying all packet string sizes by 4(?) to take
into account multicharacter bytes

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15858] Game crashes on startup

2010-04-12 Thread anonymous 

URL:
  

 Summary: Game crashes on startup
 Project: Freeciv
Submitted by: None
Submitted on: Monday 04/12/10 at 21:44 CEST
Category: client-sdl
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: brendan.w...@ntlworld.com
 Open/Closed: Open
 Release: 2.1.9
 Discussion Lock: Any
Operating System: Mac OS
 Planned Release: 

___

Details:

I did a clean install of the official 2.1.9 package for Mac OS X.  I launched
and played the game successfully then quit.  Now all subsequent attempts to
play the game result in a crash.  I've tried deleting the .civclientrc file
but to no effect.  Below is the crash report

Process: Freeciv-2.1.9b1 [4083]
Path:   
/Applications/Games/Freeciv.app/Contents/MacOS/Freeciv-2.1.9b1
Identifier:  freeciv.wikia.com
Version: Freeciv version 2.1.9b1 (2.1.9b1)
Code Type:   X86 (Native)
Parent Process:  launchd [429]

Interval Since Last Report:  1315951 sec
Crashes Since Last Report:   38
Per-App Interval Since Last Report:  134571 sec
Per-App Crashes Since Last Report:   21

Date/Time:   2010-04-12 20:36:48.468 +0100
OS Version:  Mac OS X 10.5.8 (9L31a)
Report Version:  6
Anonymous UUID:  4BDC5BC8-44B9-424E-A4BE-9FCC3BFD1672

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x0014
Crashed Thread:  0

Thread 0 Crashed:
0   freeciv.wikia.com   0x000b0e3e real_update_meswin_dialog + 
26
1   freeciv.wikia.com   0x00085934 connect_callback + 91
2   freeciv.wikia.com   0x000c877f widget_pressed_action + 486
3   freeciv.wikia.com   0x0009966c 
main_mouse_button_down_handler
+ 66
4   freeciv.wikia.com   0x0009a4cb gui_event_loop + 1096
5   freeciv.wikia.com   0x0009a9ed ui_main + 829
6   freeciv.wikia.com   0x000684c1 SDL_main + 2588
7   freeciv.wikia.com   0x282a -[SDLMain
applicationDidFinishLaunching:] + 66
8   com.apple.Foundation0x91bac42a _nsnote_callback + 106
9   com.apple.CoreFoundation0x91ec247a __CFXNotificationPost + 362
10  com.apple.CoreFoundation0x91ec2753
_CFXNotificationPostNotification + 179
11  com.apple.Foundation0x91ba9680 -[NSNotificationCenter
postNotificationName:object:userInfo:] + 128
12  com.apple.Foundation0x91bb2ed8 -[NSNotificationCenter
postNotificationName:object:] + 56
13  com.apple.AppKit0x960e5df2 -[NSApplication
_postDidFinishNotification] + 125
14  com.apple.AppKit0x960e5d01 -[NSApplication
_sendFinishLaunchingNotification] + 77
15  com.apple.AppKit0x9605f81b
-[NSApplication(NSAppleEventHandling) _handleAEOpen:] + 284
16  com.apple.AppKit0x9605f014
-[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 98
17  com.apple.Foundation0x91bd1a9f -[NSAppleEventManager
dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 655
18  com.apple.Foundation0x91bd17af
_NSAppleEventManagerGenericHandler + 223
19  com.apple.AE0x9421b648 aeDispatchAppleEvent(AEDesc
const*, AEDesc*, unsigned long, unsigned char*) + 144
20  com.apple.AE0x9421b57e
dispatchEventAndSendReply(AEDesc const*, AEDesc*) + 44
21  com.apple.AE0x9421b425 aeProcessAppleEvent + 177
22  com.apple.HIToolbox 0x959cf981 AEProcessAppleEvent + 38
23  com.apple.AppKit0x9605c8e9 _DPSNextEvent + 1189
24  com.apple.AppKit0x9605bf88 -[NSApplication
nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
25  com.apple.AppKit0x96054f9f -[NSApplication run] + 795
26  freeciv.wikia.com   0x2f8d main + 1567
27  freeciv.wikia.com   0x247e start + 54

Thread 0 crashed with X86 Thread State (32-bit):
  eax: 0x0001  ebx: 0xbfffe730  ecx: 0x  edx: 0x
  edi: 0x87f3  esi: 0x0015  ebp: 0xbfffe708  esp: 0xbfffe660
   ss: 0x001f  efl: 0x00210286  eip: 0x000b0e3e   cs: 0x0017
   ds: 0x001f   es: 0x001f   fs: 0x   gs: 0x0037
  cr2: 0x0014

Binary Images:
0x1000 -   0x116fe7 +freeciv.wikia.com Freeciv version 2.1.9b1 (2.1.9b1)

/Applications/Games/Freeciv.app/Contents/MacOS/Freeciv-2.1.9b1
  0x234000 -   0x29afc3 +SDL 1.2.13 (1.2.13)
<0340446b4d8528d002751241d76b3909>
/Applications/Games/Freeciv.app/Contents/Frameworks/SDL.framework/Versions/A/SDL
  0x2ad000 -   0x30bff3 +com.yourcompany.yourcocoaframework ??? (1.0)
/Applications/Games/Freeciv.

[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b

2010-04-12 Thread Matthias Pfafferodt 

Follow-up Comment #13, bug #13709 (project freeciv):

The second error seems to be related to an unclean directory. It does not
happen after cleaning up ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b

2010-04-12 Thread Ulrik Sverdrup 

Update of bug #13709 (project freeciv):

  Status:   Fixed => In Progress
 Planned Release:   2.3.0 => 2.2.1, 2.3.0   

___

Follow-up Comment #14:

The trunk error might be a warning from a newer gcc (I compiled with v 4.3).
Here is a diff that might fix that (Attached). Do you see an error or warning
before / after the patch?


I will update 2.2 to tolua 5.1.3 now.

(file #8937)
___

Additional Item Attachment:

File name: tolua_no_nested_decl.diff  Size:0 KB


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1574] add a player to a running game

2010-04-12 Thread Ulrik Sverdrup 

Follow-up Comment #11, patch #1574 (project freeciv):

The script api can use nations as object, so the argument can be 
(Nation_Type *). That allows nil as empty value.

In the api you find nations with 

n = find.nation_type("Greek")

so a typical use would be (when non-nil)

player = create_player("Rufus", find.nation_type("Greek"))

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b

2010-04-12 Thread Matthias Pfafferodt 

Follow-up Comment #16, bug #13709 (project freeciv):

> The trunk error might be a warning from a newer gcc (I compiled with v
4.3). Here is a diff that might fix that (Attached). Do you see an error or
warning before / after the patch? 

I did now a clean checkout (git clean -f) and the error is there (again). But
the patch solves it! Thanks!


#> gcc -v
Using built-in specs.
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --infodir=/usr/share/info
--mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64
--enable-languages=c,c++,objc,fortran,obj-c++,java,ada
--enable-checking=release --with-gxx-include-dir=/usr/include/c++/4.3
--enable-ssp --disable-libssp --with-bugurl=http://bugs.opensuse.org/
--with-pkgversion='SUSE Linux' --disable-libgcj --disable-libmudflap
--with-slibdir=/lib64 --with-system-zlib --enable-__cxa_atexit
--enable-libstdcxx-allocator=new --disable-libstdcxx-pch
--enable-version-specific-runtime-libs --program-suffix=-4.3
--enable-linux-futex --without-system-libunwind --with-cpu=generic
--build=x86_64-suse-linux
Thread model: posix
gcc version 4.3.2 [gcc-4_3-branch revision 141291] (SUSE Linux)


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15860] Fix compiler warning in tolua-5.1

2010-04-12 Thread Ulrik Sverdrup 

URL:
  

 Summary: Fix compiler warning in tolua-5.1
 Project: Freeciv
Submitted by: englabenny
Submitted on: måndag 2010-04-12 den 20:48
Category: general
Severity: 3 - Normal
Priority: 1 - Later
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.1, 2.3.0

___

Details:

There may be a warning emitted for 'nested extern declaration' in 
tolua-5.1, which causes compilation failure in debug mode.

Reported by Matthias Pfafferodt in bug #13709




___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15860] Fix compiler warning in tolua-5.1

2010-04-12 Thread Ulrik Sverdrup 

Follow-up Comment #1, bug #15860 (project freeciv):

Patch for 2.2. and trunk.

This is a compilation failure, commit directly?

(file #8938)
___

Additional Item Attachment:

File name: 2010041201-Fix-compiler-warning-in-tolua-5.1.patch Size:1 KB


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b

2010-04-12 Thread Ulrik Sverdrup 

Update of bug #13709 (project freeciv):

  Status: In Progress => Fixed  

___

Follow-up Comment #17:

The compilation error is tracked in a separate bug #15860

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15860] Fix compiler warning in tolua-5.1

2010-04-12 Thread pepeto 

Follow-up Comment #2, bug #15860 (project freeciv):

> This is a compilation failure, commit directly?

If this is the case (not for me at least), you could commit it immediately.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1611] Scripting: Hide Lua module 'debug'

2010-04-12 Thread Ulrik Sverdrup 

Update of patch #1611 (project freeciv):

 Planned Release:   2.3.0 => 2.2.1, 2.3.0   

___

Follow-up Comment #1:

This should go into both 2.2 and trunk, since the change is easily available
to make in 2.2 as well.

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1603] API: Add Player:civilization_score() and Player:gold() accessors

2010-04-12 Thread Ulrik Sverdrup 

Update of patch #1603 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1605] API: Add Tile:city() and Tile:num_units() accessors

2010-04-12 Thread Ulrik Sverdrup 

Update of patch #1605 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1604] API: Add Tile:square_iterate(..), Tile:circle_iterate(..)

2010-04-12 Thread Ulrik Sverdrup 

Update of patch #1604 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1606] API: Add Tile, Player:units_iterate(), and Player:cities_iterate()

2010-04-12 Thread Ulrik Sverdrup 

Update of patch #1606 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1617] Release script objects for removed units and cities

2010-04-12 Thread Ulrik Sverdrup 

Follow-up Comment #4, patch #1617 (project freeciv):

Updating the patch. This makes the mechanism much better. 

New summary:

We change the type of the userdata to a marker class called
'Nonexistent' [when a freeciv object such as city or unit is free'd].
Nonexistent has one single method :exists() that always returns false. City
and Unit correspondingly have :exists() methods which should always return
true.

'Nonexistent' class is common for everything that is removed. I don't think
the extra complexity is needed to have separate Dead_Unit, Razed_City etc
types. In the end, there is no sensible methods you can call on a dead unit
anyway.

Players are also removed.

(file #8939)
___

Additional Item Attachment:

File name: 2010041201-Remove-script-objects-for-removed-units-cities.patch
Size:9 KB


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1622] Karelian nation

2010-04-12 Thread J.M. Maalderink 

URL:
  

 Summary: Karelian nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Monday 04/12/2010 at 22:38
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Karelians



___

File Attachments:


---
Date: Monday 04/12/2010 at 22:38  Name: karelian.patch  Size: 49kB   By:
mixcoatl



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15858] Game crashes on startup

2010-04-12 Thread David Lowe 

Follow-up Comment #1, bug #15858 (project freeciv):

I suspect you're using the binary provided by Napoleon XIV?  The rest of us
have moved on to 2.2.0 by now, but there's no binary yet.  If you install the
'fink' build system you can test out my 2.2.0 package.

Anyway, that binary has a known problem with permissions on its internal copy
of the freetype library.  See how to fix it in the forum here: 

http://forum.freeciv.org/viewtopic.php?t=4313

and look for the post dated Sat Oct 11, 2008 6:03 am

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev