Re: [Freecol-developers] First Successful Merge Request completed

2015-03-29 Thread Caleb Williams 
That totally makes sense. I reconfigured NetBeans to give more relevant
hints. Plus it didn't help that I misinterpreted Michael's comment on the
merge request.

Now that I have that sorted, it's much easier to not worry about the
JavaDoc stuff.

On Mon, Mar 30, 2015 at 1:09 AM,  wrote:

> When editing the code I try to reduce its size, because Java is verbose
> and the less code to maintain the easier it is done.
> Thats why I only add to the Java-Doc comments when I think of some halfway
> useful text to type in manually. I'd suggest you do same.
>
> Regards
>
> wintertime
>
> *Gesendet:* Montag, 30. März 2015 um 07:15 Uhr
> *Von:* "Caleb Williams" 
> *An:* "FreeCol Developers" 
> *Betreff:* Re: [Freecol-developers] First Successful Merge Request
> completed
>  On Sun, Mar 29, 2015 at 10:31 PM, Caleb Williams 
> wrote:
>
>> Hey all,
>>
>> After a long time of bashing (no pun intended) my head against the
>> SourceForge git wall, I've managed to make a successful merge request.
>>
>> All it should be is slight code clean up involving some of the following
>> (client/gui/panel) files:
>>
>>- Remove unneeded packages
>>- Add @Override tag where appropriate
>>- Add @param and @return were appropriate
>>- One or two if else to switch statements
>>- A couple log syntax changes --- those are what needs to be tested
>>more of all as I'm not sure how they'll effect FreeCol.log (I'm hoping not
>>at all)
>>
>> I've compiled the changes and have received no issue so far.
>>
>> As I mentioned, this is all semi-automated work from what NetBeans is
>> telling me can be added. I'm not attempting any complex changes.
>>
>> Thanks,
>>
>> --
>> *Caleb R. Williams*
>>
>>
>>
>
> Just an FYI:
>
> {@inheritDoc} existed previously. I did not add that in. I could easily
> run a search for all of them in Panel directory and get rid of them.
>
> --
> *Caleb R. Williams*
>
>



-- 
*Caleb R. Williams*

*Photographer*
w: http://calebwilliamsphotography.com
b: http://blog.calebwilliamsphotography.com
e: cale...@gmail.com
c: 612-275-7796
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] First Successful Merge Request completed

2015-03-29 Thread winter 

When editing the code I try to reduce its size, because Java is verbose and the less code to maintain the easier it is done.

Thats why I only add to the Java-Doc comments when I think of some halfway useful text to type in manually. I'd suggest you do same.

 

Regards

 

wintertime

 

Gesendet: Montag, 30. März 2015 um 07:15 Uhr
Von: "Caleb Williams" 
An: "FreeCol Developers" 
Betreff: Re: [Freecol-developers] First Successful Merge Request completed



On Sun, Mar 29, 2015 at 10:31 PM, Caleb Williams  wrote:




Hey all,
 

After a long time of bashing (no pun intended) my head against the SourceForge git wall, I've managed to make a successful merge request.

 

All it should be is slight code clean up involving some of the following (client/gui/panel) files:



	Remove unneeded packages
	Add @Override tag where appropriate
	Add @param and @return were appropriate
	One or two if else to switch statements
	A couple log syntax changes --- those are what needs to be tested more of all as I'm not sure how they'll effect FreeCol.log (I'm hoping not at all)


I've compiled the changes and have received no issue so far.

 

As I mentioned, this is all semi-automated work from what NetBeans is telling me can be added. I'm not attempting any complex changes.

 

Thanks,

 
-- 


Caleb R. Williams

 

 


 




Just an FYI:

 

{@inheritDoc} existed previously. I did not add that in. I could easily run a search for all of them in Panel directory and get rid of them.

 
--


Caleb R. Williams

 









--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] First Successful Merge Request completed

2015-03-29 Thread Caleb Williams 
On Sun, Mar 29, 2015 at 10:31 PM, Caleb Williams  wrote:

> Hey all,
>
> After a long time of bashing (no pun intended) my head against the
> SourceForge git wall, I've managed to make a successful merge request.
>
> All it should be is slight code clean up involving some of the following
> (client/gui/panel) files:
>
>- Remove unneeded packages
>- Add @Override tag where appropriate
>- Add @param and @return were appropriate
>- One or two if else to switch statements
>- A couple log syntax changes --- those are what needs to be tested
>more of all as I'm not sure how they'll effect FreeCol.log (I'm hoping not
>at all)
>
> I've compiled the changes and have received no issue so far.
>
> As I mentioned, this is all semi-automated work from what NetBeans is
> telling me can be added. I'm not attempting any complex changes.
>
> Thanks,
>
> --
> *Caleb R. Williams*
>

Just an FYI:

{@inheritDoc} existed previously. I did not add that in. I could easily run
a search for all of them in Panel directory and get rid of them.

-- 
*Caleb R. Williams*
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

[Freecol-developers] First Successful Merge Request completed

2015-03-29 Thread Caleb Williams 
Hey all,

After a long time of bashing (no pun intended) my head against the
SourceForge git wall, I've managed to make a successful merge request.

All it should be is slight code clean up involving some of the following
(client/gui/panel) files:

   - Remove unneeded packages
   - Add @Override tag where appropriate
   - Add @param and @return were appropriate
   - One or two if else to switch statements
   - A couple log syntax changes --- those are what needs to be tested more
   of all as I'm not sure how they'll effect FreeCol.log (I'm hoping not at
   all)

I've compiled the changes and have received no issue so far.

As I mentioned, this is all semi-automated work from what NetBeans is
telling me can be added. I'm not attempting any complex changes.

Thanks,

-- 
*Caleb R. Williams*
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] The size of dialogs

2015-03-29 Thread winter 
Hi,

as I slowly made some (of the many needed) changes to enable the game having 
scaling
(see also BR#2726), I made a couple observations and would like to know what you
think about them.

I found I could very easily allow the map to be zoomed in some more (2-3 line 
change,
if no graphical glitch appears).
Having the tiles be double size should be nice, but should the steps inbetween 
stay
at 25% of original size? Should I try enabling it?
Would it still look nice or get blocky?

The game is very inconsistent with applying the scale factor (which is saved
in ImageLibrary) when images are needed.
I would think there are only 2 cases/scaling factors needed, anything on the map
and anything else in the GUI. Both exist already and the one for the GUI is 
currently
always 1, though there are also many images and fonts its not applied to atm, 
where I
would like to add it. I would assume there is nothing which should never be 
scaled,
or did I miss anything?

When that is done, next step would be to add scaling for all content (images, 
fonts),
maybe adding some keybindings like * and / for testing.
That would surely cause many glitches until the layout of all dialogs and 
panels gets
checked and adapted, which I fear. I hesitate introducing such problems, which 
could
last for a long time.
Would that interfere with the next release? Would it help to branch the code or 
only
add more work?

I noticed the game is very inconsistent in the appearance of the GUI. For 
example:
There are 5 or even more slightly different sizes for the unit images used, 
which
I would think could be reduced to 3 or maybe even 2?
The dialogs/panels look too different, because the usey different fonts in 
different
sizes and attributes with different layouts with some using lines inbetween 
items
and some not. Should it be a long term goal to get it more consistent, so the
headers are same size, same font in same size is used for similar items in 
different
panels, same layout for the panels showing similar things and so on?


Greetings

wintertime

--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers