Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-20 Thread Dmitry Baryshkov 

On 18/04/2023 02:14, Marijn Suijten wrote:

The WB debug log mask ended up never being assigned, leading to writes
to this block to never be logged even if the mask is enabled in
dpu_hw_util_log_mask via sysfs.

Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback 
blocks")
Signed-off-by: Marijn Suijten 
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 1 +
  1 file changed, 1 insertion(+)


With the mentioned commit message changes:

Reviewed-by: Dmitry Baryshkov 

--
With best wishes
Dmitry

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-19 Thread Abhinav Kumar 




On 4/19/2023 2:28 AM, Marijn Suijten wrote:

On 2023-04-18 09:06:34, Abhinav Kumar wrote:


On 4/17/2023 4:14 PM, Marijn Suijten wrote:

The WB debug log mask ended up never being assigned, leading to writes
to this block to never be logged even if the mask is enabled in
dpu_hw_util_log_mask via sysfs.


This should be debugfs not sysfs.


Good catch!  I've queued this up for v2 if it comes to it, otherwise it
can perhaps be fixed up while applying for msm-fixes?



Yes, I can fix it up while applying to -fixes.


Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback 
blocks")
Signed-off-by: Marijn Suijten 
---


With that fixed,

Reviewed-by: Abhinav Kumar 


Thanks!

- Marijn

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-19 Thread Marijn Suijten 
On 2023-04-18 09:06:34, Abhinav Kumar wrote:
> 
> On 4/17/2023 4:14 PM, Marijn Suijten wrote:
> > The WB debug log mask ended up never being assigned, leading to writes
> > to this block to never be logged even if the mask is enabled in
> > dpu_hw_util_log_mask via sysfs.
> 
> This should be debugfs not sysfs.

Good catch!  I've queued this up for v2 if it comes to it, otherwise it
can perhaps be fixed up while applying for msm-fixes?

> > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback 
> > blocks")
> > Signed-off-by: Marijn Suijten 
> > ---
> 
> With that fixed,
> 
> Reviewed-by: Abhinav Kumar 

Thanks!

- Marijn

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-18 Thread Abhinav Kumar 




On 4/17/2023 4:14 PM, Marijn Suijten wrote:

The WB debug log mask ended up never being assigned, leading to writes
to this block to never be logged even if the mask is enabled in
dpu_hw_util_log_mask via sysfs.


This should be debugfs not sysfs.



Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback 
blocks")
Signed-off-by: Marijn Suijten 
---


With that fixed,

Reviewed-by: Abhinav Kumar

[Freedreno] [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-17 Thread Marijn Suijten 
The WB debug log mask ended up never being assigned, leading to writes
to this block to never be logged even if the mask is enabled in
dpu_hw_util_log_mask via sysfs.

Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback 
blocks")
Signed-off-by: Marijn Suijten 
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c
index db5e6040017f..f33b48045b5c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c
@@ -61,6 +61,7 @@ static const struct dpu_wb_cfg *_wb_offset(enum dpu_wb wb,
for (i = 0; i < m->wb_count; i++) {
if (wb == m->wb[i].id) {
b->blk_addr = addr + m->wb[i].base;
+   b->log_mask = DPU_DBG_MASK_WB;
return &m->wb[i];
}
}

-- 
2.40.0