Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
Hi Eric,
On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote:
> Hi Neil,
>
> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
> > Hi,
> >
> > On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
> > > On 23/03/2023 11:25, Neil Armstrong wrote:
> > > > Fixes the following DT bindings check error:
> > > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was
> > > > unexpected)
> > > >
> > > > Signed-off-by: Neil Armstrong
> > > > ---
> > > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > > b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > > index ef9bae2e6acc..8ecc48c7c5ef 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
> > > > "jedec,ufs-2.0";
> > > > reg = <0 0x01d84000 0 0x3000>,
> > > > <0 0x01d88000 0 0x8000>;
> > > > - reg-names = "std", "ice";
> > >
> > > This is also part of:
> > > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.v...@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
> > > but I actually wonder whether you just missed some binding patch?
> >
> > I'm aware of Abel's RFC patchset to support shared ICE, but this is a
> > cleanup of the current DT,
> > and the current bindings schema doesn't document reg-names.
> >
>
> The ufs-qcom driver accesses the "ice" registers by name, so the reg-names
> can't
> be removed from the device tree. A few months ago there was a patch to fix
> the
> device tree schema for qcom,ufs to include the reg-names. It looks like that
> patch got missed, though:
> https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699...@fairphone.com
Are you implying that I should resend the patch or something? Not sure
who to bug about applying this patch.
Regards
Luca
>
> - Eric
Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
On 24/03/2023 08:26, Luca Weiss wrote:
> Hi Eric,
>
> On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote:
>> Hi Neil,
>>
>> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
>>> Hi,
>>>
>>> On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
On 23/03/2023 11:25, Neil Armstrong wrote:
> Fixes the following DT bindings check error:
> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was
> unexpected)
>
> Signed-off-by: Neil Armstrong
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index ef9bae2e6acc..8ecc48c7c5ef 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
>"jedec,ufs-2.0";
> reg = <0 0x01d84000 0 0x3000>,
> <0 0x01d88000 0 0x8000>;
> - reg-names = "std", "ice";
This is also part of:
https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.v...@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
but I actually wonder whether you just missed some binding patch?
>>>
>>> I'm aware of Abel's RFC patchset to support shared ICE, but this is a
>>> cleanup of the current DT,
>>> and the current bindings schema doesn't document reg-names.
>>>
>>
>> The ufs-qcom driver accesses the "ice" registers by name, so the reg-names
>> can't
>> be removed from the device tree. A few months ago there was a patch to fix
>> the
>> device tree schema for qcom,ufs to include the reg-names. It looks like that
>> patch got missed, though:
>> https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699...@fairphone.com
>
> Are you implying that I should resend the patch or something? Not sure
> who to bug about applying this patch.
Yes, you should. It has been almost three months...
Best regards,
Krzysztof
Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
On 24/03/2023 07:52, Eric Biggers wrote:
> Hi Neil,
>
> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
>> Hi,
>>
>> On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
>>> On 23/03/2023 11:25, Neil Armstrong wrote:
Fixes the following DT bindings check error:
ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was
unexpected)
Signed-off-by: Neil Armstrong
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index ef9bae2e6acc..8ecc48c7c5ef 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
"jedec,ufs-2.0";
reg = <0 0x01d84000 0 0x3000>,
<0 0x01d88000 0 0x8000>;
- reg-names = "std", "ice";
>>>
>>> This is also part of:
>>> https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.v...@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
>>> but I actually wonder whether you just missed some binding patch?
>>
>> I'm aware of Abel's RFC patchset to support shared ICE, but this is a
>> cleanup of the current DT,
>> and the current bindings schema doesn't document reg-names.
>>
>
> The ufs-qcom driver accesses the "ice" registers by name, so the reg-names
> can't
> be removed from the device tree. A few months ago there was a patch to fix
> the
> device tree schema for qcom,ufs to include the reg-names. It looks like that
> patch got missed, though:
> https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699...@fairphone.com
Exactly. This is why I never saw these warnings.
Neil, there are a lot of pending patches, so you need to be sure you run
dtbs_check with them applied.
Best regards,
Krzysztof
Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
Hi Neil,
On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
> Hi,
>
> On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
> > On 23/03/2023 11:25, Neil Armstrong wrote:
> > > Fixes the following DT bindings check error:
> > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was
> > > unexpected)
> > >
> > > Signed-off-by: Neil Armstrong
> > > ---
> > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > index ef9bae2e6acc..8ecc48c7c5ef 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
> > >"jedec,ufs-2.0";
> > > reg = <0 0x01d84000 0 0x3000>,
> > > <0 0x01d88000 0 0x8000>;
> > > - reg-names = "std", "ice";
> >
> > This is also part of:
> > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.v...@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
> > but I actually wonder whether you just missed some binding patch?
>
> I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup
> of the current DT,
> and the current bindings schema doesn't document reg-names.
>
The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't
be removed from the device tree. A few months ago there was a patch to fix the
device tree schema for qcom,ufs to include the reg-names. It looks like that
patch got missed, though:
https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699...@fairphone.com
- Eric
Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
Hi,
On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
On 23/03/2023 11:25, Neil Armstrong wrote:
Fixes the following DT bindings check error:
ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was
unexpected)
Signed-off-by: Neil Armstrong
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index ef9bae2e6acc..8ecc48c7c5ef 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
"jedec,ufs-2.0";
reg = <0 0x01d84000 0 0x3000>,
<0 0x01d88000 0 0x8000>;
- reg-names = "std", "ice";
This is also part of:
https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.v...@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
but I actually wonder whether you just missed some binding patch?
I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup
of the current DT,
and the current bindings schema doesn't document reg-names.
Neil
Best regards,
Krzysztof
Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
On 23/03/2023 11:25, Neil Armstrong wrote:
> Fixes the following DT bindings check error:
> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was
> unexpected)
>
> Signed-off-by: Neil Armstrong
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index ef9bae2e6acc..8ecc48c7c5ef 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
>"jedec,ufs-2.0";
> reg = <0 0x01d84000 0 0x3000>,
> <0 0x01d88000 0 0x8000>;
> - reg-names = "std", "ice";
This is also part of:
https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.v...@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
but I actually wonder whether you just missed some binding patch?
Best regards,
Krzysztof
[Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
Fixes the following DT bindings check error:
ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was
unexpected)
Signed-off-by: Neil Armstrong
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index ef9bae2e6acc..8ecc48c7c5ef 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
"jedec,ufs-2.0";
reg = <0 0x01d84000 0 0x3000>,
<0 0x01d88000 0 0x8000>;
- reg-names = "std", "ice";
interrupts = ;
phys = <_mem_phy_lanes>;
phy-names = "ufsphy";
--
2.34.1
