Re: [Freedreno] [PATCH v2 04/22] drm/msm: enumerate DSI interfaces

[Marijn Suijten]

On 2023-06-13 03:09:43, Dmitry Baryshkov wrote:
> Follow the DP example and define MSM_DSI_CONTROLLER_n enumeration.
> 
> Signed-off-by: Dmitry Baryshkov 

Nice, that'll be cleaner.

Reviewed-by: Marijn Suijten 

> ---
>  drivers/gpu/drm/msm/msm_drv.h | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
> index e13a8cbd61c9..ad4fad2bcdc8 100644
> --- a/drivers/gpu/drm/msm/msm_drv.h
> +++ b/drivers/gpu/drm/msm/msm_drv.h
> @@ -65,6 +65,12 @@ enum msm_dp_controller {
>   MSM_DP_CONTROLLER_COUNT,
>  };
>  
> +enum msm_dsi_controller {
> + MSM_DSI_CONTROLLER_0,
> + MSM_DSI_CONTROLLER_1,
> + MSM_DSI_CONTROLLER_COUNT,
> +};
> +
>  #define MSM_GPU_MAX_RINGS 4
>  #define MAX_H_TILES_PER_DISPLAY 2
>  
> @@ -117,7 +123,7 @@ struct msm_drm_private {
>   struct hdmi *hdmi;
>  
>   /* DSI is shared by mdp4 and mdp5 */
> - struct msm_dsi *dsi[2];
> + struct msm_dsi *dsi[MSM_DSI_CONTROLLER_COUNT];
>  
>   struct msm_dp *dp[MSM_DP_CONTROLLER_COUNT];
>  
> -- 
> 2.39.2
> 

Re: [Freedreno] [PATCH v2 04/22] drm/msm: enumerate DSI interfaces

[Abhinav Kumar]

On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote:

Follow the DP example and define MSM_DSI_CONTROLLER_n enumeration.

Signed-off-by: Dmitry Baryshkov 
---


Reviewed-by: Abhinav Kumar 

[Freedreno] [PATCH v2 04/22] drm/msm: enumerate DSI interfaces

[Dmitry Baryshkov]

Follow the DP example and define MSM_DSI_CONTROLLER_n enumeration.

Signed-off-by: Dmitry Baryshkov 
---
 drivers/gpu/drm/msm/msm_drv.h | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index e13a8cbd61c9..ad4fad2bcdc8 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -65,6 +65,12 @@ enum msm_dp_controller {
MSM_DP_CONTROLLER_COUNT,
 };
 
+enum msm_dsi_controller {
+   MSM_DSI_CONTROLLER_0,
+   MSM_DSI_CONTROLLER_1,
+   MSM_DSI_CONTROLLER_COUNT,
+};
+
 #define MSM_GPU_MAX_RINGS 4
 #define MAX_H_TILES_PER_DISPLAY 2
 
@@ -117,7 +123,7 @@ struct msm_drm_private {
struct hdmi *hdmi;
 
/* DSI is shared by mdp4 and mdp5 */
-   struct msm_dsi *dsi[2];
+   struct msm_dsi *dsi[MSM_DSI_CONTROLLER_COUNT];
 
struct msm_dp *dp[MSM_DP_CONTROLLER_COUNT];
 
-- 
2.39.2