Re: [Freedreno] [PATCH v2 05/17] drm/msm/dpu: Remove duplicate register defines from INTF

2023-04-24 Thread Abhinav Kumar 




On 4/17/2023 1:21 PM, Marijn Suijten wrote:

The INTF_FRAME_LINE_COUNT_EN, INTF_FRAME_COUNT and INTF_LINE_COUNT
registers are already defined higher up, in the right place when sorted
numerically.

Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Marijn Suijten 
---


Reviewed-by: Abhinav Kumar

Re: [Freedreno] [PATCH v2 05/17] drm/msm/dpu: Remove duplicate register defines from INTF

2023-04-19 Thread Dmitry Baryshkov 

On 17/04/2023 23:21, Marijn Suijten wrote:

The INTF_FRAME_LINE_COUNT_EN, INTF_FRAME_COUNT and INTF_LINE_COUNT
registers are already defined higher up, in the right place when sorted
numerically.

Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Marijn Suijten 
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 5 -
  1 file changed, 5 deletions(-)


Reviewed-by: Dmitry Baryshkov 

--
With best wishes
Dmitry

Re: [Freedreno] [PATCH v2 05/17] drm/msm/dpu: Remove duplicate register defines from INTF

2023-04-18 Thread Konrad Dybcio 



On 17.04.2023 22:21, Marijn Suijten wrote:
> The INTF_FRAME_LINE_COUNT_EN, INTF_FRAME_COUNT and INTF_LINE_COUNT
> registers are already defined higher up, in the right place when sorted
> numerically.
> 
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Signed-off-by: Marijn Suijten 
> ---
Reviewed-by: Konrad Dybcio 

Konrad
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c 
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
> index 84ee2efa9c66..b9dddf576c02 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
> @@ -56,11 +56,6 @@
>  #define   INTF_TPG_RGB_MAPPING  0x11C
>  #define   INTF_PROG_FETCH_START 0x170
>  #define   INTF_PROG_ROT_START   0x174
> -
> -#define   INTF_FRAME_LINE_COUNT_EN  0x0A8
> -#define   INTF_FRAME_COUNT  0x0AC
> -#define   INTF_LINE_COUNT   0x0B0
> -
>  #define   INTF_MUX  0x25C
>  #define   INTF_STATUS   0x26C
>  
>

[Freedreno] [PATCH v2 05/17] drm/msm/dpu: Remove duplicate register defines from INTF

2023-04-17 Thread Marijn Suijten 
The INTF_FRAME_LINE_COUNT_EN, INTF_FRAME_COUNT and INTF_LINE_COUNT
registers are already defined higher up, in the right place when sorted
numerically.

Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Marijn Suijten 
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
index 84ee2efa9c66..b9dddf576c02 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
@@ -56,11 +56,6 @@
 #define   INTF_TPG_RGB_MAPPING  0x11C
 #define   INTF_PROG_FETCH_START 0x170
 #define   INTF_PROG_ROT_START   0x174
-
-#define   INTF_FRAME_LINE_COUNT_EN  0x0A8
-#define   INTF_FRAME_COUNT  0x0AC
-#define   INTF_LINE_COUNT   0x0B0
-
 #define   INTF_MUX  0x25C
 #define   INTF_STATUS   0x26C
 

-- 
2.40.0