Re: [RFC PATCH 1/1] dt-bindings: display/msm: gpu: Split Adreno schemas into separate files

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:05, Adam Skladowski wrote:
> Split shared schema into per-gen and group adrenos by clocks used.
> 
> Signed-off-by: Adam Skladowski 
> ---
>  .../devicetree/bindings/display/msm/gpu.yaml  | 317 ++
>  .../bindings/display/msm/qcom,adreno-306.yaml | 115 +++
>  .../bindings/display/msm/qcom,adreno-330.yaml | 111 ++
>  .../bindings/display/msm/qcom,adreno-405.yaml | 135 
>  .../bindings/display/msm/qcom,adreno-506.yaml | 184 ++
>  .../bindings/display/msm/qcom,adreno-530.yaml | 161 +
>  .../bindings/display/msm/qcom,adreno-540.yaml | 154 +
>  .../bindings/display/msm/qcom,adreno-6xx.yaml | 160 +
>  .../display/msm/qcom,adreno-common.yaml   | 112 +++
>  9 files changed, 1157 insertions(+), 292 deletions(-)

One huge patch of 1150 insertions... please split it, e.g. first move
the common parts to common schema and include it in msm/gpu. Then move
device by device.

>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-306.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-330.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-405.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-506.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-530.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-540.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-6xx.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/qcom,adreno-common.yaml
> 


Best regards,
Krzysztof



[RFC PATCH 1/1] dt-bindings: display/msm: gpu: Split Adreno schemas into separate files

2024-03-26 Thread Adam Skladowski
Split shared schema into per-gen and group adrenos by clocks used.

Signed-off-by: Adam Skladowski 
---
 .../devicetree/bindings/display/msm/gpu.yaml  | 317 ++
 .../bindings/display/msm/qcom,adreno-306.yaml | 115 +++
 .../bindings/display/msm/qcom,adreno-330.yaml | 111 ++
 .../bindings/display/msm/qcom,adreno-405.yaml | 135 
 .../bindings/display/msm/qcom,adreno-506.yaml | 184 ++
 .../bindings/display/msm/qcom,adreno-530.yaml | 161 +
 .../bindings/display/msm/qcom,adreno-540.yaml | 154 +
 .../bindings/display/msm/qcom,adreno-6xx.yaml | 160 +
 .../display/msm/qcom,adreno-common.yaml   | 112 +++
 9 files changed, 1157 insertions(+), 292 deletions(-)
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-306.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-330.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-405.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-506.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-530.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-540.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-6xx.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/qcom,adreno-common.yaml

diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml 
b/Documentation/devicetree/bindings/display/msm/gpu.yaml
index 40b5c6bd11f8..be29d85e597c 100644
--- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
@@ -5,7 +5,7 @@
 $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Adreno or Snapdragon GPUs
+title: Imageon 200 GPU
 
 maintainers:
   - Rob Clark 
@@ -13,18 +13,6 @@ maintainers:
 properties:
   compatible:
 oneOf:
-  - description: |
-  The driver is parsing the compat string for Adreno to
-  figure out the chip-id.
-items:
-  - pattern: 
'^qcom,adreno-[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]$'
-  - const: qcom,adreno
-  - description: |
-  The driver is parsing the compat string for Adreno to
-  figure out the gpu-id and patch level.
-items:
-  - pattern: '^qcom,adreno-[3-7][0-9][0-9]\.[0-9]+$'
-  - const: qcom,adreno
   - description: |
   The driver is parsing the compat string for Imageon to
   figure out the gpu-id and patch level.
@@ -32,88 +20,31 @@ properties:
   - pattern: '^amd,imageon-200\.[0-1]$'
   - const: amd,imageon
 
-  clocks: true
+  clocks:
+items:
+  - description: GPU Core clock
+  - description: GPU Memory Interface clock
 
-  clock-names: true
+  clock-names:
+items:
+  - const: core_clk
+  - const: mem_iface_clk
 
   reg:
-minItems: 1
-maxItems: 3
+items:
+  - description: base address of GPU device
 
   reg-names:
-minItems: 1
-maxItems: 3
+items:
+  - const: kgsl_3d0_reg_memory
 
   interrupts:
-maxItems: 1
-
-  interrupt-names:
-maxItems: 1
-
-  interconnects:
-minItems: 1
-maxItems: 2
-
-  interconnect-names:
-minItems: 1
 items:
-  - const: gfx-mem
-  - const: ocmem
+  - description: interrupt of GPU device
 
-  iommus:
-minItems: 1
-maxItems: 64
-
-  sram:
-$ref: /schemas/types.yaml#/definitions/phandle-array
-minItems: 1
-maxItems: 4
+  interrupt-names:
 items:
-  maxItems: 1
-description: |
-  phandles to one or more reserved on-chip SRAM regions.
-  phandle to the On Chip Memory (OCMEM) that's present on some a3xx and
-  a4xx Snapdragon SoCs. See
-  Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
-
-  operating-points-v2: true
-  opp-table:
-type: object
-
-  power-domains:
-maxItems: 1
-
-  zap-shader:
-type: object
-additionalProperties: false
-description: |
-  For a5xx and a6xx devices this node contains a memory-region that
-  points to reserved memory to store the zap shader that can be used to
-  help bring the GPU out of secure mode.
-properties:
-  memory-region:
-maxItems: 1
-
-  firmware-name:
-description: |
-  Default name of the firmware to load to the remote processor.
-
-  "#cooling-cells":
-const: 2
-
-  nvmem-cell-names:
-maxItems: 1
-
-  nvmem-cells:
-description: efuse registers
-maxItems: 1
-
-  qcom,gmu:
-$ref: /schemas/types.yaml#/definitions/phandle
-description: |
-  For GMU attached devices a phandle to the GMU device that will
-  control the power for the GPU.
-
+  - const: kgsl_3d0_irq
 
 required:
   - compatible
@@ -122,222 +53,24 @@ required:
 
 additionalProperties: false