Re: [Freeipa-devel] [PATCHES 0191-0194] Fix restoring states of services after uninstalling
On 02/17/2015 02:49 PM, Martin Basti wrote: On 17/02/15 12:18, David Kupka wrote: On 02/11/2015 05:13 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4869 Fixes: - enable/start a service after uninstallation if the service was enabled/running before in correct way - store status of service before disable/stop/start/enable operation - run uninstall only for configured services Uninstall for ipa-dnskeysyncd is not executed because of https://fedorahosted.org/freeipa/ticket/4901 Patches attached. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Hi, thanks for patches. The code looks good to me but I found 2 issues: 1. httpd is left in non-working state after installing and uninstalling ipa-server. Tried on clean Fedora 21, the httpd was not configured before ipa-server installation. 2. Patch 191 needs (trivial) rebase. Thanks, Updated patches attached. Thanks, I've no further objections, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES 0191-0194] Fix restoring states of services after uninstalling
On 02/18/2015 10:02 AM, David Kupka wrote: On 02/17/2015 02:49 PM, Martin Basti wrote: On 17/02/15 12:18, David Kupka wrote: On 02/11/2015 05:13 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4869 Fixes: - enable/start a service after uninstallation if the service was enabled/running before in correct way - store status of service before disable/stop/start/enable operation - run uninstall only for configured services Uninstall for ipa-dnskeysyncd is not executed because of https://fedorahosted.org/freeipa/ticket/4901 Patches attached. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Hi, thanks for patches. The code looks good to me but I found 2 issues: 1. httpd is left in non-working state after installing and uninstalling ipa-server. Tried on clean Fedora 21, the httpd was not configured before ipa-server installation. 2. Patch 191 needs (trivial) rebase. Thanks, Updated patches attached. Thanks, I've no further objections, ACK. Pushed to master: d216cab6192398f85e2bcc4916826bc91c2841de Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0316] Fix crash triggered by zone objects with unexpected DN
On 12/16/2014 04:32 PM, Petr Spacek wrote: Hello, Fix crash triggered by zone objects with unexpected DN. https://fedorahosted.org/bind-dyndb-ldap/ticket/148 NACK. The patch seems to make no difference when using the reproducer from ticket 148 18-Feb-2015 10:34:09.067 running 18-Feb-2015 10:34:09.139 ldap_helper.c:4876: INSIST(task == inst-task) failed, back trace 18-Feb-2015 10:34:09.139 #0 0x55587a80 in ?? 18-Feb-2015 10:34:09.139 #1 0x7620781a in ?? 18-Feb-2015 10:34:09.139 #2 0x720b00b2 in ?? 18-Feb-2015 10:34:09.140 #3 0x71e7ccf9 in ?? 18-Feb-2015 10:34:09.140 #4 0x71e7d992 in ?? 18-Feb-2015 10:34:09.140 #5 0x720a7f3b in ?? 18-Feb-2015 10:34:09.140 #6 0x75dda52a in ?? 18-Feb-2015 10:34:09.140 #7 0x7508d79d in ?? 18-Feb-2015 10:34:09.140 exiting (due to assertion failure) Program received signal SIGABRT, Aborted. [Switching to Thread 0x7fffea7cd700 (LWP 1719)] 0x74fc18c7 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:55 55 return INLINE_SYSCALL (tgkill, 3, pid, selftid, sig); Missing separate debuginfos, use: debuginfo-install cyrus-sasl-gssapi-2.1.26-19.fc21.x86_64 cyrus-sasl-lib-2.1.26-19.fc21.x86_64 cyrus-sasl-md5-2.1.26-19.fc21.x86_64 cyrus-sasl-plain-2.1.26-19.fc21.x86_64 gssproxy-0.3.1-4.fc21.x86_64 keyutils-libs-1.5.9-4.fc21.x86_64 libattr-2.4.47-9.fc21.x86_64 libdb-5.3.28-9.fc21.x86_64 libgcc-4.9.2-6.fc21.x86_64 libselinux-2.3-5.fc21.x86_64 nspr-4.10.8-1.fc21.x86_64 nss-3.17.4-1.fc21.x86_64 nss-softokn-freebl-3.17.4-1.fc21.x86_64 nss-util-3.17.4-1.fc21.x86_64 pcre-8.35-8.fc21.x86_64 sssd-client-1.12.3-4.fc21.x86_64 xz-libs-5.1.2-14alpha.fc21.x86_64 (gdb) bt #0 0x74fc18c7 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:55 #1 0x74fc352a in __GI_abort () at abort.c:89 #2 0x55587c29 in assertion_failed (file=optimized out, line=optimized out, type=optimized out, cond=optimized out) at ./main.c:220 #3 0x7620781a in isc_assertion_failed (file=file@entry=0x720bad2a ldap_helper.c, line=line@entry=4876, type=type@entry=isc_assertiontype_insist, cond=cond@entry=0x720baf04 task == inst-task) at assertions.c:57 #4 0x720b00b2 in syncrepl_update (chgtype=1, entry=0x70125590, inst=0x77fa3160) at ldap_helper.c:4876 #5 ldap_sync_search_entry (ls=optimized out, msg=optimized out, entryUUID=optimized out, phase=LDAP_SYNC_CAPI_ADD) at ldap_helper.c:5031 #6 0x71e7ccf9 in ldap_sync_search_entry (ls=ls@entry=0x7fffe40008c0, res=0x7fffe4003870) at ldap_sync.c:228 #7 0x71e7d992 in ldap_sync_init (ls=0x7fffe40008c0, mode=mode@entry=3) at ldap_sync.c:792 #8 0x720a7f3b in ldap_syncrepl_watcher (arg=0x77fa3160) at ldap_helper.c:5247 #9 0x75dda52a in start_thread (arg=0x7fffea7cd700) at pthread_create.c:310 #10 0x7508d79d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 494 group-detach does not add correct objectclasses
On 01/30/2015 03:04 PM, Rob Crittenden wrote: Martin Kosek wrote: https://fedorahosted.org/freeipa/ticket/4874 LGTM but a test please to prevent future regressions. rob ACK Pushed to: master: 8ea8a7038ea0a9ed23e5569c34535e48008c7884 ipa-4-1: 2dd54c9f33c25d6c32f96e7b85850cfa3a990930 ticket for regression tests: https://fedorahosted.org/freeipa/ticket/4909 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0002] Changing the token owner also changes its manager
On 01/14/2015 08:02 PM, Nathaniel McCallum wrote: On Wed, 2015-01-14 at 17:49 +0100, Martin Babinsky wrote: On 01/14/2015 05:23 PM, Nathaniel McCallum wrote: On Wed, 2015-01-14 at 16:49 +0100, Martin Babinsky wrote: Changing the owner of a token also implicitly sets the new owner as its manager if following conditions are met: 1.) The original token owner was also its manager 2.) The new manager is not set explicitly via CLI interface. If the owner is unset and the above conditions are met, then the manager of the token will also be unset. https://fedorahosted.org/freeipa/ticket/4681 Nitpicks: 1. The commit message summary line should not have a '.' 2. The commit message is not properly wrapped. 3. The newline before _normalize_owner() is undesirable. 4. Shouldn't prev_managed_by be prev_managedby? The main body of the change looks good to me. Nathaniel Attaching updated patch. ACK Pushed to: master: b95f4330c9433683f61c46f9605fd1d24bb8b998 ipa-4-1: c985de1ee6429c49e6273a037478212e7ee301c8 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 300] Fix incorrect python shebang usage
On 01/22/2015 04:49 PM, Martin Basti wrote: On 22/01/15 12:52, Tomas Babej wrote: Hi, attached patch fixes few python2 non-explicit shebangs that lurked into the codebase. Tomas ACK was pushed by tbabej to master on 2015-01-26 f30865c5f07bdc4d5f87e89f9ed99148f4d361ce -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
