Re: [Freeipa-devel] [PATCH] 0001 provide more information for "ipa cert-revoke -h"

2016-05-03 Thread Gabe Alford 
On Tue, May 3, 2016 at 9:35 AM, Patrice Duc-Jacquet <
patrice.duc.jacq...@gmail.com> wrote:

> On 05/03/2016 04:41 PM, Rob Crittenden wrote:
>
> Gabe Alford wrote:
>>
>>> Hello,
>>>
>>> Thank you for your patch as well.
>>>
>>>  >-doc=_('Reason for revoking the certificate (0-10)'),
>>>  >+doc=_('Reason for revoking the certificate (0-10). See
>>> RFC 5280 (paragraph 5.3.1) for reason details'),
>>>
>>> Rather than just specifying the RFC with the paragraph to go look up,
>>> can you either add the revocation options or say something like:
>>>
>>> +doc=_('Reason for revoking the certificate (0-10). See
>>> \'ipa help cert\' for revocation reason details.'),
>>>
>>> IMO, it is a little annoying to go look up revocation reasons when those
>>> reasons can either be added to the help output or exist already in `ipa
>>> help cert`.
>>>
>>
>> FTR I added it to the top level help because the reasons are used in
>> multiple places and didn't want to duplicate them, and adding them to a
>> specific option help would overload it big time IMHO.
>>
>> rob
>>
>> Hi everyone
> thanks for your valuable comments. I fully agree that it is not
> recommended to duplicate this information. So as Rob suggested, I should
> avoid to add this information to cert_revoke option and thus I plan to
> modify the help message as follow:
>
> doc=_('Reason for revoking the certificate (0-10). Type "ipa help cert"
> for reason details'),
>
> Do you agree with that modification? Thanks in advance and regards
>

I think the modification is fine. One nitpick that I would have is to say
"for revocation reason details."  rather than "for reason details."
Also, don't forget a period after the word "details". :)

Gabe



>
> Pat
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0001 provide more information for "ipa cert-revoke -h"

2016-05-03 Thread Patrice Duc-Jacquet 

On 05/03/2016 04:41 PM, Rob Crittenden wrote:


Gabe Alford wrote:

Hello,

Thank you for your patch as well.

 >-doc=_('Reason for revoking the certificate (0-10)'),
 >+doc=_('Reason for revoking the certificate (0-10). See
RFC 5280 (paragraph 5.3.1) for reason details'),

Rather than just specifying the RFC with the paragraph to go look up,
can you either add the revocation options or say something like:

+doc=_('Reason for revoking the certificate (0-10). See
\'ipa help cert\' for revocation reason details.'),

IMO, it is a little annoying to go look up revocation reasons when those
reasons can either be added to the help output or exist already in `ipa
help cert`.


FTR I added it to the top level help because the reasons are used in 
multiple places and didn't want to duplicate them, and adding them to 
a specific option help would overload it big time IMHO.


rob


Hi everyone
thanks for your valuable comments. I fully agree that it is not 
recommended to duplicate this information. So as Rob suggested, I should 
avoid to add this information to cert_revoke option and thus I plan to 
modify the help message as follow:


doc=_('Reason for revoking the certificate (0-10). Type "ipa help cert" 
for reason details'),


Do you agree with that modification? Thanks in advance and regards

Pat

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0001 provide more information for "ipa cert-revoke -h"

2016-05-03 Thread Rob Crittenden 

Gabe Alford wrote:

Hello,

Thank you for your patch as well.

 >-doc=_('Reason for revoking the certificate (0-10)'),
 >+doc=_('Reason for revoking the certificate (0-10). See
RFC 5280 (paragraph 5.3.1) for reason details'),

Rather than just specifying the RFC with the paragraph to go look up,
can you either add the revocation options or say something like:

+doc=_('Reason for revoking the certificate (0-10). See
\'ipa help cert\' for revocation reason details.'),

IMO, it is a little annoying to go look up revocation reasons when those
reasons can either be added to the help output or exist already in `ipa
help cert`.


FTR I added it to the top level help because the reasons are used in 
multiple places and didn't want to duplicate them, and adding them to a 
specific option help would overload it big time IMHO.


rob

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0001 provide more information for "ipa cert-revoke -h"

2016-05-03 Thread Gabe Alford 
Hello,

Thank you for your patch as well.

>-doc=_('Reason for revoking the certificate (0-10)'),
>+doc=_('Reason for revoking the certificate (0-10). See RFC
5280 (paragraph 5.3.1) for reason details'),

Rather than just specifying the RFC with the paragraph to go look up, can
you either add the revocation options or say something like:

+doc=_('Reason for revoking the certificate (0-10). See \'ipa
help cert\' for revocation reason details.'),

IMO, it is a little annoying to go look up revocation reasons when those
reasons can either be added to the help output or exist already in `ipa
help cert`.

Thanks,

Gabe


On Tue, May 3, 2016 at 8:13 AM, Martin Basti  wrote:

>
>
> On 03.05.2016 16:01, Patrice Duc-Jacquet wrote:
>
> Hi everyone
> this is my first patch. So I may have done thhings nor in  a proper way.
> Please let me know if something is wrong in the proceess I followed. With
> regards
>
> Pat
>
>
> Hello,
>
> thank you for your patch. Please remove changes in .po and .pot files from
> the patch, these files are generated automatically from zanata.
>
> thank you
>
> Martin
>
> --
> Manage your subscription for the Freeipa-devel mailing list:
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0001 provide more information for "ipa cert-revoke -h"

2016-05-03 Thread Martin Basti 



On 03.05.2016 16:01, Patrice Duc-Jacquet wrote:

Hi everyone
this is my first patch. So I may have done thhings nor in  a proper 
way. Please let me know if something is wrong in the proceess I 
followed. With regards


Pat



Hello,

thank you for your patch. Please remove changes in .po and .pot files 
from the patch, these files are generated automatically from zanata.


thank you

Martin
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH] 0001 provide more information for "ipa cert-revoke -h"

2016-05-03 Thread Patrice Duc-Jacquet 

Hi everyone
this is my first patch. So I may have done thhings nor in  a proper way. 
Please let me know if something is wrong in the proceess I followed. 
With regards


Pat
>From bb06bd55c9f68af1a3aa01b671757abfbb45c822 Mon Sep 17 00:00:00 2001
From: Patrice Duc-Jacquet 
Date: Tue, 3 May 2016 15:17:16 +0200
Subject: [PATCH] Add more information regarding where to find revocation
 reason in "ipa cert_revoke -h" and "ipa cert_find -h"  commands. More
 precisely a pointer to RFC 5280 (paragraph 5.3.1) which contain the
 definition of the revocation code.

So basically "ipa cert_revoke -h command" now returns :

$ ipa cert_revoke -h
Usage: ipa [global-options] cert-revoke SERIAL-NUMBER [options]

Revoke a certificate.
Options:
  -h, --helpshow this help message and exit
  --revocation-reason=INT
Reason for revoking the certificate (0-10). See RFC
5280 (paragraph 5.3.1) for reason details

ipa.pot and correspondig .po files have also been modified to take into account this new string.

https://fedorahosted.org/freeipa/ticket/5819
---
 install/po/de.po   | 2 +-
 install/po/es.po   | 2 +-
 install/po/fr.po   | 2 +-
 install/po/ipa.pot | 2 +-
 install/po/kn.po   | 2 +-
 install/po/pl.po   | 2 +-
 install/po/ru.po   | 2 +-
 install/po/uk.po   | 2 +-
 install/po/zh_CN.po| 2 +-
 ipalib/plugins/cert.py | 4 ++--
 10 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/install/po/de.po b/install/po/de.po
index 35d20932060ea8865aa8cb7b19a57e4e0e3d8469..52509711c3bdb881d28e85f5da1326f4b606d453 100644
--- a/install/po/de.po
+++ b/install/po/de.po
@@ -1343,7 +1343,7 @@ msgstr "Widerrufen"
 msgid "Reason"
 msgstr "Grund"
 
-msgid "Reason for revoking the certificate (0-10)"
+msgid "Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details"
 msgstr "Grund für den Widerruf des Zertifikats (0-10)"
 
 msgid "7 is not a valid revocation reason"
diff --git a/install/po/es.po b/install/po/es.po
index 48f4284e6d0ba1650dc77a97e7c67532411dd392..3e76f419403381c675dc0b461746488a00d7e84a 100644
--- a/install/po/es.po
+++ b/install/po/es.po
@@ -1402,7 +1402,7 @@ msgstr "Revocado"
 msgid "Reason"
 msgstr "Motivo"
 
-msgid "Reason for revoking the certificate (0-10)"
+msgid "Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details"
 msgstr "Motivo por el cual el certificado ha sido revocado (0-10)"
 
 msgid "7 is not a valid revocation reason"
diff --git a/install/po/fr.po b/install/po/fr.po
index cefe28797ba0d89e7361980e3f851577738d8b63..f250b228678706f8908bc6a6e29972f975df5786 100644
--- a/install/po/fr.po
+++ b/install/po/fr.po
@@ -2896,7 +2896,7 @@ msgstr "Révoqué"
 msgid "Reason"
 msgstr "Raison"
 
-msgid "Reason for revoking the certificate (0-10)"
+msgid "Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details"
 msgstr "Raison de révocation du certificat (0-10)"
 
 msgid "7 is not a valid revocation reason"
diff --git a/install/po/ipa.pot b/install/po/ipa.pot
index 8256bb77da282d6c327a761ffd07c31b8fc7bf28..e89f035b20cac28034ba36accf7ffeba4306815d 100644
--- a/install/po/ipa.pot
+++ b/install/po/ipa.pot
@@ -3114,7 +3114,7 @@ msgid "Reason"
 msgstr ""
 
 #: ipalib/plugins/cert.py:669 ipalib/plugins/cert.py:737
-msgid "Reason for revoking the certificate (0-10)"
+msgid "Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details"
 msgstr ""
 
 #: ipalib/plugins/cert.py:692
diff --git a/install/po/kn.po b/install/po/kn.po
index e3b6f67092e30b4684a3b665966082c79ad26e59..b2551c726ab4fded523830d6b8f6f86a1b756463 100644
--- a/install/po/kn.po
+++ b/install/po/kn.po
@@ -414,7 +414,7 @@ msgstr "ರದ್ದು ಮಾಡಲಾಗಿದೆ"
 msgid "Reason"
 msgstr "ಕಾರಣ"
 
-msgid "Reason for revoking the certificate (0-10)"
+msgid "Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details"
 msgstr "ಪ್ರಮಾಣಪತ್ರವನ್ನು (0-10) ರದ್ದು ಮಾಡಲು ಕಾರಣ"
 
 msgid "Unrevoked"
diff --git a/install/po/pl.po b/install/po/pl.po
index 2f98114435081cd3b4da676608fb804292c0cff5..cc0b2fc9a1e32bf076387bf2449f5101d302dade 100644
--- a/install/po/pl.po
+++ b/install/po/pl.po
@@ -587,7 +587,7 @@ msgstr "Unieważniono"
 msgid "Reason"
 msgstr "Przyczyna"
 
-msgid "Reason for revoking the certificate (0-10)"
+msgid "Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details"
 msgstr "Przyczyna unieważnienia certyfikatu (0-10)"
 
 msgid "Unrevoked"
diff --git a/install/po/ru.po b/install/po/ru.po
index b24064f4dc0e56bb8a669dfe5949d0787146835c..a275d72a0a1a5db0c519f83fbf72186f3f747edf 100644
--- a/install/po/ru.po
+++ b/install/po/ru.po
@@ -1268,7 +1268,7 @@ msgstr "Отозван"
 msgid "Reason"
 msgstr "Причина"
 
-msgid "Reason for revoking the certificate