Re: [Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

2013-04-11 Thread Martin Kosek 
On 04/10/2013 04:20 PM, Petr Viktorin wrote:
 On 04/08/2013 06:15 PM, Ana Krivokapic wrote:
 On 04/08/2013 04:33 PM, Jan Cholasta wrote:
 On 8.4.2013 15:41, Jan Cholasta wrote:
 Hi,

 On 8.4.2013 13:40, Ana Krivokapic wrote:
 Hello,

 This patch addresses https://fedorahosted.org/freeipa/ticket/3503. See
 the commit message for details.


 the patch seems OK, I will just run the test suite to make sure you
 didn't miss anything.

 Honza


 Change dnszone_del summary to Deleted DNS zone, as we use DNS zone
 (not just zone) in other commands. Also as Petr pointed out, we're
 in string freeze now, so we have to wait until it's over before
 pushing this patch, or split the patch in two.

 Besides that, ACK.


 Thanks for the review.

 I have changed the summary message to Deleted DNS zone, and split the
 patch into two patches that can be applied independently.

 
 We can break the string freeze with this small change, so ACK to both.
 

Pushed both patches to master.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

2013-04-10 Thread Petr Viktorin 

On 04/08/2013 06:15 PM, Ana Krivokapic wrote:

On 04/08/2013 04:33 PM, Jan Cholasta wrote:

On 8.4.2013 15:41, Jan Cholasta wrote:

Hi,

On 8.4.2013 13:40, Ana Krivokapic wrote:

Hello,

This patch addresses https://fedorahosted.org/freeipa/ticket/3503. See
the commit message for details.



the patch seems OK, I will just run the test suite to make sure you
didn't miss anything.

Honza



Change dnszone_del summary to Deleted DNS zone, as we use DNS zone
(not just zone) in other commands. Also as Petr pointed out, we're
in string freeze now, so we have to wait until it's over before
pushing this patch, or split the patch in two.

Besides that, ACK.



Thanks for the review.

I have changed the summary message to Deleted DNS zone, and split the
patch into two patches that can be applied independently.



We can break the string freeze with this small change, so ACK to both.

--
Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

2013-04-08 Thread Ana Krivokapic 
Hello,

This patch addresses https://fedorahosted.org/freeipa/ticket/3503. See
the commit message for details.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

From 25b94d35f4958bda8bc435494a357be13d209f26 Mon Sep 17 00:00:00 2001
From: Ana Krivokapic akriv...@redhat.com
Date: Mon, 8 Apr 2013 05:48:11 -0400
Subject: [PATCH] Fix output for some CLI commands

Add missing summary message to dnszone_del.
Fix output of dnsrecord_del: it now uses output.standard_delete
and excludes --all and --raw flags.
Fix output of sudorule_{add,remove}_option: they now use
output.standard_entry and include --all and --raw flags.

https://fedorahosted.org/freeipa/ticket/3503
---
 API.txt  | 22 ++
 VERSION  |  2 +-
 ipalib/plugins/dns.py|  4 
 ipalib/plugins/sudorule.py   |  6 --
 tests/test_cmdline/test_cli.py   |  8 
 tests/test_xmlrpc/test_dns_plugin.py |  8 
 6 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/API.txt b/API.txt
index 81a1f6187583029a4378e44d65bcc7b8d4496508..b97864eea634a65c2b3f11c47433a0f045d175d3 100644
--- a/API.txt
+++ b/API.txt
@@ -806,13 +806,12 @@ output: Entry('result', type 'dict', Gettext('A dictionary representing an LDA
 output: Output('summary', (type 'unicode', type 'NoneType'), None)
 output: Output('value', type 'unicode', None)
 command: dnsrecord_del
-args: 2,41,3
+args: 2,39,3
 arg: Str('dnszoneidnsname', cli_name='dnszone', query=True, required=True)
 arg: Str('idnsname', attribute=True, cli_name='name', multivalue=False, primary_key=True, query=True, required=True)
 option: A6Record('a6record', attribute=True, autofill=False, cli_name='a6_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: Record('record', attribute=True, autofill=False, cli_name='_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: AFSDBRecord('afsdbrecord', attribute=True, autofill=False, cli_name='afsdb_rec', csv=True, multivalue=True, option_group=None, required=False)
-option: Flag('all', autofill=True, cli_name='all', default=False, exclude='webui')
 option: APLRecord('aplrecord', attribute=True, autofill=False, cli_name='apl_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: ARecord('arecord', attribute=True, autofill=False, cli_name='a_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: CERTRecord('certrecord', attribute=True, autofill=False, cli_name='cert_rec', csv=True, multivalue=True, option_group=None, required=False)
@@ -837,7 +836,6 @@ option: NSEC3Record('nsec3record', attribute=True, autofill=False, cli_name='nse
 option: NSECRecord('nsecrecord', attribute=True, autofill=False, cli_name='nsec_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: NSRecord('nsrecord', attribute=True, autofill=False, cli_name='ns_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: PTRRecord('ptrrecord', attribute=True, autofill=False, cli_name='ptr_rec', csv=True, multivalue=True, option_group=None, required=False)
-option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: RPRecord('rprecord', attribute=True, autofill=False, cli_name='rp_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: RRSIGRecord('rrsigrecord', attribute=True, autofill=False, cli_name='rrsig_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: SIGRecord('sigrecord', attribute=True, autofill=False, cli_name='sig_rec', csv=True, multivalue=True, option_group=None, required=False)
@@ -850,7 +848,7 @@ option: TKEYRecord('tkeyrecord', attribute=True, autofill=False, cli_name='tkey_
 option: TSIGRecord('tsigrecord', attribute=True, autofill=False, cli_name='tsig_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: TXTRecord('txtrecord', attribute=True, autofill=False, cli_name='txt_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: Str('version?', exclude='webui')
-output: Entry('result', type 'dict', Gettext('A dictionary representing an LDAP entry', domain='ipa', localedir=None))
+output: Output('result', type 'dict', None)
 output: Output('summary', (type 'unicode', type 'NoneType'), None)
 output: Output('value', type 'unicode', None)
 command: dnsrecord_delentry
@@ -3134,11 +3132,15 @@ output: Output('completed', type 'int', None)
 output: Output('failed', type 'dict', None)
 output: Entry('result', type 'dict', Gettext('A dictionary representing an LDAP entry', domain='ipa', localedir=None))
 command: sudorule_add_option
-args: 1,2,1
+args: 1,4,3
 arg: Str('cn', attribute=True, cli_name='sudorule_name', multivalue=False, primary_key=True, query=True, required=True)
+option: Flag('all', autofill=True, cli_name='all', default=False, exclude='webui')
 option: Str('ipasudoopt',

Re: [Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

2013-04-08 Thread Jan Cholasta 

Hi,

On 8.4.2013 13:40, Ana Krivokapic wrote:

Hello,

This patch addresses https://fedorahosted.org/freeipa/ticket/3503. See
the commit message for details.



the patch seems OK, I will just run the test suite to make sure you 
didn't miss anything.


Honza

--
Jan Cholasta

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

2013-04-08 Thread Petr Viktorin 

On 04/08/2013 01:40 PM, Ana Krivokapic wrote:

Hello,

This patch addresseshttps://fedorahosted.org/freeipa/ticket/3503. See
the commit message for details.

-- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red
Hat Inc.


freeipa-akrivoka-0012-Fix-output-for-some-CLI-commands.patch



[...]

+msg_summary = _('Deleted zone %(value)s')
+


We're in string freeze now. This will have to wait for the next version :(


--
Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

2013-04-08 Thread Jan Cholasta 

On 8.4.2013 15:41, Jan Cholasta wrote:

Hi,

On 8.4.2013 13:40, Ana Krivokapic wrote:

Hello,

This patch addresses https://fedorahosted.org/freeipa/ticket/3503. See
the commit message for details.



the patch seems OK, I will just run the test suite to make sure you
didn't miss anything.

Honza



Change dnszone_del summary to Deleted DNS zone, as we use DNS zone 
(not just zone) in other commands. Also as Petr pointed out, we're in 
string freeze now, so we have to wait until it's over before pushing 
this patch, or split the patch in two.


Besides that, ACK.

--
Jan Cholasta

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

2013-04-08 Thread Ana Krivokapic 
On 04/08/2013 04:33 PM, Jan Cholasta wrote:
 On 8.4.2013 15:41, Jan Cholasta wrote:
 Hi,

 On 8.4.2013 13:40, Ana Krivokapic wrote:
 Hello,

 This patch addresses https://fedorahosted.org/freeipa/ticket/3503. See
 the commit message for details.


 the patch seems OK, I will just run the test suite to make sure you
 didn't miss anything.

 Honza


 Change dnszone_del summary to Deleted DNS zone, as we use DNS zone
 (not just zone) in other commands. Also as Petr pointed out, we're
 in string freeze now, so we have to wait until it's over before
 pushing this patch, or split the patch in two.

 Besides that, ACK.


Thanks for the review.

I have changed the summary message to Deleted DNS zone, and split the
patch into two patches that can be applied independently.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

From 6ed0a3bc0af72e52742f2753c1ad39d5329e0032 Mon Sep 17 00:00:00 2001
From: Ana Krivokapic akriv...@redhat.com
Date: Mon, 8 Apr 2013 11:04:17 -0400
Subject: [PATCH] Fix output for some CLI commands

Fix output of dnsrecord_del: it now uses output.standard_delete
and excludes --all and --raw flags.
Fix output of sudorule_{add,remove}_option: they now use
output.standard_entry and include --all and --raw flags.

https://fedorahosted.org/freeipa/ticket/3503
---
 API.txt| 22 ++
 VERSION|  2 +-
 ipalib/plugins/dns.py  |  2 ++
 ipalib/plugins/sudorule.py |  6 --
 tests/test_cmdline/test_cli.py |  8 
 5 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/API.txt b/API.txt
index 81a1f6187583029a4378e44d65bcc7b8d4496508..b97864eea634a65c2b3f11c47433a0f045d175d3 100644
--- a/API.txt
+++ b/API.txt
@@ -806,13 +806,12 @@ output: Entry('result', type 'dict', Gettext('A dictionary representing an LDA
 output: Output('summary', (type 'unicode', type 'NoneType'), None)
 output: Output('value', type 'unicode', None)
 command: dnsrecord_del
-args: 2,41,3
+args: 2,39,3
 arg: Str('dnszoneidnsname', cli_name='dnszone', query=True, required=True)
 arg: Str('idnsname', attribute=True, cli_name='name', multivalue=False, primary_key=True, query=True, required=True)
 option: A6Record('a6record', attribute=True, autofill=False, cli_name='a6_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: Record('record', attribute=True, autofill=False, cli_name='_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: AFSDBRecord('afsdbrecord', attribute=True, autofill=False, cli_name='afsdb_rec', csv=True, multivalue=True, option_group=None, required=False)
-option: Flag('all', autofill=True, cli_name='all', default=False, exclude='webui')
 option: APLRecord('aplrecord', attribute=True, autofill=False, cli_name='apl_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: ARecord('arecord', attribute=True, autofill=False, cli_name='a_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: CERTRecord('certrecord', attribute=True, autofill=False, cli_name='cert_rec', csv=True, multivalue=True, option_group=None, required=False)
@@ -837,7 +836,6 @@ option: NSEC3Record('nsec3record', attribute=True, autofill=False, cli_name='nse
 option: NSECRecord('nsecrecord', attribute=True, autofill=False, cli_name='nsec_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: NSRecord('nsrecord', attribute=True, autofill=False, cli_name='ns_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: PTRRecord('ptrrecord', attribute=True, autofill=False, cli_name='ptr_rec', csv=True, multivalue=True, option_group=None, required=False)
-option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: RPRecord('rprecord', attribute=True, autofill=False, cli_name='rp_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: RRSIGRecord('rrsigrecord', attribute=True, autofill=False, cli_name='rrsig_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: SIGRecord('sigrecord', attribute=True, autofill=False, cli_name='sig_rec', csv=True, multivalue=True, option_group=None, required=False)
@@ -850,7 +848,7 @@ option: TKEYRecord('tkeyrecord', attribute=True, autofill=False, cli_name='tkey_
 option: TSIGRecord('tsigrecord', attribute=True, autofill=False, cli_name='tsig_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: TXTRecord('txtrecord', attribute=True, autofill=False, cli_name='txt_rec', csv=True, multivalue=True, option_group=None, required=False)
 option: Str('version?', exclude='webui')
-output: Entry('result', type 'dict', Gettext('A dictionary representing an LDAP entry', domain='ipa', localedir=None))
+output: Output('result', type 'dict', None)
 output: Output('summary', (type 'unicode', type 'NoneType'), None)
 output: Output('value', type 'unicode', None)
 command: dnsrecord_delentry