Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added
On 7.5.2014 15:16, Misnyovszki Adam wrote: On Tue, 06 May 2014 10:29:32 +0200 Petr Vobornik wrote: On 5.5.2014 16:39, Misnyovszki Adam wrote: On Wed, 30 Apr 2014 13:37:10 +0200 Petr Vobornik wrote: On 29.4.2014 16:30, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 17:16:48 +0200 Misnyovszki Adam wrote: Hi, this patch adds some static test data for the webui otptoken part. Adam Attached corrected DN's. Thanks Adam 1) Why otptoken_batch_del.json ends with error? Also there might be a defect in UI that for batch delete operation it asks for batch.json and not $ENTITY_batch_del.json making otptoken_batch_del.json unused - out of scope of this patch. 2) Why otptoken_mod.json ends with error? 3) otptoken_find.json is not needed since the search facet uses paging (combination of otptoken_get_records.json and otptoken_find_pkeys.json is enough). In general, it's OK to fake the data if there is some bug which causes errors and we know that it will be fixed. Hi, see the attached, and corrected 18 patch for otptoken static test data. Also, I've added patch 20, for fixing the batch_del command in static webui tests. Thanks Adam Patch 18-3: 1. otptoken_batch.json, otptoken_batch_del.json, otptoken_mod.json have trailing whitespace after commas 2. otptoken_batch.json was obsoleted by patch 20. Should be removed since both patches are in one patchset. Patch 20: ACK See attached fix for patch 18 Thanks Adam ACK Pushed to master: * 1ef91701e984c5c9717803a0d3c2e52c81386676 webui OTP token test data added * 23302645aa70613dd1ecc6eb45b6c2ad07588270 webui static site delete command fixed -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added
On Tue, 06 May 2014 10:29:32 +0200
Petr Vobornik wrote:
> On 5.5.2014 16:39, Misnyovszki Adam wrote:
> > On Wed, 30 Apr 2014 13:37:10 +0200
> > Petr Vobornik wrote:
> >
> >> On 29.4.2014 16:30, Misnyovszki Adam wrote:
> >>> On Fri, 25 Apr 2014 17:16:48 +0200
> >>> Misnyovszki Adam wrote:
> >>>
> Hi,
> this patch adds some static test data for the webui otptoken
> part. Adam
> >>>
> >>> Attached corrected DN's.
> >>> Thanks
> >>> Adam
> >>>
> >>
> >> 1) Why otptoken_batch_del.json ends with error? Also there might
> >> be a defect in UI that for batch delete operation it asks for
> >> batch.json and not $ENTITY_batch_del.json making
> >> otptoken_batch_del.json unused
> >> - out of scope of this patch.
> >>
> >> 2) Why otptoken_mod.json ends with error?
> >>
> >> 3) otptoken_find.json is not needed since the search facet uses
> >> paging (combination of otptoken_get_records.json and
> >> otptoken_find_pkeys.json is enough).
> >>
> >> In general, it's OK to fake the data if there is some bug which
> >> causes errors and we know that it will be fixed.
> >
> > Hi,
> > see the attached, and corrected 18 patch for otptoken static test
> > data. Also, I've added patch 20, for fixing the batch_del command
> > in static webui tests.
> >
> > Thanks
> > Adam
> >
>
> Patch 18-3:
>
> 1. otptoken_batch.json, otptoken_batch_del.json, otptoken_mod.json
> have trailing whitespace after commas
> 2. otptoken_batch.json was obsoleted by patch 20. Should be removed
> since both patches are in one patchset.
>
> Patch 20:
> ACK
See attached fix for patch 18
Thanks
Adam
>From ff56869ead0b99a5007f40b3a738b1ce80ada069 Mon Sep 17 00:00:00 2001
From: Adam Misnyovszki
Date: Wed, 7 May 2014 15:10:32 +0200
Subject: [PATCH] webui OTP token test data added
---
install/ui/test/data/otptoken_add.json | 43 +++
install/ui/test/data/otptoken_batch_del.json | 27 ++
install/ui/test/data/otptoken_batch_mod.json | 34
install/ui/test/data/otptoken_find_pkeys.json | 17 ++
install/ui/test/data/otptoken_get_records.json | 57
install/ui/test/data/otptoken_mod.json | 72 ++
install/ui/test/data/otptoken_show.json| 51 ++
7 files changed, 301 insertions(+)
create mode 100644 install/ui/test/data/otptoken_add.json
create mode 100644 install/ui/test/data/otptoken_batch_del.json
create mode 100644 install/ui/test/data/otptoken_batch_mod.json
create mode 100644 install/ui/test/data/otptoken_find_pkeys.json
create mode 100644 install/ui/test/data/otptoken_get_records.json
create mode 100644 install/ui/test/data/otptoken_mod.json
create mode 100644 install/ui/test/data/otptoken_show.json
diff --git a/install/ui/test/data/otptoken_add.json b/install/ui/test/data/otptoken_add.json
new file mode 100644
index ..c52fc15035e0aad025294a8da1f938ee53c8e5a9
--- /dev/null
+++ b/install/ui/test/data/otptoken_add.json
@@ -0,0 +1,43 @@
+{
+"error": null,
+"id": null,
+"result": {
+"result": {
+"dn": "ipatokenuniqueid=10bd43b5-3204-4695-9225-91064f6c77b3,cn=otp,dc=example,dc=com",
+"ipatokenmodel": [
+"totp"
+],
+"ipatokenotpalgorithm": [
+"sha1"
+],
+"ipatokenotpdigits": [
+"6"
+],
+"ipatokenotpkey": [
+{
+"__base64__": "2TUYXOVTaZf/Og=="
+}
+],
+"ipatokentotpclockoffset": [
+"0"
+],
+"ipatokentotptimestep": [
+"30"
+],
+"ipatokenuniqueid": [
+"footoken"
+],
+"ipatokenvendor": [
+"FreeIPA"
+],
+"objectclass": [
+"top",
+"ipatokentotp",
+"ipatoken"
+],
+"uri": "otpauth://totp/EXAMPLE.COM:10bd43b5-3204-4695-9225-91064f6c77b3?digits=6&secret=3E2RQXHFKNUZP7Z2&period=30&algorithm=sha1&issuer=EXAMPLE.COM"
+},
+"summary": "Added OTP token \"10bd43b5-3204-4695-9225-91064f6c77b3\"",
+"value": "10bd43b5-3204-4695-9225-91064f6c77b3"
+}
+}
diff --git a/install/ui/test/data/otptoken_batch_del.json b/install/ui/test/data/otptoken_batch_del.json
new file mode 100644
index ..7fff0a0c5cf7cbd0a39d3616c4c58ef7c8d3ccb7
--- /dev/null
+++ b/install/ui/test/data/otptoken_batch_del.json
@@ -0,0 +1,27 @@
+{
+"error": null,
+"id": null,
+"result": {
+"count": 1,
+"messages": [
+{
+"code": 13001,
+"message": "API Version number was not sent, forward compatibility not guaranteed. Assuming server's API version, 2.83",
+"name": "VersionMissing",
+"type": "warning"
+
Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added
On 5.5.2014 16:39, Misnyovszki Adam wrote: On Wed, 30 Apr 2014 13:37:10 +0200 Petr Vobornik wrote: On 29.4.2014 16:30, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 17:16:48 +0200 Misnyovszki Adam wrote: Hi, this patch adds some static test data for the webui otptoken part. Adam Attached corrected DN's. Thanks Adam 1) Why otptoken_batch_del.json ends with error? Also there might be a defect in UI that for batch delete operation it asks for batch.json and not $ENTITY_batch_del.json making otptoken_batch_del.json unused - out of scope of this patch. 2) Why otptoken_mod.json ends with error? 3) otptoken_find.json is not needed since the search facet uses paging (combination of otptoken_get_records.json and otptoken_find_pkeys.json is enough). In general, it's OK to fake the data if there is some bug which causes errors and we know that it will be fixed. Hi, see the attached, and corrected 18 patch for otptoken static test data. Also, I've added patch 20, for fixing the batch_del command in static webui tests. Thanks Adam Patch 18-3: 1. otptoken_batch.json, otptoken_batch_del.json, otptoken_mod.json have trailing whitespace after commas 2. otptoken_batch.json was obsoleted by patch 20. Should be removed since both patches are in one patchset. Patch 20: ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added
On Wed, 30 Apr 2014 13:37:10 +0200
Petr Vobornik wrote:
> On 29.4.2014 16:30, Misnyovszki Adam wrote:
> > On Fri, 25 Apr 2014 17:16:48 +0200
> > Misnyovszki Adam wrote:
> >
> >> Hi,
> >> this patch adds some static test data for the webui otptoken part.
> >> Adam
> >
> > Attached corrected DN's.
> > Thanks
> > Adam
> >
>
> 1) Why otptoken_batch_del.json ends with error? Also there might be
> a defect in UI that for batch delete operation it asks for batch.json
> and not $ENTITY_batch_del.json making otptoken_batch_del.json unused
> - out of scope of this patch.
>
> 2) Why otptoken_mod.json ends with error?
>
> 3) otptoken_find.json is not needed since the search facet uses
> paging (combination of otptoken_get_records.json and
> otptoken_find_pkeys.json is enough).
>
> In general, it's OK to fake the data if there is some bug which
> causes errors and we know that it will be fixed.
Hi,
see the attached, and corrected 18 patch for otptoken static test data.
Also, I've added patch 20, for fixing the batch_del command in static
webui tests.
Thanks
Adam>From 22577cf672128231cb4b2ced7e7ee1c12da664c7 Mon Sep 17 00:00:00 2001
From: Adam Misnyovszki
Date: Wed, 30 Apr 2014 17:53:52 +0200
Subject: [PATCH 1/2] webui OTP token test data added
---
install/ui/test/data/otptoken_add.json | 43 +++
install/ui/test/data/otptoken_batch.json | 27 ++
install/ui/test/data/otptoken_batch_del.json | 27 ++
install/ui/test/data/otptoken_batch_mod.json | 34
install/ui/test/data/otptoken_find_pkeys.json | 17 ++
install/ui/test/data/otptoken_get_records.json | 57
install/ui/test/data/otptoken_mod.json | 72 ++
install/ui/test/data/otptoken_show.json| 51 ++
8 files changed, 328 insertions(+)
create mode 100644 install/ui/test/data/otptoken_add.json
create mode 100644 install/ui/test/data/otptoken_batch.json
create mode 100644 install/ui/test/data/otptoken_batch_del.json
create mode 100644 install/ui/test/data/otptoken_batch_mod.json
create mode 100644 install/ui/test/data/otptoken_find_pkeys.json
create mode 100644 install/ui/test/data/otptoken_get_records.json
create mode 100644 install/ui/test/data/otptoken_mod.json
create mode 100644 install/ui/test/data/otptoken_show.json
diff --git a/install/ui/test/data/otptoken_add.json b/install/ui/test/data/otptoken_add.json
new file mode 100644
index ..c52fc15035e0aad025294a8da1f938ee53c8e5a9
--- /dev/null
+++ b/install/ui/test/data/otptoken_add.json
@@ -0,0 +1,43 @@
+{
+"error": null,
+"id": null,
+"result": {
+"result": {
+"dn": "ipatokenuniqueid=10bd43b5-3204-4695-9225-91064f6c77b3,cn=otp,dc=example,dc=com",
+"ipatokenmodel": [
+"totp"
+],
+"ipatokenotpalgorithm": [
+"sha1"
+],
+"ipatokenotpdigits": [
+"6"
+],
+"ipatokenotpkey": [
+{
+"__base64__": "2TUYXOVTaZf/Og=="
+}
+],
+"ipatokentotpclockoffset": [
+"0"
+],
+"ipatokentotptimestep": [
+"30"
+],
+"ipatokenuniqueid": [
+"footoken"
+],
+"ipatokenvendor": [
+"FreeIPA"
+],
+"objectclass": [
+"top",
+"ipatokentotp",
+"ipatoken"
+],
+"uri": "otpauth://totp/EXAMPLE.COM:10bd43b5-3204-4695-9225-91064f6c77b3?digits=6&secret=3E2RQXHFKNUZP7Z2&period=30&algorithm=sha1&issuer=EXAMPLE.COM"
+},
+"summary": "Added OTP token \"10bd43b5-3204-4695-9225-91064f6c77b3\"",
+"value": "10bd43b5-3204-4695-9225-91064f6c77b3"
+}
+}
diff --git a/install/ui/test/data/otptoken_batch.json b/install/ui/test/data/otptoken_batch.json
new file mode 100644
index ..059b53f96ebe34036394b969f12903e8b52d69fa
--- /dev/null
+++ b/install/ui/test/data/otptoken_batch.json
@@ -0,0 +1,27 @@
+{
+"error": null,
+"id": null,
+"result": {
+"count": 1,
+"messages": [
+{
+"code": 13001,
+"message": "API Version number was not sent, forward compatibility not guaranteed. Assuming server's API version, 2.83",
+"name": "VersionMissing",
+"type": "warning"
+}
+],
+"results": [
+{
+"error": null,
+"result": {
+"failed": []
+},
+"summary": "Deleted OTP token \"10bd43b5-3204-4695-9225-91064f6c77b3\"",
+"value": [
+"10bd43b5-3204-4695-9225-91064f6c77b3"
+]
+}
+
Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added
On 29.4.2014 16:30, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 17:16:48 +0200 Misnyovszki Adam wrote: Hi, this patch adds some static test data for the webui otptoken part. Adam Attached corrected DN's. Thanks Adam 1) Why otptoken_batch_del.json ends with error? Also there might be a defect in UI that for batch delete operation it asks for batch.json and not $ENTITY_batch_del.json making otptoken_batch_del.json unused - out of scope of this patch. 2) Why otptoken_mod.json ends with error? 3) otptoken_find.json is not needed since the search facet uses paging (combination of otptoken_get_records.json and otptoken_find_pkeys.json is enough). In general, it's OK to fake the data if there is some bug which causes errors and we know that it will be fixed. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added
On Fri, 25 Apr 2014 17:16:48 +0200
Misnyovszki Adam wrote:
> Hi,
> this patch adds some static test data for the webui otptoken part.
> Adam
Attached corrected DN's.
Thanks
Adam>From e5816ae2dca48841c7c3b3edf591257b89fcb49b Mon Sep 17 00:00:00 2001
From: Adam Misnyovszki
Date: Fri, 25 Apr 2014 16:33:11 +0200
Subject: [PATCH] webui OTP token test data added
---
install/ui/test/data/otptoken_add.json | 43 +++
install/ui/test/data/otptoken_batch_del.json | 14 +++
install/ui/test/data/otptoken_batch_mod.json | 34 +++
install/ui/test/data/otptoken_del.json | 11 +
install/ui/test/data/otptoken_find.json| 54
install/ui/test/data/otptoken_find_pkeys.json | 17
install/ui/test/data/otptoken_get_records.json | 57 ++
install/ui/test/data/otptoken_mod.json | 8
install/ui/test/data/otptoken_show.json| 51 +++
9 files changed, 289 insertions(+)
create mode 100644 install/ui/test/data/otptoken_add.json
create mode 100644 install/ui/test/data/otptoken_batch_del.json
create mode 100644 install/ui/test/data/otptoken_batch_mod.json
create mode 100644 install/ui/test/data/otptoken_del.json
create mode 100644 install/ui/test/data/otptoken_find.json
create mode 100644 install/ui/test/data/otptoken_find_pkeys.json
create mode 100644 install/ui/test/data/otptoken_get_records.json
create mode 100644 install/ui/test/data/otptoken_mod.json
create mode 100644 install/ui/test/data/otptoken_show.json
diff --git a/install/ui/test/data/otptoken_add.json b/install/ui/test/data/otptoken_add.json
new file mode 100644
index ..96170d4419ef92ed2f7768ec023c26b35e14548d
--- /dev/null
+++ b/install/ui/test/data/otptoken_add.json
@@ -0,0 +1,43 @@
+{
+"error": null,
+"id": null,
+"result": {
+"result": {
+"dn": "ipatokenuniqueid=footoken,cn=otp,dc=example,dc=com",
+"ipatokenmodel": [
+"totp"
+],
+"ipatokenotpalgorithm": [
+"sha1"
+],
+"ipatokenotpdigits": [
+"6"
+],
+"ipatokenotpkey": [
+{
+"__base64__": "2TUYXOVTaZf/Og=="
+}
+],
+"ipatokentotpclockoffset": [
+"0"
+],
+"ipatokentotptimestep": [
+"30"
+],
+"ipatokenuniqueid": [
+"footoken"
+],
+"ipatokenvendor": [
+"FreeIPA"
+],
+"objectclass": [
+"top",
+"ipatokentotp",
+"ipatoken"
+],
+"uri": "otpauth://totp/EXAMPLE.COM:footoken?digits=6&secret=3E2RQXHFKNUZP7Z2&period=30&algorithm=sha1&issuer=EXAMPLE.COM"
+},
+"summary": "Added OTP token \"footoken\"",
+"value": "footoken"
+}
+}
diff --git a/install/ui/test/data/otptoken_batch_del.json b/install/ui/test/data/otptoken_batch_del.json
new file mode 100644
index ..8fb6d701d2f4741922482127e54f9a9b6503d43c
--- /dev/null
+++ b/install/ui/test/data/otptoken_batch_del.json
@@ -0,0 +1,14 @@
+{
+"error": null,
+"id": null,
+"result": {
+"count": 1,
+"results": [
+{
+"error": "footoken: OTP token not found",
+"error_code": 4001,
+"error_name": "NotFound"
+}
+]
+}
+}
\ No newline at end of file
diff --git a/install/ui/test/data/otptoken_batch_mod.json b/install/ui/test/data/otptoken_batch_mod.json
new file mode 100644
index ..63b99b684ee2ee8aaede06f4f5f6d8080c71fe8c
--- /dev/null
+++ b/install/ui/test/data/otptoken_batch_mod.json
@@ -0,0 +1,34 @@
+{
+"error": null,
+"id": null,
+"result": {
+"count": 1,
+"results": [
+{
+"error": null,
+"result": {
+"description": [
+"Description"
+],
+"ipatokendisabled": [
+"FALSE"
+],
+"ipatokenmodel": [
+"totp"
+],
+"ipatokenowner": [
+"admin"
+],
+"ipatokenuniqueid": [
+"10bd43b5-3204-4695-9225-91064f6c77b3"
+],
+"ipatokenvendor": [
+"FreeIPA"
+]
+},
+"summary": "Modified OTP token \"10bd43b5-3204-4695-9225-91064f6c77b3\"",
+"value": "10bd43b5-3204-4695-9225-91064f6c77b3"
+}
+]
+}
+}
\ No newline at end
[Freeipa-devel] [PATCH] 18 webui otptoken test data added
Hi,
this patch adds some static test data for the webui otptoken part.
Adam>From a119f23cde594a0c9a4a2bf3cb91d259c5ce06b1 Mon Sep 17 00:00:00 2001
From: Adam Misnyovszki
Date: Fri, 25 Apr 2014 16:33:11 +0200
Subject: [PATCH] webui OTP token test data added
---
install/ui/test/data/otptoken_add.json | 43 +++
install/ui/test/data/otptoken_batch_del.json | 14 +++
install/ui/test/data/otptoken_batch_mod.json | 34 +++
install/ui/test/data/otptoken_del.json | 11 +
install/ui/test/data/otptoken_find.json| 54
install/ui/test/data/otptoken_find_pkeys.json | 17
install/ui/test/data/otptoken_get_records.json | 57 ++
install/ui/test/data/otptoken_mod.json | 9
install/ui/test/data/otptoken_show.json| 51 +++
9 files changed, 290 insertions(+)
create mode 100644 install/ui/test/data/otptoken_add.json
create mode 100644 install/ui/test/data/otptoken_batch_del.json
create mode 100644 install/ui/test/data/otptoken_batch_mod.json
create mode 100644 install/ui/test/data/otptoken_del.json
create mode 100644 install/ui/test/data/otptoken_find.json
create mode 100644 install/ui/test/data/otptoken_find_pkeys.json
create mode 100644 install/ui/test/data/otptoken_get_records.json
create mode 100644 install/ui/test/data/otptoken_mod.json
create mode 100644 install/ui/test/data/otptoken_show.json
diff --git a/install/ui/test/data/otptoken_add.json b/install/ui/test/data/otptoken_add.json
new file mode 100644
index ..5b20d1271c51d6afc5ff80cdcab580be89ccb231
--- /dev/null
+++ b/install/ui/test/data/otptoken_add.json
@@ -0,0 +1,43 @@
+{
+"error": null,
+"id": null,
+"result": {
+"result": {
+"dn": "ipatokenuniqueid=footoken,cn=otp,dc=idm,dc=lab,dc=eng,dc=brq,dc=redhat,dc=com",
+"ipatokenmodel": [
+"totp"
+],
+"ipatokenotpalgorithm": [
+"sha1"
+],
+"ipatokenotpdigits": [
+"6"
+],
+"ipatokenotpkey": [
+{
+"__base64__": "2TUYXOVTaZf/Og=="
+}
+],
+"ipatokentotpclockoffset": [
+"0"
+],
+"ipatokentotptimestep": [
+"30"
+],
+"ipatokenuniqueid": [
+"footoken"
+],
+"ipatokenvendor": [
+"FreeIPA"
+],
+"objectclass": [
+"top",
+"ipatokentotp",
+"ipatoken"
+],
+"uri": "otpauth://totp/IDM.LAB.ENG.BRQ.REDHAT.COM:footoken?digits=6&secret=3E2RQXHFKNUZP7Z2&period=30&algorithm=sha1&issuer=IDM.LAB.ENG.BRQ.REDHAT.COM"
+},
+"summary": "Added OTP token \"footoken\"",
+"value": "footoken"
+}
+}
\ No newline at end of file
diff --git a/install/ui/test/data/otptoken_batch_del.json b/install/ui/test/data/otptoken_batch_del.json
new file mode 100644
index ..8fb6d701d2f4741922482127e54f9a9b6503d43c
--- /dev/null
+++ b/install/ui/test/data/otptoken_batch_del.json
@@ -0,0 +1,14 @@
+{
+"error": null,
+"id": null,
+"result": {
+"count": 1,
+"results": [
+{
+"error": "footoken: OTP token not found",
+"error_code": 4001,
+"error_name": "NotFound"
+}
+]
+}
+}
\ No newline at end of file
diff --git a/install/ui/test/data/otptoken_batch_mod.json b/install/ui/test/data/otptoken_batch_mod.json
new file mode 100644
index ..63b99b684ee2ee8aaede06f4f5f6d8080c71fe8c
--- /dev/null
+++ b/install/ui/test/data/otptoken_batch_mod.json
@@ -0,0 +1,34 @@
+{
+"error": null,
+"id": null,
+"result": {
+"count": 1,
+"results": [
+{
+"error": null,
+"result": {
+"description": [
+"Description"
+],
+"ipatokendisabled": [
+"FALSE"
+],
+"ipatokenmodel": [
+"totp"
+],
+"ipatokenowner": [
+"admin"
+],
+"ipatokenuniqueid": [
+"10bd43b5-3204-4695-9225-91064f6c77b3"
+],
+"ipatokenvendor": [
+"FreeIPA"
+]
+},
+"summary": "Modified OTP token \"10bd43b5-3204-4695-9225-91064f6c77b3\"",
+"value": "10bd43b5-3204-4695-9225-91064f6c77b3"
+}
+]
+}
+}
\ No newline at end of file
diff --git
