Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests

2016-07-22 Thread Ganna Kaihorodova 
Hello!

Thank you!

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


- Original Message -
From: "Martin Basti" 
To: "Ganna Kaihorodova" 
Cc: freeipa-devel@redhat.com
Sent: Thursday, July 21, 2016 8:03:53 PM
Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests



On 20.07.2016 18:17, Ganna Kaihorodova wrote:
> Hello!
>
> Thank you for review.
> I attached patch with fixed commit message
>
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
>
>
> - Original Message -
> From: "Martin Basti" 
> To: "Ganna Kaihorodova" , freeipa-devel@redhat.com
> Sent: Wednesday, July 20, 2016 5:04:47 PM
> Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin 
> tests
>
>
>
> On 20.07.2016 17:02, Ganna Kaihorodova wrote:
>> Greetings!
>>
>> Fix for ipatests/test_xmlrpc/test_dns_plugin.py
>>
>> Fix conflict between “got” and “expected” values when testing 
>> "dnsconfig_mod: Update global DNS settings"
>>
>> Best regards,
>> Ganna Kaihorodova
>> Associate Software Quality Engineer
>>
>>
>>
>>
> LGTM, but can you fix commit message?
>
> This looks very suspicious
>
> Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
>=?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
>=?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
>
> regards,
> Martin^2
ACK

I just replaced some fancy unicode quotation marks with ASCII in commit 
message before push

Pushed to master: 359cfeb7c6798038f5638f9d0977dda351f21431


-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests

2016-07-21 Thread Martin Basti 



On 20.07.2016 18:17, Ganna Kaihorodova wrote:

Hello!

Thank you for review.
I attached patch with fixed commit message


Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


- Original Message -
From: "Martin Basti" 
To: "Ganna Kaihorodova" , freeipa-devel@redhat.com
Sent: Wednesday, July 20, 2016 5:04:47 PM
Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests



On 20.07.2016 17:02, Ganna Kaihorodova wrote:

Greetings!

Fix for ipatests/test_xmlrpc/test_dns_plugin.py

Fix conflict between “got” and “expected” values when testing "dnsconfig_mod: Update 
global DNS settings"

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer





LGTM, but can you fix commit message?

This looks very suspicious

Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
   =?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
   =?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


regards,
Martin^2

ACK

I just replaced some fancy unicode quotation marks with ASCII in commit 
message before push


Pushed to master: 359cfeb7c6798038f5638f9d0977dda351f21431

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests

2016-07-20 Thread Ganna Kaihorodova 
Hello!

Thank you for review. 
I attached patch with fixed commit message


Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


- Original Message -
From: "Martin Basti" 
To: "Ganna Kaihorodova" , freeipa-devel@redhat.com
Sent: Wednesday, July 20, 2016 5:04:47 PM
Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests



On 20.07.2016 17:02, Ganna Kaihorodova wrote:
> Greetings!
>
> Fix for ipatests/test_xmlrpc/test_dns_plugin.py
>
> Fix conflict between “got” and “expected” values when testing "dnsconfig_mod: 
> Update global DNS settings"
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
>
>
>
>
LGTM, but can you fix commit message?

This looks very suspicious

Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
  =?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
  =?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


regards,
Martin^2
From 94899bbb538129384a7faa22be1228e2fcd453cf Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova 
Date: Mon, 18 Jul 2016 19:20:51 +0200
Subject: [PATCH 2/2] Fix conflict between “got” and “expected” values

Fix conflict between “got” and “expected” values when testing "dnsconfig_mod:
Update global DNS settings"

---
 ipatests/test_xmlrpc/test_dns_plugin.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index 038d17e9debc86a8e9afcadcea30e7cee29bbd05..fd32ef24beeaa245e829554fb7a6da173f6624bc 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -1781,6 +1781,7 @@ class test_dns(Declarative):
  }},
 ),
 'result': {
+'dns_server_server': [api.env.host],
 'idnsforwarders': [fwd_ip],
 },
 },
@@ -1792,7 +1793,7 @@ class test_dns(Declarative):
 expected={
 'value': None,
 'summary': u'Global DNS configuration is empty',
-'result': {},
+'result': {'dns_server_server': [api.env.host]},
 },
 ),

--
2.7.4

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests

2016-07-20 Thread Martin Basti 



On 20.07.2016 17:02, Ganna Kaihorodova wrote:

Greetings!

Fix for ipatests/test_xmlrpc/test_dns_plugin.py

Fix conflict between “got” and “expected” values when testing "dnsconfig_mod: Update 
global DNS settings"

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer





LGTM, but can you fix commit message?

This looks very suspicious

Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
 =?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
 =?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


regards,
Martin^2
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests

2016-07-20 Thread Ganna Kaihorodova 
Greetings!

Fix for ipatests/test_xmlrpc/test_dns_plugin.py

Fix conflict between “got” and “expected” values when testing "dnsconfig_mod: 
Update global DNS settings"

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


From 94899bbb538129384a7faa22be1228e2fcd453cf Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova 
Date: Mon, 18 Jul 2016 19:20:51 +0200
Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
 =?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
 =?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ipatests/test_xmlrpc/test_dns_plugin.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index 038d17e9debc86a8e9afcadcea30e7cee29bbd05..fd32ef24beeaa245e829554fb7a6da173f6624bc 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -1781,6 +1781,7 @@ class test_dns(Declarative):
  }},
 ),
 'result': {
+'dns_server_server': [api.env.host],
 'idnsforwarders': [fwd_ip],
 },
 },
@@ -1792,7 +1793,7 @@ class test_dns(Declarative):
 expected={
 'value': None,
 'summary': u'Global DNS configuration is empty',
-'result': {},
+'result': {'dns_server_server': [api.env.host]},
 },
 ),

--
2.7.4

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code