Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On 03/18/2015 01:10 PM, Alexander Bokovoy wrote:
On Wed, 18 Mar 2015, Tomas Babej wrote:
On 03/12/2015 01:58 PM, Alexander Bokovoy wrote:
On Thu, 12 Mar 2015, Alexander Bokovoy wrote:
On Thu, 12 Mar 2015, Petr Vobornik wrote:
On 03/06/2015 03:13 PM, Alexander Bokovoy wrote:
On Fri, 06 Mar 2015, Lukas Slebodnik wrote:
On (05/03/15 16:20), Petr Vobornik wrote:
On 03/05/2015 11:23 AM, Lukas Slebodnik wrote:
On (05/03/15 08:54), Petr Vobornik wrote:
On 02/27/2015 09:50 PM, Lukas Slebodnik wrote:
ehlo,
Please review attached patches and fix freeipa in fedora 22
ASAP.
I think the most critical is 1st patch
sh$ git grep "SSSDConfig" | grep import
install/tools/ipa-upgradeconfig:import SSSDConfig
ipa-client/ipa-install/ipa-client-automount:import SSSDConfig
ipa-client/ipa-install/ipa-client-install: import SSSDConfig
BTW package python-sssdconfig is provides since
sssd-1.10.0alpha1
(2013-04-02)
but it was not explicitely required.
The latest python3 changes in sssd (fedora 22) is just a
result of
negligent
packaging of freeipa.
LS
Fedora 22 was amended.
Patch 1: ACK
Patch 2: ACK
Patch3:
the package name is libsss_nss_idmap-python not
python-libsss_nss_idmap
which already is required in adtrust package
In sssd upstream we decided to rename package
libsss_nss_idmap-python to
python-libsss_nss_idmap according to new rpm python guidelines.
The python3 version has alredy correct name.
We will rename package in downstream with next major release
(1.13).
Of course it we will add "Provides: libsss_nss_idmap-python".
We can push 3rd patch later or I can update 3rd patch.
What do you prefer?
Than you very much for review.
LS
Patch 3 should be updated to not forget the remaining change in
ipa-python
package.
It then should be updated downstream and master when 1.13 is
released in
Fedora, or in master sooner if SSSD 1.13 becomes the minimal
version
required
by master.
Fixed.
BTW Why ther is a pylint comment for some sssd modules
I did not kave any pylint problems after removing comment.
ipalib/plugins/trust.py:32:import pysss_murmur #pylint:
disable=F0401
ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint:
disable=F0401
And why are these modules optional (try except)
Because they are needed to properly load in the case trust
subpackages
are not installed, to generate proper messages to users who will try
these commands, like 'ipa trust-add' while the infrastructure is
not in
place.
pylint is dumb for such cases.
Alexander, the point was not to require python_nss_idmap and
python-sss-murmur on ipa clients?
Pylint is not used on ipa clients. The import statements do protection
against failed import and that's what we use on the client side.
If so python-sss-murmur should be required only by trust-ad
package and not python package (patch2). And patch 3 (adding
libsss_nss_idmap-python to python package) should not be used.
We already have dependencies in trust-ad subpackage:
%package server-trust-ad
Summary: Virtual package to install packages required for Active
Directory trusts
Group: System Environment/Base
Requires: %{name}-server = %version-%release
Requires: m2crypto
Requires: samba-python
Requires: samba >= %{samba_version}
Requires: samba-winbind
Requires: libsss_idmap
Requires: libsss_nss_idmap-python
However, we don't ship the original plugins in this package because
otherwise you wouldn't be able to use 'ipa trust*' from any machine
other than those where trust-ad subpackage is installed. That's why we
use import statements and catch the import exceptions.
Sent too early.
... and python-sss-murmur shoudl be required by trust-ad subpackage,
yes.
So what is the resolution here? Can we push patches 1 & 2?
ACK to patches 1 and 2.
Pushed to master: 6ce47d86db77373b15bb62a92b22dd2accc74b37
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On Wed, 18 Mar 2015, Tomas Babej wrote:
On 03/12/2015 01:58 PM, Alexander Bokovoy wrote:
On Thu, 12 Mar 2015, Alexander Bokovoy wrote:
On Thu, 12 Mar 2015, Petr Vobornik wrote:
On 03/06/2015 03:13 PM, Alexander Bokovoy wrote:
On Fri, 06 Mar 2015, Lukas Slebodnik wrote:
On (05/03/15 16:20), Petr Vobornik wrote:
On 03/05/2015 11:23 AM, Lukas Slebodnik wrote:
On (05/03/15 08:54), Petr Vobornik wrote:
On 02/27/2015 09:50 PM, Lukas Slebodnik wrote:
ehlo,
Please review attached patches and fix freeipa in fedora 22 ASAP.
I think the most critical is 1st patch
sh$ git grep "SSSDConfig" | grep import
install/tools/ipa-upgradeconfig:import SSSDConfig
ipa-client/ipa-install/ipa-client-automount:import SSSDConfig
ipa-client/ipa-install/ipa-client-install: import SSSDConfig
BTW package python-sssdconfig is provides since sssd-1.10.0alpha1
(2013-04-02)
but it was not explicitely required.
The latest python3 changes in sssd (fedora 22) is
just a result of
negligent
packaging of freeipa.
LS
Fedora 22 was amended.
Patch 1: ACK
Patch 2: ACK
Patch3:
the package name is libsss_nss_idmap-python not
python-libsss_nss_idmap
which already is required in adtrust package
In sssd upstream we decided to rename package
libsss_nss_idmap-python to
python-libsss_nss_idmap according to new rpm python guidelines.
The python3 version has alredy correct name.
We will rename package in downstream with next major
release (1.13).
Of course it we will add "Provides: libsss_nss_idmap-python".
We can push 3rd patch later or I can update 3rd patch.
What do you prefer?
Than you very much for review.
LS
Patch 3 should be updated to not forget the remaining change in
ipa-python
package.
It then should be updated downstream and master when 1.13
is released in
Fedora, or in master sooner if SSSD 1.13 becomes the minimal version
required
by master.
Fixed.
BTW Why ther is a pylint comment for some sssd modules
I did not kave any pylint problems after removing comment.
ipalib/plugins/trust.py:32:import pysss_murmur #pylint:
disable=F0401
ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint:
disable=F0401
And why are these modules optional (try except)
Because they are needed to properly load in the case trust subpackages
are not installed, to generate proper messages to users who will try
these commands, like 'ipa trust-add' while the infrastructure
is not in
place.
pylint is dumb for such cases.
Alexander, the point was not to require python_nss_idmap and
python-sss-murmur on ipa clients?
Pylint is not used on ipa clients. The import statements do protection
against failed import and that's what we use on the client side.
If so python-sss-murmur should be required only by trust-ad
package and not python package (patch2). And patch 3 (adding
libsss_nss_idmap-python to python package) should not be used.
We already have dependencies in trust-ad subpackage:
%package server-trust-ad
Summary: Virtual package to install packages required for Active
Directory trusts
Group: System Environment/Base
Requires: %{name}-server = %version-%release
Requires: m2crypto
Requires: samba-python
Requires: samba >= %{samba_version}
Requires: samba-winbind
Requires: libsss_idmap
Requires: libsss_nss_idmap-python
However, we don't ship the original plugins in this package because
otherwise you wouldn't be able to use 'ipa trust*' from any machine
other than those where trust-ad subpackage is installed. That's why we
use import statements and catch the import exceptions.
Sent too early.
... and python-sss-murmur shoudl be required by trust-ad subpackage,
yes.
So what is the resolution here? Can we push patches 1 & 2?
ACK to patches 1 and 2.
--
/ Alexander Bokovoy
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On 03/12/2015 01:58 PM, Alexander Bokovoy wrote:
On Thu, 12 Mar 2015, Alexander Bokovoy wrote:
On Thu, 12 Mar 2015, Petr Vobornik wrote:
On 03/06/2015 03:13 PM, Alexander Bokovoy wrote:
On Fri, 06 Mar 2015, Lukas Slebodnik wrote:
On (05/03/15 16:20), Petr Vobornik wrote:
On 03/05/2015 11:23 AM, Lukas Slebodnik wrote:
On (05/03/15 08:54), Petr Vobornik wrote:
On 02/27/2015 09:50 PM, Lukas Slebodnik wrote:
ehlo,
Please review attached patches and fix freeipa in fedora 22 ASAP.
I think the most critical is 1st patch
sh$ git grep "SSSDConfig" | grep import
install/tools/ipa-upgradeconfig:import SSSDConfig
ipa-client/ipa-install/ipa-client-automount:import SSSDConfig
ipa-client/ipa-install/ipa-client-install: import SSSDConfig
BTW package python-sssdconfig is provides since sssd-1.10.0alpha1
(2013-04-02)
but it was not explicitely required.
The latest python3 changes in sssd (fedora 22) is just a
result of
negligent
packaging of freeipa.
LS
Fedora 22 was amended.
Patch 1: ACK
Patch 2: ACK
Patch3:
the package name is libsss_nss_idmap-python not
python-libsss_nss_idmap
which already is required in adtrust package
In sssd upstream we decided to rename package
libsss_nss_idmap-python to
python-libsss_nss_idmap according to new rpm python guidelines.
The python3 version has alredy correct name.
We will rename package in downstream with next major release
(1.13).
Of course it we will add "Provides: libsss_nss_idmap-python".
We can push 3rd patch later or I can update 3rd patch.
What do you prefer?
Than you very much for review.
LS
Patch 3 should be updated to not forget the remaining change in
ipa-python
package.
It then should be updated downstream and master when 1.13 is
released in
Fedora, or in master sooner if SSSD 1.13 becomes the minimal version
required
by master.
Fixed.
BTW Why ther is a pylint comment for some sssd modules
I did not kave any pylint problems after removing comment.
ipalib/plugins/trust.py:32:import pysss_murmur #pylint:
disable=F0401
ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint:
disable=F0401
And why are these modules optional (try except)
Because they are needed to properly load in the case trust subpackages
are not installed, to generate proper messages to users who will try
these commands, like 'ipa trust-add' while the infrastructure is
not in
place.
pylint is dumb for such cases.
Alexander, the point was not to require python_nss_idmap and
python-sss-murmur on ipa clients?
Pylint is not used on ipa clients. The import statements do protection
against failed import and that's what we use on the client side.
If so python-sss-murmur should be required only by trust-ad package
and not python package (patch2). And patch 3 (adding
libsss_nss_idmap-python to python package) should not be used.
We already have dependencies in trust-ad subpackage:
%package server-trust-ad
Summary: Virtual package to install packages required for Active
Directory trusts
Group: System Environment/Base
Requires: %{name}-server = %version-%release
Requires: m2crypto
Requires: samba-python
Requires: samba >= %{samba_version}
Requires: samba-winbind
Requires: libsss_idmap
Requires: libsss_nss_idmap-python
However, we don't ship the original plugins in this package because
otherwise you wouldn't be able to use 'ipa trust*' from any machine
other than those where trust-ad subpackage is installed. That's why we
use import statements and catch the import exceptions.
Sent too early.
... and python-sss-murmur shoudl be required by trust-ad subpackage,
yes.
So what is the resolution here? Can we push patches 1 & 2?
Tomas
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On Thu, 12 Mar 2015, Alexander Bokovoy wrote:
On Thu, 12 Mar 2015, Petr Vobornik wrote:
On 03/06/2015 03:13 PM, Alexander Bokovoy wrote:
On Fri, 06 Mar 2015, Lukas Slebodnik wrote:
On (05/03/15 16:20), Petr Vobornik wrote:
On 03/05/2015 11:23 AM, Lukas Slebodnik wrote:
On (05/03/15 08:54), Petr Vobornik wrote:
On 02/27/2015 09:50 PM, Lukas Slebodnik wrote:
ehlo,
Please review attached patches and fix freeipa in fedora 22 ASAP.
I think the most critical is 1st patch
sh$ git grep "SSSDConfig" | grep import
install/tools/ipa-upgradeconfig:import SSSDConfig
ipa-client/ipa-install/ipa-client-automount:import SSSDConfig
ipa-client/ipa-install/ipa-client-install:import SSSDConfig
BTW package python-sssdconfig is provides since sssd-1.10.0alpha1
(2013-04-02)
but it was not explicitely required.
The latest python3 changes in sssd (fedora 22) is just a result of
negligent
packaging of freeipa.
LS
Fedora 22 was amended.
Patch 1: ACK
Patch 2: ACK
Patch3:
the package name is libsss_nss_idmap-python not
python-libsss_nss_idmap
which already is required in adtrust package
In sssd upstream we decided to rename package
libsss_nss_idmap-python to
python-libsss_nss_idmap according to new rpm python guidelines.
The python3 version has alredy correct name.
We will rename package in downstream with next major release (1.13).
Of course it we will add "Provides: libsss_nss_idmap-python".
We can push 3rd patch later or I can update 3rd patch.
What do you prefer?
Than you very much for review.
LS
Patch 3 should be updated to not forget the remaining change in
ipa-python
package.
It then should be updated downstream and master when 1.13 is released in
Fedora, or in master sooner if SSSD 1.13 becomes the minimal version
required
by master.
Fixed.
BTW Why ther is a pylint comment for some sssd modules
I did not kave any pylint problems after removing comment.
ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401
ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint:
disable=F0401
And why are these modules optional (try except)
Because they are needed to properly load in the case trust subpackages
are not installed, to generate proper messages to users who will try
these commands, like 'ipa trust-add' while the infrastructure is not in
place.
pylint is dumb for such cases.
Alexander, the point was not to require python_nss_idmap and
python-sss-murmur on ipa clients?
Pylint is not used on ipa clients. The import statements do protection
against failed import and that's what we use on the client side.
If so python-sss-murmur should be required only by trust-ad package
and not python package (patch2). And patch 3 (adding
libsss_nss_idmap-python to python package) should not be used.
We already have dependencies in trust-ad subpackage:
%package server-trust-ad
Summary: Virtual package to install packages required for Active Directory
trusts
Group: System Environment/Base
Requires: %{name}-server = %version-%release
Requires: m2crypto
Requires: samba-python
Requires: samba >= %{samba_version}
Requires: samba-winbind
Requires: libsss_idmap
Requires: libsss_nss_idmap-python
However, we don't ship the original plugins in this package because
otherwise you wouldn't be able to use 'ipa trust*' from any machine
other than those where trust-ad subpackage is installed. That's why we
use import statements and catch the import exceptions.
Sent too early.
... and python-sss-murmur shoudl be required by trust-ad subpackage,
yes.
--
/ Alexander Bokovoy
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On Thu, 12 Mar 2015, Petr Vobornik wrote:
On 03/06/2015 03:13 PM, Alexander Bokovoy wrote:
On Fri, 06 Mar 2015, Lukas Slebodnik wrote:
On (05/03/15 16:20), Petr Vobornik wrote:
On 03/05/2015 11:23 AM, Lukas Slebodnik wrote:
On (05/03/15 08:54), Petr Vobornik wrote:
On 02/27/2015 09:50 PM, Lukas Slebodnik wrote:
ehlo,
Please review attached patches and fix freeipa in fedora 22 ASAP.
I think the most critical is 1st patch
sh$ git grep "SSSDConfig" | grep import
install/tools/ipa-upgradeconfig:import SSSDConfig
ipa-client/ipa-install/ipa-client-automount:import SSSDConfig
ipa-client/ipa-install/ipa-client-install:import SSSDConfig
BTW package python-sssdconfig is provides since sssd-1.10.0alpha1
(2013-04-02)
but it was not explicitely required.
The latest python3 changes in sssd (fedora 22) is just a result of
negligent
packaging of freeipa.
LS
Fedora 22 was amended.
Patch 1: ACK
Patch 2: ACK
Patch3:
the package name is libsss_nss_idmap-python not
python-libsss_nss_idmap
which already is required in adtrust package
In sssd upstream we decided to rename package
libsss_nss_idmap-python to
python-libsss_nss_idmap according to new rpm python guidelines.
The python3 version has alredy correct name.
We will rename package in downstream with next major release (1.13).
Of course it we will add "Provides: libsss_nss_idmap-python".
We can push 3rd patch later or I can update 3rd patch.
What do you prefer?
Than you very much for review.
LS
Patch 3 should be updated to not forget the remaining change in
ipa-python
package.
It then should be updated downstream and master when 1.13 is released in
Fedora, or in master sooner if SSSD 1.13 becomes the minimal version
required
by master.
Fixed.
BTW Why ther is a pylint comment for some sssd modules
I did not kave any pylint problems after removing comment.
ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401
ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint:
disable=F0401
And why are these modules optional (try except)
Because they are needed to properly load in the case trust subpackages
are not installed, to generate proper messages to users who will try
these commands, like 'ipa trust-add' while the infrastructure is not in
place.
pylint is dumb for such cases.
Alexander, the point was not to require python_nss_idmap and
python-sss-murmur on ipa clients?
Pylint is not used on ipa clients. The import statements do protection
against failed import and that's what we use on the client side.
If so python-sss-murmur should be required only by trust-ad package
and not python package (patch2). And patch 3 (adding
libsss_nss_idmap-python to python package) should not be used.
We already have dependencies in trust-ad subpackage:
%package server-trust-ad
Summary: Virtual package to install packages required for Active Directory
trusts
Group: System Environment/Base
Requires: %{name}-server = %version-%release
Requires: m2crypto
Requires: samba-python
Requires: samba >= %{samba_version}
Requires: samba-winbind
Requires: libsss_idmap
Requires: libsss_nss_idmap-python
However, we don't ship the original plugins in this package because
otherwise you wouldn't be able to use 'ipa trust*' from any machine
other than those where trust-ad subpackage is installed. That's why we
use import statements and catch the import exceptions.
--
/ Alexander Bokovoy
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I think the most critical is 1st patch sh$ git grep "SSSDConfig" | grep import install/tools/ipa-upgradeconfig:import SSSDConfig ipa-client/ipa-install/ipa-client-automount:import SSSDConfig ipa-client/ipa-install/ipa-client-install:import SSSDConfig BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 (2013-04-02) but it was not explicitely required. The latest python3 changes in sssd (fedora 22) is just a result of negligent packaging of freeipa. LS Fedora 22 was amended. Patch 1: ACK Patch 2: ACK Patch3: the package name is libsss_nss_idmap-python not python-libsss_nss_idmap which already is required in adtrust package In sssd upstream we decided to rename package libsss_nss_idmap-python to python-libsss_nss_idmap according to new rpm python guidelines. The python3 version has alredy correct name. We will rename package in downstream with next major release (1.13). Of course it we will add "Provides: libsss_nss_idmap-python". We can push 3rd patch later or I can update 3rd patch. What do you prefer? Than you very much for review. LS Patch 3 should be updated to not forget the remaining change in ipa-python package. It then should be updated downstream and master when 1.13 is released in Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required by master. Fixed. BTW Why ther is a pylint comment for some sssd modules I did not kave any pylint problems after removing comment. ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401 ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401 And why are these modules optional (try except) Because they are needed to properly load in the case trust subpackages are not installed, to generate proper messages to users who will try these commands, like 'ipa trust-add' while the infrastructure is not in place. pylint is dumb for such cases. Alexander, the point was not to require python_nss_idmap and python-sss-murmur on ipa clients? If so python-sss-murmur should be required only by trust-ad package and not python package (patch2). And patch 3 (adding libsss_nss_idmap-python to python package) should not be used. -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On (06/03/15 15:05), Lukas Slebodnik wrote: >On (05/03/15 16:20), Petr Vobornik wrote: >>On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: >>>On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: >ehlo, > >Please review attached patches and fix freeipa in fedora 22 ASAP. > >I think the most critical is 1st patch > >sh$ git grep "SSSDConfig" | grep import >install/tools/ipa-upgradeconfig:import SSSDConfig >ipa-client/ipa-install/ipa-client-automount:import SSSDConfig >ipa-client/ipa-install/ipa-client-install:import SSSDConfig > >BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 >(2013-04-02) >but it was not explicitely required. > >The latest python3 changes in sssd (fedora 22) is just a result of >negligent >packaging of freeipa. > >LS > Fedora 22 was amended. Patch 1: ACK Patch 2: ACK Patch3: the package name is libsss_nss_idmap-python not python-libsss_nss_idmap which already is required in adtrust package >>>In sssd upstream we decided to rename package libsss_nss_idmap-python to >>>python-libsss_nss_idmap according to new rpm python guidelines. >>>The python3 version has alredy correct name. >>> >>>We will rename package in downstream with next major release (1.13). >>>Of course it we will add "Provides: libsss_nss_idmap-python". >>> >>>We can push 3rd patch later or I can update 3rd patch. >>>What do you prefer? >>> >>>Than you very much for review. >>> >>>LS >>> >> >>Patch 3 should be updated to not forget the remaining change in ipa-python >>package. >> >>It then should be updated downstream and master when 1.13 is released in >>Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required >>by master. > >Fixed. > >BTW Why ther is a pylint comment for some sssd modules >I did not kave any pylint problems after removing comment. > >ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401 >ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401 > > >And why are these modules optional (try except) > >ipalib/plugins/trust.py-31-try: >ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401 >ipalib/plugins/trust.py-33-_murmur_installed = True >ipalib/plugins/trust.py-34-except Exception, e: >ipalib/plugins/trust.py-35-_murmur_installed = False >ipalib/plugins/trust.py-36- >ipalib/plugins/trust.py-37-try: >ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401 >ipalib/plugins/trust.py-39-_nss_idmap_installed = True >ipalib/plugins/trust.py-40-except Exception, e: >ipalib/plugins/trust.py-41-_nss_idmap_installed = False > >LS >>From 41523fd6ab9ea95644cac1a6cd20386a620a1df5 Mon Sep 17 00:00:00 2001 >From: Lukas Slebodnik >Date: Fri, 27 Feb 2015 20:40:06 +0100 >Subject: [PATCH 1/3] SPEC: Explicitly requires python-sssdconfig bump LS -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (06/03/15 16:13), Alexander Bokovoy wrote: On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I think the most critical is 1st patch sh$ git grep "SSSDConfig" | grep import install/tools/ipa-upgradeconfig:import SSSDConfig ipa-client/ipa-install/ipa-client-automount:import SSSDConfig ipa-client/ipa-install/ipa-client-install:import SSSDConfig BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 (2013-04-02) but it was not explicitely required. The latest python3 changes in sssd (fedora 22) is just a result of negligent packaging of freeipa. LS Fedora 22 was amended. Patch 1: ACK Patch 2: ACK Patch3: the package name is libsss_nss_idmap-python not python-libsss_nss_idmap which already is required in adtrust package In sssd upstream we decided to rename package libsss_nss_idmap-python to python-libsss_nss_idmap according to new rpm python guidelines. The python3 version has alredy correct name. We will rename package in downstream with next major release (1.13). Of course it we will add "Provides: libsss_nss_idmap-python". We can push 3rd patch later or I can update 3rd patch. What do you prefer? Than you very much for review. LS Patch 3 should be updated to not forget the remaining change in ipa-python package. It then should be updated downstream and master when 1.13 is released in Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required by master. Fixed. BTW Why ther is a pylint comment for some sssd modules I did not kave any pylint problems after removing comment. ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401 ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401 And why are these modules optional (try except) Because they are needed to properly load in the case trust subpackages are not installed, to generate proper messages to users who will try these commands, like 'ipa trust-add' while the infrastructure is not in place. pylint is dumb for such cases. Yes but my patches added requires to all necessary packages. How can I get pylint warning? I modified spec file and make-lint was called in "%check" phase. and I did not have any pylint problems in mock. If you don't have those packages installed, it will complain. -- / Alexander Bokovoy -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On (06/03/15 16:13), Alexander Bokovoy wrote: >On Fri, 06 Mar 2015, Lukas Slebodnik wrote: >>On (05/03/15 16:20), Petr Vobornik wrote: >>>On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: >On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: >>ehlo, >> >>Please review attached patches and fix freeipa in fedora 22 ASAP. >> >>I think the most critical is 1st patch >> >>sh$ git grep "SSSDConfig" | grep import >>install/tools/ipa-upgradeconfig:import SSSDConfig >>ipa-client/ipa-install/ipa-client-automount:import SSSDConfig >>ipa-client/ipa-install/ipa-client-install:import SSSDConfig >> >>BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 >>(2013-04-02) >>but it was not explicitely required. >> >>The latest python3 changes in sssd (fedora 22) is just a result of >>negligent >>packaging of freeipa. >> >>LS >> > >Fedora 22 was amended. > >Patch 1: ACK > >Patch 2: ACK > >Patch3: >the package name is libsss_nss_idmap-python not python-libsss_nss_idmap >which already is required in adtrust package In sssd upstream we decided to rename package libsss_nss_idmap-python to python-libsss_nss_idmap according to new rpm python guidelines. The python3 version has alredy correct name. We will rename package in downstream with next major release (1.13). Of course it we will add "Provides: libsss_nss_idmap-python". We can push 3rd patch later or I can update 3rd patch. What do you prefer? Than you very much for review. LS >>> >>>Patch 3 should be updated to not forget the remaining change in ipa-python >>>package. >>> >>>It then should be updated downstream and master when 1.13 is released in >>>Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required >>>by master. >> >>Fixed. >> >>BTW Why ther is a pylint comment for some sssd modules >>I did not kave any pylint problems after removing comment. >> >>ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401 >>ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401 >> >> >>And why are these modules optional (try except) >Because they are needed to properly load in the case trust subpackages >are not installed, to generate proper messages to users who will try >these commands, like 'ipa trust-add' while the infrastructure is not in >place. > >pylint is dumb for such cases. > Yes but my patches added requires to all necessary packages. How can I get pylint warning? I modified spec file and make-lint was called in "%check" phase. and I did not have any pylint problems in mock. LS -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I think the most critical is 1st patch sh$ git grep "SSSDConfig" | grep import install/tools/ipa-upgradeconfig:import SSSDConfig ipa-client/ipa-install/ipa-client-automount:import SSSDConfig ipa-client/ipa-install/ipa-client-install:import SSSDConfig BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 (2013-04-02) but it was not explicitely required. The latest python3 changes in sssd (fedora 22) is just a result of negligent packaging of freeipa. LS Fedora 22 was amended. Patch 1: ACK Patch 2: ACK Patch3: the package name is libsss_nss_idmap-python not python-libsss_nss_idmap which already is required in adtrust package In sssd upstream we decided to rename package libsss_nss_idmap-python to python-libsss_nss_idmap according to new rpm python guidelines. The python3 version has alredy correct name. We will rename package in downstream with next major release (1.13). Of course it we will add "Provides: libsss_nss_idmap-python". We can push 3rd patch later or I can update 3rd patch. What do you prefer? Than you very much for review. LS Patch 3 should be updated to not forget the remaining change in ipa-python package. It then should be updated downstream and master when 1.13 is released in Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required by master. Fixed. BTW Why ther is a pylint comment for some sssd modules I did not kave any pylint problems after removing comment. ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401 ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401 And why are these modules optional (try except) Because they are needed to properly load in the case trust subpackages are not installed, to generate proper messages to users who will try these commands, like 'ipa trust-add' while the infrastructure is not in place. pylint is dumb for such cases. -- / Alexander Bokovoy -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On (05/03/15 16:20), Petr Vobornik wrote:
>On 03/05/2015 11:23 AM, Lukas Slebodnik wrote:
>>On (05/03/15 08:54), Petr Vobornik wrote:
>>>On 02/27/2015 09:50 PM, Lukas Slebodnik wrote:
ehlo,
Please review attached patches and fix freeipa in fedora 22 ASAP.
I think the most critical is 1st patch
sh$ git grep "SSSDConfig" | grep import
install/tools/ipa-upgradeconfig:import SSSDConfig
ipa-client/ipa-install/ipa-client-automount:import SSSDConfig
ipa-client/ipa-install/ipa-client-install:import SSSDConfig
BTW package python-sssdconfig is provides since sssd-1.10.0alpha1
(2013-04-02)
but it was not explicitely required.
The latest python3 changes in sssd (fedora 22) is just a result of negligent
packaging of freeipa.
LS
>>>
>>>Fedora 22 was amended.
>>>
>>>Patch 1: ACK
>>>
>>>Patch 2: ACK
>>>
>>>Patch3:
>>>the package name is libsss_nss_idmap-python not python-libsss_nss_idmap
>>>which already is required in adtrust package
>>In sssd upstream we decided to rename package libsss_nss_idmap-python to
>>python-libsss_nss_idmap according to new rpm python guidelines.
>>The python3 version has alredy correct name.
>>
>>We will rename package in downstream with next major release (1.13).
>>Of course it we will add "Provides: libsss_nss_idmap-python".
>>
>>We can push 3rd patch later or I can update 3rd patch.
>>What do you prefer?
>>
>>Than you very much for review.
>>
>>LS
>>
>
>Patch 3 should be updated to not forget the remaining change in ipa-python
>package.
>
>It then should be updated downstream and master when 1.13 is released in
>Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required
>by master.
Fixed.
BTW Why ther is a pylint comment for some sssd modules
I did not kave any pylint problems after removing comment.
ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401
ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401
And why are these modules optional (try except)
ipalib/plugins/trust.py-31-try:
ipalib/plugins/trust.py:32:import pysss_murmur #pylint: disable=F0401
ipalib/plugins/trust.py-33-_murmur_installed = True
ipalib/plugins/trust.py-34-except Exception, e:
ipalib/plugins/trust.py-35-_murmur_installed = False
ipalib/plugins/trust.py-36-
ipalib/plugins/trust.py-37-try:
ipalib/plugins/trust.py:38:import pysss_nss_idmap #pylint: disable=F0401
ipalib/plugins/trust.py-39-_nss_idmap_installed = True
ipalib/plugins/trust.py-40-except Exception, e:
ipalib/plugins/trust.py-41-_nss_idmap_installed = False
LS
>From 41523fd6ab9ea95644cac1a6cd20386a620a1df5 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Fri, 27 Feb 2015 20:40:06 +0100
Subject: [PATCH 1/3] SPEC: Explicitly requires python-sssdconfig
Resolves:
https://fedorahosted.org/freeipa/ticket/4929
---
freeipa.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index
b186d9fdff31118ea4d929f024f4dc16a75b1d0b..9513f45c6c933a1109390393cb90d68e8c697dc7
100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -122,6 +122,7 @@ Requires: mod_auth_kerb >= 5.4-16
Requires: mod_nss >= 1.0.8-26
Requires: python-ldap >= 2.4.15
Requires: python-krbV
+Requires: python-sssdconfig
Requires: acl
Requires: python-pyasn1
Requires: memcached
@@ -228,6 +229,7 @@ Requires: wget
Requires: libcurl >= 7.21.7-2
Requires: xmlrpc-c >= 1.27.4
Requires: sssd >= 1.12.3
+Requires: python-sssdconfig
Requires: certmonger >= 0.76.8
Requires: nss-tools
Requires: bind-utils
--
2.3.1
>From 69c4f4bfc911990dc7ec650c2958aaf716c53ac5 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Fri, 27 Feb 2015 20:43:38 +0100
Subject: [PATCH 2/3] SPEC: Require python2 version of sssd bindings
Python modules pysss and pysss_murmur was part of package sssd-common.
Fedora 22 tries to get rid of python2 and therefore these modules were
extracted from package sssd-common to separate packages python-sss and
python-sss-murmur and python3 version of packages python3-sss
python3-sss-murmur
git grep "pysss" | grep import
ipalib/plugins/trust.py:import pysss_murmur #pylint: disable=F0401
ipaserver/dcerpc.py:import pysss
ipaserver/dcerpc.py is pacakged in freeipa-server-trust-ad
palib/plugins/trust.py is packaged in freeipa-python
Resolves:
https://fedorahosted.org/freeipa/ticket/4929
---
freeipa.spec.in | 6 ++
1 file changed, 6 insertions(+)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index
9513f45c6c933a1109390393cb90d68e8c697dc7..7a1ff8b50ef1b462ad14fb2328149c3c2ed2fb38
100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -195,6 +195,9 @@ Requires: samba >= %{samba_version}
Requires: samba-winbind
Requires: libsss_idmap
Requires: libsss_nss_idmap-python
+%if (0%{?fedora} >= 22)
+Requires: python-sss
+%endif
# We use alternatives to divert winbind_krb5_locator.so plugin to libkrb5
# on the installes where server-trust-ad subpackage is instal
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: On (05/03/15 08:54), Petr Vobornik wrote: On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I think the most critical is 1st patch sh$ git grep "SSSDConfig" | grep import install/tools/ipa-upgradeconfig:import SSSDConfig ipa-client/ipa-install/ipa-client-automount:import SSSDConfig ipa-client/ipa-install/ipa-client-install:import SSSDConfig BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 (2013-04-02) but it was not explicitely required. The latest python3 changes in sssd (fedora 22) is just a result of negligent packaging of freeipa. LS Fedora 22 was amended. Patch 1: ACK Patch 2: ACK Patch3: the package name is libsss_nss_idmap-python not python-libsss_nss_idmap which already is required in adtrust package In sssd upstream we decided to rename package libsss_nss_idmap-python to python-libsss_nss_idmap according to new rpm python guidelines. The python3 version has alredy correct name. We will rename package in downstream with next major release (1.13). Of course it we will add "Provides: libsss_nss_idmap-python". We can push 3rd patch later or I can update 3rd patch. What do you prefer? Than you very much for review. LS Patch 3 should be updated to not forget the remaining change in ipa-python package. It then should be updated downstream and master when 1.13 is released in Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required by master. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On (05/03/15 08:54), Petr Vobornik wrote: >On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: >>ehlo, >> >>Please review attached patches and fix freeipa in fedora 22 ASAP. >> >>I think the most critical is 1st patch >> >>sh$ git grep "SSSDConfig" | grep import >>install/tools/ipa-upgradeconfig:import SSSDConfig >>ipa-client/ipa-install/ipa-client-automount:import SSSDConfig >>ipa-client/ipa-install/ipa-client-install:import SSSDConfig >> >>BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 (2013-04-02) >>but it was not explicitely required. >> >>The latest python3 changes in sssd (fedora 22) is just a result of negligent >>packaging of freeipa. >> >>LS >> > >Fedora 22 was amended. > >Patch 1: ACK > >Patch 2: ACK > >Patch3: >the package name is libsss_nss_idmap-python not python-libsss_nss_idmap >which already is required in adtrust package In sssd upstream we decided to rename package libsss_nss_idmap-python to python-libsss_nss_idmap according to new rpm python guidelines. The python3 version has alredy correct name. We will rename package in downstream with next major release (1.13). Of course it we will add "Provides: libsss_nss_idmap-python". We can push 3rd patch later or I can update 3rd patch. What do you prefer? Than you very much for review. LS ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: ehlo, Please review attached patches and fix freeipa in fedora 22 ASAP. I think the most critical is 1st patch sh$ git grep "SSSDConfig" | grep import install/tools/ipa-upgradeconfig:import SSSDConfig ipa-client/ipa-install/ipa-client-automount:import SSSDConfig ipa-client/ipa-install/ipa-client-install:import SSSDConfig BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 (2013-04-02) but it was not explicitely required. The latest python3 changes in sssd (fedora 22) is just a result of negligent packaging of freeipa. LS Fedora 22 was amended. Patch 1: ACK Patch 2: ACK Patch3: the package name is libsss_nss_idmap-python not python-libsss_nss_idmap which already is required in adtrust package -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings
ehlo,
Please review attached patches and fix freeipa in fedora 22 ASAP.
I think the most critical is 1st patch
sh$ git grep "SSSDConfig" | grep import
install/tools/ipa-upgradeconfig:import SSSDConfig
ipa-client/ipa-install/ipa-client-automount:import SSSDConfig
ipa-client/ipa-install/ipa-client-install:import SSSDConfig
BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 (2013-04-02)
but it was not explicitely required.
The latest python3 changes in sssd (fedora 22) is just a result of negligent
packaging of freeipa.
LS
>From 09bfbd420ab83f8cb571f9dc04a5cd9c7f15d604 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Fri, 27 Feb 2015 20:40:06 +0100
Subject: [PATCH 1/3] SPEC: Explicitly requires python-sssdconfig
Resolves:
https://fedorahosted.org/freeipa/ticket/4929
---
freeipa.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index
b186d9fdff31118ea4d929f024f4dc16a75b1d0b..9513f45c6c933a1109390393cb90d68e8c697dc7
100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -122,6 +122,7 @@ Requires: mod_auth_kerb >= 5.4-16
Requires: mod_nss >= 1.0.8-26
Requires: python-ldap >= 2.4.15
Requires: python-krbV
+Requires: python-sssdconfig
Requires: acl
Requires: python-pyasn1
Requires: memcached
@@ -228,6 +229,7 @@ Requires: wget
Requires: libcurl >= 7.21.7-2
Requires: xmlrpc-c >= 1.27.4
Requires: sssd >= 1.12.3
+Requires: python-sssdconfig
Requires: certmonger >= 0.76.8
Requires: nss-tools
Requires: bind-utils
--
2.1.0
>From 3efd525d72d20734d926c4e804a7080ea01cb580 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Fri, 27 Feb 2015 20:43:38 +0100
Subject: [PATCH 2/3] SPEC: Require python2 version of sssd bindings
Python modules pysss and pysss_murmur was part of package sssd-common.
Fedora 22 tries to get rid of python2 and therefore these modules were
extracted from package sssd-common to separate packages python-sss and
python-sss-murmur and python3 version of packages python3-sss
python3-sss-murmur
git grep "pysss" | grep import
ipalib/plugins/trust.py:import pysss_murmur #pylint: disable=F0401
ipaserver/dcerpc.py:import pysss
ipaserver/dcerpc.py is pacakged in freeipa-server-trust-ad
palib/plugins/trust.py is packaged in freeipa-python
Resolves:
https://fedorahosted.org/freeipa/ticket/4929
---
freeipa.spec.in | 6 ++
1 file changed, 6 insertions(+)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index
9513f45c6c933a1109390393cb90d68e8c697dc7..7a1ff8b50ef1b462ad14fb2328149c3c2ed2fb38
100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -195,6 +195,9 @@ Requires: samba >= %{samba_version}
Requires: samba-winbind
Requires: libsss_idmap
Requires: libsss_nss_idmap-python
+%if (0%{?fedora} >= 22)
+Requires: python-sss
+%endif
# We use alternatives to divert winbind_krb5_locator.so plugin to libkrb5
# on the installes where server-trust-ad subpackage is installed because
# IPA AD trusts cannot be used at the same time with the locator plugin
@@ -288,6 +291,9 @@ Requires: python-qrcode-core >= 5.0.0
Requires: python-pyasn1
Requires: python-dateutil
Requires: python-yubico
+%if (0%{?fedora} >= 22)
+Requires: python-sss-murmur
+%endif
Requires: wget
Requires: dbus-python
--
2.1.0
>From 5d963dda2d6423007cea803940be5d34fdcbc377 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik
Date: Fri, 27 Feb 2015 21:02:51 +0100
Subject: [PATCH 3/3] SPEC: Add missing requires for python-libsss_nss_idmap
git grep "pysss_nss_idmap" | grep import
ipalib/plugins/trust.py:import pysss_nss_idmap #pylint: disable=F0401
ipaserver/dcerpc.py:import pysss_nss_idmap
ipaserver/dcerpc.py is packaged in freeipa-server-trust-ad
palib/plugins/trust.py is packaged in freeipa-python
Resolves:
https://fedorahosted.org/freeipa/ticket/4929
---
freeipa.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index
7a1ff8b50ef1b462ad14fb2328149c3c2ed2fb38..fafec414849735854ee97752f20e941f01dc92ce
100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -198,6 +198,7 @@ Requires: libsss_nss_idmap-python
%if (0%{?fedora} >= 22)
Requires: python-sss
%endif
+Requires: python-libsss_nss_idmap
# We use alternatives to divert winbind_krb5_locator.so plugin to libkrb5
# on the installes where server-trust-ad subpackage is installed because
# IPA AD trusts cannot be used at the same time with the locator plugin
@@ -294,6 +295,7 @@ Requires: python-yubico
%if (0%{?fedora} >= 22)
Requires: python-sss-murmur
%endif
+Requires: python-libsss_nss_idmap
Requires: wget
Requires: dbus-python
--
2.1.0
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
