Status bug #122

2004-09-12 Thread Thor Spruyt
Hi Alan,

Regarding bug #122, which actually isn't a bug, but rather an enhancement...

Will the patch in bug #122 be apllied so the changes are in 1.0.1?
If it can't make 1.0.1, what has to be done in order to get it into the next
release?

--
Regards,

Thor Spruyt
E: [EMAIL PROTECTED]
W: www.thor-spruyt.com
M: +32 (0)475 67 22 65


- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: Status bug #122

2004-09-12 Thread Paul Hampson
On Sun, Sep 12, 2004 at 04:34:30PM +0200, Thor Spruyt wrote:
 Regarding bug #122, which actually isn't a bug, but rather an enhancement...

 Will the patch in bug #122 be apllied so the changes are in 1.0.1?

The only justification I can see to put this into 1.0.1 is if it's
invalid to have two Reply-Message attributes in a RADIUS reply.

 If it can't make 1.0.1, what has to be done in order to get it into the next
 release?

A good and clear explanation why rlm_exec does not and cannot fufill
your requirement. Unless I am mistaken, Exec-Program-Wait is deprecated,
in favour of rlm_exec, so I'm not inclined towards accepting
enhancements to it myself.

I speak only for myself here.

-- 
Paul TBBle Hampson, on an alternate email client.

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: Status bug #122

2004-09-12 Thread Thor Spruyt
Paul Hampson wrote:
 On Sun, Sep 12, 2004 at 04:34:30PM +0200, Thor Spruyt wrote:
 Will the patch in bug #122 be apllied so the changes are in 1.0.1?

 The only justification I can see to put this into 1.0.1 is if it's
 invalid to have two Reply-Message attributes in a RADIUS reply.

All these things have already been discussed, but if need be... it's my
opinion that ...
- the server should NOT add it's own Reply-Message when the external script
provides one
- when running with -X, we can as well print out the reply attributes sent
back for the reject
- rejecting a user has nothing to do with failure of the external script
- many users are experiencing the same issues because of the way it's
handled now

 If it can't make 1.0.1, what has to be done in order to get it into
 the next release?

 A good and clear explanation why rlm_exec does not and cannot fufill
 your requirement. Unless I am mistaken, Exec-Program-Wait is
 deprecated, in favour of rlm_exec, so I'm not inclined towards
 accepting enhancements to it myself.

Well... rlm_exec actually has the very same problem (accepting is done
properly, but rejecting is done poorly).
I think that simply because something is deprecated doesn't mean that it
doesn't matter that it's working bad.
Since it's there... why not make it behave properly? All that has to be done
is apply a patch :)

 I speak only for myself here.

Me too :)

-- 
Regards,

Thor Spruyt
E: [EMAIL PROTECTED]
W: www.thor-spruyt.com
M: +32 (0)475 67 22 65


- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html