Re: [Freevo-devel] Re: Errors in helpers/imdb.py
--- Dirk Meyer <[EMAIL PROTECTED]> escreveu: > den_RDC wrote: > > I am going to have some spare time the coming 2 weeks, so i want to > give it a > > try if that's ok. > > That would be great > > > Though i am gonna need some input on what features should be added > and such, > > so suggestions are welcome. > > Fisrt of all: cleanup some mess in helpers/imdb.py. Maybe making some > classes. The most important part is: when do we add the cdid and when > not? Also some ideas: > > o make it possible on the command line to add a file to an existing > fxd. > > o variant support. E.g. I have some cool movie trailers. I want to > have one fxd file for all trailers belonging to one movie. The fxd > file should contain a list of variants, each variant is one > trailer. > > o more than one file support of plugin/imdb.py. E.g.: I have the file > ca_trailer1.mov and ca_trailer2.mov. I select ca_trailer1 and > create > a fxd file with plugins/imdb.py (I can only select one item). After > that, I start the plugin with ca_trailer2. Now the plugin detects > that there is/are one or more fxd files containing a movie in the > search results. In this example, imdb.py returns 'Charlie's Angels > 2' for ca_trailer1 and ca_trailer2. Starting imdb.py for > ca_trailer2 > I want the following choice in the menu: 'Add as second part to > "Charlie's Angels 2"', 'Add as variant to "Charlie's Angels 2"' and > the normal results to create a new fxd file. > > o same for discs. I created an fxd file for disc1 and when I insert > disc2 I want an easy way to add this disc as second disc to the fxd > file (e.g. guess based on the label or the same way as adding more > than one file). > I don't know if there is the right place, but when generating a FXD file, would be cool to find subtitles and audio files for that movie. Ie: i have a movie "movie" and subtitles: "movie-pt_BR.sub" "movie-en_US.sub" and audio: "movie-pt_BR.mp3" This could be an extra modules, since would be cool to be able to detect those files even without a fxd if I hit 'ENTER' in item, it could show me the variants menu for this files. Also... would be cool if I can choose 2 variants at the same time, I mean: subtitles in pt_BR and audio in en_US, for example... Gustavo ___ Yahoo! Mail Mais espaço, mais segurança e gratuito: caixa postal de 6MB, antivírus, proteção contra spam. http://br.mail.yahoo.com/ --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: Errors in helpers/imdb.py
den_RDC wrote: > I am going to have some spare time the coming 2 weeks, so i want to give it a > try if that's ok. That would be great > Though i am gonna need some input on what features should be added and such, > so suggestions are welcome. Fisrt of all: cleanup some mess in helpers/imdb.py. Maybe making some classes. The most important part is: when do we add the cdid and when not? Also some ideas: o make it possible on the command line to add a file to an existing fxd. o variant support. E.g. I have some cool movie trailers. I want to have one fxd file for all trailers belonging to one movie. The fxd file should contain a list of variants, each variant is one trailer. o more than one file support of plugin/imdb.py. E.g.: I have the file ca_trailer1.mov and ca_trailer2.mov. I select ca_trailer1 and create a fxd file with plugins/imdb.py (I can only select one item). After that, I start the plugin with ca_trailer2. Now the plugin detects that there is/are one or more fxd files containing a movie in the search results. In this example, imdb.py returns 'Charlie's Angels 2' for ca_trailer1 and ca_trailer2. Starting imdb.py for ca_trailer2 I want the following choice in the menu: 'Add as second part to "Charlie's Angels 2"', 'Add as variant to "Charlie's Angels 2"' and the normal results to create a new fxd file. o same for discs. I created an fxd file for disc1 and when I insert disc2 I want an easy way to add this disc as second disc to the fxd file (e.g. guess based on the label or the same way as adding more than one file). Dischi -- When someone says, 'do you want my opinion?' - have you noticed that it's always a negative one. --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
Re: [Freevo-devel] Re: Errors in helpers/imdb.py
I am going to have some spare time the coming 2 weeks, so i want to give it a try if that's ok. I gained some knowledge of the working on helpers/imdb when i changed it to include urllib2. Though i am gonna need some input on what features should be added and such, so suggestions are welcome. den_Rdc On Monday 30 June 2003 21:12, Dirk Meyer wrote: > den_RDC wrote: > > Dishi says he will be working on giving both imdb.py's a decent overhaul > > sometime... > > Or someone else :-) > > O have a lot of other work, but if noone what's to do it, I will. But > this will take time (busy with the real job right now). > > > Dischi --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: Errors in helpers/imdb.py
den_RDC wrote: > Dishi says he will be working on giving both imdb.py's a decent overhaul > sometime... Or someone else :-) O have a lot of other work, but if noone what's to do it, I will. But this will take time (busy with the real job right now). Dischi -- Unix is the worst operating system; except for all others. -- Berry Kercheval --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
Re: [Freevo-devel] Re: Errors in helpers/imdb.py
Ok, I have some exams here in the uni, so I'll wait dischi to integrate it. Gustavo --- den_RDC <[EMAIL PROTECTED]> escreveu: > Do you use the imdb plugin? > I remeber it had this issue too, it didn't write media-id's and tried > to place > files on cd/dvd media. I sent a fix to Dischi a few days ago and it > got into > cvs. But as i see it, it still has a bug, i think it got in with the > mmpython > patches. Try this > > Line 158 , change the last None to 1 > > change this block of code (around line 227) > <-- > if self.item.media and self.item.media.id: > filename = os.path.join(config.MOVIE_DATA_DIR, > self.item.media.id) > device = self.item.media.devicename > # bad hack to set the drive, helpers/imdb.py really needs > # a bigger update > helpers.imdb.drive = self.item.media.devicename > else: > filename = os.path.splitext(self.item.filename)[0] > device = None > > helpers.imdb.get_data_and_write_fxd(arg[0], filename, device, None, > (os.path.basename(self.item.filename), ), > None) > --> > > to this > <-- > if self.item.media and self.item.media.id: > filename = os.path.join(config.MOVIE_DATA_DIR, > self.item.media.id) > device = self.item.media.devicename > # bad hack to set the drive, helpers/imdb.py really needs > # a bigger update > helpers.imdb.drive = self.item.media.devicename > helpers.imdb.get_data_and_write_fxd(arg[0], filename, device, > None, > (os.path.basename(self.item.filename), > ), 1) > else: > filename = os.path.splitext(self.item.filename)[0] > device = None > helpers.imdb.get_data_and_write_fxd(arg[0], filename, device, > None, >(os.path.basename(self.item.filename), > ), None) > --> > > Dishi says he will be working on giving both imdb.py's a decent > overhaul > sometime... > > > On Monday 30 June 2003 17:33, Gustavo Sverzut Barbieri wrote: > > So, would be nice if Freevo already comes with that directory and > > Freevo > > generate a fxd using the discid, now it generates: > > > > > > > > antitrust.avi > > > > > > > > but to make it work i need: > > > > > > antitrust.jpg > > > > > > > > Since it's on the CD... media-id is the result of getCDID() and > it's > > the name of the file named by freevo. > > > > > > Gustavo > > > > --- Dirk Meyer <[EMAIL PROTECTED]> escreveu: > Gustavo Sverzut > Barbieri > > > > wrote: > > > > One more thing: we should have a dir, configurable via > > > > > > local_conf.py, > > > > > > > where we should store those .fxd files it they cannot be > written in > > > > > > the > > > > > > > movie dir. > > > > > > We have: config.MOVIE_DATA_DIR > > > > > > > --- Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> > escreveu: > > > > > Hello, > > > > > > > >> Trying to get the imdb cover for a CD with a movie (.avi) > inside I > > > >> found 2 bugs: > > > >> > > > >> 1) It tries to save it in the CD, but it can't :) > > > >> > > > >> 2) There is a buggy code in: > > > >> > > > >> def download_image(url, filename) > > > >> > > > >> there is a block: > > > >> > > > >> except IOError: > > > >> print "Writing image failed" > > > >> conn.close() > > > >> return None > > > >> > > > >> Where 'conn' doesn't exists! Maybe it's 'r' from: > > > >> try: > > > >> r = urllib2.urlopen(req) > > > >> > > > >> however, if this is right, where are the other r.close() ? > > > > > > Well, I got a patch for imdb.py to use urllib2 and a second one > with > > > this exception handling ... Seems like I made an error mixing > > > them. IIRC we don't need a close at all. > > > > > > > > > Dischi > > > > > > -- > > > The good thing about standards is that there are so many to > choose > > > from. > > > -- Andrew S. Tanenbaum > > > > > > > > > --- > > > This SF.Net email sponsored by: Free pre-built ASP.NET sites > > > including > > > Data Reports, E-commerce, Portals, and Forums are available now. > > > Download today and enter to win an XBOX or Visual Studio .NET. > > > > > http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 > > > > > ___ > > > Freevo-devel mailing list > > > [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/freevo-devel > > > > > ___ > > Yahoo! Mail > > Mais espaço, mais segurança e gratuito: caixa postal de 6MB, > antivírus, > > proteção contra spam. http://br.mail.yahoo.com/ > > > > > > --- > > This SF.Net email sponsored by: Free pre-built ASP.NET sites > including > > Data Reports, E-commerce, Portals, and Forums are available now. > > Download today and enter to win an XBOX or Visual Studio .NET. > > > http://aspnet.click-url.com/go/psa00100
Re: [Freevo-devel] Re: Errors in helpers/imdb.py
Do you use the imdb plugin? I remeber it had this issue too, it didn't write media-id's and tried to place files on cd/dvd media. I sent a fix to Dischi a few days ago and it got into cvs. But as i see it, it still has a bug, i think it got in with the mmpython patches. Try this Line 158 , change the last None to 1 change this block of code (around line 227) <-- if self.item.media and self.item.media.id: filename = os.path.join(config.MOVIE_DATA_DIR, self.item.media.id) device = self.item.media.devicename # bad hack to set the drive, helpers/imdb.py really needs # a bigger update helpers.imdb.drive = self.item.media.devicename else: filename = os.path.splitext(self.item.filename)[0] device = None helpers.imdb.get_data_and_write_fxd(arg[0], filename, device, None, (os.path.basename(self.item.filename), ), None) --> to this <-- if self.item.media and self.item.media.id: filename = os.path.join(config.MOVIE_DATA_DIR, self.item.media.id) device = self.item.media.devicename # bad hack to set the drive, helpers/imdb.py really needs # a bigger update helpers.imdb.drive = self.item.media.devicename helpers.imdb.get_data_and_write_fxd(arg[0], filename, device, None, (os.path.basename(self.item.filename), ), 1) else: filename = os.path.splitext(self.item.filename)[0] device = None helpers.imdb.get_data_and_write_fxd(arg[0], filename, device, None, (os.path.basename(self.item.filename), ), None) --> Dishi says he will be working on giving both imdb.py's a decent overhaul sometime... On Monday 30 June 2003 17:33, Gustavo Sverzut Barbieri wrote: > So, would be nice if Freevo already comes with that directory and > Freevo > generate a fxd using the discid, now it generates: > > > > antitrust.avi > > > > but to make it work i need: > > > antitrust.jpg > > > > Since it's on the CD... media-id is the result of getCDID() and it's > the name of the file named by freevo. > > > Gustavo > > --- Dirk Meyer <[EMAIL PROTECTED]> escreveu: > Gustavo Sverzut Barbieri > > wrote: > > > One more thing: we should have a dir, configurable via > > > > local_conf.py, > > > > > where we should store those .fxd files it they cannot be written in > > > > the > > > > > movie dir. > > > > We have: config.MOVIE_DATA_DIR > > > > > --- Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> escreveu: > > > > Hello, > > > > > >> Trying to get the imdb cover for a CD with a movie (.avi) inside I > > >> found 2 bugs: > > >> > > >> 1) It tries to save it in the CD, but it can't :) > > >> > > >> 2) There is a buggy code in: > > >> > > >> def download_image(url, filename) > > >> > > >> there is a block: > > >> > > >> except IOError: > > >> print "Writing image failed" > > >> conn.close() > > >> return None > > >> > > >> Where 'conn' doesn't exists! Maybe it's 'r' from: > > >> try: > > >> r = urllib2.urlopen(req) > > >> > > >> however, if this is right, where are the other r.close() ? > > > > Well, I got a patch for imdb.py to use urllib2 and a second one with > > this exception handling ... Seems like I made an error mixing > > them. IIRC we don't need a close at all. > > > > > > Dischi > > > > -- > > The good thing about standards is that there are so many to choose > > from. > > -- Andrew S. Tanenbaum > > > > > > --- > > This SF.Net email sponsored by: Free pre-built ASP.NET sites > > including > > Data Reports, E-commerce, Portals, and Forums are available now. > > Download today and enter to win an XBOX or Visual Studio .NET. > > http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 > > > ___ > > Freevo-devel mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/freevo-devel > > ___ > Yahoo! Mail > Mais espaço, mais segurança e gratuito: caixa postal de 6MB, antivírus, > proteção contra spam. http://br.mail.yahoo.com/ > > > --- > This SF.Net email sponsored by: Free pre-built ASP.NET sites including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 > ___ > Freevo-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/freevo-devel --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-u
Re: [Freevo-devel] Re: Errors in helpers/imdb.py
One more thing: if I have a .fxd file with a disc-set in a dir that's in my DIR_MOVIES and I hit PLAY, I get a "NOT FOUNT" error message, shouldn't I receive a "Please insert the disc" and later try to identify the disc and play it? Gustavo --- Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> escreveu: > So, would be nice if Freevo already comes with that directory and > Freevo > generate a fxd using the discid, now it generates: > > > > antitrust.avi > > > > but to make it work i need: > > > antitrust.jpg > > > > Since it's on the CD... media-id is the result of getCDID() and it's > the name of the file named by freevo. > > > Gustavo > > --- Dirk Meyer <[EMAIL PROTECTED]> escreveu: > Gustavo Sverzut Barbieri > wrote: > > > One more thing: we should have a dir, configurable via > > local_conf.py, > > > where we should store those .fxd files it they cannot be written > in > > the > > > movie dir. > > > > We have: config.MOVIE_DATA_DIR > > > > > > > > --- Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> escreveu: > > > > > Hello, > > >> > > >> Trying to get the imdb cover for a CD with a movie (.avi) inside > I > > >> found 2 bugs: > > >> > > >> 1) It tries to save it in the CD, but it can't :) > > >> > > >> 2) There is a buggy code in: > > >> > > >> def download_image(url, filename) > > >> > > >> there is a block: > > >> > > >> except IOError: > > >> print "Writing image failed" > > >> conn.close() > > >> return None > > >> > > >> Where 'conn' doesn't exists! Maybe it's 'r' from: > > >> try: > > >> r = urllib2.urlopen(req) > > >> > > >> however, if this is right, where are the other r.close() ? > > > > Well, I got a patch for imdb.py to use urllib2 and a second one > with > > this exception handling ... Seems like I made an error mixing > > them. IIRC we don't need a close at all. > > > > > > Dischi > > > > -- > > The good thing about standards is that there are so many to choose > > from. > > -- Andrew S. Tanenbaum > > > > > > --- > > This SF.Net email sponsored by: Free pre-built ASP.NET sites > > including > > Data Reports, E-commerce, Portals, and Forums are available now. > > Download today and enter to win an XBOX or Visual Studio .NET. > > > http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 > > ___ > > Freevo-devel mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/freevo-devel > > ___ > Yahoo! Mail > Mais espaço, mais segurança e gratuito: caixa postal de 6MB, > antivírus, proteção contra spam. > http://br.mail.yahoo.com/ > > > --- > This SF.Net email sponsored by: Free pre-built ASP.NET sites > including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 > ___ > Freevo-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/freevo-devel ___ Yahoo! Mail Mais espaço, mais segurança e gratuito: caixa postal de 6MB, antivírus, proteção contra spam. http://br.mail.yahoo.com/ --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
Re: [Freevo-devel] Re: Errors in helpers/imdb.py
So, would be nice if Freevo already comes with that directory and Freevo generate a fxd using the discid, now it generates: antitrust.avi but to make it work i need: antitrust.jpg Since it's on the CD... media-id is the result of getCDID() and it's the name of the file named by freevo. Gustavo --- Dirk Meyer <[EMAIL PROTECTED]> escreveu: > Gustavo Sverzut Barbieri wrote: > > One more thing: we should have a dir, configurable via > local_conf.py, > > where we should store those .fxd files it they cannot be written in > the > > movie dir. > > We have: config.MOVIE_DATA_DIR > > > > > --- Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> escreveu: > > > Hello, > >> > >> Trying to get the imdb cover for a CD with a movie (.avi) inside I > >> found 2 bugs: > >> > >> 1) It tries to save it in the CD, but it can't :) > >> > >> 2) There is a buggy code in: > >> > >> def download_image(url, filename) > >> > >> there is a block: > >> > >> except IOError: > >> print "Writing image failed" > >> conn.close() > >> return None > >> > >> Where 'conn' doesn't exists! Maybe it's 'r' from: > >> try: > >> r = urllib2.urlopen(req) > >> > >> however, if this is right, where are the other r.close() ? > > Well, I got a patch for imdb.py to use urllib2 and a second one with > this exception handling ... Seems like I made an error mixing > them. IIRC we don't need a close at all. > > > Dischi > > -- > The good thing about standards is that there are so many to choose > from. > -- Andrew S. Tanenbaum > > > --- > This SF.Net email sponsored by: Free pre-built ASP.NET sites > including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 > ___ > Freevo-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/freevo-devel ___ Yahoo! Mail Mais espaço, mais segurança e gratuito: caixa postal de 6MB, antivírus, proteção contra spam. http://br.mail.yahoo.com/ --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: Errors in helpers/imdb.py
Gustavo Sverzut Barbieri wrote: > One more thing: we should have a dir, configurable via local_conf.py, > where we should store those .fxd files it they cannot be written in the > movie dir. We have: config.MOVIE_DATA_DIR > > --- Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> escreveu: > > Hello, >> >> Trying to get the imdb cover for a CD with a movie (.avi) inside I >> found 2 bugs: >> >> 1) It tries to save it in the CD, but it can't :) >> >> 2) There is a buggy code in: >> >> def download_image(url, filename) >> >> there is a block: >> >> except IOError: >> print "Writing image failed" >> conn.close() >> return None >> >> Where 'conn' doesn't exists! Maybe it's 'r' from: >> try: >> r = urllib2.urlopen(req) >> >> however, if this is right, where are the other r.close() ? Well, I got a patch for imdb.py to use urllib2 and a second one with this exception handling ... Seems like I made an error mixing them. IIRC we don't need a close at all. Dischi -- The good thing about standards is that there are so many to choose from. -- Andrew S. Tanenbaum --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
