Re: FVWM: Small localization patch

[Jesús Guerrero]

El Tue, 17 Apr 2007 09:30:57 +0100
seventh guardian [EMAIL PROTECTED] escribió:

 On 4/17/07, seventh guardian [EMAIL PROTECTED] wrote:
  On 4/14/07, Jesús Guerrero [EMAIL PROTECTED] wrote:
   Localization for the More... string in the menus.
  
   http://jesgue.homelinux.org/fvwm-files/gtMore.patch
 
  Seems ok, can you provide a ChangeLog entry?
 
 Can you also provide an entry to the pot file?
 
 I supose everyone is wellcome to translate it to other languages.
 
 Cheers,
   Renato
 
Sure, I can also provide a diff for the man page, if you think it would
be an interesting feature. For example, the man page says:

[snip]
Menu Anatomy
Menus consist of any number of titles which are inactive menu items
that usually appear at the top of the menu, normal items triggering
various actions when selected,separator  lines between the items, tear
off bars (a horizontal broken line) that tear off the menu when
selected, and sub menu items indicated with a triangle pointing left
or right, depending on the direction in which the sub menu appears.
All the above menu items are optional.
Additionally, if the menu is too long to fit on the screen, the excess
menu items are put in a continuation menu and a sub menu with the
string More... is placed at the bottom of the menu. Finally, there
may be a picture running up either side of the menu (a side bar).
[/snip]

May I add something like:

[snip]
This string (More...) honours the locale, though the msgid More...
[/snip]

??? If you have a better suggestion, let me know. I think that
documenting the feature would be nice, but maybe I am wrong, and it is
enough to include the msgids in the po files.

I can make a single patch for all the po files is anyone can provide
translations for the word More, I don't trust google translator :P If
that is not the case, may I patch only the english locale? Or may I
patch all of them using english, so anyone will remember to translate
it later?

--Jesús Guerrero

Re: FVWM: Small localization patch

[Jesús Guerrero]

El Tue, 17 Apr 2007 14:22:27 +0200
Jesús Guerrero [EMAIL PROTECTED] escribió:

 The patch has been attached to this mail.

Sorry, I forgot to include the Changelog entry, new patch attached.

-- Jesús Guerrero

? gtMore-v2.patch
? po/gtMore-v2.patch
Index: ChangeLog
===
RCS file: /home/cvs/fvwm/fvwm/ChangeLog,v
retrieving revision 1.2908
diff -u -r1.2908 ChangeLog
--- ChangeLog	17 Mar 2007 21:01:14 -	1.2908
+++ ChangeLog	17 Apr 2007 14:23:31 -
@@ -1,3 +1,20 @@
+2007-04-17  Jesús Guerrero  6thpink(at)terra(dot)es
+
+	* fvwm/fvwm.1.in (Menu Anatomy):
+	added a line informing about the possibility to localize
+	the string More...
+
+	* fvwm/menus.c:
+	added include for libs/FGettext.h and modified
+	line 1674 to use gettext
+
+	* po/fvwm.ar.po:
+	* po/fvwm.de.po:
+	* po/fvwm.fr.po:
+	* po/fvwm.pot:
+	updated those files to include the new localizable word,
+	the rest of po files have not been updated.
+
 2007-03-17  Viktor Griph  griph(at)dd(dot)chalmers(dot)se
 
 	* libs/PictureBase.c (PictureFindImageFile):
Index: fvwm/fvwm.1.in
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/fvwm.1.in,v
retrieving revision 1.252
diff -u -r1.252 fvwm.1.in
--- fvwm/fvwm.1.in	10 Mar 2007 05:55:11 -	1.252
+++ fvwm/fvwm.1.in	17 Apr 2007 14:30:45 -
@@ -2375,6 +2375,9 @@
 Finally, there may be a picture running up either side of the menu
 (a side bar).
 
+The More... string honours the locale settings, through
+the msgid More
+
 .TP
 .B Menu Navigation
 
Index: fvwm/menus.c
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/menus.c,v
retrieving revision 1.409
diff -u -r1.409 menus.c
--- fvwm/menus.c	27 Jan 2007 11:51:15 -	1.409
+++ fvwm/menus.c	17 Apr 2007 14:31:19 -
@@ -67,6 +67,7 @@
 #include menugeometry.h
 #include menuparameters.h
 #include menus.h
+#include libs/FGettext.h
 
 /*  local definitions -- */
 
@@ -1670,7 +1671,7 @@
 			 * popdown actions */
 			/* And add the entry pointing to the new menu */
 			AddToMenu(
-msp-menu, More..., tempname,
+msp-menu, gettext(More...), tempname,
 False /* no pixmap scan */, False, True);
 			free(tempname);
 			has_continuation_menu = True;
Index: po/fvwm.ar.po
===
RCS file: /home/cvs/fvwm/fvwm/po/fvwm.ar.po,v
retrieving revision 1.1
diff -u -r1.1 fvwm.ar.po
--- po/fvwm.ar.po	6 Dec 2002 08:23:28 -	1.1
+++ po/fvwm.ar.po	17 Apr 2007 14:37:30 -
@@ -317,3 +317,5 @@
 msgid Restart fvwm
 msgstr أعد تشغيل fvwm
 
+msgid More...
+msgstr أكثر
Index: po/fvwm.de.po
===
RCS file: /home/cvs/fvwm/fvwm/po/fvwm.de.po,v
retrieving revision 1.1
diff -u -r1.1 fvwm.de.po
--- po/fvwm.de.po	15 Oct 2003 00:34:29 -	1.1
+++ po/fvwm.de.po	17 Apr 2007 14:37:31 -
@@ -317,3 +317,6 @@
 #. ./modules/FvwmForm/FvwmForm-Setup.in: line 66
 msgid Restart fvwm
 msgstr Restart fvwm
+
+msgid More...
+msgstr Mehr...
Index: po/fvwm.fr.po
===
RCS file: /home/cvs/fvwm/fvwm/po/fvwm.fr.po,v
retrieving revision 1.1
diff -u -r1.1 fvwm.fr.po
--- po/fvwm.fr.po	29 Nov 2002 04:37:17 -	1.1
+++ po/fvwm.fr.po	17 Apr 2007 14:37:32 -
@@ -318,3 +318,6 @@
 #. ./modules/FvwmForm/FvwmForm-Setup.in: line 66
 msgid Restart fvwm
 msgstr Redémarrer fvwm
+
+msgid More...
+msgstr Plus...
Index: po/fvwm.pot
===
RCS file: /home/cvs/fvwm/fvwm/po/fvwm.pot,v
retrieving revision 1.1
diff -u -r1.1 fvwm.pot
--- po/fvwm.pot	29 Nov 2002 04:37:17 -	1.1
+++ po/fvwm.pot	17 Apr 2007 14:37:32 -
@@ -316,3 +316,6 @@
 #. ./modules/FvwmForm/FvwmForm-Setup.in: line 66
 msgid Restart fvwm
 msgstr 
+
+msgid More...
+msgstr