Re: CVS migo: * ImagePath now supports directories in form "/some/directory;.png"
On 21 Sep 2002 16:12:00 -0500, FVWM CVS wrote: > > Log message: > * ImagePath now supports directories in form "/some/directory;.png" > _ (where semicolon delimits a file extension that all files in > _ /some/directory have. This file extension replace the original > _ image extension (if any) or it is added if an image has no one. This is useful for users that converted KDE and GNOME images to .xpm in the past, but now may use the original .png images without changing their xpm based configuration, except for one ImagePath line. This is also useful for wm-icons. In fact this is the only way the next wm-icons version (that includes some icon sets in .xpm and some in .png) may work. Here are examples. ImagePath $HOME/.wm-icons:$HOME/.wm-icons;.png Style XTerm Icon norm/terminal.xpm, MiniIcon mini/terminal.xpm The following files are searched with this config: $HOME/.wm-icons/norm/terminal.xpm $HOME/.wm-icons/norm/terminal.png $HOME/.wm-icons/mini/terminal.xpm $HOME/.wm-icons/mini/terminal.png It is now even possible to supress the file extension at all if all directories in ImagePath define their extensions: ImagePath /some/dir;.png:/some/dir;.xbm:/another/dir;.xpm AddMenu SomeMenu "%calculator%Calculator" Exec xcalc The following files are searched: /some/dir/calculator.png /some/dir/calculator.xbm /another/dir/calculator.xpm There is still a logic to search all images twice, once without ".gz" extension and once with it. I think it is pretty redundant now. Because this may be done by "ImagePath /my/gzipped/pixmaps;.xpm.gz". Does anyone think similarly about removing this ".gz" logic? Regards, Mikhael. -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
CVS migo: * ImagePath now supports directories in form "/some/directory;.png"
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: migo02/09/21 16:12:00 Modified files: . : ChangeLog NEWS fvwm : cursor.c execcontext.h fvwm.1.in module_interface.c libs : Picture.c PictureBase.c System.c modules: ChangeLog modules/FvwmPager: x_pager.c Log message: * ImagePath now supports directories in form "/some/directory;.png" _ (where semicolon delimits a file extension that all files in _ /some/directory have. This file extension replace the original _ image extension (if any) or it is added if an image has no one. * FvwmPager: don't send end-of-line in SendText * execcontext.h: use 'M' for EXCT_MODULE not 'O', use 'I'nit for EXCT_NULL * minor reindentation in other files -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Better bug notification (was: Re: Notification: incoming/925)
> "MG" == Mikhael Goikhman <[EMAIL PROTECTED]> writes: MG> Jason, is it possible to tweak the script to do these 2 simple MG> things? There's no simple script; these messages are generated by Jitterbug. I'm not really a C programming expert, but I'll be happy to look at a patch if you care to send me one. - J< -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Better bug notification (was: Re: Notification: incoming/925)
Hmm, forgot to add "". :) It is pretty tricky to reply to bug messages, because: 1) The reporter name and his email are in 2 different places. Would be nice if the summary include From: Reporter Name <[EMAIL PROTECTED]> 2) The subject line is overwritten by "Notification:" line, it would be better if the original subject is not changed (probably prepended with a short "Bug #id: "). Jason, is it possible to tweak the script to do these 2 simple things? I have forwarded the parent message to Jens.Toerring. Regards, Mikhael. -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Notification: incoming/925
On 21 Sep 2002 10:04:09 -0500, [EMAIL PROTECTED] wrote: > > Message summary for PR#925 > From: [EMAIL PROTECTED] > Subject: Key binding problem > > Full_Name: Jens Thoms Törring > Version: 2.4.0 > > > What I found isn't actually a bug but more king of an annoyance: > I can't bind keys like XF86AudioRaiseVolume or XF86AudioLowerVolume. > The reason is simple: in bindings.c in function ParseBinding() the > maximum length of a key name is restricted to 19 characters (plus one > for the trailing '\0'. But both the key names are already 20 chars > long. > > A patch is simple: increase the size of the char array key in > ParseBinding() to e.g. 0 and allow lengths of up to 29 characters, > i.e. change the line > n1 = sscanf(token,"%19s",key) > to > n1 = sscanf(token,"%29s",key) > > As far as I can see this breaks nothing and testing results in > correct key bindings also for unusually long key names. This is already fixed in 2.4.6. Try fvwm-2.4.11. Regards, Mikhael. -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Notification: incoming/925
FVWM Bug Tracking notification new message incoming/925 Message summary for PR#925 From: [EMAIL PROTECTED] Subject: Key binding problem Date: Sat, 21 Sep 2002 10:04:06 -0500 0 replies 0 followups > ORIGINAL MESSAGE FOLLOWS < >From [EMAIL PROTECTED] Sat Sep 21 10:04:09 2002 Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 17slnl-0008TW-00 for [EMAIL PROTECTED]; Sat, 21 Sep 2002 10:04:09 -0500 Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by util2.math.uh.edu with esmtp (Exim 4.10) id 17slnl-0007Vy-00 for [EMAIL PROTECTED]; Sat, 21 Sep 2002 10:04:09 -0500 Received: from localhost ([127.0.0.1] ident=65534) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 17slni-0008TS-00 for [EMAIL PROTECTED]; Sat, 21 Sep 2002 10:04:06 -0500 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Key binding problem Message-Id: <[EMAIL PROTECTED]> Date: Sat, 21 Sep 2002 10:04:06 -0500 Full_Name: Jens Thoms Törring Version: 2.4.0 CVS_Date: OS: Linux X_Server: XF86 Submission from: (NULL) (62.104.208.78) Hi, What I found isn't actually a bug but more king of an annoyance: I can't bind keys like XF86AudioRaiseVolume or XF86AudioLowerVolume. The reason is simple: in bindings.c in function ParseBinding() the maximum length of a key name is restricted to 19 characters (plus one for the trailing '\0'. But both the key names are already 20 chars long. A patch is simple: increase the size of the char array key in ParseBinding() to e.g. 0 and allow lengths of up to 29 characters, i.e. change the line n1 = sscanf(token,"%19s",key) to n1 = sscanf(token,"%29s",key) As far as I can see this breaks nothing and testing results in correct key bindings also for unusually long key names. Regards, Jens -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: New member anounces diagnosed bug - (fixed, patchfile attached)
Rastislav Galia wrote:
Hello, I am new to fvwm-workers. I hope this is the right place to post
technical details.
So - in latest cvs source in fvwm/modules/FvwmTaskBar/Start.c there is bug
in case no Start button attributes are defined in config file. In that
case list of Start buttons is empty, causing null pointer dereference and
crash of the module. The bug was introduced recently (Sep 12-th). I did
patch to solve it by inserting this statement to line 254
if (First_Start_Button->isStartButton == TRUE)
{
if (First_Start_Button->buttonCaption == NULL)
UpdateString(&(First_Start_Button->buttonCaption), "Start");
if (First_Start_Button->buttonIconFileName == NULL)
UpdateString(&(First_Start_Button->buttonIconFileName), "mini-start.xpm");
}
Anyway, maybe this is not what is intended, but assumption of
non-emptyness of the list is all around the code.
/Rastjo
The attached patch will solve this problem.
The first start button is not actually allocated until a startbutton
attribute is passed to StartButtonParseConfig. At present, a
startbutton must be present, whether or not attributes are specified in
the fvwm2rc. Adding the following lines to StartButtonInit solves the
problem by setting the necessary attributes to some default values.
// if no start button params were specified, trick the program into
// thinking that they were
if (First_Start_Button == NULL)
{
StartButtonParseConfig("*FvwmTaskBarStartName Start");
StartButtonParseConfig("*FvwmTaskBarStartMenu RootMenu");
StartButtonParseConfig("*FvwmTaskBarStartIcon mini.start.xpm");
}
Ben
patchfile
Description: application/java-vm
Re: CVS olicha: * A Transparent and clipping patch
On 21 Sep 2002 10:47:44 +0200, Olivier Chapuis wrote: > > On Fri, Sep 20, 2002 at 10:45:23AM +, Mikhael Goikhman wrote: > > No, unfortunately this does not fix the problem. > > Until I execute Tint without parameters, colorset remains Plain. > > Do Alpha, IconAlpha and IconTint work (independently)? IconAlpha and IconTint work (wow, it is nice). Alpha 50, bg yellow works nicely too. Ok, here may be some clue. Tint green 50, Alpha 99 # (or any value < 100) works as expected Tint green 50, Alpha 0 # colorset is Plain, this is ok! Tint green 50, Alpha 100 # colorset is Plain, this is not ok Tint green 50, Alpha # colorset is Plain, this is not ok > Does the pbs arise with say IconMan? Yes, this is where I see this Tint problem in the first place. > Do you have any error message? None. > I've just committed some testing code. It may work now if you see > messages as: "Get a FRenderComposite GraphicsExpose". I wrote the above before trying the latest cvs. But there are exactly the same results with the new code as well. Nothing is printed. Regards, Mikhael. -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Conditional's criteria
On 21 Sep 2002 09:06:18 +0200, Rastislav Galia wrote:
>
> Mikhael Goikhman wrote:
> >
> > WindowId is available in 2.2.x, but in 2.4.x you may pass conditions.
> > And in 2.5.x you may pass Focused among others:
> >
> > WindowId 0x2ed (Focused, !Maximized) ...
> >
> > So, I move this to "existing enh.".
>
> Before I do so, I want to clarify that there is a difference between
>
> WindowId 0x2ed (...) ...
>
> and
>
> Next/*or whatevet*/ ("0x2ed") ...
>
> I know first option is available, but second option is
> not in 2.4.x documentation, so I didn't try it.
The second syntax does not match the window id, the first does. Think
about this (supposing FvwmEvent calls a function with a window id param):
Next("XTerm", !Iconic) Iconify
WindowId $0 ("XTerm", !Iconic) Iconify
The first operates on a random xterm, the second - on the one that
triggers the event.
> What did you by mean 'you can pass condition'. Is it this second way ?
> Then I change my proposal to 'include in documentation' ... :-)))
The condition is what is in parentheses. In 2.2.x, WindowId did not accept
parentheses. I don't see anything that is not documented.
What is the task you want to achieve using conditional commands?
Regards,
Mikhael.
--
Visit the official FVWM web page at http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
Re: CVS olicha: * A Transparent and clipping patch
On Fri, Sep 20, 2002 at 10:45:23AM +, Mikhael Goikhman wrote: > No, unfortunately this does not fix the problem. > Until I execute Tint without parameters, colorset remains Plain. > Do Alpha, IconAlpha and IconTint work (independently)? Does the pbs arise with say IconMan? Do you have any error message? I've just committed some testing code. It may work now if you see messages as: "Get a FRenderComposite GraphicsExpose". Olivier -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
CVS olicha: * XRender experimentation
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: olicha 02/09/21 03:55:54 Modified files: . : ChangeLog libs : FRender.c Log message: * XRender experimentation -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
New member anounces diagnosed bug !
Hello, I am new to fvwm-workers. I hope this is the right place to post
technical details.
So - in latest cvs source in fvwm/modules/FvwmTaskBar/Start.c there is bug
in case no Start button attributes are defined in config file. In that
case list of Start buttons is empty, causing null pointer dereference and
crash of the module. The bug was introduced recently (Sep 12-th). I did
patch to solve it by inserting this statement to line 254
if (First_Start_Button->isStartButton == TRUE)
{
if (First_Start_Button->buttonCaption == NULL)
UpdateString(&(First_Start_Button->buttonCaption), "Start");
if (First_Start_Button->buttonIconFileName == NULL)
UpdateString(&(First_Start_Button->buttonIconFileName), "mini-start.xpm");
}
Anyway, maybe this is not what is intended, but assumption of
non-emptyness of the list is all around the code.
/Rastjo
--
Visit the official FVWM web page at http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
Re: Conditional's criteria
>
> WindowId is available in 2.2.x, but in 2.4.x you may pass conditions.
> And in 2.5.x you may pass Focused among others:
>
> WindowId 0x2ed (Focused, !Maximized) ...
>
> So, I move this to "existing enh.".
>
Before I do so, I want to clarify that there is a difference between
WindowId 0x2ed (...) ...
and
Next/*or whatevet*/ ("0x2ed") ...
I know first option is available, but second option is
not in 2.4.x documentation, so I didn't try it.
What did you by mean 'you can pass condition'. Is it this second way ?
Then I change my proposal to 'include in documentation' ... :-)))
/Rastjo
--
Visit the official FVWM web page at http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
Root Key Press
I'm laying out a new module and having a little trouble with XEvents. This might be a purely X issue. I want to catch a key press anywhere on the screen, like the Alt key. It doesn't have to be exclusive. In fact, I want the fvwm core to read the keys too and act as usual. I tried XSelectInput(dpy,rootWindow,KeyPressMask|KeyReleaseMask), but I never get any events. In fact, for the several masks I've tried, the only one that did anything was PointerMotionMask. This tells me my approach is not entirely broken. If I can get this to work, I'm not sure I'll get the event if the mouse is over a non-root window, but that's the next step. I can't think of another module that even reads the keyboard, much less reading keys when not on a window created by the module. -- _ ( \ _ \/_ / _ _ Jason Weber (503) 380-7424 \|(\/)())) \/\/(-/_)(-/( Infinite Monkeys Inc.Aloha, Oregon // http://www.imonk.com/baboon [EMAIL PROTECTED] (/ [EMAIL PROTECTED][EMAIL PROTECTED] "Canister contains at least 50% recycled material; 15% post-consumer content." -- Pringles Fat-Free (side of can) -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: locale error messages
On Fri, Sep 20, 2002 at 04:12:22PM +0200, Dominik Vogt wrote: > What do these error messages try to tell me: > > -- > [FvwmButtons][FlocaleSetlocaleForX]: ERROR -- Cannot set locale. Please > check your $LC_CTYPE or $LANG. > [FvwmPager][FlocaleSetlocaleForX]: ERROR -- Cannot set locale. Please > check your $LC_CTYPE or $LANG. > Warning: locale not supported by C library, locale unchanged > [FvwmPager][FlocaleSetlocaleForX]: ERROR -- Cannot set locale. Please > check your $LC_CTYPE or $LANG. > [FvwmIconMan][FlocaleSetlocaleForX]: ERROR -- Cannot set locale. Please > check your $LC_CTYPE or $LANG. > Warning: locale not supported by C library, locale unchanged > -- > > This is what I have set: > > $ locale > LANG=C > [EMAIL PROTECTED] It means that the libc function setlocale return a NULL pointer when it is call as setlocale(LC_TYPE, ""). My libc manual says that: - Passing "" means to read the appropriate environment variable and use its value to select the locale for LC_CTYPE. - If you specify an invalid locale name, `setlocale' returns a null pointer and leaves the current locale unchanged. So it seems to me that the locale [EMAIL PROTECTED] is not supported by your libc. This seems strange and IMHO your system is miss-configured. Maybe your locale definitions of [EMAIL PROTECTED] (found somewhere under (/usr/share/locale/) is incomplete or does not match your libc. Maybe you have upgraded your libc without upgrading your locales (or inversely). Olivier -- Visit the official FVWM web page at http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
