[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 Aldy Hernandez changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #19 from Aldy Hernandez --- (In reply to r...@cebitec.uni-bielefeld.de from comment #18) > > --- Comment #16 from Aldy Hernandez --- > > (In reply to r...@cebitec.uni-bielefeld.de from comment #14) > >> > --- Comment #13 from Aldy Hernandez --- > >> > BTW, I'm waiting for a review, or at least a nod from a C++ savvy > >> > person here: > >> > > >> > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/650634.html > >> > >> I can give the patch a whirl, thanks. > > > > I've attached a rebased patch against current mainline. Let me know if it > > works on your end, and I'll commit. > > I've included both this patch ... > > >> I had Andrew's patch in my tree to avoid the issue. Unfortunately, > >> Solaris/SPARC bootstrap is broken again due to PR ipa/114985. > > > > I have provided a patch for that PR as well, but the IPA folk need to say if > > this is the correct approach. > > ... and that one in last night's SPARC bootstraps, which worked just > fine again. Thanks. Thanks for testing. I'll close this PR as fixed in mainline then. FWIW, I also retested on x86-64 Linux.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #18 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #16 from Aldy Hernandez --- > (In reply to r...@cebitec.uni-bielefeld.de from comment #14) >> > --- Comment #13 from Aldy Hernandez --- >> > BTW, I'm waiting for a review, or at least a nod from a C++ savvy >> > person here: >> > >> > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/650634.html >> >> I can give the patch a whirl, thanks. > > I've attached a rebased patch against current mainline. Let me know if it > works on your end, and I'll commit. I've included both this patch ... >> I had Andrew's patch in my tree to avoid the issue. Unfortunately, >> Solaris/SPARC bootstrap is broken again due to PR ipa/114985. > > I have provided a patch for that PR as well, but the IPA folk need to say if > this is the correct approach. ... and that one in last night's SPARC bootstraps, which worked just fine again. Thanks.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #17 from GCC Commits --- The master branch has been updated by Aldy Hernandez : https://gcc.gnu.org/g:d7ff8ae5313bea755f5960786b33a7b151e7b663 commit r15-336-gd7ff8ae5313bea755f5960786b33a7b151e7b663 Author: Aldy Hernandez Date: Fri May 3 11:17:32 2024 +0200 [ranger] Force buffer alignment in Value_Range [PR114912] gcc/ChangeLog: PR tree-optimization/114912 * value-range.h (class Value_Range): Use a union.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #16 from Aldy Hernandez --- (In reply to r...@cebitec.uni-bielefeld.de from comment #14) > > --- Comment #13 from Aldy Hernandez --- > > BTW, I'm waiting for a review, or at least a nod from a C++ savvy person > > here: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/650634.html > > I can give the patch a whirl, thanks. I've attached a rebased patch against current mainline. Let me know if it works on your end, and I'll commit. > > I had Andrew's patch in my tree to avoid the issue. Unfortunately, > Solaris/SPARC bootstrap is broken again due to PR ipa/114985. I have provided a patch for that PR as well, but the IPA folk need to say if this is the correct approach.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #15 from Aldy Hernandez --- Created attachment 58136 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58136=edit proposed patch in testing
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #14 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #13 from Aldy Hernandez --- > BTW, I'm waiting for a review, or at least a nod from a C++ savvy person here: > > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/650634.html I can give the patch a whirl, thanks. I had Andrew's patch in my tree to avoid the issue. Unfortunately, Solaris/SPARC bootstrap is broken again due to PR ipa/114985.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #13 from Aldy Hernandez --- BTW, I'm waiting for a review, or at least a nod from a C++ savvy person here: https://gcc.gnu.org/pipermail/gcc-patches/2024-May/650634.html
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #12 from Aldy Hernandez --- (In reply to Andrew Pinski from comment #10) > If Aldy does not fix it by Saturday, I will give the union a try then. I > will also try out the solaris machine on the compile farm if possible. Sorry, didn't mean for you to pick this up. Thanks for the analysis. I can take it from here.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #11 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #10 from Andrew Pinski --- > If Aldy does not fix it by Saturday, I will give the union a try then. I will Great, thanks. Your alignas patch also worked fine btw. > also try out the solaris machine on the compile farm if possible. Otherwise, you can just send it my way and I'll give it a whirl.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #10 from Andrew Pinski --- If Aldy does not fix it by Saturday, I will give the union a try then. I will also try out the solaris machine on the compile farm if possible.
[Bug tree-optimization/114912] [15 regression] SIGBUS in wi::copy<> on SPARC since r15-88-gc60b3e211c5557 since char array is not aligned to what it needs to be
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114912 --- Comment #9 from Richard Biener --- (In reply to Andrew Pinski from comment #8) > The other way of fixing this is to use an union and I think since we are > using C++11, it might work correctly. > > I do think we should prefer the union rather than having it as a char array > too ... If a union works then indeed that's what we should use.
