Re: [PATCH] Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites
2014-12-10 21:37 GMT+08:00 Richard Biener richard.guent...@gmail.com: On Wed, Dec 10, 2014 at 6:16 AM, Chung-Ju Wu jasonw...@gmail.com wrote: Thanks for the suggestion. The followings are proposed patch to adjust comment: Index: contrib/ChangeLog === --- contrib/ChangeLog (revision 218558) +++ contrib/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-12-10 Chung-Ju Wu jasonw...@gmail.com + + * download_prerequisites: Modify the comment for GRAPHITE_LOOP_OPT. + 2014-12-09 Laurynas Biveinis laurynas.bivei...@gmail.com Yury Gribov y.gri...@samsung.com Index: contrib/download_prerequisites === --- contrib/download_prerequisites (revision 218558) +++ contrib/download_prerequisites (working copy) @@ -19,9 +19,9 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see http://www.gnu.org/licenses/. -# If you want to build GCC with the Graphite loop optimizations, -# set GRAPHITE_LOOP_OPT=yes to download optional prerequisties -# ISL Library and CLooG. +# If you want to disable Graphite loop optimizations while building GCC, +# DO NOT set GRAPHITE_LOOP_OPT as yes so that the ISL package will not +# be downloaded. GRAPHITE_LOOP_OPT=yes Is this OK for trunk? Ok. Thanks, Richard. Thanks for approval. Committed as Rev.218652: https://gcc.gnu.org/r218652 Best regards, jasonwucj
Re: [PATCH] Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites
On Wed, Dec 10, 2014 at 6:16 AM, Chung-Ju Wu jasonw...@gmail.com wrote: 2014-12-09 21:16 GMT+08:00 Richard Biener richard.guent...@gmail.com: On Tue, Dec 9, 2014 at 6:36 AM, Chung-Ju Wu jasonw...@gmail.com wrote: Hi, all, In the discussion thread last year: https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html I extended the script ./contrib/download_prerequisites so that it can download isl and cloog packages for graphite loop optimizations. The patch was proposed to use GRAPHITE_LOOP_OPT=no by default. However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes: https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=199297 I am sorry about my carelessness and I would like to propose a new patch to fix it. The plaintext ChangeLog and patch are as follow: I'd say keep it as =yes (now that we only need ISL) and adjust the comment instead. Richard. Thanks for the suggestion. The followings are proposed patch to adjust comment: Index: contrib/ChangeLog === --- contrib/ChangeLog (revision 218558) +++ contrib/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-12-10 Chung-Ju Wu jasonw...@gmail.com + + * download_prerequisites: Modify the comment for GRAPHITE_LOOP_OPT. + 2014-12-09 Laurynas Biveinis laurynas.bivei...@gmail.com Yury Gribov y.gri...@samsung.com Index: contrib/download_prerequisites === --- contrib/download_prerequisites (revision 218558) +++ contrib/download_prerequisites (working copy) @@ -19,9 +19,9 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see http://www.gnu.org/licenses/. -# If you want to build GCC with the Graphite loop optimizations, -# set GRAPHITE_LOOP_OPT=yes to download optional prerequisties -# ISL Library and CLooG. +# If you want to disable Graphite loop optimizations while building GCC, +# DO NOT set GRAPHITE_LOOP_OPT as yes so that the ISL package will not +# be downloaded. GRAPHITE_LOOP_OPT=yes Is this OK for trunk? Ok. Thanks, Richard. Best regards, jasonwucj
Re: [PATCH] Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites
On Tue, Dec 9, 2014 at 6:36 AM, Chung-Ju Wu jasonw...@gmail.com wrote: Hi, all, In the discussion thread last year: https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html I extended the script ./contrib/download_prerequisites so that it can download isl and cloog packages for graphite loop optimizations. The patch was proposed to use GRAPHITE_LOOP_OPT=no by default. However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes: https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=199297 I am sorry about my carelessness and I would like to propose a new patch to fix it. The plaintext ChangeLog and patch are as follow: I'd say keep it as =yes (now that we only need ISL) and adjust the comment instead. Richard. Index: contrib/ChangeLog === --- contrib/ChangeLog (revision 218505) +++ contrib/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-12-09 Chung-Ju Wu jasonw...@gmail.com + + * download_prerequisites: Set GRAPHITE_LOOP_OPT=no by default. + 2014-12-04 Thomas Preud'homme thomas.preudho...@arm.com * check_GNU_style.sh: Warn for incorrect number of spaces in function Index: contrib/download_prerequisites === --- contrib/download_prerequisites (revision 218505) +++ contrib/download_prerequisites (working copy) @@ -22,7 +22,7 @@ # If you want to build GCC with the Graphite loop optimizations, # set GRAPHITE_LOOP_OPT=yes to download optional prerequisties # ISL Library and CLooG. -GRAPHITE_LOOP_OPT=yes +GRAPHITE_LOOP_OPT=no # Necessary to build GCC. MPFR=mpfr-2.4.2 Is this patch OK for trunk? Or we can still keep it yes since it has been using GRAPHITE_LOOP_OPT=yes for a long time. In that case, I will help to update the comment accordingly. Any comment? :) Best regards, jasonwucj
Re: [PATCH] Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites
2014-12-09 21:16 GMT+08:00 Richard Biener richard.guent...@gmail.com: On Tue, Dec 9, 2014 at 6:36 AM, Chung-Ju Wu jasonw...@gmail.com wrote: Hi, all, In the discussion thread last year: https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html I extended the script ./contrib/download_prerequisites so that it can download isl and cloog packages for graphite loop optimizations. The patch was proposed to use GRAPHITE_LOOP_OPT=no by default. However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes: https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=199297 I am sorry about my carelessness and I would like to propose a new patch to fix it. The plaintext ChangeLog and patch are as follow: I'd say keep it as =yes (now that we only need ISL) and adjust the comment instead. Richard. Thanks for the suggestion. The followings are proposed patch to adjust comment: Index: contrib/ChangeLog === --- contrib/ChangeLog (revision 218558) +++ contrib/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-12-10 Chung-Ju Wu jasonw...@gmail.com + + * download_prerequisites: Modify the comment for GRAPHITE_LOOP_OPT. + 2014-12-09 Laurynas Biveinis laurynas.bivei...@gmail.com Yury Gribov y.gri...@samsung.com Index: contrib/download_prerequisites === --- contrib/download_prerequisites (revision 218558) +++ contrib/download_prerequisites (working copy) @@ -19,9 +19,9 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see http://www.gnu.org/licenses/. -# If you want to build GCC with the Graphite loop optimizations, -# set GRAPHITE_LOOP_OPT=yes to download optional prerequisties -# ISL Library and CLooG. +# If you want to disable Graphite loop optimizations while building GCC, +# DO NOT set GRAPHITE_LOOP_OPT as yes so that the ISL package will not +# be downloaded. GRAPHITE_LOOP_OPT=yes Is this OK for trunk? Best regards, jasonwucj
[PATCH] Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites
Hi, all, In the discussion thread last year: https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html I extended the script ./contrib/download_prerequisites so that it can download isl and cloog packages for graphite loop optimizations. The patch was proposed to use GRAPHITE_LOOP_OPT=no by default. However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes: https://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=199297 I am sorry about my carelessness and I would like to propose a new patch to fix it. The plaintext ChangeLog and patch are as follow: Index: contrib/ChangeLog === --- contrib/ChangeLog (revision 218505) +++ contrib/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-12-09 Chung-Ju Wu jasonw...@gmail.com + + * download_prerequisites: Set GRAPHITE_LOOP_OPT=no by default. + 2014-12-04 Thomas Preud'homme thomas.preudho...@arm.com * check_GNU_style.sh: Warn for incorrect number of spaces in function Index: contrib/download_prerequisites === --- contrib/download_prerequisites (revision 218505) +++ contrib/download_prerequisites (working copy) @@ -22,7 +22,7 @@ # If you want to build GCC with the Graphite loop optimizations, # set GRAPHITE_LOOP_OPT=yes to download optional prerequisties # ISL Library and CLooG. -GRAPHITE_LOOP_OPT=yes +GRAPHITE_LOOP_OPT=no # Necessary to build GCC. MPFR=mpfr-2.4.2 Is this patch OK for trunk? Or we can still keep it yes since it has been using GRAPHITE_LOOP_OPT=yes for a long time. In that case, I will help to update the comment accordingly. Any comment? :) Best regards, jasonwucj
