Re: PATCH RFA: Update Go frontend on gcc 4.7 branch
Ian Lance Taylor i...@google.com writes: I would like to update the Go support on the 4.7 branch. As I've mentioned before, Go is working toward a stable Go 1 release. That release is not complete, but it is quite close. The 4.7 branch was made at a slightly unstable point in the process. I've updated the library one more time, and I've spent the week testing the result on a bunch of Google-internal programs. What I have now is not perfect, but it is better than what is on the 4.7 branch today. This proposed patch does include a library update, which is fairly large. However, this update should not be destabilizing. I've tested the 4.7 branch plus this patch on x86_64-unknown-linux-gnu, and I'm preparing to test it on Solaris. Unfortunately, this patch introduced several go and/or libgo testsuite failures on both Solaris/SPARC and x86 on the 4.7 branch while the results were clean before. I've filed PR go/52583 for this, but not yet investigated in detail. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: PATCH RFA: Update Go frontend on gcc 4.7 branch
Ian Lance Taylor i...@google.com writes: Unfortunately, this patch introduced several go and/or libgo testsuite failures on both Solaris/SPARC and x86 on the 4.7 branch while the results were clean before. I've filed PR go/52583 for this, but not yet investigated in detail. Hmmm, the patch just copied code from mainline--did you see these issues on mainline before? I did not see these issues when I tested the patch I did, but didn't get around to reporting them before. on the 4.7 branch on Solaris SPARC. Strange: in my tests, SPARC and x86 are equally affected (with only slight differences). Unfortunately I think it may be too late to change things before the 4.7.0 release. Would be a pity, but I fear you're right, given that Richard plans to cut the release late next week. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: PATCH RFA: Update Go frontend on gcc 4.7 branch
Jakub Jelinek ja...@redhat.com writes: FYI, on Fedora 17 I had recent testresults without the patch, so below are just testsuite differences for that (debug/dwarf fails consistently everywhere), on RHEL5/6 I didn't have earlier go testsuite results, so I'm just providing summaries there. The reason debug/dwarf fails everywhere with the patch is simply that there are a couple of binary test files in debug/dwarf, and the patch program did not update them correctly. The debug/dwarf tests should pass now that the correct binary files have been committed to the branch. Ian
Re: PATCH RFA: Update Go frontend on gcc 4.7 branch
On Fri, Mar 09, 2012 at 02:20:14PM -0800, Ian Lance Taylor wrote: I would like to update the Go support on the 4.7 branch. As I've mentioned before, Go is working toward a stable Go 1 release. That release is not complete, but it is quite close. The 4.7 branch was made at a slightly unstable point in the process. I've updated the library one more time, and I've spent the week testing the result on a bunch of Google-internal programs. What I have now is not perfect, but it is better than what is on the 4.7 branch today. I'm not very excited by such huge changes, but I've tested this on Fedora 17 (various architectures) and RHEL6/5 today, let's check this in. But certainly no further such large change will be accepted on the 4.7 branch. FYI, on Fedora 17 I had recent testresults without the patch, so below are just testsuite differences for that (debug/dwarf fails consistently everywhere), on RHEL5/6 I didn't have earlier go testsuite results, so I'm just providing summaries there. Fedora 17 i686-linux -FAIL: database/sql +FAIL: debug/dwarf x86_64-linux +FAIL: go.test/test/stack.go execution, -O2 -g +FAIL: debug/dwarf -FAIL: database/sql +FAIL: debug/dwarf ppc-linux +FAIL: log -FAIL: database/sql +FAIL: debug/dwarf -FAIL: exp/signal +FAIL: net/http/httptest +FAIL: os/signal -FAIL: testing/script ppc64-linux -FAIL: exp/signal +FAIL: net/http/httptest +FAIL: os/signal -FAIL: testing/script +FAIL: log +FAIL: debug/dwarf s390-linux +FAIL: log +FAIL: debug/dwarf -FAIL: sync/atomic s390x-linux +FAIL: log -FAIL: sync/atomic +FAIL: debug/dwarf +FAIL: log +FAIL: debug/dwarf -FAIL: sync/atomic RHEL 5, x86_64-linux (insufficient .cfi* support, so -fsplit-stack not supported): === go Summary === # of expected passes1045 # of unexpected failures556 # of expected failures 4 # of untested testcases 535 === libgo tests === Running target unix FAIL: debug/dwarf === libgo Summary for unix === # of expected passes122 # of unexpected failures1 Running target unix/-m32 FAIL: net FAIL: debug/dwarf RHEL6, x86_64-linux === go Summary === # of expected passes3296 # of expected failures 4 # of untested testcases 4 === libgo tests === Running target unix FAIL: debug/dwarf === libgo Summary for unix === # of expected passes122 # of unexpected failures1 Jakub
Re: PATCH RFA: Update Go frontend on gcc 4.7 branch
Jakub Jelinek ja...@redhat.com writes: I'm not very excited by such huge changes, but I've tested this on Fedora 17 (various architectures) and RHEL6/5 today, let's check this in. Thanks. Committed. But certainly no further such large change will be accepted on the 4.7 branch. Understood. FYI, on Fedora 17 I had recent testresults without the patch, so below are just testsuite differences for that (debug/dwarf fails consistently everywhere), on RHEL5/6 I didn't have earlier go testsuite results, so I'm just providing summaries there. I will look into these failures, not sure what is happening here. Ian
PATCH RFA: Update Go frontend on gcc 4.7 branch
I would like to update the Go support on the 4.7 branch. As I've mentioned before, Go is working toward a stable Go 1 release. That release is not complete, but it is quite close. The 4.7 branch was made at a slightly unstable point in the process. I've updated the library one more time, and I've spent the week testing the result on a bunch of Google-internal programs. What I have now is not perfect, but it is better than what is on the 4.7 branch today. This proposed patch does include a library update, which is fairly large. However, this update should not be destabilizing. I've tested the 4.7 branch plus this patch on x86_64-unknown-linux-gnu, and I'm preparing to test it on Solaris. This will be the last large Go patch I will commit before the 4.7.0 release. I may commit some small patches to fix serious bugs, subject to approval by the RMs. The bzipped patch is 375146 bytes, too large for the mailing list. I've put it at ftp://ftp.airs.com/pub/go-4_7.patch.bz2 . OK to commit to 4.7 branch? Ian
