RE: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi Ramana, Attached is the patch for marvell-pj4.md to fix the simple_alu_shift category. Thanks for your kindly help. Cheers, Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramra...@arm.com] Sent: Friday, January 18, 2013 10:28 PM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org ; Subject: Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu a...@marvell.com Ramana Radhakrishnan ramana.radhakrish...@arm.com * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. Modified patch is attached. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite. pj4.patch Description: pj4.patch
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
On 01/20/13 20:36, Matthias Klose wrote: Am 18.01.2013 15:28, schrieb Ramana Radhakrishnan: On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu a...@marvell.com Ramana Radhakrishnan ramana.radhakrish...@arm.com * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. Modified patch is attached. the patch was missing the new file config/arm/marvell-pj4.md. Checked is as obvious to restore the bootstrap. Thanks - Looks like I missed adding that. Uggh. Ramana
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi Yi-Hsiu Hsu, On 01/21/13 08:51, Yi-Hsiu Hsu wrote: Hi Ramana, Attached is the patch for marvell-pj4.md to fix the simple_alu_shift category. Thanks for your kindly help. In the future please submit patches with a Changelog entry. I've created one for this patch as it needed a bit of splitting up given the mis-commit earlier by doko. So in this case I've now committed the following with the following Changelog entry. Regards, Ramana 2013-01-21 Yi-Hsiu Hsu a...@marvell.com * config/arm/marvell-pj4.md (pj4_shift_conds, pj4_alu_shift, pj4_alu_shift_conds, pj4_shift): Handle simple_alu_shift. Cheers, Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramra...@arm.com] Sent: Friday, January 18, 2013 10:28 PM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org ; Subject: Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu a...@marvell.com Ramana Radhakrishnan ramana.radhakrish...@arm.com * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. Modified patch is attached. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite. = Index: gcc/config/arm/marvell-pj4.md === --- gcc/config/arm/marvell-pj4.md (revision 195332) +++ gcc/config/arm/marvell-pj4.md (working copy) @@ -69,26 +69,26 @@ (define_insn_reservation pj4_shift 1 (and (eq_attr tune marvell_pj4) - (eq_attr type alu_shift,alu_shift_reg) + (eq_attr type alu_shift,alu_shift_reg,simple_alu_shift) (not (eq_attr conds set)) (eq_attr shift 1)) pj4_is,(pj4_alu1,pj4_w1+pj4_cp)|(pj4_alu2,pj4_w2+pj4_cp)) (define_insn_reservation pj4_shift_conds 4 (and (eq_attr tune marvell_pj4) - (eq_attr type alu_shift,alu_shift_reg) + (eq_attr type alu_shift,alu_shift_reg,simple_alu_shift) (eq_attr conds set) (eq_attr shift 1)) pj4_is,(pj4_alu1,pj4_w1+pj4_cp)|(pj4_alu2,pj4_w2+pj4_cp)) (define_insn_reservation pj4_alu_shift 1 (and (eq_attr tune marvell_pj4) (not (eq_attr conds set)) - (eq_attr type alu_shift,alu_shift_reg)) + (eq_attr type alu_shift,alu_shift_reg,simple_alu_shift)) pj4_is,(pj4_alu1,nothing,pj4_w1+pj4_cp)|(pj4_alu2,nothing,pj4_w2+pj4_cp)) (define_insn_reservation pj4_alu_shift_conds 4 (and (eq_attr tune marvell_pj4) (eq_attr conds set) - (eq_attr type alu_shift,alu_shift_reg)) + (eq_attr type alu_shift,alu_shift_reg,simple_alu_shift)) pj4_is,(pj4_alu1,nothing,pj4_w1+pj4_cp)|(pj4_alu2,nothing
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi Ramana, Sorry for missing the Changelog, I will add it for future patches. Thanks for your kindly help. Cheers, Compiler Team @ MTL Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramra...@arm.com] Sent: Monday, January 21, 2013 6:56 PM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores Hi Yi-Hsiu Hsu, On 01/21/13 08:51, Yi-Hsiu Hsu wrote: Hi Ramana, Attached is the patch for marvell-pj4.md to fix the simple_alu_shift category. Thanks for your kindly help. In the future please submit patches with a Changelog entry. I've created one for this patch as it needed a bit of splitting up given the mis-commit earlier by doko. So in this case I've now committed the following with the following Changelog entry. Regards, Ramana 2013-01-21 Yi-Hsiu Hsu a...@marvell.com * config/arm/marvell-pj4.md (pj4_shift_conds, pj4_alu_shift, pj4_alu_shift_conds, pj4_shift): Handle simple_alu_shift. Cheers, Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramra...@arm.com] Sent: Friday, January 18, 2013 10:28 PM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org ; Subject: Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu a...@marvell.com Ramana Radhakrishnan ramana.radhakrish...@arm.com * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. Modified patch is attached. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite. =
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Am 18.01.2013 15:28, schrieb Ramana Radhakrishnan: On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu a...@marvell.com Ramana Radhakrishnan ramana.radhakrish...@arm.com * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. Modified patch is attached. the patch was missing the new file config/arm/marvell-pj4.md. Checked is as obvious to restore the bootstrap. Matthias
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
On Mon, Jan 21, 2013 at 4:36 AM, Matthias Klose d...@ubuntu.com wrote: Am 18.01.2013 15:28, schrieb Ramana Radhakrishnan: On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu a...@marvell.com Ramana Radhakrishnan ramana.radhakrish...@arm.com * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. Modified patch is attached. the patch was missing the new file config/arm/marvell-pj4.md. Checked is as obvious to restore the bootstrap. Matthias Checkin R195295 for this patch causes build failure for arm-none-eabi. Please see PR56058. -- Best Regards.
Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu a...@marvell.com Ramana Radhakrishnan ramana.radhakrish...@arm.com * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. Modified patch is attached. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite. commit faf5471d7d4616ad19d6bbae2c41e382ae506110 Author: Ramana Radhakrishnan ramana.radhakrish...@arm.com Date: Fri Jan 18 14:12:19 2013 + Apply tuning for marvell-pj4 diff --git a/gcc/config/arm/arm-cores.def b/gcc/config/arm/arm-cores.def index 0cd8714..a4cb7c6 100644 --- a/gcc/config/arm/arm-cores.def +++ b/gcc/config/arm/arm-cores.def @@ -137,3 +137,4 @@ ARM_CORE(cortex-m3, cortexm3, 7M, FL_LDSCHED, cortex) ARM_CORE(cortex-m1,cortexm1, 6M, FL_LDSCHED, v6m) ARM_CORE(cortex-m0,cortexm0, 6M, FL_LDSCHED, v6m) ARM_CORE(cortex-m0plus, cortexm0plus,6M, FL_LDSCHED, v6m) +ARM_CORE(marvell-pj4, marvell_pj4, 7A, FL_LDSCHED, 9e) diff --git a/gcc/config/arm/arm-tables.opt b/gcc/config/arm/arm-tables.opt index 6d0af59..06a529d 100644 --- a/gcc/config/arm/arm-tables.opt +++ b/gcc/config/arm/arm-tables.opt @@ -273,6 +273,9 @@ Enum(processor_type) String(cortex-m0) Value(cortexm0) EnumValue Enum(processor_type) String(cortex-m0plus) Value(cortexm0plus) +EnumValue +Enum(processor_type) String(marvell-pj4) Value(marvell_pj4) + Enum Name(arm_arch) Type(int) Known ARM architectures (for use with the -march= option): diff --git a/gcc/config/arm/arm-tune.md b/gcc/config/arm/arm-tune.md index 040587a..26c2e1f 100644 --- a/gcc/config/arm/arm-tune.md +++ b/gcc/config/arm/arm-tune.md @@ -1,5 +1,5 @@ ;; -*- buffer-read-only: t -*- ;; Generated automatically by gentune.sh from arm-cores.def (define_attr tune - arm2,arm250,arm3,arm6,arm60,arm600,arm610,arm620,arm7,arm7d,arm7di,arm70,arm700,arm700i,arm710,arm720,arm710c,arm7100,arm7500,arm7500fe,arm7m,arm7dm,arm7dmi,arm8,arm810,strongarm,strongarm110,strongarm1100,strongarm1110,fa526,fa626,arm7tdmi,arm7tdmis,arm710t,arm720t,arm740t,arm9,arm9tdmi,arm920,arm920t,arm922t,arm940t,ep9312,arm10tdmi,arm1020t,arm9e,arm946es,arm966es,arm968es,arm10e,arm1020e,arm1022e,xscale,iwmmxt,iwmmxt2,fa606te,fa626te,fmp626,fa726te,arm926ejs,arm1026ejs,arm1136js,arm1136jfs,arm1176jzs,arm1176jzfs,mpcorenovfp,mpcore,arm1156t2s,arm1156t2fs,genericv7a,cortexa5,cortexa7,cortexa8,cortexa9,cortexa15,cortexr4,cortexr4f,cortexr5,cortexm4,cortexm3,cortexm1,cortexm0,cortexm0plus + arm2,arm250,arm3,arm6,arm60,arm600,arm610,arm620,arm7,arm7d,arm7di,arm70,arm700
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
On 20 June 2012 03:53, Yi-Hsiu Hsu a...@marvell.com wrote: marvell-pj4 is added to BE8_LINK_SPEC. Modified patch is attached. Missing a modified changelog entry. Ramana Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite.
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Updated changelog. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (tune_marvell): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Added entry for marvell-pj4. B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Tuesday, June 26, 2012 3:36 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 20 June 2012 03:53, Yi-Hsiu Hsu a...@marvell.com wrote: marvell-pj4 is added to BE8_LINK_SPEC. Modified patch is attached. Missing a modified changelog entry. Ramana Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite.
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
On 2012/6/26 09:37 AM, Yi-Hsiu Hsu wrote: Updated changelog. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (tune_marvell): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Added entry for marvell-pj4. Another nit, I think the tune_marvell attribute now looks a bit unneeded. You can just fold it into the tune clause of generic_sched. Thanks, Chung-Lin
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi Chung-Lin, I think tune_marvell attribute better be kept for future Marvell cores extension. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Chung-Lin Tang [mailto:clt...@codesourcery.com] Sent: Tuesday, June 26, 2012 12:12 PM To: Yi-Hsiu Hsu Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 2012/6/26 09:37 AM, Yi-Hsiu Hsu wrote: Updated changelog. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (tune_marvell): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Added entry for marvell-pj4. Another nit, I think the tune_marvell attribute now looks a bit unneeded. You can just fold it into the tune clause of generic_sched. Thanks, Chung-Lin
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
marvell-pj4 is added to BE8_LINK_SPEC. Modified patch is attached. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite. marvell-pj4-core.patch Description: marvell-pj4-core.patch
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
On 2012/6/14 02:18 AM, Ramana Radhakrishnan wrote: On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. I take the blame for not doing this back then, but I suggest the resource names be properly qualified, similar to most recently added pipeline descriptions, e.g. prepend resource/reservation names with pj4_ (is to pj4_is, etc.) Chung-Lin
Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores
On 29 May 2012 10:07, Yi-Hsiu Hsu a...@marvell.com wrote: Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite.
