Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines
On Tue, 3 May 2011, Gerald Pfeifer wrote:
On Wed, 27 Apr 2011, Michael Witten wrote:
sed -i s/[ $(printf '\t')]\{1,\}\$// trunk/gcc/doc/extend.texi
I believe we usually don't do whitespace changes just for the sake
of cleaning up things.
Unless someone else indicates otherwise, I believe this patch is
rejected.
I think we *should* make such formatting cleanups (not just trailing
whitespace removal, but other changes to match formatting conventions,
including fixing leading whitespace in C code to use tabs where it doesn't
as well as more visible changes) - as long as we are agreed on what the
convention is to follow (see
http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00393.html and thread
regarding conventions for whitespace after VEC etc., for example). (But
not (a) in testcases, where I don't think there's any need to follow
consistent conventions, and (b) in code imported from other upstream
sources, where such fixes are not a good enough reason to diverge from
upstream.)
However, given the reaction when HJ checked in a trailing whitespace
removal patch, it seems this is controversial.
--
Joseph S. Myers
jos...@codesourcery.com
Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines
On May 4, 2011, at 3:08 AM, Joseph S. Myers wrote:
On Tue, 3 May 2011, Gerald Pfeifer wrote:
On Wed, 27 Apr 2011, Michael Witten wrote:
sed -i s/[ $(printf '\t')]\{1,\}\$// trunk/gcc/doc/extend.texi
I believe we usually don't do whitespace changes just for the sake
of cleaning up things.
Unless someone else indicates otherwise, I believe this patch is
rejected.
I think we *should* make such formatting cleanups (not just trailing
whitespace removal, but other changes to match formatting conventions,
including fixing leading whitespace in C code to use tabs where it doesn't
as well as more visible changes)
gcc had that policy for years and years. To return to that, we just need a
maintainer to approve or pre-approve these changes. :-) Then, buy some
popcorn and watch the fight (if any).
Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines
On Wed, 4 May 2011, Joseph S. Myers wrote: I believe we usually don't do whitespace changes just for the sake of cleaning up things. Unless someone else indicates otherwise, I believe this patch is rejected. I think we *should* make such formatting cleanups (not just trailing whitespace removal, but other changes to match formatting conventions, including fixing leading whitespace in C code to use tabs where it doesn't as well as more visible changes) - as long as we are agreed on what the convention is to follow Joseph, if you'd like to approave Michael's patch, I explicitly non-object. On Wed, 4 May 2011, Mike Stump wrote: gcc had that policy for years and years. To return to that, we just need a maintainer to approve or pre-approve these changes. :-) Documentation may be a bit more relaxed, and if you have one doc maintainer approve and the other abstain that may be more boring that you might hope for. :-) Unless others strongly disagree, of course, still got respective area maintainers and global reviewers. Gerald
Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines
On Wed, 4 May 2011, Gerald Pfeifer wrote: On Wed, 4 May 2011, Joseph S. Myers wrote: I believe we usually don't do whitespace changes just for the sake of cleaning up things. Unless someone else indicates otherwise, I believe this patch is rejected. I think we *should* make such formatting cleanups (not just trailing whitespace removal, but other changes to match formatting conventions, including fixing leading whitespace in C code to use tabs where it doesn't as well as more visible changes) - as long as we are agreed on what the convention is to follow Joseph, if you'd like to approave Michael's patch, I explicitly non-object. I explicitly approve trailing whitespace removal from all .texi files and other documentation not imported from upstream sources outside of GCC (subject to handling generated files properly, so any changes to tm.texi should be done by changing source files such as tm.texi.in and then regenerating tm.texi). -- Joseph S. Myers jos...@codesourcery.com
Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines
On May 4, 2011, at 11:46 AM, Joseph S. Myers wrote: I explicitly approve trailing whitespace removal from all .texi files and other documentation not imported from upstream sources outside of GCC (subject to handling generated files properly, so any changes to tm.texi should be done by changing source files such as tm.texi.in and then regenerating tm.texi). Checked in r173401 and r173402. These sorts of patches usually I don't post, as they tend to hit the size limitation and are exceedingly boring. The important part of it is: $ svn diff -r173400:173402 . -x -b Index: loop.texi === Index: generic.texi === Index: sourcebuild.texi === Index: plugins.texi === Index: cpp.texi === Index: extend.texi === Index: passes.texi === Index: cfg.texi === Index: objc.texi === Index: gimple.texi === Index: tm.texi === Index: libgcc.texi === Index: tree-ssa.texi === Index: tm.texi.in === Index: invoke.texi === Index: gcov.texi === Index: contrib.texi === Index: md.texi === Index: rtl.texi === Index: hostconfig.texi === Index: gty.texi === Index: install.texi === which is one of the audit steps I perform before checkin of these types of patches. One other step, is to hand audit every single character changed. The testsuite has a few lines that cannot be changed, for example. These are the doc bits I care about.
Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines
On May 4, 2011, at 11:40 AM, Gerald Pfeifer wrote: Documentation may be a bit more relaxed, and if you have one doc maintainer approve and the other abstain that may be more boring that you might hope for. :-) Actually, I was aiming for a global person to ack gcc/*... This could be less boring that just gcc/doc. :-)
Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines
On Wed, 27 Apr 2011, Michael Witten wrote:
sed -i s/[ $(printf '\t')]\{1,\}\$// trunk/gcc/doc/extend.texi
I believe we usually don't do whitespace changes just for the sake
of cleaning up things.
Unless someone else indicates otherwise, I believe this patch is
rejected.
Gerald
