Re: [google] libgcov workaround for weak reference issue (issue 6276043)
Ok with better naming for the dummy function such as '__gcov_dummy_ref1'. Another choice is to let __gcov_flush calls __gcov_dump + __gcov_reset -- but the dump_completed state needs to be saved and restored. David http://codereview.appspot.com/6276043/
Re: [google] libgcov workaround for weak reference issue (issue 6276043)
Renamed to __gcov_dummy_ref1 and __gcov_dummy_ref2. I'd prefer that approach for now to keep the differences with trunk to a minimum. Thanks, Teresa On Fri, Jun 1, 2012 at 2:18 PM, davi...@google.com wrote: Ok with better naming for the dummy function such as '__gcov_dummy_ref1'. Another choice is to let __gcov_flush calls __gcov_dump + __gcov_reset -- but the dump_completed state needs to be saved and restored. David http://codereview.appspot.com/6276043/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
Re: [google] libgcov workaround for weak reference issue (issue 6276043)
ok. thanks, David On Fri, Jun 1, 2012 at 2:26 PM, Teresa Johnson tejohn...@google.com wrote: Renamed to __gcov_dummy_ref1 and __gcov_dummy_ref2. I'd prefer that approach for now to keep the differences with trunk to a minimum. Thanks, Teresa On Fri, Jun 1, 2012 at 2:18 PM, davi...@google.com wrote: Ok with better naming for the dummy function such as '__gcov_dummy_ref1'. Another choice is to let __gcov_flush calls __gcov_dump + __gcov_reset -- but the dump_completed state needs to be saved and restored. David http://codereview.appspot.com/6276043/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
