Re: [Geany-devel] [RFC] Document Messages
On Mon, 07 Nov 2011 17:51:38 -0800, Matthew wrote: On 11/07/2011 02:28 PM, Enrico Tröger wrote: On Mon, 07 Nov 2011 01:00:49 -0800, Matthew wrote: Hi, I actually have a plugin I've been working on that does exactly that. It's a really simplified search bar that pops-up under the editor window and it's basically a clone of Firefox's find bar. The only In what way this is better than the search field in the toolbar? Just curious. Navigation (next/prev), highlighting all matches, and case-sensitive matching (not sure toolbar search supports these?). It's basically somewhere between the find dialog and the toolbar search field feature-wise, but in a better location ... right below the the editor where your attention is probably already focused, and it can be shown and hidden with keybindings. Ok, got it :). The toolbar search indeed doesn't support most of these features, it is really intended as a super quick search, case-insensitive and easy. Though focussing, backward srarching and highlighting all matches is possible with existing keybindings. Nevertheless, your plugin seems to fill another gap, so just release it to the wild! :D Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc pgpqlHzFiZIG0.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
Am Montag, den 07.11.2011, 23:28 +0100 schrieb Enrico Tröger: In what way this is better than the search field in the toolbar? Another point which wasn't mentioned in previous replies: It just shows up if you request it via keybinding. Otherwise it won't be displayed (if I understood Matthew correctly) and saves space on the screen. :) Regards, Dominic -- Dominic Hopf dma...@googlemail.com http://dominichopf.de/ Key Fingerprint: A7DF C4FC 07AE 4DDC 5CA0 BD93 AAB0 6019 CA7D 868D signature.asc Description: This is a digitally signed message part ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
Am 07.11.2011 08:30, schrieb Matthew Brush: It's not currently implemented, but assuming it's not too tough to add a (hidden?) preference, then it would be trivial to make this code do it. Would keep it deactivated in the first time to do some kind of only test. Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On 11/7/11 5:12 AM, Matthew Brush wrote: Hi all, I started working on something I'm calling document messages for lack of a better name. Put another way, GtkInfoBar :) The changes add a new document function called `document_show_message()` which will either show a GtkInfoBar on top of the Scintilla widget with the message or just show a modal dialog depending if the GTK+ version supports GtkInfoBar (2.18). I've only ported `monitor_reload_file()` and `monitor_resave_missing_file()` to use the new function for now, because I needed something to test with. The commits are here: https://github.com/codebrainz/geany/commits/document-messages And a screenshot is here: https://github.com/codebrainz/misc/raw/master/screenshots/geany-document-message.png Feedback is welcome. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel looks good, isn't it possible to change find in current file UI in the same manner, as in firefox, would be pretty usable imho. Regards, Alexander ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On 11/07/2011 12:51 AM, Alexander Petukhov wrote: On 11/7/11 5:12 AM, Matthew Brush wrote: Hi all, I started working on something I'm calling document messages for lack of a better name. Put another way, GtkInfoBar :) The changes add a new document function called `document_show_message()` which will either show a GtkInfoBar on top of the Scintilla widget with the message or just show a modal dialog depending if the GTK+ version supports GtkInfoBar (2.18). I've only ported `monitor_reload_file()` and `monitor_resave_missing_file()` to use the new function for now, because I needed something to test with. The commits are here: https://github.com/codebrainz/geany/commits/document-messages And a screenshot is here: https://github.com/codebrainz/misc/raw/master/screenshots/geany-document-message.png Feedback is welcome. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel looks good, isn't it possible to change find in current file UI in the same manner, as in firefox, would be pretty usable imho. I actually have a plugin I've been working on that does exactly that. It's a really simplified search bar that pops-up under the editor window and it's basically a clone of Firefox's find bar. The only difference is that it has an Advanced button that opens the normal find dialog which has way more options. I can't see something like this ever replacing the normal find dialog since the find dialog is so much more powerful, but it could possibly replace the find thing in the toolbar. At some point in the near future I'll push the plugin's code to a Github repository. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On Mon, Nov 7, 2011 at 8:00 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 11/07/2011 12:51 AM, Alexander Petukhov wrote: On 11/7/11 5:12 AM, Matthew Brush wrote: Hi all, I started working on something I'm calling document messages for lack of a better name. Put another way, GtkInfoBar :) The changes add a new document function called `document_show_message()` which will either show a GtkInfoBar on top of the Scintilla widget with the message or just show a modal dialog depending if the GTK+ version supports GtkInfoBar (2.18). I've only ported `monitor_reload_file()` and `monitor_resave_missing_file()` to use the new function for now, because I needed something to test with. The commits are here: https://github.com/codebrainz/geany/commits/document-messages And a screenshot is here: https://github.com/codebrainz/misc/raw/master/screenshots/geany-document-message.png Feedback is welcome. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel looks good, isn't it possible to change find in current file UI in the same manner, as in firefox, would be pretty usable imho. I actually have a plugin I've been working on that does exactly that. It's a really simplified search bar that pops-up under the editor window and it's basically a clone of Firefox's find bar. The only difference is that it has an Advanced button that opens the normal find dialog which has way more options. I can't see something like this ever replacing the normal find dialog since the find dialog is so much more powerful, but it could possibly replace the find thing in the toolbar. At some point in the near future I'll push the plugin's code to a Github repository. Like this idea, get a move on :) Cheers Lex Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
Le 07/11/2011 02:12, Matthew Brush a écrit : Hi all, I started working on something I'm calling document messages for lack of a better name. Put another way, GtkInfoBar :) The changes add a new document function called `document_show_message()` which will either show a GtkInfoBar on top of the Scintilla widget with the message or just show a modal dialog depending if the GTK+ version supports GtkInfoBar (2.18). I've only ported `monitor_reload_file()` and `monitor_resave_missing_file()` to use the new function for now, because I needed something to test with. The commits are here: https://github.com/codebrainz/geany/commits/document-messages And a screenshot is here: https://github.com/codebrainz/misc/raw/master/screenshots/geany-document-message.png Feedback is welcome. I haven't checked the code much, nor tested it, though: First, I of course like the in-tab messaging idea :) I planned to do this sometime, but never did basically because we haven't GtkInfoBar. However, I'm not sure fallback to modal dialog is that good… let me explain: a GtkInfoBar is a kind of non-intrusive messaging to the user, where modal dialogs (or dialogs in general) is intrusive. This means one could easily ignore the info bar but not the dialog. Also, I've seen you removed the close button from `monitor_resave_missing_file()`. With an info bar, it makes sense, no need for 2 buttons doing exactly the same [1]. But what what a dialog is used? So basically I very much like the infor bar thing, but not necessarily the degradation to a dialog. Cheers, Colomban [1] although I guess closing the tab would lead to a second notification about closing an unsaved file… annoying. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
Am 07.11.2011 16:34, schrieb Colomban Wendling: However, I'm not sure fallback to modal dialog is that good… let me explain: a GtkInfoBar is a kind of non-intrusive messaging to the user, where modal dialogs (or dialogs in general) is intrusive. This means one could easily ignore the info bar but not the dialog. I assumed the editor widget would be frozen/set read-only until the info bar is processed by the user, so both seem intrusive. OTOH the info bar would probably allow switching documents without doing anything which would solve a (for me) major annoyance with the modal dialog when ctrl-tabbing through docs. So not equally intrusive. What solution can you suggest? I find the info bar superior and don't care about the fallback really. Best regards. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
Le 07/11/2011 16:40, Thomas Martitz a écrit : Am 07.11.2011 16:34, schrieb Colomban Wendling: However, I'm not sure fallback to modal dialog is that good… let me explain: a GtkInfoBar is a kind of non-intrusive messaging to the user, where modal dialogs (or dialogs in general) is intrusive. This means one could easily ignore the info bar but not the dialog. I assumed the editor widget would be frozen/set read-only until the info bar is processed by the user, so both seem intrusive. Didn't though it'd freeze the editor (and AFAIK Matthew's code didn't do that), but that's not a bad idea and would somewhat solve the issue I'm raising, since both would then basically avoid touching the file until answering. OTOH the info bar would probably allow switching documents without doing anything which would solve a (for me) major annoyance with the modal dialog when ctrl-tabbing through docs. So not equally intrusive. What solution can you suggest? I find the info bar superior and don't care about the fallback really. Basically none apart depending on 2.18, but your freeze proposal might be OK. Cheers, Colomban ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On Mon, 07 Nov 2011 01:00:49 -0800, Matthew wrote: Hi, I actually have a plugin I've been working on that does exactly that. It's a really simplified search bar that pops-up under the editor window and it's basically a clone of Firefox's find bar. The only In what way this is better than the search field in the toolbar? Just curious. Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc pgpmKwI1xSSmG.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
2011/11/8 Enrico Tröger enrico.troe...@uvena.de: On Mon, 07 Nov 2011 01:00:49 -0800, Matthew wrote: Hi, I actually have a plugin I've been working on that does exactly that. It's a really simplified search bar that pops-up under the editor window and it's basically a clone of Firefox's find bar. The only In what way this is better than the search field in the toolbar? Just curious. Hi Enrico, the main one for me is that there is no way to bind a key to use the toolbar search instead of the search dialog. Since no toolbar keybindings are defined I guessed it was hard? Cheers Lex Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On Tue, Nov 8, 2011 at 11:14 AM, Colomban Wendling lists@herbesfolles.org wrote: Le 08/11/2011 00:17, Lex Trotman a écrit : 2011/11/8 Enrico Tröger enrico.troe...@uvena.de: On Mon, 07 Nov 2011 01:00:49 -0800, Matthew wrote: Hi, I actually have a plugin I've been working on that does exactly that. It's a really simplified search bar that pops-up under the editor window and it's basically a clone of Firefox's find bar. The only In what way this is better than the search field in the toolbar? Just curious. Hi Enrico, the main one for me is that there is no way to bind a key to use the toolbar search instead of the search dialog. Since no toolbar keybindings are defined I guessed it was hard? It must exist since I have it bound to F7 ;) Prefs - Keybindings - Focus - Switch to Search Bar Great, now I can swap it to ctrl-f and find to f7 or something, and my muscle memory will be the same for firefox and Geany, sweet :) Cheers Lex Cheers, Colomban ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On 11/07/2011 07:40 AM, Thomas Martitz wrote: Am 07.11.2011 16:34, schrieb Colomban Wendling: However, I'm not sure fallback to modal dialog is that good… let me explain: a GtkInfoBar is a kind of non-intrusive messaging to the user, where modal dialogs (or dialogs in general) is intrusive. This means one could easily ignore the info bar but not the dialog. I assumed the editor widget would be frozen/set read-only until the info bar is processed by the user, so both seem intrusive. It doesn't currently do this, but it would be trivial. Out of curiosity, why is this important? The way I see it, if a file was changed on disk, the user wants to do one of three things: 1) Reload the file from disk, over-writing their changes in the buffer. 2) Ignore the changes on disk and continue editing the file, possibly saving with a new filename later. 3) Close the document? (which can be done by clicking the tab close button which is just above where the infobar pops up). Maybe there is some use-case I'm not seeing? OTOH the info bar would probably allow switching documents without doing anything which would solve a (for me) major annoyance with the modal dialog when ctrl-tabbing through docs. So not equally intrusive. This was my #1 inspiration for writing this. What solution can you suggest? I find the info bar superior and don't care about the fallback really. The fallback is only to support GTK+ v2.16, since it doesn't have GtkInfoBar yet. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On 11/07/2011 02:28 PM, Enrico Tröger wrote: On Mon, 07 Nov 2011 01:00:49 -0800, Matthew wrote: Hi, I actually have a plugin I've been working on that does exactly that. It's a really simplified search bar that pops-up under the editor window and it's basically a clone of Firefox's find bar. The only In what way this is better than the search field in the toolbar? Just curious. Navigation (next/prev), highlighting all matches, and case-sensitive matching (not sure toolbar search supports these?). It's basically somewhere between the find dialog and the toolbar search field feature-wise, but in a better location ... right below the the editor where your attention is probably already focused, and it can be shown and hidden with keybindings. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
Am 07.11.2011 02:12, schrieb Matthew Brush: Hi all, I started working on something I'm calling document messages for lack of a better name. Put another way, GtkInfoBar :) The changes add a new document function called `document_show_message()` which will either show a GtkInfoBar on top of the Scintilla widget with the message or just show a modal dialog depending if the GTK+ version supports GtkInfoBar (2.18). I've only ported `monitor_reload_file()` and `monitor_resave_missing_file()` to use the new function for now, because I needed something to test with. The commits are here: https://github.com/codebrainz/geany/commits/document-messages And a screenshot is here: https://github.com/codebrainz/misc/raw/master/screenshots/geany-document-message.png Feedback is welcome. Didn't check the code or run a test, but based on screenshot looks useful. Is there a way to swith between current popup infobox and this slide? Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Document Messages
On 11/06/2011 11:22 PM, Frank Lanitz wrote: Am 07.11.2011 02:12, schrieb Matthew Brush: Hi all, I started working on something I'm calling document messages for lack of a better name. Put another way, GtkInfoBar :) The changes add a new document function called `document_show_message()` which will either show a GtkInfoBar on top of the Scintilla widget with the message or just show a modal dialog depending if the GTK+ version supports GtkInfoBar (2.18). I've only ported `monitor_reload_file()` and `monitor_resave_missing_file()` to use the new function for now, because I needed something to test with. The commits are here: https://github.com/codebrainz/geany/commits/document-messages And a screenshot is here: https://github.com/codebrainz/misc/raw/master/screenshots/geany-document-message.png Feedback is welcome. Didn't check the code or run a test, but based on screenshot looks useful. Is there a way to swith between current popup infobox and this slide? Hi Frank, It's not currently implemented, but assuming it's not too tough to add a (hidden?) preference, then it would be trivial to make this code do it. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
