Re: [gem5-dev] Review Request 3800: x86: fix Mul1u instruction
> On Feb. 4, 2017, 8:21 a.m., Jason Lowe-Power wrote: > > Lol, that code is hard to understand. But, LGTM. > > > > What are you using to test this? Any chance you can commit the test so we > > don't accidentally break this again in the future? This bug was manifesting in the ROCr runtime while it is loading libraries, it manifested as a segfualt (unmapped addr panic) because an address calculation was corrupted due to this instruction. I manually tested this instruction by comparing its output to the result of 64b multiplication using __uint128_t. This is a perfect example of where instruction tests would be useful. It only seemed to give bad output with certain inputs, which gave the error the appearance of being non-deterministic. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3800/#review9400 --- On Feb. 3, 2017, 4:13 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3800/ > --- > > (Updated Feb. 3, 2017, 4:13 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11778:c76b78110490 > --- > x86: fix Mul1u instruction > > the Mul1uFlags and Mul1u instructions perform > the 64b multiplication using only 64b registers, however the > method used causes the high 64b to be corrupted for certain > inputs. here we fix the computation. > > > Diffs > - > > src/arch/x86/isa/microops/regop.isa > ed89cb178ecd7586296d2a2e83595174474db554 > > Diff: http://reviews.gem5.org/r/3800/diff/ > > > Testing > --- > > > Thanks, > > Tony Gutierrez > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3807: misc: fix includes in util/systemc
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3807/#review9405 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 5, 2017, 2:06 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3807/ > --- > > (Updated Feb. 5, 2017, 2:06 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11809:54adb162f4ea > --- > misc: fix includes in util/systemc > > This fixes compilation errors with clang on OS X. > > > Diffs > - > > util/systemc/sc_module.cc c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3807/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3807: misc: fix includes in util/systemc
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3807/#review9404 --- Ship it! Indeed, I have tested it, now it works - Matthias Jung On Feb. 5, 2017, 2:06 nachm., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3807/ > --- > > (Updated Feb. 5, 2017, 2:06 nachm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11809:54adb162f4ea > --- > misc: fix includes in util/systemc > > This fixes compilation errors with clang on OS X. > > > Diffs > - > > util/systemc/sc_module.cc c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3807/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3527: misc: Clean up and complete the gem5<->SystemC-TLM bridge [1/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3527/ --- (Updated Feb. 5, 2017, 2:07 p.m.) Review request for Default. Repository: gem5 Description --- Changeset 11794:3b95cfab373f --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [1/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Restructure the existing sources in preparation of the addition of the new Master Port. * Refractor names to allow for distinction of the slave and master port. * Replace the Makefile by a SConstruct. Diffs - configs/common/MemConfig.py c10c50cb8ac9 util/tlm/sc_ext.hh c10c50cb8ac9 util/tlm/sc_ext.cc c10c50cb8ac9 util/tlm/sc_mm.hh c10c50cb8ac9 util/tlm/sc_mm.cc c10c50cb8ac9 util/tlm/sc_peq.hh PRE-CREATION util/tlm/sc_port.hh c10c50cb8ac9 util/tlm/sc_port.cc c10c50cb8ac9 util/tlm/sc_slave_port.hh PRE-CREATION util/tlm/sc_slave_port.cc PRE-CREATION util/tlm/sc_target.hh c10c50cb8ac9 util/tlm/sc_target.cc c10c50cb8ac9 util/tlm/sim_control.hh PRE-CREATION util/tlm/sim_control.cc PRE-CREATION util/tlm/tgen.cfg c10c50cb8ac9 util/tlm/tlm.py c10c50cb8ac9 util/tlm/tlm_elastic.py c10c50cb8ac9 util/tlm/Makefile c10c50cb8ac9 util/tlm/examples/slave_port/SConstruct PRE-CREATION util/tlm/examples/slave_port/main.cc PRE-CREATION util/tlm/examples/slave_port/run_gem5.sh PRE-CREATION util/tlm/examples/slave_port/sc_target.hh PRE-CREATION util/tlm/examples/slave_port/sc_target.cc PRE-CREATION util/tlm/examples/slave_port/tgen.cfg PRE-CREATION util/tlm/examples/slave_port/tlm.py PRE-CREATION util/tlm/examples/slave_port/tlm_elastic.py PRE-CREATION util/tlm/main.cc c10c50cb8ac9 util/tlm/run_gem5.sh c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3527/diff/ Testing --- The examples provided in util/tlm (now util/tlm/examples/slave_port) still compile and run error free. Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3807: misc: fix includes in util/systemc
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3807/ --- (Updated Feb. 5, 2017, 2:06 p.m.) Review request for Default. Repository: gem5 Description --- Changeset 11809:54adb162f4ea --- misc: fix includes in util/systemc This fixes compilation errors with clang on OS X. Diffs - util/systemc/sc_module.cc c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3807/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3807: misc: fix includes in util/systemc
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3807/ --- Review request for Default. Repository: gem5 Description --- Changeset 11809:54adb162f4ea --- misc: fix includes in util/systemc This fixes compilation errors with clang on OS X. Diffs - util/systemc/sc_module.cc c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3807/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3799: misc: Clean up and complete the gem5<->SystemC-TLM bridge [10/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3799/ --- (Updated Feb. 5, 2017, 1:56 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [10/10] Repository: gem5 Description (updated) --- Changeset 11803:ee5f72396d89 --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [10/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Add callbacks for the Gem5SimControl that are called at before and after simulate() Diffs - util/tlm/sim_control.hh PRE-CREATION util/tlm/sim_control.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3799/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3798: misc: Clean up and complete the gem5<->SystemC-TLM bridge [9/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3798/ --- (Updated Feb. 5, 2017, 1:55 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [9/10] Repository: gem5 Description (updated) --- Changeset 11802:31b809f6c634 --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [9/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Pay for the header delay that the gem5 XBar annotates to packets. Diffs - util/tlm/sc_master_port.cc PRE-CREATION util/tlm/sc_slave_port.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3798/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3797: misc: Clean up and complete the gem5<->SystemC-TLM bridge [8/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3797/ --- (Updated Feb. 5, 2017, 1:54 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [8/10] Repository: gem5 Description (updated) --- Changeset 11801:de4b2f94184c --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [8/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * bugfix: The BEGIN_RESP also needs to be handled when END_REQ was skipped and ' == blockingRequest && phase == tlm::BEGIN_RESP' evaluates to true. Diffs - util/tlm/sc_slave_port.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3797/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3796: misc: Clean up and complete the gem5<->SystemC-TLM bridge [7/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3796/ --- (Updated Feb. 5, 2017, 1:54 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [7/10] Repository: gem5 Description (updated) --- Changeset 11800:b5ad6c483119 --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [7/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Implement 'pipe through' for gem5 Packets (see explanation below) Basically, this patch ensures that all transactions that originated in the gem5 world are converted back to the original packet when entering the gem5 world. So far, this only worked for packets that are responded to by a SyctemC component (e.g. when a gem5 CPU sends a request to a SystemC memory). By implementing the 'pipe through' this patch ensures, that packets that are responded to by a gem5 component (e.g. when a gem5 CPU sends a request to a gem5 memory via a SystemC interconnect) are handled properly. Diffs - util/tlm/sc_ext.hh c10c50cb8ac9 util/tlm/sc_ext.cc c10c50cb8ac9 util/tlm/sc_master_port.hh PRE-CREATION util/tlm/sc_master_port.cc PRE-CREATION util/tlm/sc_slave_port.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3796/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3775: misc: Clean up and complete the gem5<->SystemC-TLM bridge [5/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3775/ --- (Updated Feb. 5, 2017, 1:53 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [5/10] Repository: gem5 Description (updated) --- Changeset 11798:3a490c57058d --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [5/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Introduce transactor modules that represent the gem5 ports in the SystemC world. * Update the SimControl module and let it keep track of the gem5 ports. Diffs - util/tlm/slave_transactor.hh PRE-CREATION util/tlm/slave_transactor.cc PRE-CREATION util/tlm/sc_slave_port.cc PRE-CREATION util/tlm/sim_control.hh PRE-CREATION util/tlm/sim_control.cc PRE-CREATION util/tlm/sim_control_if.hh PRE-CREATION util/tlm/examples/master_port/main.cc PRE-CREATION util/tlm/examples/master_port/tlm.py PRE-CREATION util/tlm/examples/slave_port/main.cc PRE-CREATION util/tlm/examples/slave_port/run_gem5.sh PRE-CREATION util/tlm/examples/slave_port/tlm.py PRE-CREATION util/tlm/master_transactor.hh PRE-CREATION util/tlm/master_transactor.cc PRE-CREATION util/tlm/sc_master_port.hh PRE-CREATION util/tlm/sc_master_port.cc PRE-CREATION util/tlm/sc_slave_port.hh PRE-CREATION Diff: http://reviews.gem5.org/r/3775/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3528: misc: Clean up and complete the gem5<->SystemC-TLM bridge [2/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3528/ --- (Updated Feb. 5, 2017, 1:52 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [2/10] Repository: gem5 Description (updated) --- Changeset 11795:321da7e75035 --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [2/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Add the Master Port. * Add an example application that isslustrates its use. Diffs - util/tlm/sc_master_port.hh PRE-CREATION util/tlm/sc_master_port.cc PRE-CREATION util/tlm/sim_control.cc PRE-CREATION util/tlm/examples/master_port/tlm.py PRE-CREATION util/tlm/examples/master_port/traffic_generator.hh PRE-CREATION util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION util/tlm/examples/master_port/SConstruct PRE-CREATION util/tlm/examples/master_port/main.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3528/diff/ Testing --- A simple example application consisting of a TLM traffic generator and a gem5 memory is part of the patch. Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3686: misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/ --- (Updated Feb. 5, 2017, 1:52 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/10] Repository: gem5 Description (updated) --- Changeset 11796:362dd9be3b96 --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Simplify the Slave Port by using a simple_initiator_socket. Diffs - util/tlm/sc_slave_port.hh PRE-CREATION util/tlm/sc_slave_port.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3686/diff/ Testing --- Example applications are still running. Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3527: misc: Clean up and complete the gem5<->SystemC-TLM bridge [1/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3527/ --- (Updated Feb. 5, 2017, 1:52 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [1/10] Repository: gem5 Description (updated) --- Changeset 11794:3b95cfab373f --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [1/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Restructure the existing sources in preparation of the addition of the new Master Port. * Refractor names to allow for distinction of the slave and master port. * Replace the Makefile by a SConstruct. Diffs - configs/common/MemConfig.py c10c50cb8ac9 util/tlm/sc_ext.hh c10c50cb8ac9 util/tlm/sc_ext.cc c10c50cb8ac9 util/tlm/sc_mm.hh c10c50cb8ac9 util/tlm/sc_mm.cc c10c50cb8ac9 util/tlm/sc_peq.hh PRE-CREATION util/tlm/sc_port.hh c10c50cb8ac9 util/tlm/sc_port.cc c10c50cb8ac9 util/tlm/sc_slave_port.hh PRE-CREATION util/tlm/sc_slave_port.cc PRE-CREATION util/tlm/sc_target.hh c10c50cb8ac9 util/tlm/sc_target.cc c10c50cb8ac9 util/tlm/sim_control.hh PRE-CREATION util/tlm/sim_control.cc PRE-CREATION util/tlm/tgen.cfg c10c50cb8ac9 util/tlm/tlm.py c10c50cb8ac9 util/tlm/tlm_elastic.py c10c50cb8ac9 util/tlm/Makefile c10c50cb8ac9 util/tlm/examples/slave_port/SConstruct PRE-CREATION util/tlm/examples/slave_port/main.cc PRE-CREATION util/tlm/examples/slave_port/run_gem5.sh PRE-CREATION util/tlm/examples/slave_port/sc_target.hh PRE-CREATION util/tlm/examples/slave_port/sc_target.cc PRE-CREATION util/tlm/examples/slave_port/tgen.cfg PRE-CREATION util/tlm/examples/slave_port/tlm.py PRE-CREATION util/tlm/examples/slave_port/tlm_elastic.py PRE-CREATION util/tlm/main.cc c10c50cb8ac9 util/tlm/run_gem5.sh c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3527/diff/ Testing --- The examples provided in util/tlm (now util/tlm/examples/slave_port) still compile and run error free. Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3695: misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3695/ --- (Updated Feb. 5, 2017, 1:43 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/10] Repository: gem5 Description (updated) --- Changeset 11813:50707c26c991 --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Move common code of the example to a common directory. * Move the cli parsing from the SimControl module to a separate example object. * Add comments describing the Gem5SimControl module. Diffs (updated) - util/tlm/sim_control.hh PRE-CREATION util/tlm/sim_control.cc PRE-CREATION util/tlm/examples/common/cli_parser.hh PRE-CREATION util/tlm/examples/common/cli_parser.cc PRE-CREATION util/tlm/examples/common/report_handler.hh PRE-CREATION util/tlm/examples/common/report_handler.cc PRE-CREATION util/tlm/examples/master_port/SConstruct PRE-CREATION util/tlm/examples/master_port/main.cc PRE-CREATION util/tlm/examples/slave_port/SConstruct PRE-CREATION util/tlm/examples/slave_port/main.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3695/diff/ Testing --- Examples compile and run. Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/ --- (Updated Feb. 5, 2017, 1:15 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] Repository: gem5 Description (updated) --- Changeset 11815:357f61d007cd --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Update the README Diffs (updated) - util/tlm/README c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3777/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3774: misc: Implement the Base SystemC Module as an sc_channel.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3774/ --- (Updated Feb. 5, 2017, 1:08 p.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 11808:e0223da68c32 --- misc: Implement the Base SystemC Module as an sc_channel. Implementing the Module as an sc_channel allows derived classes to provide SystemC interfaces. Other SystemC modules can connect to these interfaces. This meachanism can be used to control gem5 and acces gem5 components from within arbitrary SystemC moduels. Since sc_channel is derived from sc_module, this patch does not break compatibility with existing code. Diffs (updated) - util/systemc/sc_module.cc c10c50cb8ac9 util/systemc/sc_module.hh c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3774/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev