[gem5-dev] Build failed in Jenkins: compiler-checks #74

2021-05-19 Thread jenkins-no-reply--- via gem5-dev 
See 


Changes:

[gabe.black] cpu: Eliminate some macros in the minor CPU.

[Giacomo Travaglini] arch-arm: Fix FEAT_VMID16 for Self Hosted debug

[Bobby R. Bruce] base: Add GEM5_DEPRECATED_ENUM_VAL

[Bobby R. Bruce] tests,util: Remove Clang Version <6 from compiler tests

[Bobby R. Bruce] tests,util: Remove Clang Versions <6 from Docker Build

[Bobby R. Bruce] tests,util: Add Ubuntu 20.04 Clang Dockerfile

[Bobby R. Bruce] tests,util: Add Clang version 10 and 11 to Cloudbuild

[Bobby R. Bruce] util,tests: Add Clang version 10 and 11 to the compiler tests


--
Started by user Bobby R. Bruce
Running as SYSTEM
Building in workspace 
Selected Git installation does not exist. Using Default
The recommended git tool is: NONE
No credentials specified
 > git rev-parse --resolve-git-dir 
 >  # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://gem5.googlesource.com/public/gem5 # 
 > timeout=10
Fetching upstream changes from https://gem5.googlesource.com/public/gem5
 > git --version # timeout=10
 > git --version # 'git version 2.25.1'
 > git fetch --tags --force --progress -- 
 > https://gem5.googlesource.com/public/gem5 
 > +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git rev-parse refs/remotes/origin/develop^{commit} # timeout=10
Checking out Revision 0fd71ca168cf350fa6ea5369cc742fa5cfa8524b 
(refs/remotes/origin/develop)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0fd71ca168cf350fa6ea5369cc742fa5cfa8524b # timeout=10
Commit message: "util,tests: Add Clang version 10 and 11 to the compiler tests"
 > git rev-list --no-walk 49000fc3b6c81a8480dcd300d12ee091a141dbb3 # timeout=10
[compiler-checks] $ /bin/sh -xe /tmp/jenkins3877823697404501744.sh
+ ./util/compiler-tests.sh -j 12
Starting build tests with 'gcc-version-10'...
'gcc-version-10' was found in the comprehensive tests. All ISAs will be built.
  * Building target 'NULL_MOESI_CMP_token.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_CMP_token.fast' with 'gcc-version-10'...
Done.
  * Building target 'ARM.opt' with 'gcc-version-10'...
Done.
  * Building target 'ARM.fast' with 'gcc-version-10'...
Done.
  * Building target 'X86.opt' with 'gcc-version-10'...
Done.
  * Building target 'X86.fast' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_hammer.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_hammer.fast' with 'gcc-version-10'...
Done.
  * Building target 'RISCV.opt' with 'gcc-version-10'...
Done.
  * Building target 'RISCV.fast' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_CMP_directory.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_CMP_directory.fast' with 'gcc-version-10'...
Done.
  * Building target 'SPARC.opt' with 'gcc-version-10'...
Done.
  * Building target 'SPARC.fast' with 'gcc-version-10'...
Done.
  * Building target 'X86_MOESI_AMD_Base.opt' with 'gcc-version-10'...
Done.
  * Building target 'X86_MOESI_AMD_Base.fast' with 'gcc-version-10'...
Done.
  * Building target 'POWER.opt' with 'gcc-version-10'...
Done.
  * Building target 'POWER.fast' with 'gcc-version-10'...
Done.
  * Building target 'GCN3_X86.opt' with 'gcc-version-10'...
Done.
  * Building target 'GCN3_X86.fast' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MESI_Two_Level.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MESI_Two_Level.fast' with 'gcc-version-10'...
Done.
  * Building target 'ARM_MESI_Three_Level.opt' with 'gcc-version-10'...
Done.
  * Building target 'ARM_MESI_Three_Level.fast' with 'gcc-version-10'...
Done.
  * Building target 'Garnet_standalone.opt' with 'gcc-version-10'...
Done.
  * Building target 'Garnet_standalone.fast' with 'gcc-version-10'...
Done.
  * Building target 'MIPS.opt' with 'gcc-version-10'...
Done.
  * Building target 'MIPS.fast' with 'gcc-version-10'...
Done.
Starting build tests with 'gcc-version-9'...
  * Building target 'MIPS.opt' with 'gcc-version-9'...
Done.
  * Building target 'MIPS.fast' with 'gcc-version-9'...
Done.
Starting build tests with 'gcc-version-8'...
  * Building target 'NULL_MOESI_hammer.opt' with 'gcc-version-8'...
Done.
  * Building target 'NULL_MOESI_hammer.fast' with 'gcc-version-8'...
Done.
Starting build tests with 'gcc-version-7'...
  * Building target 'RISCV.opt' with 'gcc-version-7'...
Done.
  * Building target 'RISCV.fast' with 'gcc-version-7'...
Done.
Starting build tests with 'gcc-version-6'...
  * Building target 'GCN3_X86.opt' with 'gcc-version-6'...
  ! Failed with exit code 2.
  * Building target 'GCN3_X86.fast' with 'gcc-version-6'...
  ! Failed with exit code 2.
Starting build

[gem5-dev] Change in gem5/gem5[develop]: base: Deprecate the UNIT_* macros.

2021-05-19 Thread Gabe Black (Gerrit) via gem5-dev 
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45559 )


Change subject: base: Deprecate the UNIT_* macros.
..

base: Deprecate the UNIT_* macros.

These macros, like all macros, do not respect namespaces. Using these
macros effectively undoes the benefit of putting the unit classes into a
namespace.

Change-Id: I098a7d6951ccc334ae03a3a2e4da6a0f7c1e2263
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45559
Tested-by: kokoro 
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
---
M src/base/stats/units.hh
1 file changed, 35 insertions(+), 13 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/stats/units.hh b/src/base/stats/units.hh
index 87e6025..8f15e80 100644
--- a/src/base/stats/units.hh
+++ b/src/base/stats/units.hh
@@ -31,24 +31,46 @@

 #include 

+#include "base/compiler.hh"
 #include "base/cprintf.hh"

 /**
  * Convenience macros to declare the unit of a stat.
  */
-#define UNIT_CYCLE Stats::Units::Cycle::get()
-#define UNIT_TICK Stats::Units::Tick::get()
-#define UNIT_SECOND Stats::Units::Second::get()
-#define UNIT_BIT Stats::Units::Bit::get()
-#define UNIT_BYTE Stats::Units::Byte::get()
-#define UNIT_JOULE Stats::Units::Joule::get()
-#define UNIT_VOLT Stats::Units::Volt::get()
-#define UNIT_CELSIUS Stats::Units::DegreeCelsius::get()
-#define UNIT_RATE(T1, T2) Stats::Units::Rate::get()
-#define UNIT_RATIO Stats::Units::Ratio::get()
-#define UNIT_COUNT Stats::Units::Count::get()
-#define UNIT_WATT Stats::Units::Watt::get()
-#define UNIT_UNSPECIFIED Stats::Units::Unspecified::get()
+#define UNIT_CYCLE GEM5_DEPRECATED_MACRO( \
+UNIT_CYCLE, Stats::Units::Cycle::get(), \
+"Use Stats::Units::Cycle::get()")
+#define UNIT_TICK GEM5_DEPRECATED_MACRO( \
+UNIT_TICK, Stats::Units::Tick::get(), "Use  
Stats::Units::Tick::get()")

+#define UNIT_SECOND GEM5_DEPRECATED_MACRO( \
+UNIT_SECOND, Stats::Units::Second::get(), \
+"Use Stats::Units::Second::get()")
+#define UNIT_BIT GEM5_DEPRECATED_MACRO( \
+UNIT_BIT, Stats::Units::Bit::get(), "Use Stats::Units::Bit::get()")
+#define UNIT_BYTE GEM5_DEPRECATED_MACRO( \
+UNIT_BYTE, Stats::Units::Byte::get(), "Use  
Stats::Units::Byte::get()")

+#define UNIT_JOULE GEM5_DEPRECATED_MACRO( \
+UNIT_JOULE, Stats::Units::Joule::get(), \
+"Use Stats::Units::Joule::get()")
+#define UNIT_VOLT GEM5_DEPRECATED_MACRO( \
+UNIT_VOLD, Stats::Units::Volt::get(), "Use  
Stats::Units::Volt::get()")

+#define UNIT_CELSIUS GEM5_DEPRECATED_MACRO( \
+UNIT_CELSIUS, Stats::Units::DegreeCelsius::get(), \
+"Use Stats::Units::DegreeCelsius::get()")
+#define UNIT_RATE(T1, T2) GEM5_DEPRECATED_MACRO( \
+UNIT_RATE, (Stats::Units::Rate::get()), \
+"Use Stats::Units::Rate::get()")
+#define UNIT_RATIO GEM5_DEPRECATED_MACRO( \
+UNIT_RATIO, Stats::Units::Ratio::get(), \
+"Use Stats::Units::Ratio::get()")
+#define UNIT_COUNT GEM5_DEPRECATED_MACRO( \
+UNIT_COUNT, Stats::Units::Count::get(), \
+"Use Stats::Units::Count::get()")
+#define UNIT_WATT GEM5_DEPRECATED_MACRO( \
+UNIT_WATT, Stats::Units::Watt::get(), "Use  
Stats::Units::Watt::get()")

+#define UNIT_UNSPECIFIED GEM5_DEPRECATED_MACRO( \
+UNIT_UNSPECIFIED, Stats::Units::Unspecified::get(), \
+"Use Stats::Units::Unspecified::get()")

 namespace Stats {




5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the  
submitted one.

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45559
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I098a7d6951ccc334ae03a3a2e4da6a0f7c1e2263
Gerrit-Change-Number: 45559
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Hoa Nguyen 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Avoid an unused expression error in GEM5_DEPRECATED_MACRO.

2021-05-19 Thread Gabe Black (Gerrit) via gem5-dev 
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45719 )


Change subject: base: Avoid an unused expression error in  
GEM5_DEPRECATED_MACRO.

..

base: Avoid an unused expression error in GEM5_DEPRECATED_MACRO.

If the lambda in that macro is not actually called, clang complains
about an unused expression which breaks the build.

Change-Id: Id8708944cbac4c937e833583da0c2c18422230c0
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45719
Reviewed-by: Daniel Carvalho 
Maintainer: Bobby R. Bruce 
Tested-by: kokoro 
---
M src/base/compiler.hh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Carvalho: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/compiler.hh b/src/base/compiler.hh
index ba2a4bc..17124be 100644
--- a/src/base/compiler.hh
+++ b/src/base/compiler.hh
@@ -132,7 +132,7 @@
 // The definition must be an c++ expression and not a statement because of  
how

 // the original macro is wrapped.
 #  define GEM5_DEPRECATED_MACRO(name, definition, message) \
- ([](){GEM5_DEPRECATED(message) int name{}; return name;},  
(definition))
+ ([](){GEM5_DEPRECATED(message) int name{}; return name;}(),  
(definition))
 // This version is for macros which are statement-like, which frequently  
use
 // "do {} while (0)" to make their syntax look more like normal c++  
statements.

 #  define GEM5_DEPRECATED_MACRO_STMT(name, definition, message) \

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45719
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id8708944cbac4c937e833583da0c2c18422230c0
Gerrit-Change-Number: 45719
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: Check the KVM API version with a static_assert instead of macros.

2021-05-19 Thread Gabe Black (Gerrit) via gem5-dev 
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45743 )


Change subject: cpu: Check the KVM API version with a static_assert instead  
of macros.

..

cpu: Check the KVM API version with a static_assert instead of macros.

Change-Id: Id8d52e25c4582ad802ee59facad5a1c31c2aa216
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45743
Reviewed-by: Andreas Sandberg 
Reviewed-by: Daniel Carvalho 
Maintainer: Andreas Sandberg 
Tested-by: kokoro 
---
M src/cpu/kvm/vm.cc
1 file changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
  Daniel Carvalho: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/cpu/kvm/vm.cc b/src/cpu/kvm/vm.cc
index e0a500c..13f774e 100644
--- a/src/cpu/kvm/vm.cc
+++ b/src/cpu/kvm/vm.cc
@@ -53,11 +53,14 @@
 #include "params/KvmVM.hh"
 #include "sim/system.hh"

-#define EXPECTED_KVM_API_VERSION 12
+namespace
+{

-#if EXPECTED_KVM_API_VERSION != KVM_API_VERSION
-#error Unsupported KVM version
-#endif
+constexpr int ExpectedKvmApiVersion = 12;
+static_assert(KVM_API_VERSION == ExpectedKvmApiVersion,
+"Unsupported KVM version");
+
+} // anonymous namespace

 Kvm *Kvm::instance = NULL;

@@ -75,7 +78,7 @@
 fatal("KVM: Failed to open /dev/kvm\n");

 apiVersion = ioctl(KVM_GET_API_VERSION);
-if (apiVersion != EXPECTED_KVM_API_VERSION)
+if (apiVersion != ExpectedKvmApiVersion)
 fatal("KVM: Incompatible API version\n");

 vcpuMMapSize = ioctl(KVM_GET_VCPU_MMAP_SIZE);



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the  
submitted one.

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45743
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id8d52e25c4582ad802ee59facad5a1c31c2aa216
Gerrit-Change-Number: 45743
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Fix the compiler guard in base/pollevent.hh

2021-05-19 Thread Gabe Black (Gerrit) via gem5-dev 
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45740 )


Change subject: base: Fix the compiler guard in base/pollevent.hh
..

base: Fix the compiler guard in base/pollevent.hh

This was not formatted consistently with other files.

Change-Id: Ibee20cb6f458fcf99a1729cb8bd50c9c536d6639
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45740
Reviewed-by: Daniel Carvalho 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M src/base/pollevent.hh
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Daniel Carvalho: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/pollevent.hh b/src/base/pollevent.hh
index 5efa4fd..1930bb3 100644
--- a/src/base/pollevent.hh
+++ b/src/base/pollevent.hh
@@ -26,8 +26,8 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */

-#ifndef __POLLEVENT_H__
-#define __POLLEVENT_H__
+#ifndef __BASE_POLLEVENT_HH__
+#define __BASE_POLLEVENT_HH__

 #include 

@@ -110,4 +110,4 @@
  */
 extern PollQueue pollQueue;

-#endif // __POLLEVENT_H__
+#endif // __BASE_POLLEVENT_HH__

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45740
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibee20cb6f458fcf99a1729cb8bd50c9c536d6639
Gerrit-Change-Number: 45740
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Eliminate macros in base/inet.hh|cc.

2021-05-19 Thread Gabe Black (Gerrit) via gem5-dev 
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45739 )


Change subject: base: Eliminate macros in base/inet.hh|cc.
..

base: Eliminate macros in base/inet.hh|cc.

The macro in base/inet.hh, HOME_ADDRESS_OPTION, was not used by
anything. The IP6_EXTENSION macro was replaced with a static inline
function called ip6Extension. The awkward nested ternary operator was
replaced with an equivalent ||.

Change-Id: I100894811159b39b964a49c43a09d493d1268739
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45739
Reviewed-by: Daniel Carvalho 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M src/base/inet.cc
M src/base/inet.hh
2 files changed, 15 insertions(+), 10 deletions(-)

Approvals:
  Daniel Carvalho: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/inet.cc b/src/base/inet.cc
index 7ae36c3..bc9c516 100644
--- a/src/base/inet.cc
+++ b/src/base/inet.cc
@@ -274,12 +274,18 @@
 return true;
 }

-#define IP6_EXTENSION(nxt) (nxt == IP_PROTO_HOPOPTS) ? true : \
-   (nxt == IP_PROTO_ROUTING) ? true : \
-   (nxt == IP_PROTO_FRAGMENT) ? true : \
-   (nxt == IP_PROTO_AH) ? true : \
-   (nxt == IP_PROTO_ESP) ? true: \
-   (nxt == IP_PROTO_DSTOPTS) ? true : false
+namespace
+{
+
+bool
+ip6Extension(uint8_t nxt)
+{
+return nxt == IP_PROTO_HOPOPTS || nxt == IP_PROTO_ROUTING ||
+nxt == IP_PROTO_FRAGMENT || nxt == IP_PROTO_AH ||
+nxt == IP_PROTO_ESP || nxt == IP_PROTO_DSTOPTS;
+}
+
+} // anonymous namespace

 /* Scan the IP6 header for all header extensions
  * and return the number of headers found
@@ -292,7 +298,7 @@
 int len = 0;
 int all = plen();

-while (IP6_EXTENSION(nxt)) {
+while (ip6Extension(nxt)) {
 const Ip6Opt *ext = (const Ip6Opt *)data;
 nxt = ext->nxt();
 len += ext->len();
@@ -315,7 +321,7 @@
 Ip6Opt* opt = NULL;
 int all = plen();

-while (IP6_EXTENSION(nxt)) {
+while (ip6Extension(nxt)) {
 opt = (Ip6Opt *)data;
 if (nxt == ext_type) {
 break;
@@ -340,7 +346,7 @@
 uint8_t nxt = ip6_nxt;
 int all = plen();

-while (IP6_EXTENSION(nxt)) {
+while (ip6Extension(nxt)) {
 const Ip6Opt *ext = (const Ip6Opt *)data;
 nxt = ext->nxt();
 data += ext->len();
diff --git a/src/base/inet.hh b/src/base/inet.hh
index b9c0c1c..f0d1f75 100644
--- a/src/base/inet.hh
+++ b/src/base/inet.hh
@@ -565,7 +565,6 @@
 ip6_addr_t addr;
 };

-#define HOME_ADDRESS_OPTION 0xC9
 struct GEM5_PACKED ip6_opt_dstopts
 {
 uint8_t type;

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45739
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I100894811159b39b964a49c43a09d493d1268739
Gerrit-Change-Number: 45739
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: Make some compiler guards consistent with the other files.

2021-05-19 Thread Gabe Black (Gerrit) via gem5-dev 
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45741 )


Change subject: cpu: Make some compiler guards consistent with the other  
files.

..

cpu: Make some compiler guards consistent with the other files.

Change-Id: I9dd007ad4ea0e1ff93677333a2f5e1f9b5d2a8fa
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45741
Reviewed-by: Daniel Carvalho 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M src/cpu/pred/ltage.hh
M src/cpu/pred/statistical_corrector.hh
M src/cpu/pred/tage.hh
M src/cpu/pred/tage_base.hh
M src/cpu/pred/tage_sc_l.hh
M src/cpu/pred/tage_sc_l_64KB.hh
M src/cpu/pred/tage_sc_l_8KB.hh
7 files changed, 21 insertions(+), 24 deletions(-)

Approvals:
  Daniel Carvalho: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/cpu/pred/ltage.hh b/src/cpu/pred/ltage.hh
index 8e8d428..95139b7 100644
--- a/src/cpu/pred/ltage.hh
+++ b/src/cpu/pred/ltage.hh
@@ -46,8 +46,8 @@
  * one that predicted when the prediction is incorrect.
  */

-#ifndef __CPU_PRED_LTAGE
-#define __CPU_PRED_LTAGE
+#ifndef __CPU_PRED_LTAGE_HH__
+#define __CPU_PRED_LTAGE_HH__


 #include 
@@ -109,4 +109,4 @@
 ThreadID tid, Addr branch_pc, bool cond_branch, void* ) override;
 };

-#endif // __CPU_PRED_LTAGE
+#endif // __CPU_PRED_LTAGE_HH__
diff --git a/src/cpu/pred/statistical_corrector.hh  
b/src/cpu/pred/statistical_corrector.hh

index c36a168..1175568 100644
--- a/src/cpu/pred/statistical_corrector.hh
+++ b/src/cpu/pred/statistical_corrector.hh
@@ -39,8 +39,8 @@
  * Statistical corrector base class
  */

-#ifndef __CPU_PRED_STATISTICAL_CORRECTOR_HH
-#define __CPU_PRED_STATISTICAL_CORRECTOR_HH
+#ifndef __CPU_PRED_STATISTICAL_CORRECTOR_HH__
+#define __CPU_PRED_STATISTICAL_CORRECTOR_HH__

 #include "base/statistics.hh"
 #include "base/types.hh"
@@ -273,4 +273,4 @@

 virtual size_t getSizeInBits() const;
 };
-#endif//__CPU_PRED_STATISTICAL_CORRECTOR_HH
+#endif//__CPU_PRED_STATISTICAL_CORRECTOR_HH__
diff --git a/src/cpu/pred/tage.hh b/src/cpu/pred/tage.hh
index 71ee4ac5..ec4fce9 100644
--- a/src/cpu/pred/tage.hh
+++ b/src/cpu/pred/tage.hh
@@ -45,8 +45,8 @@
  * one that predicted when the prediction is incorrect.
  */

-#ifndef __CPU_PRED_TAGE
-#define __CPU_PRED_TAGE
+#ifndef __CPU_PRED_TAGE_HH__
+#define __CPU_PRED_TAGE_HH__

 #include 

@@ -90,4 +90,4 @@
 virtual void squash(ThreadID tid, void *bp_history) override;
 };

-#endif // __CPU_PRED_TAGE
+#endif // __CPU_PRED_TAGE_HH__
diff --git a/src/cpu/pred/tage_base.hh b/src/cpu/pred/tage_base.hh
index 4199299..e79fac3 100644
--- a/src/cpu/pred/tage_base.hh
+++ b/src/cpu/pred/tage_base.hh
@@ -45,8 +45,8 @@
  * one that predicted when the prediction is incorrect.
  */

-#ifndef __CPU_PRED_TAGE_BASE
-#define __CPU_PRED_TAGE_BASE
+#ifndef __CPU_PRED_TAGE_BASE_HH__
+#define __CPU_PRED_TAGE_BASE_HH__

 #include 

@@ -505,4 +505,4 @@
 } stats;
 };

-#endif // __CPU_PRED_TAGE_BASE
+#endif // __CPU_PRED_TAGE_BASE_HH__
diff --git a/src/cpu/pred/tage_sc_l.hh b/src/cpu/pred/tage_sc_l.hh
index 10e3c1f..6691928 100644
--- a/src/cpu/pred/tage_sc_l.hh
+++ b/src/cpu/pred/tage_sc_l.hh
@@ -40,8 +40,8 @@
  * It consits of a TAGE + a statistical corrector (SC) + a loop predictor  
(L)

  */

-#ifndef __CPU_PRED_TAGE_SC_L
-#define __CPU_PRED_TAGE_SC_L
+#ifndef __CPU_PRED_TAGE_SC_L_HH__
+#define __CPU_PRED_TAGE_SC_L_HH__

 #include "cpu/pred/ltage.hh"
 #include "cpu/pred/statistical_corrector.hh"
@@ -185,5 +185,4 @@

 };

-#endif // __CPU_PRED_TAGE_SC_L
-
+#endif // __CPU_PRED_TAGE_SC_L_HH__
diff --git a/src/cpu/pred/tage_sc_l_64KB.hh b/src/cpu/pred/tage_sc_l_64KB.hh
index 87b49be..00bc896 100644
--- a/src/cpu/pred/tage_sc_l_64KB.hh
+++ b/src/cpu/pred/tage_sc_l_64KB.hh
@@ -42,8 +42,8 @@
  * http://www.jilp.org/cbp2016/code/AndreSeznecLimited.tar.gz
  */

-#ifndef __CPU_PRED_TAGE_SC_L_64KB
-#define __CPU_PRED_TAGE_SC_L_64KB
+#ifndef __CPU_PRED_TAGE_SC_L_64KB_HH__
+#define __CPU_PRED_TAGE_SC_L_64KB_HH__

 #include "cpu/pred/tage_sc_l.hh"
 #include "params/TAGE_SC_L_64KB.hh"
@@ -132,5 +132,4 @@
 TAGE_SC_L_64KB(const TAGE_SC_L_64KBParams );
 };

-#endif // __CPU_PRED_TAGE_SC_L_64KB
-
+#endif // __CPU_PRED_TAGE_SC_L_64KB_HH__
diff --git a/src/cpu/pred/tage_sc_l_8KB.hh b/src/cpu/pred/tage_sc_l_8KB.hh
index 2cabbca..fe249de 100644
--- a/src/cpu/pred/tage_sc_l_8KB.hh
+++ b/src/cpu/pred/tage_sc_l_8KB.hh
@@ -39,8 +39,8 @@
  * 8KB TAGE-SC-L branch predictor (devised by Andre Seznec)
  */

-#ifndef __CPU_PRED_TAGE_SC_L_8KB
-#define __CPU_PRED_TAGE_SC_L_8KB
+#ifndef __CPU_PRED_TAGE_SC_L_8KB_HH__
+#define __CPU_PRED_TAGE_SC_L_8KB_HH__

 #include "cpu/pred/tage_sc_l.hh"
 #include "params/TAGE_SC_L_8KB.hh"
@@ -112,5 +112,4 @@
 TAGE_SC_L_8KB(const TAGE_SC_L_8KBParams );
 };

-#endif // __CPU_PRED_TAGE_SC_L_8KB
-
+#endif // __CPU_PRED_TAGE_SC_L_8KB_HH__

--
To view, visit

[gem5-dev] Build failed in Jenkins: weekly #26

2021-05-19 Thread jenkins-no-reply--- via gem5-dev 
See 

Changes:

[matthew.poremba] arch-vega,arch-gcn3: Fix s_cmp_lt_u32

[odanrc] misc: Add missing compiler.hh include

[Bobby R. Bruce] arch-gcn3: Fixing .fast compilation for gcn3

[Bobby R. Bruce] base,tests: Fix debug.cc tests to reflect new API changes

[gabe.black] cpu: Stop using macros for constants in the 
multiperpsective_perceptron.

[Giacomo Travaglini] arch-arm: Using 16 bit VMID

[Giacomo Travaglini] arch-arm: Implement ARMv8.1-VMID16, 16-bit VMID

[Giacomo Travaglini] arch-arm: Enable ARMv8.1-VMID16 by default

[Bobby R. Bruce] arch-arm: Fix unused variable error with ARM .fast comp

[cpmetz] fastmodel: Fix scx_get_parameter_list for ARM fastmodels.

[gabe.black] base: Surround a DPRINTFS parameter in ()s.

[gabe.black] cpu: Eliminate some macros in the minor CPU.

[Giacomo Travaglini] arch-arm: Fix FEAT_VMID16 for Self Hosted debug

[Bobby R. Bruce] base: Add GEM5_DEPRECATED_ENUM_VAL

[Bobby R. Bruce] tests,util: Remove Clang Version <6 from compiler tests

[Bobby R. Bruce] tests,util: Remove Clang Versions <6 from Docker Build

[Bobby R. Bruce] tests,util: Add Ubuntu 20.04 Clang Dockerfile

[Bobby R. Bruce] tests,util: Add Clang version 10 and 11 to Cloudbuild

[Bobby R. Bruce] util,tests: Add Clang version 10 and 11 to the compiler tests


--
[...truncated 579.40 KB...]
 [ CXX] GCN3_X86/sim/sim_events.cc -> .o
 [ CXX] GCN3_X86/sim/sim_object.cc -> .o
 [ CXX] GCN3_X86/sim/sub_system.cc -> .o
 [SOPARMHH] TickedObject -> GCN3_X86/params/TickedObject.hh
 [ CXX] GCN3_X86/sim/ticked_object.cc -> .o
 [ CXX] GCN3_X86/sim/simulate.cc -> .o
 [ CXX] GCN3_X86/sim/stat_control.cc -> .o
 [ CXX] GCN3_X86/sim/stat_register.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/ClockDomain.hh
 [ CXX] GCN3_X86/sim/clock_domain.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/VoltageDomain.hh
 [ CXX] GCN3_X86/sim/voltage_domain.cc -> .o
 [ CXX] GCN3_X86/sim/se_signal.cc -> .o
 [ CXX] GCN3_X86/sim/linear_solver.cc -> .o
 [GENERATE] x86 -> GCN3_X86/arch/remote_gdb.hh
 [CONFIG H] USE_KVM, 1 -> GCN3_X86/config/use_kvm.hh
 [ TRACING]  -> GCN3_X86/debug/WorkItems.hh
 [ CXX] GCN3_X86/sim/system.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/DVFS.hh
 [SOPARMHH] DVFSHandler -> GCN3_X86/params/DVFSHandler.hh
 [ CXX] GCN3_X86/sim/dvfs_handler.cc -> .o
 [ CXX] GCN3_X86/sim/clocked_object.cc -> .o
 [ CXX] GCN3_X86/sim/mathexpr.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/PowerDomain.hh
 [SOPARMHH] PowerDomain -> GCN3_X86/params/PowerDomain.hh
 [ CXX] GCN3_X86/sim/power_state.cc -> .o
 [ CXX] GCN3_X86/sim/power_domain.cc -> .o
 [ CXX] GCN3_X86/sim/stats.cc -> .o
 [ CXX] GCN3_X86/sim/workload.cc -> .o
 [ CXX] GCN3_X86/sim/mem_pool.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/Fault.hh
 [ CXX] GCN3_X86/sim/faults.cc -> .o
 [ CXX] GCN3_X86/sim/process.cc -> .o
 [ CXX] GCN3_X86/sim/fd_array.cc -> .o
 [ CXX] GCN3_X86/sim/fd_entry.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/SyscallBase.hh
 [ CXX] GCN3_X86/sim/mem_state.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/PseudoInst.hh
 [ CXX] GCN3_X86/sim/pseudo_inst.cc -> .o
 [ CXX] GCN3_X86/sim/syscall_emul.cc -> .o
 [ CXX] GCN3_X86/sim/syscall_desc.cc -> .o
 [ CXX] GCN3_X86/sim/vma.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/ProbeVerbose.hh
 [ CXX] GCN3_X86/sim/probe/probe.cc -> .o
 [ CXX] GCN3_X86/sim/power/power_model.cc -> .o
 [SOPARMHH] MathExprPowerModel -> GCN3_X86/params/MathExprPowerModel.hh
 [ CXX] GCN3_X86/sim/power/mathexpr_powermodel.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/ThermalDomain.hh
 [ CXX] GCN3_X86/sim/power/thermal_domain.cc -> .o
 [SOPARMHH] ThermalCapacitor -> GCN3_X86/params/ThermalCapacitor.hh
 [SOPARMHH] ThermalReference -> GCN3_X86/params/ThermalReference.hh
 [SOPARMHH] ThermalResistor -> GCN3_X86/params/ThermalResistor.hh
 [ CXX] GCN3_X86/sim/power/thermal_model.cc -> .o
 [SOPARMHH] ThermalNode -> GCN3_X86/params/ThermalNode.hh
 [ CXX] GCN3_X86/sim/power/thermal_node.cc -> .o
 [ CXX] GCN3_X86/gpu-compute/comm.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/GPUDisp.hh
 [ TRACING]  -> GCN3_X86/debug/GPUExec.hh
 [ TRACING]  -> GCN3_X86/debug/GPUFetch.hh
 [ TRACING]  -> GCN3_X86/debug/GPUPort.hh
 [ TRACING]  -> GCN3_X86/debug/GPUPrefetch.hh
 [ TRACING]  -> GCN3_X86/debug/GPUReg.hh
 [ TRACING]  -> GCN3_X86/debug/GPURename.hh
 [ TRACING]  -> GCN3_X86/debug/GPUSync.hh
 [ TRACING]  -> GCN3_X86/debug/GPUTLB.hh
 [ TRACING]  -> GCN3_X86/debug/GPUCommandProc.hh
 [ENUMDECL] GPUStaticInstFlags -> GCN3_X86/enums/GPUStaticInstFlags.hh
 [ TRACING]  -> GCN3_X86/debug/GPUSRF.hh
 [SOPARMHH] SimplePoolManager -> GCN3_X86/params/SimplePoolManager.hh
 [ TRACING]  -> GCN3_X86/debug/GPUVRF.hh
 [ENUMDECL] GfxVersion -> GCN3_X86/enums/GfxVersion.hh
 [ CXX] GCN3_X86/gpu-compute/compute_unit.cc -> .o
 [ TRACING]  -> GCN3_X86/debug/GPUAgentDisp.hh
 [ TRACING]  ->

[gem5-dev] Change in gem5/gem5[develop]: tests,util: Add Clang version 10 and 11 to Cloudbuild

2021-05-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev 
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45682 )


Change subject: tests,util: Add Clang version 10 and 11 to Cloudbuild
..

tests,util: Add Clang version 10 and 11 to Cloudbuild

This change will build the clang compilation images for version 10 and
11 in gem5's Google Cloud Build.  These can then be used in the gem5
compilation tests.

Change-Id: I9fc902bbaf3262c018231873abfe7fdedd13172c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45682
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M util/cloudbuild/cloudbuild_create_images.yaml
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/util/cloudbuild/cloudbuild_create_images.yaml  
b/util/cloudbuild/cloudbuild_create_images.yaml

index ba8ec9a..b81de98 100644
--- a/util/cloudbuild/cloudbuild_create_images.yaml
+++ b/util/cloudbuild/cloudbuild_create_images.yaml
@@ -90,6 +90,20 @@
 - name: 'gcr.io/cloud-builders/docker'
   args: ['build',
 '-t',
+'gcr.io/$PROJECT_ID/clang-version-10:latest',
+'--build-arg', 'version=10',
+'util/dockerfiles/ubuntu-20.04_clang-version']
+
+- name: 'gcr.io/cloud-builders/docker'
+  args: ['build',
+'-t',
+'gcr.io/$PROJECT_ID/clang-version-11:latest',
+'--build-arg', 'version=11',
+'util/dockerfiles/ubuntu-20.04_clang-version']
+
+- name: 'gcr.io/cloud-builders/docker'
+  args: ['build',
+'-t',
 'gcr.io/$PROJECT_ID/gcn-gpu:latest',
 'util/dockerfiles/gcn-gpu']

@@ -106,5 +120,7 @@
  'gcr.io/$PROJECT_ID/clang-version-7:latest',
  'gcr.io/$PROJECT_ID/clang-version-8:latest',
  'gcr.io/$PROJECT_ID/clang-version-9:latest',
+ 'gcr.io/$PROJECT_ID/clang-version-10:latest',
+ 'gcr.io/$PROJECT_ID/clang-version-11:latest',
  'gcr.io/$PROJECT_ID/gcn-gpu:latest']
 timeout: 18000s # 5 Hours

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45682
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9fc902bbaf3262c018231873abfe7fdedd13172c
Gerrit-Change-Number: 45682
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: tests,util: Remove Clang Version <6 from compiler tests

2021-05-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev 
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45679 )


Change subject: tests,util: Remove Clang Version <6 from compiler tests
..

tests,util: Remove Clang Version <6 from compiler tests

gem5 will now only support Clang Version 6 and above:
https://gem5-review.googlesource.com/c/public/gem5/+/45621

Change-Id: I21c418e73560a0332675ced06c6937b109b7ef10
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45679
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M util/compiler-tests.sh
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/util/compiler-tests.sh b/util/compiler-tests.sh
index f8d4f5d..f56a064 100755
--- a/util/compiler-tests.sh
+++ b/util/compiler-tests.sh
@@ -20,9 +20,7 @@
 "clang-version-8"
 "clang-version-7"
 "clang-version-6.0"
-"clang-version-5.0"
-"clang-version-4.0"
-"clang-version-3.9" )
+   )

 # A subset of the above list: these images will build against every target,
 # ignoring builds_per_compiler.

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45679
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I21c418e73560a0332675ced06c6937b109b7ef10
Gerrit-Change-Number: 45679
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: tests,util: Remove Clang Versions <6 from Docker Build

2021-05-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev 
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45680 )


Change subject: tests,util: Remove Clang Versions <6 from Docker Build
..

tests,util: Remove Clang Versions <6 from Docker Build

cloud_create_image.yaml is used by Google Cloud build to build the
docker images for the gem5 project. We no longer support Clang versions
<6: https://gem5-review.googlesource.com/c/public/gem5/+/45621. As such
we no longer need to build the image for Clang versions 3.9, 4, and 5.
These were primarily used for the compiler tests, which have been
updated to only test Clang versions >=6.

Change-Id: I0c41cf0f189b4e24976f19a519018f3c9e87bb90
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45680
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M util/cloudbuild/cloudbuild_create_images.yaml
1 file changed, 0 insertions(+), 24 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/util/cloudbuild/cloudbuild_create_images.yaml  
b/util/cloudbuild/cloudbuild_create_images.yaml

index bed950a..ba8ec9a 100644
--- a/util/cloudbuild/cloudbuild_create_images.yaml
+++ b/util/cloudbuild/cloudbuild_create_images.yaml
@@ -62,27 +62,6 @@
 - name: 'gcr.io/cloud-builders/docker'
   args: ['build',
 '-t',
-'gcr.io/$PROJECT_ID/clang-version-3.9:latest',
-'--build-arg', 'version=3.9',
-'util/dockerfiles/ubuntu-18.04_clang-version']
-
-- name: 'gcr.io/cloud-builders/docker'
-  args: ['build',
-'-t',
-'gcr.io/$PROJECT_ID/clang-version-4.0:latest',
-'--build-arg', 'version=4.0',
-'util/dockerfiles/ubuntu-18.04_clang-version']
-
-- name: 'gcr.io/cloud-builders/docker'
-  args: ['build',
-'-t',
-'gcr.io/$PROJECT_ID/clang-version-5.0:latest',
-'--build-arg', 'version=5.0',
-'util/dockerfiles/ubuntu-18.04_clang-version']
-
-- name: 'gcr.io/cloud-builders/docker'
-  args: ['build',
-'-t',
 'gcr.io/$PROJECT_ID/clang-version-6.0:latest',
 '--build-arg', 'version=6.0',
 'util/dockerfiles/ubuntu-18.04_clang-version']
@@ -123,9 +102,6 @@
  'gcr.io/$PROJECT_ID/gcc-version-8:latest',
  'gcr.io/$PROJECT_ID/gcc-version-9:latest',
  'gcr.io/$PROJECT_ID/gcc-version-10:latest',
- 'gcr.io/$PROJECT_ID/clang-version-3.9:latest',
- 'gcr.io/$PROJECT_ID/clang-version-4.0:latest',
- 'gcr.io/$PROJECT_ID/clang-version-5.0:latest',
  'gcr.io/$PROJECT_ID/clang-version-6.0:latest',
  'gcr.io/$PROJECT_ID/clang-version-7:latest',
  'gcr.io/$PROJECT_ID/clang-version-8:latest',

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45680
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0c41cf0f189b4e24976f19a519018f3c9e87bb90
Gerrit-Change-Number: 45680
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: tests,util: Add Ubuntu 20.04 Clang Dockerfile

2021-05-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev 
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45681 )


Change subject: tests,util: Add Ubuntu 20.04 Clang Dockerfile
..

tests,util: Add Ubuntu 20.04 Clang Dockerfile

This new Dockerfiles enables use to build images for Clang versions 10
and 11, which are not available in Ubuntu 18.04 via APT.

Change-Id: I374a1c679377b7402a63241da34f9f4f7f5c7468
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45681
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
A util/dockerfiles/ubuntu-20.04_clang-version/Dockerfile
1 file changed, 54 insertions(+), 0 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/util/dockerfiles/ubuntu-20.04_clang-version/Dockerfile  
b/util/dockerfiles/ubuntu-20.04_clang-version/Dockerfile

new file mode 100644
index 000..447a4dd
--- /dev/null
+++ b/util/dockerfiles/ubuntu-20.04_clang-version/Dockerfile
@@ -0,0 +1,54 @@
+# Copyright (c) 2021 The Regents of the University of California
+# All Rights Reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met: redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer;
+# redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution;
+# neither the name of the copyright holders nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+FROM ubuntu:20.04
+
+# Valid version values:
+# 6.0
+# 7
+# 8
+# 9
+# 10
+# 11
+ARG version
+
+ENV DEBIAN_FRONTEND=noninteractive
+RUN apt -y update
+RUN apt -y upgrade
+RUN apt -y install git m4 scons zlib1g zlib1g-dev libprotobuf-dev \
+protobuf-compiler libprotoc-dev libgoogle-perftools-dev python3-dev \
+python3-six python-is-python3 doxygen libboost-all-dev  
libhdf5-serial-dev \

+python3-pydot libpng-dev clang-${version} make
+
+RUN apt-get --purge -y remove gcc
+
+RUN update-alternatives --install \
+/usr/bin/clang++ clang++ /usr/bin/clang++-${version} 100
+RUN update-alternatives --install \
+/usr/bin/clang clang /usr/bin/clang-${version} 100
+RUN update-alternatives --install \
+/usr/bin/c++ c++ /usr/bin/clang++-${version} 100
+RUN update-alternatives --install \
+/usr/bin/cc cc /usr/bin/clang-${version} 100

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45681
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I374a1c679377b7402a63241da34f9f4f7f5c7468
Gerrit-Change-Number: 45681
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: util,tests: Add Clang version 10 and 11 to the compiler tests

2021-05-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev 
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45683 )


Change subject: util,tests: Add Clang version 10 and 11 to the compiler  
tests

..

util,tests: Add Clang version 10 and 11 to the compiler tests

Change-Id: Iad14cc57dad54a9b36f6304f882e55077f5f0156
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45683
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M util/compiler-tests.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/util/compiler-tests.sh b/util/compiler-tests.sh
index f56a064..41fdfa8 100755
--- a/util/compiler-tests.sh
+++ b/util/compiler-tests.sh
@@ -16,6 +16,8 @@
 "gcc-version-7"
 "gcc-version-6"
 "gcc-version-5"
+"clang-version-11"
+"clang-version-10"
 "clang-version-9"
 "clang-version-8"
 "clang-version-7"
@@ -25,7 +27,7 @@
 # A subset of the above list: these images will build against every target,
 # ignoring builds_per_compiler.
 comprehensive=("gcc-version-10"
-   "clang-version-9")
+   "clang-version-11")

 # All build targets in build_opt/ which we want to build using each image.
 builds=("ARM"

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45683
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iad14cc57dad54a9b36f6304f882e55077f5f0156
Gerrit-Change-Number: 45683
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Add GEM5_DEPRECATED_ENUM_VAL

2021-05-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev 
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45539 )


Change subject: base: Add GEM5_DEPRECATED_ENUM_VAL
..

base: Add GEM5_DEPRECATED_ENUM_VAL

This deperecation enum works exactly the same way as GEM5_DEPRECATED
but will not expand if using GCC <6, as enum value deprecation was only
introduced in GCC 6.

Change-Id: I64fcaca0d79a353da805642e021ec1cb101cfa0e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45539
Reviewed-by: Jason Lowe-Power 
Reviewed-by: Daniel Carvalho 
Maintainer: Jason Lowe-Power 
Tested-by: kokoro 
---
M src/base/compiler.hh
M src/sim/aux_vector.hh
2 files changed, 13 insertions(+), 3 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  Daniel Carvalho: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/compiler.hh b/src/base/compiler.hh
index 4ea0dbb..ba2a4bc 100644
--- a/src/base/compiler.hh
+++ b/src/base/compiler.hh
@@ -116,6 +116,16 @@
 // Mark a c++ declaration as deprecated, with a message explaining what to  
do

 // to update to a non-deprecated alternative.
 #  define GEM5_DEPRECATED(message) [[gnu::deprecated(message)]]
+// Mark a C++ emum value as deprecated, with a message explaining what to  
do
+// to update to a non-deprecated alternative. This wraps GEM5_DEPRECATED  
but

+// is guarded by a preprocessor if directive to ensure it is not included
+// when compiled in GCC < 6, as deprecation of enum values was introduced  
in

+// GCC 6. All supported clang compilers allow enum value deprecation.
+#  if defined(__clang__) || __GNUC__ >= 6
+#define GEM5_DEPRECATED_ENUM_VAL(message) GEM5_DEPRECATED(message)
+#  else
+#define GEM5_DEPRECATED_ENUM_VAL(message)
+#  endif
 // Mark an expression-like macro as deprecated by wrapping it in some code
 // which declares and uses a deprecated variable with the same name as the
 // macro. The wrapping macro evaluates to the same thing as the original  
macro.

diff --git a/src/sim/aux_vector.hh b/src/sim/aux_vector.hh
index 55a4a05..30b 100644
--- a/src/sim/aux_vector.hh
+++ b/src/sim/aux_vector.hh
@@ -98,8 +98,8 @@
 } // namespace gem5

 #define GEM5_DEPRECATE_AT(NAME, name) M5_AT_##NAME \
-GEM5_DEPRECATED("Replace M5_AT_" #NAME " with gem5::auxv::" #name) = \
-gem5::auxv::name
+GEM5_DEPRECATED_ENUM_VAL(\
+"Replace M5_AT_" #NAME " with gem5::auxv::" #name) =  
gem5::auxv::name


 enum AuxiliaryVectorType
 {
@@ -122,7 +122,7 @@
 GEM5_DEPRECATE_AT(HWCAP, Hwcap),
 GEM5_DEPRECATE_AT(CLKTCK, Clktck),
 GEM5_DEPRECATE_AT(SECURE, Secure),
-M5_BASE_PLATFORM GEM5_DEPRECATED(
+M5_BASE_PLATFORM GEM5_DEPRECATED_ENUM_VAL(
 "Replace M5_BASE_PLATFORM with gem5::auxv::BasePlatform") =
 gem5::auxv::BasePlatform,
 GEM5_DEPRECATE_AT(RANDOM, Random),

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45539
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I64fcaca0d79a353da805642e021ec1cb101cfa0e
Gerrit-Change-Number: 45539
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-CC: Gabe Black 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Fix FEAT_VMID16 for Self Hosted debug

2021-05-19 Thread Giacomo Travaglini (Gerrit) via gem5-dev 
Giacomo Travaglini has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/45659 )


Change subject: arch-arm: Fix FEAT_VMID16 for Self Hosted debug
..

arch-arm: Fix FEAT_VMID16 for Self Hosted debug

The existing code was querying the vmidbits but it was not checking the
VTCR_EL2.VS bit, which dynamically enables/disables VMID16

Signed-off-by: Giacomo Travaglini 
Change-Id: Id1e7df758a636267173c4fcd4db99e5834f21ee9
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45659
Reviewed-by: Richard Cooper 
Tested-by: kokoro 
---
M src/arch/arm/self_debug.cc
M src/arch/arm/self_debug.hh
2 files changed, 12 insertions(+), 7 deletions(-)

Approvals:
  Richard Cooper: Looks good to me, approved
  Giacomo Travaglini: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/arch/arm/self_debug.cc b/src/arch/arm/self_debug.cc
index 5b92fb8..310ccb4 100644
--- a/src/arch/arm/self_debug.cc
+++ b/src/arch/arm/self_debug.cc
@@ -1,4 +1,5 @@
 /*
+ * Copyright (c) 2021 Arm Limited
  * Copyright (c) 2019 Metempsy Technology LSC
  * All rights reserved
  *
@@ -452,15 +453,18 @@
 bool
 BrkPoint::testVMIDMatch(ThreadContext *tc)
 {
+const bool vs = ((VTCR_t)(tc->readMiscReg(MISCREG_VTCR_EL2))).vs;
+
 uint32_t vmid_index = 55;
-if (VMID16enabled)
+if (VMID16enabled && vs)
 vmid_index = 63;
 ExceptionLevel el = currEL(tc);
 if (el == EL2)
 return false;

-uint32_t vmid = bits(tc->readMiscReg(MISCREG_VTTBR_EL2), vmid_index,  
48);

-uint32_t v = getVMIDfromReg(tc);
+vmid_t vmid = bits(tc->readMiscReg(MISCREG_VTTBR_EL2), vmid_index, 48);
+vmid_t v = getVMIDfromReg(tc, vs);
+
 return (v == vmid);
 }

@@ -520,11 +524,11 @@
 return v && SelfDebug::securityStateMatch(tc, ssc, hmc || !aarch32);
 }

-uint32_t
-BrkPoint::getVMIDfromReg(ThreadContext *tc)
+vmid_t
+BrkPoint::getVMIDfromReg(ThreadContext *tc, bool vs)
 {
 uint32_t vmid_index = 39;
-if (VMID16enabled)
+if (VMID16enabled && vs)
 vmid_index = 47;
 return bits(tc->readMiscReg(valRegIndex), vmid_index, 32);
 }
diff --git a/src/arch/arm/self_debug.hh b/src/arch/arm/self_debug.hh
index 55e74a7..d1db5cc 100644
--- a/src/arch/arm/self_debug.hh
+++ b/src/arch/arm/self_debug.hh
@@ -1,4 +1,5 @@
 /*
+ * Copyright (c) 2021 Arm Limited
  * Copyright (c) 2019 Metempsy Technology LSC
  * All rights reserved
  *
@@ -103,7 +104,7 @@
 }


-inline uint32_t getVMIDfromReg(ThreadContext *tc);
+vmid_t getVMIDfromReg(ThreadContext *tc, bool vs);

   public:
 bool testAddrMatch(ThreadContext *tc, Addr pc, uint8_t bas);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45659
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id1e7df758a636267173c4fcd4db99e5834f21ee9
Gerrit-Change-Number: 45659
Gerrit-PatchSet: 3
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Richard Cooper 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Build failed in Jenkins: compiler-checks #73

2021-05-19 Thread jenkins-no-reply--- via gem5-dev 
See 


Changes:

[odanrc] mem: Fix compilation issues in qos

[gabe.black] arch-sparc: Replace M5_HWCAP_SPARC_* constants.

[gabe.black] base: Stop both conditionally and unconditionally including cmath.

[gabe.black] base: Stop using macros to handle nan in stats/text.cc.

[gabe.black] mem: Get rid of the SET* macros in packet.cc.

[matthew.poremba] arch-vega,arch-gcn3: Fix s_cmp_lt_u32

[odanrc] misc: Add missing compiler.hh include

[Bobby R. Bruce] arch-gcn3: Fixing .fast compilation for gcn3

[Bobby R. Bruce] base,tests: Fix debug.cc tests to reflect new API changes

[gabe.black] cpu: Stop using macros for constants in the 
multiperpsective_perceptron.

[Giacomo Travaglini] arch-arm: Using 16 bit VMID

[Giacomo Travaglini] arch-arm: Implement ARMv8.1-VMID16, 16-bit VMID

[Giacomo Travaglini] arch-arm: Enable ARMv8.1-VMID16 by default

[Bobby R. Bruce] arch-arm: Fix unused variable error with ARM .fast comp

[cpmetz] fastmodel: Fix scx_get_parameter_list for ARM fastmodels.

[gabe.black] base: Surround a DPRINTFS parameter in ()s.


--
Started by timer
Running as SYSTEM
Building in workspace 
Selected Git installation does not exist. Using Default
The recommended git tool is: NONE
No credentials specified
 > git rev-parse --resolve-git-dir 
 >  # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://gem5.googlesource.com/public/gem5 # 
 > timeout=10
Fetching upstream changes from https://gem5.googlesource.com/public/gem5
 > git --version # timeout=10
 > git --version # 'git version 2.25.1'
 > git fetch --tags --force --progress -- 
 > https://gem5.googlesource.com/public/gem5 
 > +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git rev-parse refs/remotes/origin/develop^{commit} # timeout=10
Checking out Revision 49000fc3b6c81a8480dcd300d12ee091a141dbb3 
(refs/remotes/origin/develop)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 49000fc3b6c81a8480dcd300d12ee091a141dbb3 # timeout=10
Commit message: "base: Surround a DPRINTFS parameter in ()s."
 > git rev-list --no-walk b1a396bfcfa66e05f28475758edb3e16e53c5047 # timeout=10
[compiler-checks] $ /bin/sh -xe /tmp/jenkins16579646993902089835.sh
+ ./util/compiler-tests.sh -j 12
Starting build tests with 'gcc-version-10'...
'gcc-version-10' was found in the comprehensive tests. All ISAs will be built.
  * Building target 'NULL_MOESI_CMP_directory.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_CMP_directory.fast' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MESI_Two_Level.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MESI_Two_Level.fast' with 'gcc-version-10'...
Done.
  * Building target 'GCN3_X86.opt' with 'gcc-version-10'...
Done.
  * Building target 'GCN3_X86.fast' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_CMP_token.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_CMP_token.fast' with 'gcc-version-10'...
Done.
  * Building target 'SPARC.opt' with 'gcc-version-10'...
Done.
  * Building target 'SPARC.fast' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_hammer.opt' with 'gcc-version-10'...
Done.
  * Building target 'NULL_MOESI_hammer.fast' with 'gcc-version-10'...
Done.
  * Building target 'ARM_MESI_Three_Level.opt' with 'gcc-version-10'...
Done.
  * Building target 'ARM_MESI_Three_Level.fast' with 'gcc-version-10'...
Done.
  * Building target 'X86_MOESI_AMD_Base.opt' with 'gcc-version-10'...
Done.
  * Building target 'X86_MOESI_AMD_Base.fast' with 'gcc-version-10'...
Done.
  * Building target 'Garnet_standalone.opt' with 'gcc-version-10'...
Done.
  * Building target 'Garnet_standalone.fast' with 'gcc-version-10'...
Done.
  * Building target 'X86.opt' with 'gcc-version-10'...
Done.
  * Building target 'X86.fast' with 'gcc-version-10'...
Done.
  * Building target 'MIPS.opt' with 'gcc-version-10'...
Done.
  * Building target 'MIPS.fast' with 'gcc-version-10'...
Done.
  * Building target 'ARM.opt' with 'gcc-version-10'...
Done.
  * Building target 'ARM.fast' with 'gcc-version-10'...
Done.
  * Building target 'POWER.opt' with 'gcc-version-10'...
Done.
  * Building target 'POWER.fast' with 'gcc-version-10'...
Done.
  * Building target 'RISCV.opt' with 'gcc-version-10'...
Done.
  * Building target 'RISCV.fast' with 'gcc-version-10'...
Done.
Starting build tests with 'gcc-version-9'...
  * Building target 'GCN3_X86.opt' with 'gcc-version-9'...
Done.
  * Building target 'GCN3_X86.fast' with 'gcc-version-9'...
Done.
Starting build tests with 'gcc-version-8'...
  * Building target 'NULL_MESI_Two_Level.opt' with 'gcc-version-8'...
Done.
  * Building target