[gem5-dev] Change in gem5/gem5[develop]: arch-gcn3: Fix writelane src0,src1 usage

2020-07-13 Thread Anthony Gutierrez (Gerrit) via gem5-dev
Anthony Gutierrez has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/29933 )


Change subject: arch-gcn3: Fix writelane src0,src1 usage
..

arch-gcn3: Fix writelane src0,src1 usage

Src1 should only be used for lane select.  The data should come
from src0.

Change-Id: Ibe960df2e56d351a3819b40194104d2972a5cd4c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/29933
Tested-by: kokoro 
Maintainer: Anthony Gutierrez 
Reviewed-by: Anthony Gutierrez 
Reviewed-by: Matt Sinclair 
---
M src/arch/gcn3/insts/instructions.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Anthony Gutierrez: Looks good to me, approved; Looks good to me, approved
  Matt Sinclair: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/arch/gcn3/insts/instructions.cc  
b/src/arch/gcn3/insts/instructions.cc

index 0256d46..b923eae 100644
--- a/src/arch/gcn3/insts/instructions.cc
+++ b/src/arch/gcn3/insts/instructions.cc
@@ -30181,7 +30181,7 @@
 assert(!(extData.NEG & 0x2));
 assert(!(extData.NEG & 0x4));

-vdst[src1.rawData() & 0x3f] = src1.rawData();
+vdst[src1.rawData() & 0x3f] = src0.rawData();

 vdst.write();
 }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29933
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibe960df2e56d351a3819b40194104d2972a5cd4c
Gerrit-Change-Number: 29933
Gerrit-PatchSet: 9
Gerrit-Owner: Anthony Gutierrez 
Gerrit-Reviewer: Anthony Gutierrez 
Gerrit-Reviewer: Matt Sinclair 
Gerrit-Reviewer: Michael LeBeane 
Gerrit-Reviewer: Tony Gutierrez 
Gerrit-Reviewer: Tuan Ta 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-gcn3: Fix writelane src0,src1 usage

2020-06-03 Thread Anthony Gutierrez (Gerrit) via gem5-dev

Hello Michael LeBeane, Tony Gutierrez,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/29933

to review the following change.


Change subject: arch-gcn3: Fix writelane src0,src1 usage
..

arch-gcn3: Fix writelane src0,src1 usage

Src1 should only be used for lane select.  The data should come
from src0.

Change-Id: Ibe960df2e56d351a3819b40194104d2972a5cd4c
---
M src/arch/gcn3/insts/instructions.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/arch/gcn3/insts/instructions.cc  
b/src/arch/gcn3/insts/instructions.cc

index 0256d46..b923eae 100644
--- a/src/arch/gcn3/insts/instructions.cc
+++ b/src/arch/gcn3/insts/instructions.cc
@@ -30181,7 +30181,7 @@
 assert(!(extData.NEG & 0x2));
 assert(!(extData.NEG & 0x4));

-vdst[src1.rawData() & 0x3f] = src1.rawData();
+vdst[src1.rawData() & 0x3f] = src0.rawData();

 vdst.write();
 }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29933
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibe960df2e56d351a3819b40194104d2972a5cd4c
Gerrit-Change-Number: 29933
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez 
Gerrit-Reviewer: Michael LeBeane 
Gerrit-Reviewer: Tony Gutierrez 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s