[gem5-dev] Change in gem5/gem5[develop]: mem: Remove units from stats description
Hoa Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40655 )
Change subject: mem: Remove units from stats description
..
mem: Remove units from stats description
The change https://gem5-review.googlesource.com/c/public/gem5/+/40622
allows units to be shown in stats dump, the units in stats
descriptions are nolonger necessary. This change removes units
from stats descriptions. However, for units that are multiples
of a supported unit (e.g. MegaBytes), the units in the descriptions
are kept until unit prefixes are supported.
Change-Id: I4d87139290a8458e87da776e4328edbd6c224546
Signed-off-by: Hoa Nguyen
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40655
Tested-by: kokoro
Reviewed-by: Jason Lowe-Power
Reviewed-by: Daniel Carvalho
Maintainer: Jason Lowe-Power
---
M src/mem/abstract_mem.cc
M src/mem/cache/compressors/base.cc
M src/mem/comm_monitor.cc
M src/mem/mem_ctrl.cc
M src/mem/qos/mem_ctrl.cc
M src/mem/xbar.cc
6 files changed, 15 insertions(+), 17 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/abstract_mem.cc b/src/mem/abstract_mem.cc
index 33379af..a3e4db8 100644
--- a/src/mem/abstract_mem.cc
+++ b/src/mem/abstract_mem.cc
@@ -123,13 +123,13 @@
ADD_STAT(numOther, UNIT_COUNT,
"Number of other requests responded to by this memory"),
ADD_STAT(bwRead, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Total read bandwidth from this memory (bytes/s)"),
+ "Total read bandwidth from this memory"),
ADD_STAT(bwInstRead, UNIT_RATE(Stats::Units::Byte,
Stats::Units::Second),
- "Instruction read bandwidth from this memory (bytes/s)"),
+ "Instruction read bandwidth from this memory"),
ADD_STAT(bwWrite, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Write bandwidth from this memory (bytes/s)"),
+ "Write bandwidth from this memory"),
ADD_STAT(bwTotal, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Total bandwidth to/from this memory (bytes/s)")
+ "Total bandwidth to/from this memory")
{
}
diff --git a/src/mem/cache/compressors/base.cc
b/src/mem/cache/compressors/base.cc
index e83cb6b..87f41a4 100644
--- a/src/mem/cache/compressors/base.cc
+++ b/src/mem/cache/compressors/base.cc
@@ -233,11 +233,10 @@
ADD_STAT(compressionSize, UNIT_COUNT,
"Number of blocks that were compressed to this power of two "
"size"),
-ADD_STAT(compressionSizeBits, UNIT_BIT,
- "Total compressed data size, in bits"),
+ADD_STAT(compressionSizeBits, UNIT_BIT, "Total compressed data size"),
ADD_STAT(avgCompressionSizeBits,
UNIT_RATE(Stats::Units::Bit, Stats::Units::Count),
- "Average compression size, in bits"),
+ "Average compression size"),
ADD_STAT(decompressions, UNIT_COUNT, "Total number of decompressions")
{
}
diff --git a/src/mem/comm_monitor.cc b/src/mem/comm_monitor.cc
index dffc8d1..8807a73 100644
--- a/src/mem/comm_monitor.cc
+++ b/src/mem/comm_monitor.cc
@@ -110,23 +110,23 @@
readBytes(0),
ADD_STAT(readBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Histogram of read bandwidth per sample period (bytes/s)"),
+ "Histogram of read bandwidth per sample period"),
ADD_STAT(totalReadBytes, UNIT_BYTE, "Number of bytes read"),
ADD_STAT(averageReadBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average read bandwidth (bytes/s)",
+ "Average read bandwidth",
totalReadBytes / simSeconds),
writtenBytes(0),
ADD_STAT(writeBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Histogram of write bandwidth (bytes/s)"),
+ "Histogram of write bandwidth"),
ADD_STAT(totalWrittenBytes,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Number of bytes written"),
ADD_STAT(averageWriteBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average write bandwidth (bytes/s)",
+ "Average write bandwidth",
totalWrittenBytes / simSeconds),
disableLatencyHists(params.disable_latency_hists),
diff --git a/src/mem/mem_ctrl.cc b/src/mem/mem_ctrl.cc
index 63c62ae..607d994 100644
--- a/src/mem/mem_ctrl.cc
+++ b/src/mem/mem_ctrl.cc
@@ -1249,10 +1249,10 @@
"Per-requestor bytes write to memory"),
ADD_STAT(requestorReadRate,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Per-requestor bytes read from memory
[gem5-dev] Change in gem5/gem5[develop]: mem: Remove units from stats description
Hoa Nguyen has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/40655 )
Change subject: mem: Remove units from stats description
..
mem: Remove units from stats description
The change https://gem5-review.googlesource.com/c/public/gem5/+/40622
allows units to be shown in stats dump, the units in stats
descriptions are nolonger necessary. This change removes units
from stats descriptions. However, for units that are multiples
of a supported unit (e.g. MegaBytes), the units in the descriptions
are kept until unit prefixes are supported.
Change-Id: I4d87139290a8458e87da776e4328edbd6c224546
Signed-off-by: Hoa Nguyen
---
M src/mem/abstract_mem.cc
M src/mem/cache/compressors/base.cc
M src/mem/comm_monitor.cc
M src/mem/mem_ctrl.cc
M src/mem/qos/mem_ctrl.cc
M src/mem/xbar.cc
6 files changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/mem/abstract_mem.cc b/src/mem/abstract_mem.cc
index 33379af..a3e4db8 100644
--- a/src/mem/abstract_mem.cc
+++ b/src/mem/abstract_mem.cc
@@ -123,13 +123,13 @@
ADD_STAT(numOther, UNIT_COUNT,
"Number of other requests responded to by this memory"),
ADD_STAT(bwRead, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Total read bandwidth from this memory (bytes/s)"),
+ "Total read bandwidth from this memory"),
ADD_STAT(bwInstRead, UNIT_RATE(Stats::Units::Byte,
Stats::Units::Second),
- "Instruction read bandwidth from this memory (bytes/s)"),
+ "Instruction read bandwidth from this memory"),
ADD_STAT(bwWrite, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Write bandwidth from this memory (bytes/s)"),
+ "Write bandwidth from this memory"),
ADD_STAT(bwTotal, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Total bandwidth to/from this memory (bytes/s)")
+ "Total bandwidth to/from this memory")
{
}
diff --git a/src/mem/cache/compressors/base.cc
b/src/mem/cache/compressors/base.cc
index e83cb6b..832dc5d6 100644
--- a/src/mem/cache/compressors/base.cc
+++ b/src/mem/cache/compressors/base.cc
@@ -234,10 +234,10 @@
"Number of blocks that were compressed to this power of two "
"size"),
ADD_STAT(compressionSizeBits, UNIT_BIT,
- "Total compressed data size, in bits"),
+ "Total compressed data size"),
ADD_STAT(avgCompressionSizeBits,
UNIT_RATE(Stats::Units::Bit, Stats::Units::Count),
- "Average compression size, in bits"),
+ "Average compression size"),
ADD_STAT(decompressions, UNIT_COUNT, "Total number of decompressions")
{
}
diff --git a/src/mem/comm_monitor.cc b/src/mem/comm_monitor.cc
index dffc8d1..8807a73 100644
--- a/src/mem/comm_monitor.cc
+++ b/src/mem/comm_monitor.cc
@@ -110,23 +110,23 @@
readBytes(0),
ADD_STAT(readBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Histogram of read bandwidth per sample period (bytes/s)"),
+ "Histogram of read bandwidth per sample period"),
ADD_STAT(totalReadBytes, UNIT_BYTE, "Number of bytes read"),
ADD_STAT(averageReadBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average read bandwidth (bytes/s)",
+ "Average read bandwidth",
totalReadBytes / simSeconds),
writtenBytes(0),
ADD_STAT(writeBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Histogram of write bandwidth (bytes/s)"),
+ "Histogram of write bandwidth"),
ADD_STAT(totalWrittenBytes,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Number of bytes written"),
ADD_STAT(averageWriteBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average write bandwidth (bytes/s)",
+ "Average write bandwidth",
totalWrittenBytes / simSeconds),
disableLatencyHists(params.disable_latency_hists),
diff --git a/src/mem/mem_ctrl.cc b/src/mem/mem_ctrl.cc
index 8832395..4ba7761 100644
--- a/src/mem/mem_ctrl.cc
+++ b/src/mem/mem_ctrl.cc
@@ -1249,10 +1249,10 @@
"Per-requestor bytes write to memory"),
ADD_STAT(requestorReadRate,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Per-requestor bytes read from memory rate (Bytes/sec)"),
+ "Per-requestor bytes read from memory rate"),
ADD_STAT(requestorWriteRate,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Per-requestor bytes write to memory rate (Bytes/sec)"),
+ "Per-requestor bytes write to memory rate"),
ADD_STAT(requestorReadAccesses, UNIT_COUNT,
"Per-requestor read serviced
