----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3839/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11893:3615e7d15a81 --------------------------- syscall_emul: style mods and small refactor to FDArray Some members were defined as public when they should have been privately declared so these were moved to the appropriate spot. The operator[] had inline specified for for an in-class definition which is redundant since inline definitions are always implicitly inline. Private members had the leading underscore applied to them to denote that they're private (consistent with style guide). Changed static const defined class variable into a constexpr with brace-list initialization. Diffs ----- src/sim/fd_array.hh 5ea85692a53ea437c95e5a199884bd3a5266f820 src/sim/fd_array.cc 5ea85692a53ea437c95e5a199884bd3a5266f820 Diff: http://reviews.gem5.org/r/3839/diff/ Testing ------- Thanks, Brandon Potter _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
