Re: [gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-21 Thread Gabe Black 
Ok, sounds good. I was thinking that sort of thing would make sense, but
didn't want to go that way unilaterally.

Gabe

On Tue, Nov 21, 2017 at 6:05 AM, Andreas Sandberg 
wrote:

> Hi Gabe,
>
> I won't have time to review them anytime soon. Since only Jason has
> offered to review some of them, I'd suggest that we go for a more
> relaxed review policy for SPARC. I would be happy for you to self
> approve these changes since you are the SPARC maintainer and there are
> no other obvious reviewers.
>
> Cheers,
> Andreas
>
>
>
> On 18/11/2017 01:45, Jason Lowe-Power wrote:
>
>> Hey Gabe,
>>
>> I'll *try* to find some time this weekend to skim them. I'll aim for
>> giving
>> at least +1, after which I'm fine with you taking responsibility for any
>> bugs and pushing :).
>>
>> I'll also try to catch up on all of the gem5 things that have been flying
>> past my inbox. We'll see how that goes, though.
>>
>> Cheers,
>> Jason
>>
>> ---
>> Jason Lowe-Power
>> Assistant Professor, Computer Science Department
>> University of California, Davis
>> 3049 Kemper Hall
>> https://faculty.engineering.ucdavis.edu/lowepower/
>>
>>
>> On Fri, Nov 17, 2017 at 3:39 PM Gabe Black  wrote:
>>
>> Hi folks. I have a series of CLs for the SPARC ISA (
>>> https://gem5-review.googlesource.com/c/public/gem5/+/5421/2, etc.) which
>>> haven'b gotten reviews in a while. I realize there may not be anyone to
>>> jump in and review SPARC changes, and I even chose to tinker with SPARC
>>> since it's a relatively quite corner where I'm not likely to disrupt
>>> anybody.
>>>
>>> I do, however, want to get those changes checked in at some point. Does
>>> anyone want to review them? Is there a point where there's been enough
>>> time
>>> for anybody who was sufficiently motivated to look at them, and I can go
>>> ahead and check them in unreviewed?
>>>
>>> Gabe
>>> ___
>>> gem5-dev mailing list
>>> gem5-dev@gem5.org
>>> http://m5sim.org/mailman/listinfo/gem5-dev
>>>
>> ___
>> gem5-dev mailing list
>> gem5-dev@gem5.org
>> http://m5sim.org/mailman/listinfo/gem5-dev
>>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
>
> ___
> gem5-dev mailing list
> gem5-dev@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
>
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-21 Thread Andreas Sandberg 

Hi Gabe,

I won't have time to review them anytime soon. Since only Jason has
offered to review some of them, I'd suggest that we go for a more
relaxed review policy for SPARC. I would be happy for you to self
approve these changes since you are the SPARC maintainer and there are
no other obvious reviewers.

Cheers,
Andreas


On 18/11/2017 01:45, Jason Lowe-Power wrote:

Hey Gabe,

I'll *try* to find some time this weekend to skim them. I'll aim for giving
at least +1, after which I'm fine with you taking responsibility for any
bugs and pushing :).

I'll also try to catch up on all of the gem5 things that have been flying
past my inbox. We'll see how that goes, though.

Cheers,
Jason

---
Jason Lowe-Power
Assistant Professor, Computer Science Department
University of California, Davis
3049 Kemper Hall
https://faculty.engineering.ucdavis.edu/lowepower/


On Fri, Nov 17, 2017 at 3:39 PM Gabe Black  wrote:


Hi folks. I have a series of CLs for the SPARC ISA (
https://gem5-review.googlesource.com/c/public/gem5/+/5421/2, etc.) which
haven'b gotten reviews in a while. I realize there may not be anyone to
jump in and review SPARC changes, and I even chose to tinker with SPARC
since it's a relatively quite corner where I'm not likely to disrupt
anybody.

I do, however, want to get those changes checked in at some point. Does
anyone want to review them? Is there a point where there's been enough time
for anybody who was sufficiently motivated to look at them, and I can go
ahead and check them in unreviewed?

Gabe
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-17 Thread Jason Lowe-Power 
Hey Gabe,

I'll *try* to find some time this weekend to skim them. I'll aim for giving
at least +1, after which I'm fine with you taking responsibility for any
bugs and pushing :).

I'll also try to catch up on all of the gem5 things that have been flying
past my inbox. We'll see how that goes, though.

Cheers,
Jason

---
Jason Lowe-Power
Assistant Professor, Computer Science Department
University of California, Davis
3049 Kemper Hall
https://faculty.engineering.ucdavis.edu/lowepower/


On Fri, Nov 17, 2017 at 3:39 PM Gabe Black  wrote:

> Hi folks. I have a series of CLs for the SPARC ISA (
> https://gem5-review.googlesource.com/c/public/gem5/+/5421/2, etc.) which
> haven'b gotten reviews in a while. I realize there may not be anyone to
> jump in and review SPARC changes, and I even chose to tinker with SPARC
> since it's a relatively quite corner where I'm not likely to disrupt
> anybody.
>
> I do, however, want to get those changes checked in at some point. Does
> anyone want to review them? Is there a point where there's been enough time
> for anybody who was sufficiently motivated to look at them, and I can go
> ahead and check them in unreviewed?
>
> Gabe
> ___
> gem5-dev mailing list
> gem5-dev@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-17 Thread Gabe Black 
Hi folks. I have a series of CLs for the SPARC ISA (
https://gem5-review.googlesource.com/c/public/gem5/+/5421/2, etc.) which
haven'b gotten reviews in a while. I realize there may not be anyone to
jump in and review SPARC changes, and I even chose to tinker with SPARC
since it's a relatively quite corner where I'm not likely to disrupt
anybody.

I do, however, want to get those changes checked in at some point. Does
anyone want to review them? Is there a point where there's been enough time
for anybody who was sufficiently motivated to look at them, and I can go
ahead and check them in unreviewed?

Gabe
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev