Re: Starting to move Gump to using Java 11
On 19/08/2021 17:53, Stefan Bodewig wrote: On 2021-08-19, Mark Thomas wrote: Many thanks for cleaning up the mess I created. You didn't create a mess here, you just uncovered an undetected bug. The -bootclasspath/p problems of xml-apis and xml-resolver are probably not really fixable. We cannot create a "patch module" easily, I'm afraid. I think we can remove xml-apis completely and build xml-resolver without any boot-type dependencies. We are no longer interested in building Xerces or Xalan against a JAXP version other than the one of the JDK anyway. +1 I had similar thoughts about removing xml-apis. It looks like Checkstyle may still have an issue and then I'll have some genuine Tomcat issues to fix. Tomcat transitvely inherits antlr4*.jar but this jar doesn't seem to contain the "runtime" package. I believe you also want https://mvnrepository.com/artifact/org.antlr/antlr4-runtime and make that a runtime dependency of checkstyle (not that I knew much about antlr). Ack. Thanks for the hint. I'm just finishing up some changes in the latest Tomcat and then I should have some time for this. Mark - To unsubscribe, e-mail: general-unsubscr...@gump.apache.org For additional commands, e-mail: general-h...@gump.apache.org
Re: Starting to move Gump to using Java 11
On 2021-08-19, Mark Thomas wrote: > Many thanks for cleaning up the mess I created. You didn't create a mess here, you just uncovered an undetected bug. The -bootclasspath/p problems of xml-apis and xml-resolver are probably not really fixable. We cannot create a "patch module" easily, I'm afraid. I think we can remove xml-apis completely and build xml-resolver without any boot-type dependencies. We are no longer interested in building Xerces or Xalan against a JAXP version other than the one of the JDK anyway. > It looks like Checkstyle may still have an issue and then I'll have > some genuine Tomcat issues to fix. Tomcat transitvely inherits antlr4*.jar but this jar doesn't seem to contain the "runtime" package. I believe you also want https://mvnrepository.com/artifact/org.antlr/antlr4-runtime and make that a runtime dependency of checkstyle (not that I knew much about antlr). Stefan - To unsubscribe, e-mail: general-unsubscr...@gump.apache.org For additional commands, e-mail: general-h...@gump.apache.org
Re: Starting to move Gump to using Java 11
On 19/08/2021 13:39, Stefan Bodewig wrote: On 2021-08-19, Stefan Bodewig wrote: It looks as if you may have uncovered a bug in Ant's build, no, the Gump descriptor has been broken before. While compiling the tests Ant didn't see the main classes it had just compiled. It could only see those of the bootstrap-ant project. The only explanation of why it has worked before I have is that bootstrap-ant has contained the classes that depend on jakarta-regexp before and now no longer does. And as Xalan contains the regex classes (I think the build has used the "unbundled" Xalan jar which does not contain regexp because of this, may be wrong) the classes and tests would be compiled now. Anyway, the "ant" project has just been built successfully. Let's see what breaks next. Many thanks for cleaning up the mess I created. Things are looking a lot better now. It looks like Checkstyle may still have an issue and then I'll have some genuine Tomcat issues to fix. Cheers, Mark - To unsubscribe, e-mail: general-unsubscr...@gump.apache.org For additional commands, e-mail: general-h...@gump.apache.org
Re: Starting to move Gump to using Java 11
On 2021-08-19, Stefan Bodewig wrote: > It looks as if you may have uncovered a bug in Ant's build, no, the Gump descriptor has been broken before. While compiling the tests Ant didn't see the main classes it had just compiled. It could only see those of the bootstrap-ant project. The only explanation of why it has worked before I have is that bootstrap-ant has contained the classes that depend on jakarta-regexp before and now no longer does. And as Xalan contains the regex classes (I think the build has used the "unbundled" Xalan jar which does not contain regexp because of this, may be wrong) the classes and tests would be compiled now. Anyway, the "ant" project has just been built successfully. Let's see what breaks next. Stefan - To unsubscribe, e-mail: general-unsubscr...@gump.apache.org For additional commands, e-mail: general-h...@gump.apache.org
Re: Starting to move Gump to using Java 11
On 2021-08-12, Mark Thomas wrote: > It looks like I have broken the Ant build somehow. I can't see what I > have done wrong. No rush, but some help on this from someone more > familiar with the Ant build than I would be helpful. It looks as if you may have uncovered a bug in Ant's build, but I'm unable to reproduce it locally, so I've turned on debug logging in Gump. Currently it fails because the tests for the old Jakarate Regex support in Ant are compiled but the classes implementing it are not - which is more than just a bit strange as they share the same Ant selectors. Even though the original jakarta-regexp package is not there as a dependency in Gump, Xalan could be contributing it. At least the "official" Xalan 2.7.2 contains a copy of jakarta-regexp. If I remove Xalan and jakarta-regexp locally, the build doesn't try to compile the tests, so we'll have to wait for the debug output. Stefan - To unsubscribe, e-mail: general-unsubscr...@gump.apache.org For additional commands, e-mail: general-h...@gump.apache.org
