[RESULT] [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
Hi, The vote to release Apache brpc(incubating) 0.9.8-rc01 has passed with 3 +1 binding votes. [3] +1 Binding votes: - Justin Mclean - Willem Jiang - Sheng Wu [ 0 ] +0 Binding votes [ 0 ] -1 Binding votes The vote is successful. Vote thread: https://lists.apache.org/thread.html/re44c77f98de4260a3efe4a53bc870790f2a710cc6b4edb8ef4e0342a%40%3Cgeneral.incubator.apache.org%3E Thank you to the above IPMC members for taking the time to review and provide guidance on our release! We will proceed with publishing the approved artifacts and sending out the appropriate announcements in the coming days. On behalf of brpc community,
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
+1 binding 1. ASC and sha512 exist 2. incubating in the name. 3. LICENSE and NOTICE exist 4. DISCLAIMER-WIP used. Good luck. Sheng Wu 吴晟 Twitter, wusheng1108 tan zhongyi 于2020年8月4日周二 上午9:59写道： > Thanks, Willem. > We have removed incubator-brpc-0.9.8-rc01.tar.gz. > > Now , we have two +1 (binding) from Willem and Justin. > We still need at least one +1(binding) vote. > > Can some guys help to add more +1 vote? > Thanks > > > On 2020/08/02 13:32:03, Willem Jiang wrote: > > +1. (binding)> > > > > Here are my checks,> > > 1. Signature and Hashed are good.> > > 2. Release commit and Tag are good.> > > 3. LICENSE and NOTICE files are good for me.> > > 4. I can build the binary from the Source release kit by going through> > > the build readme.> > > 5. DISCLAIMER-WIP is included.> > > > > BTW, We need to remove the file of incubator-brpc-0.9.8-rc01.tar.gz> > > from the release staging directory.> > > > > Willem Jiang> > > > > Twitter: willemjiang> > > Weibo: 姜宁willem> > > > > > > On Wed, Jul 15, 2020 at 7:02 PM tan zhongyi wrote:> > > >> > > > Hi， guys，> > > >> > > >> > > >> > > > I am pleased to be calling this vote for the release of Apache brpc > (incubating) 0.9.8-rc01> > > >> > > > BTW: there is still some license issues to be fixed, so we keep > DISCLAIMER-WIP there, we will fix them in later releases.> > > >> > > >> > > >> > > > Apache brpc community has voted and approved the release.> > > >> > > >> > > >> > > > Vote thread: > https://lists.apache.org/thread.html/r5b76897ad047c326d4b580a6c110e17ec26f7cb1db95425248827df8%40%3Cdev.brpc.apache.org%3E > > > > >> > > > Results thread: > https://lists.apache.org/thread.html/rd6667c2aad6a94238234e07461831cadf08e7ae7e66170dd4b25a694%40%3Cdev.brpc.apache.org%3E > > > > >> > > >> > > >> > > > The release candidate to be voted over is available at:> > > >> > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz > > > > >> > > >> > > >> > > >> > > >> > > > The SHA-512 checksum is:> > > >> > > > > 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d> > > >> > > > which can be found via:> > > >> > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512 > > > > >> > > > The signature can be found via:> > > >> > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc > > > > >> > > > KEYS file is available here:> > > >> > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS> > > >> > > >> > > >> > > >> > > >> > > > [Release Note]> > > >> > > > * Fix bug that time unit is not listed in grpc timeout options.> > > >> > > > https://github.com/apache/incubator-brpc/pull/1036> > > >> > > > * Fix heap overflow in simple_data_pool> > > >> > > > https://github.com/apache/incubator-brpc/pull/1056> > > >> > > > * Make args of redis protocol be StringPiece> > > >> > > > https://github.com/apache/incubator-brpc/pull/1128> > > >> > > > * Support the length of redis args could be zero> > > >> > > > https://github.com/apache/incubator-brpc/pull/1128> > > >> > > > * Optimize code in timer_thread> > > >> > > > https://github.com/apache/incubator-brpc/pull/1137/files> > > >> > > > * Fix a narrowing warning on aarch64> > > >> > > > > https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be > > > > >> > > > * Make pthread_atfork not registered in child process> > > >> > > > > https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3 > > > > >> > > > * Rename LOG_NONE which conflicts with a name in mysql> > > >> > > > > https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122 > > > > >> > > > * Fix several warnings under MAC> > > >> > > > > https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3 > > > > >> > > > * Ignore ELIMIT for circuit breaker> > > >> > > > https://github.com/apache/incubator-brpc/pull/1005> > > >> > > > * limit minimum value of max_concurrency for auto_cl> > > >> > > > https://github.com/apache/incubator-brpc/pull/1003> > > >> > > >> > > >> > > >> > > >> > > > Please vote on releasing this package as:> > > >> > > > Apache brpc(incubating) 0.9.8-rc01> > > >> > > >> > > >> > > > This vote will be open until “Monday July 20 2020 00:00:00 GMT+0800 > (CST)" and> > > >> > > > passes if a majority of at least three +1 Apache Incubator IPMC votes > are> > > >> > > > cast.> > > >> > > >> > > >> > > > [ ] +1 Release this package> > > >> > > > [ ] 0 I don't feel strongly about it, but don't object> > > >> > > > [ ] -1 Do not release this package because...> > > >> > > >> > > >> > > > Anyone can participate in testing and voting, not just committers, > please> > > >> > > > feel free to try out the release candidate and provide your votes.> > > >> > > >> > > >> > > > A checklist for reference:> > > >> > > >
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
Thanks, Willem. We have removed incubator-brpc-0.9.8-rc01.tar.gz. Now , we have two +1 (binding) from Willem and Justin. We still need at least one +1(binding) vote. Can some guys help to add more +1 vote? Thanks On 2020/08/02 13:32:03, Willem Jiang wrote: > +1. (binding)> > > Here are my checks,> > 1. Signature and Hashed are good.> > 2. Release commit and Tag are good.> > 3. LICENSE and NOTICE files are good for me.> > 4. I can build the binary from the Source release kit by going through> > the build readme.> > 5. DISCLAIMER-WIP is included.> > > BTW, We need to remove the file of incubator-brpc-0.9.8-rc01.tar.gz> > from the release staging directory.> > > Willem Jiang> > > Twitter: willemjiang> > Weibo: 姜宁willem> > > > On Wed, Jul 15, 2020 at 7:02 PM tan zhongyi wrote:> > >> > > Hi， guys，> > >> > >> > >> > > I am pleased to be calling this vote for the release of Apache brpc > > (incubating) 0.9.8-rc01> > >> > > BTW: there is still some license issues to be fixed, so we keep > > DISCLAIMER-WIP there, we will fix them in later releases.> > >> > >> > >> > > Apache brpc community has voted and approved the release.> > >> > >> > >> > > Vote thread: > > https://lists.apache.org/thread.html/r5b76897ad047c326d4b580a6c110e17ec26f7cb1db95425248827df8%40%3Cdev.brpc.apache.org%3E> > >> > > Results thread: > > https://lists.apache.org/thread.html/rd6667c2aad6a94238234e07461831cadf08e7ae7e66170dd4b25a694%40%3Cdev.brpc.apache.org%3E> > >> > >> > >> > > The release candidate to be voted over is available at:> > >> > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz> > >> > >> > >> > >> > >> > > The SHA-512 checksum is:> > >> > > 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d> > >> > > which can be found via:> > >> > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512> > >> > > The signature can be found via:> > >> > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc> > >> > > KEYS file is available here:> > >> > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS> > >> > >> > >> > >> > >> > > [Release Note]> > >> > > * Fix bug that time unit is not listed in grpc timeout options.> > >> > > https://github.com/apache/incubator-brpc/pull/1036> > >> > > * Fix heap overflow in simple_data_pool> > >> > > https://github.com/apache/incubator-brpc/pull/1056> > >> > > * Make args of redis protocol be StringPiece> > >> > > https://github.com/apache/incubator-brpc/pull/1128> > >> > > * Support the length of redis args could be zero> > >> > > https://github.com/apache/incubator-brpc/pull/1128> > >> > > * Optimize code in timer_thread> > >> > > https://github.com/apache/incubator-brpc/pull/1137/files> > >> > > * Fix a narrowing warning on aarch64> > >> > > https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be> > >> > > * Make pthread_atfork not registered in child process> > >> > > https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3> > >> > > * Rename LOG_NONE which conflicts with a name in mysql> > >> > > https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122> > >> > > * Fix several warnings under MAC> > >> > > https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3> > >> > > * Ignore ELIMIT for circuit breaker> > >> > > https://github.com/apache/incubator-brpc/pull/1005> > >> > > * limit minimum value of max_concurrency for auto_cl> > >> > > https://github.com/apache/incubator-brpc/pull/1003> > >> > >> > >> > >> > >> > > Please vote on releasing this package as:> > >> > > Apache brpc(incubating) 0.9.8-rc01> > >> > >> > >> > > This vote will be open until “Monday July 20 2020 00:00:00 GMT+0800 (CST)" > > and> > >> > > passes if a majority of at least three +1 Apache Incubator IPMC votes are> > >> > > cast.> > >> > >> > >> > > [ ] +1 Release this package> > >> > > [ ] 0 I don't feel strongly about it, but don't object> > >> > > [ ] -1 Do not release this package because...> > >> > >> > >> > > Anyone can participate in testing and voting, not just committers, please> > >> > > feel free to try out the release candidate and provide your votes.> > >> > >> > >> > > A checklist for reference:> > >> > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist> > >> > > -> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org> > For additional commands, e-mail: general-h...@incubator.apache.org> > >
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
+1. (binding) Here are my checks, 1. Signature and Hashed are good. 2. Release commit and Tag are good. 3. LICENSE and NOTICE files are good for me. 4. I can build the binary from the Source release kit by going through the build readme. 5. DISCLAIMER-WIP is included. BTW, We need to remove the file of incubator-brpc-0.9.8-rc01.tar.gz from the release staging directory. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Jul 15, 2020 at 7:02 PM tan zhongyi wrote: > > Hi， guys， > > > > I am pleased to be calling this vote for the release of Apache brpc > (incubating) 0.9.8-rc01 > > BTW: there is still some license issues to be fixed, so we keep > DISCLAIMER-WIP there, we will fix them in later releases. > > > > Apache brpc community has voted and approved the release. > > > > Vote thread: > https://lists.apache.org/thread.html/r5b76897ad047c326d4b580a6c110e17ec26f7cb1db95425248827df8%40%3Cdev.brpc.apache.org%3E > > Results thread: > https://lists.apache.org/thread.html/rd6667c2aad6a94238234e07461831cadf08e7ae7e66170dd4b25a694%40%3Cdev.brpc.apache.org%3E > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz > > > > > > The SHA-512 checksum is: > > 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d > > which can be found via: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512 > > The signature can be found via: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc > > KEYS file is available here: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS > > > > > > [Release Note] > > * Fix bug that time unit is not listed in grpc timeout options. > > https://github.com/apache/incubator-brpc/pull/1036 > > * Fix heap overflow in simple_data_pool > > https://github.com/apache/incubator-brpc/pull/1056 > > * Make args of redis protocol be StringPiece > > https://github.com/apache/incubator-brpc/pull/1128 > > * Support the length of redis args could be zero > > https://github.com/apache/incubator-brpc/pull/1128 > > * Optimize code in timer_thread > > https://github.com/apache/incubator-brpc/pull/1137/files > > * Fix a narrowing warning on aarch64 > > https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be > > * Make pthread_atfork not registered in child process > > https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3 > > * Rename LOG_NONE which conflicts with a name in mysql > > https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122 > > * Fix several warnings under MAC > > https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3 > > * Ignore ELIMIT for circuit breaker > > https://github.com/apache/incubator-brpc/pull/1005 > > * limit minimum value of max_concurrency for auto_cl > > https://github.com/apache/incubator-brpc/pull/1003 > > > > > > Please vote on releasing this package as: > > Apache brpc(incubating) 0.9.8-rc01 > > > > This vote will be open until “Monday July 20 2020 00:00:00 GMT+0800 (CST)" and > > passes if a majority of at least three +1 Apache Incubator IPMC votes are > > cast. > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > A checklist for reference: > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
Hi, incubator-brpc-0.9.8-rc01.tar.gz needs to be renamed as well. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
Here is the binary release https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/apache-brpc-0.9.8.rc01-incubating.tar.gz 在 2020/7/26 下午2:13，“tan zhongyi” 写入: OK， I will rename the release binary and carry on the vote. Yes, there are still some license issues remain, so we keep a DISCLAIMER-WIP still. We plan to fix it in Q3 release. Thanks 在 2020/7/22 下午2:25，“Justin Mclean” 写入: Hi, -1 (binding) as incubating is not in the name. I suggest you rename and carry on the vote. If you do that treat my vote as +1 (binding). I checked: - incubating in not in name - signatures and hashes are fine - DISCLAIMER exists (WIP) - LICENSE and NOTICE need more work - didn’t compile from source. I did also note CDDL licensed code in the release that we needs to be removed.This issue and others that have brought up in previous releases also haven’t been fixed, when is the PPMC intending to fix these? I number of files seem to have confused licensed e.g this file has 3 license headers which is the correct license? [1] Thanks, Justin 1. ./src/brpc/ts.cpp - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
OK， I will rename the release binary and carry on the vote. Yes, there are still some license issues remain, so we keep a DISCLAIMER-WIP still. We plan to fix it in Q3 release. Thanks 在 2020/7/22 下午2:25，“Justin Mclean” 写入: Hi, -1 (binding) as incubating is not in the name. I suggest you rename and carry on the vote. If you do that treat my vote as +1 (binding). I checked: - incubating in not in name - signatures and hashes are fine - DISCLAIMER exists (WIP) - LICENSE and NOTICE need more work - didn’t compile from source. I did also note CDDL licensed code in the release that we needs to be removed.This issue and others that have brought up in previous releases also haven’t been fixed, when is the PPMC intending to fix these? I number of files seem to have confused licensed e.g this file has 3 license headers which is the correct license? [1] Thanks, Justin 1. ./src/brpc/ts.cpp - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
Hi, -1 (binding) as incubating is not in the name. I suggest you rename and carry on the vote. If you do that treat my vote as +1 (binding). I checked: - incubating in not in name - signatures and hashes are fine - DISCLAIMER exists (WIP) - LICENSE and NOTICE need more work - didn’t compile from source. I did also note CDDL licensed code in the release that we needs to be removed.This issue and others that have brought up in previous releases also haven’t been fixed, when is the PPMC intending to fix these? I number of files seem to have confused licensed e.g this file has 3 license headers which is the correct license? [1] Thanks, Justin 1. ./src/brpc/ts.cpp - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
[VOTE] Release Apache brpc(incubating) 0.9.8-rc01
Hi， guys， I am pleased to be calling this vote for the release of Apache brpc (incubating) 0.9.8-rc01 BTW: there is still some license issues to be fixed, so we keep DISCLAIMER-WIP there, we will fix them in later releases. Apache brpc community has voted and approved the release. Vote thread: https://lists.apache.org/thread.html/r5b76897ad047c326d4b580a6c110e17ec26f7cb1db95425248827df8%40%3Cdev.brpc.apache.org%3E Results thread: https://lists.apache.org/thread.html/rd6667c2aad6a94238234e07461831cadf08e7ae7e66170dd4b25a694%40%3Cdev.brpc.apache.org%3E The release candidate to be voted over is available at: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz The SHA-512 checksum is: 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d which can be found via: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512 The signature can be found via: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc KEYS file is available here: https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS [Release Note] * Fix bug that time unit is not listed in grpc timeout options. https://github.com/apache/incubator-brpc/pull/1036 * Fix heap overflow in simple_data_pool https://github.com/apache/incubator-brpc/pull/1056 * Make args of redis protocol be StringPiece https://github.com/apache/incubator-brpc/pull/1128 * Support the length of redis args could be zero https://github.com/apache/incubator-brpc/pull/1128 * Optimize code in timer_thread https://github.com/apache/incubator-brpc/pull/1137/files * Fix a narrowing warning on aarch64 https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be * Make pthread_atfork not registered in child process https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3 * Rename LOG_NONE which conflicts with a name in mysql https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122 * Fix several warnings under MAC https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3 * Ignore ELIMIT for circuit breaker https://github.com/apache/incubator-brpc/pull/1005 * limit minimum value of max_concurrency for auto_cl https://github.com/apache/incubator-brpc/pull/1003 Please vote on releasing this package as: Apache brpc(incubating) 0.9.8-rc01 This vote will be open until “Monday July 20 2020 00:00:00 GMT+0800 (CST)" and passes if a majority of at least three +1 Apache Incubator IPMC votes are cast. [ ] +1 Release this package [ ] 0 I don't feel strongly about it, but don't object [ ] -1 Do not release this package because... Anyone can participate in testing and voting, not just committers, please feel free to try out the release candidate and provide your votes. A checklist for reference: https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
