Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating

[Henry Saputra]

Checking the source release artifact:

LICENSE file looks good
DISCLAIMER file exists
RAT check passes
No 3rd party exes in the source artifacts
Signature files look good
Hash files look good

+1 (binding)


- Henry


On Fri, Oct 21, 2016 at 10:14 AM, Swapnil Bawaskar 
wrote:

> Hello,
>
> This is a call for a vote on the Apache Geode (incubating) release
> 1.0.0-incubating.
>
> This release candidate, 1.0.0-incubating.RC2, has successfully passed
> a vote for a release
> on the geode developer mailing list.
>
> Vote thread:
>
> http://markmail.org/message/bjj6aumdkwsmaw2p
>
> Results:
>
> http://markmail.org/message/ghxt7xzi43y7wyvq
>
> It fixes the following issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420=12332343
>
> Note that we are voting upon the source (tag):
>rel/1.0.0-incubating.RC2
>  geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
>
> Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
>  280a407c59a89401d5d87d6e6aeda1c975870753>
>
> Source and binary files:
>https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> 0-incubating.RC2/
>
> The documentation on how to install and use Apache Geode will be hosted
> at http://geode.incubator.apache.org/docs/guide/about_geode.html
> (working with ASF infra to resolve an issue), but for now is available
> on:
>
>http://geode.docs.pivotal.io
>
> Maven staging repo:
>https://repository.apache.org/content/repositories/orgapachegeode-1014/
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>https://github.com/apache/incubator-geode/blob/release/
> 1.0.0-incubating/KEYS
>
> Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
>
> Please vote on releasing this package as Apache Geode 1.0.0-incubating.M1:
>
>  This vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Swapnil on behalf of the Apache Geode (incubating) team.
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating

[John D. Ament]

+1 release contents look good.

On Fri, Oct 21, 2016 at 1:14 PM Swapnil Bawaskar 
wrote:

> Hello,
>
> This is a call for a vote on the Apache Geode (incubating) release
> 1.0.0-incubating.
>
> This release candidate, 1.0.0-incubating.RC2, has successfully passed
> a vote for a release
> on the geode developer mailing list.
>
> Vote thread:
>
> http://markmail.org/message/bjj6aumdkwsmaw2p
>
> Results:
>
> http://markmail.org/message/ghxt7xzi43y7wyvq
>
> It fixes the following issues:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12332343
>
> Note that we are voting upon the source (tag):
>rel/1.0.0-incubating.RC2
> <
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2
> >
>
> Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> <
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753
> >
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.RC2/
>
> The documentation on how to install and use Apache Geode will be hosted
> at http://geode.incubator.apache.org/docs/guide/about_geode.html
> (working with ASF infra to resolve an issue), but for now is available
> on:
>
>http://geode.docs.pivotal.io
>
> Maven staging repo:
>https://repository.apache.org/content/repositories/orgapachegeode-1014/
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>
> https://github.com/apache/incubator-geode/blob/release/1.0.0-incubating/KEYS
>
> Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
>
> Please vote on releasing this package as Apache Geode 1.0.0-incubating.M1:
>
>  This vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Swapnil on behalf of the Apache Geode (incubating) team.
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating

[Roman Shaposhnik]

On Fri, Oct 21, 2016 at 10:14 AM, Swapnil Bawaskar  wrote:
> Hello,
>
> This is a call for a vote on the Apache Geode (incubating) release
> 1.0.0-incubating.
>
> This release candidate, 1.0.0-incubating.RC2, has successfully passed
> a vote for a release
> on the geode developer mailing list.
>
> Vote thread:
>
> http://markmail.org/message/bjj6aumdkwsmaw2p
>
> Results:
>
> http://markmail.org/message/ghxt7xzi43y7wyvq
>
> It fixes the following issues:
>
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12332343
>
> Note that we are voting upon the source (tag):
>rel/1.0.0-incubating.RC2
> 
>
> Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> 
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.RC2/
>
> The documentation on how to install and use Apache Geode will be hosted
> at http://geode.incubator.apache.org/docs/guide/about_geode.html
> (working with ASF infra to resolve an issue), but for now is available
> on:
>
>http://geode.docs.pivotal.io
>
> Maven staging repo:
>https://repository.apache.org/content/repositories/orgapachegeode-1014/
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>
> https://github.com/apache/incubator-geode/blob/release/1.0.0-incubating/KEYS
>
> Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
>
> Please vote on releasing this package as Apache Geode 1.0.0-incubating.M1:
>
>  This vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)

+1 (binding)

- imported keys
- verified signatures, MD5 and SHA256 checksums
- verified that content of zip archives is identical to tar.gz
- verified that source archive is pretty much identical to release tag
(baring .gitingnore and such)
- verified LICENCE, NOTICE and disclaimer in both source release and
binary convenience artifacts
- verified RAT report and exclusions
- verified that it builds from source
- verified the content of binary convenience artifacts and bundled dependencies

Thanks,
Roman.

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating

[Justin Mclean]

Hi,

> Much of the text in the NOTICE is propagated from Apache Lucene 
> (https://github.com/apache/lucene-solr/blob/master/lucene/NOTICE.txt).
>  

You may want to consider only including the bits that are needed as to reduce 
the burden on any down stream projects.

Thanks,
Justin


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating

[Anthony Baker]

Justin, thanks for the quick review!  Comments inline.

> On Oct 21, 2016, at 5:15 PM, Justin Mclean  wrote:
> 
> Hi,
> 
> +1 binding
> 
> I checked:
> - files name contain incubating
> - signatures and hashes good
> - DISCLAIMER exists
> - NOTICE and LICENSE have some very minor issues (see below)
> - No unexpected binary files
> - All Apache files have ASF headers
> - Can compile from source 
> 
> Minor license issues:
> - How is this this file licensed? [1]

screen.css comes from Swagger which is licensed ASLv2.

> - Looks like the bundled version of bootstrap is Apache licensed and not MIT 
> licensed as mentioned  in the LICENSE file.
> - License is missing MIT/GPL licensed jQuery hashchange bundled inside this 
> file [2]
> 

Good catch, filed GEODE-2028.

> I didn’t fine check the release binary but from a casual glance it looks OK. 
> The NOTICE file seems to have some unnecessary information in it and is 
> overly long at a guess.
> 
> I also noticed this in NOTICE:
> Morfologik uses data from Polish ispell/myspell dictionary
>  (http://www.sjp.pl/slownik/en/) licenced on the terms of (inter alia)
>  LGPL and Creative Commons ShareAlike.
> 
> Which may notbe allowed as CCSA is now category B in binary form only, but I 
> assuming that you haven’t actually bundled a polish dictionary in the binary.
> 

Much of the text in the NOTICE is propagated from Apache Lucene 
(https://github.com/apache/lucene-solr/blob/master/lucene/NOTICE.txt 
).  I 
think their NOTICE needs to updated to reflect that 
http://www.sjp.pl/slownik/en/  now supports 5 
licenses including ASLv2.  We don’t bundle the morfologik analyzer (only core, 
analyzers-common, queryparser, and queries) but it’s hard to tell which parts 
of the notice map to which lucene component.

> Thanks,
> Justin
> 
> 1. ./geode-web-api/src/main/webapp/docs/css/screen.css
> 2. ./geode-web-api/src/main/webapp/docs/lib/jquery.ba-bbq.min.js
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating

[Justin Mclean]

Hi,

+1 binding

I checked:
- files name contain incubating
- signatures and hashes good
- DISCLAIMER exists
- NOTICE and LICENSE have some very minor issues (see below)
- No unexpected binary files
- All Apache files have ASF headers
- Can compile from source 

Minor license issues:
- How is this this file licensed? [1]
- Looks like the bundled version of bootstrap is Apache licensed and not MIT 
licensed as mentioned  in the LICENSE file.
- License is missing MIT/GPL licensed jQuery hashchange bundled inside this 
file [2]

I didn’t fine check the release binary but from a casual glance it looks OK. 
The NOTICE file seems to have some unnecessary information in it and is overly 
long at a guess.

I also noticed this in NOTICE:
 Morfologik uses data from Polish ispell/myspell dictionary
  (http://www.sjp.pl/slownik/en/) licenced on the terms of (inter alia)
  LGPL and Creative Commons ShareAlike.

Which may notbe allowed as CCSA is now category B in binary form only, but I 
assuming that you haven’t actually bundled a polish dictionary in the binary.

Thanks,
Justin

1. ./geode-web-api/src/main/webapp/docs/css/screen.css
2. ./geode-web-api/src/main/webapp/docs/lib/jquery.ba-bbq.min.js
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating

[Swapnil Bawaskar]

The last statement should have said: Please vote on releasing this package
as Apache Geode 1.0.0-incubating (rather than 1.0.0-incubating.M1).

On Fri, Oct 21, 2016 at 10:14 AM, Swapnil Bawaskar 
wrote:

> Hello,
>
> This is a call for a vote on the Apache Geode (incubating) release 
> 1.0.0-incubating.
>
> This release candidate, 1.0.0-incubating.RC2, has successfully passed a vote 
> for a release
> on the geode developer mailing list.
>
> Vote thread:
>
> http://markmail.org/message/bjj6aumdkwsmaw2p
>
> Results:
>
> http://markmail.org/message/ghxt7xzi43y7wyvq
>
> It fixes the following issues:
>
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12332343
>
> Note that we are voting upon the source (tag):
>rel/1.0.0-incubating.RC2 
> 
>
> Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753 
> 
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.RC2/
>
> The documentation on how to install and use Apache Geode will be hosted
> at http://geode.incubator.apache.org/docs/guide/about_geode.html (working 
> with ASF infra to resolve an issue), but for now is available on:
>
>http://geode.docs.pivotal.io
>
> Maven staging repo:
>https://repository.apache.org/content/repositories/orgapachegeode-1014/
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>
> https://github.com/apache/incubator-geode/blob/release/1.0.0-incubating/KEYS
>
> Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
>
> Please vote on releasing this package as Apache Geode 1.0.0-incubating.M1:
>
>  This vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Swapnil on behalf of the Apache Geode (incubating) team.
>
>