Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-27 Thread Henry Saputra
+1 (binding)

NOTICE, LICENSE, and DISCLAIMER files exist
ASF Header exists and correct
No executable files in source artifact

- Henry

On Wed, Feb 27, 2019 at 9:54 AM Piyush Ghai  wrote:

> Hi all,
>
> Thanks everyone for spending the time to test and vote.
>
> This vote passes with 5 +1 votes (4 binding) and no 0 or -1 votes.
>
> +1 votes
> Henri Yandell / binding
> Jason Dai / binding
> Justin Mclean / binding
> Michael Wall / binding
> Sheng Zha
>
> 0 votes
> No votes
>
> -1 votes
> No votes
>
> I will move forward with publishing the official release now.
>
> Thanks,
> Piyush
>
>
>
> On 2019/02/27 05:34:03, Sheng Zha  wrote:
> > +1
> >
> > And thanks to mentors and IPMC members for helping our release. NOTICE
> year
> > was caught in dev@ vote too. Master branch already has the fix [1] and
> we
> > promise to fix it in the next release.
> >
> > -sz
> >
> > [1]
> >
> https://github.com/apache/incubator-mxnet/pull/14043/files#diff-aa14599dc3fdfa9cc81a7c3c247b77b9L2
> >
> > On Tue, Feb 26, 2019 at 7:47 PM Michael Wall  wrote:
> >
> > > +1 binding
> > >
> > > Verified
> > > - Release files in correct location
> > > - Release files have the word incubating in their name
> > > - Digital signature and hashes correct
> > > - DISCLAIMER file exist
> > > - LICENSE and NOTICE files exists
> > > - LICENSE and NOTICE text correct
> > > - Un-included software dependencies are not mentioned in LICENSE or
> NOTICE
> > > - License information is not mentioned in NOTICE
> > > - All source files have ASF headers
> > > - Contents of the release match with what's tagged in version control
> > > - No unexpected binary files in the release
> > >
> > > Non verified
> > > - NOTICE year not correct, unfortunate it was updated when the release
> was
> > > cut again
> > > Is there any 3rd party code contained inside the release? If so:
> > > - Was not able to compile.  Stopped after 10 min, is
> > >
> > >
> https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html
> > > right place to look?  Instructions could be clearer
> > >
> > > Good work fixing the licensing.
> > >
> > > Mike
> > >
> > > On Tue, Feb 26, 2019 at 9:34 PM Justin Mclean <
> jus...@classsoftware.com>
> > > wrote:
> > >
> > > > HI,.
> > > >
> > > > +1 (binding)
> > > >
> > > > I didn’t have time to check all of the licenses so there may be some
> work
> > > > that’s still needed there, but it looks fairly comprehensive.
> > > >
> > > > I checked:
> > > > - incubating in name
> > > > - DISCLAIMER exists
> > > > - LICENSE looks OK
> > > > - NOTICE need year updating
> > > > - No unexpected binary files
> > > > - All ASF files have ASF headers
> > > > - I didn’t compile from source and assume others have
> > > >
> > > > Thanks,
> > > > Justin
> > > > -
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > >
> > >
> >


Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-27 Thread Hagay Lupesko
yay! so many goodies in this release, looking forward to see it out.
Kudos to everyone who assisted in the release...

On Wed, Feb 27, 2019 at 9:54 AM Piyush Ghai  wrote:

> Hi all,
>
> Thanks everyone for spending the time to test and vote.
>
> This vote passes with 5 +1 votes (4 binding) and no 0 or -1 votes.
>
> +1 votes
> Henri Yandell / binding
> Jason Dai / binding
> Justin Mclean / binding
> Michael Wall / binding
> Sheng Zha
>
> 0 votes
> No votes
>
> -1 votes
> No votes
>
> I will move forward with publishing the official release now.
>
> Thanks,
> Piyush
>
>
>
> On 2019/02/27 05:34:03, Sheng Zha  wrote:
> > +1
> >
> > And thanks to mentors and IPMC members for helping our release. NOTICE
> year
> > was caught in dev@ vote too. Master branch already has the fix [1] and
> we
> > promise to fix it in the next release.
> >
> > -sz
> >
> > [1]
> >
> https://github.com/apache/incubator-mxnet/pull/14043/files#diff-aa14599dc3fdfa9cc81a7c3c247b77b9L2
> >
> > On Tue, Feb 26, 2019 at 7:47 PM Michael Wall  wrote:
> >
> > > +1 binding
> > >
> > > Verified
> > > - Release files in correct location
> > > - Release files have the word incubating in their name
> > > - Digital signature and hashes correct
> > > - DISCLAIMER file exist
> > > - LICENSE and NOTICE files exists
> > > - LICENSE and NOTICE text correct
> > > - Un-included software dependencies are not mentioned in LICENSE or
> NOTICE
> > > - License information is not mentioned in NOTICE
> > > - All source files have ASF headers
> > > - Contents of the release match with what's tagged in version control
> > > - No unexpected binary files in the release
> > >
> > > Non verified
> > > - NOTICE year not correct, unfortunate it was updated when the release
> was
> > > cut again
> > > Is there any 3rd party code contained inside the release? If so:
> > > - Was not able to compile.  Stopped after 10 min, is
> > >
> > >
> https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html
> > > right place to look?  Instructions could be clearer
> > >
> > > Good work fixing the licensing.
> > >
> > > Mike
> > >
> > > On Tue, Feb 26, 2019 at 9:34 PM Justin Mclean <
> jus...@classsoftware.com>
> > > wrote:
> > >
> > > > HI,.
> > > >
> > > > +1 (binding)
> > > >
> > > > I didn’t have time to check all of the licenses so there may be some
> work
> > > > that’s still needed there, but it looks fairly comprehensive.
> > > >
> > > > I checked:
> > > > - incubating in name
> > > > - DISCLAIMER exists
> > > > - LICENSE looks OK
> > > > - NOTICE need year updating
> > > > - No unexpected binary files
> > > > - All ASF files have ASF headers
> > > > - I didn’t compile from source and assume others have
> > > >
> > > > Thanks,
> > > > Justin
> > > > -
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > >
> > >
> >


Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-27 Thread Piyush Ghai
Hi all, 

Thanks everyone for spending the time to test and vote.

This vote passes with 5 +1 votes (4 binding) and no 0 or -1 votes.

+1 votes
Henri Yandell / binding
Jason Dai / binding
Justin Mclean / binding
Michael Wall / binding
Sheng Zha

0 votes
No votes

-1 votes
No votes

I will move forward with publishing the official release now. 

Thanks,
Piyush



On 2019/02/27 05:34:03, Sheng Zha  wrote: 
> +1
> 
> And thanks to mentors and IPMC members for helping our release. NOTICE year
> was caught in dev@ vote too. Master branch already has the fix [1] and we
> promise to fix it in the next release.
> 
> -sz
> 
> [1]
> https://github.com/apache/incubator-mxnet/pull/14043/files#diff-aa14599dc3fdfa9cc81a7c3c247b77b9L2
> 
> On Tue, Feb 26, 2019 at 7:47 PM Michael Wall  wrote:
> 
> > +1 binding
> >
> > Verified
> > - Release files in correct location
> > - Release files have the word incubating in their name
> > - Digital signature and hashes correct
> > - DISCLAIMER file exist
> > - LICENSE and NOTICE files exists
> > - LICENSE and NOTICE text correct
> > - Un-included software dependencies are not mentioned in LICENSE or NOTICE
> > - License information is not mentioned in NOTICE
> > - All source files have ASF headers
> > - Contents of the release match with what's tagged in version control
> > - No unexpected binary files in the release
> >
> > Non verified
> > - NOTICE year not correct, unfortunate it was updated when the release was
> > cut again
> > Is there any 3rd party code contained inside the release? If so:
> > - Was not able to compile.  Stopped after 10 min, is
> >
> > https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html
> > right place to look?  Instructions could be clearer
> >
> > Good work fixing the licensing.
> >
> > Mike
> >
> > On Tue, Feb 26, 2019 at 9:34 PM Justin Mclean 
> > wrote:
> >
> > > HI,.
> > >
> > > +1 (binding)
> > >
> > > I didn’t have time to check all of the licenses so there may be some work
> > > that’s still needed there, but it looks fairly comprehensive.
> > >
> > > I checked:
> > > - incubating in name
> > > - DISCLAIMER exists
> > > - LICENSE looks OK
> > > - NOTICE need year updating
> > > - No unexpected binary files
> > > - All ASF files have ASF headers
> > > - I didn’t compile from source and assume others have
> > >
> > > Thanks,
> > > Justin
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> 

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-26 Thread Sheng Zha
+1

And thanks to mentors and IPMC members for helping our release. NOTICE year
was caught in dev@ vote too. Master branch already has the fix [1] and we
promise to fix it in the next release.

-sz

[1]
https://github.com/apache/incubator-mxnet/pull/14043/files#diff-aa14599dc3fdfa9cc81a7c3c247b77b9L2

On Tue, Feb 26, 2019 at 7:47 PM Michael Wall  wrote:

> +1 binding
>
> Verified
> - Release files in correct location
> - Release files have the word incubating in their name
> - Digital signature and hashes correct
> - DISCLAIMER file exist
> - LICENSE and NOTICE files exists
> - LICENSE and NOTICE text correct
> - Un-included software dependencies are not mentioned in LICENSE or NOTICE
> - License information is not mentioned in NOTICE
> - All source files have ASF headers
> - Contents of the release match with what's tagged in version control
> - No unexpected binary files in the release
>
> Non verified
> - NOTICE year not correct, unfortunate it was updated when the release was
> cut again
> Is there any 3rd party code contained inside the release? If so:
> - Was not able to compile.  Stopped after 10 min, is
>
> https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html
> right place to look?  Instructions could be clearer
>
> Good work fixing the licensing.
>
> Mike
>
> On Tue, Feb 26, 2019 at 9:34 PM Justin Mclean 
> wrote:
>
> > HI,.
> >
> > +1 (binding)
> >
> > I didn’t have time to check all of the licenses so there may be some work
> > that’s still needed there, but it looks fairly comprehensive.
> >
> > I checked:
> > - incubating in name
> > - DISCLAIMER exists
> > - LICENSE looks OK
> > - NOTICE need year updating
> > - No unexpected binary files
> > - All ASF files have ASF headers
> > - I didn’t compile from source and assume others have
> >
> > Thanks,
> > Justin
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>


Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-26 Thread Michael Wall
+1 binding

Verified
- Release files in correct location
- Release files have the word incubating in their name
- Digital signature and hashes correct
- DISCLAIMER file exist
- LICENSE and NOTICE files exists
- LICENSE and NOTICE text correct
- Un-included software dependencies are not mentioned in LICENSE or NOTICE
- License information is not mentioned in NOTICE
- All source files have ASF headers
- Contents of the release match with what's tagged in version control
- No unexpected binary files in the release

Non verified
- NOTICE year not correct, unfortunate it was updated when the release was
cut again
Is there any 3rd party code contained inside the release? If so:
- Was not able to compile.  Stopped after 10 min, is
https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html
right place to look?  Instructions could be clearer

Good work fixing the licensing.

Mike

On Tue, Feb 26, 2019 at 9:34 PM Justin Mclean 
wrote:

> HI,.
>
> +1 (binding)
>
> I didn’t have time to check all of the licenses so there may be some work
> that’s still needed there, but it looks fairly comprehensive.
>
> I checked:
> - incubating in name
> - DISCLAIMER exists
> - LICENSE looks OK
> - NOTICE need year updating
> - No unexpected binary files
> - All ASF files have ASF headers
> - I didn’t compile from source and assume others have
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-26 Thread Justin Mclean
HI,.

+1 (binding)

I didn’t have time to check all of the licenses so there may be some work 
that’s still needed there, but it looks fairly comprehensive.

I checked:
- incubating in name
- DISCLAIMER exists 
- LICENSE looks OK
- NOTICE need year updating
- No unexpected binary files
- All ASF files have ASF headers
- I didn’t compile from source and assume others have

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-26 Thread Jason Dai
+1 looks good to me

On Tue, Feb 26, 2019 at 3:29 PM Hen  wrote:

> +1.
>
> I reviewed the diff with the RC2 that I approved, no concerns with
> anything added.
>
> Cc'ing other mentors.
>
> Hen
>
>
> On Wed, Feb 20, 2019 at 10:45 AM Piyush Ghai 
> wrote:
>
>> Dear community,
>>
>> This is a call for releasing Apache MXNet (incubating) 1.4.0, release
>> candidate RC3.
>>
>> Apache MXNet (incubating) community has voted and approved the release.
>>
>> Vote thread :
>>
>> https://lists.apache.org/thread.html/618ad28580e838254f998deb71373467374a05228401dae0323a6d0f@%3Cdev.mxnet.apache.org%3E
>> <
>> https://lists.apache.org/thread.html/618ad28580e838254f998deb71373467374a05228401dae0323a6d0f@%3Cdev.mxnet.apache.org%3E
>> >
>>
>>
>> Results thread :
>>
>>
>> https://lists.apache.org/thread.html/68373b7be4a12e90f136aab2d55a334fad021bec7b796174d357f4b7@%3Cdev.mxnet.apache.org%3E
>> <
>> https://lists.apache.org/thread.html/68373b7be4a12e90f136aab2d55a334fad021bec7b796174d357f4b7@%3Cdev.mxnet.apache.org%3E>
>>
>>
>> The community raised the following issues which are not considered as
>> release stopper :
>>
>> 1. NOTICE year is wrong (2018): Not considered a stopping issue as release
>> was started in 2018.
>>
>>
>> The source tar ball, including signature, digests etc can be found at :
>>
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc3/ <
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc3/>
>>
>> The tag to be voted upon :
>> https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3 <
>> https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3>
>>
>> The release hash is a03d59e
>> <
>> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da
>> <
>> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da>>
>> :
>>
>>
>> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da
>> <
>> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da
>> >
>>
>> Release artifacts are signed with the following key :
>>
>> 0812 9523 58B1 2DC3 0536 E7E0 C069 16C3 AB88 ABFE
>>
>> KEYS file available :
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS <
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS>
>>
>> The vote will end on Monday, February 25th, 4:00 PM PDT or until the
>> sufficient number of votes is reached.
>>
>> [ ] +1 Release this package as 1.4.0
>> [ ] +0 no opinion
>> [ ] -1 Do not release this package because ...
>>
>>
>> Thanks,
>> Piyush
>
>


Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-25 Thread Hen
+1.

I reviewed the diff with the RC2 that I approved, no concerns with anything
added.

Cc'ing other mentors.

Hen


On Wed, Feb 20, 2019 at 10:45 AM Piyush Ghai  wrote:

> Dear community,
>
> This is a call for releasing Apache MXNet (incubating) 1.4.0, release
> candidate RC3.
>
> Apache MXNet (incubating) community has voted and approved the release.
>
> Vote thread :
>
> https://lists.apache.org/thread.html/618ad28580e838254f998deb71373467374a05228401dae0323a6d0f@%3Cdev.mxnet.apache.org%3E
> <
> https://lists.apache.org/thread.html/618ad28580e838254f998deb71373467374a05228401dae0323a6d0f@%3Cdev.mxnet.apache.org%3E
> >
>
>
> Results thread :
>
>
> https://lists.apache.org/thread.html/68373b7be4a12e90f136aab2d55a334fad021bec7b796174d357f4b7@%3Cdev.mxnet.apache.org%3E
> <
> https://lists.apache.org/thread.html/68373b7be4a12e90f136aab2d55a334fad021bec7b796174d357f4b7@%3Cdev.mxnet.apache.org%3E>
>
>
> The community raised the following issues which are not considered as
> release stopper :
>
> 1. NOTICE year is wrong (2018): Not considered a stopping issue as release
> was started in 2018.
>
>
> The source tar ball, including signature, digests etc can be found at :
>
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc3/ <
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc3/>
>
> The tag to be voted upon :
> https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3 <
> https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3>
>
> The release hash is a03d59e
> <
> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da
> <
> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da>>
> :
>
>
> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da
> <
> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da
> >
>
> Release artifacts are signed with the following key :
>
> 0812 9523 58B1 2DC3 0536 E7E0 C069 16C3 AB88 ABFE
>
> KEYS file available :
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS <
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS>
>
> The vote will end on Monday, February 25th, 4:00 PM PDT or until the
> sufficient number of votes is reached.
>
> [ ] +1 Release this package as 1.4.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because ...
>
>
> Thanks,
> Piyush


Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

2019-02-25 Thread Piyush Ghai
Dear community,

It will be great if members can test the release and vote.

Thanks,
Piyush


On 2019/02/20 18:45:19, Piyush Ghai  wrote: 
> Dear community,> 
> 
> This is a call for releasing Apache MXNet (incubating) 1.4.0, release > 
> candidate RC3. > 
> 
> Apache MXNet (incubating) community has voted and approved the release. > 
> 
> Vote thread :> 
> https://lists.apache.org/thread.html/618ad28580e838254f998deb71373467374a05228401dae0323a6d0f@%3Cdev.mxnet.apache.org%3E
>  
> >
>  
> 
> 
> Results thread :> 
> 
> https://lists.apache.org/thread.html/68373b7be4a12e90f136aab2d55a334fad021bec7b796174d357f4b7@%3Cdev.mxnet.apache.org%3E
>  
> 
>  > 
> 
> The community raised the following issues which are not considered as release 
> stopper :> 
> 
> 1. NOTICE year is wrong (2018): Not considered a stopping issue as release> 
> was started in 2018.> 
> 
> 
> The source tar ball, including signature, digests etc can be found at : > 
> 
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc3/ 
> > 
> 
> The tag to be voted upon :> 
> https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3 
> > 
> 
> The release hash is a03d59e > 
>   
> >
>  :> 
> 
> https://github.com/apache/incubator-mxnet/commit/a03d59ed867ba334d78d61246a1090cd1868f5da
>  
> >
>  
> 
> Release artifacts are signed with the following key : > 
> 
> 0812 9523 58B1 2DC3 0536 E7E0 C069 16C3 AB88 ABFE> 
> 
> KEYS file available :> 
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS 
>  > 
> 
> The vote will end on Monday, February 25th, 4:00 PM PDT or until the 
> sufficient number of votes is reached. > 
> 
> [ ] +1 Release this package as 1.4.0> 
> [ ] +0 no opinion> 
> [ ] -1 Do not release this package because ...> 
> 
> 
> Thanks,> 
> Piyush> 
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org