Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-26 Thread Justin Mclean
Hi,

> I think we forget to close the vote and announce the results. Apologies for 
> that.

As far as I could tell I think you only had 2 +1 binding votes before I voted 
so I’m not sure the vote was closed.

Please take more care in future and please send a RESULT email on this vote.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-26 Thread Gianmarco De Francisci Morales
Hi Justin,

I think we forget to close the vote and announce the results. Apologies for
that.
Thanks for checking the release.

The headers are automatically generated by a mvn plugin, we will try to fix
them by changing its configuration.

Thanks,

-- Gianmarco

On Mon, Sep 26, 2016 at 11:04 AM, Dor Ben Dov <dor.ben-...@amdocs.com>
wrote:

> Justin,
>
> About Apache Samoa - Any known plugin to Hbase , Spark ?
>
> Regards,
> Dor Ben Dov
>
> -Original Message-
> From: Justin Mclean [mailto:jus...@classsoftware.com]
> Sent: יום ב 26 ספטמבר 2016 10:40
> To: general@incubator.apache.org
> Subject: Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1
>
> Hi,
>
> +1 binding
>
> I checked:
> - incubating in name
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - No unexpected binary in source
> - Looks like most if not all files have incorrect ASF headers. The ASF
> header should not include a copyright line [2]. Not that it matters but the
> copyright date range is also incorrect. Please remove in next release.
> - Can compile from source
>
> Some very minor things:
> - would be good if release was signed by an apache email address (not a
> gmail one)
> - might want to update the copyright year in this file [1]
>
> It also looks like you may of got ahead of yourself and published the
> release before the incubator vote results and linked to it from your web
> site. Please don’t do that.
>
> Thanks,
> Justin
>
> 1. ./samoa-0.4.0-incubating/samoa-api/src/main/java/org/
> apache/samoa/core/Globals.java
> 2. https://www.apache.org/legal/src-headers.html#headers
> 3. https://www.apache.org/dist/incubator/samoa/0.4.0-incubating/
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
> you may review at http://www.amdocs.com/email_disclaimer.asp
>


RE: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-26 Thread Dor Ben Dov
Justin, 

About Apache Samoa - Any known plugin to Hbase , Spark ? 

Regards,
Dor Ben Dov

-Original Message-
From: Justin Mclean [mailto:jus...@classsoftware.com] 
Sent: יום ב 26 ספטמבר 2016 10:40
To: general@incubator.apache.org
Subject: Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

Hi,

+1 binding

I checked:
- incubating in name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE and NOTICE good
- No unexpected binary in source
- Looks like most if not all files have incorrect ASF headers. The ASF header 
should not include a copyright line [2]. Not that it matters but the copyright 
date range is also incorrect. Please remove in next release.
- Can compile from source

Some very minor things:
- would be good if release was signed by an apache email address (not a gmail 
one)
- might want to update the copyright year in this file [1]

It also looks like you may of got ahead of yourself and published the release 
before the incubator vote results and linked to it from your web site. Please 
don’t do that.

Thanks,
Justin

1. 
./samoa-0.4.0-incubating/samoa-api/src/main/java/org/apache/samoa/core/Globals.java
2. https://www.apache.org/legal/src-headers.html#headers
3. https://www.apache.org/dist/incubator/samoa/0.4.0-incubating/
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org


This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,
you may review at http://www.amdocs.com/email_disclaimer.asp


Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-26 Thread Justin Mclean
Hi,

+1 binding

I checked:
- incubating in name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE and NOTICE good
- No unexpected binary in source
- Looks like most if not all files have incorrect ASF headers. The ASF header 
should not include a copyright line [2]. Not that it matters but the copyright 
date range is also incorrect. Please remove in next release.
- Can compile from source

Some very minor things:
- would be good if release was signed by an apache email address (not a gmail 
one)
- might want to update the copyright year in this file [1]

It also looks like you may of got ahead of yourself and published the release 
before the incubator vote results and linked to it from your web site. Please 
don’t do that.

Thanks,
Justin

1. 
./samoa-0.4.0-incubating/samoa-api/src/main/java/org/apache/samoa/core/Globals.java
2. https://www.apache.org/legal/src-headers.html#headers
3. https://www.apache.org/dist/incubator/samoa/0.4.0-incubating/
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-25 Thread Gianmarco De Francisci Morales
Thanks everyone for the feedback, we'll fix the rat for the next release.
There seem to be some random test failures, we are investigating the causes.

-- Gianmarco

On Fri, Sep 23, 2016 at 2:04 PM, Stian Soiland-Reyes 
wrote:

> My vote: 0 (non-binding)
>
> +1 tag/commit
> +1 git vs source zip
> +1 No binaries
> 0 mvn install fails in test
> 0 Apache rat is not happy
> 0 dist includes a  _remote.repositories file - this should be removed
> +1 LICENSE DISCLAIMER NOTICE
>
> I'm afraid it's not a positive vote from me because the build fails in
> test - and the README told me to do "mvn package" (A workaround here
> could be to use -DskipTests=true - but I don't know why the test
> fails)
>
>
> Apache rat complains about:
>  !? CONTRIBUTING.md
>  !? .travis.yml
>  !? bin/samza-kryo
>
> These should be added to pom.xml's apache-rat configuration to be
> ignored. None of them are worthy of a license header I think.
>
>
> Your vote email didn't say the hash of the source distro, it is (sha1)
> cab5ace6bfff3b70f883db61578fbda847f0fd66
> samoa-0.4.0-incubating-source-release.zip
>
> (which matches *.sha1 on dist)
>
>
>
>
>
> Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.411
> sec <<< FAILURE! - in
> org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest
> testStartSendingEvents(org.apache.samoa.topology.impl.
> SimpleEntranceProcessingItemTest)
>  Time elapsed: 0.313 sec  <<< ERROR!
> java.lang.IllegalStateException: Missing invocation to mocked type at
> this point; please make sure there is an associated mock field or mock
> parameter in scope
> at org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTe
> st$4.(SimpleEntranceProcessingItemTest.java:159)
> at org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTe
> st.testStartSendingEvents(SimpleEntranceProcessingItemTest.java:155)
>
> [INFO] Apache SAMOA ... SUCCESS [
> 4.748 s]
> [INFO] samoa-instances  SUCCESS [
> 3.676 s]
> [INFO] samoa-api .. SUCCESS [
> 22.050 s]
> [INFO] samoa-test . SUCCESS [
> 2.149 s]
> [INFO] samoa-local  FAILURE [
> 49.418 s]
>
> using
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T16:41:47+00:00)
> Maven home: /home/stain/software/maven
> Java version: 1.8.0_91, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-38-generic", arch: "amd64", family:
> "unix"
>
> On 19 September 2016 at 14:50, Nicolas Kourtellis 
> wrote:
> > Hi all,
> >
> > Our new release has been voted from the Apache SAMOA team and we are
> > opening the vote to the incubator email list for testing.
> >
> > Please vote on releasing the following release candidate as Apache
> > SAMOA (incubating)
> > version 0.4.0. This release will be the second release for SAMOA in the
> > incubator.
> >
> > -
> > The commit to be voted on is in the branch "releases/0.4.0-incubating"
> > (commit fc39238dd7d3674c069a8142312da8c1812bc907):
> > https://git1-us-west.apache.org/repos/asf/incubator-samoa/
> > repo?p=incubator-samoa.git;a=commit;h=fc39238dd7d3674c069a8142312da8
> > c1812bc907
> >
> > Tag v0.4.0-incubating:
> > https://git1-us-west.apache.org/repos/asf/incubator-samoa/
> > repo?p=incubator-samoa.git;a=tag;h=aa5bd941ccbed1aabb46b8119049ac
> 1bb293c3a2
> >
> > Release artifacts are signed with the following key:
> > *https://people.apache.org/keys/committer/nkourtellis.asc
> > *
> >
> > The staging repository for this release can be found at:
> > https://repository.apache.org/content/repositories/staging/
> > org/apache/samoa/samoa/0.4.0-incubating/
> >
> > The developer's version artifacts:
> > https://dist.apache.org/repos/dist/dev/incubator/samoa/0.4.
> 0-incubating-rc1/
> >
> > -
> >
> > Please vote on releasing this package as Apache SAMOA 0.4.0 (incubating).
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> least
> > three +1 PPMC votes are cast.
> >
> > [ ] +1 Release this package as Apache SAMOA 0.4.0 (incubating)
> > [ ] -1 Do not release this package because ...
> >
> > I'm +1 on the release.
> >
> > Cheers,
> >
> > Nicolas
> >
> >
> >
> > --
> > Nicolas Kourtellis
>
>
>
> --
> Stian Soiland-Reyes
> http://orcid.org/-0001-9842-9718
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-23 Thread Stian Soiland-Reyes
My vote: 0 (non-binding)

+1 tag/commit
+1 git vs source zip
+1 No binaries
0 mvn install fails in test
0 Apache rat is not happy
0 dist includes a  _remote.repositories file - this should be removed
+1 LICENSE DISCLAIMER NOTICE

I'm afraid it's not a positive vote from me because the build fails in
test - and the README told me to do "mvn package" (A workaround here
could be to use -DskipTests=true - but I don't know why the test
fails)


Apache rat complains about:
 !? CONTRIBUTING.md
 !? .travis.yml
 !? bin/samza-kryo

These should be added to pom.xml's apache-rat configuration to be
ignored. None of them are worthy of a license header I think.


Your vote email didn't say the hash of the source distro, it is (sha1)
cab5ace6bfff3b70f883db61578fbda847f0fd66
samoa-0.4.0-incubating-source-release.zip

(which matches *.sha1 on dist)





Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.411
sec <<< FAILURE! - in
org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest
testStartSendingEvents(org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest)
 Time elapsed: 0.313 sec  <<< ERROR!
java.lang.IllegalStateException: Missing invocation to mocked type at
this point; please make sure there is an associated mock field or mock
parameter in scope
at 
org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest$4.(SimpleEntranceProcessingItemTest.java:159)
at 
org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest.testStartSendingEvents(SimpleEntranceProcessingItemTest.java:155)

[INFO] Apache SAMOA ... SUCCESS [  4.748 s]
[INFO] samoa-instances  SUCCESS [  3.676 s]
[INFO] samoa-api .. SUCCESS [ 22.050 s]
[INFO] samoa-test . SUCCESS [  2.149 s]
[INFO] samoa-local  FAILURE [ 49.418 s]

using

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-38-generic", arch: "amd64", family: "unix"

On 19 September 2016 at 14:50, Nicolas Kourtellis  wrote:
> Hi all,
>
> Our new release has been voted from the Apache SAMOA team and we are
> opening the vote to the incubator email list for testing.
>
> Please vote on releasing the following release candidate as Apache
> SAMOA (incubating)
> version 0.4.0. This release will be the second release for SAMOA in the
> incubator.
>
> -
> The commit to be voted on is in the branch "releases/0.4.0-incubating"
> (commit fc39238dd7d3674c069a8142312da8c1812bc907):
> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
> repo?p=incubator-samoa.git;a=commit;h=fc39238dd7d3674c069a8142312da8
> c1812bc907
>
> Tag v0.4.0-incubating:
> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
> repo?p=incubator-samoa.git;a=tag;h=aa5bd941ccbed1aabb46b8119049ac1bb293c3a2
>
> Release artifacts are signed with the following key:
> *https://people.apache.org/keys/committer/nkourtellis.asc
> *
>
> The staging repository for this release can be found at:
> https://repository.apache.org/content/repositories/staging/
> org/apache/samoa/samoa/0.4.0-incubating/
>
> The developer's version artifacts:
> https://dist.apache.org/repos/dist/dev/incubator/samoa/0.4.0-incubating-rc1/
>
> -
>
> Please vote on releasing this package as Apache SAMOA 0.4.0 (incubating).
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PPMC votes are cast.
>
> [ ] +1 Release this package as Apache SAMOA 0.4.0 (incubating)
> [ ] -1 Do not release this package because ...
>
> I'm +1 on the release.
>
> Cheers,
>
> Nicolas
>
>
>
> --
> Nicolas Kourtellis



-- 
Stian Soiland-Reyes
http://orcid.org/-0001-9842-9718

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-21 Thread Flavio Junqueira
+1

- Built from sources and ran tests
- Checked LICENSE, NOTICE, and DISCLAIMER files
- Checked digests and signatures of the sources zip file and pom
- Ran rat through maven

I have some additional feedback:

- `mvn -Pstorm package` didn't build cleanly for me, I got test errors:

#
Tests in error: 
  AlgosTest.testCVPReqVHTWithStorm »  test timed out after 12 milliseconds
  AlgosTest.testVHTWithStorm »  test timed out after 6 milliseconds


Tests run: 4, Failures: 0, Errors: 2, Skipped: 0

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache SAMOA ... SUCCESS [  5.003 s]
[INFO] samoa-instances  SUCCESS [  2.798 s]
[INFO] samoa-api .. SUCCESS [ 19.174 s]
[INFO] samoa-test . SUCCESS [  4.978 s]
[INFO] samoa-storm  FAILURE [05:25 min]
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 05:58 min
[INFO] Finished at: 2016-09-21T10:12:56+01:00
[INFO] Final Memory: 55M/760M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.18:test (default-test) on 
project samoa-storm: There are test failures.
#

- `mvn apache-rat:check` doesn't run cleanly:

#
[INFO] 55 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/**/*
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/README.md
[INFO] 126 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 13 unknown: 13 generated: 0 
approved: 81 licence.
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache SAMOA ... FAILURE [  8.998 s]
[INFO] samoa-instances  SKIPPED
[INFO] samoa-api .. SKIPPED
[INFO] samoa-test . SKIPPED
[INFO] samoa-local  SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 19.683 s
[INFO] Finished at: 2016-09-21T10:26:38+01:00
[INFO] Final Memory: 23M/228M
[INFO] 
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.10:check 
(default-cli) on project samoa: Too many files with unapproved license: 13 See 
RAT report in: samoa-0.4.0-incubating/target/rat.txt -> [Help 1]
#

> On 20 Sep 2016, at 01:16, Alan Gates  wrote:
> 
> +1.  Checked the LICENSE, NOTICE, and DISCLAIMER files.  Checked the 
> signatures.  Did a build with a clean maven repo.  Checked for binary files.  
> Ran a rat check.
> 
> As a note there are several files that rat complains about.  Based on a quick 
> look I’m not sure it’s possible to add license headers to these files.  If it 
> isn’t it would be nice to put these in the exception list so that rat 
> succeeds.
> 
> Alan.
> 
>> On Sep 19, 2016, at 06:50, Nicolas Kourtellis  wrote:
>> 
>> Hi all,
>> 
>> Our new release has been voted from the Apache SAMOA team and we are
>> opening the vote to the incubator email list for testing.
>> 
>> Please vote on releasing the following release candidate as Apache
>> SAMOA (incubating)
>> version 0.4.0. This release will be the second release for SAMOA in the
>> incubator.
>> 
>> -
>> The commit to be voted on is in the branch "releases/0.4.0-incubating"
>> (commit fc39238dd7d3674c069a8142312da8c1812bc907):
>> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
>> repo?p=incubator-samoa.git;a=commit;h=fc39238dd7d3674c069a8142312da8
>> c1812bc907
>> 
>> Tag v0.4.0-incubating:
>> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
>> repo?p=incubator-samoa.git;a=tag;h=aa5bd941ccbed1aabb46b8119049ac1bb293c3a2
>> 
>> Release artifacts are signed with the following key:
>> *https://people.apache.org/keys/committer/nkourtellis.asc
>> *
>> 
>> The staging repository for this release can be found at:
>> https://repository.apache.org/content/repositories/staging/
>> org/apache/samoa/samoa/0.4.0-incubating/
>> 
>> The developer's version artifacts:
>> 

Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1

2016-09-19 Thread Alan Gates
+1.  Checked the LICENSE, NOTICE, and DISCLAIMER files.  Checked the 
signatures.  Did a build with a clean maven repo.  Checked for binary files.  
Ran a rat check.

As a note there are several files that rat complains about.  Based on a quick 
look I’m not sure it’s possible to add license headers to these files.  If it 
isn’t it would be nice to put these in the exception list so that rat succeeds.

Alan.

> On Sep 19, 2016, at 06:50, Nicolas Kourtellis  wrote:
> 
> Hi all,
> 
> Our new release has been voted from the Apache SAMOA team and we are
> opening the vote to the incubator email list for testing.
> 
> Please vote on releasing the following release candidate as Apache
> SAMOA (incubating)
> version 0.4.0. This release will be the second release for SAMOA in the
> incubator.
> 
> -
> The commit to be voted on is in the branch "releases/0.4.0-incubating"
> (commit fc39238dd7d3674c069a8142312da8c1812bc907):
> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
> repo?p=incubator-samoa.git;a=commit;h=fc39238dd7d3674c069a8142312da8
> c1812bc907
> 
> Tag v0.4.0-incubating:
> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
> repo?p=incubator-samoa.git;a=tag;h=aa5bd941ccbed1aabb46b8119049ac1bb293c3a2
> 
> Release artifacts are signed with the following key:
> *https://people.apache.org/keys/committer/nkourtellis.asc
> *
> 
> The staging repository for this release can be found at:
> https://repository.apache.org/content/repositories/staging/
> org/apache/samoa/samoa/0.4.0-incubating/
> 
> The developer's version artifacts:
> https://dist.apache.org/repos/dist/dev/incubator/samoa/0.4.0-incubating-rc1/
> 
> -
> 
> Please vote on releasing this package as Apache SAMOA 0.4.0 (incubating).
> 
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PPMC votes are cast.
> 
> [ ] +1 Release this package as Apache SAMOA 0.4.0 (incubating)
> [ ] -1 Do not release this package because ...
> 
> I'm +1 on the release.
> 
> Cheers,
> 
> Nicolas
> 
> 
> 
> -- 
> Nicolas Kourtellis


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org