Re: [VOTE} Apache Hudi (incubating) 0.5.0 RC5
The voting on RC5 is now closed and we will have a new release candidate shortly. Balaji.V (on behalf of Hudi PPMC) On 2019/10/16 15:15:35, Balaji Varadarajan wrote: > Thanks Justin. We have addressed all your concerns as part of this PR/commit. > > https://github.com/apache/incubator-hudi/commit/77f4e73615d0949eec70187e397ef17f62e908a0 > > We will kickstart a voting inside dev@hudi first. It would be very helpful > for us if you can take a look at the above commit to see if we are on the > right path. > > Thanks, > Balaji.V > > On 2019/10/11 07:29:40, Justin Mclean wrote: > > Hi, > > > > > It would be immensely helpful for us if you can point us to any other > > > issues/feedback concerning this release. > > > > There were no other issues other than the one mentioned. I did a detailed > > check, but as always there may of been something I’ve missed. > > > > Thanks, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE} Apache Hudi (incubating) 0.5.0 RC5
Thanks Justin. We have addressed all your concerns as part of this PR/commit. https://github.com/apache/incubator-hudi/commit/77f4e73615d0949eec70187e397ef17f62e908a0 We will kickstart a voting inside dev@hudi first. It would be very helpful for us if you can take a look at the above commit to see if we are on the right path. Thanks, Balaji.V On 2019/10/11 07:29:40, Justin Mclean wrote: > Hi, > > > It would be immensely helpful for us if you can point us to any other > > issues/feedback concerning this release. > > There were no other issues other than the one mentioned. I did a detailed > check, but as always there may of been something I’ve missed. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE} Apache Hudi (incubating) 0.5.0 RC5
Thanks Justin. Balaji.V On 2019/10/11 07:29:40, Justin Mclean wrote: > Hi, > > > It would be immensely helpful for us if you can point us to any other > > issues/feedback concerning this release. > > There were no other issues other than the one mentioned. I did a detailed > check, but as always there may of been something I’ve missed. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE} Apache Hudi (incubating) 0.5.0 RC5
Hi, > It would be immensely helpful for us if you can point us to any other > issues/feedback concerning this release. There were no other issues other than the one mentioned. I did a detailed check, but as always there may of been something I’ve missed. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE} Apache Hudi (incubating) 0.5.0 RC5
Hi Justin, We are very thankful for your detailed analysis to help make Apache Hudi release be compliant. We will work on your licensing comments and create a new release candidate shortly. It would be immensely helpful for us if you can point us to any other issues/feedback concerning this release. This would help us address all of them in one go. Thanks, Balaji.V (on behalf ofApache Hudi PPMC) On 2019/10/10 21:44:31, Justin Mclean wrote: > Hi, > > Sorry but it’s -1 (binding) due to license issues > > I checked: > - incubating in name > - signature and hash fine > - DISCLAIMER exist (but you might want to consider using the work in progress > disclaimer) > - LICENSE file is missing the appendix > - NOTICE is fine > - No unexpected binary file > - Source files have ASF headers > - Can compile from source > > This file [1] probably incorrectly has an ASF header on it, you may also want > to mention this file in LICENSE. It unclear what the license is of the code > contained in this file [2] are you sure you have permission to use this and > it’s under a compatible license? The code in here from stack overflow don’t > have a compatible license [3], see [4] (and [5]). > > Thanks, > Justin > > > 1. > ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java > 2. > ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java > 3. > ./hudi-0.5.0-incubating-rc5/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java > 4. https://www.apache.org/legal/resolved.html#stackoverflow > 5. https://issues.apache.org/jira/browse/LEGAL-471 > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE} Apache Hudi (incubating) 0.5.0 RC5
Hi, Sorry but it’s -1 (binding) due to license issues I checked: - incubating in name - signature and hash fine - DISCLAIMER exist (but you might want to consider using the work in progress disclaimer) - LICENSE file is missing the appendix - NOTICE is fine - No unexpected binary file - Source files have ASF headers - Can compile from source This file [1] probably incorrectly has an ASF header on it, you may also want to mention this file in LICENSE. It unclear what the license is of the code contained in this file [2] are you sure you have permission to use this and it’s under a compatible license? The code in here from stack overflow don’t have a compatible license [3], see [4] (and [5]). Thanks, Justin 1. ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java 2. ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java 3. ./hudi-0.5.0-incubating-rc5/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java 4. https://www.apache.org/legal/resolved.html#stackoverflow 5. https://issues.apache.org/jira/browse/LEGAL-471 - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE} Apache Hudi (incubating) 0.5.0 RC5
+1 binding On Thu, Oct 10, 2019 at 6:31 PM vbal...@apache.org wrote: > Dear IPMC, > Apache Hudi (incubating) (pronounced Hoodie) stands for Hadoop Upserts anD > Incrementals. Apache Hudi (incubating) manages storage of large analytical > datasets on DFS (Cloud stores, HDFS or any Hadoop FileSystem compatible > storage) and provide ability to query them. Apache Hudi (incubating) > community has voted on and approved the first source release. The source > release version is 0.5.0-incubating-rc5 > Results: 3 binding +1 votes > One -0 vote with the note that "NOTICE needs to include (incubating)" > This NOTICE file inconsistency is also seen in other incubating projects. > We have fixed the inconsistency subsequently in the NOTICE file in our > master branch : > https://github.com/apache/incubator-hudi/commit/834c591955cfa8a9c5f286967d693932564b6764 > . > Here is the voting thread: > > https://lists.apache.org/thread.html/7eac27261a475dfda25ea711e93d93e7305af38866f38e0dac80ad1f@%3Cdev.hudi.apache.org%3E > Here is the voting result email: > > https://lists.apache.org/thread.html/053dc9462759b7db9a60e4fd651dfe207f20d317c7ae195c390c2a55@%3Cdev.hudi.apache.org%3E > The Apache Hudi community had verified the following aspects of release: > - verified checksums and signatures [SUCCESS]- license header check > [SUCCESS]- No binaries in source release [SUCCESS] > - verified RAT check [SUCCESS] > - built from source release (mvn clean install -DskipTests) [SUCCESS] > - mvn test from source release [SUCCESS] > > I'd like to call a vote in general to approve the first release of Apache > Hudi (incubating). Please review and vote on the release candidate #5 for > the version 0.5.0, as follows: > [ ] +1, Approve the release [ ] 0 I don't feel strongly about it, but > I'm okay with the release > [ ] -1, Do not approve the release (please provide specific comments) > > > The complete staging area is available for your review, which includes: >- JIRA release notes [1] >- The official Apache source release to be deployed to dist.apache.org > [2], which are signed with the key with fingerprint > AF9BAF79D311A3D3288E583F24A499037262AAA4 [3], >- all artifacts to be deployed to the Maven Central Repository [4] >- source code tag "release-0.5.0-incubating-rc5" [5] > >- > https://jira.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822=12346087 > > >- > https://dist.apache.org/repos/dist/dev/incubator/hudi/hudi-0.5.0-incubating-rc5/ >- https://dist.apache.org/repos/dist/release/incubator/hudi/KEYS >- > https://repository.apache.org/content/repositories/orgapachehudi-1005/ >- > https://github.com/apache/incubator-hudi/tree/release-0.5.0-incubating-rc5 > > > > We also have a new release validation script available in master to > automate the usual checks. To run this > >- git clone g...@github.com:apache/incubator-hudi.git > >- cd incubator-hudi/scripts >- ./release/validate_staged_release.sh --release=0.5.0 --rc_num=5 > > The vote will be open for at least 72 hours. The vote will pass if a > majority of at least three +1 IPMC votes are cast > Thanks, > Balaji.V(on behalf of Apache Hudi PPMC) >
