[gentoo-dev] Add as-is to @GPL-COMPATIBLE licence group

2009-09-07 Thread Ulrich Mueller
Are there any objections against adding as-is to @GPL-COMPATIBLE?
It is less restrictive than the X11 licence (which is included).

Otherwise, users accepting only GPL compatible software wouldn't even
be able to install Emacs. ;-)

Ulrich



Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-09-07 Thread Daniel Drake

Robin H. Johnson wrote:

It does NOT check /proc/config.gz presently. The original logic against
not checking /proc was that we were targeting the kernel being built,
but that's moot given the use of `uname -r` in OUTPUT_DIR.


That seems like a bug. OUTPUT_DIR should default to unset which would 
cause the internal KV_OUT_DIR to be set to KV_DIR.  However I can see 
from the code that's not the case, and it's not clear why.


Relying on uname -r or /proc/config.gz is still something we should 
avoid (unless user configured, perhaps, or in very exceptional 
circumstances) however it looks like this isn't a change that you are 
proposing.


Thanks for working on this. It's a sensitive area so please take care 
and help people pick up the pieces. If you are really motivated, it 
might be worth rethinking the whole separate output directory 
implementation.


Daniel




Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-09-07 Thread Robin H. Johnson
On Mon, Sep 07, 2009 at 10:28:11AM +0100, Daniel Drake wrote:
 Robin H. Johnson wrote:
 It does NOT check /proc/config.gz presently. The original logic against
 not checking /proc was that we were targeting the kernel being built,
 but that's moot given the use of `uname -r` in OUTPUT_DIR.
 That seems like a bug. OUTPUT_DIR should default to unset which
 would cause the internal KV_OUT_DIR to be set to KV_DIR.  However I
 can see from the code that's not the case, and it's not clear why.
It's messy. I'll maybe tackle it after I'm done the work on configs and
USE=modules.

 Relying on uname -r or /proc/config.gz is still something we
 should avoid (unless user configured, perhaps, or in very
 exceptional circumstances) however it looks like this isn't a change
 that you are proposing.
The only time I'm saying that uname -r and /proc/config.gz are looked
as, is where there is no kernel sources or they are installed but not
configured. But that is as part of a larger body of work to fix up all
packages that are merely checking the kernel options during build, not
relying on the config to build.

Kernel modules still require configured sources to be installed.

 Thanks for working on this. It's a sensitive area so please take
 care and help people pick up the pieces. If you are really
 motivated, it might be worth rethinking the whole separate output
 directory implementation.
For anybody following this, we're doing the work on two tracker bugs:
283320 - Changes to linux-info
283900 - USE=modules change for linux-mod and packages.

We've got the core eclass stuff done, but not enabled yet.

If you want to test it it:
1. mv your .config or entire kernel sources away
2. I_KNOW_WHAT_I_AM_DOING=1 emerge udev

You should get warnings, but no errors.

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Trustee  Infrastructure Lead
E-Mail : robb...@gentoo.org
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85


pgptG3mmraEGR.pgp
Description: PGP signature


Re: [gentoo-portage-dev] ebuild --debug takes forever when FEATURES contains keeptemp: detects QA warnings in build.log

2009-09-07 Thread Zac Medico
Amit Dor-Shifer wrote:

 amit0 ~ $ grep -m 3 ': warning:'
 /var/tmp/portage/test/test-mkdir-1.0/temp/build.log
 + msgs=(: warning: dereferencing type-punned pointer will break
 strict-aliasing rules$ : warning: implicit declaration of function 
 : warning: incompatible implicit declaration of built-in function  :
 warning: is used uninitialized in this function$ : warning:
 comparisons like X=Y=Z do not have their mathematical meaning$ :
 warning: null argument where non-null required )
 + [[ -n : warning: dereferencing type-punned pointer will break
 strict-aliasing rules$ ]]
 + m=': warning: dereferencing type-punned pointer will break
 strict-aliasing rules$'

I think the attached patch should fix that. Could you test if for me?

-- 
Thanks,
Zac
Index: bin/misc-functions.sh
===
--- bin/misc-functions.sh	(revision 14213)
+++ bin/misc-functions.sh	(revision 14215)
@@ -408,6 +408,13 @@
 
 	# Evaluate misc gcc warnings
 	if [[ -n ${PORTAGE_LOG_FILE}  -r ${PORTAGE_LOG_FILE} ]] ; then
+		# In debug mode, this variable definition will produce
+		# a false positive if it's shown in the trace.
+		local reset_debug=0
+		if [[ ${-/x/} != $- ]] ; then
+			set +x
+			reset_debug=1
+		fi
 		local m msgs=(
 			: warning: dereferencing type-punned pointer will break strict-aliasing rules$
 			: warning: dereferencing pointer .* does break strict-aliasing rules$
@@ -417,6 +424,7 @@
 			: warning: comparisons like X=Y=Z do not have their mathematical meaning$
 			: warning: null argument where non-null required 
 		)
+		[[ $reset_debug = 1 ]]  set -x
 		abort=no
 		i=0
 		while [[ -n ${msgs[${i}]} ]] ; do