[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ruby/fromcvs: metadata.xml ChangeLog fromcvs-0_pre132.ebuild
Stanislav asked me to review. I'm also including the list since other
people may also be interested how to handle ruby ebuilds.
On Wed, 2011-06-15 at 22:04 +, Stanislav Ochotnicky (sochotnicky)
wrote:
sochotnicky11/06/15 22:04:56
Added:metadata.xml ChangeLog fromcvs-0_pre132.ebuild
Log:
New ebuild for fromcvs added to the tree. Fixes #173341
EAPI=2
USE_RUBY=ruby18 ree18
#mercurial after ruby!
inherit ruby-ng mercurial
MY_PV=${PV#0_pre}
DESCRIPTION=fromcvs converts cvs to git and hg
HOMEPAGE=http://ww2.fs.ei.tum.de/~corecode/hg/fromcvs;
SRC_URI=
EHG_REPO_URI=http://ww2.fs.ei.tum.de/~corecode/hg/fromcvs;
EHG_REVISION=${MY_PV}
LICENSE=BSD-4
SLOT=0
KEYWORDS=~amd64
IUSE=test
RUBY_S=${PN}-${PV}
RUBY_S is only supported in EAPI=4. You are getting away with this
because you are using a custom unpack method.
RDEPEND=dev-ruby/rcsparse =dev-ruby/rbtree-0.3.0-r2 dev-vcs/git
The ruby-ng eclasses frob RDEPEND, so you should always add to it, e.g.
RDEPEND=${RDEPEND} dev-vcs/git
Also, all ruby dependencies should be handled via ruby_add_rdepend to
ensure that your list in USE_RUBY is properly passed down to the
dependencies:
ruby_add_rdepend dev-ruby/rcsparse =dev-ruby/rb-tree-0.3.0-r2
# this is a workaround because combination of ruby-ng and mercurial is
# not working correctly for unpacking
src_prepare() {
for rubyv in ${USE_RUBY};do
Missing all target.
mkdir ${WORKDIR}/${rubyv}
|| die
cp -prl ${S} ${WORKDIR}/${rubyv}/${RUBY_S}
|| die
done
}
each_ruby_install() {
siteruby=$(${RUBY} -r rbconfig -e 'print Config::CONFIG[sitedir]')
insinto ${siteruby}
insinto ruby_rbconfig(sitedir)
doins *.rb || die Installation of rb files failes
Typo.
make_script togit
make_script tohg
}
make_script() {
echo ruby /usr/$(get_libdir)/ruby/site_ruby/$1.rb \$@ $1
I'm not sure how this should work? Perhaps you mean something like:
echo #!/usr/bin/ruby ...
dobin $1
|| die, (or use EAPI=4)
signature.asc
Description: This is a digitally signed message part
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ruby/rcsparse: rcsparse-0_pre45.ebuild metadata.xml ChangeLog
Another ruby ebuild review. Some of the issues that were present in
fromcvs are also in this ebuild, I won't repeat them.
On Wed, 2011-06-15 at 22:01 +, Stanislav Ochotnicky (sochotnicky)
wrote:
sochotnicky11/06/15 22:01:26
Added:rcsparse-0_pre45.ebuild metadata.xml ChangeLog
Log:
New ebuild for rcsparse, a dependency of fromcvs
(Portage version: 2.1.9.42/cvs/Linux x86_64)
Revision ChangesPath
1.1 dev-ruby/rcsparse/rcsparse-0_pre45.ebuild
file :
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-ruby/rcsparse/rcsparse-0_pre45.ebuild?rev=1.1view=markup
plain:
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-ruby/rcsparse/rcsparse-0_pre45.ebuild?rev=1.1content-type=text/plain
Index: rcsparse-0_pre45.ebuild
===
# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header:
/var/cvsroot/gentoo-x86/dev-ruby/rcsparse/rcsparse-0_pre45.ebuild,v 1.1
2011/06/15 22:01:26 sochotnicky Exp $
EAPI=2
USE_RUBY=ruby18 ree18
#mercurial after ruby!
inherit ruby-ng mercurial
MY_PV=${PV#0_pre}
DESCRIPTION=rcsparse ruby module
HOMEPAGE=http://ww2.fs.ei.tum.de/~corecode/hg/rcsparse;
SRC_URI=
EHG_REPO_URI=http://ww2.fs.ei.tum.de/~corecode/hg/rcsparse;
EHG_REVISION=${MY_PV}
LICENSE=BSD-4
SLOT=0
KEYWORDS=~amd64
IUSE=test
RUBY_S=${PN}-${PV}
# this is a workaround because combination of ruby-ng and mercurial is
# not working correctly for unpacking
src_prepare() {
for rubyv in ${USE_RUBY}; do
mkdir ${WORKDIR}/$rubyv
cp -prl ${S} ${WORKDIR}/$rubyv/${RUBY_S}
done
}
each_ruby_configure() {
${RUBY} extconf.rb || die
}
each_ruby_compile() {
emake || die
}
each_ruby_test() {
${RUBY} test.rb || die
Don't test the already installed version:
${RUBY} -I. test.rb || die
Also, depend on the test framework:
ruby_add_bdepend test? ( virtual/ruby-test-unit )
}
each_ruby_install() {
emake DESTDIR=${D} install || die
}
signature.asc
Description: This is a digitally signed message part
Re: [gentoo-dev] Re: Packages that explicitly DEPEND on sys-apps/sed
On Thu, 16 Jun 2011 23:11:36 -0400 Mike Frysinger vap...@gentoo.org wrote: we've already discussed POSIX strictness in the tree multiple times, and it's been shot down multiple times for good reason. GNU extensions make life a hell of a lot easier, the majority of people are developing/testing on such systems (Linux with GNU userland), and the burden on other ports is trivial if not negligible. let's stop kicking this horse as we're at the glue stage now. -mike OK, right, so where are we heading with this? sys-apps/sed is in system and it's bound to be =sed-4 and we're sticking with it. So are we going to get rid of it in all the ebuilds that still set that dep? jer
Re: [gentoo-dev] Re: [gentoo-commits] gentoo commit in xml/htdocs/proj/en/qa: index.xml
On 06/17/2011 09:53 PM, Mike Frysinger wrote: On Friday, June 17, 2011 14:34:35 Samuli Suominen wrote: I'm sorry, but honestly, did you have a point in there somewhere? i gathered that he had a specific case where he found a removal entry in the ChangeLog kept people from chasing their own tail for a while -mike well i read the post twice now and trying to put some logic behind it, but it doesnt have any damn my binary logic :)
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ruby/fromcvs: metadata.xml ChangeLog fromcvs-0_pre132.ebuild
Excerpts from Hans de Graaff's message of Sat Jun 18 08:16:25 +0200 2011:
Stanislav asked me to review. I'm also including the list since other
people may also be interested how to handle ruby ebuilds.
On Wed, 2011-06-15 at 22:04 +, Stanislav Ochotnicky (sochotnicky)
wrote:
sochotnicky11/06/15 22:04:56
Added:metadata.xml ChangeLog fromcvs-0_pre132.ebuild
Log:
New ebuild for fromcvs added to the tree. Fixes #173341
EAPI=2
USE_RUBY=ruby18 ree18
#mercurial after ruby!
inherit ruby-ng mercurial
MY_PV=${PV#0_pre}
DESCRIPTION=fromcvs converts cvs to git and hg
HOMEPAGE=http://ww2.fs.ei.tum.de/~corecode/hg/fromcvs;
SRC_URI=
EHG_REPO_URI=http://ww2.fs.ei.tum.de/~corecode/hg/fromcvs;
EHG_REVISION=${MY_PV}
LICENSE=BSD-4
SLOT=0
KEYWORDS=~amd64
IUSE=test
RUBY_S=${PN}-${PV}
RUBY_S is only supported in EAPI=4. You are getting away with this
because you are using a custom unpack method.
Good to know. Moved to EAPI4, with it few || die things went away.
RDEPEND=dev-ruby/rcsparse =dev-ruby/rbtree-0.3.0-r2 dev-vcs/git
The ruby-ng eclasses frob RDEPEND, so you should always add to it, e.g.
RDEPEND=${RDEPEND} dev-vcs/git
Also, all ruby dependencies should be handled via ruby_add_rdepend to
ensure that your list in USE_RUBY is properly passed down to the
dependencies:
ruby_add_rdepend dev-ruby/rcsparse =dev-ruby/rb-tree-0.3.0-r2
Fixed
# this is a workaround because combination of ruby-ng and mercurial is
# not working correctly for unpacking
src_prepare() {
for rubyv in ${USE_RUBY};do
Missing all target.
Fixed.
mkdir ${WORKDIR}/${rubyv}
|| die
cp -prl ${S} ${WORKDIR}/${rubyv}/${RUBY_S}
|| die
Fixed on second iteration :-)
done
}
each_ruby_install() {
siteruby=$(${RUBY} -r rbconfig -e 'print Config::CONFIG[sitedir]')
insinto ${siteruby}
insinto ruby_rbconfig(sitedir)
This didn't really work so I used
insinto $(ruby_rbconfig_value 'sitedir')
doins *.rb || die Installation of rb files failes
Typo.
Fixed
make_script togit
make_script tohg
}
make_script() {
echo ruby /usr/$(get_libdir)/ruby/site_ruby/$1.rb \$@ $1
I'm not sure how this should work? Perhaps you mean something like:
echo #!/usr/bin/ruby ...
In the end I fixed up upstream scripts because they had no shebangs and
isntalled them directly without any wrappers. They still use
/usr/bin/ruby where it would be nicer to have specific script for each
ruby version.
dobin $1
|| die, (or use EAPI=4)
EAPI4 it is
--
Stanislav Ochotnicky
PGP: 7B087241
jabber: stanis...@ochotnicky.com
signature.asc
Description: PGP signature
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ruby/fromcvs: metadata.xml ChangeLog fromcvs-0_pre132.ebuild
On 18.06.2011 09:16, Hans de Graaff wrote:
RDEPEND=dev-ruby/rcsparse =dev-ruby/rbtree-0.3.0-r2 dev-vcs/git
The ruby-ng eclasses frob RDEPEND, so you should always add to it, e.g.
RDEPEND=${RDEPEND} dev-vcs/git
This stacking is automatically handled by the package manager.
Regards,
Petteri
signature.asc
Description: OpenPGP digital signature
Re: [gentoo-dev] write to filesystem in pkg_pretend
On 17.06.2011 20:18, Mike Frysinger wrote: On Friday, June 17, 2011 12:25:21 Torsten Veller wrote: * justin j...@gentoo.org: Now using the new pkg_pretend for EAPI=4 While T is defined in all phases, PMS also says that pkg_pretend must not write to the filesystem. Is it allowed to write to T or not? Can the specs be clearer if it's allowed? sounds like a good reason to use emktemp as that'll utilize /tmp for files when $T is unavailable That approach would still write to the filesystem. With the current text the PM is probably allowed to set the sandbox so that writing is anywhere is denied. Regards, Petteri signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] write to filesystem in pkg_pretend
On 18/06/11 13:18, Petteri Räty wrote: On 17.06.2011 20:18, Mike Frysinger wrote: On Friday, June 17, 2011 12:25:21 Torsten Veller wrote: * justin j...@gentoo.org: Now using the new pkg_pretend for EAPI=4 While T is defined in all phases, PMS also says that pkg_pretend must not write to the filesystem. Is it allowed to write to T or not? Can the specs be clearer if it's allowed? sounds like a good reason to use emktemp as that'll utilize /tmp for files when $T is unavailable That approach would still write to the filesystem. With the current text the PM is probably allowed to set the sandbox so that writing is anywhere is denied. Regards, Petteri The reason why it would be beneficial to use is the pkg_pretend phase is simply that the checks would run at the beginning of a emerge and it would fail directly instead somewhere in the middle. For a single package it won't change much but for a huge emerge it changes the things. But when there is no writing allowed during the pretend phase. then the only chance is to move it to pkg_setup. thanks for clarification. signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] write to filesystem in pkg_pretend
On Sat, 18 Jun 2011, justin wrote: On 18/06/11 13:18, Petteri Räty wrote: That approach would still write to the filesystem. With the current text the PM is probably allowed to set the sandbox so that writing is anywhere is denied. The reason why it would be beneficial to use is the pkg_pretend phase is simply that the checks would run at the beginning of a emerge and it would fail directly instead somewhere in the middle. For a single package it won't change much but for a huge emerge it changes the things. But when there is no writing allowed during the pretend phase. then the only chance is to move it to pkg_setup. I wonder if we could loosen up that requirement in PMS. In Portage at least, T seems to point to an existing directory in pkg_pretend. I don't know about the other package managers though. Ulrich
Re: [gentoo-dev] write to filesystem in pkg_pretend
On Sat, 18 Jun 2011 14:18:28 +0200 justin j...@gentoo.org wrote: The reason why it would be beneficial to use is the pkg_pretend phase is simply that the checks would run at the beginning of a emerge and it would fail directly instead somewhere in the middle. For a single package it won't change much but for a huge emerge it changes the things. Hang on... What happens if someone doesn't have a fortran compiler installed, but installs one and then installs a fortran-using package all as part of the same group of packages? Then your pkg_pretend will fail incorrectly. Also, you appear to be assuming that environment variable saving carries over from pkg_pretend to later phases. It doesn't. -- Ciaran McCreesh signature.asc Description: PGP signature
[gentoo-dev] Last rites: net-mail/teapop
# Eray Aslan e...@gentoo.org (18 Jun 2011) # No upstream. Does not work correctly. Bugs #275764 #370171. # Several working alternatives, including dovecot, cyrus, mailutils. # Removal in 30 days net-mail/teapop -- Eray Aslan Developer, Gentoo Linux eras at gentoo.org pgp6NX2fNKZ50.pgp Description: PGP signature
[gentoo-dev] Last rites: mail-client/smtpclient
# Eray Aslan e...@gentoo.org (18 Jun 2011) # Dead upstream. Lots of alternatives including mailx, # nail, ssmtp, postfix... # Removal in 30 days mail-client/smtpclient -- Eray Aslan Developer, Gentoo Linux eras at gentoo.org pgp2bU8jMnaZR.pgp Description: PGP signature
Re: [gentoo-dev] write to filesystem in pkg_pretend
On 18/06/11 15:08, Ciaran McCreesh wrote: On Sat, 18 Jun 2011 14:18:28 +0200 justin j...@gentoo.org wrote: The reason why it would be beneficial to use is the pkg_pretend phase is simply that the checks would run at the beginning of a emerge and it would fail directly instead somewhere in the middle. For a single package it won't change much but for a huge emerge it changes the things. Hang on... What happens if someone doesn't have a fortran compiler installed, but installs one and then installs a fortran-using package all as part of the same group of packages? Then your pkg_pretend will fail incorrectly. That's a serious reason to go to pkg_Setup, which ends the discusion. thanks. Also, you appear to be assuming that environment variable saving carries over from pkg_pretend to later phases. It doesn't. If I get it correctly the pretend phase is also executed when the individual packages gets emerged not only when the emerge of multiple packages is started. But the original intention of everything is that user can do FC=myFortranCompiler emerge foo. And there the FC will be preserved for every package. Thanks justin signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] write to filesystem in pkg_pretend
So here are the last changes. Everything is in pkg_setup now, because of
the dependency problem found by Ciaran.
eclass/fortran-2.eclass | 28 ++--
1 files changed, 6 insertions(+), 22 deletions(-)
diff --git a/eclass/fortran-2.eclass b/eclass/fortran-2.eclass
index 600d107..3f35197 100644
--- a/eclass/fortran-2.eclass
+++ b/eclass/fortran-2.eclass
@@ -16,7 +16,7 @@
# and exports the variables FC and F77.
# Optionally, it checks for extended capabilities based on
# the variable options selected in the ebuild
-# The only phase functions exported are pkg_pretend and pkg_setup.
+# The only phase function exported is fortran-2_pkg_setup.
# @ECLASS-VARIABLE: FORTRAN_NEED_OPENMP
# @DESCRIPTION:
@@ -122,10 +122,10 @@ _die_msg() {
die Currently no working fortran compiler is available
}
-# @FUNCTION: fortran-2_pkg_pretend
+# @FUNCTION: fortran-2_pkg_setup
# @DESCRIPTION:
# Setup functionallity, checks for a valid fortran compiler and
optionally for its openmp support.
-fortran-2_pkg_pretend() {
+fortran-2_pkg_setup() {
local dialect
: ${F77:=$(tc-getFC)}
@@ -145,27 +145,11 @@ fortran-2_pkg_pretend() {
_fortran-has-openmp || \
die Please install current gcc with USE=openmp or set
the FC
variable to a compiler that supports OpenMP
fi
-}
-
-# @FUNCTION: fortran-2_pkg_setup
-# @DESCRIPTION:
-# In EAPI 4 it calls the compiler check. This behavior is deprecated
-# and will be removed at 01-Okt-2011. Please migrate to EAPI=4.
-#
-# Exports the FC and F77 variable according to the compiler checks.
-fortran-2_pkg_setup() {
- if has ${EAPI:-0} 0 1 2 3; then
- ewarn The support for EAPI=${EAPI} by the fortran-2.eclass
- ewarn will be end at 01-Okt-2011
- ewarn Please migrate your package to EAPI=4
- fortran-2_pkg_pretend
- fi
- [[ -n ${F77} ]] || export F77=$(tc-getFC)
- [[ -n ${FC} ]] || export FC=$(tc-getFC)
+ tc-export F77
+ tc-export FC
}
case ${EAPI:-0} in
- 1|2|3) EXPORT_FUNCTIONS pkg_setup ;;
- 4) EXPORT_FUNCTIONS pkg_pretend pkg_setup ;;
+ 1|2|3|4) EXPORT_FUNCTIONS pkg_setup ;;
*) die EAPI=${EAPI} is not supported ;;
esac
signature.asc
Description: OpenPGP digital signature
[gentoo-dev] sec-policy/selinux-policykit for removal
sec-policy/selinux-policykit masked for removal, bug #371441 There are no package depending on it. -- Anthony G. Basile, Ph.D. Gentoo Linux Developer [Hardened] E-Mail: bluen...@gentoo.org GnuPG FP : 8040 5A4D 8709 21B1 1A88 33CE 979C AF40 D045 5535 GnuPG ID : D0455535
Re: [gentoo-dev] write to filesystem in pkg_pretend
On Saturday, June 18, 2011 10:55:50 justin wrote: + tc-export F77 + tc-export FC tc-export F77 FC -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] Re: Packages that explicitly DEPEND on sys-apps/sed
On Saturday, June 18, 2011 02:26:56 Jeroen Roovers wrote: OK, right, so where are we heading with this? sys-apps/sed is in system and it's bound to be =sed-4 and we're sticking with it. So are we going to get rid of it in all the ebuilds that still set that dep? for the packages that just depend on raw sed, it should most likely be dropped. for those depending on a newer version, they're probably doing it because they dont work with an older one, and those cant be dropped until our system set forces a new enough sed. the base profile only requires sys- apps/sed atm, so that'd probably need updating to read =sys-apps/sed-4. -mike signature.asc Description: This is a digitally signed message part.
