Re: [gentoo-dev] [PATCH v3] eclass/kernel-2.eclass: Remove use of tr in global scope

[Michał Górny]

Dnia 7 września 2017 01:40:50 CEST, Mike Pagano  napisał(a):
>This time, use bash 4.0, but limit the use of this function to ebuild
>that have EAPI >= 6.
>Display a warning for maintainers to upgrade their ebuilds, or remove
>the call.
>Thanks to mgorny for the suggestion.
>
>Signed-off-by: Mike Pagano 
>---
> eclass/kernel-2.eclass | 20 +---
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
>diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
>index 84909f30c..a80f3e91a 100644
>--- a/eclass/kernel-2.eclass
>+++ b/eclass/kernel-2.eclass
>@@ -1407,11 +1407,20 @@ getfilevar() {
> # This function sets ARCH_URI and ARCH_PATCH
> # with the neccessary info for the arch sepecific compatibility
> # patchsets.
>+# To use, an ebuild could contain a line like:
>+# AMD64_URI=http//linktothearchspecificpatch
>+# This function requires EAPI >= 6.
> 
> detect_arch() {
> 
>-  local ALL_ARCH LOOP_ARCH LOOP_ARCH_L COMPAT_URI i TC_ARCH_KERNEL
>+  if [[ "${EAPI}" -lt 6 ]]; then 

EAPI is not a number. The next one we'll call gray-grizzly just to prove the 
point.

>+  eqawarn "ebuild is attempting to call detect_arch when EAPI < 
>6." 
>+  eqawarn "This function will not be executed." 
>+  return
>+  fi
> 
>+  local ALL_ARCH LOOP_ARCH LOOP_ARCH_L COMPAT_URI i TC_ARCH_KERNEL
>+  
>   # COMPAT_URI is the contents of ${ARCH}_URI
>   # ARCH_URI is the URI for all the ${ARCH}_URI patches
>   # ARCH_PATCH is ARCH_URI broken into files for UNIPATCH
>@@ -1425,18 +1434,15 @@ detect_arch() {
>   COMPAT_URI="${LOOP_ARCH}_URI"
>   COMPAT_URI="${!COMPAT_URI}"
> 
>-  declare -l LOOP_ARCH_L=${LOOP_ARCH}
>-
>   [[ -n ${COMPAT_URI} ]] && \
>-  ARCH_URI="${ARCH_URI} ${LOOP_ARCH_L}? ( ${COMPAT_URI} )"
>+  ARCH_URI="${ARCH_URI} ${LOOP_ARCH,,}? ( ${COMPAT_URI} )"
> 
>-  declare -u TC_ARCH_KERNEL=$(tc-arch-kernel)
>-  if [[ ${LOOP_ARCH} == ${TC_ARCH_KERNEL} ]]; then
>+  TC_ARCH_KERNEL=$(tc-arch-kernel);

Strictly speaking, you aren't supposed to call this in global scope either. To 
do it properly, you should split the function into two parts, one for global 
scope, and the other for phase functions. 

>+  if [[ ${LOOP_ARCH} == ${TC_ARCH_KERNEL^^} ]]; then
>   for i in ${COMPAT_URI}; do
>   ARCH_PATCH="${ARCH_PATCH} ${DISTDIR}/${i/*\//}"
>   done
>   fi
>-
>   done
> }
> 


-- 
Best regards,
Michał Górny (by phone)

Re: [gentoo-dev] [PATCH v3] eclass/kernel-2.eclass: Remove use of tr in global scope

[Floyd Anderson]

Hello,

some remarks below ...

On Mi, 06 Sep 23:40:50 +
Mike Pagano  wrote:

This time, use bash 4.0, but limit the use of this function to ebuild that have 
EAPI >= 6.
Display a warning for maintainers to upgrade their ebuilds, or remove the call.
Thanks to mgorny for the suggestion.

Signed-off-by: Mike Pagano 
---
eclass/kernel-2.eclass | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index 84909f30c..a80f3e91a 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -1407,11 +1407,20 @@ getfilevar() {
# This function sets ARCH_URI and ARCH_PATCH
# with the neccessary info for the arch sepecific compatibility
# patchsets.
+# To use, an ebuild could contain a line like:
+# AMD64_URI=http//linktothearchspecificpatch


Even it’s just a comment:

   # AMD64_URI="http://link-to-the-arch-specific-patch;

looks friendlier to my eyes. However at least the colon after the scheme 
should be given.



+# This function requires EAPI >= 6.

detect_arch() {

-   local ALL_ARCH LOOP_ARCH LOOP_ARCH_L COMPAT_URI i TC_ARCH_KERNEL
+   if [[ "${EAPI}" -lt 6 ]]; then
+   eqawarn "ebuild is attempting to call detect_arch when EAPI < 
6."
+   eqawarn "This function will not be executed."
+   return
+   fi

+   local ALL_ARCH LOOP_ARCH LOOP_ARCH_L COMPAT_URI i TC_ARCH_KERNEL


Declaration of LOOP_ARCH_L seems obsolete now.


+   
# COMPAT_URI is the contents of ${ARCH}_URI
# ARCH_URI is the URI for all the ${ARCH}_URI patches
# ARCH_PATCH is ARCH_URI broken into files for UNIPATCH
@@ -1425,18 +1434,15 @@ detect_arch() {
COMPAT_URI="${LOOP_ARCH}_URI"
COMPAT_URI="${!COMPAT_URI}"

-   declare -l LOOP_ARCH_L=${LOOP_ARCH}
-
[[ -n ${COMPAT_URI} ]] && \
-   ARCH_URI="${ARCH_URI} ${LOOP_ARCH_L}? ( ${COMPAT_URI} )"
+   ARCH_URI="${ARCH_URI} ${LOOP_ARCH,,}? ( ${COMPAT_URI} )"

-   declare -u TC_ARCH_KERNEL=$(tc-arch-kernel)
-   if [[ ${LOOP_ARCH} == ${TC_ARCH_KERNEL} ]]; then
+   TC_ARCH_KERNEL=$(tc-arch-kernel);
+   if [[ ${LOOP_ARCH} == ${TC_ARCH_KERNEL^^} ]]; then
for i in ${COMPAT_URI}; do
ARCH_PATCH="${ARCH_PATCH} ${DISTDIR}/${i/*\//}"
done
fi
-
done
}

--
2.13.5





--
Regards,
floyd

[gentoo-dev] [PATCH v3] eclass/kernel-2.eclass: Remove use of tr in global scope

[Mike Pagano]

This time, use bash 4.0, but limit the use of this function to ebuild that have 
EAPI >= 6.
Display a warning for maintainers to upgrade their ebuilds, or remove the call.
Thanks to mgorny for the suggestion.

Signed-off-by: Mike Pagano 
---
 eclass/kernel-2.eclass | 20 +---
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index 84909f30c..a80f3e91a 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -1407,11 +1407,20 @@ getfilevar() {
 # This function sets ARCH_URI and ARCH_PATCH
 # with the neccessary info for the arch sepecific compatibility
 # patchsets.
+# To use, an ebuild could contain a line like:
+# AMD64_URI=http//linktothearchspecificpatch
+# This function requires EAPI >= 6.
 
 detect_arch() {
 
-   local ALL_ARCH LOOP_ARCH LOOP_ARCH_L COMPAT_URI i TC_ARCH_KERNEL
+   if [[ "${EAPI}" -lt 6 ]]; then 
+   eqawarn "ebuild is attempting to call detect_arch when EAPI < 
6." 
+   eqawarn "This function will not be executed." 
+   return
+   fi
 
+   local ALL_ARCH LOOP_ARCH LOOP_ARCH_L COMPAT_URI i TC_ARCH_KERNEL
+   
# COMPAT_URI is the contents of ${ARCH}_URI
# ARCH_URI is the URI for all the ${ARCH}_URI patches
# ARCH_PATCH is ARCH_URI broken into files for UNIPATCH
@@ -1425,18 +1434,15 @@ detect_arch() {
COMPAT_URI="${LOOP_ARCH}_URI"
COMPAT_URI="${!COMPAT_URI}"
 
-   declare -l LOOP_ARCH_L=${LOOP_ARCH}
-
[[ -n ${COMPAT_URI} ]] && \
-   ARCH_URI="${ARCH_URI} ${LOOP_ARCH_L}? ( ${COMPAT_URI} )"
+   ARCH_URI="${ARCH_URI} ${LOOP_ARCH,,}? ( ${COMPAT_URI} )"
 
-   declare -u TC_ARCH_KERNEL=$(tc-arch-kernel)
-   if [[ ${LOOP_ARCH} == ${TC_ARCH_KERNEL} ]]; then
+   TC_ARCH_KERNEL=$(tc-arch-kernel);
+   if [[ ${LOOP_ARCH} == ${TC_ARCH_KERNEL^^} ]]; then
for i in ${COMPAT_URI}; do
ARCH_PATCH="${ARCH_PATCH} ${DISTDIR}/${i/*\//}"
done
fi
-
done
 }
 
-- 
2.13.5




signature.asc
Description: OpenPGP digital signature

Re: [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed

[Michael Orlitzky]

On 09/06/2017 02:39 PM, Chris Mayo wrote:
> 
> I believe @EXAMPLE is only for the first documentation block introducing the 
> eclass.
> 
> At least where it is used for functions the text doesn't show up in the man 
> page.
> e.g. prefix.eclass hprefixify() and prefixify_ro()
> 

Looks like you're right, sorry for the noise.

Re: [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed

[Chris Mayo]

On 03/09/17 22:22, Michael Orlitzky wrote:
> On 09/03/2017 11:56 AM, Chris Mayo wrote:
>>  #
>>  # The following snippet would suggest app-misc/foo for optional foo support,
>>  # app-misc/bar or app-misc/baz[bar] for optional bar support
>>
> 
> Would the @EXAMPLE tag[0] make sense here?
> 
> 
> [0] https://devmanual.gentoo.org/eclass-writing/index.html
> 

I believe @EXAMPLE is only for the first documentation block introducing the 
eclass.

At least where it is used for functions the text doesn't show up in the man 
page.
e.g. prefix.eclass hprefixify() and prefixify_ro()

https://devmanual.gentoo.org/eclass-reference/prefix.eclass/index.html

https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/prefix.eclass?id=61b861acd7b49083dab687e133f30f3331cb7480

Re: [gentoo-dev] Server hardaware give away (misc archs)

[R0b0t1]

On Wednesday, September 6, 2017, R0b0t1  wrote:
> On Wednesday, September 6, 2017, Brendan Horan  wrote:
>> Hi R0b0t1,
>>
>> Sounds good to me.
>> Shipping a 30kg+ system by it self will not be cheep.
>> This is originally why I had the idea to ship all the systems together.
>>
>
> I thought so. Shipping will still be cheaper than a used unit from
someone else, so thank you.
>

Sorry, still a tad excited and I forgot to finish again.

If you want to ship all the servers at once I might be able to find homes
for them stateside, but it looks like other people are already interested.
Also my budget isn't gigantic and that much weight that far is likely to be
expensive.

>> Specs are :
>>
http://www-01.ibm.com/common/ssi/ShowDoc.wss?docURL=/common/ssi/rep_sm/1/872/ENUS8203-_h01/index.html=en_locale=en
>>
>> Sorry its a single 4-core CPU.
>>
>
> That is fine. I did not expect to come into a 40+ core POWER server any
time soon. The cheaper servers are about as rare as the expensive ones.
>
>> Lets talk about shipping options, I am open to suggestions and ideas.
>>
>
> If you do not mind I am moving to a private message to discuss this. In
short, time is not too important so the cheapest of the carriers available
to you would work.
>
> I should be able to buy postage and transmit it to you if you have a box
and scale ready.
>
>> Thanks
>> Brendan (irc : undersys)
>>
>>
>> - On 6 Sep, 2017, at 2:04 PM, R0b0t1 r03...@gmail.com wrote:

 I would very much appreciate it if I could claim the IBM Power server.
 I have been interested in IBM's Power architecture and its supporting
 hardware for quite a while now. There are not many machines sold on
 the secondhand market and I do not have the funds to purchase one in
 that way.
>>>
>>> Sorry for the follow-up. To clarify, I expect to be able to cover the
>>> cost of shipping.
>>>
 The specs are mostly irrelevant as long as it has a Power
 CPU, but they would be nice to know.

 The use for the machine would be to experiment with the novel
 architecture while maintaining it with Gentoo, which would likely
 spill over into providing support for Gentoo on IBM Power.

 I will try to catch you on IRC, but hopefully you receive this message
as well.

 Respectfully,
>>> >  R0b0t1
>>
>>

[gentoo-dev] Server hardaware give away (misc archs)

[R0b0t1]

On Wednesday, September 6, 2017, Brendan Horan  wrote:
> Hi R0b0t1,
>
> Sounds good to me.
> Shipping a 30kg+ system by it self will not be cheep.
> This is originally why I had the idea to ship all the systems together.
>

I thought so. Shipping will still be cheaper than a used unit from someone
else, so thank you.

> Specs are :
>
http://www-01.ibm.com/common/ssi/ShowDoc.wss?docURL=/common/ssi/rep_sm/1/872/ENUS8203-_h01/index.html=en_locale=en
>
> Sorry its a single 4-core CPU.
>

That is fine. I did not expect to come into a 40+ core POWER server any
time soon. The cheaper servers are about as rare as the expensive ones.

> Lets talk about shipping options, I am open to suggestions and ideas.
>

If you do not mind I am moving to a private message to discuss this. In
short, time is not too important so the cheapest of the carriers available
to you would work.

I should be able to buy postage and transmit it to you if you have a box
and scale ready.

> Thanks
> Brendan (irc : undersys)
>
>
> - On 6 Sep, 2017, at 2:04 PM, R0b0t1 r03...@gmail.com wrote:
>>>
>>> I would very much appreciate it if I could claim the IBM Power server.
>>> I have been interested in IBM's Power architecture and its supporting
>>> hardware for quite a while now. There are not many machines sold on
>>> the secondhand market and I do not have the funds to purchase one in
>>> that way.
>>
>> Sorry for the follow-up. To clarify, I expect to be able to cover the
>> cost of shipping.
>>
>>> The specs are mostly irrelevant as long as it has a Power
>>> CPU, but they would be nice to know.
>>>
>>> The use for the machine would be to experiment with the novel
>>> architecture while maintaining it with Gentoo, which would likely
>>> spill over into providing support for Gentoo on IBM Power.
>>>
>>> I will try to catch you on IRC, but hopefully you receive this message
as well.
>>>
>>> Respectfully,
>> >  R0b0t1
>
>

Re: [gentoo-dev] Last rites: games-rpg/nwn-shadowlordsdreamcatcherdemon

[Rich Freeman]

On Wed, Sep 6, 2017 at 2:52 AM, Ulrich Mueller  wrote:
>> On Tue, 5 Sep 2017, Gordon Pettey wrote:
>
>> Can these package.mask notes stop saying "no alternative found" when
>> it's obvious five seconds of Google searching was not even performed
>> to find an alternative?
>> https://neverwintervault.org/project/nwn1/module/shadowlords-dreamcatcher-and-demon-campaigns
>> has live links, and the exe even matches the sha256sum.
>
> Do they have permission to redistribute the file, though? The ebuild
> is mirror restricted and LICENSE says "all-rights-reserved".
>

Do we routinely confirm that any site we list in SRC_URI has
permission to redistribute files?  That seems like a slippery slope.
In any case, as far as I can tell this is probably one of the largest
sites for hosting this sort of content and I can't imagine that it
would have escaped the author's notice if they didn't want the files
distributed there.

-- 
Rich

Re: [gentoo-dev] Server hardaware give away (misc archs)

[Brendan Horan]

Hi R0b0t1,

Sounds good to me.
Shipping a 30kg+ system by it self will not be cheep.
This is originally why I had the idea to ship all the systems together.

Specs are :
http://www-01.ibm.com/common/ssi/ShowDoc.wss?docURL=/common/ssi/rep_sm/1/872/ENUS8203-_h01/index.html=en_locale=en

Sorry its a single 4-core CPU.

Lets talk about shipping options, I am open to suggestions and ideas.

Thanks
Brendan (irc : undersys)


- On 6 Sep, 2017, at 2:04 PM, R0b0t1 r03...@gmail.com wrote:
>>
>> I would very much appreciate it if I could claim the IBM Power server.
>> I have been interested in IBM's Power architecture and its supporting
>> hardware for quite a while now. There are not many machines sold on
>> the secondhand market and I do not have the funds to purchase one in
>> that way.
> 
> Sorry for the follow-up. To clarify, I expect to be able to cover the
> cost of shipping.
> 
>> The specs are mostly irrelevant as long as it has a Power
>> CPU, but they would be nice to know.
>>
>> The use for the machine would be to experiment with the novel
>> architecture while maintaining it with Gentoo, which would likely
>> spill over into providing support for Gentoo on IBM Power.
>>
>> I will try to catch you on IRC, but hopefully you receive this message as 
>> well.
>>
>> Respectfully,
> >  R0b0t1

Re: [gentoo-dev] Server hardaware give away (misc archs)

[Brendan Horan]

Hi Lucas,

Its a tough moment that is for sure!

Its a Zx2000, not Zx6000.
Single Itanium2 Deerfield.

Let me know if your still interested.

Thanks
Brendan (irc : undersys)

- On 6 Sep, 2017, at 9:11 AM, Lucas Ramage ramage.luca...@gmail.com wrote:

> I'm sorry that you must part with your machines. But it's awesome to see
> that they will go to a new home!
> 
> I would like to get my hands on an HP Zx6000 like this:

Re: [gentoo-dev] Server hardaware give away (misc archs)

[Brendan Horan]

Hi Johnson,

Thanks for the interest. 
I know there are some issues with shipping second hand computers into China.
I could ask SF here in HK about if they feel it would make it thought customs.

Your thoughts?

Thanks
Brendan (irc : undersys)


- On 6 Sep, 2017, at 8:41 AM, Johnson Steward i...@jsteward.moe wrote:

> Hi Brendan,
> 
> I'm in Beijing and interested in these machines, especially the SPARC.
> Though not a Gentoo Dev, In recently struggling with Gentoo BSD and,
> hopefully, have some experience with Gentoo. It would be great if I can get
> one and test the packages on that system and, hopefully, contribute to the
> not-so-popular architectures.
> 
> Yours,

Re: [gentoo-dev] Last rites: games-rpg/nwn-shadowlordsdreamcatcherdemon

[Ulrich Mueller]

> On Tue, 5 Sep 2017, Gordon Pettey wrote:

> Can these package.mask notes stop saying "no alternative found" when
> it's obvious five seconds of Google searching was not even performed
> to find an alternative?
> https://neverwintervault.org/project/nwn1/module/shadowlords-dreamcatcher-and-demon-campaigns
> has live links, and the exe even matches the sha256sum.

Do they have permission to redistribute the file, though? The ebuild
is mirror restricted and LICENSE says "all-rights-reserved".

Ulrich


pgpp7l3H2mnxt.pgp
Description: PGP signature

Re: [gentoo-dev] Server hardaware give away (misc archs)

[R0b0t1]

On Tue, Sep 5, 2017 at 10:18 PM, R0b0t1  wrote:
> On Tue, Sep 5, 2017 at 7:20 PM, Brendan Horan  wrote:
>> Hi everyone,
>>
>> I have some hardware I would like to see go to a good home.
>> I would prefer it to be someone working with Gentoo.
>> That was my goal, but life changes :)
>>
>>
>> I have the following :
>> * HP j6750 (2x cpu PA-RSIC)
>> * HP Zx2000 Itanium2 (single cpu) (custom 4ru unit)
>> * IBM Power 6+ p560 (dual cpu)
>> * Sun SPARC T5120 (single cpu)
>>
>> The systems are all in working order. With decent specs.
>> All have 8gb of memory or more
>> All have at least 2 disks (ranging from 32gb to 300gb)
>> I have some misc spares for all of the above.
>> If you want more details on any of the systems please ask.
>> You can also catch me on IRC @ #gentoo-proxy-maint
>>
>>
>> Ideally I would want to ship it to one location.
>> If you then wanted to ship interstate/country from that point I don't care.
>> I live in Hong Kong, no one hear but scrap metal places what this kit.
>> I don't mind helping pay some of the shipping costs.
>> I do not want payment for the systems, just a good home vs the scrap heap.
>>
>> Thanks
>> Brendan
>>
>
> Hello,
>
> I would very much appreciate it if I could claim the IBM Power server.
> I have been interested in IBM's Power architecture and its supporting
> hardware for quite a while now. There are not many machines sold on
> the secondhand market and I do not have the funds to purchase one in
> that way.

Sorry for the follow-up. To clarify, I expect to be able to cover the
cost of shipping.

> The specs are mostly irrelevant as long as it has a Power
> CPU, but they would be nice to know.
>
> The use for the machine would be to experiment with the novel
> architecture while maintaining it with Gentoo, which would likely
> spill over into providing support for Gentoo on IBM Power.
>
> I will try to catch you on IRC, but hopefully you receive this message as 
> well.
>
> Respectfully,
>  R0b0t1