Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
On Wed, Jun 09, 2010 at 07:08:44PM +0200, Paweee Hajdan, Jr. wrote: On 6/4/10 5:11 PM, Paweł Hajdan, Jr. wrote: What do you think about doing the following change in /usr/portage/profiles/targets/developer/make.defaults: The following change has now landed in CVS: I'd suggest a dev-announce in the future on that one w/ some lead time... dev profile is admittedly 'dev', but changes that can induce an hour build taking a day due to tests being ran is usually good to give a heads up on. Aside from that, change makes sense. ~harring pgpOiV1OQc5Rf.pgp Description: PGP signature
Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
On 06/10/2010 07:28 PM, Brian Harring wrote: On Wed, Jun 09, 2010 at 07:08:44PM +0200, Paweee Hajdan, Jr. wrote: On 6/4/10 5:11 PM, Paweł Hajdan, Jr. wrote: What do you think about doing the following change in /usr/portage/profiles/targets/developer/make.defaults: The following change has now landed in CVS: I'd suggest a dev-announce in the future on that one w/ some lead time... dev profile is admittedly 'dev', but changes that can induce an hour build taking a day due to tests being ran is usually good to give a heads up on. Aside from that, change makes sense. ~harring not really, since FEATURES=test was already there... http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/profiles/targets/developer/make.defaults?r1=1.3r2=1.4
Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
On Thu, Jun 10, 2010 at 07:36:51PM +0300, Samuli Suominen wrote: On 06/10/2010 07:28 PM, Brian Harring wrote: On Wed, Jun 09, 2010 at 07:08:44PM +0200, Paweee Hajdan, Jr. wrote: On 6/4/10 5:11 PM, Paweł Hajdan, Jr. wrote: What do you think about doing the following change in /usr/portage/profiles/targets/developer/make.defaults: The following change has now landed in CVS: I'd suggest a dev-announce in the future on that one w/ some lead time... dev profile is admittedly 'dev', but changes that can induce an hour build taking a day due to tests being ran is usually good to give a heads up on. Aside from that, change makes sense. ~harring not really, since FEATURES=test was already there... http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/profiles/targets/developer/make.defaults?r1=1.3r2=1.4 Nard, good catch. Nevermind ;) ~harring pgpNc8szjoWcV.pgp Description: PGP signature
Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
On 6/4/10 5:11 PM, Paweł Hajdan, Jr. wrote: What do you think about doing the following change in /usr/portage/profiles/targets/developer/make.defaults: The following change has now landed in CVS: Index: targets/developer/make.defaults === RCS file: /var/cvsroot/gentoo-x86/profiles/targets/developer/make.defaults,v retrieving revision 1.3 retrieving revision 1.4 diff -u -B -r1.3 -r1.4 --- targets/developer/make.defaults 4 Oct 2009 09:44:27 - 1.3 +++ targets/developer/make.defaults 9 Jun 2010 17:03:37 - 1.4 @@ -1,8 +1,8 @@ # Copyright 1999-2008 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 -# $Header: /var/cvsroot/gentoo-x86/profiles/targets/developer/make.defaults,v 1.3 2009/10/04 09:44:27 ssuominen Exp $ +# $Header: /var/cvsroot/gentoo-x86/profiles/targets/developer/make.defaults,v 1.4 2010/06/09 17:03:37 phajdan.jr Exp $ -FEATURES=collision-protect cvs digest multilib-strict sign splitdebug stricter test userpriv usersandbox +FEATURES=collision-protect cvs digest multilib-strict sign splitdebug stricter test test-fail-continue userpriv usersandbox # Disable branding (from desktop) USE=-branding signature.asc Description: OpenPGP digital signature
[gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
What do you think about doing the following change in /usr/portage/profiles/targets/developer/make.defaults: replace test with test-fail-continue to make it just less frustrating (we still have a lot of test failures) Hopefully that will also make more of us use the developer profile, and detect test failures. What do you think? Paweł signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
Hi, On Fri, Jun 4, 2010 at 10:41 AM, Paweł Hajdan, Jr. phajdan...@gentoo.org wrote: What do you think about doing the following change in /usr/portage/profiles/targets/developer/make.defaults: replace test with test-fail-continue to make it just less frustrating (we still have a lot of test failures) I've been thinking about this for a while. Some packages have tests that are meant only for upstream in certain conditions and are not meant to be ran during installing. As we have ARCH teams, couldn't we think a way in which TEST teams can be created? I mean, a bunch of devs only focused on making tests work or just restrict them? This team (or a Gentoo project) can work hand by hand with other teams and ARCH members. Is it even possible? Hopefully that will also make more of us use the developer profile, and detect test failures. What do you think? Paweł Best regards, -- Jesus Rivero (Neurogeek)
Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
On 6/4/10 5:35 PM, Jesus Rivero (Neurogeek) wrote: I've been thinking about this for a while. Some packages have tests that are meant only for upstream in certain conditions and are not meant to be ran during installing. I think that in extreme cases src_test should not call such tests. As we have ARCH teams, couldn't we think a way in which TEST teams can be created? I mean, a bunch of devs only focused on making tests work or just restrict them? I don't think that would be effective. Making the tests work is hard, especially for packages like gcc, or python. Having FEATURES=test is intended to make developers catch these failures before checking in. However, with many packages failing tests, people started running FEATURES=-test or just stopped (or never used) the developer profile. With FEATURES=test test-fail-continue we should get best of both worlds: run tests always, but don't frustrate people by making build fail in the middle of long emerge. Paweł signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
On Fri, 04 Jun 2010 17:11:45 +0200 Paweł Hajdan, Jr. phajdan...@gentoo.org wrote: What do you think about doing the following change in /usr/portage/profiles/targets/developer/make.defaults: [..] What do you think? I've never felt any need or obligation to use a developer profile. I don't think I ever saw any announcement to that effect either. What is the use of a developer profile?[1] Someone in the know, please sell it to me. :) Regards, jer [1] I've seen developers complain more and more about failing test suites. Maybe that's a related issue? Developers now use the FEATURES set out in a developer profile and can then extract some kind of validity claim from the fact that I obviously didn't do my QA? That would explain a lot.
Re: [gentoo-dev] RFC: changing the developer profile: FEATURES=test - FEATURES=test-fail-continue
On Fri, 4 Jun 2010 18:48:38 +0200 Jeroen Roovers j...@gentoo.org wrote: [1] I've seen developers complain more and more about failing test suites. Maybe that's a related issue? Developers now use the FEATURES set out in a developer profile and can then extract some kind of validity claim from the fact that I obviously didn't do my QA? That would explain a lot. That came out wrong. s|from the fact|to the effect|
