Re: [gentoo-portage-dev] [PATCH] Support PROPERTIES="live".

2019-07-28 Thread Michał Górny
On Sun, 2019-07-28 at 17:21 -0700, Zac Medico wrote:
> On 7/26/19 3:45 PM, Michał Górny wrote:
> > While at it, could you look into making src_unpack() network-sandbox
> > override apply only to ebuilds with PROPERTIES=live?
> 
> There could be another subset of packages that aren't quite "live" but
> they need to fetch something that's immutable which can't be fetched via
> a protocol supported by SRC_URI. Maybe call it
> PROPERTIES="src-fetch-immutable" or something.

Could you name one of those packages, and explain how are they not
'live' if they skip checksum verification?  I'm really against adding
hundreds of weird-named items for the sake of potential use cases
without a real benefit to it.

-- 
Best regards,
Michał Górny



signature.asc
Description: This is a digitally signed message part


Re: [gentoo-portage-dev] [PATCH] Support PROPERTIES="live".

2019-07-28 Thread Zac Medico
On 7/26/19 3:45 PM, Michał Górny wrote:
> While at it, could you look into making src_unpack() network-sandbox
> override apply only to ebuilds with PROPERTIES=live?

There could be another subset of packages that aren't quite "live" but
they need to fetch something that's immutable which can't be fetched via
a protocol supported by SRC_URI. Maybe call it
PROPERTIES="src-fetch-immutable" or something.
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature


Re: [gentoo-portage-dev] [PATCH 2/2] man/ebuild.5: Document PROPERTIES="live".

2019-07-28 Thread Zac Medico
On 7/27/19 7:38 AM, Ulrich Müller wrote:
> Signed-off-by: Ulrich Müller 
> ---
>  man/ebuild.5 | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/man/ebuild.5 b/man/ebuild.5
> index 31bd8f771..b002f3889 100644
> --- a/man/ebuild.5
> +++ b/man/ebuild.5
> @@ -1,4 +1,4 @@
> -.TH "EBUILD" "5" "Apr 2019" "Portage VERSION" "Portage"
> +.TH "EBUILD" "5" "Jul 2019" "Portage VERSION" "Portage"
>  
>  .SH "NAME"
>  ebuild \- the internal format, variables, and functions in an ebuild script
> @@ -708,13 +708,17 @@ Disables userpriv for specific packages.
>  .RE
>  .PD 1
>  .TP
> -.B PROPERTIES\fR = \fI[interactive]
> +.B PROPERTIES\fR = \fI[interactive,live]
>  A space delimited list of properties, with conditional syntax support.
>  .PD 0
>  .RS
>  .TP
>  .I interactive
>  One or more ebuild phases will produce a prompt that requires user 
> interaction.
> +.TP
> +.I live
> +The package uses live source code that may vary each time that the package
> +is installed.
>  .RE
>  .PD 1
>  .TP
> 

This series looks good. Please merge.
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature


Re: [gentoo-portage-dev] [RFC] Adding extra vars to md5-cache, for QA purposes

2019-07-28 Thread Zac Medico
On 7/25/19 11:49 PM, Fabian Groffen wrote:
> Hi,
> 
> On 25-07-2019 14:20:50 +0200, Michał Górny wrote:
>> Hi,
>>
>> TL;DR: I'd like to make it possible for ebuilds to define additional
>> variables that will be stored in md5-cache.  This would be useful for CI
>> and other tooling that right now has to parse ebuilds for other data.
> 
> Only downside I can think of, is a diskspace increase for the md5-cache.
> Not sure if this is going to be substantial, but given things like
> PYTHON_COMPAT, perhaps a quick calculation of extra "cost" can be made.
> Should diskspace become a problem, one could consider to use a separate
> file/dir, that users could rsync-exclude, since Portage won't need it to
> operate properly.

Yes, using a separate directory from md5-cache will provide useful
isolation. There's a lot of potential for bloat here, and by keeping it
separate we can easily render the bloat harmless.

> Thanks,
> Fabian-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature