Re: [gentoo-portage-dev] [PATCH v2] Default MAKEOPTS to -j(ncpus+1) when unset

2015-01-28 Thread Rick Zero_Chaos Farina 
On 01/18/2015 11:58 AM, Brian Dolbec wrote:
 On Sun, 18 Jan 2015 11:38:38 +0100
 Michał Górny mgo...@gentoo.org wrote:
 
 Default MAKEOPTS job number to (number of CPUs + 1) when it is not
 provided in the ebuild environment.

 Suggested-By: Daniel Robbins drobb...@funtoo.org
 ---
  pym/portage/package/ebuild/doebuild.py |  8 +++-
  pym/portage/util/cpuinfo.py| 18 ++
  2 files changed, 25 insertions(+), 1 deletion(-)
  create mode 100644 pym/portage/util/cpuinfo.py

 
 
 looks good, merge please
 
I realize I'm a little bit late here, but after extensive testing with
multiple different schedulers that NUMCPU provides equivalent
performance, or even outperforms NUMCPU+1.  I think that changes from 1
cpu to NUMCPU is good enough, and we don't need to test thrashing the
scheduler.

Thanks,
Zero



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH v2] Default MAKEOPTS to -j(ncpus+1) when unset

2015-01-18 Thread Brian Dolbec 
On Sun, 18 Jan 2015 11:38:38 +0100
Michał Górny mgo...@gentoo.org wrote:

 Default MAKEOPTS job number to (number of CPUs + 1) when it is not
 provided in the ebuild environment.
 
 Suggested-By: Daniel Robbins drobb...@funtoo.org
 ---
  pym/portage/package/ebuild/doebuild.py |  8 +++-
  pym/portage/util/cpuinfo.py| 18 ++
  2 files changed, 25 insertions(+), 1 deletion(-)
  create mode 100644 pym/portage/util/cpuinfo.py



looks good, merge please

-- 
Brian Dolbec dolsen