Re: [Geotools-devel] Stepping down from GeoTools PMC
Thanks, Jody. I have learned so much. The honour is mine. Kind regards, Ben. On 23/10/2018 11:51, Jody Garnett wrote: That is .. great news - glad you have an exciting prospect! It has been an honour to work with you these many years :) -- Jody Garnett On Mon, 22 Oct 2018 at 14:26, Ben Caradoc-Davies wrote: I hereby step down from the GeoTools PMC. Thanks everyone. I have had a great time. I have some exciting new projects that need my focus. I will update the docs. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Stepping down from GeoTools PMC
I hereby step down from the GeoTools PMC. Thanks everyone. I have had a great time. I have some exciting new projects that need my focus. I will update the docs. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=10=16=19=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 15:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 15:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=10=2=15=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules
On 27/09/2018 10:01, Jody Garnett wrote:
Hey Ben - are you available for the code sprint? Completely understand if
you are not being a small business, but we would really love your help.
Sorry, I am not likely to be available.
Additional comments/confusion inline:
On Wed, 26 Sep 2018 at 14:50, Ben Caradoc-Davies wrote:
Does Jigsaw prevent classpath trickery like gt-xsd-gml3
org.geotools.referencing.crs.EPSGCRSAuthorityFactory? This is required
to make tests pass in Eclipse.
What CLASSPATH trickery is that? Reading the java docs:
* * A disabled version of {@link EPSGCRSAuthorityFactory} that exists
solely as a workaround for*
* * Eclipse capture of transitive dependencies. The real implementation in
gt-epsg-wkt; Maven does*
* * the right thing and does not include the provider at test time, but
Eclipse captures it as a*
* * transitive dependency, causing the wrong provider to be used for
srsName encoding. The presence*
* * of this class allows gt-xsd-gml3 unit tests to pass in Eclipse.*
Since you are the author you may need to explain the trick?
Eclipse puts project classes before dependency classes on the classpath.
This class allows us to replace an unwanted class in a transitive
dependency (Eclipse includes more dependencies than Maven) that
otherwise causes tests to fail (axis order, IIRC?). Jigsaw exists to
prevent this.
By the way, how does Jigsaw work with optional dependencies? Can we
still leave out unused dependencies like with the current classpath? Or
will Java 11 spit the dummy?
Are modules like gt-app-schema that define classes in several packages
also defined in other modules affected by this change?
Yes, they will need to be untangled.
I guess that it might be because only one module can publish a package, but
this depends
on whether any other module consumes these classes.
Normally it would - ie if we were going all in on Java 11 and using
module-info.java to carefully control what we are publishing.
We are not .. as an "automatic module" all the public packages are
published.
We will need to understand the impact on downstream, especially
GeoServer. Especially gs-app-schema-test. Especially especially tests
that depend on GeoTools tests. I am still trying to understand the
implications.
Thanks for the excellent proposal, by the way. This is the most
comprehensible explanation of Jigsaw that I have seen.
No worries, there are a couple features that make it not as scary as I
first feared. And indeed some (like "automatic modules" acting as a bridge
to the classpath) that can be used to make our transition gradual and not
stuck on waiting for everything ever to be turned into modules.
I added Nuno and Torben to the proposal.
Red Hat are supporting OpenJDK 8 until 2023. OpenJDK 8 forever!
Kind regards,
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules
Does Jigsaw prevent classpath trickery like gt-xsd-gml3 org.geotools.referencing.crs.EPSGCRSAuthorityFactory? This is required to make tests pass in Eclipse. Are modules like gt-app-schema that define classes in several packages also defined in other modules affected by this change? I guess that it might be because only one module can publish a package, but this depends on whether any other module consumes these classes. Thanks for the excellent proposal, by the way. This is the most comprehensible explanation of Jigsaw that I have seen. Kind regards, Ben. On 18/09/2018 11:16, Jody Garnett wrote: Proposal is here: Restructure GeoTools into Jigsaw modules <https://github.com/geotools/geotools/wiki/Restructure-GeoTools-into-Jigsaw-modules> Feedback welcome, I expect we will have some discussion before voting. -- Jody Garnett ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=9=18=19=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Proposing Nuno Oliveira and Torben Barballe for PMC
+1 for Nuno and +1 for Torben. Both have made substantial contributions to the community beyond their technical work, especially mailing list user support from Nuno, and CI infrastructure, pull request reviews, and (non-voting) committee work from Torben. They would be most welcome on the PMC. Kind regards, Ben. On 11/09/2018 23:04, Andrea Aime wrote: Hi al, as you know the current PMC is rather... slim! Time to bring new participants in. I'd like to propose both Nuno and Torben as new members. The choice is imho rather obvious, they both have contributed to a number of modules, know the procedures and how to deal with the community, and speak up during public discussions, a good sign of personal interest in the project. Nuno and Torben, could you please let us know if you are interested? (I've heard a positive from both, but it was some time ago, please confirm). PMC members, would you please cast a vote? As a reminder, the current PMC members are: - Andrea Aime - Ben Caradoc-Davies - Ian Turton - Jody Garnett - Simone Giannecchini We need 75% +1 in order to have this motion pass, I'll start with my vote: +1 for Nuno +1 for Torben Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.* ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 15:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 15:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=9=4=15=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=8=21=19=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 15:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 15:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=8=7=15=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API/ABI change to move XMLTestSupport to test jar.
Merged on master. Kind regards, Ben. On 24/07/18 17:30, Andrea Aime wrote: +1 here, thanks! Cheers Andrea Il mar 24 lug 2018, 03:55 ha scritto: https://github.com/geotools/geotools/pull/1986 is a proposal to remove xmlunit (and junit) as dependencies we ship in geotools. The reason why we were providing that is partly because some of the dependency definitions were not test scoped, and partly because we actually do depend on it, for one class – org.geotools.xml.test.XMLTestSupport ( http://docs.geotools.org/latest/javadocs/org/geotools/xml/test/XMLTestSupport.html ) I propose (see PR) to remove XMLTestSupport from the GeoTools XML API and provide it only as a test-jar. That has impact on at least GeoServer, and Ben Caradoc Davies has developed a corresponding PR. That is an API/ABI break, and backport is not intended. Given the nature of the changes in 20.0, I don’t think this is a particularly onerous change if anyone else is using that class. I request approval for this change. Brad -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
Thanks, Torben. Kind regards, Ben. On 25/07/18 08:14, Torben Barsballe wrote: Ben - we covered this in todays meeting; synopsis in the notes is: *2.14.0 release currently scheduled for September (RC in August)Last two fall releases have been delayed; looking at the release schedule <https://github.com/geoserver/geoserver/wiki/Release-Schedule#2015>, GT 14.0 / GS 2.8.0 was released 2015-09-23 (September). The next fall release, 2.10.0, was delayed until October, 2.12.x followed the same pattern, so the 2.14.0 release is us finally getting back on track.* Cheers, Torben On Mon, Jul 23, 2018 at 4:20 PM, Jody Garnett wrote: I think we got out of sync (java 8 upgrade) and are gradually trying to bring the release schedule back for September release -- Jody Garnett On Mon, 23 Jul 2018 at 15:31, Ben Caradoc-Davies wrote: My only question was the 20.0/2.14.0 release timeline. It seems a month earlier this year. We should discuss. On 24/07/18 10:10, Jody Garnett wrote: I have a meeting conflict and cannot attend. -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Geoserver-devel mailing list geoserver-de...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API/ABI change to move XMLTestSupport to test jar.
Thanks, Brad. I think this is a good change, so +1 from me. Here is the corresponding GeoServer change: https://github.com/geoserver/geoserver/pull/3019 There are two types of downstream breakages. The first are downstream tests that use XMLTestSupport and so need to depend on the new gt-xsd-core tests artifact: org.geotools.xsd gt-xsd-core tests test The second are downstream tests that were using xmlunit as a transitive dependency via gt-xsd-core but not XMLTestSupport. As Brad has noted and fixed in his PR, the main gt-xsd-core artifact should not depend on xmlunit. These downstream tests that use xmlunit but not XMLTestSupport need only declare a test dependency on xmlunit: xmlunit xmlunit test Please let us know if you find any other affected downstream projects. Does anyone object to this API change? Kind regards, Ben. On 24/07/18 13:53, br...@frogmouth.net wrote: https://github.com/geotools/geotools/pull/1986 is a proposal to remove xmlunit (and junit) as dependencies we ship in geotools. The reason why we were providing that is partly because some of the dependency definitions were not test scoped, and partly because we actually do depend on it, for one class - org.geotools.xml.test.XMLTestSupport (http://docs.geotools.org/latest/javadocs/org/geotools/xml/test/XMLTestSuppo rt.html) I propose (see PR) to remove XMLTestSupport from the GeoTools XML API and provide it only as a test-jar. That has impact on at least GeoServer, and Ben Caradoc Davies has developed a corresponding PR. That is an API/ABI break, and backport is not intended. Given the nature of the changes in 20.0, I don't think this is a particularly onerous change if anyone else is using that class. I request approval for this change. Brad -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
My only question was the 20.0/2.14.0 release timeline. It seems a month earlier this year. We should discuss. On 24/07/18 10:10, Jody Garnett wrote: I have a meeting conflict and cannot attend. -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
I am still investigating this change. I think I have found a use-case where deprecation of dispose() and third-party migration to close() might introduce a resource leak. I will report back when I have finished my investigation. Kind regards, Ben. On 07/06/18 14:29, Ben Caradoc-Davies wrote: Jody, the problem is that doing it this way will break any third-party code that already implements an interface with dispose(). Their implementation will override dispose() and fail to implement close(). What we could do is provide default implementations for *both* close() and @Deprecated dispose() that call each other. All implementations with dispose() will work fine, and will work just the same when dispose() is renamed to close(). I think we need a deprecation cycle: Stage one (GeoTools 20): introduce @Deprecated interface Disposable (extends AutoCloseable) with @Deprecated default dispose() that calls close() and default close() that calls dispose(). All implementations have dispose() marked @Deprecated. All implementations can now have their dispose() renamed to close() as convenient, with @Deprecated removed. The default dispose() will provide backwards compatibility. Stage two (GeoTools 21): remove Disposable entirely, replacing it with AutoClosable. Any remaining dispose() methods renamed to close(). Third-party code that ignored the deprecation warnings is now broken. Is one release cycle enough deprecation before removal? Kind regards, Ben. On 07/06/18 10:41, Jody Garnett wrote: You could swap this around, rename the dispose implementations to close, and provide a deprecated default implementation of dispose that calls close. This way you can manage eventually remove dispose() from the API. -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=7=24=19=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Cleaning up some community modules
+1. Thanks, Andrea. Kind regards, Ben. On 09/07/18 21:59, Andrea Aime wrote: Hi, I was looking at a Ian's pull request about supporting EPSG:404000 in image mosaics and it occurred to me that it makes the "imagecollection" module basically useless. The module has been out of the build for a long while in any case, so I guess time to remove it for good. Are there other modules that we want to remove? Thinking out loud: - SFS store (Simple Feature Service). Never really took off, is there anyone still using it? (there is a counterpart in GeoServer offering a server side, should probably also go) - efeature (author left, don't think it is used by anybody?) - caching (was about caching vector features, old, never took off) - feature-aggregate - geotiff_new (was meant as an experiment to rewrite the geotiff module, we can recover it from history if needs be) Anything else we might want to remove from checkouts/builds? Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.* -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 15:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 15:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=7=10=15=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] JTS 1.15.1 upgrade started
Merged on master. Thanks, Jody. I tested this locally and can confirm that the exclusion is effective. Kind regards, Ben. On 06/07/18 08:36, Jody Garnett wrote: Here is a PR fix https://github.com/geotools/geotools/pull/1961 Adds the transitive dependency (it was excluding "jts" and should of been excluding "its-core") -- Jody Garnett On Thu, 5 Jul 2018 at 13:31, Jody Garnett wrote: Thanks Ben, I have fixed it here https://repo.boundlessgeo.com/main/net/sourceforge/hatbox/hatbox/1.0.b10/ I cannot currently reach http://download.osgeo.org/webdav/geotools -- Jody Garnett On Wed, 4 Jul 2018 at 15:55, Ben Caradoc-Davies wrote: Jody, I noticed an incorrect jts-core version while assembling GeoServer artifacts: [WARNING] The POM for org.locationtech.jts:jts-core:jar:1.15.1-SNAPSHOT is missing, no dependency information available The cause is hatbox-1.0.b10.pom, which contains an incorrect dependency on jts-core 1.15.1-SNAPSHOT (should be 1.15.1): org.locationtech.jts jts-core 1.15.1-SNAPSHOT jar Kind regards, Ben. On 29/06/18 19:55, Jody Garnett wrote: The Upgrade to JTS 1.15 is in progress <https://github.com/geotools/geotools/wiki/Upgrade-to-JTS-1.15>, with several releases in the chain already made: * JTS 1.15.1 released and syncing to maven central * java-vector-tile 1.3.1 released to repo.boundlessgeo.com * hatbox 1.0-b10 released to repo.boundlessgeo.com * geodb 0.9 released to repo.boundlessgeo.com * jaitools 1.5.0 is tagged, we have permission to release to maven central The next numbered release is jai-ext, if we can ask the jai-ext team merge #196 <https://github.com/geosolutions-it/jai-ext/pull/196> and make a 1.0.24 release. With this in place we can cut over the the final geotools, geowebcache, geoserver at the same time, preferably this weekend. -- Jody Garnett -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Can't build GeoTools??
On 05/07/18 09:13, Ben Caradoc-Davies wrote: On 04/07/18 18:18, Andrea Aime wrote: On Wed, Jul 4, 2018 at 2:37 AM, Ben Caradoc-Davies wrote: I suspect that we might have a race condition. gt-cql uses the jjtree-javacc plugin but does not declare a dependency on it, so a multithreaded build can race between a local build of jjtree-javacc and a remote snapshot download from repo.boundlessgeo.com. You mean, a straight, normal dependency, to force a proper build order? What scope would you suggest to avoid transitiveness... test? Would "provided" work? The gt-cql module already has a "provided" dependency on gt-epsg-hsql. The "provided" scope is not transitive: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope I am not convinced that adding a dependency changes anything. I cannot reproduce any race with or without it. For me on master, jjtree-javacc is built much earlier than gt-cql, even for multithreaded builds. Even using -pl to build just these two modules, with a manually cleaned local repo, and -T2 to make the build multithreaded, results in jjtree-javacc being built and installed before the gt-cql build starts, and no downloads. It looks like Maven is already recognising the plugin dependency, although there is no mention of it in the -X debug output. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] JTS 1.15.1 upgrade started
Jody, I noticed an incorrect jts-core version while assembling GeoServer artifacts: [WARNING] The POM for org.locationtech.jts:jts-core:jar:1.15.1-SNAPSHOT is missing, no dependency information available The cause is hatbox-1.0.b10.pom, which contains an incorrect dependency on jts-core 1.15.1-SNAPSHOT (should be 1.15.1): org.locationtech.jts jts-core 1.15.1-SNAPSHOT jar Kind regards, Ben. On 29/06/18 19:55, Jody Garnett wrote: The Upgrade to JTS 1.15 is in progress <https://github.com/geotools/geotools/wiki/Upgrade-to-JTS-1.15>, with several releases in the chain already made: * JTS 1.15.1 released and syncing to maven central * java-vector-tile 1.3.1 released to repo.boundlessgeo.com * hatbox 1.0-b10 released to repo.boundlessgeo.com * geodb 0.9 released to repo.boundlessgeo.com * jaitools 1.5.0 is tagged, we have permission to release to maven central The next numbered release is jai-ext, if we can ask the jai-ext team merge #196 <https://github.com/geosolutions-it/jai-ext/pull/196> and make a 1.0.24 release. With this in place we can cut over the the final geotools, geowebcache, geoserver at the same time, preferably this weekend. -- Jody Garnett -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Can't build GeoTools??
On 04/07/18 18:18, Andrea Aime wrote: On Wed, Jul 4, 2018 at 2:37 AM, Ben Caradoc-Davies wrote: I suspect that we might have a race condition. gt-cql uses the jjtree-javacc plugin but does not declare a dependency on it, so a multithreaded build can race between a local build of jjtree-javacc and a remote snapshot download from repo.boundlessgeo.com. You mean, a straight, normal dependency, to force a proper build order? What scope would you suggest to avoid transitiveness... test? Would "provided" work? The gt-cql module already has a "provided" dependency on gt-epsg-hsql. The "provided" scope is not transitive: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Can't build GeoTools??
es from Ernst & Young LLP (except for EY Client Portal and the ey.com<http://ey.com> website, which track e-mail preferences through a separate process) at this e-mail address by forwarding this message to no-more-m...@ey.com<mailto:no-more-m...@ey.com>. If you do so, the sender of this message will be notified promptly. Our principal postal address is 5 Times Square, New York, NY 10036. Thank you. Ernst & Young LLP -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net<mailto:GeoTools-Devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. Any tax advice in this e-mail should be considered in the context of the tax services we are providing to you. Preliminary tax advice should not be relied upon and may be insufficient for penalty protection. The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Notice required by law: This e-mail may constitute an advertisement or solicitation under U.S. law, if its primary purpose is to advertise or promote a commercial product or service. You may choose not to receive advertising and promotional messages from Ernst & Young LLP (except for EY Client Portal and the ey.com website, which track e-mail preferences through a separate process) at this e-mail address by forwarding this message to no-more-m...@ey.com. If you do so, the sender of this message will be notified promptly. Our principal postal address is 5 Times Square, New York, NY 10036. Thank you. Ernst & Young LLP -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] App-Schema backports
No objection from me. The first is a clean extension that should not break existing functionality, the second addresses a functional deficiency, and the third should not affect existing deployments. These changes have been on master for a month and have not caused any problems with GeoServer app-schema online tests on Jenkins or locally. Kind On 03/07/18 10:32, Nuno Oliveira wrote: Hi all, I would like to backport some new features \ bug fixing related with App-Schema (and the corresponding integration tests) to GeoTools 19.x and 18.x: * [https://osgeo-org.atlassian.net/browse/GEOT-6058] Extend App-Schema to make it possible to use an HTTP URL for the mapping file location * [https://osgeo-org.atlassian.net/browse/GEOT-6014] Make App-Schema delegate spatial filters on nested properties to the relational database * [https://osgeo-org.atlassian.net/browse/GEOT-5964] Allow the selection of a default geometry attribute in App-Schema All of them respect the one month cool down rule, and at the exception of the first issue, they are in /a gray zone/ between a new feature \ bug fixing. Objections ? Regards, Nuno Oliveira -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Can't build GeoTools??
Dave, what are your Maven and JDK versions? Kind regards, Ben. On 03/07/18 01:58, Dave Wichers wrote: I've tried building the master, 18.x, and 19.x branches and I always get an error in this project: [INFO] OGC CQL to Filter parser ... FAILURE [ 0.001 s] Like so: [ERROR] Failed to parse plugin descriptor for org.geotools.maven:jjtree-javacc:19-SNAPSHOT (/home/drwiche/git/geotools/build/maven/jjtree-javacc/target/classes): No plugin descriptor found at META-INF/maven/plugin.xml -> [Help 1] Am I trying to build it wrong? I'm simply using: mvn clean install (as it suggests). Thanks, Dave Any tax advice in this e-mail should be considered in the context of the tax services we are providing to you. Preliminary tax advice should not be relied upon and may be insufficient for penalty protection. The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Notice required by law: This e-mail may constitute an advertisement or solicitation under U.S. law, if its primary purpose is to advertise or promote a commercial product or service. You may choose not to receive advertising and promotional messages from Ernst & Young LLP (except for EY Client Portal and the ey.com website, which track e-mail preferences through a separate process) at this e-mail address by forwarding this message to no-more-m...@ey.com. If you do so, the sender of this message will be notified promptly. Our principal postal address is 5 Times Square, New York, NY 10036. Thank you. Ernst & Young LLP -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Backport of HSQLDB upgrade to 2.4.1
Brad, before the upgrade, test builds of gs-main on Linux with maxcpus=2 hung on CoverageViewTest in 2/100 tests. CPU was still burning so it looked like a livelock. I did not think to dump stack with jstack. I did not see these hangs after the upgrade. It is possible that this upgrade will fix the livelock(?) in GEOS-8491. I also have another EPSG concurrency fix, but I thought that it would only affect tests, where multiple ThreadedHsqlEpsgFactory are instantiated, not production where there should be a single instance: [GEOT-6056] EPSG lookup failures caused by concurrent database shutdown in FactoryUsingHSQL finalizer https://osgeo-org.atlassian.net/browse/GEOT-6056 https://github.com/geotools/geotools/pull/1953 It would be interesting to repeat the GEOS-8491 tests with both GEOT-6050 and GEOT-6056 fixes applied. Kind regards, Ben. On 30/06/18 16:25, br...@frogmouth.net wrote: It is possible that https://osgeo-org.atlassian.net/browse/GEOS-8491 is the same issue Brad -Original Message- From: Ben Caradoc-Davies Sent: Saturday, 30 June 2018 12:16 PM To: GeoTools Devel Subject: [Geotools-devel] Backport of HSQLDB upgrade to 2.4.1 I will be backporting the upgrade of HSQLDB to 2.4.1 <https://osgeo-org.atlassian.net/browse/GEOT-6050> to 19.x and 18.x because it is in effect a bug fix because it fixes concurrency problems that cause: [GEOS-8802] CoverageViewTest intermittent failures https://osgeo-org.atlassian.net/browse/GEOS-8802 To provide backwards and forwards compatibility (likely unneeded but we are being super-careful), the upgrade changes the path to the EPSG database file. This is unlikely to cause problems but I thought I should mention in just in case. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Backport of HSQLDB upgrade to 2.4.1
I will be backporting the upgrade of HSQLDB to 2.4.1 <https://osgeo-org.atlassian.net/browse/GEOT-6050> to 19.x and 18.x because it is in effect a bug fix because it fixes concurrency problems that cause: [GEOS-8802] CoverageViewTest intermittent failures https://osgeo-org.atlassian.net/browse/GEOS-8802 To provide backwards and forwards compatibility (likely unneeded but we are being super-careful), the upgrade changes the path to the EPSG database file. This is unlikely to cause problems but I thought I should mention in just in case. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Line endings checks on Jenkins and Travis CI
In yesterday's meeting we noticed a pull request that tried to convert many line endings from LF to CRLF. This was not detected by fmt-maven-plugin. There is a fmt-maven-plugin feature request: https://github.com/coveo/fmt-maven-plugin/issues/32 We could add a separate check. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Call for vote on JTS 15.0 upgrade proposal
+1. Thanks, Jody and Jim. This is much needed. Will choosing the BSD licence make downstream EPL exemptions unnecessary? (e.g. for projects licensed under GPL?) Kind regards, Ben. On 27/06/18 10:26, Jody Garnett wrote: Thanks for today's discussion, I would like to call for a vote on the following proposal: https://github.com/geotools/geotools/wiki/Upgrade-to-JTS-1.15 Thanks -- Jody Garnett -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] GeoTools / GeoServer Meeting 2018-06-26
Failure was bogus so I am merging these now. On 27/06/18 08:39, Ben Caradoc-Davies wrote: Didn't merge anything, as master is currently failing. The following PRs can be merged when master is stable again: * https://github.com/geotools/geotools/pull/1942 * https://github.com/geotools/geotools/pull/1872 * https://github.com/geotools/geotools/pull/1945 * https://github.com/geotools/geotools/pull/1946 * https://github.com/geotools/geotools/pull/1947 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Build failed in Jenkins: geotools-master #2585
Service outage. Test server is back. This should be an OnlineTest. 2018-06-26T15:22:39.057+ SEVERE Failed to execute request https://sampleserver6.arcgisonline.com/arcgis/rest/services/Toronto/ImageServer/WMTS/1.0.0/WMTSCapabilities.xml?REQUEST=GetCapabilities=1.0.0=WMTS Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 32.37 sec <<< FAILURE! - in org.geotools.data.wmts.client.WMTSServiceTest testDefaultStyleRequired(org.geotools.data.wmts.client.WMTSServiceTest) Time elapsed: 30.487 sec <<< ERROR! java.net.SocketTimeoutException: Read timed out [...] at org.geotools.data.wmts.WebMapTileServer.(WebMapTileServer.java:95) at org.geotools.data.wmts.client.WMTSServiceTest.testDefaultStyleRequired(WMTSServiceTest.java:198) On 27/06/18 03:22, moni...@boundlessgeo.com wrote: See <https://build.geoserver.org/job/geotools-master/2585/display/redirect?page=changes> Changes: [Andrea Aime] Fix formatting -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Stepping aside from PMC
Indeed. And most especially your work on our XML infrastructure is much appreciated. Justin, you are always welcome here. Kind regards, Ben. On 27/06/18 08:47, Jody Garnett wrote: Thanks Justin, we appreciate all that you have done! -- Jody Garnett On Mon, 18 Jun 2018 at 10:57, Justin Deoliveira wrote: Hi folks, Some of you are probably shocked that I am still actually still on the PMC given my level of involvement over the past few years but technically I am. I figure there are other developers who are far more active with GeoTools than myself who would make great PMC members so I am happy to step aside and let someone else take the spot if interested. I’ll leave it in the capable hands of the currently active PMC to figure out who that is. Thanks and awesome work to the core team who keep GeoTools going! -Justin -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=6=26=19=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Build failed in Jenkins: geotools-master #2581
Temporary outage of www.w3.org, or DNS? I have kicked the build. Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.232 sec <<< FAILURE! - in org.geotools.xml.SchemaFactoryResolveTest testRemotePathResolve(org.geotools.xml.SchemaFactoryResolveTest) Time elapsed: 0.207 sec <<< ERROR! java.lang.RuntimeException: Failed to resolve http://www.w3.org/2001/03/xml.xsd at org.geotools.xml.resolver.SchemaResolver.resolve(SchemaResolver.java:189) at org.geotools.xml.SchemaFactory.resolveSchema(SchemaFactory.java:344) at org.geotools.xml.SchemaFactory.getRealInstance(SchemaFactory.java:297) at org.geotools.xml.SchemaFactory.getInstance(SchemaFactory.java:284) at org.geotools.xml.SchemaFactory.getInstance(SchemaFactory.java:209) at org.geotools.xml.SchemaFactoryResolveTest.testRemotePathResolve(SchemaFactoryResolveTest.java:85) On 24/06/18 13:55, moni...@boundlessgeo.com wrote: See <https://build.geoserver.org/job/geotools-master/2581/display/redirect?page=changes> Changes: [Ben Caradoc-Davies] Add fmt.skip property -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] You have been... ref0rmatt3d!
Andrea, I have added a fmt.skip property on all active branches of GeoTools and GeoServer. This allows -Dfmt.skip to skip formatting. This is useful in loops of many short Maven runs of a single test (e.g. hunting intermittent failures), when formatting can otherwise take most of the time. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Proposal: Allow usage of expressions in SelectChannelName
+1. That looks quite useful. Kind regards, Ben. On 07/06/18 02:38, Andrea Aime wrote: We already discussed in on the mailing list a bit, here is the format proposal: https://github.com/geotools/geotools/wiki/Allow-usage-of-expressions-in-SelectChannelName Votes welcomed (and discussion too, in case you missed it previously) :-) Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.* -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 15:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 15:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=6=12=15=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Build failed in Jenkins: geotools-master #2562
.. SUCCESS [ 0.032 s] [INFO] Process SKIPPED [INFO] Swing widgets .. SKIPPED [INFO] Tile Client SKIPPED [INFO] WMTS XML Support ... SKIPPED [INFO] Web Map Tile Service Client SKIPPED [INFO] KML XML Support SKIPPED [INFO] WCS XML Support SKIPPED [INFO] WPS XML Support SKIPPED [INFO] WMS XML Support SKIPPED [INFO] CSW XML Support SKIPPED [INFO] Process Feature SKIPPED [INFO] Process Raster . SKIPPED [INFO] YSLD Parser/Encoder SKIPPED [INFO] SWT widgets SKIPPED [INFO] GeoJSON Support SKIPPED [INFO] Process Geometry ... SKIPPED [INFO] MBTiles Module . SKIPPED [INFO] WFS client module (NG) . SKIPPED [INFO] ISO 19107 implementation using JTS . SKIPPED [INFO] Geometries . SKIPPED [INFO] Web Processing Service . SKIPPED [INFO] Application Schema Support (Unsupported Modules) ... SUCCESS [ 0.015 s] [INFO] SOLR module SKIPPED [INFO] Geobuf DataStore ... SKIPPED [INFO] Cartographic CSS parser SKIPPED [INFO] GeoJSON Datastore .. SKIPPED [INFO] Mapbox Styles Support .. SKIPPED [INFO] CSVDataStore ... SKIPPED [INFO] EPSG Authority Factory for Oracle .. SUCCESS [ 1.294 s] [INFO] Next Generation JDBC DataStores SKIPPED [INFO] Simple Feature Service store ... SKIPPED [INFO] Aggregating DataStore .. SKIPPED [INFO] gt-s3-geotiff .. SKIPPED [INFO] GeoTools Documentation . SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 02:05 min (Wall Clock) [INFO] Finished at: 2018-06-09T12:52:29+00:00 [INFO] Final Memory: 143M/1618M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.15:test (default-test) on project gt-main: There are test failures. [ERROR] [ERROR] Please refer to <https://build.geoserver.org/j ob/geotools-master/ws/modules/library/main/target/surefire-reports> for the individual test results. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/conflu ence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :gt-main Build step 'Invoke top-level Maven targets' marked build as failure -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
And I hope Josh Bloch also hates checked exceptions, which are the only reason AutoCloseable was required and Closeable could not be used for try-with-resources (because the exception specification was too narrow). On 07/06/18 14:48, Ben Caradoc-Davies wrote: I hate checked exceptions so much. -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
The one thing I am still thinking about is the impact of checked exceptions. Our interfaces that include dispose() without throws should probably end up with close() without throws after stage two and keep dispose() without throws during stage one to maintain backwards compatibility (so client code using the interface does not get a compile failure with an unhandled exception during the transition). We might need two interfaces because we have dispose() without throws and dispose() with throws. I hate checked exceptions so much. On 07/06/18 14:29, Ben Caradoc-Davies wrote: Jody, the problem is that doing it this way will break any third-party code that already implements an interface with dispose(). Their implementation will override dispose() and fail to implement close(). What we could do is provide default implementations for *both* close() and @Deprecated dispose() that call each other. All implementations with dispose() will work fine, and will work just the same when dispose() is renamed to close(). I think we need a deprecation cycle: Stage one (GeoTools 20): introduce @Deprecated interface Disposable (extends AutoCloseable) with @Deprecated default dispose() that calls close() and default close() that calls dispose(). All implementations have dispose() marked @Deprecated. All implementations can now have their dispose() renamed to close() as convenient, with @Deprecated removed. The default dispose() will provide backwards compatibility. Stage two (GeoTools 21): remove Disposable entirely, replacing it with AutoClosable. Any remaining dispose() methods renamed to close(). Third-party code that ignored the deprecation warnings is now broken. Is one release cycle enough deprecation before removal? Kind regards, Ben. On 07/06/18 10:41, Jody Garnett wrote: You could swap this around, rename the dispose implementations to close, and provide a deprecated default implementation of dispose that calls close. This way you can manage eventually remove dispose() from the API. -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
Jody, the problem is that doing it this way will break any third-party code that already implements an interface with dispose(). Their implementation will override dispose() and fail to implement close(). What we could do is provide default implementations for *both* close() and @Deprecated dispose() that call each other. All implementations with dispose() will work fine, and will work just the same when dispose() is renamed to close(). I think we need a deprecation cycle: Stage one (GeoTools 20): introduce @Deprecated interface Disposable (extends AutoCloseable) with @Deprecated default dispose() that calls close() and default close() that calls dispose(). All implementations have dispose() marked @Deprecated. All implementations can now have their dispose() renamed to close() as convenient, with @Deprecated removed. The default dispose() will provide backwards compatibility. Stage two (GeoTools 21): remove Disposable entirely, replacing it with AutoClosable. Any remaining dispose() methods renamed to close(). Third-party code that ignored the deprecation warnings is now broken. Is one release cycle enough deprecation before removal? Kind regards, Ben. On 07/06/18 10:41, Jody Garnett wrote: You could swap this around, rename the dispose implementations to close, and provide a deprecated default implementation of dispose that calls close. This way you can manage eventually remove dispose() from the API. -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
Good thinking. This will require more work, but will most likely be best in the long term. We should probably deprecate the proposed Disposable class as well for good measure. Should we change all uses in GeoTools from dispose() to close()? This makes sense but will be a widespread change with impact on pull requests and future backports. Kind regards, Ben. On 07/06/18 10:41, Jody Garnett wrote: You could swap this around, rename the dispose implementations to close, and provide a deprecated default implementation of dispose that calls close. This way you can manage eventually remove dispose() from the API. -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
Thanks for the regex. I would also like to update all classes with
dispose, not just interfaces.
On 07/06/18 08:08, Nuno Oliveira wrote:
Hi Ben,
I also used the support of the find command:
find . | grep -E "\.java$" | xargs -i grep -l -E
"((public)|(^))\s*interface" {} | xargs -i grep -l -E "void\s+dispose" {}
+1 for the proposal.
On 06/06/2018 02:11 AM, Ben Caradoc-Davies wrote:
Thanks, Nuno. How did you make the list? I have been using things like:
find . -name "*.java" -exec grep -l 'void dispose()' {} \; | sort
Instead of editing your list, I would like to make a change proposal
on the wiki.
Kind regards,
Ben.
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] API changes to add AutoCloseable for try-with-resources
Agreed, and Java generics are erased at compile time and offer no run
time benefits.
Kind regards,
Ben.
On 07/06/18 08:06, Nuno Oliveira wrote:
Hi Ben,
+1 for the NON generics option, my felling is that usually generics
bring more harm than good in the long run :(
On 06/06/2018 03:44 AM, Ben Caradoc-Davies wrote:
Or with generics:
public interface ThrowingDisposable extends
AutoCloseable {
/**
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() throws T {
dispose();
}
void dispose() throws T;
}
public interface Disposable extends ThrowingDisposable {
/**
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() {
dispose();
}
@Override
void dispose();
}
Or just keep it simple and have dispose throw Exception like
java.lang.AutoCloseable#close() and let implementers narrow the return
type to no exception if they like. Impact will be minimal as client
code will likely use an implementer not a bare Disposable:
public interface Disposable extends AutoCloseable{
/**
* @throws Exception
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() throws Exception{
dispose();
}
void dispose() throws Exception;
}
Preference?
Kind regards,
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] API changes to add AutoCloseable for try-with-resources
Or with generics:
public interface ThrowingDisposable extends
AutoCloseable {
/**
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() throws T {
dispose();
}
void dispose() throws T;
}
public interface Disposable extends ThrowingDisposable {
/**
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() {
dispose();
}
@Override
void dispose();
}
Or just keep it simple and have dispose throw Exception like
java.lang.AutoCloseable#close() and let implementers narrow the return
type to no exception if they like. Impact will be minimal as client code
will likely use an implementer not a bare Disposable:
public interface Disposable extends AutoCloseable{
/**
* @throws Exception
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() throws Exception{
dispose();
}
void dispose() throws Exception;
}
Preference?
Kind regards,
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] API changes to add AutoCloseable for try-with-resources
On 06/06/18 13:48, Ben Caradoc-Davies wrote:
I would also remove the exception specification because it can never be
thrown, and for consistency with dispose().
Although I should note that there are several classes with a dispose()
that throws. While this is ugly, it can be a necessary guard required
for data integrity. We might need two interfaces ThrowingDisposable and
Disposable:
public interface ThrowingDisposable extends AutoCloseable {
/**
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() throws Exception {
dispose();
}
void dispose() throws Exception;
}
public interface Disposable extends ThrowingDisposable {
/**
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() {
dispose();
}
@Override
void dispose();
}
Kind regards,
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] API changes to add AutoCloseable for try-with-resources
Nuno,
I think you are right. The problem with deprecating dispose is that the
default method uses it and we will never be rid of it. What we really
want is for implementers to use dispose() and for only
try-with-resources to use close(). Java does not permit final on default
methods
<https://stackoverflow.com/questions/23453287/why-is-final-not-allowed-in-java-8-interface-methods>
but we can add a stern warning to treat close() as final. We could even
deprecate close(), which is an ugly misuse, but might be the best way of
warning implementers.
I would also remove the exception specification because it can never be
thrown, and for consistency with dispose().
To make intent clear and make retrofitting even easier, I propose that
we add a Disposable interface that we can conveniently add to any
interface or class with an existing dispose() method. How about:
public interface Disposable extends AutoCloseable {
/**
* Stern warning to treat close as final */
* @see java.lang.AutoCloseable#close()
*/
@Deprecated
@Override
default void close() {
dispose();
}
void dispose();
}
I would put this in org.geotools.util in gt-metadata so it can be used
by the classes in gt-referencing that have dispose().
The one class that cannot be fixed by this is the one that motivated me
to start: ImageReader, which is in javax.imageio, and thus outside our
grasp. This will require some ugly workarounds including delegates and
static factory methods, but this should not deter us from the above fix.
I am calling ImageReader out of scope for this change proposal.
Kind regards,
Ben.
On 05/06/18 20:02, Nuno Oliveira wrote:
I would add the AutoClose interface to all interfaces that have the
dispose method or a similar one. Then I would provide a default
implementation for the close method that invokes the dispose method:
default void close() throws Exception {
dispose();
}
This would make the interfaces fully backward compatible and would allow
us to use the resource try catch pattern. I don't see any possible
resource leakage with this approach, the new code that will start using
the auto close approach will delegate on the existing dispose method and
old code will still use the dispose method.
The only drawback I see is that the dispose method would still around,
the only thing we could do is mark it as deprecated ... but I can leave
with that.
On 06/05/2018 02:16 AM, Ben Caradoc-Davies wrote:
Erik,
we require Java 8 for all supported branches. Interface default
methods are on the table.
Kind regards,
Ben.
On 05/06/18 12:54, Erik Merkle wrote:
A small caveat to my suggestion about default methods. Apparently
default
methods on interfaces is a Java 8 thing. So it is not a viable option if
running with an older version.
Erik Merkle
Software Engineer | Boundless
<http://d32wfbeasdaw38.cloudfront.net/img/Boundless_Logo.png>
On Mon, Jun 4, 2018 at 7:49 PM, Erik Merkle
wrote:
I don't believe I have a vote here, but I wanted to add that you could
provide a default implementation on any GeoServer Interfaces to
which you
want to add AutoCloseable. That would get around the compile issue,
and I
believe the backward compatibility compile issue is exactly why Java
added
the default keyword for interface methods. The default
implementation could
simply be a no-op for things like close().
While it would alleviate compile issues, it might not have the most
reliable runtime effects.
For what it's worth,
Erik Merkle
Software Engineer | Boundless
<http://d32wfbeasdaw38.cloudfront.net/img/Boundless_Logo.png>
On Mon, Jun 4, 2018 at 6:24 PM, Ben Caradoc-Davies
wrote:
Many interfaces in GeoTools and GeoServer use the Dispose pattern,
often
with a dispose() method, but do not implement AutoCloseable,
preventing
their use in a try-with-resources statement. Examples range from
ImageReader to DataStore/DataAccess. Some interfaces like
FeatureReader
already implement Closeable and thus AutoCloseable, but many do not.
Java 7 try-with-resources improves code quality because it simplifies
code by automating common boilerplate:
https://docs.oracle.com/javase/tutorial/essential/exceptions
/tryResourceClose.html
https://docs.oracle.com/javase/8/docs/api/java/lang/AutoCloseable.html
Adding AutoCloseable to an interface is an API-breaking change because
third-party subclasses that do not implement a close() method will no
longer compile. Any change would be applied only to master and
would target
GeoTools 20.0 and GeoServer 2.14.0.
- Should we add AutoCloseable to interfaces, and if so which ones? We
could make a list.
- Do we make the change one interface at a time or try to do them
all at
once?
- Should we rename dispose() to close() in implementers and add a
deprecated dispose() that wraps close(), or just add a close() that
wraps
dispose()?
- As we are breaking the API anyway, should we get rid of dispose()
en
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
Thanks, Nuno. How did you make the list? I have been using things like:
find . -name "*.java" -exec grep -l 'void dispose()' {} \; | sort
Instead of editing your list, I would like to make a change proposal on
the wiki.
Kind regards,
Ben.
On 05/06/18 22:17, Nuno Oliveira wrote:
You can count on me, I can dedicate some spare during WE to this.
I guess before deciding on an attack plan, it would be good to have a
list of the concerned interfaces, I have started to put a list together
here:
https://docs.google.com/spreadsheets/d/1u3488JvSs34IMZ1TLjJ5FYQBAFHhQ4QHqfHfULH_k1s/edit?usp=sharing
Feel free to ask me edition permissions ...
On 06/05/2018 09:17 AM, Andrea Aime wrote:
On Tue, Jun 5, 2018 at 10:05 AM, Ian Turton <mailto:ijtur...@gmail.com>> wrote:
- Who is interested in participating in this work?
I'd be up to do some of it.
Same here. As spare time contribution, if we are a group, we do the
deprecation, and attack one interface at a time.
As a code sprint if we want to do all toghether (though, in a week
long code sprint, we might want to look into more
"urgent yet too big" stuff, like running the whole project stack on
Java 10-11).
Cheers
Andrea
== GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A
55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob:
+39 339 8844549 http://www.geo-solutions.it
http://twitter.com/geosolutions_it
--- /Con
riferimento alla normativa sul trattamento dei dati personali (Reg. UE
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
precisa che ogni circostanza inerente alla presente email (il suo
contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
operazione è illecita. Le sarei comunque grato se potesse darmene
notizia. This email is intended only for the person or entity to which
it is addressed and may contain information that is privileged,
confidential or otherwise protected from disclosure. We remind that -
as provided by European Regulation 2016/679 “GDPR” - copying,
dissemination or use of this e-mail or the information herein by
anyone other than the intended recipient is prohibited. If you have
received this email by mistake, please notify us immediately by
telephone or e-mail./
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources
On 05/06/18 20:05, Ian Turton wrote:
On Tue, 5 Jun 2018 at 00:25, Ben Caradoc-Davies wrote:
- Should we add AutoCloseable to interfaces, and if so which ones? We
could make a list.
This is an obvious first step, is there an easy way to do it? grep for
dispose?
I found many interfaces and classes with:
find . -name "*.java" -exec grep -H 'void dispose()' {} \;
With context:
find . -name "*.java" -exec grep -H -B2 'void dispose()' {} \;
Names only:
find . -name "*.java" -exec grep -l 'void dispose()' {} \; | sort
Nuno also made a list.
- Should we rename dispose() to close() in implementers and add a
deprecated dispose() that wraps close(), or just add a close() that
wraps dispose()?
I'd favour deprecating a dispose() that wraps close() - makes it clearer
what we intend.
This was my first thought, but now I prefer Nuno and Erik's suggestion
of a default method. I am contemplating adding a Disposable interface.
Kind regards,
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] API changes to add AutoCloseable for try-with-resources
Erik, we require Java 8 for all supported branches. Interface default methods are on the table. Kind regards, Ben. On 05/06/18 12:54, Erik Merkle wrote: A small caveat to my suggestion about default methods. Apparently default methods on interfaces is a Java 8 thing. So it is not a viable option if running with an older version. Erik Merkle Software Engineer | Boundless <http://d32wfbeasdaw38.cloudfront.net/img/Boundless_Logo.png> On Mon, Jun 4, 2018 at 7:49 PM, Erik Merkle wrote: I don't believe I have a vote here, but I wanted to add that you could provide a default implementation on any GeoServer Interfaces to which you want to add AutoCloseable. That would get around the compile issue, and I believe the backward compatibility compile issue is exactly why Java added the default keyword for interface methods. The default implementation could simply be a no-op for things like close(). While it would alleviate compile issues, it might not have the most reliable runtime effects. For what it's worth, Erik Merkle Software Engineer | Boundless <http://d32wfbeasdaw38.cloudfront.net/img/Boundless_Logo.png> On Mon, Jun 4, 2018 at 6:24 PM, Ben Caradoc-Davies wrote: Many interfaces in GeoTools and GeoServer use the Dispose pattern, often with a dispose() method, but do not implement AutoCloseable, preventing their use in a try-with-resources statement. Examples range from ImageReader to DataStore/DataAccess. Some interfaces like FeatureReader already implement Closeable and thus AutoCloseable, but many do not. Java 7 try-with-resources improves code quality because it simplifies code by automating common boilerplate: https://docs.oracle.com/javase/tutorial/essential/exceptions /tryResourceClose.html https://docs.oracle.com/javase/8/docs/api/java/lang/AutoCloseable.html Adding AutoCloseable to an interface is an API-breaking change because third-party subclasses that do not implement a close() method will no longer compile. Any change would be applied only to master and would target GeoTools 20.0 and GeoServer 2.14.0. - Should we add AutoCloseable to interfaces, and if so which ones? We could make a list. - Do we make the change one interface at a time or try to do them all at once? - Should we rename dispose() to close() in implementers and add a deprecated dispose() that wraps close(), or just add a close() that wraps dispose()? - As we are breaking the API anyway, should we get rid of dispose() entirely by renaming it to close() without adding a deprecated wrapper? - I thought of updating only interfaces and overrides. A more ambitious scope would find every deprecated dispose() and refactor to use try-with-resources. The alternative is to refactor incrementally over time. How do we wish to pay off our technical debt? - Who is interested in participating in this work? Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Geoserver-devel mailing list geoserver-de...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] API changes to add AutoCloseable for try-with-resources
Eric, that is an interesting idea but I suspect it would introduce silent resource leaks. Unless we have a default implementation that calls the deprecated dispose() method? In any case, just like constructors and virtual destructors in C++, there in an intimate relationship between a close() method and the implementing class. Avoiding a default implementation avoids the risk that an implementer might forget to override it. Kind regards, Ben. On 05/06/18 12:49, Erik Merkle wrote: I don't believe I have a vote here, but I wanted to add that you could provide a default implementation on any GeoServer Interfaces to which you want to add AutoCloseable. That would get around the compile issue, and I believe the backward compatibility compile issue is exactly why Java added the default keyword for interface methods. The default implementation could simply be a no-op for things like close(). While it would alleviate compile issues, it might not have the most reliable runtime effects. For what it's worth, Erik Merkle Software Engineer | Boundless <http://d32wfbeasdaw38.cloudfront.net/img/Boundless_Logo.png> On Mon, Jun 4, 2018 at 6:24 PM, Ben Caradoc-Davies wrote: Many interfaces in GeoTools and GeoServer use the Dispose pattern, often with a dispose() method, but do not implement AutoCloseable, preventing their use in a try-with-resources statement. Examples range from ImageReader to DataStore/DataAccess. Some interfaces like FeatureReader already implement Closeable and thus AutoCloseable, but many do not. Java 7 try-with-resources improves code quality because it simplifies code by automating common boilerplate: https://docs.oracle.com/javase/tutorial/essential/exceptions /tryResourceClose.html https://docs.oracle.com/javase/8/docs/api/java/lang/AutoCloseable.html Adding AutoCloseable to an interface is an API-breaking change because third-party subclasses that do not implement a close() method will no longer compile. Any change would be applied only to master and would target GeoTools 20.0 and GeoServer 2.14.0. - Should we add AutoCloseable to interfaces, and if so which ones? We could make a list. - Do we make the change one interface at a time or try to do them all at once? - Should we rename dispose() to close() in implementers and add a deprecated dispose() that wraps close(), or just add a close() that wraps dispose()? - As we are breaking the API anyway, should we get rid of dispose() entirely by renaming it to close() without adding a deprecated wrapper? - I thought of updating only interfaces and overrides. A more ambitious scope would find every deprecated dispose() and refactor to use try-with-resources. The alternative is to refactor incrementally over time. How do we wish to pay off our technical debt? - Who is interested in participating in this work? Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Geoserver-devel mailing list geoserver-de...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] API changes to add AutoCloseable for try-with-resources
Many interfaces in GeoTools and GeoServer use the Dispose pattern, often with a dispose() method, but do not implement AutoCloseable, preventing their use in a try-with-resources statement. Examples range from ImageReader to DataStore/DataAccess. Some interfaces like FeatureReader already implement Closeable and thus AutoCloseable, but many do not. Java 7 try-with-resources improves code quality because it simplifies code by automating common boilerplate: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html https://docs.oracle.com/javase/8/docs/api/java/lang/AutoCloseable.html Adding AutoCloseable to an interface is an API-breaking change because third-party subclasses that do not implement a close() method will no longer compile. Any change would be applied only to master and would target GeoTools 20.0 and GeoServer 2.14.0. - Should we add AutoCloseable to interfaces, and if so which ones? We could make a list. - Do we make the change one interface at a time or try to do them all at once? - Should we rename dispose() to close() in implementers and add a deprecated dispose() that wraps close(), or just add a close() that wraps dispose()? - As we are breaking the API anyway, should we get rid of dispose() entirely by renaming it to close() without adding a deprecated wrapper? - I thought of updating only interfaces and overrides. A more ambitious scope would find every deprecated dispose() and refactor to use try-with-resources. The alternative is to refactor incrementally over time. How do we wish to pay off our technical debt? - Who is interested in participating in this work? Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Alignment of the planets caused geotools-master-online-postgis DefaultTemporalGeometricPrimitiveTest failure?
And we can also expect this test to fail on 1 January 2020: https://github.com/geotools/geotools/blob/master/modules/library/main/src/test/java/org/geotools/temporal/object/DefaultTemporalGeometricPrimitiveTest.java#L95 The last time this test failed in 2012 the fix was to increase the year to 2020: [GEOT-3995] org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest fails in 2012 https://osgeo-org.atlassian.net/browse/GEOT-3995 https://github.com/geotools/geotools/commit/15aa91e588def1ec9822b0308c9fffb8fff5821d#diff-8f07c1965dae55b7158e9080c79486e5 Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Alignment of the planets caused geotools-master-online-postgis DefaultTemporalGeometricPrimitiveTest failure?
On 03/06/18 09:56, Ben Caradoc-Davies wrote: On 03/06/18 09:33, moni...@boundlessgeo.com wrote: See <https://build.geoserver.org/job/geotools-master-online-postgis/626/display/redirect> I kicked it and it failed again: Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 sec <<< FAILURE! - in org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest testDistance(org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest) Time elapsed: 0 sec <<< FAILURE! java.lang.AssertionError: null at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertFalse(Assert.java:64) at org.junit.Assert.assertFalse(Assert.java:74) at org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest.testDistance(DefaultTemporalGeometricPrimitiveTest.java:73) Timezone rollover problem? Month zero is January. Server west of the meridian? But why was this passing before? There is a logic error in the test! The test assumes that the duration from 25 July 1985 from 1 January 2000 (6734 days) is not the same as the duration from 1 January 2000 to today. But this happens. Once! I am just not sure why it seems to have happened one week early on 2 June 2018. $ date -u -d "6734 day 12:00 25 July 1981 UTC" Sat 1 Jan 12:00:00 UTC 2000 $ date -u -d "6734 day 12:00 1 Jan 2000 UTC" Sat 9 Jun 12:00:00 UTC 2018 Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Build failed in Jenkins: geotools-master-online-postgis #626
On 03/06/18 09:33, moni...@boundlessgeo.com wrote:
See
<https://build.geoserver.org/job/geotools-master-online-postgis/626/display/redirect>
I kicked it and it failed again:
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 sec
<<< FAILURE! - in
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest
testDistance(org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest)
Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest.testDistance(DefaultTemporalGeometricPrimitiveTest.java:73)
Timezone rollover problem? Month zero is January. Server west of the
meridian? But why was this passing before?:
@Test
public void testDistance() {
TemporalGeometricPrimitive other;
// calcul Distance with instant objects
cal.set(2000, 0, 1);
Position position = new DefaultPosition(cal.getTime());
other = new DefaultInstant(position);
Duration result = temporalGeomericPrimitive1.distance(other);
assertFalse(temporalGeomericPrimitive2.distance(other).equals(result));
Kind regards,
--
Ben Caradoc-Davies
Director
Transient Software Limited <https://transient.nz/>
New Zealand
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Should we just ignore the H2 test breaking the online builds?
I have re-enabled H2DataStoreFactoryTest.testTCP on master. It should be fixed on apollo-slave-02 by the /etc/hosts fix, but with the new Jenkins geotools-master-online-postgis -pl -am configuration, it will not even be run. Might as well enable it to restore the coverage. I think this test will now be run on geotools-master. Kind regards, Ben. On 25/05/18 17:04, Ben Caradoc-Davies wrote: H2DataStoreFactoryTest.testTCP is now skipped, revealing a bunch more failures in gt-app-schema and gt-render: https://build.geoserver.org/job/geotools-master-online-postgis/611/consoleText On 25/05/18 14:45, Ben Caradoc-Davies wrote: Andrea, I see that you inadvertently included the @Ignore for H2DataStoreFactoryTest.testTCP in your GEOT-6005 changes: https://github.com/geotools/geotools/commit/d7aac38f6657f9b0064cd4cc71a1c4f5f3601973#diff-f89dcf4a2f5a125e809e6e14c19e242aR86 This @Ignore is ineffective because H2DataStoreFactoryTest is a JUnit 3 TestCase and @Ignore is a JUnit 4 feature. You can see H2DataStoreFactoryTest.testTCP continue to run and fail on Jenkins: https://build.geoserver.org/job/geotools-master-online-postgis/610/consoleText To make your @Ignore effective, I ported H2DataStoreFactoryTest to JUnit 4 on master: https://github.com/geotools/geotools/commit/f94a6b92e3c4ce4aa43f5cfff223b4f909aed14c I have kicked the Jenkins geotools-master-online-postgis build to see if this change fixes it. I have also disabled the Jenkins geotools-master-online-oracle and geotools-master-online-sqlserver-jtds builds until some cares enough to fix them. Kind regards, Ben. On 23/05/18 11:02, Ben Caradoc-Davies wrote: Yes, please disable H2DataStoreFactoryTest.testTCP by X-ing it out or porting to JUnit 4 and using @Ignore. If we cannot fix this failure on Jenkins (and it only fails on Jenkins), we must preserve test coverage by sacrificing the failing method. At the moment, we have no online test coverage for postgis because the online build fails and nobody will notice if a new failure is introduced. Any remaining failing builds must be disabled because they are conditioning developers to ignore build failure messages and are thus harmful to continuous integration. I think the online Oracle test was failing on 3D support. Unless someone cares enough to fix it, it should be disabled. Kind regards, Ben. On 23/05/18 05:14, Andrea Aime wrote: Hi, the geotools-devel list is a wall of test failure reports... should we just disable that test? I don't think it's adding all that much to test coverage... Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https
Re: [Geotools-devel] Jenkins geotools-master-online-postgis
Jenkins geotools-master-online-postgis is now passing. The gt-render failures on apollo-slave-02 are not fixed, and I have not yet determined the cause, despite detailed comparison of the font configurations on apollo-slave-01 (where it passes) and apollo-slave-02 (where it fails). The workaround is to not build gt-render on apollo-slave-02. The build was using: -Ponline -pl modules/plugins/jdbc -amd which means build gt-jdbc and *everything that depends on it*, which includes gt-render. I changed this to: -Ponline -pl modules/plugins/jdbc/jdbc-postgis -am which just builds gt-jdbc-postgis and *everything it depends on*. "-am" is the opposite of "-amd". This avoids building gt-render, fixes the build, and gives us the gt-jdbc-postgis online test coverage we need. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Jenkins apollo-slave-01 is offline
Thanks, Nick. Much appreciated. Kind regards, Ben. On 01/06/18 10:42, Nick Stires wrote: Ben, I think it was a hiccup on the AWS side. I see an alert that it detected downtime. I was able to SSH in and reboot it. It seems on now. I also had to go into the Jenkins Slave menu and start the agent. https://build.geoserver.org/computer/apollo-slave-01/ I've also updated your IP address for the firewall. Let me know if you need anything else! Cheers, Nick On Thu, May 31, 2018 at 6:33 PM, Ben Caradoc-Davies wrote: Nick, Jenkins apollo-slave-01 is offline. Because this is the worker for most GeoTools and GeoServer jobs, most jobs are blocked. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Jenkins apollo-slave-01 is offline
Nick, Jenkins apollo-slave-01 is offline. Because this is the worker for most GeoTools and GeoServer jobs, most jobs are blocked. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Jenkins geotools-master-online-postgis
Looks like a severe font problem to me. This test is supposed to be using the Bitstream Vera Sans we include with GeoTools. Attached screenshot made by sshing into apollo-slave-02 with X forwarding and manual cookie copying, after installing xorg-x11-xauth. As jenkins in /var/jenkins/workspace/geotools-master-online-postgis/modules/library/render: mvn -o -Djava.awt.headless=false -Dorg.geotools.image.test.interactive=true -Dtest="RepeatedLabelTest#testLabelSquareBordersWithHoles" test Running org.geotools.renderer.lite.RepeatedLabelTest May 30, 2018 1:49:08 AM org.geotools.image.ImageWorker INFO: Warp/affine reduction enabled: true Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 220.947 sec <<< FAILURE! - in org.geotools.renderer.lite.RepeatedLabelTest testLabelSquareBordersWithHoles(org.geotools.renderer.lite.RepeatedLabelTest) Time elapsed: 220.897 sec <<< FAILURE! java.lang.AssertionError: Images are visibly different, found 1786 different pixels, against a threshold of 1000 You can add -Dorg.geotools.image.test.interactive=true to show a dialog comparing them (requires GUI support) at org.geotools.image.test.ImageAssert.assertImagesResemble(ImageAssert.java:162) at org.geotools.image.test.ImageAssert.assertEquals(ImageAssert.java:64) at org.geotools.renderer.lite.RepeatedLabelTest.checkRepeatedLabelsPolygonBorder(RepeatedLabelTest.java:178) at org.geotools.renderer.lite.RepeatedLabelTest.testLabelSquareBordersWithHoles(RepeatedLabelTest.java:110) Results : Failed tests: RepeatedLabelTest.testLabelSquareBordersWithHoles:110->checkRepeatedLabelsPolygonBorder:178 Images are visibly different, found 1786 different pixels, against a threshold of 1000 You can add -Dorg.geotools.image.test.interactive=true to show a dialog comparing them (requires GUI support) Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Jenkins geotools-master-online-postgis
Torben, although the build still fails, your guess was good because "fc-match sans" matches DejaVu on both slaves (LGC just has a smaller code point coverage): apollo-slave-01: DejaVuSans.ttf: "DejaVu Sans" "Book" apollo-slave-02: DejaVuLGCSans.ttf: "DejaVu LGC Sans" "Book" In other words, these are the default sans fonts on both platforms. The gt-render tests pass on apollo-slave-01 (Amazon Linux AMI release 2017.03) and fail on apollo-slave-02 (CentOS release 6.9). Kind regards, Ben. On 30/05/18 12:26, Ben Caradoc-Davies wrote: Thanks, Torben. We include Bitstream Vera fonts and some tests depend on them to make them more robust against font differences. I do not think any of the rendering tests use DejaVu fonts but it should not hurt to try. Kind regards, Ben. On 30/05/18 11:45, Torben Barsballe wrote: I've installed the following font packages on apollo-slave-02, and restarted the geotools-master-online-postgis build; lets see if that works - dejavu-sans-mono-fonts - dejavu-lgc-sans-fonts - dejavu-fonts-common If not, it might be worth it to take a look at what packages apollo-slave-01 has that apollo-slave-02 doesn't. Torben On Tue, May 29, 2018 at 4:31 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: If its label tests failing, it may mean that some fonts aren't installed on the build box - I recall that CentOS tends to have a very different set of default fonts then most other systems (Ubuntu, OS X, etc). Let me see if I can find a useful list of fonts to install... Torben On Tue, May 29, 2018 at 3:40 PM, Ben Caradoc-Davies wrote: Nuno, Jenkins apollo-slave-02, the only node used for geotools-master-online-postgis, had an /etc/hosts entry that did not match its DHCP-assigned private network IP address. Fixing this fixed HttpConfigTest in Jenkins geotools-master-online-postgis. This will probably also fix H2DataStoreFactoryTest.testTCP. There are still many "*Label*" failures in gt-render. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Jenkins geotools-master-online-postgis
Thanks, Torben. We include Bitstream Vera fonts and some tests depend on them to make them more robust against font differences. I do not think any of the rendering tests use DejaVu fonts but it should not hurt to try. Kind regards, Ben. On 30/05/18 11:45, Torben Barsballe wrote: I've installed the following font packages on apollo-slave-02, and restarted the geotools-master-online-postgis build; lets see if that works - dejavu-sans-mono-fonts - dejavu-lgc-sans-fonts - dejavu-fonts-common If not, it might be worth it to take a look at what packages apollo-slave-01 has that apollo-slave-02 doesn't. Torben On Tue, May 29, 2018 at 4:31 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: If its label tests failing, it may mean that some fonts aren't installed on the build box - I recall that CentOS tends to have a very different set of default fonts then most other systems (Ubuntu, OS X, etc). Let me see if I can find a useful list of fonts to install... Torben On Tue, May 29, 2018 at 3:40 PM, Ben Caradoc-Davies wrote: Nuno, Jenkins apollo-slave-02, the only node used for geotools-master-online-postgis, had an /etc/hosts entry that did not match its DHCP-assigned private network IP address. Fixing this fixed HttpConfigTest in Jenkins geotools-master-online-postgis. This will probably also fix H2DataStoreFactoryTest.testTCP. There are still many "*Label*" failures in gt-render. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Jenkins geotools-master-online-postgis
Nuno, Jenkins apollo-slave-02, the only node used for geotools-master-online-postgis, had an /etc/hosts entry that did not match its DHCP-assigned private network IP address. Fixing this fixed HttpConfigTest in Jenkins geotools-master-online-postgis. This will probably also fix H2DataStoreFactoryTest.testTCP. There are still many "*Label*" failures in gt-render. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] GeoTools / GeoServer Meeting 2018-05-29
GeoTools / GeoServer Meeting 2018-05-29 Attending Ben Caradoc-Davies Torben Barsballe Kevin Smith Agenda * Jenkins geotools-master-online-postgis failures * FOSS4G-NA Update * OSGeo geotools user compromised * Jira notifications for GeoTools Actions * Ben: investigate at the persistent failure of Jenkins geotools-master-online-postgis on Jenkins build slaves only [DONE] * Everyone: Configure a forwarding email <https://osgeo-org.atlassian.net/secure/admin/IncomingMailServers.jspa>for j...@osgeo-org.atlassian.net <mailto:j...@osgeo-org.atlassian.net>so we can debug GeoTools JIRA notifications (Forwarding email TBD - discuss further on mailing list) Previous meeting actions * Andrea: ping Nuno about residual pull requests in preparation for the big reformat [DONE] Jenkins geotools-master-online-postgis failures The geotools-master-online-postgis job is currently failing (possibly) on a networking issue (see discussion thread for further details) Action: Ben will investigate at the persistent failure of Jenkins geotools-master-online-postgis on Jenkins build slaves only. FOSS4G-NA Update General theme: Cloud first GIS with “STAC, Cloud Optmized GeoTIFF, and machine learning” Presentations: * State of GeoServer - went well, lots of interest, etc… Andrea will be running this at FOSS4GE * State of GeoWebCache - similar * State of JTS - went a lot better, had diagrams to show JTS 2.xchallenges Code Sprint: * More ideas then volunteers present, single day code sprint not enough to get much done * https://wiki.osgeo.org/wiki/FOSS4GNA_Code_Sprint_2018 * Some progress on TWKB, we can port the implementation to GT while we wait for JTS upgrade Upgrade to JTS 1.15.x: need to migrate * GT * GS * GWC * JAI-Ext * JAI-Tools o Some discussion around mbedward work such as jiffle * https://github.com/jeo/jeo- jdeolive work, may need to fork to geotools/jeo * http://hatbox.sourceforge.net - spatial for h2, used test cases, need to fork * https://github.com/jdeolive/geodb - uses hatbox spatial index above OSGeo geotools user compromised OSGeo geotools user was compromised and has been disabled (as of May 12), any ideas? https://lists.osgeo.org/pipermail/sac/2018-May/010017.html So is this used to deploy artifacts to the OSGeo repo? Release 19.1 worked: https://download.osgeo.org/webdav/geotools/org/geotools/gt-api/19.1/ So unless we hear otherwise, … keep it disabled? Jira Notifications for GeoTools Last successful notification I could find was from August 2017: [Geotools-devel] [JIRA] (GEOT-5795) WARNING: java.lang.ClassNotFoundException: org.geotools.data.wfs.v1_0_0.xml.WFSSchema So this has been broken for awhile. Notification settings are here <https://osgeo-org.atlassian.net/plugins/servlet/project-config/GEOT/notifications>and everything seems to be properly configured. It is possible the sending email address (j...@osgeo-org.atlassian.net) needs to accept the new privacy terms from lists.sourceforge.com, similar to the issue we were having with Jenkins notifications. Who has access to the j...@osgeo-org.atlassian.net <mailto:j...@osgeo-org.atlassian.net>mailbox? * Nobody it is probably fake? * geoto...@osgeo.org <mailto:geoto...@osgeo.org>? o Could create with SAC * bu...@geoserver.org <mailto:bu...@geoserver.org>? o matches server name o Who to setup account with ... * moni...@boundlessgeo.com <mailto:moni...@boundlessgeo.com>? o Already working… o Trying: DKIM failure It looks like we can configure jira to forward emails it recieves: https://osgeo-org.atlassian.net/secure/admin/IncomingMailServers.jspa Action: Configure a forwarding email <https://osgeo-org.atlassian.net/secure/admin/IncomingMailServers.jspa>for j...@osgeo-org.atlassian.net <mailto:j...@osgeo-org.atlassian.net>so we can debug this further (Forwarding email TBD) -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=5=29=19=30=0=1 -- Ben Caradoc-Davies Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Build failed in Jenkins: geotools-master-online-postgis #614
... SKIPPED [INFO] Process Raster . SKIPPED [INFO] YSLD Parser/Encoder SKIPPED [INFO] SWT widgets SKIPPED [INFO] MBTiles Module . SUCCESS [ 5.899 s] [INFO] Cartographic CSS parser SKIPPED [INFO] Mapbox Styles Support .. SKIPPED [INFO] Next Generation JDBC DataStores SUCCESS [ 0.011 s] [INFO] GeoTools Documentation . SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 52:17 min [INFO] Finished at: 2018-05-27T14:00:24+00:00 [INFO] Final Memory: 78M/445M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.15:test (default-test) on project gt-render: There are test failures. [ERROR] [ERROR] Please refer to <https://build.geoserver.org/job/geotools-master-online-postgis/ws/modules/library/render/target/surefire-reports> for the individual test results. [ERROR] -> [Help 1] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.15:test (default-test) on project gt-app-schema: There are test failures. [ERROR] [ERROR] Please refer to <https://build.geoserver.org/job/geotools-master-online-postgis/ws/modules/extension/app-schema/app-schema/target/surefire-reports> for the individual test results. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :gt-render Build step 'Invoke top-level Maven targets' marked build as failure -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Build failed in Jenkins: geotools-master-online-postgis #611
Nick,
the test is using an internal embedded Jetty server, as far as I know.
This test and an H2 test I disabled earlier pass elsewhere but fail only
on the Jenkins slaves. Both fail trying to connect to a service running
in a different thread in the same process on the same machine. The error
messages suggest that there is something odd about the networking
configuration on these machines.
Kind regards,
Ben.
On 26/05/18 05:29, Nick Stires wrote:
It doesn't appear to be a firewall issue. I'm curious what's going on
around the web server init. We may have some missing dependencies. I don't
see apache or nginx installed on slave-02. If you can emulate that, or
pause it, we can check for open ports to make sure the listener is working.
Then follow it up with a telnet to ensure connection handshake.
-Nick
On Fri, May 25, 2018 at 12:42 PM, Torben Barsballe <
tbarsba...@boundlessgeo.com> wrote:
Took a look at both slaves. There is an entry for localhost in /etc/hosts,
and I am able to ping localhost without issue.
My only other thought would be some sort of internal firewall rule - Nick,
any ideas if this could be the case?
Looking at the test logs before the error, I see this:
Running org.geotools.http.HttpConfigTest
2018-05-25 16:39:07.057:INFO::main: Logging initialized @757ms
2018-05-25 16:39:07.093:INFO:oejs.Server:main: jetty-9.2.13.v20150730
2018-05-25 16:39:07.122:INFO:oejs.ServerConnector:main: Started
ServerConnector@223191a6{HTTP/1.1}{0.0.0.0:44593}
2018-05-25 16:39:07.123:INFO:oejs.Server:main: Started @824ms
May 25, 2018 4:39:07 PM org.geotools.http.HttpStaticServer start
INFO: HTTP static server started 'build-slave-02.geoserver.org:44593'.
May 25, 2018 4:39:07 PM org.geotools.http.HttpStaticServer putResource
INFO: Resource http://build-slave-02.geoserver.org:44593/
measurements_http_includes.xml added.
May 25, 2018 4:39:07 PM org.geotools.http.HttpStaticServer putResource
INFO: Resource http://build-slave-02.geoserver.org:44593/
measurements_relative_includes.xml added.
May 25, 2018 4:39:07 PM org.geotools.http.HttpStaticServer putResource
INFO: Resource http://build-slave-02.geoserver.org:44593/stations_
http_includes.xml added.
May 25, 2018 4:39:07 PM org.geotools.http.HttpStaticServer putResource
INFO: Resource http://build-slave-02.geoserver.org:44593/stations_
relative_includes.xml added.
May 25, 2018 4:39:07 PM org.geotools.http.HttpStaticServer putResource
INFO: Resource http://build-slave-02.geoserver.org:44593/stations.xsd
added.
May 25, 2018 4:39:07 PM org.geotools.data.DataAccessFinder getDataStore
WARNING: Problem asking Directory of spatial files (shapefiles) if it can
process request:java.lang.NullPointerException
So, it does seem to be trying to use the true hostname of the slave,
rather than localhost (and appears to be able to successfully put
resources).
Torben
On Thu, May 24, 2018 at 10:02 PM, Ben Caradoc-Davies <b...@transient.nz>
wrote:
Torben and Nick,
I suspect that there is something wrong with networking on the Jenkins
slaves. Can you please check that they have working localhost including an
entry for localhost in /etc/hosts. I am pretty sure that a test is failing
trying to connect to localhost with:
"java.net.NoRouteToHostException: No route to host (Host unreachable)"
Kind regards,
Ben.
On 25/05/18 16:45, moni...@boundlessgeo.com wrote:
See <https://build.geoserver.org/job/geotools-master-online-post
gis/611/display/redirect?page=changes>
Changes:
[Ben Caradoc-Davies] [GEOT-6027] LabelingTest.testLineLabelingSharpTurn2
fails on Oracle JDK
[Ben Caradoc-Davies] Port H2DataStoreFactoryTest to JUnit 4 so @Ignore
on testTCP works
[Ben Caradoc-Davies] [GEOT-6028] Bad URL->File conversion causes
HttpConfigTest failure in a
--
[...truncated 725.71 KB...]
at java.net.Socket.connect(Socket.java:589)
at java.net.Socket.connect(Socket.java:538)
at sun.net.NetworkClient.doConnect(NetworkClient.java:180)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:463)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:558)
at sun.net.www.http.HttpClient.(HttpClient.java:242)
at sun.net.www.http.HttpClient.New(HttpClient.java:339)
at sun.net.www.http.HttpClient.New(HttpClient.java:357)
at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient
(HttpURLConnection.java:1202)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(Ht
tpURLConnection.java:1138)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect(Htt
pURLConnection.java:1032)
at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLC
onnection.java:966)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(
HttpURLConnection.java:1546)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(H
ttpURLConnection.java:1474)
at j
Re: [Geotools-devel] Should we just ignore the H2 test breaking the online builds?
H2DataStoreFactoryTest.testTCP is now skipped, revealing a bunch more failures in gt-app-schema and gt-render: https://build.geoserver.org/job/geotools-master-online-postgis/611/consoleText On 25/05/18 14:45, Ben Caradoc-Davies wrote: Andrea, I see that you inadvertently included the @Ignore for H2DataStoreFactoryTest.testTCP in your GEOT-6005 changes: https://github.com/geotools/geotools/commit/d7aac38f6657f9b0064cd4cc71a1c4f5f3601973#diff-f89dcf4a2f5a125e809e6e14c19e242aR86 This @Ignore is ineffective because H2DataStoreFactoryTest is a JUnit 3 TestCase and @Ignore is a JUnit 4 feature. You can see H2DataStoreFactoryTest.testTCP continue to run and fail on Jenkins: https://build.geoserver.org/job/geotools-master-online-postgis/610/consoleText To make your @Ignore effective, I ported H2DataStoreFactoryTest to JUnit 4 on master: https://github.com/geotools/geotools/commit/f94a6b92e3c4ce4aa43f5cfff223b4f909aed14c I have kicked the Jenkins geotools-master-online-postgis build to see if this change fixes it. I have also disabled the Jenkins geotools-master-online-oracle and geotools-master-online-sqlserver-jtds builds until some cares enough to fix them. Kind regards, Ben. On 23/05/18 11:02, Ben Caradoc-Davies wrote: Yes, please disable H2DataStoreFactoryTest.testTCP by X-ing it out or porting to JUnit 4 and using @Ignore. If we cannot fix this failure on Jenkins (and it only fails on Jenkins), we must preserve test coverage by sacrificing the failing method. At the moment, we have no online test coverage for postgis because the online build fails and nobody will notice if a new failure is introduced. Any remaining failing builds must be disabled because they are conditioning developers to ignore build failure messages and are thus harmful to continuous integration. I think the online Oracle test was failing on 3D support. Unless someone cares enough to fix it, it should be disabled. Kind regards, Ben. On 23/05/18 05:14, Andrea Aime wrote: Hi, the geotools-devel list is a wall of test failure reports... should we just disable that test? I don't think it's adding all that much to test coverage... Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.l
Re: [Geotools-devel] Build failed in Jenkins: geotools-master-online-postgis #611
Torben and Nick, I suspect that there is something wrong with networking on the Jenkins slaves. Can you please check that they have working localhost including an entry for localhost in /etc/hosts. I am pretty sure that a test is failing trying to connect to localhost with: "java.net.NoRouteToHostException: No route to host (Host unreachable)" Kind regards, Ben. On 25/05/18 16:45, moni...@boundlessgeo.com wrote: See <https://build.geoserver.org/job/geotools-master-online-postgis/611/display/redirect?page=changes> Changes: [Ben Caradoc-Davies] [GEOT-6027] LabelingTest.testLineLabelingSharpTurn2 fails on Oracle JDK [Ben Caradoc-Davies] Port H2DataStoreFactoryTest to JUnit 4 so @Ignore on testTCP works [Ben Caradoc-Davies] [GEOT-6028] Bad URL->File conversion causes HttpConfigTest failure in a -- [...truncated 725.71 KB...] at java.net.Socket.connect(Socket.java:589) at java.net.Socket.connect(Socket.java:538) at sun.net.NetworkClient.doConnect(NetworkClient.java:180) at sun.net.www.http.HttpClient.openServer(HttpClient.java:463) at sun.net.www.http.HttpClient.openServer(HttpClient.java:558) at sun.net.www.http.HttpClient.(HttpClient.java:242) at sun.net.www.http.HttpClient.New(HttpClient.java:339) at sun.net.www.http.HttpClient.New(HttpClient.java:357) at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1202) at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1138) at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1032) at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:966) at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1546) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474) at java.net.URL.openStream(URL.java:1045) at org.geotools.data.complex.config.XMLConfigDigester.digest(XMLConfigDigester.java:110) at org.geotools.data.complex.config.XMLConfigDigester.parse(XMLConfigDigester.java:89) at org.geotools.data.complex.AppSchemaDataAccessFactory.createDataStore(AppSchemaDataAccessFactory.java:84) at org.geotools.data.complex.AppSchemaDataAccessFactory.createDataStore(AppSchemaDataAccessFactory.java:74) at org.geotools.data.DataAccessFinder.getDataStore(DataAccessFinder.java:121) at org.geotools.data.DataAccessFinder.getDataStore(DataAccessFinder.java:77) at org.geotools.http.HttpConfigTest.buildAppSchemaDataStore(HttpConfigTest.java:144) at org.geotools.http.HttpConfigTest.testHttpMapping(HttpConfigTest.java:100) at org.geotools.http.HttpConfigTest.testHttpIncludes(HttpConfigTest.java:85) Running org.geotools.util.ComplexAttributeConverterFactoryTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.geotools.util.ComplexAttributeConverterFactoryTest Running org.geotools.util.InterpolationPropertiesTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.geotools.util.InterpolationPropertiesTest Results : Tests in error: HttpConfigTest.testRelativeIncludes:91->testHttpMapping:100->buildAppSchemaDataStore:148 Runtime HttpConfigTest.testHttpIncludes:85->testHttpMapping:100->buildAppSchemaDataStore:148 Runtime Tests run: 145, Failures: 0, Errors: 2, Skipped: 0 [INFO] [INFO] [INFO] Skipping MongoDB DataStore [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Web Map Server client [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Swing widgets [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Tile Client [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Web Map Tile Service Client [INFO] This project has been banned from the build due to previous failures. [INFO] --
Re: [Geotools-devel] Should we just ignore the H2 test breaking the online builds?
Andrea, I see that you inadvertently included the @Ignore for H2DataStoreFactoryTest.testTCP in your GEOT-6005 changes: https://github.com/geotools/geotools/commit/d7aac38f6657f9b0064cd4cc71a1c4f5f3601973#diff-f89dcf4a2f5a125e809e6e14c19e242aR86 This @Ignore is ineffective because H2DataStoreFactoryTest is a JUnit 3 TestCase and @Ignore is a JUnit 4 feature. You can see H2DataStoreFactoryTest.testTCP continue to run and fail on Jenkins: https://build.geoserver.org/job/geotools-master-online-postgis/610/consoleText To make your @Ignore effective, I ported H2DataStoreFactoryTest to JUnit 4 on master: https://github.com/geotools/geotools/commit/f94a6b92e3c4ce4aa43f5cfff223b4f909aed14c I have kicked the Jenkins geotools-master-online-postgis build to see if this change fixes it. I have also disabled the Jenkins geotools-master-online-oracle and geotools-master-online-sqlserver-jtds builds until some cares enough to fix them. Kind regards, Ben. On 23/05/18 11:02, Ben Caradoc-Davies wrote: Yes, please disable H2DataStoreFactoryTest.testTCP by X-ing it out or porting to JUnit 4 and using @Ignore. If we cannot fix this failure on Jenkins (and it only fails on Jenkins), we must preserve test coverage by sacrificing the failing method. At the moment, we have no online test coverage for postgis because the online build fails and nobody will notice if a new failure is introduced. Any remaining failing builds must be disabled because they are conditioning developers to ignore build failure messages and are thus harmful to continuous integration. I think the online Oracle test was failing on 3D support. Unless someone cares enough to fix it, it should be disabled. Kind regards, Ben. On 23/05/18 05:14, Andrea Aime wrote: Hi, the geotools-devel list is a wall of test failure reports... should we just disable that test? I don't think it's adding all that much to test coverage... Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Should we just ignore the H2 test breaking the online builds?
Yes, please disable H2DataStoreFactoryTest.testTCP by X-ing it out or porting to JUnit 4 and using @Ignore. If we cannot fix this failure on Jenkins (and it only fails on Jenkins), we must preserve test coverage by sacrificing the failing method. At the moment, we have no online test coverage for postgis because the online build fails and nobody will notice if a new failure is introduced. Any remaining failing builds must be disabled because they are conditioning developers to ignore build failure messages and are thus harmful to continuous integration. I think the online Oracle test was failing on 3D support. Unless someone cares enough to fix it, it should be disabled. Kind regards, Ben. On 23/05/18 05:14, Andrea Aime wrote: Hi, the geotools-devel list is a wall of test failure reports... should we just disable that test? I don't think it's adding all that much to test coverage... Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 15:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 15:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=5=15=15=30=0=1 -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geoserver-devel] Promoting MongoDB as an extension \ supported plugin
posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Geoserver-devel mailing list geoserver-de...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Jenkins geotools-master-online-postgis broken for six months
Yes, I think Daniele made the hstore tests robust against the absence of the hstore extension. Kind regards, Ben. On 02/05/18 11:09, Torben Barsballe wrote: As of the latest tests, it seems like the H2 failure is the only thing causing the geotools-master-online-postgis tests to fail - the PostGIS tests pass fine. (As an aside, I was able to "create extension hstore" on the PostGIS DB, but the PostGIS tests were passing before that) Torben On Wed, Apr 18, 2018 at 7:50 AM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: On Wed, Apr 18, 2018 at 7:01 AM, Andrea Aime <andrea.a...@geo-solutions.it wrote: Hum: Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.32 sec <<< FAILURE! - in org.geotools.data.h2.H2DataStoreFactoryTest testTCP(org.geotools.data.h2.H2DataStoreFactoryTest) Time elapsed: 12.316 sec <<< ERROR! org.h2.jdbc.JdbcSQLException: Exception opening port H2 TCP Server (tcp://172.16.1.87:9092) (port may be in use), cause: timeout [90061-119] at org.h2.message.Message.getSQLException(Message.java:106) at org.h2.message.Message.getSQLException(Message.java:117) at org.h2.tools.Server.start(Server.java:361) at org.geotools.data.h2.H2DataStoreFactoryTest.testTCP(H2DataStoreFactoryTest.java:94) What's keeping port 9092 busy? don't know... I've seen similar errors locally (with various different tests that use H2) if a previous H2 test didn't close its connections properly or terminated in a non-standard fashion. When that is the issue the problem typically goes away after a few hours (or a machine restart). Not sure if that is the case here though. Torben Cheers Andrea On Wed, Apr 18, 2018 at 1:49 PM, Daniele Romagnoli < daniele.romagn...@geo-solutions.it> wrote: Hi again, Good news: The 2 test classes (HSTORE and JSON) aren't failing anymore: https://build.geoserver.org/view/geotools/job/geotools-maste r-online-postgis/571/console However that the build is still failing on different H2 related stuff which seems failing since long time too. Cheers, Daniele On Wed, Apr 18, 2018 at 12:16 PM, Daniele Romagnoli < daniele.romagn...@geo-solutions.it> wrote: Hi everybody. From my previous understanding, the https://osgeo-org.atlassia n.net/browse/GEOT-5876 JIRA was closed as "Not a bug" so I didn't spend additional time on it. However, it looks like is still causing issues with online tests so I was able to replicate it locally and made a couple of fixes for HSTORE and JSON Let's see if the next builds are happy for these tests. Regards, Daniele On Tue, Apr 17, 2018 at 11:53 PM, Ben Caradoc-Davies <b...@transient.nz> wrote: All I know is that I needed a one-time "create extension hstore;" to turn on hstore support in my test database. I do not know anything about the JSON failure. Kind regards, Ben. On 18/04/18 07:23, Torben Barsballe wrote: As far as I can tell, this is a GeoTools failure - the PostGIS instance does seem to be working (I know this has been an issue in the past, but I don't think PostGIS is the problem this time) I'm not familiar enough with the failing tests (PostGISHStoreOnlineTest and PostGISJsonOnlineTest) to say for certain though. Torben On Fri, Mar 30, 2018 at 9:22 PM, Ben Caradoc-Davies <b...@transient.nz wrote: https://build.geoserver.org/view/geotools/job/geotools-maste r-online-postgis/ Builds that are already broken do cause new breakage to be noticed: https://osgeo-org.atlassian.net/browse/GEOT-5981 https://github.com/geotools/geotools/pull/1846 -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Regards, Daniele Romagnoli == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Daniele Romagnoli Senior Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitte
Re: [Geotools-devel] Missing emails to the geotools-devel mailing list
SourceForge support have cleared their stuck mail queue: Forwarded Message Subject: [forge:site-support] #17601 Email to SourceForge mailing lists sometimes not delivered Date: Wed, 02 May 2018 16:31:06 - From: Dave Brondsema <brond...@users.sourceforge.net> Reply-To: [forge:site-support] <17...@site-support.forge.p.re.sourceforge.net> To: [forge:site-support] <17...@site-support.forge.p.re.sourceforge.net> - **status**: open --> fixed - **private**: No --> Yes - **Comment**: Hi Ben, We found this email among others that got stuck in the mail queue. We have fixed the issue and they have sent out now. Thanks for providing the header details. Note I am setting this ticket private since it has personal email addresses in it. Sincerely, SourceForge.net Support On 02/05/18 09:40, Ben Caradoc-Davies wrote: Reported to SourceForge: #17601 Email to SourceForge mailing lists sometimes not delivered https://sourceforge.net/p/forge/site-support/17601/ On 02/05/18 07:01, Ben Caradoc-Davies wrote: My email below was not delivered to the list. [...] On 01/05/18 10:34, Ben Caradoc-Davies wrote: Of my last five emails sent to this mailing list, only two have been delivered (and the missing emails do not appear in the archives <https://sourceforge.net/p/geotools/mailman/geotools-devel/>). Two of the missing emails were sent over a day ago. MTA logs confirm that mx.sourceforge.net accepted all five emails. If this one makes it through, the success rate will be 50%. Has anyone else noticed emails sent to this list but not delivered? Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Build failed in Jenkins: geotools-master #2525
Jody and Torben, thanks for fixing Jenkins notifications! On 02/05/18 09:52, moni...@boundlessgeo.com wrote: See <https://build.geoserver.org/job/geotools-master/2525/display/redirect?page=changes> Changes: [tbarsballe] [GEOT-6000] change handler access modifier to protected (#1871) -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Missing emails to the geotools-devel mailing list
Of my last five emails sent to this mailing list, only two have been delivered (and the missing emails do not appear in the archives <https://sourceforge.net/p/geotools/mailman/geotools-devel/>). Two of the missing emails were sent over a day ago. MTA logs confirm that mx.sourceforge.net accepted all five emails. If this one makes it through, the success rate will be 50%. Has anyone else noticed emails sent to this list but not delivered? Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Big bad reformat done
[Resending as not delivered to geotools-devel, despite confirmed acceptance by mx.sourceforge.net] On 30/04/18 09:57, Ben Caradoc-Davies wrote: We should update the developer manual. Andrea, I see that you have updated the developer manual. Thanks! Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Big bad reformat done
Thanks, Andrea. Do we have an AOSP formatter for Eclipse that we recommend? And a configuration for IntelliJ? We should update the developer manual. Kind regards, Ben. On 29/04/18 21:53, Andrea Aime wrote: Hi, the full reformat has been done on all 3 branches. A few updates: - I did not try to reformat the maven plugins and the docs before, that threw me a few curve balls. See the thread about ":lines." usage for docs, plugin wise, I gave up reformatting the xmlcodegen one as it caused build failures, hopefully not a big deal, don't think we're going to touch it anyways - The formatter checkes are really strict, that is, it checks the file is exactly identical to how it would format it. So, instead of adding the checks, I've enabled the reformatting on build. That helps also those that cannot use IDE plugins, just build once before committing and done. - Since someone will forget to build before committing, I've also added a noLocalChanges profile that checks there are no local changes during the build, and enabled it during Travis builds. I'm thinking we should probably have it also for build.geoserver.org, do you agree? Please follow up this mail with any issue/hiccup you encounter. Next reformat is GeoServer, I'll try to work on it once the pull request queue is (almost) empty, help to bring it down in that state appreciated :-) Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Big bad reformat done
On 30/04/18 09:57, Ben Caradoc-Davies wrote: We should update the developer manual. Andrea, I see that you have updated the developer manual. Thanks! Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Missing emails to the geotools-devel mailing list
Reported to SourceForge: #17601 Email to SourceForge mailing lists sometimes not delivered https://sourceforge.net/p/forge/site-support/17601/ On 02/05/18 07:01, Ben Caradoc-Davies wrote: My email below was not delivered to the list. [...] On 01/05/18 10:34, Ben Caradoc-Davies wrote: Of my last five emails sent to this mailing list, only two have been delivered (and the missing emails do not appear in the archives <https://sourceforge.net/p/geotools/mailman/geotools-devel/>). Two of the missing emails were sent over a day ago. MTA logs confirm that mx.sourceforge.net accepted all five emails. If this one makes it through, the success rate will be 50%. Has anyone else noticed emails sent to this list but not delivered? Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] GeoTools / GeoServer Meeting 2018-05-01
GeoTools / GeoServer Meeting 2018-05-01 Attending Ben Caradoc-Davies Torben Barsballe Jody Garnett Kevin Smith Jim Hughes (joined near the end for JTS etc discussion) Agenda * Missing emails on SourceForge mailing lists * Jenkins geotools-master-online-postgis build * State of presentation coordination * Release manager for 19.1 / 1.13.1 / 2.13.1 Actions * Everyone: try Jitsi, perhaps use it next time instead of Skype * Ben: report missing mailing list emails to SourceForge * Jody: investigate Jenkins email subscription for geotools-devel to get notifications * Torben: follow up postgis configuration for Jenkins geotools-master-online-postgis build with Nick Previous meeting actions * Ben:Discuss Jenkins geotools-master-online-postgis build with Torben [DONE] Missing emails on SourceForge mailing lists * Some Emails from Ben to Geotools-devel are missing * One from Kevin to geowebcache-devel * No geotools-devel Jenkins notifications * Admin interface here: https://lists.sourceforge.net/lists/admin/geotools-devel * Action: Ben to report missing mailing list emails to SourceForge * Action: Jody to investigate Jenkins email subscription for geotools-devel to get notifications o (done) SF no longer able to manage users due to privacy o moni...@boundlessgeo.com <mailto:moni...@boundlessgeo.com>will need to resubscribe to the mailing list o Aside: ICANN versus EU on privacy shows concerns not misplaced Jenkins geotools-master-online-postgis build * Postgis configuration investigated by Torben, but does not have admin access * Action: Torben to follow up with Nick * One time configuration, no profile for setting up fixtures State of presentation coordination Kevin is starting “State of GeoServer 2018” and “State of GeoWebCache 2018” presentation decks for foss4gna. Scheduled for: * FOSS4GNA * FOSS4GE * Not sure about foss4g global yet Topics to highlight: * Java 18.9 LTS roadmap compatibility o Lots of work not much visible, units library etc... * Mapbox Style? Filters being added, etc... * GWC Config refactor * Need to ask devel list for features and customers to highlight. Release manager for 19.1 / 1.13.1 / 2.13.1 * GWC 1.13 - Kevin (Unless travel back from FOSS4G-NA goes wrong) * Torben volunteered for 19.1 / 2.13.1 Pull requests * Reviewed GeoServer pull requests in preparation for impending mass reformat next weekend Proposals Rainy day proposals: * GSIP 167 - Log4j Upgrade <https://github.com/geoserver/geoserver/wiki/GSIP-167> o required for “jigsaw” (Java 9+) compatibility * Upgrade to JTS-1.15.0 <https://github.com/geotools/geotools/wiki/Upgrade-to-JTS-1.15.0>- mostly bulk search and replace of imports. o Jim has branches ready and tested (that will need to be redone after reformatting) o Discussion of Tiny Well-Known Binary o Had to upgrade jai-tools, jai-ext, and geodb, … o hatbox (http://hatbox.sourceforge.net/derbyquickstart.html) used in some unit tests, h2 datastore(?) o Being considered for foss4gna code-sprint -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Missing emails to the geotools-devel mailing list
We are not getting any Jenkins notifications to the geotools-devel list, so this is not a new problem. On 02/05/18 07:01, Ben Caradoc-Davies wrote: Jenkins build failure emails are also missing: https://build.geoserver.org/view/geotools/job/geotools-master/2522/ -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Missing emails to the geotools-devel mailing list
My email below was not delivered to the list. Jenkins build failure emails are also missing: https://build.geoserver.org/view/geotools/job/geotools-master/2522/ Kind regards, Ben. On 01/05/18 10:34, Ben Caradoc-Davies wrote: Of my last five emails sent to this mailing list, only two have been delivered (and the missing emails do not appear in the archives <https://sourceforge.net/p/geotools/mailman/geotools-devel/>). Two of the missing emails were sent over a day ago. MTA logs confirm that mx.sourceforge.net accepted all five emails. If this one makes it through, the success rate will be 50%. Has anyone else noticed emails sent to this list but not delivered? Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Big bad reformat done
Note that Eclipse users might need to build an formatter plugin from source to get AOSP support: google-java-format Eclipse plugin does not provide AOSP Style option as google-java-format IntelliJ plugin https://github.com/google/google-java-format/issues/179 This adds an AOSP formatter to the Eclipse plugin https://github.com/google/google-java-format/pull/251 Kind regards, Ben. On 01/05/18 10:59, Ben Caradoc-Davies wrote: Thanks, Jody. I see that Andrea added this link at the end of the coding style page: http://docs.geotools.org/latest/developer/conventions/code/style.html#use-of-formatting-tools Kind regards, Ben. On 01/05/18 10:54, Jody Garnett wrote: The pull request links to google-java-format <https://github.com/google/google-java-format>, which provides a plugin for installation. -- Jody Garnett On Mon, 30 Apr 2018 at 14:15, Ben Caradoc-Davies <b...@transient.nz> wrote: [Resending as not delivered to geotools-devel, despite confirmed acceptance by mx.sourceforge.net] Thanks, Andrea. Do we have an AOSP formatter for Eclipse that we recommend? And a configuration for IntelliJ? We should update the developer manual. Kind regards, Ben. On 29/04/18 21:53, Andrea Aime wrote: Hi, the full reformat has been done on all 3 branches. A few updates: - I did not try to reformat the maven plugins and the docs before, that threw me a few curve balls. See the thread about ":lines." usage for docs, plugin wise, I gave up reformatting the xmlcodegen one as it caused build failures, hopefully not a big deal, don't think we're going to touch it anyways - The formatter checkes are really strict, that is, it checks the file is exactly identical to how it would format it. So, instead of adding the checks, I've enabled the reformatting on build. That helps also those that cannot use IDE plugins, just build once before committing and done. - Since someone will forget to build before committing, I've also added a noLocalChanges profile that checks there are no local changes during the build, and enabled it during Travis builds. I'm thinking we should probably have it also for build.geoserver.org, do you agree? Please follow up this mail with any issue/hiccup you encounter. Next reformat is GeoServer, I'll try to work on it once the pull request queue is (almost) empty, help to bring it down in that state appreciated :-) Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz>
Re: [Geotools-devel] Big bad reformat done
Thanks, Jody. I see that Andrea added this link at the end of the coding style page: http://docs.geotools.org/latest/developer/conventions/code/style.html#use-of-formatting-tools Kind regards, Ben. On 01/05/18 10:54, Jody Garnett wrote: The pull request links to google-java-format <https://github.com/google/google-java-format>, which provides a plugin for installation. -- Jody Garnett On Mon, 30 Apr 2018 at 14:15, Ben Caradoc-Davies <b...@transient.nz> wrote: [Resending as not delivered to geotools-devel, despite confirmed acceptance by mx.sourceforge.net] Thanks, Andrea. Do we have an AOSP formatter for Eclipse that we recommend? And a configuration for IntelliJ? We should update the developer manual. Kind regards, Ben. On 29/04/18 21:53, Andrea Aime wrote: Hi, the full reformat has been done on all 3 branches. A few updates: - I did not try to reformat the maven plugins and the docs before, that threw me a few curve balls. See the thread about ":lines." usage for docs, plugin wise, I gave up reformatting the xmlcodegen one as it caused build failures, hopefully not a big deal, don't think we're going to touch it anyways - The formatter checkes are really strict, that is, it checks the file is exactly identical to how it would format it. So, instead of adding the checks, I've enabled the reformatting on build. That helps also those that cannot use IDE plugins, just build once before committing and done. - Since someone will forget to build before committing, I've also added a noLocalChanges profile that checks there are no local changes during the build, and enabled it during Travis builds. I'm thinking we should probably have it also for build.geoserver.org, do you agree? Please follow up this mail with any issue/hiccup you encounter. Next reformat is GeoServer, I'll try to work on it once the pull request queue is (almost) empty, help to bring it down in that state appreciated :-) Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-d
Re: [Geotools-devel] Big bad reformat done
[Resending as not delivered to geotools-devel, despite confirmed acceptance by mx.sourceforge.net] Thanks, Andrea. Do we have an AOSP formatter for Eclipse that we recommend? And a configuration for IntelliJ? We should update the developer manual. Kind regards, Ben. On 29/04/18 21:53, Andrea Aime wrote: Hi, the full reformat has been done on all 3 branches. A few updates: - I did not try to reformat the maven plugins and the docs before, that threw me a few curve balls. See the thread about ":lines." usage for docs, plugin wise, I gave up reformatting the xmlcodegen one as it caused build failures, hopefully not a big deal, don't think we're going to touch it anyways - The formatter checkes are really strict, that is, it checks the file is exactly identical to how it would format it. So, instead of adding the checks, I've enabled the reformatting on build. That helps also those that cannot use IDE plugins, just build once before committing and done. - Since someone will forget to build before committing, I've also added a noLocalChanges profile that checks there are no local changes during the build, and enabled it during Travis builds. I'm thinking we should probably have it also for build.geoserver.org, do you agree? Please follow up this mail with any issue/hiccup you encounter. Next reformat is GeoServer, I'll try to work on it once the pull request queue is (almost) empty, help to bring it down in that state appreciated :-) Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=5=1=19=30=0=1 -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] About the OGR failures
On 20/04/18 18:24, Andrea Aime wrote: On Fri, Apr 20, 2018 at 1:16 AM, Jody Garnett <jody.garn...@gmail.com> wrote: Andrea, I often often been frustrated with build difficulties on this one over the years. I understand it is not supported, so just remain frustrated - usually removing GDAL when it showed up on my path. Well, the module is actually in supported land, and cannot stay there in this condition. The JNI part is equally broken, but at least it's not breaking the build. I have too many modules to look after, time to cut some dead branches +1 to demote modules that we do not support to unsupported status. Note however that we do have some community interest in GDAL and we should give them a chance to assess whether they are willing to support this module. Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Jenkins geotools-master-online-postgis broken for six months
All I know is that I needed a one-time "create extension hstore;" to turn on hstore support in my test database. I do not know anything about the JSON failure. Kind regards, Ben. On 18/04/18 07:23, Torben Barsballe wrote: As far as I can tell, this is a GeoTools failure - the PostGIS instance does seem to be working (I know this has been an issue in the past, but I don't think PostGIS is the problem this time) I'm not familiar enough with the failing tests (PostGISHStoreOnlineTest and PostGISJsonOnlineTest) to say for certain though. Torben On Fri, Mar 30, 2018 at 9:22 PM, Ben Caradoc-Davies <b...@transient.nz> wrote: https://build.geoserver.org/view/geotools/job/geotools-maste r-online-postgis/ Builds that are already broken do cause new breakage to be noticed: https://osgeo-org.atlassian.net/browse/GEOT-5981 https://github.com/geotools/geotools/pull/1846 -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 15:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 15:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=4=17=15=30=0=1 -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Codebase reformat using Google/AOSP format
+1. Thanks very much, Andrea. We have needed this for a long time. Extra credit for linking to GSIP-2. :-) Kind regards, Ben. On 15/04/18 21:47, Andrea Aime wrote: Hi all, sorry for the cross posting, but this proposal is best applied on all projects toghether, and would have the same contents on all projects (if really needed, I can copy/paste on GeoServer's wiki): https://github.com/geotools/geotools/wiki/Codebase-Reformat The last discussion and vote showed that everybody is comfortable with the AOSP format, so that's the one that has been chosen. Please vote :-) Once voting is done we'll have to coordinate a bit in order to avoid major issues with pull request merging (although I believe some work will end up having merge issues anyways, don't think we can review and merge all outstanding pull requests). Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] [Geowebcache-devel] GSIP 168, skip beta releases and remove feature freeze
+1. Thanks, Andrea. Kind regards, Ben. On 15/04/18 20:52, Andrea Aime wrote: Hi, as promised here is the GSIP for the release procedure change we've already applied to 2.13.x: https://github.com/geoserver/geoserver/wiki/GSIP-168 Please vote :-) Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Geowebcache-devel mailing list geowebcache-de...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geowebcache-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] CLA assistant
I just submitted a tiny PR for thredds and noticed that they are now using CLA assistant <https://cla-assistant.io/> PR checks to gather contributor agreements. We should consider this. - It is convenient and quick and might reduce the barrier for entry. - Does OSGeo have a policy on contributor agreement collection via third parties? - Is there a mechanism for whitelisting current contributors? CLA assistant is from SAP and licensed under Apache 2.0: https://github.com/cla-assistant/cla-assistant Nice to see that SAP contributes to open source. Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] password in postgres problem
Julio, the "user" and "passwd" used for the connection are provided in the Map supplied to DataStoreFinder (or directly to PostgisNGDataStoreFactory): http://docs.geotools.org/stable/userguide/library/jdbc/datastore.html - What "dbtype" did you supply? - Are gt-jdbc-postgis and its dependencies on the classpath? - What is the value for the "user" key in the connection parameter Map? Kind regards, Ben. On 07/04/18 02:30, jmone...@frm.utn.edu.ar wrote: Hello List, I'm trying to connect from my Java program to my Postgresql 9.2. The Geotools jars I am using aparently try to connect to postgres using the "Geotools" user. The problem is, acoording what i've just read in Postgres forum, in the case sensitive condition in user name. (Postgres is expecting "geotools" username, instead of "Geotools".) My working platform: -Windows 10 -Postgresql 9.2 -Java 8 -Geotools 18 I appreciate if you could help me. Julio. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] GeoTools / GeoServer Meeting 2018-04-03
Attending Ben Caradoc-Davies Jukka Rahkonen Kevin Smith Apologies Torben Barsballe Agenda * GeoServer branding guidelines out of date * Jenkins geotools-master-online-postgis build Actions * Ben:Discuss Jenkins geotools-master-online-postgis build with Torben Previous meeting actions * Andrea: Create Proposal for formatting - google style approach [DONE] * Jody: Call for vote on Units proposal [DONE] * Jody: Submit "State of GeoServer" for FOSS4G 2018 GeoServer branding guidelines are out of date * Discussed on GeoWebCache list * Guidelines refer to OpenGeo * https://github.com/geoserver/geoserver/wiki/GeoServer_BrandingGuide.pdf * Kevin asked user to make a proposal * Permit variant that says “Powered by GeoServer” or “Works with GeoServer”? o Common use case is a script represented by a square icon, possibly defaced in corner to indicate “script” or “plugin” Jenkins geotools-master-online-postgis build The Jenkins geotools-master-online-postgis build has been broken for six months: https://build.geoserver.org/view/geotools/job/geotools-master-online-postgis/556/consoleText After recent fixes, down to three different failures: 1. Exception opening port H2 TCP Server (tcp://172.16.1.87:9092) (port may be in use) 2. PSQLException: ERROR: permission denied to create extension "hstore" Hint: Must be superuser to create this extension. 3. org.postgresql.util.PSQLException: ERROR: type "jsonb" does not exist Solution to (2) is likely to add “create extension hstore;” to database setup script. Action: Ben to discuss with Torben -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday
GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday: https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=4=3=19=30=0=1 -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Jenkins geotools-master-online-postgis broken for six months
https://build.geoserver.org/view/geotools/job/geotools-master-online-postgis/ Builds that are already broken do cause new breakage to be noticed: https://osgeo-org.atlassian.net/browse/GEOT-5981 https://github.com/geotools/geotools/pull/1846 -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Nabble blacklisted by URIBL
Nabble has been blacklisted by URIBL. This likely causes emails containing a Nabble URI to be treated as spam by filters such as SpamAssassin using URIBL. Affected emails might be labelled as "***SPAM***" or silently discarded, depending on recipient's configuration. My request to delist Nabble URIs has just been accepted but it might take a day or two for changes to propagate everywhere. If your emails might be affected and go unanswered, please wait a couple of days and then resend. Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <https://transient.nz/> New Zealand -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
