Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jim Hughes]

Hi all,

I wanted to follow up on this.  I am glad we were able to test the 
GeoTools RC and I think this dicussion has been useful.  At the minute, 
Emilio and I have ways to use either module to do what we want to in 
GeoMesa.  Given that, nothing here should hold up the release, etc.  
Since my PR isn't a great solution (and hence isn't reaching consensus), 
I'm fine closing or having someone else closing it.


Emilio and I had a chance to try out the gt-geojsonstore, and we have a 
few suggestions for improvements:


1.  On the write path, it is our opinion that if you pass in a 
writer/stream, then it shouldn't get closed.  Instead, it'd make sense 
for GeoJSONWriter to implement Flushable.


2.  In terms of dependencies, I'd like to suggest that the module use 
JTS's GeoJsonWriter[*] for writing out geometries instead of jts-jackson 
(which depends on JTS 1.13).


3.  On the read path, there's a tiny bug(**) which prevents the use of 
URLs.


Further, what all should happen around feature ID handling?  Even if the 
GeoJSON spec doesn't cover it, would it make sense for the Writer and 
Reader to handle feature IDs in a way so that they can be written and 
read back in?


Is there a good way to have a consistent FeatureType throughout the 
entire GeoJSONReader?  Having it change feature to feature is somewhat 
unexpected?


Anyhow, I'd love to see GeoTools have a nice SimpleFeatureCollection <-> 
GeoJson set of libraries.  Lemme know how I can help!  Just to ask, is 
the plan to clean up and promotoe the gt-geojsonstore to an extension?


Cheers,

Jim

* 
https://github.com/locationtech/jts/blob/master/modules/io/common/src/main/java/org/locationtech/jts/io/geojson/GeoJsonWriter.java


** 
https://github.com/geotools/geotools/blob/master/modules/unsupported/geojsonstore/src/main/java/org/geotools/data/geojson/GeoJSONDataStoreFactory.java#L147 
should be 'name' not 'file'.


On 3/18/2020 4:18 PM, Jody Garnett wrote:
Ian could we add a utility class to the gt-geojson jar for handling 
this case (parsing geojson in isolation)? The GeoJSONWriter could make 
us of the utility class to avoid duplication.

--
Jody Garnett


On Wed, 18 Mar 2020 at 10:42, Emilio Lahr-Vivaz > wrote:


Hi Ian,

Do you mean using the GeoJSONDataStore? I wasn't actually aware of
it until now, but I think it wouldn't work to use the feature
writer directly as that will write out to a file, correct? We
(GeoMesa) have a command line tool that abstracts around
OutputStream for exporting data in different formats (json, avro,
parquet, csv, etc) and to different places (stdout, file, hdfs, etc).

One small issue that I see is that the writer closes the
OutputStream:

https://github.com/geotools/geotools/blob/master/modules/unsupported/geojsonstore/src/main/java/org/geotools/data/geojson/GeoJSONWriter.java#L160

This makes it slightly tricky for us to use, as for some use cases
we keep writing to the output stream after writing out the geojson.

I've previously looked around for 'best practices' around when to
close an output stream, and haven't really found any. My thought
is that generally the code that creates the stream should be
responsible for closing it. Would you be open to me putting up a
PR to change the writer behavior in that regard?

Thanks,

Emilio

On 3/18/20 12:40 PM, Ian Turton wrote:

Emilio,

could you not just create a FeatureStore or FeatureWriter and
write features out that way as with any other datastore? But
anyway glad that it seems to work for you.

Ian

On Wed, 18 Mar 2020 at 14:00, Emilio Lahr-Vivaz
mailto:elahrvi...@ccri.com>> wrote:

Actually the GeoJSONWriter looks like it would work
perfectly. Our workflow is: start writing the export (i.e.
write the type 'FeatureCollection' and start the 'features'
array); write 0-n features as they come back from various
asynchronous queries; finish writing the export (i.e. write
the closing array bracket and close the FeatureCollection
element). The old gt-geojson module didn't support this pattern.

Thanks,

Emilio

On 3/18/20 9:10 AM, Ian Turton wrote:

I'm not quite sure what the use case for that would be, but
if you would like to propose modifications to GeoJSONWriter
in gt-geojsondatastore I'm happy to consider them.

Ian

On Wed, 18 Mar 2020 at 13:06, Emilio Lahr-Vivaz
mailto:elahrvi...@ccri.com>> wrote:

If that module is unsupported, are there any supported
methods for writing a feature as geojson? For our use
case, we need to write each feature individually, and
not as a feature collection.

Thanks,

Emilio

On 3/18/20 4:00 AM, Andrea Aime wrote:

On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

Ian could we add a utility class to the gt-geojson jar for handling this
case (parsing geojson in isolation)? The GeoJSONWriter could make us of the
utility class to avoid duplication.
--
Jody Garnett


On Wed, 18 Mar 2020 at 10:42, Emilio Lahr-Vivaz  wrote:

> Hi Ian,
>
> Do you mean using the GeoJSONDataStore? I wasn't actually aware of it
> until now, but I think it wouldn't work to use the feature writer directly
> as that will write out to a file, correct? We (GeoMesa) have a command line
> tool that abstracts around OutputStream for exporting data in different
> formats (json, avro, parquet, csv, etc) and to different places (stdout,
> file, hdfs, etc).
>
> One small issue that I see is that the writer closes the OutputStream:
> https://github.com/geotools/geotools/blob/master/modules/unsupported/geojsonstore/src/main/java/org/geotools/data/geojson/GeoJSONWriter.java#L160
>
> This makes it slightly tricky for us to use, as for some use cases we keep
> writing to the output stream after writing out the geojson.
>
> I've previously looked around for 'best practices' around when to close an
> output stream, and haven't really found any. My thought is that generally
> the code that creates the stream should be responsible for closing it.
> Would you be open to me putting up a PR to change the writer behavior in
> that regard?
>
> Thanks,
>
> Emilio
>
> On 3/18/20 12:40 PM, Ian Turton wrote:
>
> Emilio,
>
> could you not just create a FeatureStore or FeatureWriter and write
> features out that way as with any other datastore? But anyway glad that it
> seems to work for you.
>
> Ian
>
> On Wed, 18 Mar 2020 at 14:00, Emilio Lahr-Vivaz 
> wrote:
>
>> Actually the GeoJSONWriter looks like it would work perfectly. Our
>> workflow is: start writing the export (i.e. write the type
>> 'FeatureCollection' and start the 'features' array); write 0-n features as
>> they come back from various asynchronous queries; finish writing the export
>> (i.e. write the closing array bracket and close the FeatureCollection
>> element). The old gt-geojson module didn't support this pattern.
>>
>> Thanks,
>>
>> Emilio
>>
>> On 3/18/20 9:10 AM, Ian Turton wrote:
>>
>> I'm not quite sure what the use case for that would be, but if you would
>> like to propose modifications to GeoJSONWriter in gt-geojsondatastore I'm
>> happy to consider them.
>>
>> Ian
>>
>> On Wed, 18 Mar 2020 at 13:06, Emilio Lahr-Vivaz 
>> wrote:
>>
>>> If that module is unsupported, are there any supported methods for
>>> writing a feature as geojson? For our use case, we need to write each
>>> feature individually, and not as a feature collection.
>>>
>>> Thanks,
>>>
>>> Emilio
>>>
>>> On 3/18/20 4:00 AM, Andrea Aime wrote:
>>>
>>> On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett 
>>> wrote:
>>>
 Since this is an unsupported module should we just break the existing
 API contract in order to be clear about expectations?

>>>
>>> Jody, since this is a unsupported module a quick band aid should do no?
>>> Also consider the module is in bad shape, and Ian has expressed a desire
>>> to level it down to the ground
>>> and replace it with a jackson based machery coming from the geojsonstore
>>> module.
>>>
>>> Since it seems like a goner anyways, clean API should likely be the last
>>> of our concerns?
>>>
>>> Cheers
>>> Andrea
>>> ==
>>>
>>> GeoServer Professional Services from the experts! Visit
>>> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
>>> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
>>> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
>>> http://www.geo-solutions.it http://twitter.com/geosolutions_it
>>> --- *Con
>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE
>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
>>> precisa che ogni circostanza inerente alla presente email (il suo
>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>>> This email is intended only for the person or entity to which it is
>>> addressed and may contain information that is privileged, confidential or
>>> otherwise protected from disclosure. We remind that - as provided by
>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
>>> e-mail or the information herein by anyone other than the intended
>>> recipient is prohibited. If you have received this email by mistake, please
>>> notify us immediately by telephone or e-mail.*
>>>
>>>
>>> ___
>>> GeoTools-Devel mailing 
>>> listGeoTools-Devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>>
>>> 

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Emilio Lahr-Vivaz]

Hi Ian,

Do you mean using the GeoJSONDataStore? I wasn't actually aware of it 
until now, but I think it wouldn't work to use the feature writer 
directly as that will write out to a file, correct? We (GeoMesa) have a 
command line tool that abstracts around OutputStream for exporting data 
in different formats (json, avro, parquet, csv, etc) and to different 
places (stdout, file, hdfs, etc).


One small issue that I see is that the writer closes the OutputStream: 
https://github.com/geotools/geotools/blob/master/modules/unsupported/geojsonstore/src/main/java/org/geotools/data/geojson/GeoJSONWriter.java#L160


This makes it slightly tricky for us to use, as for some use cases we 
keep writing to the output stream after writing out the geojson.


I've previously looked around for 'best practices' around when to close 
an output stream, and haven't really found any. My thought is that 
generally the code that creates the stream should be responsible for 
closing it. Would you be open to me putting up a PR to change the writer 
behavior in that regard?


Thanks,

Emilio

On 3/18/20 12:40 PM, Ian Turton wrote:

Emilio,

could you not just create a FeatureStore or FeatureWriter and write 
features out that way as with any other datastore? But anyway glad 
that it seems to work for you.


Ian

On Wed, 18 Mar 2020 at 14:00, Emilio Lahr-Vivaz > wrote:


Actually the GeoJSONWriter looks like it would work perfectly. Our
workflow is: start writing the export (i.e. write the type
'FeatureCollection' and start the 'features' array); write 0-n
features as they come back from various asynchronous queries;
finish writing the export (i.e. write the closing array bracket
and close the FeatureCollection element). The old gt-geojson
module didn't support this pattern.

Thanks,

Emilio

On 3/18/20 9:10 AM, Ian Turton wrote:

I'm not quite sure what the use case for that would be, but if
you would like to propose modifications to GeoJSONWriter in
gt-geojsondatastore I'm happy to consider them.

Ian

On Wed, 18 Mar 2020 at 13:06, Emilio Lahr-Vivaz
mailto:elahrvi...@ccri.com>> wrote:

If that module is unsupported, are there any supported
methods for writing a feature as geojson? For our use case,
we need to write each feature individually, and not as a
feature collection.

Thanks,

Emilio

On 3/18/20 4:00 AM, Andrea Aime wrote:

On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett
mailto:jody.garn...@gmail.com>> wrote:

Since this is an unsupported module should we just break
the existing API contract in order to be clear about
expectations?


Jody, since this is a unsupported module a quick band aid
should do no?
Also consider the module is in bad shape, and Ian has
expressed a desire to level it down to the ground
and replace it with a jackson based machery coming from the
geojsonstore module.

Since it seems like a goner anyways, clean API should likely
be the last of our concerns?

Cheers
Andrea
==

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information. == Ing. Andrea
Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di
Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313
fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
--- /Con
riferimento alla normativa sul trattamento dei dati
personali (Reg. UE 2016/679 - Regolamento generale sulla
protezione dei dati “GDPR”), si precisa che ogni circostanza
inerente alla presente email (il suo contenuto, gli
eventuali allegati, etc.) è un dato la cui conoscenza è
riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è
tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email
is intended only for the person or entity to which it is
addressed and may contain information that is privileged,
confidential or otherwise protected from disclosure. We
remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the
information herein by anyone other than the intended
recipient is prohibited. If you have received this email by
mistake, please notify us immediately by telephone or e-mail./



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net  

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Ian Turton]

Emilio,

could you not just create a FeatureStore or FeatureWriter and write
features out that way as with any other datastore? But anyway glad that it
seems to work for you.

Ian

On Wed, 18 Mar 2020 at 14:00, Emilio Lahr-Vivaz  wrote:

> Actually the GeoJSONWriter looks like it would work perfectly. Our
> workflow is: start writing the export (i.e. write the type
> 'FeatureCollection' and start the 'features' array); write 0-n features as
> they come back from various asynchronous queries; finish writing the export
> (i.e. write the closing array bracket and close the FeatureCollection
> element). The old gt-geojson module didn't support this pattern.
>
> Thanks,
>
> Emilio
>
> On 3/18/20 9:10 AM, Ian Turton wrote:
>
> I'm not quite sure what the use case for that would be, but if you would
> like to propose modifications to GeoJSONWriter in gt-geojsondatastore I'm
> happy to consider them.
>
> Ian
>
> On Wed, 18 Mar 2020 at 13:06, Emilio Lahr-Vivaz 
> wrote:
>
>> If that module is unsupported, are there any supported methods for
>> writing a feature as geojson? For our use case, we need to write each
>> feature individually, and not as a feature collection.
>>
>> Thanks,
>>
>> Emilio
>>
>> On 3/18/20 4:00 AM, Andrea Aime wrote:
>>
>> On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett 
>> wrote:
>>
>>> Since this is an unsupported module should we just break the existing
>>> API contract in order to be clear about expectations?
>>>
>>
>> Jody, since this is a unsupported module a quick band aid should do no?
>> Also consider the module is in bad shape, and Ian has expressed a desire
>> to level it down to the ground
>> and replace it with a jackson based machery coming from the geojsonstore
>> module.
>>
>> Since it seems like a goner anyways, clean API should likely be the last
>> of our concerns?
>>
>> Cheers
>> Andrea
>> ==
>>
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
>> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
>> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
>> http://www.geo-solutions.it http://twitter.com/geosolutions_it
>> --- *Con riferimento
>> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
>> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
>> circostanza inerente alla presente email (il suo contenuto, gli eventuali
>> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
>> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
>> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
>> sarei comunque grato se potesse darmene notizia. This email is intended
>> only for the person or entity to which it is addressed and may contain
>> information that is privileged, confidential or otherwise protected from
>> disclosure. We remind that - as provided by European Regulation 2016/679
>> “GDPR” - copying, dissemination or use of this e-mail or the information
>> herein by anyone other than the intended recipient is prohibited. If you
>> have received this email by mistake, please notify us immediately by
>> telephone or e-mail.*
>>
>>
>> ___
>> GeoTools-Devel mailing 
>> listGeoTools-Devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>> ___
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>
>
> --
> Ian Turton
>
>
>

-- 
Ian Turton
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Emilio Lahr-Vivaz]

Actually the GeoJSONWriter looks like it would work perfectly. Our 
workflow is: start writing the export (i.e. write the type 
'FeatureCollection' and start the 'features' array); write 0-n features 
as they come back from various asynchronous queries; finish writing the 
export (i.e. write the closing array bracket and close the 
FeatureCollection element). The old gt-geojson module didn't support 
this pattern.


Thanks,

Emilio

On 3/18/20 9:10 AM, Ian Turton wrote:
I'm not quite sure what the use case for that would be, but if you 
would like to propose modifications to GeoJSONWriter in 
gt-geojsondatastore I'm happy to consider them.


Ian

On Wed, 18 Mar 2020 at 13:06, Emilio Lahr-Vivaz > wrote:


If that module is unsupported, are there any supported methods for
writing a feature as geojson? For our use case, we need to write
each feature individually, and not as a feature collection.

Thanks,

Emilio

On 3/18/20 4:00 AM, Andrea Aime wrote:

On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett
mailto:jody.garn...@gmail.com>> wrote:

Since this is an unsupported module should we just break the
existing API contract in order to be clear about expectations?


Jody, since this is a unsupported module a quick band aid should
do no?
Also consider the module is in bad shape, and Ian has expressed a
desire to level it down to the ground
and replace it with a jackson based machery coming from the
geojsonstore module.

Since it seems like a goner anyways, clean API should likely be
the last of our concerns?

Cheers
Andrea
==

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A
55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272
mob: +39 339 8844549 http://www.geo-solutions.it
http://twitter.com/geosolutions_it
--- /Con
riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei
dati “GDPR”), si precisa che ogni circostanza inerente alla
presente email (il suo contenuto, gli eventuali allegati, etc.) è
un dato la cui conoscenza è riservata al/i solo/i destinatario/i
indicati dallo scrivente. Se il messaggio Le è giunto per errore,
è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is
intended only for the person or entity to which it is addressed
and may contain information that is privileged, confidential or
otherwise protected from disclosure. We remind that - as provided
by European Regulation 2016/679 “GDPR” - copying, dissemination
or use of this e-mail or the information herein by anyone other
than the intended recipient is prohibited. If you have received
this email by mistake, please notify us immediately by telephone
or e-mail./



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net  

https://lists.sourceforge.net/lists/listinfo/geotools-devel


___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/geotools-devel



--
Ian Turton


___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Ian Turton]

Yes, that is correct.

Ian

On Wed, 18 Mar 2020 at 13:13, Andrea Aime 
wrote:

> On Wed, Mar 18, 2020 at 2:12 PM Ian Turton  wrote:
>
>> I'm not quite sure what the use case for that would be, but if you would
>> like to propose modifications to GeoJSONWriter in gt-geojsondatastore I'm
>> happy to consider them.
>>
>
> Just to match my previous answer and clarify... gt-geojsondatastore is
> also unsupported right?
> The critical difference being that it has you behind it, while gt-geojson
> is completely abandoned?
>
> Cheers
> Andrea
>
> ==
>
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> --- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>


-- 
Ian Turton
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Andrea Aime]

On Wed, Mar 18, 2020 at 2:12 PM Ian Turton  wrote:

> I'm not quite sure what the use case for that would be, but if you would
> like to propose modifications to GeoJSONWriter in gt-geojsondatastore I'm
> happy to consider them.
>

Just to match my previous answer and clarify... gt-geojsondatastore is also
unsupported right?
The critical difference being that it has you behind it, while gt-geojson
is completely abandoned?

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Ian Turton]

I'm not quite sure what the use case for that would be, but if you would
like to propose modifications to GeoJSONWriter in gt-geojsondatastore I'm
happy to consider them.

Ian

On Wed, 18 Mar 2020 at 13:06, Emilio Lahr-Vivaz  wrote:

> If that module is unsupported, are there any supported methods for writing
> a feature as geojson? For our use case, we need to write each feature
> individually, and not as a feature collection.
>
> Thanks,
>
> Emilio
>
> On 3/18/20 4:00 AM, Andrea Aime wrote:
>
> On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett 
> wrote:
>
>> Since this is an unsupported module should we just break the existing API
>> contract in order to be clear about expectations?
>>
>
> Jody, since this is a unsupported module a quick band aid should do no?
> Also consider the module is in bad shape, and Ian has expressed a desire
> to level it down to the ground
> and replace it with a jackson based machery coming from the geojsonstore
> module.
>
> Since it seems like a goner anyways, clean API should likely be the last
> of our concerns?
>
> Cheers
> Andrea
> ==
>
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> --- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>
>
> ___
> GeoTools-Devel mailing 
> listGeoTools-Devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>


-- 
Ian Turton
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Andrea Aime]

On Wed, Mar 18, 2020 at 2:07 PM Emilio Lahr-Vivaz 
wrote:

> If that module is unsupported, are there any supported methods for writing
> a feature as geojson? For our use case, we need to write each feature
> individually, and not as a feature collection.
>

None I'm afraid. GeoServer writes JSON using some very old code based on
json-lib,
and the gt-geojson module only in some parts, like WPS (mostly because
parsing was also needed).

Cheers
Andrea

-- 

Regards, Andrea Aime == GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Emilio Lahr-Vivaz]

If that module is unsupported, are there any supported methods for 
writing a feature as geojson? For our use case, we need to write each 
feature individually, and not as a feature collection.


Thanks,

Emilio

On 3/18/20 4:00 AM, Andrea Aime wrote:
On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett > wrote:


Since this is an unsupported module should we just break the
existing API contract in order to be clear about expectations?


Jody, since this is a unsupported module a quick band aid should do no?
Also consider the module is in bad shape, and Ian has expressed a 
desire to level it down to the ground
and replace it with a jackson based machery coming from the 
geojsonstore module.


Since it seems like a goner anyways, clean API should likely be the 
last of our concerns?


Cheers
Andrea
==

GeoServer Professional Services from the experts! Visit 
http://goo.gl/it488V for more information. == Ing. Andrea Aime 
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 
55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: 
+39 339 8844549 http://www.geo-solutions.it 
http://twitter.com/geosolutions_it 
--- /Con 
riferimento alla normativa sul trattamento dei dati personali (Reg. UE 
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si 
precisa che ogni circostanza inerente alla presente email (il suo 
contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è 
riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il 
messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra 
operazione è illecita. Le sarei comunque grato se potesse darmene 
notizia. This email is intended only for the person or entity to which 
it is addressed and may contain information that is privileged, 
confidential or otherwise protected from disclosure. We remind that - 
as provided by European Regulation 2016/679 “GDPR” - copying, 
dissemination or use of this e-mail or the information herein by 
anyone other than the intended recipient is prohibited. If you have 
received this email by mistake, please notify us immediately by 
telephone or e-mail./




___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Andrea Aime]

On Wed, Mar 18, 2020 at 12:03 AM Jody Garnett 
wrote:

> Since this is an unsupported module should we just break the existing API
> contract in order to be clear about expectations?
>

Jody, since this is a unsupported module a quick band aid should do no?
Also consider the module is in bad shape, and Ian has expressed a desire to
level it down to the ground
and replace it with a jackson based machery coming from the geojsonstore
module.

Since it seems like a goner anyways, clean API should likely be the last of
our concerns?

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

Yeah that is a lot of hard work from Andrea (the checks benefit from lots
of QA checks being performed).

Can you just make a new method?

/**
 * 
 * @param output output stream to be used for feature content
 * @param autoclose close writer after use
 * @return a writer
 */
public static Writer toWriter(OuputStreamWriter output, boolean autoclose);
--
Jody Garnett


On Tue, 17 Mar 2020 at 16:44, Jim Hughes  wrote:

> Hi Jody,
>
> This is more or less the approach that I described above.  Since I was
> encouraged to toss up a PR for that approach, I put one together.  (By the
> way, it was a good exercise.  I really like the checkboxes and the new
> improvements to the CI hooks!  Those were awesome.  I missed the formatting
> on the first pass, but managed to address those issues easily enough.  All
> that was very, very easy to use...)
>
> The API as-is allows for implementation details to leak and be confusing.
> While I was putting up the PR, I checked to see if GeoWebCache or GeoServer
> use this capability and I don't think they do.  Overall, if this doesn't
> get addressed, I have a suitable workaround.  It may be worth it for all to
> move on.  (I did enjoy the new and improved PR process.  That was great!)
>
> Cheers,
>
> Jim
> On 3/17/2020 7:02 PM, Jody Garnett wrote:
>
> I am not quite sure what I am seeing in this PR.
>
> I was going to ask you to add a note to the javadoc explaining the API
> contract (ie that we trust users to close the provided writer). But then I
> got confused, if I am reading the code correctly, the other writers
> returned (for example BufferedWriter) will close end up the underlying
> stream.
>
> This results in an inconsistent API contract... which I am not wild about.
>
> Since this is an unsupported module should we just break the existing API
> contract in order to be clear about expectations?
> --
> Jody Garnett
>
>
> On Tue, 17 Mar 2020 at 15:33, Jim Hughes  wrote:
>
>> Hi all,
>>
>> Here's a PR for the discussed approach:
>> https://github.com/geotools/geotools/pull/2839
>>
>> I'm not wild about it, but it does fix the 'regression' / change I saw.
>> I think the idea of the method GeoJSONUtil.toWriter(Object output) is a bit
>> too broad, and that means that any solution which keeps the API in place
>> will be a little silly looking.
>>
>> If anyone doesn't like it, the identified approach can readily be used
>> downstream in GeoMesa.
>>
>> Other than that, the GeoTools RC looks pretty reasonable.  I'm hoping
>> that we can kick the tires on the GeoServer RC, but that's uncertain.
>>
>> Cheers,
>>
>> Jim
>> On 3/13/2020 3:34 AM, Andrea Aime wrote:
>>
>> On Thu, Mar 12, 2020 at 10:11 PM Jim Hughes  wrote:
>>
>>> Hi Andrea,
>>>
>>> Ah!  The context that some of the Objects need closing and others do not
>>> helps clarify things.
>>>
>>> I just wrote a client side version of such a wrapper to see if it'd work
>>> (it does).  Sounds like an amendment to 'toWriter' to have a no-op-close
>>> wrapper around the 1) BufferedWriter, 2) Writer, and 3) OutputStream would
>>> fit the bill?
>>>
>>> If so, I can try to put something together.
>>>
>> Please go ahead!
>>
>> Cheers
>> Andrea
>> ==
>>
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
>> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
>> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
>> http://www.geo-solutions.it http://twitter.com/geosolutions_it
>> --- *Con riferimento
>> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
>> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
>> circostanza inerente alla presente email (il suo contenuto, gli eventuali
>> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
>> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
>> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
>> sarei comunque grato se potesse darmene notizia. This email is intended
>> only for the person or entity to which it is addressed and may contain
>> information that is privileged, confidential or otherwise protected from
>> disclosure. We remind that - as provided by European Regulation 2016/679
>> “GDPR” - copying, dissemination or use of this e-mail or the information
>> herein by anyone other than the intended recipient is prohibited. If you
>> have received this email by mistake, please notify us immediately by
>> telephone or e-mail.*
>>
>>
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jim Hughes]

Hi Jody,

This is more or less the approach that I described above.  Since I was 
encouraged to toss up a PR for that approach, I put one together.  (By 
the way, it was a good exercise.  I really like the checkboxes and the 
new improvements to the CI hooks!  Those were awesome.  I missed the 
formatting on the first pass, but managed to address those issues easily 
enough.  All that was very, very easy to use...)


The API as-is allows for implementation details to leak and be 
confusing.  While I was putting up the PR, I checked to see if 
GeoWebCache or GeoServer use this capability and I don't think they do.  
Overall, if this doesn't get addressed, I have a suitable workaround.  
It may be worth it for all to move on.  (I did enjoy the new and 
improved PR process.  That was great!)


Cheers,

Jim

On 3/17/2020 7:02 PM, Jody Garnett wrote:

I am not quite sure what I am seeing in this PR.

I was going to ask you to add a note to the javadoc explaining the API 
contract (ie that we trust users to close the provided writer). But 
then I got confused, if I am reading the code correctly, the other 
writers returned (for example BufferedWriter) will close end up the 
underlying stream.


This results in an inconsistent API contract... which I am not wild about.

Since this is an unsupported module should we just break the existing 
API contract in order to be clear about expectations?

--
Jody Garnett


On Tue, 17 Mar 2020 at 15:33, Jim Hughes > wrote:


Hi all,

Here's a PR for the discussed approach:
https://github.com/geotools/geotools/pull/2839

I'm not wild about it, but it does fix the 'regression' / change I
saw.  I think the idea of the method GeoJSONUtil.toWriter(Object
output) is a bit too broad, and that means that any solution which
keeps the API in place will be a little silly looking.

If anyone doesn't like it, the identified approach can readily be
used downstream in GeoMesa.

Other than that, the GeoTools RC looks pretty reasonable.  I'm
hoping that we can kick the tires on the GeoServer RC, but that's
uncertain.

Cheers,

Jim

On 3/13/2020 3:34 AM, Andrea Aime wrote:

On Thu, Mar 12, 2020 at 10:11 PM Jim Hughes mailto:jhug...@ccri.com>> wrote:

Hi Andrea,

Ah!  The context that some of the Objects need closing and
others do not helps clarify things.

I just wrote a client side version of such a wrapper to see
if it'd work (it does).  Sounds like an amendment to
'toWriter' to have a no-op-close wrapper around the 1)
BufferedWriter, 2) Writer, and 3) OutputStream would fit the
bill?

If so, I can try to put something together.

Please go ahead!

Cheers
Andrea
==

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A
55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272
mob: +39 339 8844549 http://www.geo-solutions.it
http://twitter.com/geosolutions_it
--- /Con
riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei
dati “GDPR”), si precisa che ogni circostanza inerente alla
presente email (il suo contenuto, gli eventuali allegati, etc.) è
un dato la cui conoscenza è riservata al/i solo/i destinatario/i
indicati dallo scrivente. Se il messaggio Le è giunto per errore,
è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is
intended only for the person or entity to which it is addressed
and may contain information that is privileged, confidential or
otherwise protected from disclosure. We remind that - as provided
by European Regulation 2016/679 “GDPR” - copying, dissemination
or use of this e-mail or the information herein by anyone other
than the intended recipient is prohibited. If you have received
this email by mistake, please notify us immediately by telephone
or e-mail./

___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

I am not quite sure what I am seeing in this PR.

I was going to ask you to add a note to the javadoc explaining the API
contract (ie that we trust users to close the provided writer). But then I
got confused, if I am reading the code correctly, the other writers
returned (for example BufferedWriter) will close end up the underlying
stream.

This results in an inconsistent API contract... which I am not wild about.

Since this is an unsupported module should we just break the existing API
contract in order to be clear about expectations?
--
Jody Garnett


On Tue, 17 Mar 2020 at 15:33, Jim Hughes  wrote:

> Hi all,
>
> Here's a PR for the discussed approach:
> https://github.com/geotools/geotools/pull/2839
>
> I'm not wild about it, but it does fix the 'regression' / change I saw.  I
> think the idea of the method GeoJSONUtil.toWriter(Object output) is a bit
> too broad, and that means that any solution which keeps the API in place
> will be a little silly looking.
>
> If anyone doesn't like it, the identified approach can readily be used
> downstream in GeoMesa.
>
> Other than that, the GeoTools RC looks pretty reasonable.  I'm hoping that
> we can kick the tires on the GeoServer RC, but that's uncertain.
>
> Cheers,
>
> Jim
> On 3/13/2020 3:34 AM, Andrea Aime wrote:
>
> On Thu, Mar 12, 2020 at 10:11 PM Jim Hughes  wrote:
>
>> Hi Andrea,
>>
>> Ah!  The context that some of the Objects need closing and others do not
>> helps clarify things.
>>
>> I just wrote a client side version of such a wrapper to see if it'd work
>> (it does).  Sounds like an amendment to 'toWriter' to have a no-op-close
>> wrapper around the 1) BufferedWriter, 2) Writer, and 3) OutputStream would
>> fit the bill?
>>
>> If so, I can try to put something together.
>>
> Please go ahead!
>
> Cheers
> Andrea
> ==
>
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> --- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>
>
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jim Hughes]

Hi all,

Here's a PR for the discussed approach: 
https://github.com/geotools/geotools/pull/2839


I'm not wild about it, but it does fix the 'regression' / change I saw.  
I think the idea of the method GeoJSONUtil.toWriter(Object output) is a 
bit too broad, and that means that any solution which keeps the API in 
place will be a little silly looking.


If anyone doesn't like it, the identified approach can readily be used 
downstream in GeoMesa.


Other than that, the GeoTools RC looks pretty reasonable.  I'm hoping 
that we can kick the tires on the GeoServer RC, but that's uncertain.


Cheers,

Jim

On 3/13/2020 3:34 AM, Andrea Aime wrote:
On Thu, Mar 12, 2020 at 10:11 PM Jim Hughes > wrote:


Hi Andrea,

Ah!  The context that some of the Objects need closing and others
do not helps clarify things.

I just wrote a client side version of such a wrapper to see if
it'd work (it does).  Sounds like an amendment to 'toWriter' to
have a no-op-close wrapper around the 1) BufferedWriter, 2)
Writer, and 3) OutputStream would fit the bill?

If so, I can try to put something together.

Please go ahead!

Cheers
Andrea
==

GeoServer Professional Services from the experts! Visit 
http://goo.gl/it488V for more information. == Ing. Andrea Aime 
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 
55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: 
+39 339 8844549 http://www.geo-solutions.it 
http://twitter.com/geosolutions_it 
--- /Con 
riferimento alla normativa sul trattamento dei dati personali (Reg. UE 
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si 
precisa che ogni circostanza inerente alla presente email (il suo 
contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è 
riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il 
messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra 
operazione è illecita. Le sarei comunque grato se potesse darmene 
notizia. This email is intended only for the person or entity to which 
it is addressed and may contain information that is privileged, 
confidential or otherwise protected from disclosure. We remind that - 
as provided by European Regulation 2016/679 “GDPR” - copying, 
dissemination or use of this e-mail or the information herein by 
anyone other than the intended recipient is prohibited. If you have 
received this email by mistake, please notify us immediately by 
telephone or e-mail./


___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Andrea Aime]

On Thu, Mar 12, 2020 at 10:11 PM Jim Hughes  wrote:

> Hi Andrea,
>
> Ah!  The context that some of the Objects need closing and others do not
> helps clarify things.
>
> I just wrote a client side version of such a wrapper to see if it'd work
> (it does).  Sounds like an amendment to 'toWriter' to have a no-op-close
> wrapper around the 1) BufferedWriter, 2) Writer, and 3) OutputStream would
> fit the bill?
>
> If so, I can try to put something together.
>
Please go ahead!

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jim Hughes]

Hi Andrea,

Ah!  The context that some of the Objects need closing and others do not 
helps clarify things.


I just wrote a client side version of such a wrapper to see if it'd work 
(it does).  Sounds like an amendment to 'toWriter' to have a no-op-close 
wrapper around the 1) BufferedWriter, 2) Writer, and 3) OutputStream 
would fit the bill?


If so, I can try to put something together.

Cheers,

Jim

On 3/12/20 4:33 PM, Andrea Aime wrote:

Hi,
the API is problematic because it happens to create a Writer out of 
Object, using this method:

https://github.com/geotools/geotools/blob/master/modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java#L117

Some of the "things" passed in need closing (the FileWriter created 
out of file), others do not.
Maybe someone can write a Writer wrapper that does not delegate the 
close() method down,

and use it for the sources that happen to already be writer or a stream?

Cheers
Andrea



On Thu, Mar 12, 2020 at 8:47 PM Jim Hughes > wrote:


From API point-of-view, that makes sense.  From a code
point-of-view, there's a writer created on line 274:

https://github.com/geotools/geotools/blob/master/modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java#L274-L278...
that writer isn't returned, so as-is, the code maybe doing
something sensible.

Thoughts?


On 3/12/20 3:39 PM, Jody Garnett wrote:

Good timing on testing, it seems rough closing the writer after
one feature? I would update the javadoc to be clear about the API
contract and leave the writer open.

On Thu, Mar 12, 2020 at 11:50 AM Jim Hughes mailto:jhug...@ccri.com>> wrote:

Hi all,

As a happy coincidence, I was able to test the GeoTools RC
with GeoMesa.  I did hit an issue or two.

The first one is that GeoMesa uses GeoTools library code to
write out GeoJson.  Calls to
FeatureJSON.writeFeature(SimpleFeature feature, Object
output) use GeoJSONUtil.encode(String, Writer).

This encode method was changed[1] to use the
try-with-resources pattern, and that means the writer we pass
in gets closed.  This messes up that previous wrote out GeoJSON.

I see two options:
A.  This change is a 'bug' and we chat through a GeoTools
update.
B.  This change is an improvement, and I should update
GeoMesa.  (Maybe to use "new
FeatureEncoder(feature).toJSONString()" along with managing
the writes to outputstreams, etc.)

Thoughts?

Jim

1.

https://github.com/geotools/geotools/commit/8b5d6279474c9dc8962d279a884e508ab670ee3c#diff-208951a6b5feb5f96a890c79c9846389
2. Example GeoMesa code:

https://github.com/locationtech/geomesa/blob/master/geomesa-tools/src/main/scala/org/locationtech/geomesa/tools/export/formats/GeoJsonExporter.scala

On 3/12/20 12:53 AM, Jody Garnett wrote:

23-RC is deployed and on SF, will work on blog post while
waiting for future builds.
--
Jody Garnett


On Wed, 11 Mar 2020 at 07:25, Jody Garnett
mailto:jody.garn...@gmail.com>> wrote:

Thanks for letting me know, speed seems good from this
end. Thanks for building from the tag, that may have to
do for timezone testing.
I will start geowebcache release cycle at end-of-day.
--
Jody Garnett


On Wed, 11 Mar 2020 at 02:17, Andrea Aime
mailto:andrea.a...@geo-solutions.it>> wrote:

Hi Jody,
I'm having trouble connecting to anything that's in
the US, getting to the build server is very slow,
downloading the package times out instead.
I've tried building out of github checkouts (that
one works) but it still gets stuck trying to download
from the boundless repository...

Will try again later, hopefully it's a short lived
situation

Cheers
Andrea


On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett
mailto:jody.garn...@gmail.com>> wrote:

Build is once again complete, please test
artifacts and report back:
-

https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/

Andrea if testing is successful please proceed
with geowebcache, or I will catch it tomorrow
after work.
--
Jody Garnett
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jim Hughes]

I'm hitting issues with the looking up EPSG codes in with 
FilterFactory(2).bbox.  E.g. things like


ff.bbox("geom",49.0,79.0,51.0,80.0,"EPSG:4326")

Are throwing errors like:

java.lang.RuntimeException: Failed to setup bbox SRS
Caused by: org.opengis.referencing.FactoryException: Type "EPSG" is unknow in 
this context.
Caused by: java.text.ParseException: Type "EPSG" is unknow in this context.

I didn't mention it in the first email 'cause I'm having a little trouble 
debugging it and I'm trying to make sure I'm not missing something obvious like 
gt-epsg-* jars.

At this point, I've looked a little, and I'm not seeing anything obvious.  If 
folks have really quick suggestions, I'd appreciate it.  That said, I'll keep 
digging.

Cheers,

Jim


On 3/12/20 4:34 PM, Andrea Aime wrote:
On Thu, Mar 12, 2020 at 7:51 PM Jim Hughes > wrote:


Hi all,

As a happy coincidence, I was able to test the GeoTools RC with
GeoMesa.  I did hit an issue or two.


Hum... or two? What's the second?

Cheers
Andrea
==

GeoServer Professional Services from the experts! Visit 
http://goo.gl/it488V for more information. == Ing. Andrea Aime 
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 
55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: 
+39 339 8844549 http://www.geo-solutions.it 
http://twitter.com/geosolutions_it 
--- /Con 
riferimento alla normativa sul trattamento dei dati personali (Reg. UE 
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si 
precisa che ogni circostanza inerente alla presente email (il suo 
contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è 
riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il 
messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra 
operazione è illecita. Le sarei comunque grato se potesse darmene 
notizia. This email is intended only for the person or entity to which 
it is addressed and may contain information that is privileged, 
confidential or otherwise protected from disclosure. We remind that - 
as provided by European Regulation 2016/679 “GDPR” - copying, 
dissemination or use of this e-mail or the information herein by 
anyone other than the intended recipient is prohibited. If you have 
received this email by mistake, please notify us immediately by 
telephone or e-mail./




___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Andrea Aime]

Hi,
the API is problematic because it happens to create a Writer out of Object,
using this method:
https://github.com/geotools/geotools/blob/master/modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java#L117

Some of the "things" passed in need closing (the FileWriter created out of
file), others do not.
Maybe someone can write a Writer wrapper that does not delegate the close()
method down,
and use it for the sources that happen to already be writer or a stream?

Cheers
Andrea



On Thu, Mar 12, 2020 at 8:47 PM Jim Hughes  wrote:

> From API point-of-view, that makes sense.  From a code point-of-view,
> there's a writer created on line 274:
> https://github.com/geotools/geotools/blob/master/modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java#L274-L278...
> that writer isn't returned, so as-is, the code maybe doing something
> sensible.
>
> Thoughts?
>
> On 3/12/20 3:39 PM, Jody Garnett wrote:
>
> Good timing on testing, it seems rough closing the writer after one
> feature? I would update the javadoc to be clear about the API contract and
> leave the writer open.
>
> On Thu, Mar 12, 2020 at 11:50 AM Jim Hughes  wrote:
>
>> Hi all,
>>
>> As a happy coincidence, I was able to test the GeoTools RC with GeoMesa.
>> I did hit an issue or two.
>>
>> The first one is that GeoMesa uses GeoTools library code to write out
>> GeoJson.  Calls to FeatureJSON.writeFeature(SimpleFeature feature, Object
>> output) use GeoJSONUtil.encode(String, Writer).
>>
>> This encode method was changed[1] to use the try-with-resources pattern,
>> and that means the writer we pass in gets closed.  This messes up that
>> previous wrote out GeoJSON.
>>
>> I see two options:
>> A.  This change is a 'bug' and we chat through a GeoTools update.
>> B.  This change is an improvement, and I should update GeoMesa.  (Maybe
>> to use "new FeatureEncoder(feature).toJSONString()" along with managing the
>> writes to outputstreams, etc.)
>>
>> Thoughts?
>>
>> Jim
>>
>> 1.
>> https://github.com/geotools/geotools/commit/8b5d6279474c9dc8962d279a884e508ab670ee3c#diff-208951a6b5feb5f96a890c79c9846389
>> 2. Example GeoMesa code:
>> https://github.com/locationtech/geomesa/blob/master/geomesa-tools/src/main/scala/org/locationtech/geomesa/tools/export/formats/GeoJsonExporter.scala
>>
>> On 3/12/20 12:53 AM, Jody Garnett wrote:
>>
>> 23-RC is deployed and on SF, will work on blog post while waiting for
>> future builds.
>> --
>> Jody Garnett
>>
>>
>> On Wed, 11 Mar 2020 at 07:25, Jody Garnett 
>> wrote:
>>
>>> Thanks for letting me know, speed seems good from this end. Thanks for
>>> building from the tag, that may have to do for timezone testing.
>>> I will start geowebcache release cycle at end-of-day.
>>> --
>>> Jody Garnett
>>>
>>>
>>> On Wed, 11 Mar 2020 at 02:17, Andrea Aime 
>>> wrote:
>>>
 Hi Jody,
 I'm having trouble connecting to anything that's in the US, getting to
 the build server is very slow,
 downloading the package times out instead.
 I've tried building out of github checkouts (that one works) but it
 still gets stuck trying to download
 from the boundless repository...

 Will try again later, hopefully it's a short lived situation

 Cheers
 Andrea


 On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett 
 wrote:

> Build is once again complete, please test artifacts and report back:
> -
> https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/
>
> Andrea if testing is successful please proceed with geowebcache, or I
> will catch it tomorrow after work.
> --
> Jody Garnett
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>


 --

 Regards, Andrea Aime == GeoServer Professional Services from the
 experts! Visit http://goo.gl/it488V for more information. == Ing.
 Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di
 Montramito 3/A 55054 Massarosa
 
 (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
 http://www.geo-solutions.it http://twitter.com/geosolutions_it
 --- *Con
 riferimento alla normativa sul trattamento dei dati personali (Reg. UE
 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
 precisa che ogni circostanza inerente alla presente email (il suo
 contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
 riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
 messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
 operazione è illecita. Le sarei comunque grato se potesse 

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Andrea Aime]

On Thu, Mar 12, 2020 at 7:51 PM Jim Hughes  wrote:

> Hi all,
>
> As a happy coincidence, I was able to test the GeoTools RC with GeoMesa.
> I did hit an issue or two.
>

Hum... or two? What's the second?

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jim Hughes]

From API point-of-view, that makes sense.  From a code point-of-view, 
there's a writer created on line 274: 
https://github.com/geotools/geotools/blob/master/modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java#L274-L278... 
that writer isn't returned, so as-is, the code maybe doing something 
sensible.


Thoughts?


On 3/12/20 3:39 PM, Jody Garnett wrote:
Good timing on testing, it seems rough closing the writer after one 
feature? I would update the javadoc to be clear about the API contract 
and leave the writer open.


On Thu, Mar 12, 2020 at 11:50 AM Jim Hughes > wrote:


Hi all,

As a happy coincidence, I was able to test the GeoTools RC with
GeoMesa.  I did hit an issue or two.

The first one is that GeoMesa uses GeoTools library code to write
out GeoJson.  Calls to FeatureJSON.writeFeature(SimpleFeature
feature, Object output) use GeoJSONUtil.encode(String, Writer).

This encode method was changed[1] to use the try-with-resources
pattern, and that means the writer we pass in gets closed.  This
messes up that previous wrote out GeoJSON.

I see two options:
A.  This change is a 'bug' and we chat through a GeoTools update.
B.  This change is an improvement, and I should update GeoMesa. 
(Maybe to use "new FeatureEncoder(feature).toJSONString()" along
with managing the writes to outputstreams, etc.)

Thoughts?

Jim

1.

https://github.com/geotools/geotools/commit/8b5d6279474c9dc8962d279a884e508ab670ee3c#diff-208951a6b5feb5f96a890c79c9846389
2. Example GeoMesa code:

https://github.com/locationtech/geomesa/blob/master/geomesa-tools/src/main/scala/org/locationtech/geomesa/tools/export/formats/GeoJsonExporter.scala

On 3/12/20 12:53 AM, Jody Garnett wrote:

23-RC is deployed and on SF, will work on blog post while waiting
for future builds.
--
Jody Garnett


On Wed, 11 Mar 2020 at 07:25, Jody Garnett
mailto:jody.garn...@gmail.com>> wrote:

Thanks for letting me know, speed seems good from this end.
Thanks for building from the tag, that may have to do for
timezone testing.
I will start geowebcache release cycle at end-of-day.
--
Jody Garnett


On Wed, 11 Mar 2020 at 02:17, Andrea Aime
mailto:andrea.a...@geo-solutions.it>> wrote:

Hi Jody,
I'm having trouble connecting to anything that's in the
US, getting to the build server is very slow,
downloading the package times out instead.
I've tried building out of github checkouts (that one
works) but it still gets stuck trying to download
from the boundless repository...

Will try again later, hopefully it's a short lived situation

Cheers
Andrea


On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett
mailto:jody.garn...@gmail.com>>
wrote:

Build is once again complete, please test artifacts
and report back:
-

https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/

Andrea if testing is successful please proceed with
geowebcache, or I will catch it tomorrow after work.
--
Jody Garnett
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/geotools-devel



-- 


Regards, Andrea Aime == GeoServer Professional Services
from the experts! Visit http://goo.gl/it488V for more
information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa


(LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob:
+39 339 8844549 http://www.geo-solutions.it
http://twitter.com/geosolutions_it
---
/Con riferimento alla normativa sul trattamento dei dati
personali (Reg. UE 2016/679 - Regolamento generale sulla
protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo
contenuto, gli eventuali allegati, etc.) è un dato la cui
conoscenza è riservata al/i solo/i destinatario/i
indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è
illecita. Le sarei comunque grato se potesse darmene
notizia. 

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

Good timing on testing, it seems rough closing the writer after one
feature? I would update the javadoc to be clear about the API contract and
leave the writer open.

On Thu, Mar 12, 2020 at 11:50 AM Jim Hughes  wrote:

> Hi all,
>
> As a happy coincidence, I was able to test the GeoTools RC with GeoMesa.
> I did hit an issue or two.
>
> The first one is that GeoMesa uses GeoTools library code to write out
> GeoJson.  Calls to FeatureJSON.writeFeature(SimpleFeature feature, Object
> output) use GeoJSONUtil.encode(String, Writer).
>
> This encode method was changed[1] to use the try-with-resources pattern,
> and that means the writer we pass in gets closed.  This messes up that
> previous wrote out GeoJSON.
>
> I see two options:
> A.  This change is a 'bug' and we chat through a GeoTools update.
> B.  This change is an improvement, and I should update GeoMesa.  (Maybe to
> use "new FeatureEncoder(feature).toJSONString()" along with managing the
> writes to outputstreams, etc.)
>
> Thoughts?
>
> Jim
>
> 1.
> https://github.com/geotools/geotools/commit/8b5d6279474c9dc8962d279a884e508ab670ee3c#diff-208951a6b5feb5f96a890c79c9846389
> 2. Example GeoMesa code:
> https://github.com/locationtech/geomesa/blob/master/geomesa-tools/src/main/scala/org/locationtech/geomesa/tools/export/formats/GeoJsonExporter.scala
>
> On 3/12/20 12:53 AM, Jody Garnett wrote:
>
> 23-RC is deployed and on SF, will work on blog post while waiting for
> future builds.
> --
> Jody Garnett
>
>
> On Wed, 11 Mar 2020 at 07:25, Jody Garnett  wrote:
>
>> Thanks for letting me know, speed seems good from this end. Thanks for
>> building from the tag, that may have to do for timezone testing.
>> I will start geowebcache release cycle at end-of-day.
>> --
>> Jody Garnett
>>
>>
>> On Wed, 11 Mar 2020 at 02:17, Andrea Aime 
>> wrote:
>>
>>> Hi Jody,
>>> I'm having trouble connecting to anything that's in the US, getting to
>>> the build server is very slow,
>>> downloading the package times out instead.
>>> I've tried building out of github checkouts (that one works) but it
>>> still gets stuck trying to download
>>> from the boundless repository...
>>>
>>> Will try again later, hopefully it's a short lived situation
>>>
>>> Cheers
>>> Andrea
>>>
>>>
>>> On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett 
>>> wrote:
>>>
 Build is once again complete, please test artifacts and report back:
 -
 https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/

 Andrea if testing is successful please proceed with geowebcache, or I
 will catch it tomorrow after work.
 --
 Jody Garnett
 ___
 GeoTools-Devel mailing list
 GeoTools-Devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/geotools-devel

>>>
>>>
>>> --
>>>
>>> Regards, Andrea Aime == GeoServer Professional Services from the
>>> experts! Visit http://goo.gl/it488V for more information. == Ing.
>>> Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di
>>> Montramito 3/A 55054 Massarosa
>>> 
>>> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
>>> http://www.geo-solutions.it http://twitter.com/geosolutions_it
>>> --- *Con
>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE
>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
>>> precisa che ogni circostanza inerente alla presente email (il suo
>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>>> This email is intended only for the person or entity to which it is
>>> addressed and may contain information that is privileged, confidential or
>>> otherwise protected from disclosure. We remind that - as provided by
>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
>>> e-mail or the information herein by anyone other than the intended
>>> recipient is prohibited. If you have received this email by mistake, please
>>> notify us immediately by telephone or e-mail.*
>>>
>>
>
> ___
> GeoTools-Devel mailing 
> listGeoTools-Devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
-- 
--
Jody Garnett
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jim Hughes]

Hi all,

As a happy coincidence, I was able to test the GeoTools RC with 
GeoMesa.  I did hit an issue or two.


The first one is that GeoMesa uses GeoTools library code to write out 
GeoJson.  Calls to FeatureJSON.writeFeature(SimpleFeature feature, 
Object output) use GeoJSONUtil.encode(String, Writer).


This encode method was changed[1] to use the try-with-resources pattern, 
and that means the writer we pass in gets closed.  This messes up that 
previous wrote out GeoJSON.


I see two options:
A.  This change is a 'bug' and we chat through a GeoTools update.
B.  This change is an improvement, and I should update GeoMesa.  (Maybe 
to use "new FeatureEncoder(feature).toJSONString()" along with managing 
the writes to outputstreams, etc.)


Thoughts?

Jim

1. 
https://github.com/geotools/geotools/commit/8b5d6279474c9dc8962d279a884e508ab670ee3c#diff-208951a6b5feb5f96a890c79c9846389
2. Example GeoMesa code: 
https://github.com/locationtech/geomesa/blob/master/geomesa-tools/src/main/scala/org/locationtech/geomesa/tools/export/formats/GeoJsonExporter.scala


On 3/12/20 12:53 AM, Jody Garnett wrote:
23-RC is deployed and on SF, will work on blog post while waiting for 
future builds.

--
Jody Garnett


On Wed, 11 Mar 2020 at 07:25, Jody Garnett > wrote:


Thanks for letting me know, speed seems good from this end. Thanks
for building from the tag, that may have to do for timezone testing.
I will start geowebcache release cycle at end-of-day.
--
Jody Garnett


On Wed, 11 Mar 2020 at 02:17, Andrea Aime
mailto:andrea.a...@geo-solutions.it>> wrote:

Hi Jody,
I'm having trouble connecting to anything that's in the US,
getting to the build server is very slow,
downloading the package times out instead.
I've tried building out of github checkouts (that one works)
but it still gets stuck trying to download
from the boundless repository...

Will try again later, hopefully it's a short lived situation

Cheers
Andrea


On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett
mailto:jody.garn...@gmail.com>> wrote:

Build is once again complete, please test artifacts and
report back:
-

https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/

Andrea if testing is successful please proceed with
geowebcache, or I will catch it tomorrow after work.
--
Jody Garnett
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/geotools-devel



-- 


Regards, Andrea Aime == GeoServer Professional Services from
the experts! Visit http://goo.gl/it488V for more information.
== Ing. Andrea Aime @geowolf Technical Lead GeoSolutions
S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- /Con
riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei
dati “GDPR”), si precisa che ogni circostanza inerente alla
presente email (il suo contenuto, gli eventuali allegati,
etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è
giunto per errore, è tenuta/o a cancellarlo, ogni altra
operazione è illecita. Le sarei comunque grato se potesse
darmene notizia. This email is intended only for the person or
entity to which it is addressed and may contain information
that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European
Regulation 2016/679 “GDPR” - copying, dissemination or use of
this e-mail or the information herein by anyone other than the
intended recipient is prohibited. If you have received this
email by mistake, please notify us immediately by telephone or
e-mail./



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

23-RC is deployed and on SF, will work on blog post while waiting for
future builds.
--
Jody Garnett


On Wed, 11 Mar 2020 at 07:25, Jody Garnett  wrote:

> Thanks for letting me know, speed seems good from this end. Thanks for
> building from the tag, that may have to do for timezone testing.
> I will start geowebcache release cycle at end-of-day.
> --
> Jody Garnett
>
>
> On Wed, 11 Mar 2020 at 02:17, Andrea Aime 
> wrote:
>
>> Hi Jody,
>> I'm having trouble connecting to anything that's in the US, getting to
>> the build server is very slow,
>> downloading the package times out instead.
>> I've tried building out of github checkouts (that one works) but it still
>> gets stuck trying to download
>> from the boundless repository...
>>
>> Will try again later, hopefully it's a short lived situation
>>
>> Cheers
>> Andrea
>>
>>
>> On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett 
>> wrote:
>>
>>> Build is once again complete, please test artifacts and report back:
>>> -
>>> https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/
>>>
>>> Andrea if testing is successful please proceed with geowebcache, or I
>>> will catch it tomorrow after work.
>>> --
>>> Jody Garnett
>>> ___
>>> GeoTools-Devel mailing list
>>> GeoTools-Devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>
>>
>> --
>>
>> Regards, Andrea Aime == GeoServer Professional Services from the experts!
>> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
>> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
>> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
>> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
>> --- *Con riferimento
>> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
>> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
>> circostanza inerente alla presente email (il suo contenuto, gli eventuali
>> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
>> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
>> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
>> sarei comunque grato se potesse darmene notizia. This email is intended
>> only for the person or entity to which it is addressed and may contain
>> information that is privileged, confidential or otherwise protected from
>> disclosure. We remind that - as provided by European Regulation 2016/679
>> “GDPR” - copying, dissemination or use of this e-mail or the information
>> herein by anyone other than the intended recipient is prohibited. If you
>> have received this email by mistake, please notify us immediately by
>> telephone or e-mail.*
>>
>
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

Thanks for letting me know, speed seems good from this end. Thanks for
building from the tag, that may have to do for timezone testing.
I will start geowebcache release cycle at end-of-day.
--
Jody Garnett


On Wed, 11 Mar 2020 at 02:17, Andrea Aime 
wrote:

> Hi Jody,
> I'm having trouble connecting to anything that's in the US, getting to the
> build server is very slow,
> downloading the package times out instead.
> I've tried building out of github checkouts (that one works) but it still
> gets stuck trying to download
> from the boundless repository...
>
> Will try again later, hopefully it's a short lived situation
>
> Cheers
> Andrea
>
>
> On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett 
> wrote:
>
>> Build is once again complete, please test artifacts and report back:
>> -
>> https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/
>>
>> Andrea if testing is successful please proceed with geowebcache, or I
>> will catch it tomorrow after work.
>> --
>> Jody Garnett
>> ___
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>
>
> --
>
> Regards, Andrea Aime == GeoServer Professional Services from the experts!
> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
> --- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Andrea Aime]

Hi Jody,
I'm having trouble connecting to anything that's in the US, getting to the
build server is very slow,
downloading the package times out instead.
I've tried building out of github checkouts (that one works) but it still
gets stuck trying to download
from the boundless repository...

Will try again later, hopefully it's a short lived situation

Cheers
Andrea


On Wed, Mar 11, 2020 at 4:30 AM Jody Garnett  wrote:

> Build is once again complete, please test artifacts and report back:
> -
> https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/
>
> Andrea if testing is successful please proceed with geowebcache, or I will
> catch it tomorrow after work.
> --
> Jody Garnett
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>


-- 

Regards, Andrea Aime == GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

Some notes from testing the project download:

1) README.md links
- broken link to
https://docs.geotools.org/stable/developer/procedures/contribute.html
- broken link to:
https://docs.geotools.org/stable/developer/procedures/pull_requests.html

2) VERSION.txt

Does not have the correct substitutions (or indeed any substitutions):

version: ${project.version}
git revision: ${build.commit.id}
build date: ${build.timestamp}


3) target/VERSION.txt is fine

4) Builds from PDT (UTC -7) completed
--
Jody Garnett


On Tue, 10 Mar 2020 at 20:27, Jody Garnett  wrote:

> Build is once again complete, please test artifacts and report back:
> -
> https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/
>
> Andrea if testing is successful please proceed with geowebcache, or I will
> catch it tomorrow after work.
> --
> Jody Garnett
>
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

[Jody Garnett]

Build is once again complete, please test artifacts and report back:
-
https://build.geoserver.org/view/release/job/geotools-release/230/artifact/build/release/distribution/23-RC/

Andrea if testing is successful please proceed with geowebcache, or I will
catch it tomorrow after work.
--
Jody Garnett
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] GeoTools 23-RC ready for testing

[Ian Turton]

JDBC stores I think. This certainly sounds familiar

Ian

On Tue, 10 Mar 2020 at 10:05, Andrea Aime 
wrote:

> Btw, I think Ian at one point worked on a setting on whether to prefer
> local time zone vs GMT... but I don't
> quite remember what it is supposed to affect... GML encoders? Converters?
> Data stores?
>
> Cheers
> Andrea
>
>
> On Tue, Mar 10, 2020 at 10:48 AM Andrea Aime 
> wrote:
>
>> Hi Jody,
>> tried with a local build with no remote repo, the GeoPackage tests fail,
>> seems a timezone issue
>>
>>
>> ---
>> Test set: org.geotools.geopkg.GeoPkgDatetimeTest
>>
>> ---
>> Tests run: 11, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.186 s
>> <<< FAILURE! - in org.geotools.geopkg.GeoPkgDatetimeTest
>> testMax(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.086 s
>>  <<< FAILURE!
>> java.lang.AssertionError: expected:<2020-02-23> but was:<2020-02-22>
>> at
>> org.geotools.geopkg.GeoPkgDatetimeTest.testMax(GeoPkgDatetimeTest.java:156)
>>
>> testMin(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.008 s
>>  <<< FAILURE!
>> java.lang.AssertionError: expected:<2020-02-19> but was:<2020-02-18>
>> at
>> org.geotools.geopkg.GeoPkgDatetimeTest.testMin(GeoPkgDatetimeTest.java:178)
>>
>> testGroupBy(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.008
>> s  <<< FAILURE!
>> java.lang.AssertionError: expected:<2020-02-19> but was:<2020-02-18>
>> at
>> org.geotools.geopkg.GeoPkgDatetimeTest.testGroupBy(GeoPkgDatetimeTest.java:206)
>>
>> I have a crazy day ahead of me, will try to have a look later but cannot
>> promise.
>>
>> Cheers
>> Andrea
>>
>> On Tue, Mar 10, 2020 at 8:32 AM Jody Garnett 
>> wrote:
>>
>>> Build is complete, please test artifacts and report back:
>>> - https://build.geoserver.org/view/release/job/geotools-release/229/
>>>
>>> Andrea if testing is successful please proceed with geowebcache, or I
>>> will catch it after work tomorrow if you are busy.
>>> --
>>> Jody Garnett
>>> ___
>>> GeoTools-Devel mailing list
>>> GeoTools-Devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>
>>
>> --
>>
>> Regards, Andrea Aime == GeoServer Professional Services from the experts!
>> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
>> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
>> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
>> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
>> --- *Con riferimento
>> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
>> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
>> circostanza inerente alla presente email (il suo contenuto, gli eventuali
>> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
>> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
>> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
>> sarei comunque grato se potesse darmene notizia. This email is intended
>> only for the person or entity to which it is addressed and may contain
>> information that is privileged, confidential or otherwise protected from
>> disclosure. We remind that - as provided by European Regulation 2016/679
>> “GDPR” - copying, dissemination or use of this e-mail or the information
>> herein by anyone other than the intended recipient is prohibited. If you
>> have received this email by mistake, please notify us immediately by
>> telephone or e-mail.*
>>
>
>
> --
>
> Regards, Andrea Aime == GeoServer Professional Services from the experts!
> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
> --- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - 

Re: [Geotools-devel] GeoTools 23-RC ready for testing

[Nuno Oliveira]

Hi all,
thx for the release Jody, got a green build here:
[INFO] Reactor Summary for GeoTools 23-RC:
[INFO] 
[INFO] GeoTools ... SUCCESS
[  0.768 s]
[INFO] Build tools for Geotools 2 . SUCCESS
[  0.044 s]
[INFO] Maven plugins for Geotools 2 ... SUCCESS
[  0.039 s]
[INFO] JAR files collector  SUCCESS
[  4.102 s]
[INFO] JJTree and JavaCC compilers plugin . SUCCESS
[  2.777 s]
[INFO] Geotools modules ... SUCCESS
[  0.033 s]
[INFO] Geotools libraries . SUCCESS
[  0.077 s]
[INFO] Open GIS Interfaces  SUCCESS
[  6.019 s]
[INFO] OGC Web Service Models . SUCCESS
[  0.035 s]
[INFO] Xlink Model  SUCCESS
[  1.617 s]
[INFO] Open Web Services Model  SUCCESS
[  2.224 s]
[INFO] Metadata ... SUCCESS
[  8.217 s]
[INFO] Sample data module . SUCCESS
[  4.667 s]
[INFO] Referencing services ... SUCCESS
[  5.822 s]
[INFO] Geotools plugins ... SUCCESS
[  0.040 s]
[INFO] EPSG Authority Service using HSQL database . SUCCESS
[  5.334 s]
[INFO] Main module  SUCCESS [
20.417 s]
[INFO] XML Parsing Support  SUCCESS [
11.332 s]
[INFO] Geotools extensions  SUCCESS
[  0.038 s]
[INFO] XML Parsing  SUCCESS
[  0.233 s]
[INFO] XML Parsing  SUCCESS
[  3.279 s]
[INFO] Feature Based Graphs and Networks .. SUCCESS
[  2.987 s]
[INFO] XML Code Generation Support  SUCCESS
[  0.832 s]
[INFO] Grid Coverage module ... SUCCESS [
24.981 s]
[INFO] EPSG Authority Service using WKT file .. SUCCESS
[  2.591 s]
[INFO] OGC CQL to Filter parser ... SUCCESS
[  2.940 s]
[INFO] Property File DataStore  SUCCESS
[  1.600 s]
[INFO] GeoTIFF grid coverage exchange module .. SUCCESS
[  3.161 s]
[INFO] JDBC DataStore Support . SUCCESS
[  4.917 s]
[INFO] JDBC DataStore Plugins . SUCCESS
[  0.018 s]
[INFO] H2 DataStore ... SUCCESS [
31.232 s]
[INFO] Oracle DataStore ... SUCCESS
[  0.545 s]
[INFO] PostGIS DataStore .. SUCCESS
[  2.207 s]
[INFO] Shapefile module ... SUCCESS
[  9.016 s]
[INFO] Feature transforming feature source wrapper  SUCCESS
[  2.501 s]
[INFO] WorldImage datasource module ... SUCCESS
[  2.046 s]
[INFO] imagemosaic datasource module .. SUCCESS [
20.298 s]
[INFO] ArcGrid datasource module .. SUCCESS [
17.744 s]
[INFO] GML2 XML Support ... SUCCESS
[  2.443 s]
[INFO] GML3 XML Support ... SUCCESS [
12.344 s]
[INFO] Filter XML Support . SUCCESS
[  3.212 s]
[INFO] SLD XML Support  SUCCESS
[  4.894 s]
[INFO] Render . SUCCESS
[01:09 min]
[INFO] Filter Encoding Specification Model  SUCCESS
[  1.686 s]
[INFO] Web Feature Service Model .. SUCCESS
[  1.358 s]
[INFO] Web Processing Service Model ... SUCCESS
[  1.581 s]
[INFO] Web Coverage Service Model . SUCCESS
[  1.813 s]
[INFO] Catalog Services for the Web Model . SUCCESS
[  1.406 s]
[INFO] Web Map Tile Service model . SUCCESS
[  5.326 s]
[INFO] Dynamic symbolizer module based on JFreeChart and Eastwood
SUCCESS [  1.992 s]
[INFO] Coverage Multidimensional Module ... SUCCESS
[  0.112 s]
[INFO] API interfaces . SUCCESS
[  3.115 s]
[INFO] NetCDF gridcoverage module . SUCCESS [
45.352 s]
[INFO] GRIB gridcoverage module ... SUCCESS [
20.195 s]
[INFO] CSVDataStore ... SUCCESS
[  2.636 s]
[INFO] Extensions to EPSG authority factory ... SUCCESS
[  2.370 s]
[INFO] EPSG Authority Service using PostgreSQL database ... SUCCESS
[  0.253 s]
[INFO] Feature-Pregeneralized . SUCCESS
[  1.800 s]
[INFO] OWS XML Support  SUCCESS
[  2.344 s]
[INFO] Filter Encoding Specification XML Support .. SUCCESS
[  3.808 s]
[INFO] GeoPackage Module .. SUCCESS [
18.177 s]

Re: [Geotools-devel] GeoTools 23-RC ready for testing

[Andrea Aime]

Btw, I think Ian at one point worked on a setting on whether to prefer
local time zone vs GMT... but I don't
quite remember what it is supposed to affect... GML encoders? Converters?
Data stores?

Cheers
Andrea


On Tue, Mar 10, 2020 at 10:48 AM Andrea Aime 
wrote:

> Hi Jody,
> tried with a local build with no remote repo, the GeoPackage tests fail,
> seems a timezone issue
>
>
> ---
> Test set: org.geotools.geopkg.GeoPkgDatetimeTest
>
> ---
> Tests run: 11, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.186 s
> <<< FAILURE! - in org.geotools.geopkg.GeoPkgDatetimeTest
> testMax(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.086 s
>  <<< FAILURE!
> java.lang.AssertionError: expected:<2020-02-23> but was:<2020-02-22>
> at
> org.geotools.geopkg.GeoPkgDatetimeTest.testMax(GeoPkgDatetimeTest.java:156)
>
> testMin(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.008 s
>  <<< FAILURE!
> java.lang.AssertionError: expected:<2020-02-19> but was:<2020-02-18>
> at
> org.geotools.geopkg.GeoPkgDatetimeTest.testMin(GeoPkgDatetimeTest.java:178)
>
> testGroupBy(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.008 s
>  <<< FAILURE!
> java.lang.AssertionError: expected:<2020-02-19> but was:<2020-02-18>
> at
> org.geotools.geopkg.GeoPkgDatetimeTest.testGroupBy(GeoPkgDatetimeTest.java:206)
>
> I have a crazy day ahead of me, will try to have a look later but cannot
> promise.
>
> Cheers
> Andrea
>
> On Tue, Mar 10, 2020 at 8:32 AM Jody Garnett 
> wrote:
>
>> Build is complete, please test artifacts and report back:
>> - https://build.geoserver.org/view/release/job/geotools-release/229/
>>
>> Andrea if testing is successful please proceed with geowebcache, or I
>> will catch it after work tomorrow if you are busy.
>> --
>> Jody Garnett
>> ___
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>
>
> --
>
> Regards, Andrea Aime == GeoServer Professional Services from the experts!
> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
> --- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>


-- 

Regards, Andrea Aime == GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*

Re: [Geotools-devel] GeoTools 23-RC ready for testing

[Andrea Aime]

Hi Jody,
tried with a local build with no remote repo, the GeoPackage tests fail,
seems a timezone issue

---
Test set: org.geotools.geopkg.GeoPkgDatetimeTest
---
Tests run: 11, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.186 s
<<< FAILURE! - in org.geotools.geopkg.GeoPkgDatetimeTest
testMax(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.086 s  <<<
FAILURE!
java.lang.AssertionError: expected:<2020-02-23> but was:<2020-02-22>
at
org.geotools.geopkg.GeoPkgDatetimeTest.testMax(GeoPkgDatetimeTest.java:156)

testMin(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.008 s  <<<
FAILURE!
java.lang.AssertionError: expected:<2020-02-19> but was:<2020-02-18>
at
org.geotools.geopkg.GeoPkgDatetimeTest.testMin(GeoPkgDatetimeTest.java:178)

testGroupBy(org.geotools.geopkg.GeoPkgDatetimeTest)  Time elapsed: 0.008 s
 <<< FAILURE!
java.lang.AssertionError: expected:<2020-02-19> but was:<2020-02-18>
at
org.geotools.geopkg.GeoPkgDatetimeTest.testGroupBy(GeoPkgDatetimeTest.java:206)

I have a crazy day ahead of me, will try to have a look later but cannot
promise.

Cheers
Andrea

On Tue, Mar 10, 2020 at 8:32 AM Jody Garnett  wrote:

> Build is complete, please test artifacts and report back:
> - https://build.geoserver.org/view/release/job/geotools-release/229/
>
> Andrea if testing is successful please proceed with geowebcache, or I will
> catch it after work tomorrow if you are busy.
> --
> Jody Garnett
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>


-- 

Regards, Andrea Aime == GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054
Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339
8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] GeoTools 23-RC ready for testing

[Jody Garnett]

Build is complete, please test artifacts and report back:
- https://build.geoserver.org/view/release/job/geotools-release/229/

Andrea if testing is successful please proceed with geowebcache, or I will
catch it after work tomorrow if you are busy.
--
Jody Garnett
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel