Change in osmo-sgsn[master]: gprs_gmm: introduce a GMM Attach Request FSM

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/9257 )

Change subject: gprs_gmm: introduce a GMM Attach Request FSM
..


Patch Set 1:

the failing tests are related to the changes. I would recommend removing the 
unit tests, because ttcn3 is testing the same and is much more maintainable and 
debug'able.


--
To view, visit https://gerrit.osmocom.org/9257
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b9c17be9776a03bb2a5b21e99135cfefc8c912
Gerrit-Change-Number: 9257
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Wed, 23 May 2018 00:44:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: gprs_gmm: introduce a GMM Attach Request FSM

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/9257 )

Change subject: gprs_gmm: introduce a GMM Attach Request FSM
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/9257
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b9c17be9776a03bb2a5b21e99135cfefc8c912
Gerrit-Change-Number: 9257
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 23 May 2018 00:44:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failed in Jenkins: master-rtl-sdr » a1=default,a2=default,a3=default,osmocom-master-debian9 #42

[jenkins]

See 


--
[...truncated 93.29 KB...]
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
Making dvi in src
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi-am'.
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
make[1]: Entering directory 
'
make  check-recursive
make[2]: Entering directory 
'
Making check in include
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory 
'
Making check in src
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory 
'
make[3]: Entering directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
make[1]: Entering directory 
'
make  install-recursive
make[2]: Entering directory 
'
Making install in include
make[3]: Entering directory 
'
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644 ../../../include/rtl-sdr.h 
../../../include/rtl-sdr_export.h 
'
make[4]: Leaving directory 

Change in osmo-sgsn[master]: WIP: tests: remove gmm unit tests

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9258


Change subject: WIP: tests: remove gmm unit tests
..

WIP: tests: remove gmm unit tests

The TTCN3 tests should replace all of the GMM unit tests.
The GMM unit tests uses send/recieve LLME while TTCN3 is using BSSGP
tx/rx to the same.
TTCN3 has better tooling and can handle packets more easier.
The unittests expect the package in a specific order and do checks
the internal state, which is now changing because of the new FSM.

TODO: compare TTCN3 <> unit tests and add missing checks.

Change-Id: Iac1c8854b5ea4aa03279990390ebc110c979aac2
---
M tests/sgsn/sgsn_test.c
1 file changed, 0 insertions(+), 818 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/58/9258/1

diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c
index 0e5267b..3e86266 100644
--- a/tests/sgsn/sgsn_test.c
+++ b/tests/sgsn/sgsn_test.c
@@ -925,166 +925,6 @@
cleanup_test();
 }

-/*
- * Test the GMM Attach procedure
- */
-static void test_gmm_attach(int retry)
-{
-   struct gprs_ra_id raid = { 0, };
-   struct sgsn_mm_ctx *ctx = NULL;
-   struct sgsn_mm_ctx *ictx;
-   uint32_t ptmsi1;
-   uint32_t foreign_tlli;
-   uint32_t local_tlli = 0;
-   struct gprs_llc_lle *lle;
-
-   /* DTAP - Attach Request */
-   /* The P-TMSI is not known by the SGSN */
-   static const unsigned char attach_req[] = {
-   0x08, 0x01, 0x02, 0xf5, 0xe0, 0x21, 0x08, 0x02, 0x05, 0xf4,
-   0xfb, 0xc5, 0x46, 0x79, 0x11, 0x22, 0x33, 0x40, 0x50, 0x60,
-   0x19, 0x18, 0xb3, 0x43, 0x2b, 0x25, 0x96, 0x62, 0x00, 0x60,
-   0x80, 0x9a, 0xc2, 0xc6, 0x62, 0x00, 0x60, 0x80, 0xba, 0xc8,
-   0xc6, 0x62, 0x00, 0x60, 0x80, 0x00
-   };
-
-   /* DTAP - Identity Response IMEI */
-   static const unsigned char ident_resp_imei[] = {
-   0x08, 0x16, 0x08, 0x9a, 0x78, 0x56, 0x34, 0x12, 0x90, 0x78,
-   0x56
-   };
-
-   /* DTAP - Identity Response IMSI */
-   static const unsigned char ident_resp_imsi[] = {
-   0x08, 0x16, 0x08, 0x19, 0x32, 0x54, 0x76, 0x98, 0x10, 0x32,
-   0x54
-   };
-
-   /* DTAP - Authentication and Ciphering Resp */
-   static const unsigned char auth_ciph_resp[] = {
-   0x08, 0x13, 0x00, 0x22, 0x51, 0xe5, 0x51, 0xe5, 0x23, 0x09,
-   0x9a, 0x78, 0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x01
-   };
-
-   /* DTAP - Attach Complete */
-   static const unsigned char attach_compl[] = {
-   0x08, 0x03
-   };
-
-   /* DTAP - Detach Request (MO) */
-   /* normal detach, power_off = 0 */
-   static const unsigned char detach_req[] = {
-   0x08, 0x05, 0x01, 0x18, 0x05, 0xf4, 0xeb, 0x8b,
-   0x45, 0x67, 0x19, 0x03, 0xb9, 0x97, 0xcb
-   };
-
-   printf("Testing GMM attach%s\n", retry ? " with retry" : "");
-
-   foreign_tlli = gprs_tmsi2tlli(0xc023, TLLI_FOREIGN);
-
-   /* Create a LLE/LLME */
-   OSMO_ASSERT(count(gprs_llme_list()) == 0);
-   lle = gprs_lle_get_or_create(foreign_tlli, 3);
-   OSMO_ASSERT(count(gprs_llme_list()) == 1);
-
-   /* inject the attach request */
-   send_0408_message(lle->llme, foreign_tlli, ,
- attach_req, ARRAY_SIZE(attach_req));
-
-   ctx = sgsn_mm_ctx_by_tlli(foreign_tlli, );
-   OSMO_ASSERT(ctx != NULL);
-   OSMO_ASSERT(ctx->gmm_state == GMM_COMMON_PROC_INIT);
-
-   /* we expect an identity request (IMEI) */
-   OSMO_ASSERT(sgsn_tx_counter == 1);
-
-   /* inject the identity response (IMEI) */
-   send_0408_message(ctx->gb.llme, foreign_tlli, ,
- ident_resp_imei, ARRAY_SIZE(ident_resp_imei));
-
-   /* we expect an identity request (IMSI) */
-   OSMO_ASSERT(sgsn_tx_counter == 1);
-
-   /* inject the identity response (IMSI) */
-   send_0408_message(ctx->gb.llme, foreign_tlli, ,
- ident_resp_imsi, ARRAY_SIZE(ident_resp_imsi));
-
-   /* check that the MM context has not been removed due to a failed
-* authorization */
-   OSMO_ASSERT(ctx == sgsn_mm_ctx_by_tlli(foreign_tlli, ));
-
-   OSMO_ASSERT(ctx->gmm_state == GMM_COMMON_PROC_INIT);
-
-retry_attach_req:
-
-   if (retry && sgsn_tx_counter == 0) {
-   fprintf(stderr, "Retrying attach request\n");
-   /* re-inject the attach request */
-   send_0408_message(lle->llme, foreign_tlli, ,
- attach_req, ARRAY_SIZE(attach_req));
-   }
-
-   if (ctx->auth_state == SGSN_AUTH_AUTHENTICATE && sgsn_tx_counter == 1) {
-   /* we got an auth & ciph request */
-
-   /* inject the auth & ciph response */
-   send_0408_message(ctx->gb.llme, foreign_tlli, ,
-  

Change in osmocom-bb[master]: osmocon: Makefile.am: Fix build using different path

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9244 )

Change subject: osmocon: Makefile.am: Fix build using different path
..

osmocon: Makefile.am: Fix build using different path

Change-Id: I1a322e364612976f3d797f25e57ccc7c2354bd5e
---
M src/host/osmocon/Makefile.am
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/host/osmocon/Makefile.am b/src/host/osmocon/Makefile.am
index 8b0d4bf..de4e575 100644
--- a/src/host/osmocon/Makefile.am
+++ b/src/host/osmocon/Makefile.am
@@ -13,9 +13,9 @@
 sbin_PROGRAMS = osmocon osmoload
 
 # FIXME: sercomm needs to move into libosmocore or another shared lib
-INCLUDES += -I../../target/firmware/include/comm -I../../target/firmware/apps 
-DHOST_BUILD
-osmocon_SOURCES = osmocon.c tpu_debug.c ../../target/firmware/comm/sercomm.c
+INCLUDES += -I$(srcdir)/../../target/firmware/include/comm 
-I$(srcdir)/../../target/firmware/apps -DHOST_BUILD
+osmocon_SOURCES = osmocon.c tpu_debug.c 
$(srcdir)/../../target/firmware/comm/sercomm.c
 osmocon_LDADD = $(LIBOSMOCORE_LIBS)

-osmoload_SOURCE = osmoload.c ../../target/firmware/comm/sercomm.c
+osmoload_SOURCE = osmoload.c $(srcdir)/../../target/firmware/comm/sercomm.c
 osmoload_LDADD = $(LIBOSMOCORE_LIBS)

--
To view, visit https://gerrit.osmocom.org/9244
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a322e364612976f3d797f25e57ccc7c2354bd5e
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: osmocon: Makefile.am: Fix build using different path

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9244 )

Change subject: osmocon: Makefile.am: Fix build using different path
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9244
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a322e364612976f3d797f25e57ccc7c2354bd5e
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 22 May 2018 19:51:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: gprs_gmm: make functions relating to GMM Attach Request public

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9255


Change subject: gprs_gmm: make functions relating to GMM Attach Request public
..

gprs_gmm: make functions relating to GMM Attach Request public

GMM Attach Request will be handled in it's own file and will
use those functions.

Change-Id: Ic90d77f7b0bacd2a8e2e409e82d676772d352749
---
M include/osmocom/sgsn/gprs_gmm.h
M src/gprs/gprs_gmm.c
2 files changed, 13 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/55/9255/1

diff --git a/include/osmocom/sgsn/gprs_gmm.h b/include/osmocom/sgsn/gprs_gmm.h
index 6324c5d..b89eff5 100644
--- a/include/osmocom/sgsn/gprs_gmm.h
+++ b/include/osmocom/sgsn/gprs_gmm.h
@@ -11,6 +11,9 @@
 uint8_t cause, uint8_t pco_len, uint8_t *pco_v);
 int gsm48_tx_gsm_act_pdp_acc(struct sgsn_pdp_ctx *pdp);
 int gsm48_tx_gsm_deact_pdp_acc(struct sgsn_pdp_ctx *pdp);
+int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,
+ const struct osmo_auth_vector *vec,
+ uint8_t key_seq, bool force_standby);

 int gsm0408_gprs_rcvmsg_gb(struct msgb *msg, struct gprs_llc_llme *llme,
   bool drop_cipherable);
@@ -32,4 +35,9 @@

 int iu_rab_act_ps(uint8_t rab_id, struct sgsn_pdp_ctx *pdp);

+int gsm48_tx_gmm_id_req(struct sgsn_mm_ctx *mm, uint8_t id_type);
+int gsm48_tx_gmm_att_rej(struct sgsn_mm_ctx *mm,
+   uint8_t gmm_cause);
+int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm);
+
 #endif /* _GPRS_GMM_H */
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 93d64a4..df498c1 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -424,7 +424,7 @@
 };

 /* Chapter 9.4.2: Attach accept */
-static int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm)
+int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm)
 {
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 ATT ACK");
struct gsm48_hdr *gh;
@@ -503,7 +503,7 @@
gmm_copy_id(msg, old_msg);
return _tx_gmm_att_rej(msg, gmm_cause, NULL);
 }
-static int gsm48_tx_gmm_att_rej(struct sgsn_mm_ctx *mm,
+int gsm48_tx_gmm_att_rej(struct sgsn_mm_ctx *mm,
uint8_t gmm_cause)
 {
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 ATT REJ");
@@ -547,7 +547,7 @@
 }

 /* Transmit Chapter 9.4.12 Identity Request */
-static int gsm48_tx_gmm_id_req(struct sgsn_mm_ctx *mm, uint8_t id_type)
+int gsm48_tx_gmm_id_req(struct sgsn_mm_ctx *mm, uint8_t id_type)
 {
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 ID REQ");
struct gsm48_hdr *gh;
@@ -577,7 +577,7 @@
 }

 /* 3GPP TS 24.008 Section 9.4.9: Authentication and Ciphering Request */
-static int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,
+int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,
  const struct osmo_auth_vector *vec,
  uint8_t key_seq, bool force_standby)
 {
@@ -1533,7 +1533,7 @@
 }

 /* Chapter 9.4.17: Routing area update reject */
-static int gsm48_tx_gmm_ra_upd_rej(struct msgb *old_msg, uint8_t cause)
+int gsm48_tx_gmm_ra_upd_rej(struct msgb *old_msg, uint8_t cause)
 {
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 RA UPD REJ");
struct gsm48_hdr *gh;

--
To view, visit https://gerrit.osmocom.org/9255
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic90d77f7b0bacd2a8e2e409e82d676772d352749
Gerrit-Change-Number: 9255
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-sgsn[master]: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9256


Change subject: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public
..

gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public

Change-Id: I54168e1a58dd36b38c53c13bbb5cdb4311f34410
---
M include/osmocom/sgsn/gprs_gmm.h
M src/gprs/gprs_gmm.c
2 files changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/56/9256/1

diff --git a/include/osmocom/sgsn/gprs_gmm.h b/include/osmocom/sgsn/gprs_gmm.h
index b89eff5..3c93efc 100644
--- a/include/osmocom/sgsn/gprs_gmm.h
+++ b/include/osmocom/sgsn/gprs_gmm.h
@@ -40,4 +40,7 @@
uint8_t gmm_cause);
 int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm);

+/* TODO: move extract_subscr_* when gsm48_gmm_authorize() got removed */
+void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx);
+void extract_subscr_hlr(struct sgsn_mm_ctx *ctx);
 #endif /* _GPRS_GMM_H */
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index df498c1..57d3883 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -848,7 +848,7 @@
return rc;
 }

-static void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx)
+void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx)
 {
struct gsm_mncc_number called;
uint8_t msisdn[sizeof(ctx->subscr->sgsn_data->msisdn) + 1];
@@ -879,7 +879,7 @@
}
 }

-static void extract_subscr_hlr(struct sgsn_mm_ctx *ctx)
+void extract_subscr_hlr(struct sgsn_mm_ctx *ctx)
 {
struct gsm_mncc_number called;
uint8_t hlr_number[sizeof(ctx->subscr->sgsn_data->hlr) + 1];

--
To view, visit https://gerrit.osmocom.org/9256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54168e1a58dd36b38c53c13bbb5cdb4311f34410
Gerrit-Change-Number: 9256
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-sgsn[master]: gprs_gmm: introduce a GMM Attach Request FSM

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9257


Change subject: gprs_gmm: introduce a GMM Attach Request FSM
..

gprs_gmm: introduce a GMM Attach Request FSM

The old GMM Attach Request handling used a recursive function
which can not handle certain states and is quite complex and hard to
extend.

The new FSM handles such request in a FSM and can be called multiple
times.

Change-Id: I58b9c17be9776a03bb2a5b21e99135cfefc8c912
---
M include/osmocom/sgsn/gprs_sgsn.h
M src/gprs/Makefile.am
M src/gprs/gprs_gmm.c
A src/gprs/gprs_gmm_attach.c
A src/gprs/gprs_gmm_attach.h
M src/gprs/gprs_sgsn.c
M tests/sgsn/Makefile.am
7 files changed, 404 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/57/9257/1

diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h
index 64e5619..2a01a99 100644
--- a/include/osmocom/sgsn/gprs_sgsn.h
+++ b/include/osmocom/sgsn/gprs_sgsn.h
@@ -4,6 +4,7 @@
 #include 
 #include 

+#include 
 #include 

 #include 
@@ -168,6 +169,8 @@
struct ranap_ue_conn_ctx*ue_ctx;
struct service_info service;
} iu;
+   struct osmo_fsm_inst *gmm_att_req_fsm;
+   uint32_t gmm_att_identy_type;
/* VLR number */
uint32_tnew_sgsn_addr;
/* Authentication Triplet */
diff --git a/src/gprs/Makefile.am b/src/gprs/Makefile.am
index 4c7f730..aa6b08c 100644
--- a/src/gprs/Makefile.am
+++ b/src/gprs/Makefile.am
@@ -58,6 +58,7 @@
$(NULL)

 osmo_sgsn_SOURCES = \
+   gprs_gmm_attach.c \
gprs_gmm.c \
gprs_sgsn.c \
gprs_sndcp.c \
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 57d3883..4236870 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -64,6 +64,8 @@

 #include 

+#include "gprs_gmm_attach.h"
+
 #define PTMSI_ALLOC

 extern struct sgsn_instance *sgsn;
@@ -791,7 +793,7 @@
/* FIXME: enable LLC cipheirng */

/* Check if we can let the mobile station enter */
-   return gsm48_gmm_authorize(ctx);
+   return osmo_fsm_inst_dispatch(ctx->gmm_att_req_fsm, E_AUTH_RESP_RECV, 
NULL);
 }

 /* Section 9.4.10: Authentication and Ciphering Failure */
@@ -1107,7 +1109,10 @@
 {
ctx->sec_ctx = OSMO_AUTH_TYPE_NONE;

-   gsm48_gmm_authorize(ctx);
+   if (ctx->gmm_att_req_fsm->state != ST_INIT)
+   osmo_fsm_inst_dispatch(ctx->gmm_att_req_fsm, E_VLR_ANSWERED, 
(void *) 0);
+   else
+   gsm48_gmm_authorize(ctx);
 }

 void gsm0408_gprs_access_granted(struct sgsn_mm_ctx *ctx)
@@ -1118,7 +1123,8 @@
 "Authorized, continuing procedure, IMSI=%s\n",
 ctx->imsi);
/* Continue with the authorization */
-   gsm48_gmm_authorize(ctx);
+   if (ctx->gmm_att_req_fsm->state != ST_INIT)
+   osmo_fsm_inst_dispatch(ctx->gmm_att_req_fsm, 
E_VLR_ANSWERED, (void *) 0);
break;
default:
LOGMMCTXP(LOGL_INFO, ctx,
@@ -1139,8 +1145,8 @@
  "with cause '%s' (%d)\n",
  get_value_string(gsm48_gmm_cause_names, gmm_cause),
  gmm_cause);
-   gsm48_tx_gmm_att_rej(ctx, gmm_cause);
-   mm_ctx_cleanup_free(ctx, "GPRS ATTACH REJECT");
+   if (ctx->gmm_att_req_fsm->state != ST_INIT)
+   osmo_fsm_inst_dispatch(ctx->gmm_att_req_fsm, E_REJECT, 
(void *) (long) gmm_cause);
break;
case GMM_REGISTERED_NORMAL:
case GMM_REGISTERED_SUSPENDED:
@@ -1183,6 +1189,7 @@
 {
struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg);
uint8_t mi_type = gh->data[1] & GSM_MI_TYPE_MASK;
+   long mi_typel = mi_type;
char mi_string[GSM48_MI_SIZE];

gsm48_mi_to_string(mi_string, sizeof(mi_string), >data[1], 
gh->data[0]);
@@ -1235,7 +1242,7 @@
}

/* Check if we can let the mobile station enter */
-   return gsm48_gmm_authorize(ctx);
+   return osmo_fsm_inst_dispatch(ctx->gmm_att_req_fsm, E_IDEN_RESP_RECV, 
(void *)mi_typel);
 }

 /* Allocate a new P-TMSI and change context state */
@@ -1425,8 +1432,8 @@
gprs_llgmm_assign(ctx->gb.llme, ctx->gb.tlli, ctx->gb.tlli_new);
}

-   ctx->pending_req = GSM48_MT_GMM_ATTACH_REQ;
-   return gsm48_gmm_authorize(ctx);
+   osmo_fsm_inst_dispatch(ctx->gmm_att_req_fsm, E_ATTACH_REQ_RECV, msg);
+   return 0;

 err_inval:
LOGPC(DMM, LOGL_INFO, "\n");
@@ -2023,6 +2030,7 @@
mmctx_set_mm_state(mmctx, MM_READY);
rc = 0;

+   osmo_fsm_inst_dispatch(mmctx->gmm_att_req_fsm, 
E_ATTACH_COMPLETE_RECV, 0);
memset(_data, 0, sizeof(sig_data));
sig_data.mm = mmctx;
osmo_signal_dispatch(SS_SGSN, 

Change in osmo-sgsn[master]: gprs_gmm: Cancel Location: use detach type IMSI

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9254


Change subject: gprs_gmm: Cancel Location: use detach type IMSI
..

gprs_gmm: Cancel Location: use detach type IMSI

The detach type network side is defined as
- Reattach required
- Reattach not required
- IMSI detach (after VLR failure)

IMSI detach seems to be more close. Howeever the standard
isn't clear about this.

Change-Id: I27da6dc5165819cccd1ae0a98b132b45a01f38bb
---
M src/gprs/gprs_gmm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/54/9254/1

diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 93d64a4..4593dde 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1150,7 +1150,7 @@
  get_value_string(gsm48_gmm_cause_names, gmm_cause),
  gmm_cause);
gsm48_tx_gmm_detach_req(
-   ctx, GPRS_DET_T_MT_REATT_NOTREQ, gmm_cause);
+   ctx, GPRS_DET_T_MT_IMSI, gmm_cause);

mm_ctx_cleanup_free(ctx, "auth lost");
break;

--
To view, visit https://gerrit.osmocom.org/9254
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27da6dc5165819cccd1ae0a98b132b45a01f38bb
Gerrit-Change-Number: 9254
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-sgsn[master]: gprs_subscriber: gsup_auth_error: reject MS in all cases

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9253


Change subject: gprs_subscriber: gsup_auth_error: reject MS in all cases
..

gprs_subscriber: gsup_auth_error: reject MS in all cases

There is no way to recover from "PROTOCOL_ERRORS".
As long the error_cause is not set, the
SGSN won't send out a GMM Request Reject.

Fixes: TTCN: SGGN_Tests.TC_attach_auth_sai_reject
Change-Id: Iefe8f05686ef4acac721f3c0672910704f3b0ff8
---
M src/gprs/gprs_subscriber.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/53/9253/1

diff --git a/src/gprs/gprs_subscriber.c b/src/gprs/gprs_subscriber.c
index bebdb1e..1bebc65 100644
--- a/src/gprs/gprs_subscriber.c
+++ b/src/gprs/gprs_subscriber.c
@@ -502,6 +502,7 @@
"GSUP protocol remote error, GMM cause = '%s' (%d)\n",
get_value_string(gsm48_gmm_cause_names, 
gsup_msg->cause),
gsup_msg->cause);
+   sdata->error_cause = gsup_msg->cause;
break;
}


--
To view, visit https://gerrit.osmocom.org/9253
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefe8f05686ef4acac721f3c0672910704f3b0ff8
Gerrit-Change-Number: 9253
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmocom-bb[master]: osmocon: Makefile.am: Fix build using different path

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9244 )

Change subject: osmocon: Makefile.am: Fix build using different path
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9244
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a322e364612976f3d797f25e57ccc7c2354bd5e
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 22 May 2018 18:03:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: core/timer_compat: define CLOCK_BOOTTIME

[lynxis lazus]

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/7906 )

Change subject: core/timer_compat: define CLOCK_BOOTTIME
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/7906
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia3d3a829700272ec8e5cf67379d8d85368230726
Gerrit-Change-Number: 7906
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request_unknown_subscriber_{withdraw...

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9250


Change subject: SGSN: add 
TC_hlr_location_cancel_request_unknown_subscriber_{withdraw,update}
..

SGSN: add TC_hlr_location_cancel_request_unknown_subscriber_{withdraw,update}

Cancel Location using an unknown IMSI.

HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Error

Change-Id: Iad90c3cc25d72b9ab40e358fe60aa6f62163f146
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 51 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/50/9250/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index a2679cf..860ca09 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1282,6 +1282,55 @@
 }


+private function f_hlr_location_cancel_request_unknown_subscriber(
+   charstring id,
+   GSUP_CancelType canceltype) runs on BSSGP_ConnHdlr {
+
+   /* HLR: cancel the location request */
+   var GSUP_PDU gsup;
+   gsup := valueof(ts_GSUP_CL_REQ(g_pars.imsi, canceltype));
+   GSUP.send(gsup);
+
+   /* cause 2 = IMSI_UNKNOWN */
+   GSUP.receive(tr_GSUP_CL_ERR(g_pars.imsi, 2));
+
+   setverdict(pass);
+}
+
+private function 
f_TC_hlr_location_cancel_request_unknown_subscriber_withdraw(charstring id) 
runs on BSSGP_ConnHdlr {
+f_hlr_location_cancel_request_unknown_subscriber(id, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW);
+}
+
+testcase TC_hlr_location_cancel_request_unknown_subscriber_withdraw() runs on 
test_CT {
+   /* HLR -> SGSN: Cancel Location Request
+* HLR <- SGSN: Cancel Location Error
+*/
+
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := 
f_start_handler(refers(f_TC_hlr_location_cancel_request_unknown_subscriber_withdraw),
 testcasename(), g_gb[0], 30);
+   vc_conn.done;
+}
+
+private function 
f_TC_hlr_location_cancel_request_unknown_subscriber_update(charstring id) runs 
on BSSGP_ConnHdlr {
+f_hlr_location_cancel_request_unknown_subscriber(id, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW);
+}
+
+testcase TC_hlr_location_cancel_request_unknown_subscriber_update() runs on 
test_CT {
+   /* HLR -> SGSN: Cancel Location Request
+* HLR <- SGSN: Cancel Location Error
+*/
+
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := 
f_start_handler(refers(f_TC_hlr_location_cancel_request_unknown_subscriber_update),
 testcasename(), g_gb[0], 30);
+   vc_conn.done;
+}
+
+
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1296,6 +1345,8 @@
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
execute( TC_hlr_location_cancel_request_withdraw(), 5.0 );
+   execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
5.0 );
+   execute( TC_hlr_location_cancel_request_unknown_subscriber_update(), 
5.0 );
execute( TC_rau_unknown() );
execute( TC_attach_rau() );
execute( TC_detach_unknown_nopoweroff() );

--
To view, visit https://gerrit.osmocom.org/9250
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad90c3cc25d72b9ab40e358fe60aa6f62163f146
Gerrit-Change-Number: 9250
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: L3_Templates: add values for c_GMM_DTT_MT_*

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9246


Change subject: L3_Templates: add values for c_GMM_DTT_MT_*
..

L3_Templates: add values for c_GMM_DTT_MT_*

GMM detach type values

Change-Id: I4903fa4c915add3062ab6b82a1d39d60426b5681
---
M library/L3_Templates.ttcn
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/46/9246/1

diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index b2bfb07..ec3f257 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -1790,6 +1790,10 @@
 const BIT3 c_GMM_DTT_MO_IMSI := '010'B;
 const BIT3 c_GMM_DTT_MO_GPRS_IMSI_COMBINED := '011'B;

+const BIT3 c_GMM_DTT_MT_REATTACH_REQUIRED := '001'B;
+const BIT3 c_GMM_DTT_MT_REATTACH_NOT_REQUIRED := '010'B;
+const BIT3 c_GMM_DTT_MT_IMSI_DETACH := '011'B;
+
 template (value) DetachTypeV ts_GMM_DetType(BIT3 dtt, boolean power_off := 
false) := {
detachType := dtt,
powerOffFlag := bool2bit(power_off)

--
To view, visit https://gerrit.osmocom.org/9246
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4903fa4c915add3062ab6b82a1d39d60426b5681
Gerrit-Change-Number: 9246
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: GSUP_Types.ttcn: allow other TLV appear in Cancel Location Errors

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9249


Change subject: GSUP_Types.ttcn: allow other TLV appear in Cancel Location 
Errors
..

GSUP_Types.ttcn: allow other TLV appear in Cancel Location Errors

Change-Id: I21ee02556f0734dad871a6294b21ca6f2864dea0
---
M library/GSUP_Types.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/49/9249/1

diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 57c0a39..4c2aac0 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -341,7 +341,7 @@

 template GSUP_PDU tr_GSUP_CL_ERR(template hexstring imsi, template integer 
cause := ?) :=
tr_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_ERROR, {
-   tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause) });
+   tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause), * });
 
 template (value) GSUP_PDU ts_GSUP_PURGE_MS_REQ(hexstring imsi, GSUP_CnDomain 
dom) :=
ts_GSUP(OSMO_GSUP_MSGT_PURGE_MS_REQUEST, {

--
To view, visit https://gerrit.osmocom.org/9249
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21ee02556f0734dad871a6294b21ca6f2864dea0
Gerrit-Change-Number: 9249
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: L3_Templates: rename tr_GMM_DET_ACCEPT_MT -> tr_GMM_DET_ACCEPT_MO

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9245


Change subject: L3_Templates: rename tr_GMM_DET_ACCEPT_MT -> 
tr_GMM_DET_ACCEPT_MO
..

L3_Templates: rename tr_GMM_DET_ACCEPT_MT -> tr_GMM_DET_ACCEPT_MO

The standard defines this messages, even it's send from the Network -> MS as MO,
because the procedure initiated by the MS.

Change-Id: I4b5e2d43c9754d34b3749bff43b7df7196b9bb9c
---
M library/L3_Templates.ttcn
M sgsn/SGSN_Tests.ttcn
2 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/45/9245/1

diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index 5acd2bf..b2bfb07 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -1843,7 +1843,7 @@
}
 }

-template PDU_L3_SGSN_MS tr_GMM_DET_ACCEPT_MT := {
+template PDU_L3_SGSN_MS tr_GMM_DET_ACCEPT_MO := {
discriminator := '1000'B,
tiOrSkip := {
skipIndicator := ''B
@@ -1859,7 +1859,7 @@
}
 }

-template PDU_L3_SGSN_MS tr_GMM_DET_REQ_MT(template BIT3 dtt := ?, template 
boolean power_off := ?) := {
+template PDU_L3_SGSN_MS tr_GMM_DET_REQ_MO(template BIT3 dtt := ?, template 
boolean power_off := ?) := {
discriminator := '1000'B,
tiOrSkip := {
skipIndicator := ''B
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index e1d35c5..36a4700 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -784,7 +784,7 @@
[not expect_purge] GSUP.receive(tr_GSUP_PURGE_MS_REQ(?)) {
setverdict(fail, "Unexpected GSUP PURGE MS for unregistered 
TLLI");
}
-   [power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MT)) -> value 
bd {
+   [power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MO)) -> value 
bd {
g_pars.ra := omit;
setverdict(fail, "Unexpected ATTACH ACCEPT in no-power-off 
DETACH");
/* TODO: check if any PDP contexts are deactivated on network 
side? */
@@ -792,7 +792,7 @@
[power_off] T.timeout {
setverdict(pass);
}
-   [not power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MT)) -> 
value bd {
+   [not power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MO)) -> 
value bd {
g_pars.ra := omit;
setverdict(pass);
/* TODO: check if any PDP contexts are deactivated on network 
side? */
@@ -1130,7 +1130,7 @@
 apars.apn, apars.pco));
alt {
/* We might want toalso actually expect a PDPC CTX ACT REJ? */
-   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MT(?, ?))) {
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MO(?, ?))) {
setverdict(pass);
}
[] GTP.receive(tr_GTPC_MsgType(?, createPDPContextRequest, ?)) {

--
To view, visit https://gerrit.osmocom.org/9245
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b5e2d43c9754d34b3749bff43b7df7196b9bb9c
Gerrit-Change-Number: 9245
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9248


Change subject: SGSN: add TC_hlr_location_cancel_request
..

SGSN: add TC_hlr_location_cancel_request

MS <-> SGSN: GMM Attach
HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Ack
MS  <- SGSN: Detach Request
SGSN->   MS: Detach Complete

Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 34 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/48/9248/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 36a4700..a2679cf 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1249,6 +1249,39 @@
 }


+private function f_TC_hlr_location_cancel_request_withdraw(charstring id) runs 
on BSSGP_ConnHdlr {
+   /* MS: perform regular attach */
+   f_TC_attach(id);
+
+   /* HLR: cancel the location request */
+   var GSUP_PDU gsup;
+   gsup := valueof(ts_GSUP_CL_REQ(g_pars.imsi, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW));
+   GSUP.send(gsup);
+   GSUP.receive(tr_GSUP_CL_RES(g_pars.imsi));
+   GSUP.send(ts_GSUP_UL_RES(g_pars.imsi));
+
+   /* MS: receive a Detach Request */
+   BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MT(c_GMM_DTT_MT_IMSI_DETACH, 
?, ?)));
+   BSSGP.send(ts_GMM_DET_ACCEPT_MT);
+
+   setverdict(pass);
+}
+
+testcase TC_hlr_location_cancel_request_withdraw() runs on test_CT {
+   /* MS <-> SGSN: GMM Attach
+* HLR -> SGSN: Cancel Location Request
+* HLR <- SGSN: Cancel Location Ack
+* MS  <- SGSN: Detach Request
+* SGSN->   MS: Detach Complete
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := 
f_start_handler(refers(f_TC_hlr_location_cancel_request_withdraw), 
testcasename(), g_gb[0], 29);
+   vc_conn.done;
+}
+
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1262,6 +1295,7 @@
execute( TC_attach_combined() );
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
+   execute( TC_hlr_location_cancel_request_withdraw(), 5.0 );
execute( TC_rau_unknown() );
execute( TC_attach_rau() );
execute( TC_detach_unknown_nopoweroff() );

--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request_update

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9251


Change subject: SGSN: add TC_hlr_location_cancel_request_update
..

SGSN: add TC_hlr_location_cancel_request_update

MS <-> SGSN: GMM Attach
HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Ack

Change-Id: I5d3a818eb0a4eb3b0d4bd7bd88874bd2ac6adb11
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 40 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/51/9251/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 860ca09..bce0241 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1249,6 +1249,45 @@
 }


+private function f_TC_hlr_location_cancel_request_update(charstring id) runs 
on BSSGP_ConnHdlr {
+   /* MS: perform regular attach */
+   f_TC_attach(id);
+
+   /* HLR: cancel the location request */
+   var GSUP_PDU gsup;
+   gsup := valueof(ts_GSUP_CL_REQ(g_pars.imsi, 
OSMO_GSUP_CANCEL_TYPE_UPDATE));
+   GSUP.send(gsup);
+   GSUP.receive(tr_GSUP_CL_RES(g_pars.imsi));
+   GSUP.send(ts_GSUP_UL_RES(g_pars.imsi));
+
+   /* ensure no Detach Request got received */
+   timer T := 5.0;
+   T.start;
+   alt {
+   [] 
BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MT(c_GMM_DTT_MT_IMSI_DETACH, ?, ?))) {
+   T.stop;
+   setverdict(fail, "Unexpected GMM Detach Request");
+}
+   [] T.timeout {
+   setverdict(pass);
+   self.stop;
+   }
+   }
+}
+
+testcase TC_hlr_location_cancel_request_update() runs on test_CT {
+   /* MS <-> SGSN: GMM Attach
+* HLR -> SGSN: Cancel Location Request
+* HLR <- SGSN: Cancel Location Ack
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := 
f_start_handler(refers(f_TC_hlr_location_cancel_request_update), 
testcasename(), g_gb[0], 31);
+   vc_conn.done;
+}
+
+
 private function f_TC_hlr_location_cancel_request_withdraw(charstring id) runs 
on BSSGP_ConnHdlr {
/* MS: perform regular attach */
f_TC_attach(id);
@@ -1344,6 +1383,7 @@
execute( TC_attach_combined() );
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
+   execute( TC_hlr_location_cancel_request_update(), 10.0 );
execute( TC_hlr_location_cancel_request_withdraw(), 5.0 );
execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
5.0 );
execute( TC_hlr_location_cancel_request_unknown_subscriber_update(), 
5.0 );

--
To view, visit https://gerrit.osmocom.org/9251
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d3a818eb0a4eb3b0d4bd7bd88874bd2ac6adb11
Gerrit-Change-Number: 9251
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-bsc[master]: fix misaligned memory write access in abis_nm_ipaccess_rsl_connect()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9242 )

Change subject: fix misaligned memory write access in 
abis_nm_ipaccess_rsl_connect()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9242
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e591a56ae522b371da01ea968151a7e6fa24bb9
Gerrit-Change-Number: 9242
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 22 May 2018 15:23:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: osmocon: Makefile.am: Fix build using different path

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9244


Change subject: osmocon: Makefile.am: Fix build using different path
..

osmocon: Makefile.am: Fix build using different path

Change-Id: I1a322e364612976f3d797f25e57ccc7c2354bd5e
---
M src/host/osmocon/Makefile.am
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/44/9244/1

diff --git a/src/host/osmocon/Makefile.am b/src/host/osmocon/Makefile.am
index 8b0d4bf..de4e575 100644
--- a/src/host/osmocon/Makefile.am
+++ b/src/host/osmocon/Makefile.am
@@ -13,9 +13,9 @@
 sbin_PROGRAMS = osmocon osmoload
 
 # FIXME: sercomm needs to move into libosmocore or another shared lib
-INCLUDES += -I../../target/firmware/include/comm -I../../target/firmware/apps 
-DHOST_BUILD
-osmocon_SOURCES = osmocon.c tpu_debug.c ../../target/firmware/comm/sercomm.c
+INCLUDES += -I$(srcdir)/../../target/firmware/include/comm 
-I$(srcdir)/../../target/firmware/apps -DHOST_BUILD
+osmocon_SOURCES = osmocon.c tpu_debug.c 
$(srcdir)/../../target/firmware/comm/sercomm.c
 osmocon_LDADD = $(LIBOSMOCORE_LIBS)

-osmoload_SOURCE = osmoload.c ../../target/firmware/comm/sercomm.c
+osmoload_SOURCE = osmoload.c $(srcdir)/../../target/firmware/comm/sercomm.c
 osmoload_LDADD = $(LIBOSMOCORE_LIBS)

--
To view, visit https://gerrit.osmocom.org/9244
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a322e364612976f3d797f25e57ccc7c2354bd5e
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: contrib: build-osmocom-bb: Download and install osmocom-bb fw from OBS

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9243


Change subject: contrib: build-osmocom-bb: Download and install osmocom-bb fw 
from OBS
..

contrib: build-osmocom-bb: Download and install osmocom-bb fw from OBS

As it's quite complex to build osmocom firmware nowadays (a specific old
release of gcc and binutils are required to build it), instead download
the already built binaries from OBS.

Change-Id: I2571268d91e2430a270e51438608e7dbd121e76d
---
M contrib/jenkins-build-osmocom-bb.sh
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/43/9243/1

diff --git a/contrib/jenkins-build-osmocom-bb.sh 
b/contrib/jenkins-build-osmocom-bb.sh
index f54518a..d5eec1e 100755
--- a/contrib/jenkins-build-osmocom-bb.sh
+++ b/contrib/jenkins-build-osmocom-bb.sh
@@ -5,6 +5,8 @@
 name="osmocom-bb"
 . "$(dirname "$0")/jenkins-build-common.sh"

+FW_RPM_URL="http://download.opensuse.org/repositories/home:/mnhauke:/osmocom:/nightly/SLE_15/x86_64/;
+
 build_repo libosmocore --disable-doxygen

 have_repo osmocom-bb
@@ -20,5 +22,12 @@
 set +x; echo; echo; set -x
 make install

+mkdir -p "$prefix"
+cd "$prefix"
+FW_RPM="$(wget -q -O - "$FW_RPM_URL" | grep -o 'osmocom-bb-firmware.*rpm' | 
sed 's#\"#\n#g' | head -1)"
+echo "Downloading RPM package $FW_RPM"
+wget -q "$FW_RPM_URL/$FW_RPM" -O osmocom-bb-firmware.rpm
+rpm2cpio osmocom-bb-firmware.rpm  | cpio -idmv
+rm osmocom-bb-firmware.rpm

 create_bin_tgz "" "osmocon"

--
To view, visit https://gerrit.osmocom.org/9243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2571268d91e2430a270e51438608e7dbd121e76d
Gerrit-Change-Number: 9243
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmocom-bb[master]: Move 'src/target_dsp' to 'target/calypso_dsp'

[Vadim Yanitskiy]

Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/9241 )

Change subject: Move 'src/target_dsp' to 'target/calypso_dsp'
..


Abandoned

Ok, np :) Too aggressive clean up from my side.
--
To view, visit https://gerrit.osmocom.org/9241
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1338d88fe1cbd6a27cf0bafe27b42ea5116c5b7e
Gerrit-Change-Number: 9241
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt 
Gerrit-CC: Harald Welte 

Change in osmocom-bb[master]: README.development: cosmetic: correct/add wiki links

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9238 )

Change subject: README.development: cosmetic: correct/add wiki links
..

README.development: cosmetic: correct/add wiki links

Change-Id: Ib17196044f276d05269dbdb5a5a1444202fa0e07
---
M src/README.development
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/README.development b/src/README.development
index 1963b5a..060cbd9 100644
--- a/src/README.development
+++ b/src/README.development
@@ -1,18 +1,24 @@
 = Contributing to OsmocomBB development =

 Feel free to help us by extending the code.  Always make sure to
-send back all your patches to the baseband-de...@lists.osmocom.org
-mailing list - Free Software is all about sharing.
+send back all your patches to Gerrit (recommended) or to the
+baseband-de...@lists.osmocom.org mailing list - Free Software
+is all about sharing. For details, see:
+
+https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit
+https://gerrit.osmocom.org/

 == Coding Style ==

 Like all C language Osmocom projects, we use the Linux Kernel coding
 style, you can find it in the Documentation/CodingStyle subdirectory
-of any Linux Kernel source.
+of any Linux Kernel source. For details, see:
+
+https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

 == More Information ==

-Please consult the http://bb.osmocom.org/ web page / wiki.
+Please consult the https://osmocom.org/projects/baseband/wiki/.

 If you have any technical questions regarding the code, don't hesitate
 to ask the baseband-de...@lists.osmocom.org mailing list.

--
To view, visit https://gerrit.osmocom.org/9238
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib17196044f276d05269dbdb5a5a1444202fa0e07
Gerrit-Change-Number: 9238
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmocom-bb[master]: README.building: cosmetic: correct wiki links

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9237 )

Change subject: README.building: cosmetic: correct wiki links
..

README.building: cosmetic: correct wiki links

Change-Id: I0fd8fdc7aecdf04266898eaadd05f1f0c705bb5c
---
M src/README.building
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/README.building b/src/README.building
index f73f661..d7cc794 100644
--- a/src/README.building
+++ b/src/README.building
@@ -8,13 +8,15 @@
 this.

  * Make sure you have compiled and installed a recent version of
-   libosmocore. See http://bb.osmocom.org/trac/wiki/libosmocore
+   libosmocore. See https://osmocom.org/projects/libosmocore/wiki/Libosmocore

DO NOT USE the libosmocore version embedded in this git tree. This
is a special version used internally and MUST NOT be used as
system-wide libosmocore.

  * Get a GNU toolchain (gcc/binutils) for ARM (e.g. from http://gnuarm.com/)
+   See https://osmocom.org/projects/baseband/wiki/GnuArmToolchain
+
  * Set your path to include the arm-elf-* executables of your toolchain

  * call 'make' in this (the src) subdirectory

--
To view, visit https://gerrit.osmocom.org/9237
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fd8fdc7aecdf04266898eaadd05f1f0c705bb5c
Gerrit-Change-Number: 9237
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmocom-bb[master]: include/osmocore: remove unused headers

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9236 )

Change subject: include/osmocore: remove unused headers
..

include/osmocore: remove unused headers

Both removed headers are not used anywhere, and probably left
from the time when there was no libosmocore as a shared library.

Change-Id: I821e2958e07176c1031c636019dffd1cee62bb10
---
D include/osmocore/rsl.h
D include/osmocore/utils.h
2 files changed, 0 insertions(+), 41 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocore/rsl.h b/include/osmocore/rsl.h
deleted file mode 100644
index c9375a7..000
--- a/include/osmocore/rsl.h
+++ /dev/null
@@ -1,24 +0,0 @@
-#ifndef _OSMOCORE_RSL_H
-#define _OSMOCORE_RSL_H
-
-#include 
-#include 
-#include 
-
-void rsl_init_rll_hdr(struct abis_rsl_rll_hdr *dh, uint8_t msg_type);
-
-extern const struct tlv_definition rsl_att_tlvdef;
-#define rsl_tlv_parse(dec, buf, len) \
-   tlv_parse(dec, _att_tlvdef, buf, len, 0, 0)
-
-/* encode channel number as per Section 9.3.1 */
-uint8_t rsl_enc_chan_nr(uint8_t type, uint8_t subch, uint8_t timeslot);
-
-const struct value_string rsl_rlm_cause_strs[];
-
-const char *rsl_err_name(uint8_t err);
-
-/* Section 3.3.2.3 TS 05.02. I think this looks like a table */
-int rsl_ccch_conf_to_bs_cc_chans(int ccch_conf);
-
-#endif /* _OSMOCORE_RSL_H */
diff --git a/include/osmocore/utils.h b/include/osmocore/utils.h
deleted file mode 100644
index cf3b460..000
--- a/include/osmocore/utils.h
+++ /dev/null
@@ -1,17 +0,0 @@
-#ifndef OSMOCORE_UTIL_H
-#define OSMOCORE_UTIL_H
-
-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
-
-#include 
-
-struct value_string {
-   unsigned int value;
-   const char *str;
-};
-
-const char *get_value_string(const struct value_string *vs, uint32_t val);
-int get_string_value(const struct value_string *vs, const char *str);
-
-
-#endif

--
To view, visit https://gerrit.osmocom.org/9236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I821e2958e07176c1031c636019dffd1cee62bb10
Gerrit-Change-Number: 9236
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: include/osmocore: remove unused headers

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9236 )

Change subject: include/osmocore: remove unused headers
..


Patch Set 1: Code-Review+2

no idea why we have those additional include files. Remove them, sure.


--
To view, visit https://gerrit.osmocom.org/9236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I821e2958e07176c1031c636019dffd1cee62bb10
Gerrit-Change-Number: 9236
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 22 May 2018 12:05:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: README.development: add brief info about the TRX Toolkit

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9239 )

Change subject: README.development: add brief info about the TRX Toolkit
..

README.development: add brief info about the TRX Toolkit

Change-Id: I589a5e0a1b41439aabc59e97aca378d16f4e4cc5
---
M src/README.development
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/README.development b/src/README.development
index 060cbd9..6482143 100644
--- a/src/README.development
+++ b/src/README.development
@@ -65,6 +65,15 @@
* board/compal_e99 is the Motorola C155 family
  * Applications (each app builds one firmware image) in apps/

+=== src/target/trx_toolkit ===
+
+A set of tools in Python for debugging TRX interface and creating
+a virtual Um-interface between OsmocomBB and OsmoBTS. For details,
+please refer:
+
+https://osmocom.org/projects/baseband/wiki/TRX_Interface
+https://osmocom.org/projects/baseband/wiki/FakeTRX
+target/trx_toolkit/README

 === src/target_dsp/calypso ===

@@ -75,4 +84,3 @@

 The Layer2 (LAPDm / TS 04.06) and Layer3 (CC/MM/RR / TS 04.08)
 implementations, as they are growing.
-

--
To view, visit https://gerrit.osmocom.org/9239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I589a5e0a1b41439aabc59e97aca378d16f4e4cc5
Gerrit-Change-Number: 9239
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bsc[master]: fix misaligned memory write access in abis_nm_ipaccess_rsl_connect()

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/9242


Change subject: fix misaligned memory write access in 
abis_nm_ipaccess_rsl_connect()
..

fix misaligned memory write access in abis_nm_ipaccess_rsl_connect()

Use memcpy() to avoid unaligned access, instead of writing through a
pointer cast to uint32_t. Problem spotted by address sanitizer:

abis_nm.c:2802:24: runtime error: store to misaligned address 0x7ffc95396706
for type 'uint32_t', which requires 4 byte alignment
0x7ffc95396706: note: pointer points here
 81 0b bb 80 00 00  00 00 ed 79 28 56 00 00  e0 9c 00 00 a0 61 00 00 ...
 ^
Related: OS#3196

Change-Id: I8e591a56ae522b371da01ea968151a7e6fa24bb9
---
M src/libbsc/abis_nm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/9242/1

diff --git a/src/libbsc/abis_nm.c b/src/libbsc/abis_nm.c
index b2cfa53..ea94d37 100644
--- a/src/libbsc/abis_nm.c
+++ b/src/libbsc/abis_nm.c
@@ -2799,7 +2799,7 @@
attr[1] = stream;
attr[3] = port >> 8;
attr[4] = port & 0xff;
-   *(uint32_t *)(attr+6) = ia.s_addr;
+   memcpy(attr + 6, _addr, sizeof(uint32_t));

/* if ip == 0, we use the default IP */
if (ip == 0)

--
To view, visit https://gerrit.osmocom.org/9242
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e591a56ae522b371da01ea968151a7e6fa24bb9
Gerrit-Change-Number: 9242
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 

Change in osmocom-bb[master]: Move 'src/target_dsp' to 'target/calypso_dsp'

[tnt]

tnt has posted comments on this change. ( https://gerrit.osmocom.org/9241 )

Change subject: Move 'src/target_dsp' to 'target/calypso_dsp'
..


Patch Set 1:

Err .. yeah, pretty much same as Harald. Doesn't bother me to have this merged, 
but it seems a bit pointless.


--
To view, visit https://gerrit.osmocom.org/9241
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1338d88fe1cbd6a27cf0bafe27b42ea5116c5b7e
Gerrit-Change-Number: 9241
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 22 May 2018 10:15:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-mgw[master]: mgcp_sdp: correct apidoc of mgcp_parse_sdp_data

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9233 )

Change subject: mgcp_sdp: correct apidoc of mgcp_parse_sdp_data
..

mgcp_sdp: correct apidoc of mgcp_parse_sdp_data

The API documentation of mgcp_parse_sdp_data is incorrect.

- correct API documentation

Change-Id: I9906f1dd6811c7092b93d60c9348221fef68cc3e
---
M src/libosmo-mgcp/mgcp_sdp.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c
index 52b4df4..5c66a83 100644
--- a/src/libosmo-mgcp/mgcp_sdp.c
+++ b/src/libosmo-mgcp/mgcp_sdp.c
@@ -205,10 +205,10 @@
  *  \param[in] endp trunk endpoint.
  *  \param[out] conn associated rtp connection.
  *  \param[out] caller provided memory to store the parsing results.
- *  \returns 0 on success, -1 on failure.
+ *  \returns 1 when codecs are assigned, 0 when no codecs are assigned.
  *
  *  Note: In conn (conn->end) the function returns the packet duration,
- *  the rtp port and the rtcp port */
+ *  rtp port, rtcp port and the assigned codecs (codec and alt_codec). */
 int mgcp_parse_sdp_data(const struct mgcp_endpoint *endp,
struct mgcp_conn_rtp *conn,
struct mgcp_parse_data *p)

--
To view, visit https://gerrit.osmocom.org/9233
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9906f1dd6811c7092b93d60c9348221fef68cc3e
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmocom-bb[master]: Move 'src/target_dsp' to 'target/calypso_dsp'

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9241 )

Change subject: Move 'src/target_dsp' to 'target/calypso_dsp'
..


Patch Set 1:

I don't really care about it too much.  But I also don't really see the gain of 
this change, sorry.  Adding Sylvain, as it's his code anyway.


--
To view, visit https://gerrit.osmocom.org/9241
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1338d88fe1cbd6a27cf0bafe27b42ea5116c5b7e
Gerrit-Change-Number: 9241
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 22 May 2018 10:00:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: Remove the patches for Wireshark

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9240 )

Change subject: Remove the patches for Wireshark
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448dc5a3dba3ecc6fc041861239dc23cca72b70b
Gerrit-Change-Number: 9240
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 22 May 2018 09:59:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: README.development: add brief info about the TRX Toolkit

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9239 )

Change subject: README.development: add brief info about the TRX Toolkit
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I589a5e0a1b41439aabc59e97aca378d16f4e4cc5
Gerrit-Change-Number: 9239
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 22 May 2018 09:59:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: README.building: cosmetic: correct wiki links

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9237 )

Change subject: README.building: cosmetic: correct wiki links
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9237
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fd8fdc7aecdf04266898eaadd05f1f0c705bb5c
Gerrit-Change-Number: 9237
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 22 May 2018 09:59:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: include/osmocore: remove unused headers

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9236 )

Change subject: include/osmocore: remove unused headers
..


Patch Set 1: Code-Review-2

we don't do modifications to the git-subtree of libosmocore here.  The 
libosmocore in osmocom-bb reflects a single, tagged version of upstream 
libosmocore.git


--
To view, visit https://gerrit.osmocom.org/9236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I821e2958e07176c1031c636019dffd1cee62bb10
Gerrit-Change-Number: 9236
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 22 May 2018 09:58:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 22 May 2018 09:57:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: nat: Add jitter buffer on the uplink receiver

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9214 )

Change subject: nat: Add jitter buffer on the uplink receiver
..

nat: Add jitter buffer on the uplink receiver

Default usage values are defined in mgcp node, and can be per-BSC
overriden on each bsc node.

This commit is a forward-port of openbsc.git Change-Id
Ibf3932adc07442fb5e9c7a06404853f9d0a20959.

Depends on osmo-mgw.git Change-Id Ie19a64ac09f9d51f2434ad0d7925610fc919a90e.

Change-Id: Ie07b8a577caf731d59d68e3b3510ae2f9fd3dc93
---
M include/osmocom/bsc/bsc_nat.h
M src/osmo-bsc_nat/bsc_mgcp_utils.c
M src/osmo-bsc_nat/bsc_nat_vty.c
3 files changed, 96 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/bsc_nat.h b/include/osmocom/bsc/bsc_nat.h
index 6146c00..bd78b9d 100644
--- a/include/osmocom/bsc/bsc_nat.h
+++ b/include/osmocom/bsc/bsc_nat.h
@@ -175,6 +175,16 @@

/* Osmux is enabled/disabled per BSC */
int osmux;
+
+   /* Use a jitterbuffer on the bts-side receiver */
+   bool bts_use_jibuf;
+   /* Minimum and maximum buffer size for the jitter buffer, in ms */
+   uint32_t bts_jitter_delay_min;
+   uint32_t bts_jitter_delay_max;
+   /* Enabled if explicitly configured through VTY: */
+   bool bts_use_jibuf_override;
+   bool bts_jitter_delay_min_override;
+   bool bts_jitter_delay_max_override;
 };
 
 struct bsc_lac_entry {
diff --git a/src/osmo-bsc_nat/bsc_mgcp_utils.c 
b/src/osmo-bsc_nat/bsc_mgcp_utils.c
index bf6d0ad..ab06a5e 100644
--- a/src/osmo-bsc_nat/bsc_mgcp_utils.c
+++ b/src/osmo-bsc_nat/bsc_mgcp_utils.c
@@ -585,6 +585,17 @@
if (state == MGCP_ENDP_CRCX) {
struct sockaddr_in sock;

+   /* set up jitter buffer parameters */
+   if (bsc_endp->bsc->cfg->bts_use_jibuf_override)
+   mgcp_endp->bts_use_jibuf = 
bsc_endp->bsc->cfg->bts_use_jibuf;
+
+   if (bsc_endp->bsc->cfg->bts_jitter_delay_min_override)
+   mgcp_endp->bts_jitter_delay_min = 
bsc_endp->bsc->cfg->bts_jitter_delay_min;
+
+   if (bsc_endp->bsc->cfg->bts_jitter_delay_max_override)
+   mgcp_endp->bts_jitter_delay_max = 
bsc_endp->bsc->cfg->bts_jitter_delay_max;
+
+
/* Annotate the allocated Osmux CID until the bsc confirms that
 * it agrees to use Osmux for this voice flow.
 */
diff --git a/src/osmo-bsc_nat/bsc_nat_vty.c b/src/osmo-bsc_nat/bsc_nat_vty.c
index 64608bd..5d8d0c7 100644
--- a/src/osmo-bsc_nat/bsc_nat_vty.c
+++ b/src/osmo-bsc_nat/bsc_nat_vty.c
@@ -173,6 +173,12 @@
vty_out(vty, "  osmux only%s", VTY_NEWLINE);
break;
}
+   if (bsc->bts_use_jibuf_override)
+   vty_out(vty, "  %sbts-jitter-buffer%s", bsc->bts_use_jibuf? "" 
: "no ", VTY_NEWLINE);
+   if (bsc->bts_jitter_delay_min_override)
+   vty_out(vty, "  bts-jitter-delay-min %"PRIu32"%s", 
bsc->bts_jitter_delay_min, VTY_NEWLINE);
+   if (bsc->bts_jitter_delay_max_override)
+   vty_out(vty, "  bts-jitter-delay-max %"PRIu32"%s", 
bsc->bts_jitter_delay_max, VTY_NEWLINE);
 }

 static int config_write_bsc(struct vty *vty)
@@ -1231,6 +1237,71 @@
return CMD_SUCCESS;
 }

+#define DEJITTER_STR "Uplink Jitter Buffer"
+DEFUN(cfg_bsc_bts_use_jibuf,
+  cfg_bsc_bts_use_jibuf_cmd,
+  "bts-jitter-buffer",
+  DEJITTER_STR "\n")
+{
+   struct bsc_config *conf = vty->index;
+   conf->bts_use_jibuf = true;
+   conf->bts_use_jibuf_override = true;
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_bsc_no_bts_use_jibuf,
+  cfg_bsc_no_bts_use_jibuf_cmd,
+  "no bts-jitter-buffer",
+  NO_STR DEJITTER_STR "\n")
+{
+   struct bsc_config *conf = vty->index;
+   conf->bts_use_jibuf = false;
+   conf->bts_use_jibuf_override = true;
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_bsc_bts_jitter_delay_min,
+  cfg_bsc_bts_jitter_delay_min_cmd,
+  "bts-jitter-buffer-delay-min <1-65535>",
+  DEJITTER_STR " Minimum Delay in ms\n" "Minimum Delay in ms\n")
+{
+   struct bsc_config *conf = vty->index;
+   conf->bts_jitter_delay_min = atoi(argv[0]);
+   if (!conf->bts_jitter_delay_min) {
+   vty_out(vty, "bts-jitter-buffer-delay-min cannot be zero.%s", 
VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+   if (conf->bts_jitter_delay_min && conf->bts_jitter_delay_max &&
+   conf->bts_jitter_delay_min > conf->bts_jitter_delay_max) {
+   vty_out(vty, "bts-jitter-buffer-delay-min cannot be bigger than 
" \
+   "bts-jitter-buffer-delay-max.%s", VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+   conf->bts_jitter_delay_min_override = true;
+   return CMD_SUCCESS;
+}
+

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..

add counter for connection attempts from BTS with unknown unit id

Add a global counter to the BSC which shows the number of failed
connections attempts due to a unit_id mismatch between the BSC
and the BTS.

Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Related: OS#3245
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bts_ipaccess_nanobts.c
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 6365938..6f854d8 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1128,6 +1128,7 @@
BSC_CTR_PAGING_ATTEMPTED,
BSC_CTR_PAGING_DETACHED,
BSC_CTR_PAGING_RESPONDED,
+   BSC_CTR_UNKNOWN_UNIT_ID,
 };

 static const struct rate_ctr_desc bsc_ctr_description[] = {
@@ -1140,6 +1141,8 @@
[BSC_CTR_PAGING_ATTEMPTED] ={"paging:attempted", "Paging 
attempts for a subscriber."},
[BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging 
request send failures because no responsible BTS was found."},
[BSC_CTR_PAGING_RESPONDED] ={"paging:responded", "Paging 
attempts with successful response."},
+
+   [BSC_CTR_UNKNOWN_UNIT_ID] = {"abis:unknown_unit_id", 
"Connection attempts from unknown IPA CCM Unit ID."},
 };


diff --git a/src/libbsc/bts_ipaccess_nanobts.c 
b/src/libbsc/bts_ipaccess_nanobts.c
index d5b3b21..823fd66 100644
--- a/src/libbsc/bts_ipaccess_nanobts.c
+++ b/src/libbsc/bts_ipaccess_nanobts.c
@@ -468,6 +468,7 @@
LOGP(DLINP, LOGL_ERROR, "Unable to find BTS configuration for "
" %u/%u/%u, disconnecting\n", dev->site_id,
dev->bts_id, dev->trx_id);
+   
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_UNKNOWN_UNIT_ID]);
return NULL;
}
DEBUGP(DLINP, "Identified BTS %u/%u/%u\n",

--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-bsc[master]: nat: Add jitter buffer on the uplink receiver

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9214 )

Change subject: nat: Add jitter buffer on the uplink receiver
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9214
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07b8a577caf731d59d68e3b3510ae2f9fd3dc93
Gerrit-Change-Number: 9214
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 22 May 2018 09:57:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: nat: Add jitter buffer on the uplink receiver

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9214 )

Change subject: nat: Add jitter buffer on the uplink receiver
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h
File include/osmocom/bsc/bsc_nat.h:

https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h@180
PS1, Line 180:  bool bts_use_jibuf;
> I would prefer something like a sub-structure  […]
Makes sense. However, as this commit is just a forward-port from openbsc, I 
think it's better to merge this one as it is, and then do these modification in 
a follow-up commit.



--
To view, visit https://gerrit.osmocom.org/9214
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07b8a577caf731d59d68e3b3510ae2f9fd3dc93
Gerrit-Change-Number: 9214
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 22 May 2018 09:35:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

[Stefan Sperling]

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9218

to look at the new patch set (#4).

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..

add counter for connection attempts from BTS with unknown unit id

Add a global counter to the BSC which shows the number of failed
connections attempts due to a unit_id mismatch between the BSC
and the BTS.

Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Related: OS#3245
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bts_ipaccess_nanobts.c
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/9218/4
--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3:

> One might think of implementing this somewhere generic in a
 > library, but I think we still have three IPA. implementations
 > around. In terms of naming, some reference to abis would be good,
 > as other interfaces (A, CTRL, ...) May also use IPA

Having reviewed the protocol layering between BTS and BSC, I agree that "abis" 
is a better prefix for the description of this counter.


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 22 May 2018 08:15:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: include/osmocore: remove unused headers

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9236 )

Change subject: include/osmocore: remove unused headers
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I821e2958e07176c1031c636019dffd1cee62bb10
Gerrit-Change-Number: 9236
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 22 May 2018 07:56:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Jenkins build is back to normal : master-osmo-pcu » master,osmocom-master-debian9,none,False #488

[jenkins]

See