Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  338s] No package 'libpcsclite' found
[  338s] simtrace2-remsim.o: In function `main':
[  338s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  338s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  338s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  338s] apdu_dispatch.o: In function `apdu_segment_in':
[  338s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  338s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  338s] collect2: error: ld returned 1 exit status
[  338s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  338s] make[2]: *** [simtrace2-remsim] Error 1
[  338s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  338s] Makefile:20: recipe for target 'utils' failed
[  338s] make[1]: *** [utils] Error 2
[  338s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  338s] dh_auto_build: make -j1 returned exit code 2
[  338s] debian/rules:4: recipe for target 'build' failed
[  338s] make: *** [build] Error 2
[  338s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  338s] 
[  338s] armbuild17 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:50:57 UTC 2018.
[  338s] 
[  338s] ### VM INTERACTION START ###
[  342s] [  303.055150] SysRq : Power Off
[  342s] [  303.056747] reboot: Power down
[  342s] ### VM INTERACTION END ###
[  342s] 
[  342s] armbuild17 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:51:01 UTC 2018.
[  342s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  194s] No package 'libpcsclite' found
[  194s] simtrace2-remsim.o: In function `main':
[  194s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  194s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  194s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  194s] apdu_dispatch.o: In function `apdu_segment_in':
[  194s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  194s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  194s] collect2: error: ld returned 1 exit status
[  194s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  194s] make[2]: *** [simtrace2-remsim] Error 1
[  195s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  195s] Makefile:20: recipe for target 'utils' failed
[  195s] make[1]: *** [utils] Error 2
[  195s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  195s] dh_auto_build: make -j1 returned exit code 2
[  195s] debian/rules:4: recipe for target 'build' failed
[  195s] make: *** [build] Error 2
[  195s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  195s] 
[  195s] cloud119 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:21:18 UTC 2018.
[  195s] 
[  195s] ### VM INTERACTION START ###
[  198s] [  172.633733] sysrq: SysRq : Power Off
[  198s] [  172.656443] reboot: Power down
[  199s] ### VM INTERACTION END ###
[  199s] 
[  199s] cloud119 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:21:24 UTC 2018.
[  199s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  269s] No package 'libpcsclite' found
[  269s] simtrace2-remsim.o: In function `main':
[  269s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  269s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  269s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  269s] apdu_dispatch.o: In function `apdu_segment_in':
[  269s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  269s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  269s] collect2: error: ld returned 1 exit status
[  269s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  269s] make[2]: *** [simtrace2-remsim] Error 1
[  269s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  269s] Makefile:20: recipe for target 'utils' failed
[  269s] make[1]: *** [utils] Error 2
[  269s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  269s] dh_auto_build: make -j1 returned exit code 2
[  269s] debian/rules:4: recipe for target 'build' failed
[  269s] make: *** [build] Error 2
[  269s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  269s] 
[  269s] lamb23 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:21:20 UTC 2018.
[  269s] 
[  269s] ### VM INTERACTION START ###
[  273s] [  260.905266] sysrq: SysRq : Power Off
[  273s] [  260.987822] reboot: Power down
[  273s] ### VM INTERACTION END ###
[  273s] 
[  273s] lamb23 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:21:25 UTC 2018.
[  273s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  206s] No package 'libpcsclite' found
[  206s] simtrace2-remsim.o: In function `main':
[  206s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  206s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  206s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  206s] apdu_dispatch.o: In function `apdu_segment_in':
[  206s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  206s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  206s] collect2: error: ld returned 1 exit status
[  206s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  206s] make[2]: *** [simtrace2-remsim] Error 1
[  206s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  206s] Makefile:20: recipe for target 'utils' failed
[  206s] make[1]: *** [utils] Error 2
[  206s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  206s] dh_auto_build: make -j1 returned exit code 2
[  206s] debian/rules:4: recipe for target 'build' failed
[  206s] make: *** [build] Error 2
[  206s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  206s] 
[  206s] lamb26 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:20:18 UTC 2018.
[  206s] 
[  206s] ### VM INTERACTION START ###
[  209s] [  195.319065] sysrq: SysRq : Power Off
[  209s] [  195.324547] reboot: Power down
[  210s] ### VM INTERACTION END ###
[  210s] 
[  210s] lamb26 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:20:23 UTC 2018.
[  210s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  146s] No package 'libpcsclite' found
[  146s] simtrace2-remsim.o: In function `main':
[  146s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  146s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  146s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  146s] apdu_dispatch.o: In function `apdu_segment_in':
[  146s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  146s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  146s] collect2: error: ld returned 1 exit status
[  146s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  146s] make[2]: *** [simtrace2-remsim] Error 1
[  146s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  146s] Makefile:20: recipe for target 'utils' failed
[  146s] make[1]: *** [utils] Error 2
[  146s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  146s] dh_auto_build: make -j1 returned exit code 2
[  146s] debian/rules:4: recipe for target 'build' failed
[  146s] make: *** [build] Error 2
[  146s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  146s] 
[  146s] lamb21 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:19:23 UTC 2018.
[  146s] 
[  146s] ### VM INTERACTION START ###
[  149s] [  138.026670] sysrq: SysRq : Power Off
[  149s] [  138.031861] reboot: Power down
[  149s] ### VM INTERACTION END ###
[  149s] 
[  149s] lamb21 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:19:27 UTC 2018.
[  149s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  183s] No package 'libpcsclite' found
[  183s] simtrace2-remsim.o: In function `main':
[  183s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  183s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  183s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  183s] apdu_dispatch.o: In function `apdu_segment_in':
[  183s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  183s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  183s] collect2: error: ld returned 1 exit status
[  183s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  183s] make[2]: *** [simtrace2-remsim] Error 1
[  183s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  183s] Makefile:20: recipe for target 'utils' failed
[  183s] make[1]: *** [utils] Error 2
[  183s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  183s] dh_auto_build: make -j1 returned exit code 2
[  183s] debian/rules:4: recipe for target 'build' failed
[  183s] make: *** [build] Error 2
[  183s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  183s] 
[  183s] wildcard2 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:16:33 UTC 2018.
[  183s] 
[  183s] ### VM INTERACTION START ###
[  187s] [  157.975833] sysrq: SysRq : Power Off
[  187s] [  157.978794] reboot: Power down
[  189s] ### VM INTERACTION END ###
[  189s] 
[  189s] wildcard2 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:16:39 UTC 2018.
[  189s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  155s] No package 'libpcsclite' found
[  155s] simtrace2-remsim.o: In function `main':
[  155s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  155s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  155s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  155s] apdu_dispatch.o: In function `apdu_segment_in':
[  155s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  155s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  155s] collect2: error: ld returned 1 exit status
[  155s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  155s] make[2]: *** [simtrace2-remsim] Error 1
[  155s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  155s] Makefile:20: recipe for target 'utils' failed
[  155s] make[1]: *** [utils] Error 2
[  155s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  155s] dh_auto_build: make -j1 returned exit code 2
[  155s] debian/rules:4: recipe for target 'build' failed
[  155s] make: *** [build] Error 2
[  155s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  155s] 
[  155s] lamb18 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:13:58 UTC 2018.
[  155s] 
[  155s] ### VM INTERACTION START ###
[  158s] [  146.564970] sysrq: SysRq : Power Off
[  158s] [  146.570111] reboot: Power down
[  159s] ### VM INTERACTION END ###
[  159s] 
[  159s] lamb18 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:14:03 UTC 2018.
[  159s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  141s] No package 'libpcsclite' found
[  141s] simtrace2-remsim.o: In function `main':
[  141s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  141s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  141s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  141s] apdu_dispatch.o: In function `apdu_segment_in':
[  141s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  141s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  141s] collect2: error: ld returned 1 exit status
[  141s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  141s] make[2]: *** [simtrace2-remsim] Error 1
[  141s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  141s] Makefile:20: recipe for target 'utils' failed
[  141s] make[1]: *** [utils] Error 2
[  141s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  141s] dh_auto_build: make -j1 returned exit code 2
[  141s] debian/rules:4: recipe for target 'build' failed
[  141s] make: *** [build] Error 2
[  141s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  141s] 
[  141s] build70 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:11:58 UTC 2018.
[  141s] 
[  141s] ### VM INTERACTION START ###
[  144s] [  133.326777] sysrq: SysRq : Power Off
[  144s] [  133.329218] reboot: Power down
[  144s] ### VM INTERACTION END ###
[  144s] 
[  144s] build70 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:12:02 UTC 2018.
[  144s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  150s] No package 'libpcsclite' found
[  150s] simtrace2-remsim.o: In function `main':
[  150s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  150s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  150s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  150s] apdu_dispatch.o: In function `apdu_segment_in':
[  150s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  150s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  150s] collect2: error: ld returned 1 exit status
[  150s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  150s] make[2]: *** [simtrace2-remsim] Error 1
[  150s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  150s] Makefile:20: recipe for target 'utils' failed
[  150s] make[1]: *** [utils] Error 2
[  150s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  150s] dh_auto_build: make -j1 returned exit code 2
[  150s] debian/rules:4: recipe for target 'build' failed
[  150s] make: *** [build] Error 2
[  150s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  150s] 
[  150s] lamb55 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:06:12 UTC 2018.
[  150s] 
[  150s] ### VM INTERACTION START ###
[  153s] [  138.894968] sysrq: SysRq : Power Off
[  153s] [  138.901052] reboot: Power down
[  153s] ### VM INTERACTION END ###
[  153s] 
[  153s] lamb55 failed "build simtrace2_0.5.1.14.faf1.dsc" at Fri Sep  7 
20:06:15 UTC 2018.
[  153s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmo-sccp[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10843

to look at the new patch set (#2).

Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
---
M Makefile.am
M configure.ac
A contrib/Makefile.am
A contrib/systemd/Makefile.am
M debian/osmo-stp.install
D debian/osmo-stp.service
M debian/rules
7 files changed, 29 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/43/10843/2
--
To view, visit https://gerrit.osmocom.org/10843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
Gerrit-Change-Number: 10843
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in libosmo-sccp[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10843 )

Change subject: Install systemd services with autotools
..


Patch Set 1:

Following https://www.freedesktop.org/software/systemd/man/daemon.html

Tested in my OBS branch that package builds fine and ends up with 
osmo-stp.service.

Once it's reviewed, I plan to do this for all systemd services.


--
To view, visit https://gerrit.osmocom.org/10843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
Gerrit-Change-Number: 10843
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 18:23:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-sccp[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10843


Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
---
M Makefile.am
M configure.ac
A contrib/Makefile.am
A contrib/systemd/Makefile.am
M debian/osmo-stp.install
D debian/osmo-stp.service
M debian/rules
7 files changed, 28 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/43/10843/1

diff --git a/Makefile.am b/Makefile.am
index 3f4de13..7d09259 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,13 +1,16 @@
 AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src tests examples stp doc
+SUBDIRS = include src tests examples stp doc contrib

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmo-sccp.pc libosmo-mtp.pc libosmo-sigtran.pc 
libosmo-xua.pc

 EXTRA_DIST = .version git-version-gen osmoappdesc.py doc/examples/osmo-stp.cfg

+DISTCHECK_CONFIGURE_FLAGS = \
+  --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
+
 @RELMAKE@

 BUILT_SOURCES = $(top_srcdir)/.version
diff --git a/configure.ac b/configure.ac
index c0cc488..af64bc0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -98,6 +98,21 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")

+# https://www.freedesktop.org/software/systemd/man/daemon.html
+AC_ARG_WITH([systemdsystemunitdir],
+ [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
+ [with_systemdsystemunitdir=auto])
+AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
+ def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
+ AS_IF([test "x$def_systemdsystemunitdir" = "x"],
+   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
+[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
+with_systemdsystemunitdir=no],
+   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
+AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
+  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
+AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
+
 AC_MSG_RESULT([CFLAGS="$CFLAGS"])
 AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])

@@ -122,5 +137,7 @@
 stp/Makefile
 doc/Makefile
 doc/examples/Makefile
+contrib/Makefile
+contrib/systemd/Makefile
 Doxyfile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
new file mode 100644
index 000..3439c97
--- /dev/null
+++ b/contrib/Makefile.am
@@ -0,0 +1 @@
+SUBDIRS = systemd
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
new file mode 100644
index 000..d6a94e7
--- /dev/null
+++ b/contrib/systemd/Makefile.am
@@ -0,0 +1,4 @@
+if HAVE_SYSTEMD
+systemdsystemunit_DATA = \
+  osmo-stp.service
+endif
diff --git a/debian/osmo-stp.install b/debian/osmo-stp.install
index b2f8077..2c250b0 100644
--- a/debian/osmo-stp.install
+++ b/debian/osmo-stp.install
@@ -1,2 +1,3 @@
+/lib/sytemd/system/osmo-stp.service
 /usr/bin/osmo-stp
 /usr/share/doc/libosmo-sccp/examples/osmo-stp/osmo-stp.cfg
diff --git a/debian/osmo-stp.service b/debian/osmo-stp.service
deleted file mode 12
index 55f37c2..000
--- a/debian/osmo-stp.service
+++ /dev/null
@@ -1 +0,0 @@
-../contrib/systemd/osmo-stp.service
\ No newline at end of file
diff --git a/debian/rules b/debian/rules
index bea0a76..c0c9f0c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -24,7 +24,7 @@
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)

 override_dh_auto_configure:
-   dh_auto_configure -- --enable-static
+   dh_auto_configure -- --enable-static 
--with-systemdsystemunitdir=/lib/sytemd/system

 # Print test results in case of a failure
 override_dh_auto_test:

--
To view, visit https://gerrit.osmocom.org/10843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
Gerrit-Change-Number: 10843
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10717 )

Change subject: UHHDDevice: Replace deprecated header 
uhd/utils/thread_priority.hpp
..


Patch Set 2:

> I saw this warning, too.  The question is: When was that moved?
 > What kind of compatibility to old UHD versions are we dropping with
 > your proposed patch?

With 2nd version of this patch I already posted we don't loose compatibility, 
since old version will continue to use thread_priority.hpp.


--
To view, visit https://gerrit.osmocom.org/10717
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 07 Sep 2018 17:55:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: add vty config for GSMTAP-SAPI host (-i)

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10808 )

Change subject: add vty config for GSMTAP-SAPI host (-i)
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 17:41:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10717 )

Change subject: UHHDDevice: Replace deprecated header 
uhd/utils/thread_priority.hpp
..


Patch Set 2:

I saw this warning, too.  The question is: When was that moved? What kind of 
compatibility to old UHD versions are we dropping with your proposed patch?


--
To view, visit https://gerrit.osmocom.org/10717
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 07 Sep 2018 16:42:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in openbsc[master]: systemd: describe osmo-bsc-sccplite service as legacy

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10833 )

Change subject: systemd: describe osmo-bsc-sccplite service as legacy
..

systemd: describe osmo-bsc-sccplite service as legacy

Change-Id: I88ba349e547c8f85e12e1ad80a2724086c489c02
---
M openbsc/contrib/systemd/osmo-bsc-sccplite.service
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/contrib/systemd/osmo-bsc-sccplite.service 
b/openbsc/contrib/systemd/osmo-bsc-sccplite.service
index 70cda5f..3edd35c 100644
--- a/openbsc/contrib/systemd/osmo-bsc-sccplite.service
+++ b/openbsc/contrib/systemd/osmo-bsc-sccplite.service
@@ -1,5 +1,5 @@
 [Unit]
-Description=OpenBSC BSC
+Description=OpenBSC BSC (legacy, with SCCPLite)
 Wants=osmo-bsc-mgcp.service

 [Service]

--
To view, visit https://gerrit.osmocom.org/10833
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88ba349e547c8f85e12e1ad80a2724086c489c02
Gerrit-Change-Number: 10833
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in openbsc[master]: systemd: describe osmo-bsc-sccplite service as legacy

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10833 )

Change subject: systemd: describe osmo-bsc-sccplite service as legacy
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10833
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ba349e547c8f85e12e1ad80a2724086c489c02
Gerrit-Change-Number: 10833
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 16:41:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-nat service from git repo

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10838 )

Change subject: openbsc: Install osmo-bsc-nat service from git repo
..

openbsc: Install osmo-bsc-nat service from git repo

Change-Id: Id9d1a2ea74e41baf3ab292e446a0402cd0cf55e5
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index 66782fb..f76afb7 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -20,7 +20,7 @@
install -d ${D}${sysconfdir}/osmocom
install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
${D}${sysconfdir}/osmocom/osmo-nitb.cfg
install -m 0660 
${S}/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
-   install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/
+   install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg

# Install sysv-init files
install -d ${D}${sysconfdir}/init.d
@@ -32,6 +32,7 @@
install -d ${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/contrib/systemd/osmo-bsc-nat.service 
${D}${systemd_system_unitdir}/

install -d ${D}/var/lib/osmocom

@@ -65,6 +66,7 @@

 CONFFILES_osmo-bsc-nat = "${sysconfdir}/osmocom/osmo-bsc_nat.cfg"
 FILES_osmo-bsc-nat = " \
-   ${bindir}/osmo-bsc_nat \
-   ${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
-   "
+   ${bindir}/osmo-bsc_nat \
+   ${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
+   ${systemd_system_unitdir}/osmo-bsc-nat.service \
+   "

--
To view, visit https://gerrit.osmocom.org/10838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9d1a2ea74e41baf3ab292e446a0402cd0cf55e5
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10836 )

Change subject: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp
..

osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp

Since osmo-mgw.git 31b4729f2731c747b8b33c4646dd5ade2ace29bc those have
been removed entirely from the repo and are only available trhough
openbsc.git.

Change-Id: If07c4af918304db7611f21cd203e4e4670616cf1
---
M recipes-osmocom/osmo-mgw/osmo-mgw.inc
1 file changed, 3 insertions(+), 23 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc 
b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
index b083a9c..19e17ab 100644
--- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc
+++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
@@ -3,35 +3,22 @@
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"

-DEPENDS = "libosmocore libosmo-netif bcg729 libgsm"
+DEPENDS = "libosmocore libosmo-netif"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-EXTRA_OECONF += "--enable-mgcp-transcoding --with-g729"
-
 do_install_append() {
install -d ${D}${systemd_system_unitdir}/
install -d ${D}${sysconfdir}/osmocom/

-   install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-mgcp.service 
${D}${systemd_system_unitdir}/
-
install -m 0644 ${S}/doc/examples/osmo-mgw/osmo-mgw.cfg 
${D}${sysconfdir}/osmocom/osmo-mgw.cfg
install -m 0644 ${S}/contrib/systemd/osmo-mgw.service 
${D}${systemd_system_unitdir}/
 }

-PACKAGES =+ " libosmo-legacy-mgcp libosmo-legacy-mgcp-dev libosmo-mgcp 
libosmo-mgcp-dev libosmo-mgcp-client libosmo-mgcp-client-dev osmo-bsc-mgcp"
+PACKAGES =+ "libosmo-mgcp libosmo-mgcp-dev libosmo-mgcp-client 
libosmo-mgcp-client-dev"
 SYSTEMD_SERVICE_osmo-mgw = "osmo-mgw.service"
-SYSTEMD_SERVICE_osmo-bsc-mgcp = "osmo-bsc-mgcp.service"
-
-FILES_libosmo-legacy-mgcp = "${libdir}/libosmo-legacy-mgcp${SOLIBS}"
-FILES_libosmo-legacy-mgcp-dev = " \
-   ${includedir}/osmocom/legacy_mgcp \
-   ${libdir}/pkgconfig/libosmo-legacy-mgcp.pc \
-   ${libdir}/libosmo-legacy-mgcp${SOLIBSDEV} \
-   "

 FILES_libosmo-mgcp = "${libdir}/libosmo-mgcp${SOLIBS}"
 FILES_libosmo-mgcp-dev = " \
@@ -47,11 +34,4 @@
${libdir}/libosmo-mgcp-client${SOLIBSDEV} \
"

-FILES_osmo-bsc-mgcp = " \
-   ${bindir}/osmo-bsc_mgcp \
-   ${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg \
-   ${systemd_unitdir}/system/osmo-bsc-mgcp.service \
-   "
-CONFFILES_osmo-bsc-mgcp = "${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg"
-
 CONFFILES_osmo-mgw = "${sysconfdir}/osmocom/osmo-mgw.cfg"

--
To view, visit https://gerrit.osmocom.org/10836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: If07c4af918304db7611f21cd203e4e4670616cf1
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10842 )

Change subject: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils
..

osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils

Change-Id: If19a2aac9cf414f9c590eb9670192abf6134c6ff
---
M recipes-osmocom/osmo-hlr/osmo-hlr.inc
1 file changed, 15 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc 
b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
index 7e75d13..8f078ed 100644
--- a/recipes-osmocom/osmo-hlr/osmo-hlr.inc
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
@@ -5,7 +5,7 @@

 DEPENDS = "libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

@@ -23,6 +23,20 @@
install -m 0644 ${WORKDIR}/hlr.db 
${D}${localstatedir}/lib/osmocom/hlr.db
 }

+PACKAGES =+ "libosmo-gsup-client libosmo-gsup-client-dev osmo-hlr-utils"
+
+FILES_libosmo-gsup-client = "${libdir}/libosmo-gsup-client${SOLIBS}"
+FILES_libosmo-gsup-client-dev = " \
+   ${includedir}/osmocom/gsupclient \
+   ${libdir}/pkgconfig/libosmo-gsup-client.pc \
+   ${libdir}/libosmo-gsup-client${SOLIBSDEV} \
+   "
+
+FILES_osmo-hlr-utils = " \
+   ${bindir}/osmo-hlr-db-tool \
+   ${bindir}/osmo-euse-demo \
+   "
+
 SYSTEMD_SERVICE_${PN} = "${PN}.service"
 CONFFILES_osmo-hlr = "\
${sysconfdir}/osmocom/osmo-hlr.cfg \

--
To view, visit https://gerrit.osmocom.org/10842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: If19a2aac9cf414f9c590eb9670192abf6134c6ff
Gerrit-Change-Number: 10842
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..

osmo-msc: Depend on osmo-hlr

Since a while ago, osmo-msc depends on libosmo-gsup-client which is
provided by osmo-hlr.

Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
---
M recipes-osmocom/osmo-msc/osmo-msc.inc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc 
b/recipes-osmocom/osmo-msc/osmo-msc.inc
index 06f5b10..e5364cd 100644
--- a/recipes-osmocom/osmo-msc/osmo-msc.inc
+++ b/recipes-osmocom/osmo-msc/osmo-msc.inc
@@ -3,9 +3,9 @@
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"

-DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw"
+DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw 
osmo-hlr"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Use systemd.bbclass correctly

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10839 )

Change subject: openbsc: Use systemd.bbclass correctly
..

openbsc: Use systemd.bbclass correctly

* Describe packages containing systemd services in SYSTEMD_PACKAGES.
* Enable services by default, since now osmo-bsc-sccplite doesn't collide
with osmo-bsc.git's osmo-bsc.
* Add SYSTEMD_SERVICE_* to specify service file for each package.

Change-Id: I922291bc8a1a8d52f41b3f4d5d80b80305b181cd
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index f76afb7..ca9a6c6 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -39,13 +39,11 @@
 }

 PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
-
+SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
 INITSCRIPT_PACKAGES = "osmo-bsc-sccplite osmo-nitb"

-# Do not start any of the services by default
-SYSTEMD_AUTO_ENABLE = "disable"
-
 CONFFILES_osmo-bsc-sccplite = "${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg"
+SYSTEMD_SERVICE_osmo-bsc-sccplite = "osmo-bsc-sccplite.service"
 INITSCRIPT_NAME_osmo-bsc-sccplite = "osmo-bsc-sccplite"
 INITSCRIPT_PARAMS_osmo-bsc-sccplite = "defaults 30 30"
 FILES_osmo-bsc-sccplite = " ${bindir}/osmo-bsc-sccplite \
@@ -55,16 +53,18 @@
"

 CONFFILES_osmo-nitb = "${sysconfdir}/osmocom/osmo-nitb.cfg"
+SYSTEMD_SERVICE_osmo-nitb = "osmo-nitb.service"
 INITSCRIPT_NAME_osmo-nitb = "osmo-nitb"
 INITSCRIPT_PARAMS_osmo-nitb = "defaults 30 30"
 FILES_osmo-nitb = " ${bindir}/osmo-nitb \
/var/lib/osmocom \
${sysconfdir}/init.d/osmo-nitb \
${sysconfdir}/osmocom/osmo-nitb.cfg \
-   ${systemd_unitdir}/system/osmo-nitb.service \
+   ${systemd_system_unitdir}/osmo-nitb.service \
"

 CONFFILES_osmo-bsc-nat = "${sysconfdir}/osmocom/osmo-bsc_nat.cfg"
+SYSTEMD_SERVICE_osmo-bsc-nat = "osmo-bsc-nat.service"
 FILES_osmo-bsc-nat = " \
${bindir}/osmo-bsc_nat \
${sysconfdir}/osmocom/osmo-bsc_nat.cfg \

--
To view, visit https://gerrit.osmocom.org/10839
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I922291bc8a1a8d52f41b3f4d5d80b80305b181cd
Gerrit-Change-Number: 10839
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Package osmo-bsc-mgcp

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10840 )

Change subject: openbsc: Package osmo-bsc-mgcp
..

openbsc: Package osmo-bsc-mgcp

Change-Id: I622e2752c878753d1b4b4ccc943fa430b055ffee
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 13 insertions(+), 3 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index ca9a6c6..ec130db 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -10,7 +10,7 @@
   file://osmo-bsc-sccplite.init \
   "

-INC_PR = "r2.${META_TELEPHONY_OSMO_INC}"
+INC_PR = "r3.${META_TELEPHONY_OSMO_INC}"

 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

@@ -21,6 +21,7 @@
install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
${D}${sysconfdir}/osmocom/osmo-nitb.cfg
install -m 0660 
${S}/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg
+   install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg

# Install sysv-init files
install -d ${D}${sysconfdir}/init.d
@@ -33,13 +34,14 @@
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-bsc-nat.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/contrib/systemd/osmo-bsc-mgcp.service 
${D}${systemd_system_unitdir}/

install -d ${D}/var/lib/osmocom

 }

-PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
-SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
+PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
+SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
 INITSCRIPT_PACKAGES = "osmo-bsc-sccplite osmo-nitb"

 CONFFILES_osmo-bsc-sccplite = "${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg"
@@ -70,3 +72,11 @@
${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
${systemd_system_unitdir}/osmo-bsc-nat.service \
"
+
+CONFFILES_osmo-bsc-mgcp = "${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg"
+SYSTEMD_SERVICE_osmo-bsc-mgcp = "osmo-bsc-mgcp.service"
+FILES_osmo-bsc-mgcp = " \
+   ${bindir}/osmo-bsc_mgcp \
+   ${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg \
+   ${systemd_system_unitdir}/osmo-bsc-mgcp.service \
+   "

--
To view, visit https://gerrit.osmocom.org/10840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I622e2752c878753d1b4b4ccc943fa430b055ffee
Gerrit-Change-Number: 10840
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-sccplite.service from git repo

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10837 )

Change subject: openbsc: Install osmo-bsc-sccplite.service from git repo
..

openbsc: Install osmo-bsc-sccplite.service from git repo

Change-Id: I4d308a62fefd6f3b8d944eb6a84427437c2844bb
---
M recipes-osmocom/openbsc/openbsc.inc
D recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service
2 files changed, 2 insertions(+), 15 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index 9f23d52..66782fb 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -8,10 +8,9 @@

 SRC_URI = "file://osmo-nitb.init \
   file://osmo-bsc-sccplite.init \
-  file://osmo-bsc-sccplite.service \
   "

-INC_PR = "r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR = "r2.${META_TELEPHONY_OSMO_INC}"
 
 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

@@ -32,7 +31,7 @@
# Install systemd files and enable on sysinit
install -d ${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${WORKDIR}/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/

install -d ${D}/var/lib/osmocom

diff --git a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service 
b/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service
deleted file mode 100644
index 3edd35c..000
--- a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service
+++ /dev/null
@@ -1,12 +0,0 @@
-[Unit]
-Description=OpenBSC BSC (legacy, with SCCPLite)
-Wants=osmo-bsc-mgcp.service
-
-[Service]
-Type=simple
-Restart=always
-ExecStart=/usr/bin/osmo-bsc-sccplite -c /etc/osmocom/osmo-bsc-sccplite.cfg -s
-RestartSec=2
-
-[Install]
-WantedBy=multi-user.target

--
To view, visit https://gerrit.osmocom.org/10837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d308a62fefd6f3b8d944eb6a84427437c2844bb
Gerrit-Change-Number: 10837
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:32:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1:

> actually, I think you should first split the libosmo-gsup-client
 > sub-package and then depend on that?

No, afaik you DEPEND on recipes, not on packages. You RDEPEND on packages, but 
that's done automatically by OE in most cases (through linker analysis).


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:24:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: add vty config for GSMTAP-SAPI host (-i)

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10808 )

Change subject: add vty config for GSMTAP-SAPI host (-i)
..


Patch Set 1:

> we often use 'remote-ip', but this one here is not limited to an
 > IP, but could also be a hostname ... 'gsmtap-remote-host' then?

while we use "char *" to store the stringified IP address in many places, we 
still don't do DNS lookups, as those would happen synchronously and block.  So 
actually I'm happy with remote-ip and restricting the string to A.B.C.D style 
syntax.

If there is code that triggers a blcoking DNS, then please flag that as 
separate bug!


--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:18:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: ho fsm: handle RR HO Failure for inter-BSC outgoing

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10834 )

Change subject: ho fsm: handle RR HO Failure for inter-BSC outgoing
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10834
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82
Gerrit-Change-Number: 10834
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:16:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: lchan_fsm: allow late RTP release events without erroring

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10835 )

Change subject: lchan_fsm: allow late RTP release events without erroring
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10835
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia463f97402b957bd13a95d18d291d1c1f006f089
Gerrit-Change-Number: 10835
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:16:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10842 )

Change subject: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: If19a2aac9cf414f9c590eb9670192abf6134c6ff
Gerrit-Change-Number: 10842
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:15:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: -Code-Review

actually, I think you should first split the libosmo-gsup-client sub-package 
and then depend on that?


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:15:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Use systemd.bbclass correctly

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10839 )

Change subject: openbsc: Use systemd.bbclass correctly
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10839
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I922291bc8a1a8d52f41b3f4d5d80b80305b181cd
Gerrit-Change-Number: 10839
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:14:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:14:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-nat service from git repo

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10838 )

Change subject: openbsc: Install osmo-bsc-nat service from git repo
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d1a2ea74e41baf3ab292e446a0402cd0cf55e5
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:14:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Package osmo-bsc-mgcp

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10840 )

Change subject: openbsc: Package osmo-bsc-mgcp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I622e2752c878753d1b4b4ccc943fa430b055ffee
Gerrit-Change-Number: 10840
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:14:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10836 )

Change subject: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: If07c4af918304db7611f21cd203e4e4670616cf1
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:14:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-sccplite.service from git repo

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10837 )

Change subject: openbsc: Install osmo-bsc-sccplite.service from git repo
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d308a62fefd6f3b8d944eb6a84427437c2844bb
Gerrit-Change-Number: 10837
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:13:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #239

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in meta-telephony[laforge/nightly]: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10842 )

Change subject: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: If19a2aac9cf414f9c590eb9670192abf6134c6ff
Gerrit-Change-Number: 10842
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:45:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Package osmo-bsc-mgcp

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10840 )

Change subject: openbsc: Package osmo-bsc-mgcp
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I622e2752c878753d1b4b4ccc943fa430b055ffee
Gerrit-Change-Number: 10840
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Use systemd.bbclass correctly

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10839 )

Change subject: openbsc: Use systemd.bbclass correctly
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10839
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I922291bc8a1a8d52f41b3f4d5d80b80305b181cd
Gerrit-Change-Number: 10839
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10836 )

Change subject: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: If07c4af918304db7611f21cd203e4e4670616cf1
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-nat service from git repo

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10838 )

Change subject: openbsc: Install osmo-bsc-nat service from git repo
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d1a2ea74e41baf3ab292e446a0402cd0cf55e5
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-sccplite.service from git repo

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10837 )

Change subject: openbsc: Install osmo-bsc-sccplite.service from git repo
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d308a62fefd6f3b8d944eb6a84427437c2844bb
Gerrit-Change-Number: 10837
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: inter-BSC HO outgoing: fix L3 forwarding

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10809 )

Change subject: inter-BSC HO outgoing: fix L3 forwarding
..


Patch Set 2: Code-Review+2

done, now submitting myself: triviality


--
To view, visit https://gerrit.osmocom.org/10809
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
Gerrit-Change-Number: 10809
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: openbsc: Drop binaries provided by other recipes

[Pau Espin Pedrol]

Pau Espin Pedrol has abandoned this change. ( https://gerrit.osmocom.org/10451 )

Change subject: openbsc: Drop binaries provided by other recipes
..


Abandoned

Abandoned in favour of https://gerrit.osmocom.org/#/c/meta-telephony/+/10836/
--
To view, visit https://gerrit.osmocom.org/10451
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: abandon
Gerrit-Change-Id: If9d8976451dd642ab516fba91bd283417e57bbb5
Gerrit-Change-Number: 10451
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 

Change in osmo-bsc[master]: inter-BSC HO outgoing: fix L3 forwarding

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10809 )

Change subject: inter-BSC HO outgoing: fix L3 forwarding
..

inter-BSC HO outgoing: fix L3 forwarding

Set msgb->l3h when composing the L3 message. Before this, the unset l3h
resulted in erratic size in the RSL L3 Info IE. This likely fixes inter-BSC
Handover on the outgoing side, to properly forward the RR Handover Command.

Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 0dd27fd..589d673 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -683,14 +683,13 @@
 int rsl_forward_layer3_info(struct gsm_lchan *lchan, const uint8_t *l3_info, 
uint8_t l3_info_len)
 {
struct msgb *msg;
-   uint8_t *dst;

if (!l3_info || !l3_info_len)
return -EINVAL;

msg = rsl_msgb_alloc();
-   dst = msgb_put(msg, l3_info_len);
-   memcpy(dst, l3_info, l3_info_len);
+   msg->l3h = msgb_put(msg, l3_info_len);
+   memcpy(msg->l3h, l3_info, l3_info_len);

msg->lchan = lchan;
return rsl_data_request(msg, 0);

-- 
To view, visit https://gerrit.osmocom.org/10809
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
Gerrit-Change-Number: 10809
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in meta-telephony[laforge/nightly]: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10842


Change subject: osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils
..

osmo-hlr: Split libosmo-gsup-client and osmo-hlr-utils

Change-Id: If19a2aac9cf414f9c590eb9670192abf6134c6ff
---
M recipes-osmocom/osmo-hlr/osmo-hlr.inc
1 file changed, 15 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/42/10842/1

diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc 
b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
index 7e75d13..8f078ed 100644
--- a/recipes-osmocom/osmo-hlr/osmo-hlr.inc
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
@@ -5,7 +5,7 @@

 DEPENDS = "libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

@@ -23,6 +23,20 @@
install -m 0644 ${WORKDIR}/hlr.db 
${D}${localstatedir}/lib/osmocom/hlr.db
 }

+PACKAGES =+ "libosmo-gsup-client libosmo-gsup-client-dev osmo-hlr-utils"
+
+FILES_libosmo-gsup-client = "${libdir}/libosmo-gsup-client${SOLIBS}"
+FILES_libosmo-gsup-client-dev = " \
+   ${includedir}/osmocom/gsupclient \
+   ${libdir}/pkgconfig/libosmo-gsup-client.pc \
+   ${libdir}/libosmo-gsup-client${SOLIBSDEV} \
+   "
+
+FILES_osmo-hlr-utils = " \
+   ${bindir}/osmo-hlr-db-tool \
+   ${bindir}/osmo-euse-demo \
+   "
+
 SYSTEMD_SERVICE_${PN} = "${PN}.service"
 CONFFILES_osmo-hlr = "\
${sysconfdir}/osmocom/osmo-hlr.cfg \

--
To view, visit https://gerrit.osmocom.org/10842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: If19a2aac9cf414f9c590eb9670192abf6134c6ff
Gerrit-Change-Number: 10842
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10841


Change subject: osmo-msc: Depend on osmo-hlr
..

osmo-msc: Depend on osmo-hlr

Since a while ago, osmo-msc depends on libosmo-gsup-client which is
provided by osmo-hlr.

Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
---
M recipes-osmocom/osmo-msc/osmo-msc.inc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/41/10841/1

diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc 
b/recipes-osmocom/osmo-msc/osmo-msc.inc
index 06f5b10..e5364cd 100644
--- a/recipes-osmocom/osmo-msc/osmo-msc.inc
+++ b/recipes-osmocom/osmo-msc/osmo-msc.inc
@@ -3,9 +3,9 @@
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"

-DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw"
+DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw 
osmo-hlr"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Package osmo-bsc-mgcp

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10840


Change subject: openbsc: Package osmo-bsc-mgcp
..

openbsc: Package osmo-bsc-mgcp

Change-Id: I622e2752c878753d1b4b4ccc943fa430b055ffee
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 13 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/40/10840/1

diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index ca9a6c6..ec130db 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -10,7 +10,7 @@
   file://osmo-bsc-sccplite.init \
   "

-INC_PR = "r2.${META_TELEPHONY_OSMO_INC}"
+INC_PR = "r3.${META_TELEPHONY_OSMO_INC}"

 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

@@ -21,6 +21,7 @@
install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
${D}${sysconfdir}/osmocom/osmo-nitb.cfg
install -m 0660 
${S}/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg
+   install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg

# Install sysv-init files
install -d ${D}${sysconfdir}/init.d
@@ -33,13 +34,14 @@
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-bsc-nat.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/contrib/systemd/osmo-bsc-mgcp.service 
${D}${systemd_system_unitdir}/

install -d ${D}/var/lib/osmocom

 }

-PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
-SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
+PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
+SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
 INITSCRIPT_PACKAGES = "osmo-bsc-sccplite osmo-nitb"

 CONFFILES_osmo-bsc-sccplite = "${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg"
@@ -70,3 +72,11 @@
${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
${systemd_system_unitdir}/osmo-bsc-nat.service \
"
+
+CONFFILES_osmo-bsc-mgcp = "${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg"
+SYSTEMD_SERVICE_osmo-bsc-mgcp = "osmo-bsc-mgcp.service"
+FILES_osmo-bsc-mgcp = " \
+   ${bindir}/osmo-bsc_mgcp \
+   ${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg \
+   ${systemd_system_unitdir}/osmo-bsc-mgcp.service \
+   "

--
To view, visit https://gerrit.osmocom.org/10840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I622e2752c878753d1b4b4ccc943fa430b055ffee
Gerrit-Change-Number: 10840
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Use systemd.bbclass correctly

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10839


Change subject: openbsc: Use systemd.bbclass correctly
..

openbsc: Use systemd.bbclass correctly

* Describe packages containing systemd services in SYSTEMD_PACKAGES.
* Enable services by default, since now osmo-bsc-sccplite doesn't collide
with osmo-bsc.git's osmo-bsc.
* Add SYSTEMD_SERVICE_* to specify service file for each package.

Change-Id: I922291bc8a1a8d52f41b3f4d5d80b80305b181cd
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/39/10839/1

diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index f76afb7..ca9a6c6 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -39,13 +39,11 @@
 }

 PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
-
+SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb"
 INITSCRIPT_PACKAGES = "osmo-bsc-sccplite osmo-nitb"

-# Do not start any of the services by default
-SYSTEMD_AUTO_ENABLE = "disable"
-
 CONFFILES_osmo-bsc-sccplite = "${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg"
+SYSTEMD_SERVICE_osmo-bsc-sccplite = "osmo-bsc-sccplite.service"
 INITSCRIPT_NAME_osmo-bsc-sccplite = "osmo-bsc-sccplite"
 INITSCRIPT_PARAMS_osmo-bsc-sccplite = "defaults 30 30"
 FILES_osmo-bsc-sccplite = " ${bindir}/osmo-bsc-sccplite \
@@ -55,16 +53,18 @@
"

 CONFFILES_osmo-nitb = "${sysconfdir}/osmocom/osmo-nitb.cfg"
+SYSTEMD_SERVICE_osmo-nitb = "osmo-nitb.service"
 INITSCRIPT_NAME_osmo-nitb = "osmo-nitb"
 INITSCRIPT_PARAMS_osmo-nitb = "defaults 30 30"
 FILES_osmo-nitb = " ${bindir}/osmo-nitb \
/var/lib/osmocom \
${sysconfdir}/init.d/osmo-nitb \
${sysconfdir}/osmocom/osmo-nitb.cfg \
-   ${systemd_unitdir}/system/osmo-nitb.service \
+   ${systemd_system_unitdir}/osmo-nitb.service \
"

 CONFFILES_osmo-bsc-nat = "${sysconfdir}/osmocom/osmo-bsc_nat.cfg"
+SYSTEMD_SERVICE_osmo-bsc-nat = "osmo-bsc-nat.service"
 FILES_osmo-bsc-nat = " \
${bindir}/osmo-bsc_nat \
${sysconfdir}/osmocom/osmo-bsc_nat.cfg \

--
To view, visit https://gerrit.osmocom.org/10839
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I922291bc8a1a8d52f41b3f4d5d80b80305b181cd
Gerrit-Change-Number: 10839
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10836


Change subject: osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp
..

osmo-mgw: Remove osmo-bsc_mgcp and libosmo-legacy-mgcp

Since osmo-mgw.git 31b4729f2731c747b8b33c4646dd5ade2ace29bc those have
been removed entirely from the repo and are only available trhough
openbsc.git.

Change-Id: If07c4af918304db7611f21cd203e4e4670616cf1
---
M recipes-osmocom/osmo-mgw/osmo-mgw.inc
1 file changed, 3 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/36/10836/1

diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc 
b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
index b083a9c..19e17ab 100644
--- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc
+++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
@@ -3,35 +3,22 @@
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"

-DEPENDS = "libosmocore libosmo-netif bcg729 libgsm"
+DEPENDS = "libosmocore libosmo-netif"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-EXTRA_OECONF += "--enable-mgcp-transcoding --with-g729"
-
 do_install_append() {
install -d ${D}${systemd_system_unitdir}/
install -d ${D}${sysconfdir}/osmocom/

-   install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-mgcp.service 
${D}${systemd_system_unitdir}/
-
install -m 0644 ${S}/doc/examples/osmo-mgw/osmo-mgw.cfg 
${D}${sysconfdir}/osmocom/osmo-mgw.cfg
install -m 0644 ${S}/contrib/systemd/osmo-mgw.service 
${D}${systemd_system_unitdir}/
 }

-PACKAGES =+ " libosmo-legacy-mgcp libosmo-legacy-mgcp-dev libosmo-mgcp 
libosmo-mgcp-dev libosmo-mgcp-client libosmo-mgcp-client-dev osmo-bsc-mgcp"
+PACKAGES =+ "libosmo-mgcp libosmo-mgcp-dev libosmo-mgcp-client 
libosmo-mgcp-client-dev"
 SYSTEMD_SERVICE_osmo-mgw = "osmo-mgw.service"
-SYSTEMD_SERVICE_osmo-bsc-mgcp = "osmo-bsc-mgcp.service"
-
-FILES_libosmo-legacy-mgcp = "${libdir}/libosmo-legacy-mgcp${SOLIBS}"
-FILES_libosmo-legacy-mgcp-dev = " \
-   ${includedir}/osmocom/legacy_mgcp \
-   ${libdir}/pkgconfig/libosmo-legacy-mgcp.pc \
-   ${libdir}/libosmo-legacy-mgcp${SOLIBSDEV} \
-   "

 FILES_libosmo-mgcp = "${libdir}/libosmo-mgcp${SOLIBS}"
 FILES_libosmo-mgcp-dev = " \
@@ -47,11 +34,4 @@
${libdir}/libosmo-mgcp-client${SOLIBSDEV} \
"

-FILES_osmo-bsc-mgcp = " \
-   ${bindir}/osmo-bsc_mgcp \
-   ${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg \
-   ${systemd_unitdir}/system/osmo-bsc-mgcp.service \
-   "
-CONFFILES_osmo-bsc-mgcp = "${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg"
-
 CONFFILES_osmo-mgw = "${sysconfdir}/osmocom/osmo-mgw.cfg"

--
To view, visit https://gerrit.osmocom.org/10836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: If07c4af918304db7611f21cd203e4e4670616cf1
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-sccplite.service from git repo

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10837


Change subject: openbsc: Install osmo-bsc-sccplite.service from git repo
..

openbsc: Install osmo-bsc-sccplite.service from git repo

Change-Id: I4d308a62fefd6f3b8d944eb6a84427437c2844bb
---
M recipes-osmocom/openbsc/openbsc.inc
D recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service
2 files changed, 2 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/37/10837/1

diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index 9f23d52..66782fb 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -8,10 +8,9 @@
 
 SRC_URI = "file://osmo-nitb.init \
   file://osmo-bsc-sccplite.init \
-  file://osmo-bsc-sccplite.service \
   "

-INC_PR = "r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR = "r2.${META_TELEPHONY_OSMO_INC}"

 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

@@ -32,7 +31,7 @@
# Install systemd files and enable on sysinit
install -d ${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${WORKDIR}/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/

install -d ${D}/var/lib/osmocom

diff --git a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service 
b/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service
deleted file mode 100644
index 3edd35c..000
--- a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.service
+++ /dev/null
@@ -1,12 +0,0 @@
-[Unit]
-Description=OpenBSC BSC (legacy, with SCCPLite)
-Wants=osmo-bsc-mgcp.service
-
-[Service]
-Type=simple
-Restart=always
-ExecStart=/usr/bin/osmo-bsc-sccplite -c /etc/osmocom/osmo-bsc-sccplite.cfg -s
-RestartSec=2
-
-[Install]
-WantedBy=multi-user.target

--
To view, visit https://gerrit.osmocom.org/10837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d308a62fefd6f3b8d944eb6a84427437c2844bb
Gerrit-Change-Number: 10837
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Install osmo-bsc-nat service from git repo

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10838


Change subject: openbsc: Install osmo-bsc-nat service from git repo
..

openbsc: Install osmo-bsc-nat service from git repo

Change-Id: Id9d1a2ea74e41baf3ab292e446a0402cd0cf55e5
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/38/10838/1

diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index 66782fb..f76afb7 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -20,7 +20,7 @@
install -d ${D}${sysconfdir}/osmocom
install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
${D}${sysconfdir}/osmocom/osmo-nitb.cfg
install -m 0660 
${S}/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
-   install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/
+   install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg

# Install sysv-init files
install -d ${D}${sysconfdir}/init.d
@@ -32,6 +32,7 @@
install -d ${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/contrib/systemd/osmo-bsc-nat.service 
${D}${systemd_system_unitdir}/

install -d ${D}/var/lib/osmocom

@@ -65,6 +66,7 @@

 CONFFILES_osmo-bsc-nat = "${sysconfdir}/osmocom/osmo-bsc_nat.cfg"
 FILES_osmo-bsc-nat = " \
-   ${bindir}/osmo-bsc_nat \
-   ${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
-   "
+   ${bindir}/osmo-bsc_nat \
+   ${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
+   ${systemd_system_unitdir}/osmo-bsc-nat.service \
+   "

--
To view, visit https://gerrit.osmocom.org/10838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9d1a2ea74e41baf3ab292e446a0402cd0cf55e5
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-bsc[master]: inter-BSC HO incoming: send BSSMAP HO Complete directly

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10811 )

Change subject: inter-BSC HO incoming: send BSSMAP HO Complete directly
..

inter-BSC HO incoming: send BSSMAP HO Complete directly

Before Handover is fully completed, the gscon remains in an INIT state. To send
back the BSSMAP Handover Complete message, use osmo_bsc_sigtran_send() directly
to not thwart the message due to the gscon state.

(The gscon state will change to ACTIVE right after that, once the handover FSM
is done.)

Change-Id: Ic48ae2bb23565015d5e2ccb56308fad09347b51a
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 03e073a..d6b0b6d 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -1100,7 +1100,7 @@
return HO_RESULT_ERROR;
}

-   rc = gscon_sigtran_send(conn, msg);
+   rc = osmo_bsc_sigtran_send(conn, msg);
if (rc) {
LOG_HO(conn, LOGL_ERROR, "Cannot send BSSMAP Handover Complete 
message\n");
return HO_RESULT_ERROR;

-- 
To view, visit https://gerrit.osmocom.org/10811
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic48ae2bb23565015d5e2ccb56308fad09347b51a
Gerrit-Change-Number: 10811
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-bsc[master]: SCCPlite Assignment Complete: include Speech Codec (Chosen)

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10810 )

Change subject: SCCPlite Assignment Complete: include Speech Codec (Chosen)
..

SCCPlite Assignment Complete: include Speech Codec (Chosen)

Compose the Speech Codec (Chosen) IE not only for AoIP, but also for SCCPlite:
place the code that assigns the codec to sc_ptr outside of the gscon_is_aoip()
if scope.

This way the MSC is told the chosen speech codec, which is mandatory for IP
based user plane, and was missing until now.

Related: OS#3528
Change-Id: Ibedade8d71a7994d25a63bc2faa2a24a10bfffa1
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index e1da45b..63776f0 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -163,12 +163,12 @@
return;
}
addr_local_p = _local;
-
-   /* Extrapolate speech codec from speech mode */
-   gsm0808_speech_codec_from_chan_type(, perm_spch);
-   sc_ptr = 
}
+
+   /* Extrapolate speech codec from speech mode */
/* FIXME: AMR codec configuration must be derived from lchan1! 
*/
+   gsm0808_speech_codec_from_chan_type(, perm_spch);
+   sc_ptr = 
}

resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,

--
To view, visit https://gerrit.osmocom.org/10810
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibedade8d71a7994d25a63bc2faa2a24a10bfffa1
Gerrit-Change-Number: 10810
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-bts[master]: add vty config for GSMTAP-SAPI host (-i)

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10808 )

Change subject: add vty config for GSMTAP-SAPI host (-i)
..


Patch Set 1:

> we often use 'remote-ip', but this one here is not limited to an
 > IP, but could also be a hostname ... 'gsmtap-remote-host' then?

gsmtap-dst-host ?


--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:38:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: ho fsm: handle RR HO Failure for inter-BSC outgoing

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/10834


Change subject: ho fsm: handle RR HO Failure for inter-BSC outgoing
..

ho fsm: handle RR HO Failure for inter-BSC outgoing

Before, this would ignore the failure and hit a timeout instead. Rather handle
the event directly.

Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/10834/1

diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index a42f10c..9d558bc 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -1025,6 +1025,18 @@
}
 }

+static void ho_out_fsm_wait_clear(struct osmo_fsm_inst *fi, uint32_t event, 
void *data)
+{
+   struct gsm_subscriber_connection *conn = ho_fi_conn(fi);
+   switch (event) {
+   case HO_EV_RR_HO_FAIL:
+   ho_fail(HO_RESULT_FAIL_RR_HO_FAIL, "Received RR Handover 
Failure message");
+   return;
+
+   default:
+   OSMO_ASSERT(false);
+   }
+}

 #define S(x)   (1 << (x))

@@ -1108,6 +1120,10 @@
},
[HO_OUT_ST_WAIT_CLEAR] = {
.name = "inter-BSC-OUT:WAIT_CLEAR",
+   .in_event_mask = 0
+   | S(HO_EV_RR_HO_FAIL)
+   ,
+   .action = ho_out_fsm_wait_clear,
},
 };


--
To view, visit https://gerrit.osmocom.org/10834
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82
Gerrit-Change-Number: 10834
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bsc[master]: inter-BSC HO outgoing: fix L3 forwarding

[Neels Hofmeyr]

Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10809

to look at the new patch set (#2).

Change subject: inter-BSC HO outgoing: fix L3 forwarding
..

inter-BSC HO outgoing: fix L3 forwarding

Set msgb->l3h when composing the L3 message. Before this, the unset l3h
resulted in erratic size in the RSL L3 Info IE. This likely fixes inter-BSC
Handover on the outgoing side, to properly forward the RR Handover Command.

Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/10809/2
--
To view, visit https://gerrit.osmocom.org/10809
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
Gerrit-Change-Number: 10809
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bsc[master]: lchan_fsm: allow late RTP release events without erroring

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/10835


Change subject: lchan_fsm: allow late RTP release events without erroring
..

lchan_fsm: allow late RTP release events without erroring

Change-Id: Ia463f97402b957bd13a95d18d291d1c1f006f089
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/35/10835/1

diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 7d47380..1ef7869 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -967,6 +967,10 @@
lchan_fsm_state_chg(LCHAN_ST_UNUSED);
break;
 
+   case LCHAN_EV_RTP_RELEASED:
+   /* ignore late lchan_rtp_fsm release events */
+   return;
+
default:
OSMO_ASSERT(false);
}
@@ -1119,6 +1123,7 @@
.name = "WAIT_BEFORE_RF_RELEASE",
.in_event_mask = 0
| S(LCHAN_EV_RLL_REL_IND) /* allow late REL_IND of 
SAPI[0] */
+   | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm 
release events */
,
.out_state_mask = 0
| S(LCHAN_ST_UNUSED)
@@ -1131,6 +1136,7 @@
.action = lchan_fsm_wait_rf_release_ack,
.in_event_mask = 0
| S(LCHAN_EV_RSL_RF_CHAN_REL_ACK)
+   | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm 
release events */
,
.out_state_mask = 0
| S(LCHAN_ST_UNUSED)
@@ -1140,6 +1146,9 @@
},
[LCHAN_ST_WAIT_AFTER_ERROR] = {
.name = "WAIT_AFTER_ERROR",
+   .in_event_mask = 0
+   | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm 
release events */
+   ,
.out_state_mask = 0
| S(LCHAN_ST_UNUSED)
,

--
To view, visit https://gerrit.osmocom.org/10835
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia463f97402b957bd13a95d18d291d1c1f006f089
Gerrit-Change-Number: 10835
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bts[master]: add vty config for GSMTAP-SAPI host (-i)

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10808 )

Change subject: add vty config for GSMTAP-SAPI host (-i)
..


Patch Set 1:

we often use 'remote-ip', but this one here is not limited to an IP, but could 
also be a hostname ... 'gsmtap-remote-host' then?


--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:15:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-mgw[master]: mgcp_conn_get(): match conn Id ('I:') despite leading zeros

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10678 )

Change subject: mgcp_conn_get(): match conn Id ('I:') despite leading zeros
..

mgcp_conn_get(): match conn Id ('I:') despite leading zeros

The Connection Identifier is defined as a hex string, so clients may send the
ID back with or without leading zeros. Ignore all leading zeros when comparing.

A specific SCCPlite MSC is observed to DLCX with Connection Identifier with
leading zeros removed, which would mismatch pefore this patch.

Extend test_conn_id_matching() in mgcp_test.c to include leading zero tests.

Now, mgcp_conn_get() would match a valid id with *any* amount of leading zeros,
even if that far surpasses the permitted conn id length. Valid lengths of
incoming conn ids should be and is checked elsewhere.

Related: OS#3509
Change-Id: If55a64a2da47b6eff035711c08e4114d70dbec91
---
M src/libosmo-mgcp/mgcp_conn.c
M tests/mgcp/mgcp_test.c
M tests/mgcp/mgcp_test.ok
3 files changed, 21 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c
index 0918b8b..820c63a 100644
--- a/src/libosmo-mgcp/mgcp_conn.c
+++ b/src/libosmo-mgcp/mgcp_conn.c
@@ -190,17 +190,25 @@
 {
struct mgcp_conn *conn;
const char *id_upper;
+   const char *conn_id;

if (!id || !*id)
return NULL;

+   /* Ignore leading zeros in needle */
+   while (*id == '0')
+   id++;
+
/* Use uppercase to compare identifiers, to avoid mismatches: RFC3435 
2.1.3.2 "Names of
 * Connections" defines the id as a hex string, so clients may return 
lower case hex even though
 * we sent upper case hex in the CRCX response. */
id_upper = osmo_str_toupper(id);

llist_for_each_entry(conn, >conns, entry) {
-   if (strcmp(conn->id, id_upper) == 0)
+   /* Ignore leading zeros in haystack */
+   for (conn_id=conn->id; *conn_id == '0'; conn_id++);
+
+   if (strcmp(conn_id, id_upper) == 0)
return conn;
}

diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c
index 99ddd71..b9f7253 100644
--- a/tests/mgcp/mgcp_test.c
+++ b/tests/mgcp/mgcp_test.c
@@ -1759,8 +1759,14 @@
int i;
const char *conn_id_generated = "23AB";
const char *conn_id_request[] = {
+   "23AB",
+   "0023AB",
"23AB",
+   "0023AB",
+   "23ab",
+   "0023ab",
"23ab",
+   "0023ab",
};

printf("\nTesting %s\n", __func__);
diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok
index f50f487..28e9aad 100644
--- a/tests/mgcp/mgcp_test.ok
+++ b/tests/mgcp/mgcp_test.ok
@@ -1171,6 +1171,12 @@
 '10,a :PCMU' -> '(null)'

 Testing test_conn_id_matching
+needle='23AB' found '23AB'
+needle='0023AB' found '23AB'
 needle='23AB' found '23AB'
+needle='0023AB' found '23AB'
+needle='23ab' found '23AB'
+needle='0023ab' found '23AB'
 needle='23ab' found '23AB'
+needle='0023ab' found '23AB'
 Done

--
To view, visit https://gerrit.osmocom.org/10678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If55a64a2da47b6eff035711c08e4114d70dbec91
Gerrit-Change-Number: 10678
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-mgw[master]: cosmetic: mgcp_test: fix get_conn_id_from_response()

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10679 )

Change subject: cosmetic: mgcp_test: fix get_conn_id_from_response()
..

cosmetic: mgcp_test: fix get_conn_id_from_response()

This function is implemented in such a weird way that I couldn't stop myself
from rewriting it.

Change-Id: Ib9b13d7b0e64f8ae25a7b69cbb385e7fad33d02b
---
M tests/mgcp/mgcp_test.c
1 file changed, 30 insertions(+), 35 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c
index b9f7253..4cb16dd 100644
--- a/tests/mgcp/mgcp_test.c
+++ b/tests/mgcp/mgcp_test.c
@@ -607,47 +607,42 @@
MGCP_CONN_RECV_SEND);
 }
 
-/* Extract a connection ID from a response (CRCX) */
+/* Extract a connection ID from a response and return in conn_id;
+ * if there is none, return -EINVAL and leave conn_id unchanged. */
 static int get_conn_id_from_response(uint8_t *resp, char *conn_id,
-unsigned int conn_id_len)
+size_t conn_id_buflen)
 {
-   char *conn_id_ptr;
-   int i;
-   bool got_conn_id = false;
+   const char *conn_id_start;
+   const char *conn_id_end;
+   int conn_id_len;

-   /* First try to get the conn_id from the I: parameter */
-   conn_id_ptr = strstr((char *)resp, "I: ");
-   if (conn_id_ptr) {
-   memset(conn_id, 0, conn_id_len);
-   memcpy(conn_id, conn_id_ptr + 3, 32);
-   got_conn_id = true;
-   } else {
-   /* Alternatively try to extract the conn_id from the o=- SDP
-* parameter */
-   conn_id_ptr = strstr((char *)resp, "o=- ");
-   if(conn_id_ptr) {
-   memset(conn_id, 0, conn_id_len);
-   memcpy(conn_id, conn_id_ptr + 4, 32);
-   got_conn_id = true;
-   }
-   }
+   const char *header_I = "\r\nI: ";
+   const char *header_o = "\r\no=- ";

-   if (got_conn_id) {
-   for (i = 0; i < conn_id_len; i++) {
-   if (!isxdigit(conn_id[i])) {
-   conn_id[i] = '\0';
-   break;
-   }
-   }
+   /* Try to get the conn_id from the 'I:' or 'o=-' parameter */
+   if ((conn_id_start = strstr((char *)resp, header_I))) {
+   conn_id_start += strlen(header_I);
+   conn_id_end = strstr(conn_id_start, "\r\n");
+   } else if ((conn_id_start = strstr((char *)resp, header_o))) {
+   conn_id_start += strlen(header_o);
+   conn_id_end = strchr(conn_id_start, ' ');
+   } else
+   return -EINVAL;

-   /* A valid conn_id must at least contain one digit, and must
-* not exceed a length of 32 digits */
-   OSMO_ASSERT(strlen(conn_id) <= 32);
-   OSMO_ASSERT(strlen(conn_id) > 0);
+   if (conn_id_end)
+   conn_id_len = conn_id_end - conn_id_start;
+   else
+   conn_id_len = strlen(conn_id_start);
+   OSMO_ASSERT(conn_id_len <= conn_id_buflen - 1);

-   return 0;
-   }
-   return -EINVAL;
+   /* A valid conn_id must at least contain one digit, and must
+* not exceed a length of 32 digits */
+   OSMO_ASSERT(conn_id_len <= 32);
+   OSMO_ASSERT(conn_id_len > 0);
+
+   strncpy(conn_id, conn_id_start, conn_id_len);
+   conn_id[conn_id_len] = '\0';
+   return 0;
 }

 /* Check response, automatically patch connection ID if needed */

--
To view, visit https://gerrit.osmocom.org/10679
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9b13d7b0e64f8ae25a7b69cbb385e7fad33d02b
Gerrit-Change-Number: 10679
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-mgw[master]: comment: indicate struct type for mgcp_endpoint.conns

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10680 )

Change subject: comment: indicate struct type for mgcp_endpoint.conns
..

comment: indicate struct type for mgcp_endpoint.conns

Change-Id: Ia65359c22da3e7b28e3f23b36446ca434ca0be8c
---
M include/osmocom/mgcp/mgcp_endp.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/mgcp/mgcp_endp.h b/include/osmocom/mgcp/mgcp_endp.h
index d834c09..a23e192 100644
--- a/include/osmocom/mgcp/mgcp_endp.h
+++ b/include/osmocom/mgcp/mgcp_endp.h
@@ -69,7 +69,7 @@
/*! Local connection options (see mgcp_internal.h) */
struct mgcp_lco local_options;

-   /*! List with connections active on this endpoint */
+   /*! List of struct mgcp_conn, of the connections active on this 
endpoint */
struct llist_head conns;

/*! Backpointer to the MGW configuration */

--
To view, visit https://gerrit.osmocom.org/10680
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia65359c22da3e7b28e3f23b36446ca434ca0be8c
Gerrit-Change-Number: 10680
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-mgw[master]: mgcp_conn_get(): compare conn Id ('I:') case insensitively

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10677 )

Change subject: mgcp_conn_get(): compare conn Id ('I:') case insensitively
..

mgcp_conn_get(): compare conn Id ('I:') case insensitively

The Connection Identifier is defined as a hex string, so clients may send the
ID back in lower case. Convert to upper case before comparing.

A specific SCCPlite MSC is observed to DLCX with Connection Identifier in lower
case, which would mismatch pefore this patch.

Add test_conn_id_matching() in mgcp_test.c to verify case insensitivity.

Cosmetic: use strcmp(), not strncmp(). In the presence of a terminating nul as
we can assume here, this makes no functional difference, but it clarifies the
code.

Related: OS#3508
Depends: Ib0ee1206b9f31d7ba25c31f8008119ac55440797 (libosmocore)
Change-Id: I8e52278c3abe9e9c8c848c2b1538bce443f68a43
---
M src/libosmo-mgcp/mgcp_conn.c
M tests/mgcp/mgcp_test.c
M tests/mgcp/mgcp_test.ok
3 files changed, 49 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c
index 0126c7c..0918b8b 100644
--- a/src/libosmo-mgcp/mgcp_conn.c
+++ b/src/libosmo-mgcp/mgcp_conn.c
@@ -189,9 +189,18 @@
 struct mgcp_conn *mgcp_conn_get(struct mgcp_endpoint *endp, const char *id)
 {
struct mgcp_conn *conn;
+   const char *id_upper;
+
+   if (!id || !*id)
+   return NULL;
+
+   /* Use uppercase to compare identifiers, to avoid mismatches: RFC3435 
2.1.3.2 "Names of
+* Connections" defines the id as a hex string, so clients may return 
lower case hex even though
+* we sent upper case hex in the CRCX response. */
+   id_upper = osmo_str_toupper(id);

llist_for_each_entry(conn, >conns, entry) {
-   if (strncmp(conn->id, id, sizeof(conn->id)) == 0)
+   if (strcmp(conn->id, id_upper) == 0)
return conn;
}

diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c
index c40eabc..99ddd71 100644
--- a/tests/mgcp/mgcp_test.c
+++ b/tests/mgcp/mgcp_test.c
@@ -1751,6 +1751,40 @@
OSMO_ASSERT(pt_dst == -EINVAL);
 }

+void test_conn_id_matching()
+{
+   struct mgcp_endpoint endp = {};
+   struct mgcp_conn *conn;
+   struct mgcp_conn *conn_match;
+   int i;
+   const char *conn_id_generated = "23AB";
+   const char *conn_id_request[] = {
+   "23AB",
+   "23ab",
+   };
+
+   printf("\nTesting %s\n", __func__);
+
+   INIT_LLIST_HEAD();
+
+   conn = talloc_zero(NULL, struct mgcp_conn);
+   OSMO_ASSERT(conn);
+   osmo_strlcpy(conn->id, conn_id_generated, sizeof(conn->id));
+   llist_add(>entry, );
+
+   for (i = 0; i < ARRAY_SIZE(conn_id_request); i++) {
+   const char *needle = conn_id_request[i];
+   printf("needle='%s' ", needle);
+   conn_match = mgcp_conn_get(, needle);
+   OSMO_ASSERT(conn_match);
+   printf("found '%s'\n", conn_match->id);
+   OSMO_ASSERT(conn_match == conn);
+   }
+
+   llist_del(>entry);
+   talloc_free(conn);
+}
+
 int main(int argc, char **argv)
 {
void *ctx = talloc_named_const(NULL, 0, "mgcp_test");
@@ -1775,6 +1809,7 @@
test_get_lco_identifier();
test_check_local_cx_options(ctx);
test_mgcp_codec_pt_translate();
+   test_conn_id_matching();

OSMO_ASSERT(talloc_total_size(msgb_ctx) == 0);
OSMO_ASSERT(talloc_total_blocks(msgb_ctx) == 1);
diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok
index ddda751..f50f487 100644
--- a/tests/mgcp/mgcp_test.ok
+++ b/tests/mgcp/mgcp_test.ok
@@ -1169,4 +1169,8 @@
 '' -> '(null)'
 p10, aPCMU -> (null)
 '10,a :PCMU' -> '(null)'
+
+Testing test_conn_id_matching
+needle='23AB' found '23AB'
+needle='23ab' found '23AB'
 Done

--
To view, visit https://gerrit.osmocom.org/10677
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e52278c3abe9e9c8c848c2b1538bce443f68a43
Gerrit-Change-Number: 10677
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in openbsc[master]: systemd: describe osmo-bsc-sccplite service as legacy

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10833


Change subject: systemd: describe osmo-bsc-sccplite service as legacy
..

systemd: describe osmo-bsc-sccplite service as legacy

Change-Id: I88ba349e547c8f85e12e1ad80a2724086c489c02
---
M openbsc/contrib/systemd/osmo-bsc-sccplite.service
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/33/10833/1

diff --git a/openbsc/contrib/systemd/osmo-bsc-sccplite.service 
b/openbsc/contrib/systemd/osmo-bsc-sccplite.service
index 70cda5f..3edd35c 100644
--- a/openbsc/contrib/systemd/osmo-bsc-sccplite.service
+++ b/openbsc/contrib/systemd/osmo-bsc-sccplite.service
@@ -1,5 +1,5 @@
 [Unit]
-Description=OpenBSC BSC
+Description=OpenBSC BSC (legacy, with SCCPLite)
 Wants=osmo-bsc-mgcp.service

 [Service]

--
To view, visit https://gerrit.osmocom.org/10833
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88ba349e547c8f85e12e1ad80a2724086c489c02
Gerrit-Change-Number: 10833
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10717 )

Change subject: UHHDDevice: Replace deprecated header 
uhd/utils/thread_priority.hpp
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10717
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 12:28:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in gr-gsm[master]: apps/grgsm_trx: fix inaccurate sample rate calculation

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10831


Change subject: apps/grgsm_trx: fix inaccurate sample rate calculation
..

apps/grgsm_trx: fix inaccurate sample rate calculation

Change-Id: I0c309588fa0f7822abfb3919327639735db07679
---
M apps/grgsm_trx
M python/trx/radio_if.py
2 files changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/31/10831/1

diff --git a/apps/grgsm_trx b/apps/grgsm_trx
index 45312e6..6efed07 100755
--- a/apps/grgsm_trx
+++ b/apps/grgsm_trx
@@ -46,7 +46,7 @@
base_port = 6700

# PHY specific
-   phy_sample_rate = 4 * 1625000 / 6
+   phy_sample_rate = radio_if.SAMPLE_RATE
phy_freq_offset_hz = None
phy_tx_antenna = "TX/RX"
phy_rx_antenna = "RX2"
diff --git a/python/trx/radio_if.py b/python/trx/radio_if.py
index 407e724..2aeb49a 100644
--- a/python/trx/radio_if.py
+++ b/python/trx/radio_if.py
@@ -75,6 +75,9 @@
GSM_TS_PERIOD_uS = GSM_SYM_PERIOD_uS * 156.25
GSM_UL_DL_SHIFT_uS = -(GSM_TS_PERIOD_uS * 3)

+   # TODO: explain where do these values come from?
+   SAMPLE_RATE = 4.0 * 1625000.0 / 6.0
+
# FIXME: shall be measured (automatically?) for
# particular device and particular clock rate.
# The current value is measured for USRP B2X0 at 26e6.

--
To view, visit https://gerrit.osmocom.org/10831
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c309588fa0f7822abfb3919327639735db07679
Gerrit-Change-Number: 10831
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in gr-gsm[master]: apps/grgsm_trx: migrate from getopt to argparse

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10832


Change subject: apps/grgsm_trx: migrate from getopt to argparse
..

apps/grgsm_trx: migrate from getopt to argparse

Change-Id: I24a17b4cd44db0ce95a19d7470f4f09f3c85a26d
---
M apps/grgsm_trx
1 file changed, 69 insertions(+), 106 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/32/10832/1

diff --git a/apps/grgsm_trx b/apps/grgsm_trx
index 6efed07..d57c979 100755
--- a/apps/grgsm_trx
+++ b/apps/grgsm_trx
@@ -4,6 +4,7 @@
 # GR-GSM based transceiver
 #
 # (C) 2016-2018 by Vadim Yanitskiy 
+# (C) 2017-2018 by Piotr Krysik 
 #
 # All Rights Reserved
 #
@@ -22,9 +23,10 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

 import signal
-import getopt
 import sys

+from argparse import ArgumentParser
+from argparse import ArgumentTypeError
 from gnuradio import eng_notation

 from grgsm.trx import ctrl_if_bb
@@ -33,31 +35,25 @@

 COPYRIGHT = \
"Copyright (C) 2016-2018 by Vadim Yanitskiy \n" \
-   "Copyright (C) 2017 by Piotr Krysik \n" \
+   "Copyright (C) 2017-2018 by Piotr Krysik \n" \
"License GPLv2+: GNU GPL version 2 or later " \
"\n" \
"This is free software: you are free to change and redistribute it.\n" \
"There is NO WARRANTY, to the extent permitted by law.\n"

 class Application:
-   # Application variables
-   remote_addr = "127.0.0.1"
-   bind_addr = "0.0.0.0"
-   base_port = 6700
-
-   # PHY specific
-   phy_sample_rate = radio_if.SAMPLE_RATE
-   phy_freq_offset_hz = None
-   phy_tx_antenna = "TX/RX"
-   phy_rx_antenna = "RX2"
-   phy_rx_gain = 30
-   phy_tx_gain = 10
-   phy_args = ""
-   phy_ppm = 0
-
-   def __init__(self):
-   self.print_copyright()
-   self.parse_argv()
+   def __init__(self, argv):
+   self.remote_addr = argv.remote_addr
+   self.bind_addr = argv.bind_addr
+   self.base_port = argv.base_port
+   self.phy_args = argv.args
+   self.phy_sample_rate = argv.sample_rate
+   self.phy_rx_gain = argv.rx_gain
+   self.phy_tx_gain = argv.tx_gain
+   self.phy_rx_antenna = argv.rx_antenna
+   self.phy_tx_antenna = argv.tx_antenna
+   self.phy_freq_offset_hz = argv.freq_offset
+   self.phy_ppm = argv.ppm

# Set up signal handlers
signal.signal(signal.SIGINT, self.sig_handler)
@@ -95,97 +91,64 @@
print("[i] Shutting down...")
self.radio.shutdown()

-   def print_copyright(self):
-   print(COPYRIGHT)
-
-   def print_help(self):
-   s  = " Usage: " + sys.argv[0] + " [options]\n\n" \
-" Some help...\n" \
-"  -h --help this text\n\n"
-
-   # TRX specific
-   s += " TRX interface specific\n" \
-"  -i --remote-addr  Set remote address (default 
%s)\n" \
-"  -b --bind-addrSet bind address (default %s)\n" \
-"  -p --base-portSet base port number (default 
%d)\n\n"
-
-   # PHY specific
-   s += " Radio interface specific\n" \
-"  -a --device-args  Set device arguments\n" \
-"  -s --sample-rate  Set sample rate\n" \
-"  -g --rx-gain  Set RX gain (default %d)\n" \
-"  -G --tx-gain  Set TX gain (default %d)\n" \
-" --rx-antenna   Set RX antenna (default %s)\n" \
-" --tx-antenna   Set TX antenna (default %s)\n" \
-" --freq-offset  Shift baseband freq. (e.g. 
-500M)\n" \
-" --ppm  Set frequency correction (default 
%d)\n"
-
-   print(s % (
-   self.remote_addr,
-   self.bind_addr,
-   self.base_port,
-   self.phy_rx_gain,
-   self.phy_tx_gain,
-   self.phy_rx_antenna,
-   self.phy_tx_antenna,
-   self.phy_ppm))
-
-   def parse_argv(self):
-   try:
-   opts, args = getopt.getopt(sys.argv[1:],
-   "i:b:p:a:s:g:G:h",
-   ["help", "remote-addr=", "bind-addr=", 
"base-port=",
-   "device-args=", "sample-rate=", "rx-gain=", 
"tx-gain=",
-   "ppm=", "rx-antenna=", "tx-antenna=", 
"freq-offset="])
-   except getopt.GetoptError as err:
-   # Print(help and exit)
- 

Change in docker-playground[master]: gr-gsm-master/Dockerfile: fix full system upgrade

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10812 )

Change subject: gr-gsm-master/Dockerfile: fix full system upgrade
..

gr-gsm-master/Dockerfile: fix full system upgrade

Thanks to Piotr, it was discovered that the image building
process fails during full system upgrade:

  RUNpacman -Syu

with the following output:

  looking for conflicting packages...
  Packages (2) ca-certificates-mozilla-*  p11-kit-*

  ...

  :: Proceed with installation? [Y/n]
  The command '/bin/sh -c pacman -Syu' returned a non-zero code: 1

Looks like the '--noconfirm' flag was missing.

Change-Id: Icb3ccb9a9531686efcebb3e277421c4c05387b09
---
M gr-gsm-master/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Verified



diff --git a/gr-gsm-master/Dockerfile b/gr-gsm-master/Dockerfile
index e75d318..8be1a20 100644
--- a/gr-gsm-master/Dockerfile
+++ b/gr-gsm-master/Dockerfile
@@ -17,7 +17,7 @@
gcc

 # Sync pacman
-RUNpacman -Syu
+RUNpacman -Syyu --noconfirm

 # Install persistent packages
 RUNpacman -S --needed --noconfirm \

--
To view, visit https://gerrit.osmocom.org/10812
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb3ccb9a9531686efcebb3e277421c4c05387b09
Gerrit-Change-Number: 10812
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in docker-playground[master]: gr-gsm-master/Dockerfile: use 'master' branch for gr-gsm

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10813 )

Change subject: gr-gsm-master/Dockerfile: use 'master' branch for gr-gsm
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10813
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e228ca15577b8f2734a23ca57c436a3f7fb26fa
Gerrit-Change-Number: 10813
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:10:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: codec_pref.c: Add comment in expected switch case without break

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10775 )

Change subject: codec_pref.c: Add comment in expected switch case without break
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10775
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I568353f070f049003326306106dce89b35deb92f
Gerrit-Change-Number: 10775
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:10:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: gr-gsm-master/Dockerfile: use 'master' branch for gr-gsm

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10813 )

Change subject: gr-gsm-master/Dockerfile: use 'master' branch for gr-gsm
..

gr-gsm-master/Dockerfile: use 'master' branch for gr-gsm

All required changes from 'fixeria/trx' have been merged.

Change-Id: I6e228ca15577b8f2734a23ca57c436a3f7fb26fa
---
M gr-gsm-master/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Verified



diff --git a/gr-gsm-master/Dockerfile b/gr-gsm-master/Dockerfile
index 8be1a20..813b66b 100644
--- a/gr-gsm-master/Dockerfile
+++ b/gr-gsm-master/Dockerfile
@@ -3,7 +3,7 @@
 MAINTAINER Vadim Yanitskiy 

 ARGLIBOSMOCORE_BRANCH="master"
-ARGGR_GSM_BRANCH="fixeria/trx"
+ARGGR_GSM_BRANCH="master"

 # Build dependencies
 ENVBUILD_DEPS \

--
To view, visit https://gerrit.osmocom.org/10813
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e228ca15577b8f2734a23ca57c436a3f7fb26fa
Gerrit-Change-Number: 10813
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bsc[master]: codec_pref.c: Add comment in expected switch case without break

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10775 )

Change subject: codec_pref.c: Add comment in expected switch case without break
..

codec_pref.c: Add comment in expected switch case without break

Change-Id: I568353f070f049003326306106dce89b35deb92f
---
M src/osmo-bsc/codec_pref.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index cbe8ef4..2a9be6e 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -44,6 +44,7 @@
break;
case GSM0808_PERM_HR2:
LOGP(DMSC, LOGL_FATAL, "Speech HR2 was never specified!\n");
+   /* fall through */
default:
LOGP(DMSC, LOGL_FATAL, "Unsupported permitted speech %s 
selected, "
 "assuming AMR as channel mode...\n",

--
To view, visit https://gerrit.osmocom.org/10775
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I568353f070f049003326306106dce89b35deb92f
Gerrit-Change-Number: 10775
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-mgw[master]: mgcp_conn_get(): compare conn Id ('I:') case insensitively

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10677 )

Change subject: mgcp_conn_get(): compare conn Id ('I:') case insensitively
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10677
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e52278c3abe9e9c8c848c2b1538bce443f68a43
Gerrit-Change-Number: 10677
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:10:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: gr-gsm-master/Dockerfile: fix full system upgrade

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10812 )

Change subject: gr-gsm-master/Dockerfile: fix full system upgrade
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10812
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb3ccb9a9531686efcebb3e277421c4c05387b09
Gerrit-Change-Number: 10812
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:09:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: gr-gsm-master/Dockerfile: fix full system upgrade

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10812 )

Change subject: gr-gsm-master/Dockerfile: fix full system upgrade
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10812
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb3ccb9a9531686efcebb3e277421c4c05387b09
Gerrit-Change-Number: 10812
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:10:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: mgcp_conn_get(): match conn Id ('I:') despite leading zeros

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10678 )

Change subject: mgcp_conn_get(): match conn Id ('I:') despite leading zeros
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If55a64a2da47b6eff035711c08e4114d70dbec91
Gerrit-Change-Number: 10678
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:10:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: gr-gsm-master/Dockerfile: use 'master' branch for gr-gsm

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10813 )

Change subject: gr-gsm-master/Dockerfile: use 'master' branch for gr-gsm
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10813
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e228ca15577b8f2734a23ca57c436a3f7fb26fa
Gerrit-Change-Number: 10813
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:10:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: inter-BSC HO incoming: send BSSMAP HO Complete directly

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10811 )

Change subject: inter-BSC HO incoming: send BSSMAP HO Complete directly
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10811
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48ae2bb23565015d5e2ccb56308fad09347b51a
Gerrit-Change-Number: 10811
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:07:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: SCCPlite Assignment Complete: include Speech Codec (Chosen)

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10810 )

Change subject: SCCPlite Assignment Complete: include Speech Codec (Chosen)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10810
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedade8d71a7994d25a63bc2faa2a24a10bfffa1
Gerrit-Change-Number: 10810
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:07:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: inter-BSC HO outgoing: fix L3 forwarding

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10809 )

Change subject: inter-BSC HO outgoing: fix L3 forwarding
..


Patch Set 1: Code-Review+1

agreeing with vadim


--
To view, visit https://gerrit.osmocom.org/10809
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
Gerrit-Change-Number: 10809
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:06:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: add osmo_str_tolower() and _toupper() with test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10830 )

Change subject: add osmo_str_tolower() and _toupper() with test
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10830
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ee1206b9f31d7ba25c31f8008119ac55440797
Gerrit-Change-Number: 10830
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:03:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: add osmo_str_tolower() and _toupper() with test

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10830 )

Change subject: add osmo_str_tolower() and _toupper() with test
..

add osmo_str_tolower() and _toupper() with test

We already have osmo_str2lower() and osmo_str2upper(), but these lack:
* proper destination buffer bounds checking,
* ability to call directly as printf() argument.

Deprecate osmo_str2upper() and osmo_str2lower() because of missing bounds
checking.

Introduce osmo_str_tolower_buf(), osmo_str_toupper_buf() to provide
bounds-safe conversion, also able to safely convert a buffer in-place.

Introduce osmo_str_tolower(), osmo_str_toupper() that call the above _buf()
equivalents using a static buffer[128] and returning the resulting string
directly, convenient for direct printing. Possibly truncated but always safe.

Add unit tests to utils_test.c.

Replace all libosmocore uses of now deprecated osmo_str2lower().

Naming: the ctype.h API is called tolower() and toupper(), so just prepend
'osmo_str_' and don't separate 'to_lower'.

Change-Id: Ib0ee1206b9f31d7ba25c31f8008119ac55440797
---
M include/osmocom/core/utils.h
M src/utils.c
M src/vty/logging_vty.c
M tests/utils/utils_test.c
M tests/utils/utils_test.ok
5 files changed, 333 insertions(+), 9 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h
index 976d4a8..0b54c88 100644
--- a/include/osmocom/core/utils.h
+++ b/include/osmocom/core/utils.h
@@ -7,6 +7,7 @@
 #include 
 #include 
 #include 
+#include 

 /*! \defgroup utils General-purpose utility functions
  *  @{
@@ -57,8 +58,18 @@

 #define osmo_static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1] 
__attribute__((__unused__));

-void osmo_str2lower(char *out, const char *in);
-void osmo_str2upper(char *out, const char *in);
+void osmo_str2lower(char *out, const char *in)
+   OSMO_DEPRECATED("Use osmo_str_tolower() or osmo_str_tolower_buf() 
instead,"
+   " to properly check target memory bounds");
+void osmo_str2upper(char *out, const char *in)
+   OSMO_DEPRECATED("Use osmo_str_toupper() or osmo_str_toupper_buf() 
instead,"
+   " to properly check target memory bounds");
+
+size_t osmo_str_tolower_buf(char *dest, size_t dest_len, const char *src);
+const char *osmo_str_tolower(const char *src);
+
+size_t osmo_str_toupper_buf(char *dest, size_t dest_len, const char *src);
+const char *osmo_str_toupper(const char *src);

 #define OSMO_SNPRINTF_RET(ret, rem, offset, len)   \
 do {   \
diff --git a/src/utils.c b/src/utils.c
index 3f40f2e..e6adcf8 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -638,4 +638,90 @@
return g0;
 }

+/*! Convert a string to lowercase, while checking buffer size boundaries.
+ * The result written to \a dest is guaranteed to be nul terminated if \a 
dest_len > 0.
+ * If dest == src, the string is converted in-place, if necessary truncated at 
dest_len - 1 characters
+ * length as well as nul terminated.
+ * Note: similar osmo_str2lower(), but safe to use for src strings of 
arbitrary length.
+ *  \param[out] dest  Target buffer to write lowercase string.
+ *  \param[in] dest_len  Maximum buffer size of dest (e.g. sizeof(dest)).
+ *  \param[in] src  String to convert to lowercase.
+ *  \returns Length of \a src, like osmo_strlcpy(), but if \a dest == \a src 
at most \a dest_len - 1.
+ */
+size_t osmo_str_tolower_buf(char *dest, size_t dest_len, const char *src)
+{
+   size_t rc;
+   if (dest == src) {
+   if (dest_len < 1)
+   return 0;
+   dest[dest_len - 1] = '\0';
+   rc = strlen(dest);
+   } else {
+   if (dest_len < 1)
+   return strlen(src);
+   rc = osmo_strlcpy(dest, src, dest_len);
+   }
+   for (; *dest; dest++)
+   *dest = tolower(*dest);
+   return rc;
+}
+
+/*! Convert a string to lowercase, using a static buffer.
+ * The resulting string may be truncated if the internally used static buffer 
is shorter than src.
+ * The internal buffer is at least 128 bytes long, i.e. guaranteed to hold at 
least 127 characters and a
+ * terminating nul.
+ * See also osmo_str_tolower_buf().
+ * \param[in] src  String to convert to lowercase.
+ * \returns Resulting lowercase string in a static buffer, always nul 
terminated.
+ */
+const char *osmo_str_tolower(const char *src)
+{
+   static char buf[128];
+   osmo_str_tolower_buf(buf, sizeof(buf), src);
+   return buf;
+}
+
+/*! Convert a string to uppercase, while checking buffer size boundaries.
+ * The result written to \a dest is guaranteed to be nul terminated if \a 
dest_len > 0.
+ * If dest == src, the string is converted in-place, if necessary truncated at 

Change in libosmocore[master]: api doc: fix osmo_quote_str_*

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10829 )

Change subject: api doc: fix osmo_quote_str_*
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10829
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd8ff213630e34009936b0fcb3ee50dda65fb70
Gerrit-Change-Number: 10829
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:02:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: common/l1ctl.c: fix: use signed type for TA in l1ctl_tx_param_req()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10816 )

Change subject: common/l1ctl.c: fix: use signed type for TA in 
l1ctl_tx_param_req()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10816
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee42b5fa2ca9ebe187f0b933465c49f840a55c2
Gerrit-Change-Number: 10816
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:01:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trx_toolkit/fake_trx: drop Timing Advance range limitation

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10818 )

Change subject: trx_toolkit/fake_trx: drop Timing Advance range limitation
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10818
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fd2a2ab7784b38bde5ebcfd0359b7e2cb53f5a7
Gerrit-Change-Number: 10818
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:02:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: api doc: fix osmo_quote_str_*

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10829 )

Change subject: api doc: fix osmo_quote_str_*
..

api doc: fix osmo_quote_str_*

Change-Id: Ibfd8ff213630e34009936b0fcb3ee50dda65fb70
---
M src/utils.c
1 file changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/utils.c b/src/utils.c
index ea0bbde..3f40f2e 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -557,8 +557,8 @@
 /*! Like osmo_escape_str(), but returns double-quotes around a string, or 
"NULL" for a NULL string.
  * This allows passing any char* value and get its C representation as string.
  * \param[in] str  A string that may contain any characters.
- * \param[in] len  Pass -1 to print until nul char, or >= 0 to force a length.
- * \returns buf containing an escaped representation, possibly truncated, or 
str itself.
+ * \param[in] in_len  Pass -1 to print until nul char, or >= 0 to force a 
length.
+ * \returns buf containing a quoted and escaped representation, possibly 
truncated.
  */
 const char *osmo_quote_str_buf(const char *str, int in_len, char *buf, size_t 
bufsize)
 {
@@ -587,6 +587,12 @@
return buf;
 }

+/*! Like osmo_quote_str_buf() but returns the result in a static buffer.
+ * The static buffer is shared with get_value_string() and osmo_escape_str().
+ * \param[in] str  A string that may contain any characters.
+ * \param[in] in_len  Pass -1 to print until nul char, or >= 0 to force a 
length.
+ * \returns static buffer containing a quoted and escaped representation, 
possibly truncated.
+ */
 const char *osmo_quote_str(const char *str, int in_len)
 {
return osmo_quote_str_buf(str, in_len, namebuf, sizeof(namebuf));

--
To view, visit https://gerrit.osmocom.org/10829
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfd8ff213630e34009936b0fcb3ee50dda65fb70
Gerrit-Change-Number: 10829
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmocom-bb[master]: trx_toolkit/fake_trx: drop Timing Advance range limitation

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10818 )

Change subject: trx_toolkit/fake_trx: drop Timing Advance range limitation
..

trx_toolkit/fake_trx: drop Timing Advance range limitation

Despite the correct range of Timing Advance value is [0..63],
there is a special feature in OsmocomBB which allows one to
simulate the distance between both MS and a BTS by playing
with the signal delay.

So, let's drop the range limitation.

Change-Id: I8fd2a2ab7784b38bde5ebcfd0359b7e2cb53f5a7
---
M src/target/trx_toolkit/ctrl_if_bb.py
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/target/trx_toolkit/ctrl_if_bb.py 
b/src/target/trx_toolkit/ctrl_if_bb.py
index 929caf4..808c880 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -119,12 +119,6 @@
elif self.verify_cmd(request, "SETTA", 1):
print("[i] Recv SETTA cmd")

-   # Parse and check TA value
-   ta = int(request[1])
-   if ta < 0 or ta > 63:
-   print("[!] TA value should be in range: 0..63")
-   return -1
-
# Save to the BurstForwarder instance
self.burst_fwd.ta = ta
return 0

--
To view, visit https://gerrit.osmocom.org/10818
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fd2a2ab7784b38bde5ebcfd0359b7e2cb53f5a7
Gerrit-Change-Number: 10818
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmocom-bb[master]: common/l1ctl.c: fix: use signed type for TA in l1ctl_tx_param_req()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10816 )

Change subject: common/l1ctl.c: fix: use signed type for TA in 
l1ctl_tx_param_req()
..

common/l1ctl.c: fix: use signed type for TA in l1ctl_tx_param_req()

Despite the correct range of Timing Advance value is [0..63],
there is a special feature in OsmocomBB which allows one to
simulate the distance between both MS and a BTS by playing
with the signal delay.

It was discovered that l1ctl_tx_param_req() is using an unsigned
'uint8_t' type for Timing Advance value, while other code and
L1CTL protocol is using signed 'int8_t'. This may result in
distortion of negative values, so let's fix this!

Change-Id: I6ee42b5fa2ca9ebe187f0b933465c49f840a55c2
---
M src/host/layer23/include/osmocom/bb/common/l1ctl.h
M src/host/layer23/src/common/l1ctl.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/layer23/include/osmocom/bb/common/l1ctl.h 
b/src/host/layer23/include/osmocom/bb/common/l1ctl.h
index 824b1b0..e4dbded 100644
--- a/src/host/layer23/include/osmocom/bb/common/l1ctl.h
+++ b/src/host/layer23/include/osmocom/bb/common/l1ctl.h
@@ -14,7 +14,7 @@
uint8_t link_id);

 /* Transmit L1CTL_PARAM_REQ */
-int l1ctl_tx_param_req(struct osmocom_ms *ms, uint8_t ta, uint8_t tx_power);
+int l1ctl_tx_param_req(struct osmocom_ms *ms, int8_t ta, uint8_t tx_power);

 int l1ctl_tx_crypto_req(struct osmocom_ms *ms, uint8_t chan_nr,
uint8_t algo, uint8_t *key, uint8_t len);
diff --git a/src/host/layer23/src/common/l1ctl.c 
b/src/host/layer23/src/common/l1ctl.c
index f4c214d..3c57042 100644
--- a/src/host/layer23/src/common/l1ctl.c
+++ b/src/host/layer23/src/common/l1ctl.c
@@ -388,7 +388,7 @@
 }

 /* Transmit L1CTL_PARAM_REQ */
-int l1ctl_tx_param_req(struct osmocom_ms *ms, uint8_t ta, uint8_t tx_power)
+int l1ctl_tx_param_req(struct osmocom_ms *ms, int8_t ta, uint8_t tx_power)
 {
struct msgb *msg;
struct l1ctl_info_ul *ul;

--
To view, visit https://gerrit.osmocom.org/10816
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ee42b5fa2ca9ebe187f0b933465c49f840a55c2
Gerrit-Change-Number: 10816
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmocom-bb[master]: trxcon/trx_if.c: drop Timing Advance range limitation

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10817 )

Change subject: trxcon/trx_if.c: drop Timing Advance range limitation
..

trxcon/trx_if.c: drop Timing Advance range limitation

Despite the correct range of Timing Advance value is [0..63],
there is a special feature in OsmocomBB which allows one to
simulate the distance between both MS and a BTS by playing
with the signal delay.

This is why a signed 'int8_t' type is used in L1CTL protocol.
No need to limit the range, just forward it to TRX.

Change-Id: I06774b315b8451bf14083da6b2849d6e8594abc8
---
M src/host/trxcon/trx_if.c
1 file changed, 3 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index b3735c2..19d8c75 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -380,7 +380,9 @@
  * advance calculated from requested TA value. This value is
  * normally between 0 and 63, with each step representing
  * an advance of one bit period (about 3.69 microseconds).
- * CMD SETTA <0-63>
+ * Since OsmocomBB has a special feature, which allows one
+ * to spoof the distance from BTS, the range is extended.
+ * CMD SETTA <-128..127>
  * RSP SETTA  
  */

@@ -390,12 +392,6 @@
if (trx->ta == ta)
return 0;

-   /* Make sure that TA value is in valid range */
-   if (ta < 0 || ta > 63) {
-   LOGP(DTRX, LOGL_ERROR, "TA value %d is out of allowed range\n", 
ta);
-   return -ENOTSUP;
-   }
-
return trx_ctrl_cmd(trx, 0, "SETTA", "%d", ta);
 }


--
To view, visit https://gerrit.osmocom.org/10817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I06774b315b8451bf14083da6b2849d6e8594abc8
Gerrit-Change-Number: 10817
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmocom-bb[master]: trxcon/trx_if.c: drop Timing Advance range limitation

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10817 )

Change subject: trxcon/trx_if.c: drop Timing Advance range limitation
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06774b315b8451bf14083da6b2849d6e8594abc8
Gerrit-Change-Number: 10817
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:01:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in simtrace2[master]: owhw: add missing function board_exec_dbg_cmd

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10824 )

Change subject: owhw: add missing function board_exec_dbg_cmd
..

owhw: add missing function board_exec_dbg_cmd

the board_exec_dbg_cmd function was not defined, causing a hard
fault on user input

Change-Id: I3ecc1f7bdb2484f5a67c36163d33ebc065e4e709
---
M firmware/libboard/owhw/source/owhw.c
1 file changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libboard/owhw/source/owhw.c 
b/firmware/libboard/owhw/source/owhw.c
index 91c1294..be62660 100644
--- a/firmware/libboard/owhw/source/owhw.c
+++ b/firmware/libboard/owhw/source/owhw.c
@@ -24,6 +24,24 @@

 static const Pin pins_cardsim[] = PINS_CARDSIM;

+void board_exec_dbg_cmd(int ch)
+{
+   switch (ch) {
+   case '?':
+   printf("\t?\thelp\n\r");
+   printf("\tR\treset SAM3\n\r");
+   break;
+   case 'R':
+   printf("Asking NVIC to reset us\n\r");
+   USBD_Disconnect();
+   NVIC_SystemReset();
+   break;
+   default:
+   printf("Unknown command '%c'\n\r", ch);
+   break;
+   }
+}
+
 void cardsim_set_simpres(uint8_t slot, int present)
 {
if (slot > 1)

--
To view, visit https://gerrit.osmocom.org/10824
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ecc1f7bdb2484f5a67c36163d33ebc065e4e709
Gerrit-Change-Number: 10824
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in simtrace2[master]: minor: fix typo in comment

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10822 )

Change subject: minor: fix typo in comment
..

minor: fix typo in comment

Change-Id: I3edb50abe93bc8574c9c1f25b34f75dab2e8f0ce
---
M firmware/apps/cardem/main.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c
index 0b5fbde..ef24c36 100644
--- a/firmware/apps/cardem/main.c
+++ b/firmware/apps/cardem/main.c
@@ -129,9 +129,8 @@
return;

ch = UART_GetChar();
-   /* We must echo the character to make python fdexpect happy, whcih we 
use in factory testing */
+   /* We must echo the character to make python fdexpect happy, which we 
use in factory testing */
fputc(ch, stdout);
-
board_exec_dbg_cmd(ch);
 }


--
To view, visit https://gerrit.osmocom.org/10822
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3edb50abe93bc8574c9c1f25b34f75dab2e8f0ce
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in simtrace2[master]: owhw: add missing function board_main_top

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10825 )

Change subject: owhw: add missing function board_main_top
..

owhw: add missing function board_main_top

the board_main_top function was not defined, causing a hard fault
when initializing the board

Change-Id: Ib92003416648822c4115472992850c592bc4047a
---
M firmware/libboard/owhw/source/owhw.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libboard/owhw/source/owhw.c 
b/firmware/libboard/owhw/source/owhw.c
index be62660..3bf51ec 100644
--- a/firmware/libboard/owhw/source/owhw.c
+++ b/firmware/libboard/owhw/source/owhw.c
@@ -21,6 +21,7 @@
 #include "chip.h"
 #include "board.h"
 #include "utils.h"
+#include "usb_buf.h"

 static const Pin pins_cardsim[] = PINS_CARDSIM;

@@ -42,6 +43,13 @@
}
 }

+void board_main_top(void)
+{
+#ifndef APPLICATION_dfu
+   usb_buf_init();
+#endif
+}
+
 void cardsim_set_simpres(uint8_t slot, int present)
 {
if (slot > 1)

--
To view, visit https://gerrit.osmocom.org/10825
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib92003416648822c4115472992850c592bc4047a
Gerrit-Change-Number: 10825
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in simtrace2[master]: host: clean library dependencies

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10826 )

Change subject: host: clean library dependencies
..

host: clean library dependencies

remsim also needs libpcsclite
`pkg-config --libs libosmocore` and -losmocore are duplicates
`pkg-config --libs libosmosim` is equivalent to -losmosim
pthread it needed (by most applications) for static compilation
LDFLAGS+= allows static compilation when running
LDFLAGS="-static" make

Change-Id: Ic7bd6f2be074d6f652d4f84f4996c8588ea5f851
---
M host/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/host/Makefile b/host/Makefile
index 7d5c7a4..aee399c 100644
--- a/host/Makefile
+++ b/host/Makefile
@@ -1,4 +1,4 @@
-LDFLAGS=`pkg-config --libs libusb-1.0 libosmocore` -losmocore
+LDFLAGS+=`pkg-config --libs libusb-1.0 libosmocore` -pthread
 CFLAGS=-Wall -g

 APPS=simtrace2-remsim simtrace2-remsim-usb2udp simtrace2-list simtrace2-sniff
@@ -6,7 +6,7 @@
 all: $(APPS)

 simtrace2-remsim: simtrace2-remsim.o apdu_dispatch.o simtrace2-discovery.o 
libusb_util.o
-   $(CC) -o $@ $^ $(LDFLAGS) -losmosim
+   $(CC) -o $@ $^ $(LDFLAGS) `pkg-config --libs libosmosim libpcsclite`

 simtrace2-remsim-usb2udp: usb2udp.o simtrace2-discovery.o
$(CC) -o $@ $^ $(LDFLAGS)

--
To view, visit https://gerrit.osmocom.org/10826
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7bd6f2be074d6f652d4f84f4996c8588ea5f851
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in simtrace2[master]: minor: update copyright

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10823 )

Change subject: minor: update copyright
..

minor: update copyright

Change-Id: Iafcd029be9b3f8cf2e90f08d5e9802912d6a59b1
---
M firmware/apps/cardem/main.c
M firmware/libboard/common/include/board_common.h
M firmware/libboard/common/source/board_lowlevel.c
M firmware/libboard/owhw/include/board.h
M firmware/libboard/owhw/source/owhw.c
M firmware/libboard/qmod/source/board_qmod.c
6 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c
index ef24c36..209c79f 100644
--- a/firmware/apps/cardem/main.c
+++ b/firmware/apps/cardem/main.c
@@ -1,6 +1,7 @@
 /* SIMtrace 2 firmware card emulation application
  *
  * (C) 2015-2017 by Harald Welte 
+ * (C) 2018, sysmocom -s.f.m.c. GmbH, Author: Kevin Redon 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
diff --git a/firmware/libboard/common/include/board_common.h 
b/firmware/libboard/common/include/board_common.h
index 1155158..cb72d40 100644
--- a/firmware/libboard/common/include/board_common.h
+++ b/firmware/libboard/common/include/board_common.h
@@ -1,5 +1,8 @@
 /* SIMtrace 2 common board pin definitions
  *
+ * (C) 2015-2017 by Harald Welte 
+ * (C) 2018, sysmocom -s.f.m.c. GmbH, Author: Kevin Redon 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
diff --git a/firmware/libboard/common/source/board_lowlevel.c 
b/firmware/libboard/common/source/board_lowlevel.c
index 2be6134..8210938 100644
--- a/firmware/libboard/common/source/board_lowlevel.c
+++ b/firmware/libboard/common/source/board_lowlevel.c
@@ -2,6 +2,7 @@
  * ATMEL Microcontroller Software Support
  * 
  * Copyright (c) 2009, Atmel Corporation
+ * Copyright (c) 2018, sysmocom -s.f.m.c. GmbH, Author: Kevin Redon 

  *
  * All rights reserved.
  *
diff --git a/firmware/libboard/owhw/include/board.h 
b/firmware/libboard/owhw/include/board.h
index 401fb73..8c0052d 100644
--- a/firmware/libboard/owhw/include/board.h
+++ b/firmware/libboard/owhw/include/board.h
@@ -1,6 +1,7 @@
 /* OWHW board definition
  *
  * (C) 2015-2017 by Harald Welte 
+ * (C) 2018, sysmocom -s.f.m.c. GmbH, Author: Kevin Redon 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
diff --git a/firmware/libboard/owhw/source/owhw.c 
b/firmware/libboard/owhw/source/owhw.c
index 2cfa8c6..91c1294 100644
--- a/firmware/libboard/owhw/source/owhw.c
+++ b/firmware/libboard/owhw/source/owhw.c
@@ -1,6 +1,7 @@
 /* Card simulator specific functions
  *
  * (C) 2015-2017 by Harald Welte 
+ * (C) 2018, sysmocom -s.f.m.c. GmbH, Author: Kevin Redon 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
diff --git a/firmware/libboard/qmod/source/board_qmod.c 
b/firmware/libboard/qmod/source/board_qmod.c
index 9073489..ad1f6b7 100644
--- a/firmware/libboard/qmod/source/board_qmod.c
+++ b/firmware/libboard/qmod/source/board_qmod.c
@@ -1,6 +1,7 @@
 /* sysmocom quad-modem sysmoQMOD application code
  *
  * (C) 2016-2017 by Harald Welte 
+ * (C) 2018, sysmocom -s.f.m.c. GmbH, Author: Kevin Redon 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by

--
To view, visit https://gerrit.osmocom.org/10823
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafcd029be9b3f8cf2e90f08d5e9802912d6a59b1
Gerrit-Change-Number: 10823
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in simtrace2[master]: minor: add checks on configurations and functions

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10821 )

Change subject: minor: add checks on configurations and functions
..

minor: add checks on configurations and functions

these checks prevent out of bounds access and running
unset function pointers.

Change-Id: Ida889d40b898fc1ab8b885800431833570fdaafe
---
M firmware/apps/cardem/main.c
1 file changed, 17 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c
index 600e4e9..0b5fbde 100644
--- a/firmware/apps/cardem/main.c
+++ b/firmware/apps/cardem/main.c
@@ -101,7 +101,11 @@
 void USBDDriverCallbacks_ConfigurationChanged(uint8_t cfgnum)
 {
TRACE_INFO_WP("cfgChanged%d ", cfgnum);
-   simtrace_config = cfgnum;
+   if (cfgnum < ARRAY_SIZE(config_func_ptrs)) {
+   simtrace_config = cfgnum;
+   } else {
+   TRACE_ERROR("trying to set out of bounds config %u\r\n", 
cfgnum);
+   }
 }

 void USART1_IrqHandler(void)
@@ -204,7 +208,9 @@
}

TRACE_INFO("calling init of config %u...\n\r", simtrace_config);
-   config_func_ptrs[simtrace_config].init();
+   if (config_func_ptrs[simtrace_config].init) {
+   config_func_ptrs[simtrace_config].init();
+   }
last_simtrace_config = simtrace_config;

TRACE_INFO("entering main loop...\n\r");
@@ -232,11 +238,17 @@
if (last_simtrace_config != simtrace_config) {
TRACE_INFO("USB config chg %u -> %u\n\r",
   last_simtrace_config, simtrace_config);
-   config_func_ptrs[last_simtrace_config].exit();
-   config_func_ptrs[simtrace_config].init();
+   if (config_func_ptrs[last_simtrace_config].exit) {
+   config_func_ptrs[last_simtrace_config].exit();
+   }
+   if (config_func_ptrs[simtrace_config].init) {
+   config_func_ptrs[simtrace_config].init();
+   }
last_simtrace_config = simtrace_config;
} else {
-   config_func_ptrs[simtrace_config].run();
+   if (config_func_ptrs[simtrace_config].run) {
+   config_func_ptrs[simtrace_config].run();
+   }
}
}
 }

--
To view, visit https://gerrit.osmocom.org/10821
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida889d40b898fc1ab8b885800431833570fdaafe
Gerrit-Change-Number: 10821
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in simtrace2[master]: host: clean library dependencies

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10826 )

Change subject: host: clean library dependencies
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10826
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7bd6f2be074d6f652d4f84f4996c8588ea5f851
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 07 Sep 2018 06:31:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes