date:20181202

Build failed in Jenkins: master-simtrace2 » a1=default,a2=default,a3=default,osmocom-master-debian9 #208

2018-12-02 Thread jenkins

See 


--
[...truncated 168.04 KB...]
  8   0   0   8   8 obj/owhw/dfu_boardver_adc.o
 30  16   0  46  2e obj/owhw/dfu_manifest.o
239   0   0 239  ef obj/owhw/dfu_owhw.o
   1472   1   01473 5c1 obj/owhw/dfu_main.o
244   0   0 244  f4 obj/owhw/dfu_dfu.o
645   4   6 655 28f obj/owhw/dfu_dfu_runtime.o
   3490   0 2083698 e72 obj/owhw/dfu_card_emu.o
  0   0   0   0   0 obj/owhw/dfu_cciddriver.o
   2629  12   42645 a55 obj/owhw/dfu_iso7816_4.o
 96   0   0  96  60 obj/owhw/dfu_iso7816_fidi.o
  0   0   0   0   0 obj/owhw/dfu_mitm.o
   23081152   03460 d84 obj/owhw/dfu_mode_cardemu.o
  0   0   0   0   0 obj/owhw/dfu_mode_ccid.o
352   0 520 872 368 obj/owhw/dfu_simtrace_iso7816.o
  0   0   0   0   0 obj/owhw/dfu_sniffer.o
488  40   0 528 210 obj/owhw/dfu_tc_etu.o
597  48   0 645 285 obj/owhw/dfu_usb.o
  26024   0   17988   44012abec bin/owhw-cardem-dfu.elf
=== owhw / cardem RES:0 ==

=== FIRMWARE TESTS ===
cc -g -Wall `pkg-config --cflags libosmocore` -I../src_simtrace 
-I../atmel_softpack_libraries/libchip_sam3s 
-I../atmel_softpack_libraries/libchip_sam3s/cmsis 
-I../atmel_softpack_libraries/libchip_sam3s/include 
-I../atmel_softpack_libraries/usb/include -I../libcommon/include 
-I../libboard/common/include -I../libboard/simtrace/include -I. -o 
card_emu_tests.hobj -c card_emu_tests.c
In file included from ../libboard/common/include/board_common.h:24:0,
 from ../libboard/simtrace/include/board.h:21,
 from 
../atmel_softpack_libraries/libchip_sam3s/include/trace.h:70,
 from ../libcommon/include/assert.h:60,
 from card_emu_tests.c:4:
../atmel_softpack_libraries/libchip_sam3s/chip.h:11:6: warning: #warning 
Library does not support the specified chip, specifying sam3s4. [-Wcpp]
 #warning Library does not support the specified chip, specifying sam3s4.
  ^~~
card_emu_tests.c: In function ‘get_and_verify_rctx’:
card_emu_tests.c:171:34: warning: unused variable ‘td’ [-Wunused-variable]
  struct cardemu_usb_msg_tx_data *td;
  ^~
cc -g -Wall `pkg-config --cflags libosmocore` -I../src_simtrace 
-I../atmel_softpack_libraries/libchip_sam3s 
-I../atmel_softpack_libraries/libchip_sam3s/cmsis 
-I../atmel_softpack_libraries/libchip_sam3s/include 
-I../atmel_softpack_libraries/usb/include -I../libcommon/include 
-I../libboard/common/include -I../libboard/simtrace/include -I. -o 
card_emu.hobj -c ../libcommon/source/card_emu.c
In file included from ../libboard/common/include/board_common.h:24:0,
 from ../libboard/simtrace/include/board.h:21,
 from 
../atmel_softpack_libraries/libchip_sam3s/include/trace.h:70,
 from ../libcommon/include/assert.h:60,
 from ../libcommon/source/card_emu.c:21:
../atmel_softpack_libraries/libchip_sam3s/chip.h:11:6: warning: #warning 
Library does not support the specified chip, specifying sam3s4. [-Wcpp]
 #warning Library does not support the specified chip, specifying sam3s4.
  ^~~
In file included from ../libcommon/source/card_emu.c:27:0:
../libcommon/include/utils.h:31:2: warning: #warning 
"local_irq_{save,restore}() not implemented" [-Wcpp]
 #warning "local_irq_{save,restore}() not implemented"
  ^~~
../libcommon/source/card_emu.c: In function ‘flush_rx_buffer’:
../libcommon/source/card_emu.c:279:11: warning: unused variable ‘data_len’ 
[-Wunused-variable]
  uint32_t data_len;
   ^~~~
cc -g -Wall `pkg-config --cflags libosmocore` -I../src_simtrace 
-I../atmel_softpack_libraries/libchip_sam3s 
-I../atmel_softpack_libraries/libchip_sam3s/cmsis 
-I../atmel_softpack_libraries/libchip_sam3s/include 
-I../atmel_softpack_libraries/usb/include -I../libcommon/include 
-I../libboard/common/include -I../libboard/simtrace/include -I. -o usb_buf.hobj 
-c ../libcommon/source/usb_buf.c
In file included from ../libboard/common/include/board_common.h:24:0,
 from ../libboard/simtrace/include/board.h:21,
 from ../libcommon/source/usb_buf.c:17:
../atmel_softpack_libraries/libchip_sam3s/chip.h:11:6: warning: #warning 
Library does not support the specified chip, specifying sam3s4. [-Wcpp]
 #warning Library does not support the specified chip, specifying sam3s4.
  ^~~
cc -g -Wall `pkg-config --cflags libosmocore` -I../src_simtrace 
-I../atmel_softpack_libraries/libchip_sam3s 
-I../atmel_softpack_libraries/libchip_sam3s/cmsis

Jenkins build is back to normal : master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #7202

2018-12-02 Thread jenkins

See

Build failed in Jenkins: master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #3319

2018-12-02 Thread jenkins

See 


--
[...truncated 13.02 KB...]
error: unable to write file openbsc/include/openbsc/ipaccess.h
error: unable to write file openbsc/include/openbsc/iu.h
error: unable to write file openbsc/include/openbsc/meas_feed.h
error: unable to write file openbsc/include/openbsc/meas_rep.h
error: unable to write file openbsc/include/openbsc/mgcp.h
error: unable to write file openbsc/include/openbsc/mgcp_internal.h
error: unable to write file openbsc/include/openbsc/mgcp_transcode.h
error: unable to write file openbsc/include/openbsc/misdn.h
error: unable to write file openbsc/include/openbsc/mncc.h
error: unable to write file openbsc/include/openbsc/mncc_int.h
error: unable to write file openbsc/include/openbsc/nat_rewrite_trie.h
error: unable to write file openbsc/include/openbsc/network_listen.h
error: unable to write file openbsc/include/openbsc/oap_client.h
error: unable to write file openbsc/include/openbsc/openbscdefines.h
error: unable to write file openbsc/include/openbsc/osmo_bsc.h
error: unable to write file openbsc/include/openbsc/osmo_bsc_grace.h
error: unable to write file openbsc/include/openbsc/osmo_bsc_rf.h
error: unable to write file openbsc/include/openbsc/osmo_msc.h
error: unable to write file openbsc/include/openbsc/osmux.h
error: unable to write file openbsc/include/openbsc/paging.h
error: unable to write file openbsc/include/openbsc/pcu_if.h
error: unable to write file openbsc/include/openbsc/pcuif_proto.h
error: unable to write file openbsc/include/openbsc/rest_octets.h
error: unable to write file openbsc/include/openbsc/rrlp.h
error: unable to write file openbsc/include/openbsc/rs232.h
error: unable to write file openbsc/include/openbsc/rtp_proxy.h
error: unable to write file openbsc/include/openbsc/signal.h
error: unable to write file openbsc/include/openbsc/silent_call.h
error: unable to write file openbsc/include/openbsc/smpp.h
error: unable to write file openbsc/include/openbsc/sms_queue.h
error: unable to write file openbsc/include/openbsc/socket.h
error: unable to write file openbsc/include/openbsc/system_information.h
error: unable to write file openbsc/include/openbsc/token_auth.h
error: unable to write file openbsc/include/openbsc/transaction.h
error: unable to write file openbsc/include/openbsc/trau_mux.h
error: unable to write file openbsc/include/openbsc/trau_upqueue.h
error: unable to write file openbsc/include/openbsc/ussd.h
error: unable to write file openbsc/include/openbsc/vty.h
error: unable to write file openbsc/m4/README
error: unable to write file openbsc/m4/ax_check_compile_flag.m4
error: unable to write file openbsc/openbsc.pc.in
error: unable to write file openbsc/osmoappdesc.py
error: unable to write file openbsc/src/Makefile.am
error: unable to write file openbsc/src/ipaccess/Makefile.am
error: unable to write file openbsc/src/ipaccess/abisip-find.c
error: unable to write file openbsc/src/ipaccess/ipaccess-config.c
error: unable to write file openbsc/src/ipaccess/ipaccess-firmware.c
error: unable to write file openbsc/src/ipaccess/ipaccess-proxy.c
error: unable to write file openbsc/src/ipaccess/network_listen.c
error: unable to write file openbsc/src/libbsc/Makefile.am
error: unable to write file openbsc/src/libbsc/abis_nm.c
error: unable to write file openbsc/src/libbsc/abis_nm_ipaccess.c
error: unable to write file openbsc/src/libbsc/abis_nm_vty.c
error: unable to write file openbsc/src/libbsc/abis_om2000.c
error: unable to write file openbsc/src/libbsc/abis_om2000_vty.c
error: unable to write file openbsc/src/libbsc/abis_rsl.c
error: unable to write file openbsc/src/libbsc/acc_ramp.c
error: unable to write file openbsc/src/libbsc/arfcn_range_encode.c
error: unable to write file openbsc/src/libbsc/bsc_api.c
error: unable to write file openbsc/src/libbsc/bsc_ctrl_commands.c
error: unable to write file openbsc/src/libbsc/bsc_ctrl_lookup.c
error: unable to write file openbsc/src/libbsc/bsc_dyn_ts.c
error: unable to write file openbsc/src/libbsc/bsc_init.c
error: unable to write file openbsc/src/libbsc/bsc_msc.c
error: unable to write file openbsc/src/libbsc/bsc_rf_ctrl.c
error: unable to write file openbsc/src/libbsc/bsc_rll.c
error: unable to write file openbsc/src/libbsc/bsc_subscriber.c
error: unable to write file openbsc/src/libbsc/bsc_vty.c
error: unable to write file openbsc/src/libbsc/bts_ericsson_rbs2000.c
error: unable to write file openbsc/src/libbsc/bts_init.c
error: unable to write file openbsc/src/libbsc/bts_ipaccess_nanobts.c
error: unable to write file openbsc/src/libbsc/bts_ipaccess_nanobts_omlattr.c
error: unable to write file openbsc/src/libbsc/bts_nokia_site.c
error: unable to write file openbsc/src/libbsc/bts_siemens_bs11.c
error: unable to write file openbsc/src/libbsc/bts_sysmobts.c
error: unable to write file

Build failed in Jenkins: master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #7201

2018-12-02 Thread jenkins

See 


--
Started by upstream project "master-osmo-msc" build number 7201
originally caused by:
 Started by upstream project "master-libosmo-sccp" build number 1872
 originally caused by:
  Started by timer
Building remotely on build2-deb9build-ansible (ttcn3 osmo-gsm-tester-build 
osmocom-gerrit-debian9 osmocom-master-debian9 coverity) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.osmocom.org/osmo-msc # timeout=10
Fetching upstream changes from git://git.osmocom.org/osmo-msc
 > git --version # timeout=10
 > git fetch --tags --progress git://git.osmocom.org/osmo-msc 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision 1263bc801749af648cf4fae790ddbdd348d87e69 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1263bc801749af648cf4fae790ddbdd348d87e69
Commit message: "move gsm_cbfn to gsm_subscriber.h, the only user"
 > git rev-list --no-walk 1263bc801749af648cf4fae790ddbdd348d87e69 # timeout=10
[osmocom-master-debian9] $ /bin/sh -xe /tmp/jenkins9135587703213621573.sh
+ ARTIFACT_STORE=/home/osmocom-build/jenkins_build_artifact_store
+ mkdir -p /home/osmocom-build/jenkins_build_artifact_store
+ docker run --rm=true -i -e HOME=/build -e ARTIFACT_STORE=/artifact_store -e 
JOB_NAME=master-osmo-msc/IU=--disable-iu,a2=default,a3=default,label=osmocom-master-debian9
 -e MAKE=make -e PARALLEL_MAKE=-j 8 -e IU=--disable-iu -e 
PATH=/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin 
-e OSMOPY_DEBUG_TCP_SOCKETS=1 -w /build -u build -v 
:/build
 -v /home/osmocom-build/bin:/build_bin -v 
/home/osmocom-build/jenkins_build_artifact_store:/artifact_store osmocom:amd64 
/build/contrib/jenkins.sh --publish
+ base=/build
+ deps=/build/deps
+ inst=/build/deps/install
+ export deps inst
+ osmo-clean-workspace.sh
+ chmod -R +w .
+ git checkout -f HEAD
+ git clean -dxf
Skipping repository deps/libosmocore
Skipping repository deps/libosmo-sccp
Skipping repository deps/libosmo-netif
Skipping repository deps/libsmpp34
Skipping repository deps/osmo-hlr
Skipping repository deps/libosmo-abis
Skipping repository deps/osmo-mgw
+ [ -d /build/deps ]
+ git_clean /build/deps/libosmo-abis
+ repos=/build/deps/libosmo-abis
+ [ ! -d /build/deps/libosmo-abis ]
+ [ ! -d /build/deps/libosmo-abis/.git ]
+ git -C /build/deps/libosmo-abis checkout -f HEAD
+ git -C /build/deps/libosmo-abis clean -dxf
+ git_clean /build/deps/libosmo-netif
+ repos=/build/deps/libosmo-netif
+ [ ! -d /build/deps/libosmo-netif ]
+ [ ! -d /build/deps/libosmo-netif/.git ]
+ git -C /build/deps/libosmo-netif checkout -f HEAD
+ git -C /build/deps/libosmo-netif clean -dxf
+ git_clean /build/deps/libosmo-sccp
+ repos=/build/deps/libosmo-sccp
+ [ ! -d /build/deps/libosmo-sccp ]
+ [ ! -d /build/deps/libosmo-sccp/.git ]
+ git -C /build/deps/libosmo-sccp checkout -f HEAD
+ git -C /build/deps/libosmo-sccp clean -dxf
+ git_clean /build/deps/libosmocore
+ repos=/build/deps/libosmocore
+ [ ! -d /build/deps/libosmocore ]
+ [ ! -d /build/deps/libosmocore/.git ]
+ git -C /build/deps/libosmocore checkout -f HEAD
+ git -C /build/deps/libosmocore clean -dxf
+ git_clean /build/deps/libsmpp34
+ repos=/build/deps/libsmpp34
+ [ ! -d /build/deps/libsmpp34 ]
+ [ ! -d /build/deps/libsmpp34/.git ]
+ git -C /build/deps/libsmpp34 checkout -f HEAD
+ git -C /build/deps/libsmpp34 clean -dxf
+ git_clean /build/deps/osmo-hlr
+ repos=/build/deps/osmo-hlr
+ [ ! -d /build/deps/osmo-hlr ]
+ [ ! -d /build/deps/osmo-hlr/.git ]
+ git -C /build/deps/osmo-hlr checkout -f HEAD
+ git -C /build/deps/osmo-hlr clean -dxf
+ git_clean /build/deps/osmo-mgw
+ repos=/build/deps/osmo-mgw
+ [ ! -d /build/deps/osmo-mgw ]
+ [ ! -d /build/deps/osmo-mgw/.git ]
+ git -C /build/deps/osmo-mgw checkout -f HEAD
+ git -C /build/deps/osmo-mgw clean -dxf
+ [ -d layer1-headers ]
+ mkdir /build/deps
mkdir: cannot create directory '/build/deps': File exists
+ true
+ osmo-build-dep.sh libosmocore '' ac_cv_path_DOXYGEN=false



 === libosmocore ===

+ mkdir -p /build/deps
+ cd /build/deps
+ osmo-deps.sh libosmocore 
+ project=libosmocore
+ branch=master
+ git branch -a
+ grep -c remotes/origin/master$
+ [ x1 != x0 ]
+ branch=origin/master
+ test -d libosmocore
+ cd libosmocore
+ git fetch --tags origin
+ git fetch origin
+ deps= osmo-clean-workspace.sh
+ chmod -R +w .
+ git checkout -f HEAD
+ git clean -dxf
+ [ -d  ]
+ [ -d layer1-headers ]
+ git checkout -f origin/master

Build failed in Jenkins: master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #3319

2018-12-02 Thread jenkins

See 


--
[...truncated 13.03 KB...]
error: unable to write file openbsc/include/openbsc/ipaccess.h
error: unable to write file openbsc/include/openbsc/iu.h
error: unable to write file openbsc/include/openbsc/meas_feed.h
error: unable to write file openbsc/include/openbsc/meas_rep.h
error: unable to write file openbsc/include/openbsc/mgcp.h
error: unable to write file openbsc/include/openbsc/mgcp_internal.h
error: unable to write file openbsc/include/openbsc/mgcp_transcode.h
error: unable to write file openbsc/include/openbsc/misdn.h
error: unable to write file openbsc/include/openbsc/mncc.h
error: unable to write file openbsc/include/openbsc/mncc_int.h
error: unable to write file openbsc/include/openbsc/nat_rewrite_trie.h
error: unable to write file openbsc/include/openbsc/network_listen.h
error: unable to write file openbsc/include/openbsc/oap_client.h
error: unable to write file openbsc/include/openbsc/openbscdefines.h
error: unable to write file openbsc/include/openbsc/osmo_bsc.h
error: unable to write file openbsc/include/openbsc/osmo_bsc_grace.h
error: unable to write file openbsc/include/openbsc/osmo_bsc_rf.h
error: unable to write file openbsc/include/openbsc/osmo_msc.h
error: unable to write file openbsc/include/openbsc/osmux.h
error: unable to write file openbsc/include/openbsc/paging.h
error: unable to write file openbsc/include/openbsc/pcu_if.h
error: unable to write file openbsc/include/openbsc/pcuif_proto.h
error: unable to write file openbsc/include/openbsc/rest_octets.h
error: unable to write file openbsc/include/openbsc/rrlp.h
error: unable to write file openbsc/include/openbsc/rs232.h
error: unable to write file openbsc/include/openbsc/rtp_proxy.h
error: unable to write file openbsc/include/openbsc/signal.h
error: unable to write file openbsc/include/openbsc/silent_call.h
error: unable to write file openbsc/include/openbsc/smpp.h
error: unable to write file openbsc/include/openbsc/sms_queue.h
error: unable to write file openbsc/include/openbsc/socket.h
error: unable to write file openbsc/include/openbsc/system_information.h
error: unable to write file openbsc/include/openbsc/token_auth.h
error: unable to write file openbsc/include/openbsc/transaction.h
error: unable to write file openbsc/include/openbsc/trau_mux.h
error: unable to write file openbsc/include/openbsc/trau_upqueue.h
error: unable to write file openbsc/include/openbsc/ussd.h
error: unable to write file openbsc/include/openbsc/vty.h
error: unable to write file openbsc/m4/README
error: unable to write file openbsc/m4/ax_check_compile_flag.m4
error: unable to write file openbsc/openbsc.pc.in
error: unable to write file openbsc/osmoappdesc.py
error: unable to write file openbsc/src/Makefile.am
error: unable to write file openbsc/src/ipaccess/Makefile.am
error: unable to write file openbsc/src/ipaccess/abisip-find.c
error: unable to write file openbsc/src/ipaccess/ipaccess-config.c
error: unable to write file openbsc/src/ipaccess/ipaccess-firmware.c
error: unable to write file openbsc/src/ipaccess/ipaccess-proxy.c
error: unable to write file openbsc/src/ipaccess/network_listen.c
error: unable to write file openbsc/src/libbsc/Makefile.am
error: unable to write file openbsc/src/libbsc/abis_nm.c
error: unable to write file openbsc/src/libbsc/abis_nm_ipaccess.c
error: unable to write file openbsc/src/libbsc/abis_nm_vty.c
error: unable to write file openbsc/src/libbsc/abis_om2000.c
error: unable to write file openbsc/src/libbsc/abis_om2000_vty.c
error: unable to write file openbsc/src/libbsc/abis_rsl.c
error: unable to write file openbsc/src/libbsc/acc_ramp.c
error: unable to write file openbsc/src/libbsc/arfcn_range_encode.c
error: unable to write file openbsc/src/libbsc/bsc_api.c
error: unable to write file openbsc/src/libbsc/bsc_ctrl_commands.c
error: unable to write file openbsc/src/libbsc/bsc_ctrl_lookup.c
error: unable to write file openbsc/src/libbsc/bsc_dyn_ts.c
error: unable to write file openbsc/src/libbsc/bsc_init.c
error: unable to write file openbsc/src/libbsc/bsc_msc.c
error: unable to write file openbsc/src/libbsc/bsc_rf_ctrl.c
error: unable to write file openbsc/src/libbsc/bsc_rll.c
error: unable to write file openbsc/src/libbsc/bsc_subscriber.c
error: unable to write file openbsc/src/libbsc/bsc_vty.c
error: unable to write file openbsc/src/libbsc/bts_ericsson_rbs2000.c
error: unable to write file openbsc/src/libbsc/bts_init.c
error: unable to write file openbsc/src/libbsc/bts_ipaccess_nanobts.c
error: unable to write file openbsc/src/libbsc/bts_ipaccess_nanobts_omlattr.c
error: unable to write file openbsc/src/libbsc/bts_nokia_site.c
error: unable to write file openbsc/src/libbsc/bts_siemens_bs11.c
error: unable to write file openbsc/src/libbsc/bts_sysmobts.c
error: unable to write file

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: fix direction for SS messages

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12060


Change subject: chapters/gsup.adoc: fix direction for SS messages
..

chapters/gsup.adoc: fix direction for SS messages

Most likely, this was a copy-paste error. SGSN is not involved
in Supplemeptary Services handling, they are pure CS data.

Moreover, HLR is not the only entity that can initiate both
Process Supplementary Service Error and Response messages,
there is also EUSE (External USSD handling Entity).

Change-Id: I46ad7311747f2b392244c49d3df1e152e6f1bfe3
---
M common/chapters/gsup.adoc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/60/12060/1

diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc
index e87d979..70295cf 100644
--- a/common/chapters/gsup.adoc
+++ b/common/chapters/gsup.adoc
@@ -474,7 +474,7 @@

  Process Supplementary Service Error

-Direction: HLR => SGSN / VLR
+Direction: EUSE / HLR => MSC

 [options="header",cols="5%,20%,45%,10%,10%,10%"]
 |===
@@ -488,7 +488,7 @@

  Process Supplementary Service Response

-Direction: HLR => SGSN / VLR
+Direction: EUSE / HLR => MSC

 [options="header",cols="5%,20%,45%,10%,10%,10%"]
 |===

--
To view, visit https://gerrit.osmocom.org/12060
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46ad7311747f2b392244c49d3df1e152e6f1bfe3
Gerrit-Change-Number: 12060
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11837 )

Change subject: chapters/gsup.adoc: document READY-FOR-SM message
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549b6c8840a1e86caac09e77fb8bc5042d939e62
Gerrit-Change-Number: 11837
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Mon, 03 Dec 2018 00:31:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11836 )

Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c
Gerrit-Change-Number: 11836
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 03 Dec 2018 00:31:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: (HACK) libmsc/gsm_04_11.c: properly handle MMS indication

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12059


Change subject: (HACK) libmsc/gsm_04_11.c: properly handle MMS indication
..

(HACK) libmsc/gsm_04_11.c: properly handle MMS indication

MMS (More Messages to Send) is a part of MT-ForwardSM-Req message,
that is used by ESME to indicate that there are more MT SMS messages
to be sent, so the MSC should keep RAN connection open.

Change-Id: Ic46b04913b2e8cc5d11a39426dcc1bfe11f1d31e
Related Change-Id: (TTCN) I6308586a70c4fb3254c519330a61a9667372149f
Related: OS#3587
---
M include/osmocom/msc/gsm_04_11.h
M include/osmocom/msc/ran_conn.h
M include/osmocom/msc/transaction.h
M src/libmsc/gsm_04_11.c
M src/libmsc/gsm_04_11_gsup.c
M src/libmsc/osmo_msc.c
6 files changed, 25 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/59/12059/1

diff --git a/include/osmocom/msc/gsm_04_11.h b/include/osmocom/msc/gsm_04_11.h
index 4297cdb..0e5b3d2 100644
--- a/include/osmocom/msc/gsm_04_11.h
+++ b/include/osmocom/msc/gsm_04_11.h
@@ -42,7 +42,8 @@
 int gsm411_send_sms(struct gsm_network *net,
struct vlr_subscr *vsub,
struct gsm_sms *sms);
-int gsm411_send_rp_data(struct gsm_network *net, struct vlr_subscr *vsub,
+int gsm411_send_rp_data(struct gsm_network *net,
+   struct vlr_subscr *vsub, uint8_t *mms_ind,
size_t sm_rp_oa_len, const uint8_t *sm_rp_oa,
size_t sm_rp_ud_len, const uint8_t *sm_rp_ud);

diff --git a/include/osmocom/msc/ran_conn.h b/include/osmocom/msc/ran_conn.h
index d71872e..5975a59 100644
--- a/include/osmocom/msc/ran_conn.h
+++ b/include/osmocom/msc/ran_conn.h
@@ -220,6 +220,7 @@
RAN_CONN_USE_TRANS_SMS,
RAN_CONN_USE_TRANS_NC_SS,
RAN_CONN_USE_SILENT_CALL,
+   RAN_CONN_USE_MT_SMS_MMTS,
RAN_CONN_USE_RELEASE,
 };

diff --git a/include/osmocom/msc/transaction.h 
b/include/osmocom/msc/transaction.h
index 0760c07..a987b1c 100644
--- a/include/osmocom/msc/transaction.h
+++ b/include/osmocom/msc/transaction.h
@@ -78,6 +78,9 @@

/* SM-RP-MR, Message Reference (see GSM TS 04.11, 
section 8.2.3) */
uint8_t sm_rp_mr;
+   /* SM-RP-MMS, More Messages to Send
+* (see GSM 3GPP TS 29.002, section 7.6.8.7) */
+   bool sm_rp_mms;

struct gsm_sms *sms;
} sms;
diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 01f1cb5..c77c4ec 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -1133,7 +1133,8 @@
 }

 /* Low-level function to send raw RP-DATA to a given subscriber */
-int gsm411_send_rp_data(struct gsm_network *net, struct vlr_subscr *vsub,
+int gsm411_send_rp_data(struct gsm_network *net,
+   struct vlr_subscr *vsub, uint8_t *mms_ind,
size_t sm_rp_oa_len, const uint8_t *sm_rp_oa,
size_t sm_rp_ud_len, const uint8_t *sm_rp_ud)
 {
@@ -1146,6 +1147,10 @@
if (!trans)
return -ENOMEM;

+   /* Handle MMS indication */
+   if (mms_ind != NULL && *mms_ind != 0x00)
+   trans->sms.sm_rp_mms = true;
+
/* Allocate a message buffer for to be encoded SMS */
msg = gsm411_msgb_alloc();
if (!msg) {
@@ -1277,6 +1282,17 @@
trans->sms.smc_inst.mn_recv = NULL;
trans->sms.smc_inst.mm_send = NULL;

+   /* HACK: handle SM-RP-MMS (More Messages to Send) */
+   if (trans->conn != NULL) {
+   if (trans->sms.sm_rp_mms) {
+   if (!ran_conn_used_by(trans->conn, 
RAN_CONN_USE_MT_SMS_MMTS))
+   ran_conn_get(trans->conn, 
RAN_CONN_USE_MT_SMS_MMTS);
+   } else {
+   if (ran_conn_used_by(trans->conn, 
RAN_CONN_USE_MT_SMS_MMTS))
+   ran_conn_put(trans->conn, 
RAN_CONN_USE_MT_SMS_MMTS);
+   }
+   }
+
if (trans->sms.sms) {
LOGP(DLSMS, LOGL_ERROR, "Transaction contains SMS.\n");
send_signal(S_SMS_UNKNOWN_ERROR, trans, trans->sms.sms, 0);
diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 9b15961..2aedbf4 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -280,7 +280,7 @@
goto msg_error;

/* Send RP-DATA */
-   rc = gsm411_send_rp_data(net, vsub,
+   rc = gsm411_send_rp_data(net, vsub, gsup_msg->sm_rp_mms,
gsup_msg->sm_rp_oa_len, gsup_msg->sm_rp_oa,
gsup_msg->sm_rp_ui_len, gsup_msg->sm_rp_ui);
if (rc) {
diff --git a/src/libmsc/osmo_msc.c b/src/libmsc/osmo_msc.c
index 52277b7..a996e14 100644
--- a/src/libmsc/osmo_msc.c
+++ b/src/libmsc/osmo_msc.c
@@ -316,6 +316,7 @@
{RAN_CONN_USE_TRANS_SMS,

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mt_sms for MT SMS over GSUP

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/11777 )

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms for MT SMS over GSUP
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11777
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic93105e8f9d230ac7c1991395e719c461b3cd8ab
Gerrit-Change-Number: 11777
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11751 )

Change subject: GSUP/SMS: introduce READY-FOR-SM message
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11751
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37f3b2114b8095cfce22977e67133b9103942e3
Gerrit-Change-Number: 11751
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 02 Dec 2018 22:21:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11069 )

Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11069
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71
Gerrit-Change-Number: 11069
Gerrit-PatchSet: 10
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 02 Dec 2018 22:21:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11776 )

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11776
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7abc95b8e416f7308d54e11be11c08586d18e6c5
Gerrit-Change-Number: 11776
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 02 Dec 2018 22:11:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler.ttcn: split up f_mo_sms() into two functions

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11717 )

Change subject: BSC_ConnectionHandler.ttcn: split up f_mo_sms() into two 
functions
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11717
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b35206286ae8add8b5bd34b0ab41ba7862c28e4
Gerrit-Change-Number: 11717
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 02 Dec 2018 22:11:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mo_sms for MO SMS over GSUP

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11718 )

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mo_sms for MO SMS over GSUP
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id14bbd8bd51558cdacefea0fe042769cd69ed5c8
Gerrit-Change-Number: 11718
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 02 Dec 2018 22:11:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: add READY-FOR-SM message

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11752 )

Change subject: library/GSUP_Types.ttcn: add READY-FOR-SM message
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11752
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2256607527ecfcb10285583332fb8b0515d7c78
Gerrit-Change-Number: 11752
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 02 Dec 2018 22:11:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}

2018-12-02 Thread Vadim Yanitskiy

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11924

to look at the new patch set (#4).

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}
..

MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}

The idea of this test case is to verify MT SMS transmission
initiated by ESME over GSUP. Basically, the algorythm is
the following:

  1.0 send MT-ForwardSM-Req on GSUP,
  1.1 expect Paging Request on RAN,
  1.2 establish a RAN connection,
  1.3 expect CP-DATA/RP-DATA on BSSAP/DTAP,
  2.1 send CP-DATA/RP-ACK on BSSAP/DTAP,
  2.2.a expect MT-ForwardSM-Res,
  2.2.b expect MT-ForwardSM-Err.

Change-Id: I63a25c8366cce0852df6b628365151661a22a25f
Related: OS#3587
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 149 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/24/11924/4
--
To view, visit https://gerrit.osmocom.org/11924
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I63a25c8366cce0852df6b628365151661a22a25f
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Holger Freyther

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms

2018-12-02 Thread Vadim Yanitskiy

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12058

to look at the new patch set (#2).

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms
..

MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms

The idea of this test case is to verify the process of multi-part
MT SMS transmission. The MSC should keep the RAN connection until
the last message part is transmitted.

Change-Id: I6308586a70c4fb3254c519330a61a9667372149f
Related: OS#3587
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 73 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/58/12058/2
--
To view, visit https://gerrit.osmocom.org/12058
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6308586a70c4fb3254c519330a61a9667372149f
Gerrit-Change-Number: 12058
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}

2018-12-02 Thread Vadim Yanitskiy

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11924

to look at the new patch set (#3).

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}
..

MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}

The idea of this test case is to verify MT SMS transmission
initiated by ESME over GSUP. Basically, the algorythm is
the following:

  1.0 send MT-ForwardSM-Req on GSUP,
  1.1 expect Paging Request on RAN,
  1.2 establish a RAN connection,
  1.3 expect CP-DATA/RP-DATA on BSSAP/DTAP,
  2.1 send CP-DATA/RP-ACK on BSSAP/DTAP,
  2.2.a expect MT-ForwardSM-Res
  2.2.b expect MT-ForwardSM-Err

Change-Id: I63a25c8366cce0852df6b628365151661a22a25f
Related: OS#3587
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 149 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/24/11924/3
--
To view, visit https://gerrit.osmocom.org/11924
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I63a25c8366cce0852df6b628365151661a22a25f
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Holger Freyther

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12058


Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms
..

MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms

The idea of this test case is to verify the process of multi-part
MT SMS transmission. The MSC should keep the RAN connection until
the last message part is transmitted.

Change-Id: I6308586a70c4fb3254c519330a61a9667372149f
Related: OS#3587
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 73 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/58/12058/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 3364e64..8a29696 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2291,6 +2291,77 @@
f_vty_config(MSCVTY, "msc", "no sms-over-gsup");
 }

+/* Test multi-part MT-SMS over GSUP */
+private function f_tc_gsup_mt_multi_part_sms(charstring id, BSC_ConnHdlrPars 
pars)
+runs on BSC_ConnHdlr {
+   var SmsParameters spars := valueof(t_SmsPars);
+
+   f_init_handler(pars);
+
+   /* We need to inspect GSUP activity */
+   f_create_gsup_expect(hex2str(g_pars.imsi));
+
+   /* Perform location update */
+   f_perform_lu();
+
+   /* Register an 'expect' for given IMSI (+TMSI) */
+   if (isvalue(g_pars.tmsi)) {
+   f_bssmap_register_imsi(g_pars.imsi, g_pars.tmsi);
+   } else {
+   f_bssmap_register_imsi(g_pars.imsi, ''O);
+   }
+
+   var template GSUP_PDU mt_forwardSM_res := tr_GSUP_MT_FORWARD_SM_RES(
+   imsi := g_pars.imsi,
+   /* NOTE: MSC should assign RP-MR itself */
+   sm_rp_mr := ?
+   );
+
+   /* Send 4 messages (NOTE: SM-RP-UI remains unchanged) */
+   for (var integer i := 3; i >= 0; i := i-1) {
+   /* Submit a MT SMS on GSUP (MMS is decremented) */
+   f_gsup_forwardSM_req(spars, int2oct(i, 1));
+
+   /* Expect Paging Request and Establish connection */
+   if (i == 3) { /* ... only once! */
+   BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi));
+   f_establish_fully(EST_TYPE_PAG_RESP);
+   }
+
+   /* Wait for MT SMS on DTAP */
+   f_mt_sms_expect(spars);
+
+   /* Send RP-ACK and expect MT-forwardSM-Res on GSUP */
+   f_mt_sms_send_rp_ack(spars);
+   alt {
+   [] GSUP.receive(mt_forwardSM_res) {
+   log("RX MT-forwardSM-Res (RP-ACK)");
+   setverdict(pass);
+   }
+   [] GSUP.receive {
+   log("RX unexpected GSUP message");
+   setverdict(fail);
+   mtc.stop;
+   }
+   }
+
+   /* Keep some 'distance' between transmissions */
+   f_sleep(1.5);
+   }
+
+   f_expect_clear();
+}
+testcase TC_gsup_mt_multi_part_sms() runs on MTC_CT {
+   var BSC_ConnHdlrPars pars;
+   var BSC_ConnHdlr vc_conn;
+   f_init();
+   pars := f_init_pars(91);
+   f_vty_config(MSCVTY, "msc", "sms-over-gsup");
+   vc_conn := 
f_start_handler_with_pars(refers(f_tc_gsup_mt_multi_part_sms), pars);
+   vc_conn.done;
+   f_vty_config(MSCVTY, "msc", "no sms-over-gsup");
+}
+
 /* convert GSM L3 TON to SMPP_TON enum */
 function f_sm_ton_from_gsm(BIT3 ton) return SMPP_TON {
select (ton) {
@@ -3122,6 +3193,7 @@
execute( TC_gsup_mo_smma() );
execute( TC_gsup_mt_sms_ack() );
execute( TC_gsup_mt_sms_err() );
+   execute( TC_gsup_mt_multi_part_sms() );

execute( TC_lu_and_mo_ussd_single_request() );
execute( TC_lu_and_mt_ussd_notification() );
diff --git a/msc/expected-results.xml b/msc/expected-results.xml
index 710d6d4..a4a3322 100644
--- a/msc/expected-results.xml
+++ b/msc/expected-results.xml
@@ -67,6 +67,7 @@
   
   
   
+  
   
   
   

--
To view, visit https://gerrit.osmocom.org/12058
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6308586a70c4fb3254c519330a61a9667372149f
Gerrit-Change-Number: 12058
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-trx[master]: UHDDevice: log exception information on device open failure

2018-12-02 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12052 )

Change subject: UHDDevice: log exception information on device open failure
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia84ddcf50cc83f9326b22bfdfb4f259b4e0bc5f1
Gerrit-Change-Number: 12052
Gerrit-PatchSet: 3
Gerrit-Owner: d0gtail 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: d0gtail 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 02 Dec 2018 20:01:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: UHDDevice: log exception information on device open failure

2018-12-02 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12052 )

Change subject: UHDDevice: log exception information on device open failure
..

UHDDevice: log exception information on device open failure

Change-Id: Ia84ddcf50cc83f9326b22bfdfb4f259b4e0bc5f1
---
M Transceiver52M/device/uhd/UHDDevice.cpp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp 
b/Transceiver52M/device/uhd/UHDDevice.cpp
index 3db09a8..765150f 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -635,8 +635,8 @@
LOGC(DDEV, INFO) << "Using discovered UHD device " << 
dev_addrs[0].to_string();
try {
usrp_dev = uhd::usrp::multi_usrp::make(addr);
-   } catch(...) {
-   LOGC(DDEV, ALERT) << "UHD make failed, device " << args;
+   } catch(uhd::key_error::exception ) {
+   LOGC(DDEV, ALERT) << "UHD make failed, device " << args << ", 
exception:\n" << e.what();
return -1;
}


--
To view, visit https://gerrit.osmocom.org/12052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia84ddcf50cc83f9326b22bfdfb4f259b4e0bc5f1
Gerrit-Change-Number: 12052
Gerrit-PatchSet: 4
Gerrit-Owner: d0gtail 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: d0gtail 
Gerrit-CC: Vadim Yanitskiy

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: add MO-/MT-FORWARD-SM messages

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11062 )

Change subject: library/GSUP_Types.ttcn: add MO-/MT-FORWARD-SM messages
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11062
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf49474a81235096c032ea21f217170f523bd94e
Gerrit-Change-Number: 11062
Gerrit-PatchSet: 11
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 02 Dec 2018 19:51:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: add MO-/MT-FORWARD-SM messages

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11062 )

Change subject: library/GSUP_Types.ttcn: add MO-/MT-FORWARD-SM messages
..

library/GSUP_Types.ttcn: add MO-/MT-FORWARD-SM messages

According to 3GPP TS 29.002, there are two services:

 - MAP-MO-FORWARD-SHORT-MESSAGE (see 12.2),
 - MAP-MT-FORWARD-SHORT-MESSAGE (see 12.9),

which are used to forward MO/MT short messages.

This change replicates both services as GSUP messages:

 - OSMO_GSUP_MSGT_MO_FORWARD_SM_*,
 - OSMO_GSUP_MSGT_MT_FORWARD_SM_*.

Please note, that only the 'must-have' IEs are introduced
by this change, in particular the following:

 - OSMO_GSUP_SM_RP_MR_IE (see note below),
 - OSMO_GSUP_SM_RP_DA_IE (see 7.6.8.1),
 - OSMO_GSUP_SM_RP_OA_IE (see 7.6.8.2),
 - OSMO_GSUP_SM_RP_UI_IE (see 7.6.8.4),
 - OSMO_GSUP_SM_RP_MMS_IE (see 7.6.8.7),
 - OSMO_GSUP_SM_RP_CAUSE_IE (see GSM TS 04.11, 8.2.5.4),

where both SM_RP_DA and SM_RP_OA IEs basically contain
a single nested TLV of the following format:

 - T: identity type (see 'GSUP_SM_RP_ODA_IdType'),
 - L: identity length,
 - V: encoded identity itself.

According to GSM TS 04.11, every single message on the SM-RL has
an unique message reference (see 8.2.3), that is used to link
an RP-ACK or RP-ERROR message to the associated (preceding)
RP-DATA or RP-SMMA message transfer attempt.

In case of TCAP/MAP, this message reference is being mapped to the
Invoke ID. But since GSUP has no 'Invoke ID' IE, and it is not
required for other applications (other than SMS), this change
introduces a special 'SM_RP_MR' IE that doesn't exist in MAP.

Change-Id: Ibf49474a81235096c032ea21f217170f523bd94e
Related: OS#3587
---
M library/GSUP_Types.ttcn
1 file changed, 433 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 6329ebd..9cb3255 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -43,7 +43,15 @@

OSMO_GSUP_SESSION_ID_IE ('30'O),
OSMO_GSUP_SESSION_STATE_IE  ('31'O),
-   OSMO_GSUP_SS_INFO_IE('35'O)
+   OSMO_GSUP_SS_INFO_IE('35'O),
+
+   /* SM related IEs (see 3GPP TS 29.002, section 7.6.8) */
+   OSMO_GSUP_SM_RP_MR_IE   ('40'O),
+   OSMO_GSUP_SM_RP_DA_IE   ('41'O),
+   OSMO_GSUP_SM_RP_OA_IE   ('42'O),
+   OSMO_GSUP_SM_RP_UI_IE   ('43'O),
+   OSMO_GSUP_SM_RP_CAUSE_IE('44'O),
+   OSMO_GSUP_SM_RP_MMS_IE  ('45'O)
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_MessageType {
@@ -75,7 +83,15 @@

OSMO_GSUP_MSGT_PROC_SS_REQUEST  ('0010'B),
OSMO_GSUP_MSGT_PROC_SS_ERROR('0011'B),
-   OSMO_GSUP_MSGT_PROC_SS_RESULT   ('00100010'B)
+   OSMO_GSUP_MSGT_PROC_SS_RESULT   ('00100010'B),
+
+   OSMO_GSUP_MSGT_MO_FORWARD_SM_REQUEST('00100100'B),
+   OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR  ('00100101'B),
+   OSMO_GSUP_MSGT_MO_FORWARD_SM_RESULT ('00100110'B),
+
+   OSMO_GSUP_MSGT_MT_FORWARD_SM_REQUEST('00101000'B),
+   OSMO_GSUP_MSGT_MT_FORWARD_SM_ERROR  ('00101001'B),
+   OSMO_GSUP_MSGT_MT_FORWARD_SM_RESULT ('00101010'B)
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_CancelType {
@@ -128,6 +144,12 @@
 session_state, tag = 
OSMO_GSUP_SESSION_STATE_IE;
 session_id, tag = OSMO_GSUP_SESSION_ID_IE;
 ss_info, tag = OSMO_GSUP_SS_INFO_IE;
+sm_rp_mr, tag = OSMO_GSUP_SM_RP_MR_IE;
+sm_rp_da, tag = OSMO_GSUP_SM_RP_DA_IE;
+sm_rp_oa, tag = OSMO_GSUP_SM_RP_OA_IE;
+sm_rp_ui, tag = OSMO_GSUP_SM_RP_UI_IE;
+sm_rp_cause, tag = OSMO_GSUP_SM_RP_CAUSE_IE;
+sm_rp_mms, tag = OSMO_GSUP_SM_RP_MMS_IE;
)"
 };

@@ -161,7 +183,14 @@
GSUP_SessionState   session_state,
OCT4session_id,
/* Supplementary Services */
-   octetstring ss_info
+   octetstring ss_info,
+   /* Short Message Service */
+   OCT1sm_rp_mr,
+   GSUP_SM_RP_DA   sm_rp_da,
+   GSUP_SM_RP_OA   sm_rp_oa,
+   octetstring sm_rp_ui,
+   OCT1sm_rp_cause,
+   OCT1sm_rp_mms
 };

 type record GSUP_PDU {
@@ -593,6 +622,235 @@
}
 }

+template (value) GSUP_IE ts_GSUP_IE_SM_RP_MR(OCT1 ref) := {
+   tag := OSMO_GSUP_SM_RP_MR_IE,
+   len := 0, /* overwritten */
+   val := {
+   sm_rp_mr := ref
+   }
+}
+template GSUP_IE tr_GSUP_IE_SM_RP_MR(template

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: correct VTY command in TC_lu_and_ss_session_timeout

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12057


Change subject: MSC_Tests.ttcn: correct VTY command in 
TC_lu_and_ss_session_timeout
..

MSC_Tests.ttcn: correct VTY command in TC_lu_and_ss_session_timeout

Change-Id: Icd1133ca9f46bc2a9302deebb1e401862cf672cb
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/57/12057/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index a0ace4e..4adc1a3 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2760,10 +2760,10 @@
 testcase TC_lu_and_ss_session_timeout() runs on MTC_CT {
var BSC_ConnHdlr vc_conn;
f_init();
-   f_vty_config(MSCVTY, "msc", "ss-guard-timeout 3");
+   f_vty_config(MSCVTY, "msc", "ncss-guard-timeout 3");
vc_conn := f_start_handler(refers(f_tc_lu_and_ss_session_timeout), 51);
vc_conn.done;
-   f_vty_config(MSCVTY, "msc", "ss-guard-timeout 0");
+   f_vty_config(MSCVTY, "msc", "ncss-guard-timeout 0");
 }

 /* TODO (SMS):

--
To view, visit https://gerrit.osmocom.org/12057
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1133ca9f46bc2a9302deebb1e401862cf672cb
Gerrit-Change-Number: 12057
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-msc[master]: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11991 )

Change subject: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11991
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89727354385b40e18732e8fd1d6c93f4463ade37
Gerrit-Change-Number: 11991
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 02 Dec 2018 19:42:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 02 Dec 2018 19:42:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-hlr[master]: SS/USSD: fix: properly (re)schedule NCSS session timeout

2018-12-02 Thread Vadim Yanitskiy

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12049

to look at the new patch set (#2).

Change subject: SS/USSD: fix: properly (re)schedule NCSS session timeout
..

SS/USSD: fix: properly (re)schedule NCSS session timeout

It may happen that either the MS or an ESME would become
unresponsive, e.g. due to a bug, or a dropped message. This
is why we have SS session timeout, that prevents keeping
'stalled' sessions forever.

For some reason, it wasn't properly resceduled in case of
subsequent SS/USSD activity, so the lifetime of a session
was limited. Let's properly (re)schedule it.

Change-Id: I11aeacf012b06d3d0b5cc6e64baecf857b645fda
Related: OS#3717
---
M src/hlr_ussd.c
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/49/12049/2
--
To view, visit https://gerrit.osmocom.org/12049
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11aeacf012b06d3d0b5cc6e64baecf857b645fda
Gerrit-Change-Number: 12049
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-hlr[master]: SS/USSD: make NCSS session timeout configurable

2018-12-02 Thread Vadim Yanitskiy

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12048

to look at the new patch set (#2).

Change subject: SS/USSD: make NCSS session timeout configurable
..

SS/USSD: make NCSS session timeout configurable

It may happen that either the MS or an ESME would become
unresponsive, e.g. due to a bug, or a dropped message.
This is why we have SS session timeout, that prevents
keeping 'stalled' sessions forever.

Let's introduce a VTY option, which can be used to configure
this timer (by default it's set to 30 seconds):

hlr
  ...
  ! Use 0 to disable this timer
  ncss-guard-timeout 30

Change-Id: I971fc2cee6fd46d4d5d6dac6c634e0b22fff183d
Related: OS#3717
---
M src/hlr.c
M src/hlr.h
M src/hlr_ussd.c
M src/hlr_ussd.h
M src/hlr_vty.c
M tests/test_nodes.vty
6 files changed, 29 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/48/12048/2
--
To view, visit https://gerrit.osmocom.org/12048
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I971fc2cee6fd46d4d5d6dac6c634e0b22fff183d
Gerrit-Change-Number: 12048
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-hlr[master]: add 'show subscriber' command, alias for 'subscriber ... show'

2018-12-02 Thread Neels Hofmeyr

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12055

to look at the new patch set (#2).

Change subject: add 'show subscriber' command, alias for 'subscriber ... show'
..

add 'show subscriber' command, alias for 'subscriber ... show'

When I wrote the osmo-hlr subscriber command, I failed to heed the common
'show foo' scheme and instead created a 'subscriber [...] show' command.
Relieve that weirdness by creating an alias that has 'show' at the start.

Arrange string macros so that the 'show subscriber' cmd doesn't end in a space
(the SUBSCR macro ends in a space ' ' to implicitly include the space to
commands like 'create', 'show', 'update').

Add the new command to test_nodes.vty and test_subscriber.vty.

Change-Id: I01ce9b0868302d40ed05c6a588316a194d6071e4
---
M src/hlr_vty_subscr.c
M tests/test_nodes.vty
M tests/test_subscriber.vty
3 files changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/55/12055/2
--
To view, visit https://gerrit.osmocom.org/12055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01ce9b0868302d40ed05c6a588316a194d6071e4
Gerrit-Change-Number: 12055
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-hlr[master]: implement removal of MSISDN

2018-12-02 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12056


Change subject: implement removal of MSISDN
..

implement removal of MSISDN

Add the first "official" way to remove the MSISDN from a subscriber entry, to
go back to 'MSISDN: none' like just after 'subscriber create'.

Add VTY command 'subscriber  update msisdn none' to drop the MSISDN from
the subscriber. (Like 'subscriber  update aud3g none')

Add DB_STMT_DELETE_MSISDN_BY_IMSI.

In db_subscr_update_msisdn_by_imsi(), allow passing a NULL msisdn, and if NULL,
call above delete SQL statement.

Change-Id: I15419105ea461137776adb92d384d8985210c90e
---
M src/db.c
M src/db.h
M src/db_hlr.c
M src/hlr_vty_subscr.c
M tests/test_subscriber.vty
5 files changed, 56 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/56/12056/1

diff --git a/src/db.c b/src/db.c
index 4b0577f..bcf83c6 100644
--- a/src/db.c
+++ b/src/db.c
@@ -62,6 +62,7 @@
[DB_STMT_SUBSCR_CREATE] = "INSERT INTO subscriber (imsi) VALUES 
($imsi)",
[DB_STMT_DEL_BY_ID] = "DELETE FROM subscriber WHERE id = 
$subscriber_id",
[DB_STMT_SET_MSISDN_BY_IMSI] = "UPDATE subscriber SET msisdn = $msisdn 
WHERE imsi = $imsi",
+   [DB_STMT_DELETE_MSISDN_BY_IMSI] = "UPDATE subscriber SET msisdn = NULL 
WHERE imsi = $imsi",
[DB_STMT_AUC_2G_INSERT] =
"INSERT INTO auc_2g (subscriber_id, algo_id_2g, ki)"
" VALUES($subscriber_id, $algo_id_2g, $ki)",
diff --git a/src/db.h b/src/db.h
index 956b5ed..34582c8 100644
--- a/src/db.h
+++ b/src/db.h
@@ -20,6 +20,7 @@
DB_STMT_SUBSCR_CREATE,
DB_STMT_DEL_BY_ID,
DB_STMT_SET_MSISDN_BY_IMSI,
+   DB_STMT_DELETE_MSISDN_BY_IMSI,
DB_STMT_AUC_2G_INSERT,
DB_STMT_AUC_2G_DELETE,
DB_STMT_AUC_3G_INSERT,
diff --git a/src/db_hlr.c b/src/db_hlr.c
index c4d4974..2bccc38 100644
--- a/src/db_hlr.c
+++ b/src/db_hlr.c
@@ -135,7 +135,7 @@

 /*! Set a subscriber's MSISDN in the HLR database.
  * \param[in,out] dbc  database context.
- * \param[in] imsi  ASCII string of IMSI digits.
+ * \param[in] imsi  ASCII string of IMSI digits, or NULL to remove the MSISDN.
  * \param[in] msisdn  ASCII string of MSISDN digits.
  * \returns 0 on success, -EINVAL in case of invalid MSISDN string, -EIO on
  *  database failure, -ENOENT if no such subscriber exists.
@@ -146,19 +146,22 @@
int rc;
int ret = 0;

-   if (!osmo_msisdn_str_valid(msisdn)) {
+   if (msisdn && !osmo_msisdn_str_valid(msisdn)) {
LOGHLR(imsi, LOGL_ERROR,
   "Cannot update subscriber: invalid MSISDN: '%s'\n",
   msisdn);
return -EINVAL;
}

-   sqlite3_stmt *stmt = dbc->stmt[DB_STMT_SET_MSISDN_BY_IMSI];
+   sqlite3_stmt *stmt = dbc->stmt[
+   msisdn ? DB_STMT_SET_MSISDN_BY_IMSI : 
DB_STMT_DELETE_MSISDN_BY_IMSI];

if (!db_bind_text(stmt, "$imsi", imsi))
return -EIO;
-   if (!db_bind_text(stmt, "$msisdn", msisdn))
-   return -EIO;
+   if (msisdn) {
+   if (!db_bind_text(stmt, "$msisdn", msisdn))
+   return -EIO;
+   }

/* execute the statement */
rc = sqlite3_step(stmt);
diff --git a/src/hlr_vty_subscr.c b/src/hlr_vty_subscr.c
index ddbaf26..bc6f6a5 100644
--- a/src/hlr_vty_subscr.c
+++ b/src/hlr_vty_subscr.c
@@ -142,6 +142,7 @@

 #define SUBSCR_UPDATE  SUBSCR "update "
 #define SUBSCR_UPDATE_HELP SUBSCR_HELP "Set or update subscriber data\n"
+#define SUBSCR_MSISDN_HELP "Set MSISDN (phone number) of the subscriber\n"

 DEFUN(subscriber_show,
   subscriber_show_cmd,
@@ -228,9 +229,9 @@

 DEFUN(subscriber_msisdn,
   subscriber_msisdn_cmd,
-  SUBSCR_UPDATE "msisdn MSISDN",
-  SUBSCR_UPDATE_HELP
-  "Set MSISDN (phone number) of the subscriber\n"
+  SUBSCR_UPDATE "msisdn (none|MSISDN)",
+  SUBSCR_UPDATE_HELP SUBSCR_MSISDN_HELP
+  "Remove MSISDN (phone number)\n"
   "New MSISDN (phone number)\n")
 {
struct hlr_subscriber subscr;
@@ -238,15 +239,19 @@
const char *id = argv[1];
const char *msisdn = argv[2];

-   if (strlen(msisdn) > sizeof(subscr.msisdn) - 1) {
-   vty_out(vty, "%% MSISDN is too long, max. %zu characters are 
allowed%s",
-   sizeof(subscr.msisdn)-1, VTY_NEWLINE);
-   return CMD_WARNING;
-   }
+   if (strcmp(msisdn, "none") == 0)
+   msisdn = NULL;
+   else {
+   if (strlen(msisdn) > sizeof(subscr.msisdn) - 1) {
+   vty_out(vty, "%% MSISDN is too long, max. %zu 
characters are allowed%s",
+   sizeof(subscr.msisdn)-1, VTY_NEWLINE);
+   return CMD_WARNING;
+   }

-   if (!osmo_msisdn_str_valid(msisdn)) {
-

Change in osmo-hlr[master]: add 'show subscriber' command, alias for 'subscriber ... show'

2018-12-02 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12055


Change subject: add 'show subscriber' command, alias for 'subscriber ... show'
..

add 'show subscriber' command, alias for 'subscriber ... show'

When I wrote the osmo-hlr subscriber command, I failed to heed the common
'show foo' scheme and instead created a 'subscriber [...] show' command.
Relieve that weirdness by creating an alias that has 'show' at the start.

Change-Id: I01ce9b0868302d40ed05c6a588316a194d6071e4
---
M src/hlr_vty_subscr.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/55/12055/1

diff --git a/src/hlr_vty_subscr.c b/src/hlr_vty_subscr.c
index 6ce96fe..f0cf8ba 100644
--- a/src/hlr_vty_subscr.c
+++ b/src/hlr_vty_subscr.c
@@ -159,6 +159,10 @@
return CMD_SUCCESS;
 }

+ALIAS(subscriber_show, show_subscriber_cmd,
+  "show " SUBSCR,
+  SHOW_STR SUBSCR_HELP);
+
 DEFUN(subscriber_create,
   subscriber_create_cmd,
   SUBSCR_CMD "imsi IDENT create",
@@ -478,6 +482,7 @@
 void hlr_vty_subscriber_init(void)
 {
install_element_ve(_show_cmd);
+   install_element_ve(_subscriber_cmd);
install_element(ENABLE_NODE, _create_cmd);
install_element(ENABLE_NODE, _delete_cmd);
install_element(ENABLE_NODE, _msisdn_cmd);

--
To view, visit https://gerrit.osmocom.org/12055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01ce9b0868302d40ed05c6a588316a194d6071e4
Gerrit-Change-Number: 12055
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Jenkins build is back to normal : master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #3314

2018-12-02 Thread jenkins

See

Jenkins build is back to normal : master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #3314

2018-12-02 Thread jenkins

See

Change in osmo-gsm-tester[master]: Fix and use the right member variable

2018-12-02 Thread Holger Freyther

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/12054


Change subject: Fix and use the right member variable
..

Fix and use the right member variable

Change-Id: Ib5d50322ecd30c7724eef8452d22845450e9c633
---
M src/osmo_gsm_tester/ms_driver.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/54/12054/1

diff --git a/src/osmo_gsm_tester/ms_driver.py b/src/osmo_gsm_tester/ms_driver.py
index 634370f..b29859b 100644
--- a/src/osmo_gsm_tester/ms_driver.py
+++ b/src/osmo_gsm_tester/ms_driver.py
@@ -82,7 +82,7 @@
 """

 # Get the base directory for the virtphy/mobile application
-inst = 
util.Dir(os.path.abspath(self.suite_run.trial.get_inst('osmocom-bb')))
+inst = 
util.Dir(os.path.abspath(self._suite_run.trial.get_inst('osmocom-bb')))

 # Assume these are dynamically linked and verify there is a lib dir.
 lib = inst.child('lib')
@@ -113,7 +113,7 @@
 options = self.build_binary_options()
 self._test_case = MassUpdateLocationTest("mass", options, 
self._num_ms, self._cdf,
  self._ev_server,
- 
util.Dir(self.suite_run.get_test_run_dir()),
+ 
util.Dir(self._suite_run.get_test_run_dir()),
  suite_run=self._suite_run)

 # TODO: We should pass subscribers down to the test and not get it from

--
To view, visit https://gerrit.osmocom.org/12054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5d50322ecd30c7724eef8452d22845450e9c633
Gerrit-Change-Number: 12054
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther

Jenkins build is back to normal : master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #325

2018-12-02 Thread jenkins

See

Change in osmo-bsc[master]: osmo_bsc_bssap.c: fix incorrect link_id assignment

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12053 )

Change subject: osmo_bsc_bssap.c: fix incorrect link_id assignment
..


Patch Set 1:

> nice catch! I know we're all busy, but a TTCN3 test to ensure the
 > use of SACCH might be nice :)

To be honest, I have been trying to write a test case for that,
before and after fixing this issue. The problem is that I'am not
familiar (yet) with the BSC's testing infrastructure, so I've
spent a few hours learning/reading/trying and finally gave up :/

I will reopen the issue and try again some day ;)


--
To view, visit https://gerrit.osmocom.org/12053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7675e1ce4436fad836778261ac9d446fa8f81483
Gerrit-Change-Number: 12053
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 02 Dec 2018 09:49:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err} for MT SMS over GSUP

2018-12-02 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11924 )

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err} for MT SMS 
over GSUP
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11924/2/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11924/2/msc/MSC_Tests.ttcn@2149
PS2, Line 2149: FIXME
> Add info about what it should represent?
Well, the template definition already has a comment with the
spec. reference. I can clarify this comment anyway:

  /* FIXME: encoded SMS TPDU was taken from Wireshark */



--
To view, visit https://gerrit.osmocom.org/11924
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63a25c8366cce0852df6b628365151661a22a25f
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Holger Freyther 
Gerrit-Comment-Date: Sun, 02 Dec 2018 09:44:07 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: cosmetic: gerrit-verifications: format docker cmd

2018-12-02 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12047 )

Change subject: cosmetic: gerrit-verifications: format docker cmd
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0adcb028be24c2e05189c15b85811777d6287387
Gerrit-Change-Number: 12047
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Sun, 02 Dec 2018 09:39:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: cosmetic: gerrit-verifications: format docker cmd

2018-12-02 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12047 )

Change subject: cosmetic: gerrit-verifications: format docker cmd
..

cosmetic: gerrit-verifications: format docker cmd

Format the docker command lines just like they are formatted in
master-builds.yml. Most notably, this puts every environment variable on
its own line. This makes it much easier to compare both files side by
side.

Change-Id: I0adcb028be24c2e05189c15b85811777d6287387
---
M jobs/gerrit-verifications.yml
1 file changed, 61 insertions(+), 22 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Harald Welte: Looks good to me, approved; Verified



diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 71a0904..e70d28e 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -32,9 +32,14 @@
   concurrent: true
   cmd: >
# keep first line with less indent to preserve newlines
-docker run --rm=true -e HOME=/build -e MAKE=make -e 
PARALLEL_MAKE="$PARALLEL_MAKE" \
-  -e PATH="$PATH:/build_bin" -w /build \
-  -i -u build -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
+docker run --rm=true \
+  -e HOME=/build \
+  -e MAKE=make \
+  -e PARALLEL_MAKE="$PARALLEL_MAKE" \
+  -e PATH="$PATH:/build_bin" \
+  -w /build -i -u build \
+  -v "$PWD:/build" \
+  -v "$HOME/bin:/build_bin" \
   osmocom:amd64 /build/contrib/jenkins.sh

   - libasn1c
@@ -64,11 +69,21 @@
# keep first line with less indent to preserve newlines
 ARTIFACT_STORE="$HOME/jenkins_build_artifact_store"
 mkdir -p "$ARTIFACT_STORE"
-docker run --rm=true -e HOME=/build -e 
ARTIFACT_STORE=/artifact_store \
-  -e JOB_NAME="$JOB_NAME" -e MAKE=make -e 
PARALLEL_MAKE="$PARALLEL_MAKE" \
-  -e IU="$IU" -e SMPP="$SMPP" -e MGCP="$MGCP" -e 
PATH="$PATH:/build_bin" \
-  -e OSMOPY_DEBUG_TCP_SOCKETS="1" -w /build -i -u build -v 
"$PWD:/build" \
-  -v "$HOME/bin:/build_bin" -v "$ARTIFACT_STORE:/artifact_store" \
+docker run --rm=true \
+  -e HOME=/build \
+  -e ARTIFACT_STORE=/artifact_store \
+  -e JOB_NAME="$JOB_NAME" \
+  -e MAKE=make \
+  -e PARALLEL_MAKE="$PARALLEL_MAKE" \
+  -e IU="$IU" \
+  -e SMPP="$SMPP" \
+  -e MGCP="$MGCP" \
+  -e PATH="$PATH:/build_bin" \
+  -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+  -w /build -i -u build \
+  -v "$PWD:/build" \
+  -v "$HOME/bin:/build_bin" \
+  -v "$ARTIFACT_STORE:/artifact_store" \
   osmocom:amd64 /build/contrib/jenkins.sh

   - openggsn:
@@ -80,10 +95,15 @@
   concurrent: true
   cmd: >
# keep first line with less indent to preserve newlines
-docker run --rm=true -e HOME=/build -e MAKE=make -e 
PARALLEL_MAKE="$PARALLEL_MAKE" \
--e PATH="$PATH:/build_bin" -e OSMOPY_DEBUG_TCP_SOCKETS="1" -w 
/build -i -u build \
--v "$PWD:/build" -v "$HOME/bin:/build_bin" \
-osmocom:amd64 /build/contrib/jenkins.sh
+docker run --rm=true \
+  -e HOME=/build \
+  -e MAKE=make \
+  -e PARALLEL_MAKE="$PARALLEL_MAKE" \
+  -e PATH="$PATH:/build_bin" \
+  -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+  -w /build -i -u build \
+  -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
+  osmocom:amd64 /build/contrib/jenkins.sh

   - osmo-bts:
   a1_name: FIRMWARE_VERSION
@@ -120,9 +140,15 @@
   concurrent: true
   cmd: >
# keep first line with less indent to preserve newlines
-docker run --rm=true -e HOME=/build -e MAKE=make -e 
PARALLEL_MAKE="$PARALLEL_MAKE" \
-  -e MGCP="$MGCP" -e PATH="$PATH:/build_bin" -e 
OSMOPY_DEBUG_TCP_SOCKETS="1" -w /build \
-  -i -u build -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
+docker run --rm=true \
+  -e HOME=/build \
+  -e MAKE=make \
+  -e PARALLEL_MAKE="$PARALLEL_MAKE" \
+  -e MGCP="$MGCP" \
+  -e PATH="$PATH:/build_bin" \
+  -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+  -w /build -i -u build \
+  -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
   osmocom:amd64 /build/contrib/jenkins.sh

   - osmo-msc:
@@ -133,10 +159,17 @@
# keep first line with less indent to preserve newlines
 ARTIFACT_STORE="$HOME/jenkins_build_artifact_store"
 mkdir -p "$ARTIFACT_STORE"
-docker run --rm=true -i -e HOME=/build -e

Change in osmo-hlr[master]: contrib/jenkins.sh: build and publish manuals

2018-12-02 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11976 )

Change subject: contrib/jenkins.sh: build and publish manuals
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a6ab64c7912f30a693ca4f5f474f22d72b8873
Gerrit-Change-Number: 11976
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Sun, 02 Dec 2018 09:38:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: lms: User correct scale factor for transmit samples

2018-12-02 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12006 )

Change subject: lms: User correct scale factor for transmit samples
..

lms: User correct scale factor for transmit samples

Due to (I believe) a copy+paste mistake from the USRP1 code,
we were using only a scale range of up to 9830 when transmitting
samples, rather than the full 16 bit signed integer range up to
32767.

As a result, we were loosing almost two bits (MSBs) of resolution
as well as a lot of transmit power.

This changes the scale factor to 0.707 (1/sqrt(2)).

Please note that the much higher DAC output level means that the analog
gain should be reduced.  The theoretic range of up to 73dB should not
be used, but Lime Microsystems suggest a value of 61..67 dB.  This can
be achieved by using a "osmotrx tx-attenuation" value of 6..12 inside
the osmo-bts-trx configuration file.

Related: OS#3341
Related: OS#3342
Change-Id: I71702feaa11f53e7614a6938a984dd748405474a
---
M Transceiver52M/device/lms/LMSDevice.h
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.h 
b/Transceiver52M/device/lms/LMSDevice.h
index 349efbb..6635c13 100644
--- a/Transceiver52M/device/lms/LMSDevice.h
+++ b/Transceiver52M/device/lms/LMSDevice.h
@@ -28,7 +28,14 @@
 #include 
 #include 

-#define LIMESDR_TX_AMPL  0.3
+/* Definition of LIMESDR_TX_AMPL limits maximum amplitude of I and Q
+ * channels separately. Hence LIMESDR_TX_AMPL value must be 1/sqrt(2) =
+ * 0.7071 to get an amplitude of 1 of the complex signal:
+ * A^2 = I^2 + Q^2
+ * A^2 = (1/sqrt(2))^2 + (1/sqrt(2))^2
+ * A^2 = 1/2 + 1/2
+ * A^2 = 1 */
+#define LIMESDR_TX_AMPL  0.707

 /** A class to handle a LimeSuite supported device */
 class LMSDevice:public RadioDevice {

--
To view, visit https://gerrit.osmocom.org/12006
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I71702feaa11f53e7614a6938a984dd748405474a
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-trx[master]: lms: Set Rx gain to midpoint, as comment suggests.

2018-12-02 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12007 )

Change subject: lms: Set Rx gain to midpoint, as comment suggests.
..

lms: Set Rx gain to midpoint, as comment suggests.

So far, the Rx gain was set to 34 dB, wile the comment stated it
would be set to half-point, which is 73/2=36dB.  Let's adjust the
code to match the comment.

Change-Id: Idc646def53b83faf4e6c011fb595fa436e223b32
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp 
b/Transceiver52M/device/lms/LMSDevice.cpp
index 0a6c4a2..1cda4f9 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -223,7 +223,7 @@

// Set gains to midpoint
setTxGain((minTxGain() + maxTxGain()) / 2, i);
-   setRxGain(34.0, i);
+   setRxGain((minRxGain() + maxRxGain()) / 2, i);

m_lms_stream_rx[i] = {};
m_lms_stream_rx[i].isTx = false;

--
To view, visit https://gerrit.osmocom.org/12007
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc646def53b83faf4e6c011fb595fa436e223b32
Gerrit-Change-Number: 12007
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bsc[master]: osmo_bsc_bssap.c: fix incorrect link_id assignment

2018-12-02 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12053 )

Change subject: osmo_bsc_bssap.c: fix incorrect link_id assignment
..


Patch Set 1: Code-Review+2

nice catch! I know we're all busy, but a TTCN3 test to ensure the use of SACCH 
might be nice :)


--
To view, visit https://gerrit.osmocom.org/12053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7675e1ce4436fad836778261ac9d446fa8f81483
Gerrit-Change-Number: 12053
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Sun, 02 Dec 2018 08:25:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler.ttcn: introduce f_mt_sms_send_rp_error()

2018-12-02 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11923 )

Change subject: BSC_ConnectionHandler.ttcn: introduce f_mt_sms_send_rp_error()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11923
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d67a451335e1c1e1b18237fdda82260c0c969fb
Gerrit-Change-Number: 11923
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 02 Dec 2018 08:07:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler.ttcn: split up f_mt_sms() into two functions

2018-12-02 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11922 )

Change subject: BSC_ConnectionHandler.ttcn: split up f_mt_sms() into two 
functions
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11922
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4730634a9f3352b6f8553ee2fd1d43044f41241e
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 02 Dec 2018 08:05:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

46 matches

Mail list logo