Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11924 )
Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err} for MT SMS
over GSUP
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/11924/2/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/#/c/11924/2/msc/MSC_Tests.ttcn@2149
PS2, Line 2149: FIXME
> Add info about what it should represent?
Well, the template definition already has a comment with the
spec. reference. I can clarify this comment anyway:
/* FIXME: encoded SMS TPDU was taken from Wireshark */
--
To view, visit https://gerrit.osmocom.org/11924
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63a25c8366cce0852df6b628365151661a22a25f
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-CC: Holger Freyther <[email protected]>
Gerrit-Comment-Date: Sun, 02 Dec 2018 09:44:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
