Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 ) Change subject: manual: link to new common cs7-config.adoc, remove some dup of that .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/17580/1/doc/manuals/chapters/running.adoc File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-msc/+/17580/1/doc/manuals/chapters/running.adoc@107 PS1, Line 107: #routing-key 2 0.23.1 what about this comment? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie88dd2c7f7318a31ae04fbd6930346d92141fde5 Gerrit-Change-Number: 17580 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 22:46:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-msc[master]: manual: add missing mention of MGCP in "Multiple instances"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17579 ) Change subject: manual: add missing mention of MGCP in "Multiple instances" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91d06921e4dca08428bf45fc1a3fd6e124599371 Gerrit-Change-Number: 17579 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 22:42:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: manual: add SCCP/M3UA section from common chapters
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17504 ) Change subject: manual: add SCCP/M3UA section from common chapters .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5b4973901f02046322b852fd9862517982d21bd9 Gerrit-Change-Number: 17504 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 22:39:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17581 ) Change subject: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate .. Patch Set 2: I'm not sure that's really what we want. I mean, with current setup if you use INFO level you get one line for each message with the message being handled, which is "acceptable", while using DEBUG then you get tons of detailed parsing information. If you set it to notice (the default) you then don't see those. What do you think? It may look more annoying because of the red color. I'm fine if you want to swap for instance red with the other category in orange/brown, which usually shows more "interesting" stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016 Gerrit-Change-Number: 17581 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 22:28:30 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srs{enb, ue}.conf.tmpl: make sure to only use a single PHY thread when...
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17563 )
Change subject: srs{enb,ue}.conf.tmpl: make sure to only use a single PHY
thread when running with ZMQ
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17563
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Icc1e67705c0354ece77c037f224a9c756a16daaa
Gerrit-Change-Number: 17563
Gerrit-PatchSet: 5
Gerrit-Owner: Andre Puschmann
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Mon, 23 Mar 2020 22:24:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srs_ue: add scenario for airplane mode simulation in srsUE
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 ) Change subject: srs_ue: add scenario for airplane mode simulation in srsUE .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5db2ff325ce4b4236c1ceec0831dd7420d52dedb Gerrit-Change-Number: 17577 Gerrit-PatchSet: 2 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 22:23:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srs{enb, ue}.conf.tmpl: make sure to only use a single PHY thread when...
Hello pespin, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17563
to look at the new patch set (#5).
Change subject: srs{enb,ue}.conf.tmpl: make sure to only use a single PHY
thread when running with ZMQ
..
srs{enb,ue}.conf.tmpl: make sure to only use a single PHY thread when running
with ZMQ
Change-Id: Icc1e67705c0354ece77c037f224a9c756a16daaa
---
M src/osmo_gsm_tester/templates/srsenb.conf.tmpl
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
2 files changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/63/17563/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17563
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Icc1e67705c0354ece77c037f224a9c756a16daaa
Gerrit-Change-Number: 17563
Gerrit-PatchSet: 5
Gerrit-Owner: Andre Puschmann
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: srs_ue: add scenario for airplane mode simulation in srsUE
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 to look at the new patch set (#2). Change subject: srs_ue: add scenario for airplane mode simulation in srsUE .. srs_ue: add scenario for airplane mode simulation in srsUE Change-Id: I5db2ff325ce4b4236c1ceec0831dd7420d52dedb --- M example/defaults.conf A example/scenarios/mod-srsue-airplane_mode_sim@.conf M src/osmo_gsm_tester/resource.py M src/osmo_gsm_tester/templates/srsue.conf.tmpl 4 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/77/17577/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5db2ff325ce4b4236c1ceec0831dd7420d52dedb Gerrit-Change-Number: 17577 Gerrit-PatchSet: 2 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: srs_ue: send t+Enter to stdin after launching app
Andre Puschmann has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17561 )
Change subject: srs_ue: send t+Enter to stdin after launching app
..
srs_ue: send t+Enter to stdin after launching app
this enables the console trace which is printed to stdout
and provides human readable radio statistics
Change-Id: If1c998aff1c5c11d3fa636fb60cb4991e0def768
---
M src/osmo_gsm_tester/srs_ue.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo_gsm_tester/srs_ue.py b/src/osmo_gsm_tester/srs_ue.py
index f725587..388fbf1 100644
--- a/src/osmo_gsm_tester/srs_ue.py
+++ b/src/osmo_gsm_tester/srs_ue.py
@@ -120,6 +120,10 @@
else:
self.start_remotely()
+# send t+Enter to enable console trace
+self.dbg('Enabling console trace')
+self.process.stdin_write('t\n')
+
def start_remotely(self):
self.inst =
util.Dir(os.path.abspath(self.suite_run.trial.get_inst('srslte')))
lib = self.inst.child('lib')
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17561
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: If1c998aff1c5c11d3fa636fb60cb4991e0def768
Gerrit-Change-Number: 17561
Gerrit-PatchSet: 4
Gerrit-Owner: Andre Puschmann
Gerrit-Reviewer: Andre Puschmann
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: srs_ue: run srsUE as normal RemoteProcess
Andre Puschmann has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17562 ) Change subject: srs_ue: run srsUE as normal RemoteProcess .. srs_ue: run srsUE as normal RemoteProcess running with RemoteProcessFixIgnoreSIGHUP was needed bc srsUE used to ignore SIGHUP that is delivered to the process when the SSH session is terminated causing the UE to not quit properly. This isn't the case anymore so we can use RemoteProcess for spawning the UE. Furthermore, the wrapper script didn't pass along stdin to it's child process, i.e., srsUE. Therefore the console trace can't be seen if the run through the wrapper. Change-Id: Iab4dafc58167620362a36ec9e904b8d49a7d5fc1 --- M src/osmo_gsm_tester/srs_ue.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo_gsm_tester/srs_ue.py b/src/osmo_gsm_tester/srs_ue.py index 388fbf1..fdcd6dd 100644 --- a/src/osmo_gsm_tester/srs_ue.py +++ b/src/osmo_gsm_tester/srs_ue.py @@ -170,7 +170,7 @@ '--pcap.filename=' + self.remote_pcap_file, '--general.metrics_csv_filename=' + self.remote_metrics_file) -self.process = self.rem_host.RemoteProcessFixIgnoreSIGHUP(srsUE.BINFILE, util.Dir(srsUE.REMOTE_DIR), args) +self.process = self.rem_host.RemoteProcess(srsUE.BINFILE, args) #self.process = self.rem_host.RemoteProcessFixIgnoreSIGHUP(srsUE.BINFILE, remote_run_dir, args, remote_lib) self.suite_run.remember_to_stop(self.process) self.process.launch() -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Iab4dafc58167620362a36ec9e904b8d49a7d5fc1 Gerrit-Change-Number: 17562 Gerrit-PatchSet: 4 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
Andre Puschmann has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 )
Change subject: process: add stdin_write method to communicate with child on
stdin
..
process: add stdin_write method to communicate with child on stdin
Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5
---
M src/osmo_gsm_tester/process.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo_gsm_tester/process.py b/src/osmo_gsm_tester/process.py
index f399b29..5d02ab5 100644
--- a/src/osmo_gsm_tester/process.py
+++ b/src/osmo_gsm_tester/process.py
@@ -350,6 +350,13 @@
def wait(self, timeout=300):
MainLoop.wait(self, self.terminated, timeout=timeout)
+def stdin_write(self, cmd):
+'''
+Send a cmd to the stdin of a process (convert to byte before)
+'''
+if self.process_obj.stdin is not None:
+self.process_obj.stdin.write(cmd.encode("utf-8"))
+self.process_obj.stdin.flush()
class RemoteProcess(Process):
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5
Gerrit-Change-Number: 17560
Gerrit-PatchSet: 4
Gerrit-Owner: Andre Puschmann
Gerrit-Reviewer: Andre Puschmann
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-pcu[master]: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/17581 ) Change subject: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate .. rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate This a leftover from I7b42c9e21ad8d8a5b54e7a3b68490934ce3d3198. Most of the CSN.1 codec related logging messages are now using LOGL_DEBUG, so the rlcmac code should also do the same. Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016 --- M src/gsm_rlcmac.cpp M tests/rlcmac/RLCMACTest.err 2 files changed, 50 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/17581/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016 Gerrit-Change-Number: 17581 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/17581 )
Change subject: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate
..
rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate
This a leftover from I7b42c9e21ad8d8a5b54e7a3b68490934ce3d3198.
Most of the CSN.1 codec related logging messages are now using
LOGL_DEBUG, so the rlcmac code should also do the same.
Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016
---
M src/gsm_rlcmac.cpp
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/17581/1
diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp
index c1dc80e..03e0417 100644
--- a/src/gsm_rlcmac.cpp
+++ b/src/gsm_rlcmac.cpp
@@ -4978,7 +4978,7 @@
/* recursive csnStreamDecoder call uses LOGPC everywhere, so we need to
start the log somewhere... */
msg_type_name = get_value_string(rlcmac_ul_msg_names, data->u.MESSAGE_TYPE);
- LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (type: %s (%d)): ",
+ LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (type: %s (%d)): ",
msg_type_name, data->u.MESSAGE_TYPE);
switch (data->u.MESSAGE_TYPE)
{
@@ -5065,7 +5065,7 @@
/* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
newline, so as a caller we are responisble for submitting it */
- LOGPC(DCSN1, LOGL_INFO, "\n");
+ LOGPC(DCSN1, LOGL_DEBUG, "\n");
if (ret > 0) {
LOGP(DRLCMACDATA, LOGL_NOTICE, "%s: Got %d remaining bits unhandled by
decoder at the end of bitvec\n", msg_type_name, ret);
@@ -5140,7 +5140,7 @@
/* recursive csnStreamDecoder call uses LOGPC everywhere, so we need to
start the log somewhere... */
msg_type_name = get_value_string(rlcmac_dl_msg_names, data->u.MESSAGE_TYPE);
- LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (type: %s (%d): ",
+ LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (type: %s (%d): ",
msg_type_name, data->u.MESSAGE_TYPE);
switch (data->u.MESSAGE_TYPE)
@@ -5277,7 +5277,7 @@
/* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
newline, so as a caller we are responisble for submitting it */
- LOGPC(DCSN1, LOGL_INFO, "\n");
+ LOGPC(DCSN1, LOGL_DEBUG, "\n");
if (ret > 0) {
LOGP(DRLCMACDATA, LOGL_NOTICE, "%s: Got %d remaining bits unhandled by
decoder at the end of bitvec\n", msg_type_name, ret);
@@ -5301,7 +5301,7 @@
/* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to
start the log somewhere... */
msg_type_name = get_value_string(rlcmac_ul_msg_names, data->u.MESSAGE_TYPE);
- LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (type: %s (%d)): ",
+ LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (type: %s (%d)): ",
msg_type_name, data->u.MESSAGE_TYPE);
switch (data->u.MESSAGE_TYPE)
{
@@ -5388,7 +5388,7 @@
/* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
newline, so as a caller we are responisble for submitting it */
- LOGPC(DCSN1, LOGL_INFO, "\n");
+ LOGPC(DCSN1, LOGL_DEBUG, "\n");
if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {
LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode an Uplink block: not
enough bits "
@@ -5462,7 +5462,7 @@
/* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to
start the log somewhere... */
msg_type_name = get_value_string(rlcmac_dl_msg_names, data->u.MESSAGE_TYPE);
- LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (type: %s (%d)): ",
+ LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (type: %s (%d)): ",
msg_type_name, data->u.MESSAGE_TYPE);
switch (data->u.MESSAGE_TYPE)
{
@@ -5598,7 +5598,7 @@
/* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
newline, so as a caller we are responisble for submitting it */
- LOGPC(DCSN1, LOGL_INFO, "\n");
+ LOGPC(DCSN1, LOGL_DEBUG, "\n");
if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {
LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode a Downlink block: not
enough bits "
@@ -5754,12 +5754,12 @@
csnStreamInit(, 0, 8 * vector->data_len);
/* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to
start the log somewhere... */
- LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (RAcap): ");
+ LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (RAcap): ");
ret = csnStreamDecoder(, CSNDESCR(MS_Radio_Access_capability_t), vector,
, data);
/* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
newline, so as a caller we are responisble for submitting it */
- LOGPC(DCSN1, LOGL_INFO, "\n");
+ LOGPC(DCSN1, LOGL_DEBUG, "\n");
if (ret > 0) {
LOGP(DRLCMACDATA, LOGL_NOTICE, "RAcap: Got %d remaining bits unhandled by
decoder at the end of bitvec\n", ret);
@@ -5780,9 +5780,9 @@
csnStreamInit(, 0, vector->data_len * 8);
/* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to
start the log somewhere... */
-
Change in osmo-gsm-tester[master]: srs_ue: add scenario for airplane mode simulation in srsUE
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 )
Change subject: srs_ue: add scenario for airplane mode simulation in srsUE
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577/1/src/osmo_gsm_tester/srs_ue.py
File src/osmo_gsm_tester/srs_ue.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577/1/src/osmo_gsm_tester/srs_ue.py@221
PS1, Line 221: values = dict(ue=config.get_defaults('srsue'))
See from here it takes stuff from defaults.conf from the "srsue" section.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5db2ff325ce4b4236c1ceec0831dd7420d52dedb
Gerrit-Change-Number: 17577
Gerrit-PatchSet: 1
Gerrit-Owner: Andre Puschmann
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Mon, 23 Mar 2020 19:08:43 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srs_ue: add scenario for airplane mode simulation in srsUE
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 ) Change subject: srs_ue: add scenario for airplane mode simulation in srsUE .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577/1/src/osmo_gsm_tester/srs_ue.py File src/osmo_gsm_tester/srs_ue.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577/1/src/osmo_gsm_tester/srs_ue.py@226 PS1, Line 226: # Get airplane mode params You don't need this. Instead, add default values in defaults.conf -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5db2ff325ce4b4236c1ceec0831dd7420d52dedb Gerrit-Change-Number: 17577 Gerrit-PatchSet: 1 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 19:08:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/17580 )
Change subject: manual: link to new common cs7-config.adoc, remove some dup of
that
..
manual: link to new common cs7-config.adoc, remove some dup of that
Related: OS#2767
Depends: Ia2508d4c7b0fef9cdc57e7e122799a480e340bf7 (osmo-gsm-manuals)
Change-Id: Ie88dd2c7f7318a31ae04fbd6930346d92141fde5
---
A TODO-RELEASE
M doc/manuals/chapters/running.adoc
M doc/manuals/osmomsc-usermanual.adoc
3 files changed, 24 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/17580/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
new file mode 100644
index 000..dde4b72
--- /dev/null
+++ b/TODO-RELEASE
@@ -0,0 +1,10 @@
+# When cleaning up this file: bump API version in corresponding Makefile.am
and rename corresponding debian/lib*.install
+# according to
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info
+# In short:
+# LIBVERSION=c:r:a
+# If the library source code has changed at all since the last update, then
increment revision: c:r + 1:a.
+# If any interfaces have been added, removed, or changed since the last
update: c + 1:0:0.
+# If any interfaces have been added since the last public release: c:r:a + 1.
+# If any interfaces have been removed or changed since the last public
release: c:r:0.
+#library whatdescription / commit summary line
+manual needs common chapter cs7-config.adoc from
osmo-gsm-manuals > 0.3.0
diff --git a/doc/manuals/chapters/running.adoc
b/doc/manuals/chapters/running.adoc
index 4bd3913..18fdad9 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -91,20 +91,24 @@
Configure SCCP/M3UA to accept _A_ and _IuCS_ links
-OsmoMSC will contact an STP instance to establish an SCCP/M3UA link. BSC and
-HNBGW will then reach the MSC via this link. By default, an STP instance is
-assumed to listen on the default M3UA port (2905) on the local host.
+OsmoMSC acts as client to contact an STP instance and establish an SCCP/M3UA
+link.
-Establishing an SCCP/M3UA link towards an STP instance not on the local host
-can be configured as follows:
+An example configuration of OsmoMSC's SCCP link:
cs7 instance 0
- asp my-OsmoMSC 2905 0 m3ua
- ! IP address of the remote STP:
- remote-ip 10.23.24.1
+ point-code 0.23.1
+ asp asp-clnt-OsmoMSC-A-Iu 2905 0 m3ua
+ remote-ip 127.0.0.1
+ sctp-role client
+ as as-clnt-OsmoMSC-A-Iu m3ua
+ asp asp-clnt-OsmoMSC-A-Iu
+ #routing-key 2 0.23.1
+This configuration is explained in detail in <>.
+
Note that _A_ and _IuCS_ may use different SCCP instances, if so desired:
@@ -119,21 +123,6 @@
cs7-instance-iu 1
-A full configuration needs an `asp` on an `as` -- an Application Server Process
-running on an Application Server -- as well as a local point code and routing
-configuration. The SCCP VTY automatically creates those parts that are missing,
-by assuming sane defaults. A complete configuration would look like this:
-
-
-cs7 instance 0
- point-code 0.23.1
- asp my-OsmoMSC-A-Iu 2905 0 m3ua
- remote-ip 127.0.0.1
- as my-as-for-OsmoMSC-A-Iu m3ua
- asp my-OsmoMSC-A-Iu
- routing-key 0 0.23.1
-
-
Configure GSUP to reach the HLR
OsmoMSC will assume a GSUP server (OsmoHLR) to run on the local host and the
diff --git a/doc/manuals/osmomsc-usermanual.adoc
b/doc/manuals/osmomsc-usermanual.adoc
index d680a51..848d9c0 100644
--- a/doc/manuals/osmomsc-usermanual.adoc
+++ b/doc/manuals/osmomsc-usermanual.adoc
@@ -22,6 +22,8 @@
include::./common/chapters/logging.adoc[]
+include::./common/chapters/cs7-config.adoc[]
+
include::{srcdir}/chapters/net.adoc[]
include::./common/chapters/smpp.adoc[]
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17580
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie88dd2c7f7318a31ae04fbd6930346d92141fde5
Gerrit-Change-Number: 17580
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-msc[master]: manual: add missing mention of MGCP in "Multiple instances"
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/17579 ) Change subject: manual: add missing mention of MGCP in "Multiple instances" .. manual: add missing mention of MGCP in "Multiple instances" Change-Id: I91d06921e4dca08428bf45fc1a3fd6e124599371 --- M doc/manuals/chapters/running.adoc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/79/17579/1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 03dade6..4bd3913 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -84,6 +84,7 @@ - The SCCP/M3UA links are established by OsmoMSC contacting an STP. - The GSUP link is established by OsmoMSC contacting an HLR. +- The MGCP link is established by OsmoMSC contacting an MGW. === Configure primary links -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91d06921e4dca08428bf45fc1a3fd6e124599371 Gerrit-Change-Number: 17579 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange
Change in osmo-bsc[master]: manual: add SCCP/M3UA section from common chapters
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/17504 to look at the new patch set (#6). Change subject: manual: add SCCP/M3UA section from common chapters .. manual: add SCCP/M3UA section from common chapters Link to the osmo-gsm-manuals/common/cs7-config.adoc chapter to fully explain the 'cs7' client configuration. Related: OS#2767 Depends: Ia2508d4c7b0fef9cdc57e7e122799a480e340bf7 (osmo-gsm-manuals) Change-Id: I5b4973901f02046322b852fd9862517982d21bd9 --- A TODO-RELEASE M doc/manuals/chapters/running.adoc M doc/manuals/osmobsc-usermanual.adoc 3 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/17504/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5b4973901f02046322b852fd9862517982d21bd9 Gerrit-Change-Number: 17504 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: rlcmac: Fix bug receiving RA cap
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/17548 )
Change subject: rlcmac: Fix bug receiving RA cap
..
rlcmac: Fix bug receiving RA cap
It seems the assumptions regarding maximum number of RA capabilitites
in one message were wrong. Doing some rough calculations, each RA
capabilitiy value (without extensions) can take around 20ish bits, which
means for a message containing up to 52 bytes that quite a lot of
different values could be theoretically fed in. Let's be safe and
increase the array size to be able to handle all different access
technologies listed in See TS 24.008 table 10.5.146 following
restrictions:
* "The MS Radio Access capability is a type 4 information element, with a
maximum length of 52 octets."
* "Among the three Access Type Technologies GSM 900-P, GSM 900-E and GSM 900-R
only one shall be present."
* "the mobile station should provide the relevant radio access
capability for either GSM 1800 band OR GSM 1900 band, not both".
Wireshark requires similar fix (it's not important though because it
currently uses another ad-hoc decoder for RAcap).
Related: OS#4463
Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff
---
M src/gsm_rlcmac.h
M tests/rlcmac/RLCMACTest.cpp
M tests/rlcmac/RLCMACTest.err
M tests/rlcmac/RLCMACTest.ok
4 files changed, 16 insertions(+), 20 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h
index 10bb6af..9e38966 100644
--- a/src/gsm_rlcmac.h
+++ b/src/gsm_rlcmac.h
@@ -1224,10 +1224,6 @@
} Content_t;
-#define ABSOLUTE_MAX_BANDS2 /* New fields for R4 extend the
length of the capabilities message so we can only send 2 */
-
-#define MAX_ACCESS_TECHNOLOGIES_COUNT 16 /* No more than 16 instances */
-
typedef enum
{/* See TS 24.008 table 10.5.146 */
AccTech_GSMP = 0x0,
@@ -1246,14 +1242,9 @@
AccTech_GSMT810 = 0xd,
AccTech_GSMOther = 0xf
} AccessTechnology_t;
-
-#if 0
-typedef struct
-{
- guint8 CountAccessTechnologies;
- AccessTechnology_t AccessTechnologies[MAX_ACCESS_TECHNOLOGIES_COUNT];
-} AccessTechnologiesRequest_t;
-#endif
+/* Maximum entries in one message, Enum above, appying restrictions from
section
+ 12.30 "MS Radio Access Capability 2": */
+#define MAX_ACCESS_TECHNOLOGIES_COUNT 11
typedef struct
{
@@ -1266,8 +1257,8 @@
{
guint8 Count_additional_access_technologies;
/* The value 0xf cannot be set for the first ATT, therefore we can only have
- ABSOLUTE_MAX_BANDS-1 additional access technologies. */
- Additional_access_technologies_struct_t
Additional_access_technologies[ABSOLUTE_MAX_BANDS-1];
+ MAX_ACCESS_TECHNOLOGIES_COUNT-1 additional access technologies. */
+ Additional_access_technologies_struct_t
Additional_access_technologies[MAX_ACCESS_TECHNOLOGIES_COUNT-1];
} Additional_access_technologies_t;
typedef struct
@@ -1285,7 +1276,7 @@
typedef struct
{
guint8 Count_MS_RA_capability_value; /* Recursive */
- MS_RA_capability_value_t MS_RA_capability_value[ABSOLUTE_MAX_BANDS];
+ MS_RA_capability_value_t
MS_RA_capability_value[MAX_ACCESS_TECHNOLOGIES_COUNT];
} MS_Radio_Access_capability_t;
diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp
index 058d57e..200cac8 100644
--- a/tests/rlcmac/RLCMACTest.cpp
+++ b/tests/rlcmac/RLCMACTest.cpp
@@ -456,15 +456,16 @@
printf("=== Test decoding of multi-band MS RA Capability ===\n");
rc = decode_gsm_ra_cap(bv_dec, );
- OSMO_ASSERT(rc == CSN_ERROR_STREAM_NOT_SUPPORTED);
-#if 0
- /* Make sure there's 1 value (currently fails due to failed decoding) */
+ printf("decode_gsm_ra_cap() returns %d\n", rc);
+ OSMO_ASSERT(rc == 0);
+
+ /* Make sure there's 3 values */
OSMO_ASSERT(data.Count_MS_RA_capability_value == 3);
/* Make sure GPRS / EGPRS multislot class is parsed correctly */
printf("GPRS multislot class = %u\n",
Decoding::get_ms_class_by_capability());
printf("EGPRS multislot class = %u\n",
Decoding::get_egprs_ms_class_by_capability());
-#endif
+
bitvec_free(bv_dec);
}
diff --git a/tests/rlcmac/RLCMACTest.err b/tests/rlcmac/RLCMACTest.err
index b225bfd..497f4d8 100644
--- a/tests/rlcmac/RLCMACTest.err
+++ b/tests/rlcmac/RLCMACTest.err
@@ -39,4 +39,5 @@
DCSN1 INFO csnStreamDecoder (RAcap): MS_RA_capability_value { | Choice
MS_RA_capability_value_Choice = 1 | u.Content length = 21 | offset = 4 |
RF_Power_Capability = 1 | Exist_A5_bits = 0 | ES_IND = 1 | PS = 0 | VGCS = 0 |
VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability |
Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 |
GPRS_multislot_class = 3 | GPRS_Extended_Dynamic_Allocation_Capability = 0 |
Exist_SM = 0 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1
| DCSN1 ERROR csnStreamDecoder: error NEED_MORE BITS TO UNPACK (-5) at
Change in osmocom-bb[master]: virt_phy: implement GSMTAP_CHANNEL_VOICE
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17380 ) Change subject: virt_phy: implement GSMTAP_CHANNEL_VOICE .. Abandoned merged as Id72cf23b7c6587efae4cdaa7b50ab4d85b8c8d22 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I25cb50fea3501f90c762f0cbdc9835c5db87 Gerrit-Change-Number: 17380 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 ) Change subject: process: add stdin_write method to communicate with child on stdin .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 4 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 18:22:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Introduce MS Radio Access Capabilities 2 to fix related spare...
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17578 ) Change subject: rlcmac: Introduce MS Radio Access Capabilities 2 to fix related spare bits .. Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/17578/1/tests/rlcmac/RLCMACTest.err File tests/rlcmac/RLCMACTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/17578/1/tests/rlcmac/RLCMACTest.err@a38 PS1, Line 38: DRLCMACDATA ERROR Failed to encode MS RA Capability IE: not enough bits in the output buffer (rc=107) Huh, interesting side effect :) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibd756f80a03452a651e2771dbc628d701e55ac4b Gerrit-Change-Number: 17578 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 23 Mar 2020 18:10:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Fix bug receiving RA cap
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17548 ) Change subject: rlcmac: Fix bug receiving RA cap .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 18:09:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Fix bug receiving RA cap
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 to look at the new patch set (#8). Change subject: rlcmac: Fix bug receiving RA cap .. rlcmac: Fix bug receiving RA cap It seems the assumptions regarding maximum number of RA capabilitites in one message were wrong. Doing some rough calculations, each RA capabilitiy value (without extensions) can take around 20ish bits, which means for a message containing up to 52 bytes that quite a lot of different values could be theoretically fed in. Let's be safe and increase the array size to be able to handle all different access technologies listed in See TS 24.008 table 10.5.146 following restrictions: * "The MS Radio Access capability is a type 4 information element, with a maximum length of 52 octets." * "Among the three Access Type Technologies GSM 900-P, GSM 900-E and GSM 900-R only one shall be present." * "the mobile station should provide the relevant radio access capability for either GSM 1800 band OR GSM 1900 band, not both". Wireshark requires similar fix (it's not important though because it currently uses another ad-hoc decoder for RAcap). Related: OS#4463 Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff --- M src/gsm_rlcmac.h M tests/rlcmac/RLCMACTest.cpp M tests/rlcmac/RLCMACTest.err M tests/rlcmac/RLCMACTest.ok 4 files changed, 16 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/48/17548/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: tests/RLCMACTest: Several fixes and improvements to RAcap tests
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/17549 )
Change subject: tests/RLCMACTest: Several fixes and improvements to RAcap tests
..
tests/RLCMACTest: Several fixes and improvements to RAcap tests
It was recently discovered that the Racap value used for testRAcap was
actually malformed (it was taken from a TTCN3 test). It had the presence
bit for "EGPRS multislot class" set but no struct was put after it.
So let's move that malformed value to a new test named
testMalformedRAcap(). Since it doesn't make sense trying to re-encode or
do similar things with an initially malformed value, let's drop all
those parts in this new test.
For the old testRAcap() test, use a new bitstream this time with the
"EGPRS multoslot class" struct set inside (class 3).
Change-Id: I1e7f8d8866695732ee24a79d8b54d660fd4f22d5
---
M tests/rlcmac/RLCMACTest.cpp
M tests/rlcmac/RLCMACTest.err
M tests/rlcmac/RLCMACTest.ok
3 files changed, 91 insertions(+), 40 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp
index e62d6e4..6529d4d 100644
--- a/tests/rlcmac/RLCMACTest.cpp
+++ b/tests/rlcmac/RLCMACTest.cpp
@@ -219,12 +219,79 @@
void testRAcap(void *test_ctx)
{
+printf("*** %s ***\n", __func__);
+MS_Radio_Access_capability_t data;
+memset(, 0, sizeof(data));
+bitvec *bv_dec = bitvec_alloc(23, test_ctx);
+bitvec *bv_enc = bitvec_alloc(23, test_ctx);
+unsigned int len_dec, len_enc;
+int rc;
+/*
+MS RA capability 1
+0001 = Access Technology Type: GSM E --note that GSM E covers GSM P
(1)
+ 0011 011. = Length in bits: 0x1b (27)
+...0 01.. RF Power Capability, GMSK Power Class: Not specified (1)
+A5 Bits: Same values apply for parameters as in the immediately preceding
Access capabilities field within this IE (0)
+ ...1 = Controlled early Classmark Sending: Implemented
+0... = Pseudo Synchronisation: Not Present
+.0.. = Voice Group Call Service: no VGCS capability or no
notifications wanted
+..0. = Voice Broadcast Service: no VBS capability or no notifications
wanted
+...1 = Multislot capability struct: Present
+HSCSD multislot class: Bits are not available (0)
+SMS_VALUE (Switch-Measure-Switch): Bits are not available (0)
+ECSD multislot class: Bits are not available (0)
+DTM GPRS Multi Slot Class: Bits are not available (0)
+ ..00 011. = GPRS multislot class: Max Rx-Slot/TDMA:2 Max
Tx-Slot/TDMA:2 Max-Sum-Slot/TDMA:3 Tta:3 Ttb:2 Tra:3 Trb:1 Type:1 (3)
+...0 = GPRS Extended Dynamic Allocation Capability: Not Implemented
+ ...0 0011 = EGPRS multislot class: Max Rx-Slot/TDMA:2 Max
Tx-Slot/TDMA:2 Max-Sum-Slot/TDMA:3 Tta:3 Ttb:2 Tra:3 Trb:1 Type:1 (3)
+ 0... = EGPRS Extended Dynamic Allocation Capability: Not Implemented
+*/
+bitvec_unhex(bv_dec, "1365146230");
+
+printf("=== Test decoding of MS RA Capability ===\n");
+rc = decode_gsm_ra_cap(bv_dec, );
+OSMO_ASSERT(rc == 0);
+
+/* Make sure there's 1 value (currently fails due to failed decoding)
*/
+OSMO_ASSERT(data.Count_MS_RA_capability_value == 1);
+
+/* Make sure GPRS / EGPRS multislot class is parsed correctly */
+printf("GPRS multislot class = %u\n",
Decoding::get_ms_class_by_capability());
+printf("EGPRS multislot class = %u\n",
Decoding::get_egprs_ms_class_by_capability());
+
+/* Test encoding of decoded MS RA Capability */
+printf("=== Test encoding of MS RA Capability ===\n");
+rc = encode_gsm_ra_cap(bv_enc, );
+printf("encode_gsm_ra_cap() returns %d\n", rc);
+
+bv_dec->cur_bit = 4;
+len_dec = bitvec_get_uint(bv_dec, 7);
+bv_enc->cur_bit = 4;
+len_enc = bitvec_get_uint(bv_enc, 7);
+
+/* NOTE: vector2 is expected to be different because there is actually
no
+ * way to distinguish between NULL and 0 in
MS_Radio_Access_capability_t.
+ * The difference is in length indicator: 27 bits vs 65 bits. */
+printf("vector1 (len_ind=%u) = %s\n", len_dec,
osmo_hexdump(bv_dec->data, bv_dec->data_len));
+printf("vector2 (len_ind=%u) = %s\n", len_enc,
osmo_hexdump(bv_enc->data, bv_enc->data_len));
+
+/* Mangle the length indicator (set it to 21) */
+unsigned int writeIndex = 4;
+rc = bitvec_write_field(bv_dec, , 21, 7);
+OSMO_ASSERT(rc == 0);
+
+/* Make sure decoding attempt fails */
+printf("=== Test decoding of a malformed vector (short length
indicator) ===\n");
+rc = decode_gsm_ra_cap(bv_dec, );
+printf("decode_gsm_ra_cap() returns %d\n", rc);
+}
+
+void
Change in osmo-pcu[master]: rlcmac: Don't pass array element to CSN1 descriptors
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17574 ) Change subject: rlcmac: Don't pass array element to CSN1 descriptors .. rlcmac: Don't pass array element to CSN1 descriptors This way the macros can be used to access the arrays themselves and calculate its static size to enable validation later. In the case of Packet_Access_Reject_t, modify the description to use a M_REC_TARRAY_1 object to get rid of access to 2nd element. The new description is the correct one, since the first element is mandatory according to TS 44.060 Table 11.2.1. Change-Id: I6f10350d4734360c7a15a702c72b59efd84987ee --- M src/gsm_rlcmac.cpp 1 file changed, 11 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp index 40b75ed..db0e54a 100644 --- a/src/gsm_rlcmac.cpp +++ b/src/gsm_rlcmac.cpp @@ -902,7 +902,7 @@ static const CSN_DESCR_BEGIN (Additional_access_technologies_t) - M_REC_TARRAY(Additional_access_technologies_t, Additional_access_technologies[0], Additional_access_technologies_struct_t, Count_additional_access_technologies), + M_REC_TARRAY(Additional_access_technologies_t, Additional_access_technologies, Additional_access_technologies_struct_t, Count_additional_access_technologies), CSN_DESCR_END (Additional_access_technologies_t) gint16 Additional_access_technologies_Dissector(csnStream_t* ar, bitvec* vector, unsigned *readIndex, void* data) @@ -1365,7 +1365,7 @@ static const CSN_DESCR_BEGIN(PSI_Message_List_t) - M_REC_TARRAY (PSI_Message_List_t, PSI_Message[0], PSI_Message_t, Count_PSI_Message), + M_REC_TARRAY (PSI_Message_List_t, PSI_Message, PSI_Message_t, Count_PSI_Message), M_FIXED (PSI_Message_List_t, 1, 0x00), M_UINT (PSI_Message_List_t, ADDITIONAL_MSG_TYPE, 1), CSN_DESCR_END (PSI_Message_List_t) @@ -1402,7 +1402,7 @@ static const CSN_DESCR_BEGIN(SI_Message_List_t) - M_REC_TARRAY (SI_Message_List_t, SI_Message[0], SI_Message_t, Count_SI_Message), + M_REC_TARRAY (SI_Message_List_t, SI_Message, SI_Message_t, Count_SI_Message), M_FIXED (SI_Message_List_t, 1, 0x00), M_UINT (SI_Message_List_t, ADDITIONAL_MSG_TYPE, 1), CSN_DESCR_END (SI_Message_List_t) @@ -2602,8 +2602,7 @@ M_UINT (Packet_Access_Reject_t, MESSAGE_TYPE, 6), M_UINT (Packet_Access_Reject_t, PAGE_MODE, 2), - M_TYPE (Packet_Access_Reject_t, Reject, Reject_t), - M_REC_TARRAY (Packet_Access_Reject_t, Reject[1], Reject_t, Count_Reject), + M_REC_TARRAY_1(Packet_Access_Reject_t, Reject, Reject_t, Count_Reject), M_PADDING_BITS(Packet_Access_Reject_t), CSN_DESCR_END (Packet_Access_Reject_t) @@ -3572,7 +3571,7 @@ M_UINT (ENH_NC_Measurement_Report_t, SCALE, 1), M_NEXT_EXIST (ENH_NC_Measurement_Report_t, Exist_Serving_Cell_Data, 1), M_TYPE (ENH_NC_Measurement_Report_t, Serving_Cell_Data, Serving_Cell_Data_t), - M_REC_TARRAY (ENH_NC_Measurement_Report_t, RepeatedInvalid_BSIC_Info[0], RepeatedInvalid_BSIC_Info_t, Count_RepeatedInvalid_BSIC_Info), + M_REC_TARRAY (ENH_NC_Measurement_Report_t, RepeatedInvalid_BSIC_Info, RepeatedInvalid_BSIC_Info_t, Count_RepeatedInvalid_BSIC_Info), M_NEXT_EXIST (ENH_NC_Measurement_Report_t, Exist_ReportBitmap, 1), M_VAR_TARRAY (ENH_NC_Measurement_Report_t, REPORTING_QUANTITY_Instances, REPORTING_QUANTITY_Instance_t, Count_REPORTING_QUANTITY_Instances), CSN_DESCR_END (ENH_NC_Measurement_Report_t) @@ -3713,7 +3712,7 @@ M_UINT (EnhancedMeasurementReport_t, SCALE, 1), M_NEXT_EXIST(EnhancedMeasurementReport_t, Exist_ServingCellData, 1), M_TYPE (EnhancedMeasurementReport_t, ServingCellData, EMR_ServingCell_t), - M_REC_TARRAY(EnhancedMeasurementReport_t, RepeatedInvalid_BSIC_Info[0], RepeatedInvalid_BSIC_Info_t, + M_REC_TARRAY(EnhancedMeasurementReport_t, RepeatedInvalid_BSIC_Info, RepeatedInvalid_BSIC_Info_t, Count_RepeatedInvalid_BSIC_Info), M_NEXT_EXIST(EnhancedMeasurementReport_t, Exist_ReportBitmap, 1), M_VAR_TARRAY(EnhancedMeasurementReport_t, REPORTING_QUANTITY_Instances, REPORTING_QUANTITY_Instance_t, Count_REPORTING_QUANTITY_Instances), @@ -4472,7 +4471,7 @@ static const CSN_DESCR_BEGIN(NonHoppingPCCCH_t) - M_REC_TARRAY (NonHoppingPCCCH_t, Carriers[0], Non_Hopping_PCCCH_Carriers_t, Count_Carriers), + M_REC_TARRAY (NonHoppingPCCCH_t, Carriers, Non_Hopping_PCCCH_Carriers_t, Count_Carriers), CSN_DESCR_END (NonHoppingPCCCH_t) static const @@ -4484,7 +4483,7 @@ static const CSN_DESCR_BEGIN(HoppingPCCCH_t) M_UINT(HoppingPCCCH_t, MA_NUMBER, 4), - M_REC_TARRAY (HoppingPCCCH_t, Carriers[0], Hopping_PCCCH_Carriers_t, Count_Carriers), + M_REC_TARRAY (HoppingPCCCH_t, Carriers, Hopping_PCCCH_Carriers_t, Count_Carriers),
Change in osmo-pcu[master]: csn1: Validate recursive array max size during decoding
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/17572 )
Change subject: csn1: Validate recursive array max size during decoding
..
csn1: Validate recursive array max size during decoding
This way if CSN1 encoded bitstream contains more elements than what the
defintion expects it will fail instead of overflowing the decoded
buffer.
RA cap struct placed in unit test is taken from a real android phone
sending the value when attaching to the network. Then SGSN sends it back
and osmo-pcu would crash similar to unit test:
*** stack smashing detected ***: terminated
Process terminating with default action of signal 6 (SIGABRT): dumping core
at 0x4C62CE5: raise (in /usr/lib/libc-2.31.so)
by 0x4C4C856: abort (in /usr/lib/libc-2.31.so)
by 0x4CA62AF: __libc_message (in /usr/lib/libc-2.31.so)
by 0x4D36069: __fortify_fail (in /usr/lib/libc-2.31.so)
by 0x4D36033: __stack_chk_fail (in /usr/lib/libc-2.31.so)
by 0x124706: testRAcap2(void*) (RLCMACTest.cpp:468)
Related: OS#4463
Change-Id: I9fe0e55e0a6a41ae2cc885fba490c1d4a186231e
---
M src/csn1.c
M src/csn1.h
M tests/rlcmac/RLCMACTest.cpp
M tests/rlcmac/RLCMACTest.err
M tests/rlcmac/RLCMACTest.ok
5 files changed, 163 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
laforge: Looks good to me, approved
diff --git a/src/csn1.c b/src/csn1.c
index 296bf6c..7172847 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -1278,9 +1278,10 @@
case CSN_RECURSIVE_TARRAY:
{ /* Recursive way to specify an array of type: ::= { 1 }
** 0 ;
* M_REC_TARRAY(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)
- * {t, offsetof(_STRUCT, _ElementCountField),
(void*)CSNDESCR_##_MEMBER_TYPE, offsetof(_STRUCT, _MEMBER), #_MEMBER,
(StreamSerializeFcn_t)sizeof(_MEMBER_TYPE)}
+ * {t, offsetof(_STRUCT, _ElementCountField),
(void*)CSNDESCR_##_MEMBER_TYPE, offsetof(_STRUCT, _MEMBER), #_MEMBER,
(StreamSerializeFcn_t)sizeof(_MEMBER_TYPE),
(void_fn_t)ElementsOf(((_STRUCT*)0)->_MEMBER)}
*/
gint16 nSizeElement = (gint16)(gint32)pDescr->value;
+guint32 nSizeArray = (guint32)((uintptr_t)pDescr->aux_fn);
guint8 ElementCount = 0;
pui8 = pui8DATA(data, pDescr->offset);
@@ -1292,6 +1293,12 @@
remaining_bits_len--;
ElementCount++;
+ if (ElementCount > nSizeArray)
+ {
+LOGPC(DCSN1, LOGL_ERROR, "error: %s: too many elements (>%u) in
recursive array. Increase its size! } |", pDescr->sz, nSizeArray);
+return ProcessError(readIndex,"csnStreamDecoder",
CSN_ERROR_STREAM_NOT_SUPPORTED, pDescr);
+ }
+
{ /* unpack the following data structure */
csnStream_t arT = *ar;
gint16 Status;
@@ -1342,9 +1349,10 @@
case CSN_RECURSIVE_TARRAY_1:
{ /* Recursive way to specify an array of type: ::= { 1
} ** 0 ;
* M_REC_TARRAY(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)
- * {t, offsetof(_STRUCT, _ElementCountField),
(void*)CSNDESCR_##_MEMBER_TYPE, offsetof(_STRUCT, _MEMBER), #_MEMBER,
(StreamSerializeFcn_t)sizeof(_MEMBER_TYPE)}
+ * {t, offsetof(_STRUCT, _ElementCountField),
(void*)CSNDESCR_##_MEMBER_TYPE, offsetof(_STRUCT, _MEMBER), #_MEMBER,
(StreamSerializeFcn_t)sizeof(_MEMBER_TYPE),
(void_fn_t)ElementsOf(((_STRUCT*)0)->_MEMBER)}
*/
gint16 nSizeElement = (gint16)(gint32)pDescr->value;
+guint32 nSizeArray = (guint32)((uintptr_t)pDescr->aux_fn);
guint8 ElementCount = 0;
csnStream_t arT = *ar;
gboolean EndOfList= FALSE;
@@ -1355,6 +1363,12 @@
{ /* get data element */
ElementCount++;
+ if (ElementCount > nSizeArray)
+ {
+LOGPC(DCSN1, LOGL_ERROR, "error: %s: too many elements (>%u) in
recursive array. Increase its size! } |", pDescr->sz, nSizeArray);
+return ProcessError(readIndex,"csnStreamDecoder",
CSN_ERROR_STREAM_NOT_SUPPORTED, pDescr);
+ }
+
LOGPC(DCSN1, LOGL_DEBUG, "%s { | ", pDescr->sz);
csnStreamInit(, bit_offset, remaining_bits_len);
diff --git a/src/csn1.h b/src/csn1.h
index b3fdc0a..0421b39 100644
--- a/src/csn1.h
+++ b/src/csn1.h
@@ -443,7 +443,7 @@
* Par4: will hold the number of element in the array after unpacking
*/
#define M_REC_TARRAY(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)\
-{CSN_RECURSIVE_TARRAY, offsetof(_STRUCT, _ElementCountField), {(const
void*)CSNDESCR_##_MEMBER_TYPE}, offsetof(_STRUCT, _MEMBER), FALSE, #_MEMBER,
sizeof(_MEMBER_TYPE), NULL}
+{CSN_RECURSIVE_TARRAY, offsetof(_STRUCT, _ElementCountField), {(const
void*)CSNDESCR_##_MEMBER_TYPE}, offsetof(_STRUCT, _MEMBER), FALSE, #_MEMBER,
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 to look at the new patch set (#4). Change subject: process: add stdin_write method to communicate with child on stdin .. process: add stdin_write method to communicate with child on stdin Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 --- M src/osmo_gsm_tester/process.py 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/60/17560/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 4 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: srs_ue: add scenario for airplane mode simulation in srsUE
Andre Puschmann has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577 )
Change subject: srs_ue: add scenario for airplane mode simulation in srsUE
..
srs_ue: add scenario for airplane mode simulation in srsUE
Change-Id: I5db2ff325ce4b4236c1ceec0831dd7420d52dedb
---
M example/defaults.conf
A example/scenarios/mod-srsue-airplane_mode_sim@.conf
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/srs_ue.py
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
5 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/77/17577/1
diff --git a/example/defaults.conf b/example/defaults.conf
index 60539c8..dcb84db 100644
--- a/example/defaults.conf
+++ b/example/defaults.conf
@@ -108,3 +108,5 @@
srsue:
enable_pcap: false
+ airplane_t_on_ms: -1
+ airplane_t_off_ms: -1
diff --git a/example/scenarios/mod-srsue-airplane_mode_sim@.conf
b/example/scenarios/mod-srsue-airplane_mode_sim@.conf
new file mode 100644
index 000..c05fba1
--- /dev/null
+++ b/example/scenarios/mod-srsue-airplane_mode_sim@.conf
@@ -0,0 +1,4 @@
+modifiers:
+ modem:
+- airplane_t_on_ms: ${param1}
+ airplane_t_off_ms: ${param2}
diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py
index 8a93ea4..757a9c5 100644
--- a/src/osmo_gsm_tester/resource.py
+++ b/src/osmo_gsm_tester/resource.py
@@ -106,6 +106,8 @@
'modem[].features[]': schema.MODEM_FEATURE,
'modem[].rf_dev_type': schema.STR,
'modem[].rf_dev_args': schema.STR,
+'modem[].airplane_t_on_ms': schema.INT,
+'modem[].airplane_t_off_ms': schema.INT,
'osmocon_phone[].serial_device': schema.STR,
}
diff --git a/src/osmo_gsm_tester/srs_ue.py b/src/osmo_gsm_tester/srs_ue.py
index fdcd6dd..18545a2 100644
--- a/src/osmo_gsm_tester/srs_ue.py
+++ b/src/osmo_gsm_tester/srs_ue.py
@@ -223,6 +223,10 @@
config.overlay(values, dict(ue=self._conf))
config.overlay(values, dict(ue=dict(num_antennas =
self.enb.num_ports(
+# Get airplane mode params
+config.overlay(values, dict(ue=dict(airplane_t_on_ms =
values['ue'].get('airplane_t_on_ms', ''
+config.overlay(values, dict(ue=dict(airplane_t_off_ms =
values['ue'].get('airplane_t_off_ms', ''
+
# Convert parsed boolean string to Python boolean:
self.enable_pcap = util.str2bool(values['ue'].get('enable_pcap',
'false'))
config.overlay(values, dict(ue={'enable_pcap': self.enable_pcap}))
diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index 91f9277..d833493 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -336,6 +336,21 @@
#force_ul_amplitude = 0
#
+# Simulation configuration options
+#
+# The UE simulation supports turning on and off airplane mode in the UE.
+# The actions are carried periodically until the UE is stopped.
+#
+# airplane_t_on_ms: Time to leave airplane mode turned on (in ms)
+#
+# airplane_t_off_ms: Time to leave airplane mode turned off (in ms)
+#
+#
+[sim]
+airplane_t_on_ms = ${ue.airplane_t_on_ms}
+airplane_t_off_ms = ${ue.airplane_t_off_ms}
+
+#
# General configuration options
#
# metrics_csv_enable: Write UE metrics to CSV file.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17577
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5db2ff325ce4b4236c1ceec0831dd7420d52dedb
Gerrit-Change-Number: 17577
Gerrit-PatchSet: 1
Gerrit-Owner: Andre Puschmann
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: abis_nm.c: rx_fail_evt_rep: fix sd.bts
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17569 ) Change subject: abis_nm.c: rx_fail_evt_rep: fix sd.bts .. Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c@402 PS1, Line 402: sd.bts = bts; > rx_fail_evt_rep(mb, bts) is called by abis_nm_rcvmsg_report(mb, bts), which > is called by abis_nm_rcv […] msgb->trx is not used in osmo-bsc. Rather, it uses msg->dst, which points to an e1inp_sign_link, and not to a TRX. So any code dereferncing msgb->trx inside osmo-bsc must be wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie61512f5690763fa380bdf0e7fb4763dbda019d2 Gerrit-Change-Number: 17569 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 17:32:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: osmith Gerrit-MessageType: comment
Change in osmo-bsc[master]: VTY: add show bts failure report
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17571 ) Change subject: VTY: add show bts failure report .. Patch Set 2: (1 comment) I find the implementation a bit "inteeresting" in that it neither a) uses the raw input data and stores that, only generating strings during "show" time, nor b) reuses the existing libosmocore/strrb.c code for ring-buffers of strings. I would say that either we store the raw/binary report data in some custom structure, but if we convert everything into strings at the time the alarm happens, then I would expect strrb.c to be usable? https://gerrit.osmocom.org/c/osmo-bsc/+/17571/2/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17571/2/src/osmo-bsc/osmo_bsc_main.c@220 PS2, Line 220: entry = talloc_zero(fail_rep->bts, struct bts_oml_fail_rep); please either return NULL if talloc fails, or OSMO_ASSERT() on the result. The further talloc_strdup below result doesn't need to be checked, but if the first allocation fails, we are getting null pointer deref right below. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78 Gerrit-Change-Number: 17571 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 23 Mar 2020 17:28:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: VTY: add show bts failure report
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17571 ) Change subject: VTY: add show bts failure report .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78 Gerrit-Change-Number: 17571 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 23 Mar 2020 17:23:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: csn1: Validate recursive array max size during decoding
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17572 ) Change subject: csn1: Validate recursive array max size during decoding .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9fe0e55e0a6a41ae2cc885fba490c1d4a186231e Gerrit-Change-Number: 17572 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 23 Mar 2020 17:21:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Don't pass array element to CSN1 descriptors
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17574 ) Change subject: rlcmac: Don't pass array element to CSN1 descriptors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f10350d4734360c7a15a702c72b59efd84987ee Gerrit-Change-Number: 17574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 23 Mar 2020 17:20:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: tests/RLCMACTest: Several fixes and improvements to RAcap tests
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17549 ) Change subject: tests/RLCMACTest: Several fixes and improvements to RAcap tests .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1e7f8d8866695732ee24a79d8b54d660fd4f22d5 Gerrit-Change-Number: 17549 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 23 Mar 2020 17:20:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx: do not set rx-gain to 1 by default
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17570 ) Change subject: osmo-bts-trx: do not set rx-gain to 1 by default .. osmo-bts-trx: do not set rx-gain to 1 by default The sample configs supplied within the doc/trx directory set the rx-gain parameter to 1. A low value like this may cause a noticeable degration of rx performance (For an USRP B200 an rx-gain of 38dbm is recommended). Lets remove this seting from the sample configuration to allow the default settings in osmo-trx to be applied. Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Related: OS#4467 --- M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg b/doc/examples/trx/osmo-bts-trx-calypso.cfg index 6b52fd2..3f2e778 100644 --- a/doc/examples/trx/osmo-bts-trx-calypso.cfg +++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg @@ -22,7 +22,6 @@ ! phy 0 instance 0 - osmotrx rx-gain 1 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 osmotrx timing-advance-loop diff --git a/doc/examples/trx/osmo-bts-trx.cfg b/doc/examples/trx/osmo-bts-trx.cfg index 8342697..81313e5 100644 --- a/doc/examples/trx/osmo-bts-trx.cfg +++ b/doc/examples/trx/osmo-bts-trx.cfg @@ -21,7 +21,6 @@ ! phy 0 instance 0 - osmotrx rx-gain 1 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 bts 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Gerrit-Change-Number: 17570 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bts[master]: osmo-bts-trx: do not set rx-gain to 1 by default
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17570 ) Change subject: osmo-bts-trx: do not set rx-gain to 1 by default .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Gerrit-Change-Number: 17570 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 17:18:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx: do not set rx-gain to 1 by default
laforge has uploaded a new patch set (#2) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/17570 ) Change subject: osmo-bts-trx: do not set rx-gain to 1 by default .. osmo-bts-trx: do not set rx-gain to 1 by default The sample configs supplied within the doc/trx directory set the rx-gain parameter to 1. A low value like this may cause a noticeable degration of rx performance (For an USRP B200 an rx-gain of 38dbm is recommended). Lets remove this seting from the sample configuration to allow the default settings in osmo-trx to be applied. Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Related: OS#4467 --- M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/17570/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Gerrit-Change-Number: 17570 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: VTY: add "test-failure-event-report"
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17573 ) Change subject: VTY: add "test-failure-event-report" .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/17573/3/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/17573/3/src/common/vty.c@931 PS3, Line 931: test I would prefer to see 'test' as an individual node, so if someone would need more special commands in the future they all will be grouped properly. That's at least how it's done in OsmocomBB. So 'test send-failure-event-report <0-255>' would be nice to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e Gerrit-Change-Number: 17573 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 17:15:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ggsn[master]: doc: do not use random ip address for dns in default conf
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17576 ) Change subject: doc: do not use random ip address for dns in default conf .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/17576/1/doc/examples/osmo-ggsn.cfg File doc/examples/osmo-ggsn.cfg: https://gerrit.osmocom.org/c/osmo-ggsn/+/17576/1/doc/examples/osmo-ggsn.cfg@47 PS1, Line 47: ip dns 1 8.8.8.8 > hThen better set tis to 8.8.8. […] ACK. Or 1.1.1.1 as an alternative. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5876a806185bb3aea356fb6996d1925b8d0d1758 Gerrit-Change-Number: 17576 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 17:07:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-trx: do not set rx-gain to 1 by default
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17570 ) Change subject: osmo-trx: do not set rx-gain to 1 by default .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/17570/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/17570/1//COMMIT_MSG@7 PS1, Line 7: osmo-trx osmo-bts-trx -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Gerrit-Change-Number: 17570 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 17:04:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Log names of de/encoded rlcmac packet types
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17575 ) Change subject: rlcmac: Log names of de/encoded rlcmac packet types .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a6e79d7e12cd5e8e969bf0eaa30ddac6b0aa7d3 Gerrit-Change-Number: 17575 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 23 Mar 2020 17:01:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Fix bug receiving RA cap
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17548 ) Change subject: rlcmac: Fix bug receiving RA cap .. Patch Set 7: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.cpp File tests/rlcmac/RLCMACTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.cpp@461 PS7, Line 461: Make sure there's 1 value (currently fails due to failed decoding) please update this comment too https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.ok File tests/rlcmac/RLCMACTest.ok: https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.ok@146 PS7, Line 146: decode_gsm_ra_cap() returns 0 to be consistent, I would also print this line from the new test -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 16:59:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: csn1: Validate recursive array max size during decoding
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17572 ) Change subject: csn1: Validate recursive array max size during decoding .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9fe0e55e0a6a41ae2cc885fba490c1d4a186231e Gerrit-Change-Number: 17572 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 23 Mar 2020 16:56:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ggsn[master]: doc: do not use random ip address for dns in default conf
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17576 ) Change subject: doc: do not use random ip address for dns in default conf .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ggsn/+/17576/1/doc/examples/osmo-ggsn.cfg File doc/examples/osmo-ggsn.cfg: https://gerrit.osmocom.org/c/osmo-ggsn/+/17576/1/doc/examples/osmo-ggsn.cfg@47 PS1, Line 47: ip dns 1 8.8.8.8 hThen better set tis to 8.8.8.4 (was it the secondary google dns?) https://gerrit.osmocom.org/c/osmo-ggsn/+/17576/1/doc/examples/osmo-ggsn.cfg@65 PS1, Line 65: ip dns 1 8.8.8.8 Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5876a806185bb3aea356fb6996d1925b8d0d1758 Gerrit-Change-Number: 17576 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 16:49:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Log names of de/encoded rlcmac packet types
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/17575 to look at the new patch set (#2). Change subject: rlcmac: Log names of de/encoded rlcmac packet types .. rlcmac: Log names of de/encoded rlcmac packet types Change-Id: I6a6e79d7e12cd5e8e969bf0eaa30ddac6b0aa7d3 --- M src/gsm_rlcmac.cpp M tests/rlcmac/RLCMACTest.err 2 files changed, 120 insertions(+), 157 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/17575/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a6e79d7e12cd5e8e969bf0eaa30ddac6b0aa7d3 Gerrit-Change-Number: 17575 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-ggsn[master]: doc: do not use random ip address for dns in default conf
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17576 ) Change subject: doc: do not use random ip address for dns in default conf .. doc: do not use random ip address for dns in default conf The default configuration has a random ip-address as first DNS server. This might cause unnedessary trouble for people who try osmo-ggsn the first time. Lets have some public DNS here, just to be sure. Change-Id: I5876a806185bb3aea356fb6996d1925b8d0d1758 --- M doc/examples/osmo-ggsn.cfg 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/76/17576/1 diff --git a/doc/examples/osmo-ggsn.cfg b/doc/examples/osmo-ggsn.cfg index 4000636..22aeb45 100644 --- a/doc/examples/osmo-ggsn.cfg +++ b/doc/examples/osmo-ggsn.cfg @@ -43,7 +43,7 @@ tun-device tun4 type-support v4 ip prefix dynamic 176.16.222.0/24 - ip dns 0 192.168.100.1 + ip dns 0 8.8.8.8 ip dns 1 8.8.8.8 ip ifconfig 176.16.222.0/24 no shutdown @@ -61,7 +61,7 @@ tun-device tun46 type-support v4v6 ip prefix dynamic 176.16.46.0/24 - ip dns 0 192.168.100.1 + ip dns 0 8.8.8.8 ip dns 1 8.8.8.8 ip ifconfig 176.16.46.0/24 ipv6 prefix dynamic 2001:780:44:2100:0:0:0:0/56 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5876a806185bb3aea356fb6996d1925b8d0d1758 Gerrit-Change-Number: 17576 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in osmo-pcu[master]: tests/RLCMACTest: Several fixes and improvements to RAcap tests
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17549 ) Change subject: tests/RLCMACTest: Several fixes and improvements to RAcap tests .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/17549/1/tests/rlcmac/RLCMACTest.cpp File tests/rlcmac/RLCMACTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17549/1/tests/rlcmac/RLCMACTest.cpp@255 PS1, Line 255: (currently fails due to failed decoding) This comment should be removed some day. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1e7f8d8866695732ee24a79d8b54d660fd4f22d5 Gerrit-Change-Number: 17549 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 23 Mar 2020 16:32:34 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Don't pass array element to CSN1 descriptors
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17574 ) Change subject: rlcmac: Don't pass array element to CSN1 descriptors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f10350d4734360c7a15a702c72b59efd84987ee Gerrit-Change-Number: 17574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 23 Mar 2020 16:28:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: VTY: add "test-failure-event-report"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17573 ) Change subject: VTY: add "test-failure-event-report" .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e Gerrit-Change-Number: 17573 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 15:23:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: VTY: add "test-failure-event-report"
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 to look at the new patch set (#3). Change subject: VTY: add "test-failure-event-report" .. VTY: add "test-failure-event-report" Send test failure event report OML message to the BSC. I found this useful while manually testing related handling code in OsmoBSC. Related: OS#1605 Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e --- M src/common/vty.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/17573/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e Gerrit-Change-Number: 17573 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: VTY: add "test-failure-event-report"
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17573 ) Change subject: VTY: add "test-failure-event-report" .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/17573/2/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/17573/2/src/common/vty.c@931 PS2, Line 931: DEFUN(send_failure_event_report, send_failure_event_report_cmd, "send-failure-event-report <0-255>", > probably adding the "test" keyword in the vty command would make it more > clear that it's only to be used for testing. Good idea, done. > I think you can even check that this command is only run under no config node > to make suer it's not added to the vty.cfg file. It is not attached to a config node in bts_vty_init(), so just like "show_bts_cmd" etc an extra check should not be necessary. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e Gerrit-Change-Number: 17573 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 15:09:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bts[master]: VTY: add "send-failure-event-report"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17573 ) Change subject: VTY: add "send-failure-event-report" .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e Gerrit-Change-Number: 17573 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 14:49:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: VTY: add "send-failure-event-report"
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/17573 )
Change subject: VTY: add "send-failure-event-report"
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bts/+/17573/2/src/common/vty.c
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/17573/2/src/common/vty.c@931
PS2, Line 931: DEFUN(send_failure_event_report, send_failure_event_report_cmd,
"send-failure-event-report <0-255>",
probably adding the "test" keyword in the vty command would make it more clear
that it's only to be used for testing.
I think you can even check that this command is only run under no config node
to make suer it's not added to the vty.cfg file.
Something like: if(vty->node == CONFIG_NODE) { vty_Out("not allowed in cfg,
it's for testing"); return CMD_WARNING; }
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e
Gerrit-Change-Number: 17573
Gerrit-PatchSet: 2
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Mon, 23 Mar 2020 14:49:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 )
Change subject: process: add stdin_write method to communicate with child on
stdin
..
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560/3/src/osmo_gsm_tester/process.py
File src/osmo_gsm_tester/process.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560/3/src/osmo_gsm_tester/process.py@358
PS3, Line 358:
self.process_obj.stdin.write("{}".format(cmd).encode("utf-8"))
You can simply use cmd.encode("utf-8") here, right?
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5
Gerrit-Change-Number: 17560
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Puschmann
Gerrit-Reviewer: Andre Puschmann
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Mon, 23 Mar 2020 14:45:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-trx: do not set rx-gain to 1 by default
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17570 ) Change subject: osmo-trx: do not set rx-gain to 1 by default .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Gerrit-Change-Number: 17570 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 14:44:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Don't pass array element to CSN1 descriptors
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17574 ) Change subject: rlcmac: Don't pass array element to CSN1 descriptors .. rlcmac: Don't pass array element to CSN1 descriptors This way the macros can be used to access the arrays themselves and calculate its static size to enable validation later. In the case of Packet_Access_Reject_t, modify the description to use a M_REC_TARRAY_1 object to get rid of access to 2nd element. The new description is the correct one, since the first element is mandatory according to TS 44.060 Table 11.2.1. Change-Id: I6f10350d4734360c7a15a702c72b59efd84987ee --- M src/gsm_rlcmac.cpp 1 file changed, 11 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/74/17574/1 diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp index 40b75ed..db0e54a 100644 --- a/src/gsm_rlcmac.cpp +++ b/src/gsm_rlcmac.cpp @@ -902,7 +902,7 @@ static const CSN_DESCR_BEGIN (Additional_access_technologies_t) - M_REC_TARRAY(Additional_access_technologies_t, Additional_access_technologies[0], Additional_access_technologies_struct_t, Count_additional_access_technologies), + M_REC_TARRAY(Additional_access_technologies_t, Additional_access_technologies, Additional_access_technologies_struct_t, Count_additional_access_technologies), CSN_DESCR_END (Additional_access_technologies_t) gint16 Additional_access_technologies_Dissector(csnStream_t* ar, bitvec* vector, unsigned *readIndex, void* data) @@ -1365,7 +1365,7 @@ static const CSN_DESCR_BEGIN(PSI_Message_List_t) - M_REC_TARRAY (PSI_Message_List_t, PSI_Message[0], PSI_Message_t, Count_PSI_Message), + M_REC_TARRAY (PSI_Message_List_t, PSI_Message, PSI_Message_t, Count_PSI_Message), M_FIXED (PSI_Message_List_t, 1, 0x00), M_UINT (PSI_Message_List_t, ADDITIONAL_MSG_TYPE, 1), CSN_DESCR_END (PSI_Message_List_t) @@ -1402,7 +1402,7 @@ static const CSN_DESCR_BEGIN(SI_Message_List_t) - M_REC_TARRAY (SI_Message_List_t, SI_Message[0], SI_Message_t, Count_SI_Message), + M_REC_TARRAY (SI_Message_List_t, SI_Message, SI_Message_t, Count_SI_Message), M_FIXED (SI_Message_List_t, 1, 0x00), M_UINT (SI_Message_List_t, ADDITIONAL_MSG_TYPE, 1), CSN_DESCR_END (SI_Message_List_t) @@ -2602,8 +2602,7 @@ M_UINT (Packet_Access_Reject_t, MESSAGE_TYPE, 6), M_UINT (Packet_Access_Reject_t, PAGE_MODE, 2), - M_TYPE (Packet_Access_Reject_t, Reject, Reject_t), - M_REC_TARRAY (Packet_Access_Reject_t, Reject[1], Reject_t, Count_Reject), + M_REC_TARRAY_1(Packet_Access_Reject_t, Reject, Reject_t, Count_Reject), M_PADDING_BITS(Packet_Access_Reject_t), CSN_DESCR_END (Packet_Access_Reject_t) @@ -3572,7 +3571,7 @@ M_UINT (ENH_NC_Measurement_Report_t, SCALE, 1), M_NEXT_EXIST (ENH_NC_Measurement_Report_t, Exist_Serving_Cell_Data, 1), M_TYPE (ENH_NC_Measurement_Report_t, Serving_Cell_Data, Serving_Cell_Data_t), - M_REC_TARRAY (ENH_NC_Measurement_Report_t, RepeatedInvalid_BSIC_Info[0], RepeatedInvalid_BSIC_Info_t, Count_RepeatedInvalid_BSIC_Info), + M_REC_TARRAY (ENH_NC_Measurement_Report_t, RepeatedInvalid_BSIC_Info, RepeatedInvalid_BSIC_Info_t, Count_RepeatedInvalid_BSIC_Info), M_NEXT_EXIST (ENH_NC_Measurement_Report_t, Exist_ReportBitmap, 1), M_VAR_TARRAY (ENH_NC_Measurement_Report_t, REPORTING_QUANTITY_Instances, REPORTING_QUANTITY_Instance_t, Count_REPORTING_QUANTITY_Instances), CSN_DESCR_END (ENH_NC_Measurement_Report_t) @@ -3713,7 +3712,7 @@ M_UINT (EnhancedMeasurementReport_t, SCALE, 1), M_NEXT_EXIST(EnhancedMeasurementReport_t, Exist_ServingCellData, 1), M_TYPE (EnhancedMeasurementReport_t, ServingCellData, EMR_ServingCell_t), - M_REC_TARRAY(EnhancedMeasurementReport_t, RepeatedInvalid_BSIC_Info[0], RepeatedInvalid_BSIC_Info_t, + M_REC_TARRAY(EnhancedMeasurementReport_t, RepeatedInvalid_BSIC_Info, RepeatedInvalid_BSIC_Info_t, Count_RepeatedInvalid_BSIC_Info), M_NEXT_EXIST(EnhancedMeasurementReport_t, Exist_ReportBitmap, 1), M_VAR_TARRAY(EnhancedMeasurementReport_t, REPORTING_QUANTITY_Instances, REPORTING_QUANTITY_Instance_t, Count_REPORTING_QUANTITY_Instances), @@ -4472,7 +4471,7 @@ static const CSN_DESCR_BEGIN(NonHoppingPCCCH_t) - M_REC_TARRAY (NonHoppingPCCCH_t, Carriers[0], Non_Hopping_PCCCH_Carriers_t, Count_Carriers), + M_REC_TARRAY (NonHoppingPCCCH_t, Carriers, Non_Hopping_PCCCH_Carriers_t, Count_Carriers), CSN_DESCR_END (NonHoppingPCCCH_t) static const @@ -4484,7 +4483,7 @@ static const CSN_DESCR_BEGIN(HoppingPCCCH_t) M_UINT(HoppingPCCCH_t, MA_NUMBER, 4), - M_REC_TARRAY (HoppingPCCCH_t, Carriers[0], Hopping_PCCCH_Carriers_t, Count_Carriers), + M_REC_TARRAY (HoppingPCCCH_t, Carriers, Hopping_PCCCH_Carriers_t, Count_Carriers), CSN_DESCR_END (HoppingPCCCH_t) static
Change in osmo-pcu[master]: csn1: Validate recursive array max size during decoding
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/17572 to look at the new patch set (#2). Change subject: csn1: Validate recursive array max size during decoding .. csn1: Validate recursive array max size during decoding This way if CSN1 encoded bitstream contains more elements than what the defintion expects it will fail instead of overflowing the decoded buffer. RA cap struct placed in unit test is taken from a real android phone sending the value when attaching to the network. Then SGSN sends it back and osmo-pcu would crash similar to unit test: *** stack smashing detected ***: terminated Process terminating with default action of signal 6 (SIGABRT): dumping core at 0x4C62CE5: raise (in /usr/lib/libc-2.31.so) by 0x4C4C856: abort (in /usr/lib/libc-2.31.so) by 0x4CA62AF: __libc_message (in /usr/lib/libc-2.31.so) by 0x4D36069: __fortify_fail (in /usr/lib/libc-2.31.so) by 0x4D36033: __stack_chk_fail (in /usr/lib/libc-2.31.so) by 0x124706: testRAcap2(void*) (RLCMACTest.cpp:468) Related: OS#4463 Change-Id: I9fe0e55e0a6a41ae2cc885fba490c1d4a186231e --- M src/csn1.c M src/csn1.h M tests/rlcmac/RLCMACTest.cpp M tests/rlcmac/RLCMACTest.err M tests/rlcmac/RLCMACTest.ok 5 files changed, 163 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/72/17572/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9fe0e55e0a6a41ae2cc885fba490c1d4a186231e Gerrit-Change-Number: 17572 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: VTY: add "send-failure-event-report"
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 to look at the new patch set (#2). Change subject: VTY: add "send-failure-event-report" .. VTY: add "send-failure-event-report" Send test failure event report OML message to the BSC. I found this useful while manually testing related handling code in OsmoBSC. Related: OS#1605 Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e --- M src/common/vty.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/17573/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e Gerrit-Change-Number: 17573 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: VTY: add show bts failure report
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/17571 to look at the new patch set (#2). Change subject: VTY: add show bts failure report .. VTY: add show bts failure report Save OML failure reports from each BTS in a ring buffer. Add a VTY command to display them conveniently. OsmoBSC> show bts 0 fail-rep [2020-03-23 14:51:22] Type=processing failure, Severity=minor failure, Probable cause=Manufacturer specific values: Software warning, Additional text=test message sent from VTY [2020-03-23 14:51:19] Type=processing failure, Severity=minor failure, Probable cause=Manufacturer specific values: Software warning, Additional text=test message sent from VTY Related: OS#1605 Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/osmo_bsc_main.c 4 files changed, 90 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/17571/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78 Gerrit-Change-Number: 17571 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: VTY: add "send-failure-event-report"
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/17573 )
Change subject: VTY: add "send-failure-event-report"
..
VTY: add "send-failure-event-report"
Send test failure event report OML message to the BSC. I found this
useful while manually testing related handling code in OsmoBSC.
Related: OS#1605
Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e
---
M src/common/vty.c
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/17573/1
diff --git a/src/common/vty.c b/src/common/vty.c
index ab38dc1..181feb5 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -928,6 +928,22 @@
return CMD_SUCCESS;
}
+DEFUN(send_failure_event_report, send_failure_event_report_cmd,
"send-failure-event-report <0-255>",
+ "Send a test OML failure event report to the BSC\n" BTS_NR_STR)
+{
+ struct gsm_network *net = gsmnet_from_vty(vty);
+ int bts_nr = atoi(argv[0]);
+ struct gsm_bts *bts;
+
+ if (bts_nr >= net->num_bts) {
+ vty_out(vty, "%% can't find BTS '%s'%s", argv[0], VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+
+ bts = gsm_bts_num(net, bts_nr);
+ oml_tx_failure_event_rep(>mo, NM_SEVER_MINOR,
OSMO_EVT_WARN_SW_WARN, "test message sent from VTY");
+}
+
static void trx_dump_vty(struct vty *vty, struct gsm_bts_trx *trx)
{
vty_out(vty, "TRX %u of BTS %u is on ARFCN %u%s",
@@ -1667,6 +1683,7 @@
install_element_ve(_lchan_summary_cmd);
install_element_ve(_fltr_l1_sapi_cmd);
install_element_ve(_logging_fltr_l1_sapi_cmd);
+ install_element_ve(_failure_event_report_cmd);
logging_vty_add_cmds();
osmo_talloc_vty_add_cmds();
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e
Gerrit-Change-Number: 17573
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: csn1: Validate recursive array max size during decoding
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/17572 )
Change subject: csn1: Validate recursive array max size during decoding
..
csn1: Validate recursive array max size during decoding
This way if CSN1 encoded bitstream contains more elements than what the
defintion expects it will fail instead of overflowing the decoded
buffer.
RA cap struct placed in unit test is taken from a real android phone
sending the value when attaching to the network. Then SGSN sends it back
and osmo-pcu would crash similar to unit test:
*** stack smashing detected ***: terminated
Process terminating with default action of signal 6 (SIGABRT): dumping core
at 0x4C62CE5: raise (in /usr/lib/libc-2.31.so)
by 0x4C4C856: abort (in /usr/lib/libc-2.31.so)
by 0x4CA62AF: __libc_message (in /usr/lib/libc-2.31.so)
by 0x4D36069: __fortify_fail (in /usr/lib/libc-2.31.so)
by 0x4D36033: __stack_chk_fail (in /usr/lib/libc-2.31.so)
by 0x124706: testRAcap2(void*) (RLCMACTest.cpp:468)
Related: OS#4463
Change-Id: I9fe0e55e0a6a41ae2cc885fba490c1d4a186231e
---
M src/csn1.c
M src/csn1.h
M tests/rlcmac/RLCMACTest.cpp
M tests/rlcmac/RLCMACTest.err
M tests/rlcmac/RLCMACTest.ok
5 files changed, 160 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/72/17572/1
diff --git a/src/csn1.c b/src/csn1.c
index 296bf6c..e8ee917 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -1281,6 +1281,7 @@
* {t, offsetof(_STRUCT, _ElementCountField),
(void*)CSNDESCR_##_MEMBER_TYPE, offsetof(_STRUCT, _MEMBER), #_MEMBER,
(StreamSerializeFcn_t)sizeof(_MEMBER_TYPE)}
*/
gint16 nSizeElement = (gint16)(gint32)pDescr->value;
+guint32 nSizeArray = (guint32)((uintptr_t)pDescr->aux_fn);
guint8 ElementCount = 0;
pui8 = pui8DATA(data, pDescr->offset);
@@ -1292,6 +1293,12 @@
remaining_bits_len--;
ElementCount++;
+ if (ElementCount > nSizeArray)
+ {
+LOGPC(DCSN1, LOGL_ERROR, "error: %s: too many elements (>%u) in
recursive array. Increase its size! } |", pDescr->sz, nSizeArray);
+return ProcessError(readIndex,"csnStreamDecoder",
CSN_ERROR_STREAM_NOT_SUPPORTED, pDescr);
+ }
+
{ /* unpack the following data structure */
csnStream_t arT = *ar;
gint16 Status;
@@ -1345,6 +1352,7 @@
* {t, offsetof(_STRUCT, _ElementCountField),
(void*)CSNDESCR_##_MEMBER_TYPE, offsetof(_STRUCT, _MEMBER), #_MEMBER,
(StreamSerializeFcn_t)sizeof(_MEMBER_TYPE)}
*/
gint16 nSizeElement = (gint16)(gint32)pDescr->value;
+guint32 nSizeArray = (guint32)((uintptr_t)pDescr->aux_fn);
guint8 ElementCount = 0;
csnStream_t arT = *ar;
gboolean EndOfList= FALSE;
@@ -1355,6 +1363,12 @@
{ /* get data element */
ElementCount++;
+ if (ElementCount > nSizeArray)
+ {
+LOGPC(DCSN1, LOGL_ERROR, "error: %s: too many elements (>%u) in
recursive array. Increase its size! } |", pDescr->sz, nSizeArray);
+return ProcessError(readIndex,"csnStreamDecoder",
CSN_ERROR_STREAM_NOT_SUPPORTED, pDescr);
+ }
+
LOGPC(DCSN1, LOGL_DEBUG, "%s { | ", pDescr->sz);
csnStreamInit(, bit_offset, remaining_bits_len);
diff --git a/src/csn1.h b/src/csn1.h
index b3fdc0a..e4ef867 100644
--- a/src/csn1.h
+++ b/src/csn1.h
@@ -451,7 +451,7 @@
* ::= {1 } ** 0 ;
*/
#define M_REC_TARRAY_1(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)\
-{CSN_RECURSIVE_TARRAY_1, offsetof(_STRUCT, _ElementCountField),
{(const void*)CSNDESCR_##_MEMBER_TYPE}, offsetof(_STRUCT, _MEMBER), FALSE,
#_MEMBER, sizeof(_MEMBER_TYPE), NULL}
+{CSN_RECURSIVE_TARRAY_1, offsetof(_STRUCT, _ElementCountField),
{(const void*)CSNDESCR_##_MEMBER_TYPE}, offsetof(_STRUCT, _MEMBER), FALSE,
#_MEMBER, sizeof(_MEMBER_TYPE), (void_fn_t)ElementsOf(((_STRUCT*)0)->_MEMBER)}
/**
* M_REC_TARRAY2(Par1, Par2, Par3, Par4)
@@ -459,7 +459,7 @@
* ::= { 0 } ** 1 ;
*/
#define M_REC_TARRAY_2(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)\
-{CSN_RECURSIVE_TARRAY_2, offsetof(_STRUCT, _ElementCountField),
{(const void*)CSNDESCR_##_MEMBER_TYPE}, offsetof(_STRUCT, _MEMBER), FALSE,
#_MEMBER, sizeof(_MEMBER_TYPE), NULL}
+{CSN_RECURSIVE_TARRAY_2, offsetof(_STRUCT, _ElementCountField),
{(const void*)CSNDESCR_##_MEMBER_TYPE}, offsetof(_STRUCT, _MEMBER), FALSE,
#_MEMBER, sizeof(_MEMBER_TYPE), (void_fn_t)ElementsOf(((_STRUCT*)0)->_MEMBER)}
/**
* M_TYPE(Par1,
Change in osmo-pcu[master]: rlcmac: Fix bug receiving RA cap
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 to look at the new patch set (#6). Change subject: rlcmac: Fix bug receiving RA cap .. rlcmac: Fix bug receiving RA cap It seems the assumptions regarding maximum number of RA capabilitites in one message were wrong. Doing some rough calculations, each RA capabilitiy value (without extensions) can take around 20ish bits, which means for a message containing up to 52 bytes that quite a lot of different values could be theoretically fed in. Let's be safe and increase the array size to be able to handle all different access technologies listed in See TS 24.008 table 10.5.146 following restrictions: * "The MS Radio Access capability is a type 4 information element, with a maximum length of 52 octets." * "Among the three Access Type Technologies GSM 900-P, GSM 900-E and GSM 900-R only one shall be present." * "the mobile station should provide the relevant radio access capability for either GSM 1800 band OR GSM 1900 band, not both". Wireshark requires similar fix (it's not important though because it currently uses another ad-hoc decoder for RAcap). Related: OS#4463 Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff --- M src/gsm_rlcmac.h M tests/rlcmac/RLCMACTest.cpp M tests/rlcmac/RLCMACTest.err M tests/rlcmac/RLCMACTest.ok 4 files changed, 13 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/48/17548/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: VTY: add show bts failure report
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/17571 )
Change subject: VTY: add show bts failure report
..
VTY: add show bts failure report
Save OML failure reports from each BTS in a ring buffer. Add a VTY
command to display them conveniently.
OsmoBSC> show bts 0 fail-rep
[2020-03-23 14:51:22] Type=processing failure, Severity=minor failure, Probable
cause=Manufacturer specific values: Software warning, Additional text=test
message sent from VTY
[2020-03-23 14:51:19] Type=processing failure, Severity=minor failure, Probable
cause=Manufacturer specific values: Software warning, Additional text=test
message sent from VTY
Related: OS#1605
Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/osmo_bsc_main.c
4 files changed, 90 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/17571/1
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 5afc2cf..b7b6009 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1005,6 +1005,16 @@
uint8_t overflow;
};
+struct bts_oml_fail_rep {
+ struct llist_head list;
+ time_t time;
+ char *event_type;
+ char *severity;
+ char *additional_text;
+ enum abis_nm_pcause_type pcause;
+ enum abis_mm_event_causes cause;
+};
+
/* One BTS */
struct gsm_bts {
/* list header in net->bts_list */
@@ -1267,6 +1277,8 @@
struct bts_smscb_chan_state cbch_basic;
struct bts_smscb_chan_state cbch_extended;
struct osmo_timer_list etws_timer; /* when to stop ETWS PN */
+
+ struct llist_head oml_fail_rep;
};
/* One rejected BTS */
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 39adb21..94aa06c 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -559,6 +559,43 @@
return CMD_SUCCESS;
}
+DEFUN(show_bts_fail_rep, show_bts_fail_rep_cmd, "show bts <0-255> fail-rep",
+ SHOW_STR "Display information about a BTS\n"
+ "BTS number" "OML failure reports")
+{
+ struct gsm_network *net = gsmnet_from_vty(vty);
+ struct llist_head *list;
+ struct bts_oml_fail_rep *entry;
+ int bts_nr;
+
+ bts_nr = atoi(argv[0]);
+ if (bts_nr >= net->num_bts) {
+ vty_out(vty, "%% can't find BTS '%s'%s", argv[0], VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+
+ list = _bts_num(net, bts_nr)->oml_fail_rep;
+ if (llist_empty(list)) {
+ vty_out(vty, "No failure reports received.%s", VTY_NEWLINE);
+ return CMD_SUCCESS;
+ }
+
+ llist_for_each_entry(entry, list, list) {
+ char timestamp[20]; /* format like 2020-03-23 14:24:00 */
+ strftime(timestamp, sizeof(timestamp), "%F %T",
localtime(>time));
+
+ vty_out(vty, "[%s] Type=%s, Severity=%s, ", timestamp,
entry->event_type, entry->severity);
+ vty_out(vty, "Probable cause=%s: ",
get_value_string(abis_nm_pcause_type_names, entry->pcause));
+ if (entry->pcause == NM_PCAUSE_T_MANUF)
+ vty_out(vty, "%s, ",
get_value_string(abis_mm_event_cause_names, entry->cause));
+ else
+ vty_out(vty, "%04X, ", entry->cause);
+ vty_out(vty, "Additional text=%s%s", entry->additional_text,
VTY_NEWLINE);
+ }
+
+ return CMD_SUCCESS;
+}
+
DEFUN(show_rejected_bts, show_rejected_bts_cmd, "show rejected-bts",
SHOW_STR "Display recently rejected BTS devices\n")
{
@@ -5272,6 +5309,7 @@
install_element_ve(_show_net_cmd);
install_element_ve(_bts_cmd);
+ install_element_ve(_bts_fail_rep_cmd);
install_element_ve(_rejected_bts_cmd);
install_element_ve(_trx_cmd);
install_element_ve(_trx_con_cmd);
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index f12b032..fe421a4 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -881,6 +881,7 @@
INIT_LLIST_HEAD(>abis_queue);
INIT_LLIST_HEAD(>loc_list);
INIT_LLIST_HEAD(>local_neighbors);
+ INIT_LLIST_HEAD(>oml_fail_rep);
/* Enable all codecs by default. These get reset to a more fine grained
selection IF a
* 'codec-support' config appears in the config file (see bsc_vty.c). */
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index bf68c9b..a968c97 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -205,16 +205,55 @@
return 0;
}
+/* Callback function for FAIL REPORT on the OML NM: save to ringbuffer, so it
can be read from VTY */
+static int oml_msg_fail_rep(struct nm_fail_rep_signal_data *fail_rep)
+{
+ struct llist_head
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 to look at the new patch set (#3). Change subject: process: add stdin_write method to communicate with child on stdin .. process: add stdin_write method to communicate with child on stdin Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 --- M src/osmo_gsm_tester/process.py 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/60/17560/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 3 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: osmo-trx: do not set rx-gain to 1 by default
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/17570 ) Change subject: osmo-trx: do not set rx-gain to 1 by default .. osmo-trx: do not set rx-gain to 1 by default The sample configs supplied within the doc/trx directory set the rx-gain parameter to 1. A low value like this may cause a noticeable degration of rx performance (For an USRP B200 an rx-gain of 38dbm is recommended). Lets remove this seting from the sample configuration to allow the default settings in osmo-trx to be applied. Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Related: OS#4467 --- M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/17570/1 diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg b/doc/examples/trx/osmo-bts-trx-calypso.cfg index 6b52fd2..3f2e778 100644 --- a/doc/examples/trx/osmo-bts-trx-calypso.cfg +++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg @@ -22,7 +22,6 @@ ! phy 0 instance 0 - osmotrx rx-gain 1 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 osmotrx timing-advance-loop diff --git a/doc/examples/trx/osmo-bts-trx.cfg b/doc/examples/trx/osmo-bts-trx.cfg index 8342697..81313e5 100644 --- a/doc/examples/trx/osmo-bts-trx.cfg +++ b/doc/examples/trx/osmo-bts-trx.cfg @@ -21,7 +21,6 @@ ! phy 0 instance 0 - osmotrx rx-gain 1 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 bts 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76be1739b638b3c1b0de5ac667eed53397631caa Gerrit-Change-Number: 17570 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: fix lookup table for maximum DL/UL rate for srsENB
Andre Puschmann has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17534 )
Change subject: fix lookup table for maximum DL/UL rate for srsENB
..
fix lookup table for maximum DL/UL rate for srsENB
Change-Id: Ieb027eaf5d8f4d774d0e29207f7a3b75dec6ee5b
---
M src/osmo_gsm_tester/srs_enb.py
1 file changed, 11 insertions(+), 12 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo_gsm_tester/srs_enb.py b/src/osmo_gsm_tester/srs_enb.py
index 14e2db4..940665e 100644
--- a/src/osmo_gsm_tester/srs_enb.py
+++ b/src/osmo_gsm_tester/srs_enb.py
@@ -254,20 +254,19 @@
return 2
def ue_max_rate(self, downlink=True):
-# The max rate for a single UE per PRB in TM1
-max_phy_rate_tm1_dl = { 6 : 2.3e6,
- 15 : 8e6,
- 25 : 16e6,
+# The max rate for a single UE per PRB configuration in TM1
+max_phy_rate_tm1_dl = { 6 : 3.5e6,
+ 15 : 11e6,
+ 25 : 18e6,
50 : 36e6,
- 75 : 54e6,
+ 75 : 55e6,
100 : 75e6 }
-# TODO: proper values for this table:
-max_phy_rate_tm1_ul = { 6 : 0.23e6,
- 15 : 0.8e6,
- 25 : 1.6e6,
- 50 : 3.6e6,
- 75 : 5.4e6,
- 100 : 7.5e6 }
+max_phy_rate_tm1_ul = { 6 : 0.9e6,
+ 15 : 4.7e6,
+ 25 : 10e6,
+ 50 : 23e6,
+ 75 : 34e6,
+ 100 : 51e6 }
if downlink:
max_rate = max_phy_rate_tm1_dl[self.num_prb()]
else:
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17534
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ieb027eaf5d8f4d774d0e29207f7a3b75dec6ee5b
Gerrit-Change-Number: 17534
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Puschmann
Gerrit-Reviewer: Andre Puschmann
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: relax max_rate for iperf UL/DL tests
Andre Puschmann has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17535 ) Change subject: relax max_rate for iperf UL/DL tests .. relax max_rate for iperf UL/DL tests Change-Id: Ia243156931918d5ab013c64c37823bc2e400798e --- M suites/4g/iperf3_dl.py M suites/4g/iperf3_ul.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/suites/4g/iperf3_dl.py b/suites/4g/iperf3_dl.py index c98251b..38a3891 100755 --- a/suites/4g/iperf3_dl.py +++ b/suites/4g/iperf3_dl.py @@ -44,6 +44,6 @@ print_results(iperf3cli.get_results(), iperf3srv.get_results()) max_rate = enb.ue_max_rate(downlink=True) -res_str = ue.verify_metric(max_rate * 0.9, operation='avg', metric='dl_brate', criterion='gt') +res_str = ue.verify_metric(max_rate * 0.8, operation='avg', metric='dl_brate', criterion='gt') print(res_str) test.set_report_stdout(res_str) diff --git a/suites/4g/iperf3_ul.py b/suites/4g/iperf3_ul.py index fe963a9..f467696 100755 --- a/suites/4g/iperf3_ul.py +++ b/suites/4g/iperf3_ul.py @@ -44,6 +44,6 @@ print_results(iperf3cli.get_results(), iperf3srv.get_results()) max_rate = enb.ue_max_rate(downlink=False) -res_str = ue.verify_metric(max_rate * 0.9, operation='avg', metric='ul_brate', criterion='gt') +res_str = ue.verify_metric(max_rate * 0.8, operation='avg', metric='ul_brate', criterion='gt') print(res_str) test.set_report_stdout(res_str) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ia243156931918d5ab013c64c37823bc2e400798e Gerrit-Change-Number: 17535 Gerrit-PatchSet: 2 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: srsenb.conf.tmpl: update to new version
Andre Puschmann has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17533 ) Change subject: srsenb.conf.tmpl: update to new version .. srsenb.conf.tmpl: update to new version Change-Id: I204d03307aaaddcb15fed6f7310b64d09c43f64c --- M src/osmo_gsm_tester/templates/srsenb.conf.tmpl 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo_gsm_tester/templates/srsenb.conf.tmpl b/src/osmo_gsm_tester/templates/srsenb.conf.tmpl index d28d255..51afcce 100644 --- a/src/osmo_gsm_tester/templates/srsenb.conf.tmpl +++ b/src/osmo_gsm_tester/templates/srsenb.conf.tmpl @@ -135,10 +135,11 @@ # # max_aggr_level:Optional maximum aggregation level index (l=log2(L) can be 0, 1, 2 or 3) # pdsch_mcs: Optional fixed PDSCH MCS (ignores reported CQIs if specified) -# pdsch_max_mcs: Optional PDSCH MCS limit +# pdsch_max_mcs: Optional PDSCH MCS limit # pusch_mcs: Optional fixed PUSCH MCS (ignores reported CQIs if specified) -# pusch_max_mcs: Optional PUSCH MCS limit -# #nof_ctrl_symbols: Number of control symbols +# pusch_max_mcs: Optional PUSCH MCS limit +# min_nof_ctrl_symbols: Minimum number of control symbols +# max_nof_ctrl_symbols: Maximum number of control symbols # # [scheduler] @@ -146,8 +147,9 @@ #pdsch_mcs= -1 #pdsch_max_mcs= -1 #pusch_mcs= -1 -pusch_max_mcs= 16 -nof_ctrl_symbols = 3 +#pusch_max_mcs= 16 +#min_nof_ctrl_symbols = 1 +#max_nof_ctrl_symbols = 3 # # eMBMS configuration options -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I204d03307aaaddcb15fed6f7310b64d09c43f64c Gerrit-Change-Number: 17533 Gerrit-PatchSet: 2 Gerrit-Owner: Andre Puschmann Gerrit-Reviewer: Andre Puschmann Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: abis_nm.c: rx_fail_evt_rep: fix sd.bts
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17569 ) Change subject: abis_nm.c: rx_fail_evt_rep: fix sd.bts .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c@402 PS1, Line 402: sd.bts = bts; > The important question is: why does not it point to the BTS? rx_fail_evt_rep(mb, bts) is called by abis_nm_rcvmsg_report(mb, bts), which is called by abis_nm_rcvmsg_fom(mb). abis_nm_rcvmsg_fom(mb) saves the extra bts pointer with a comment noting, that osmo_signal_dispatch may free mb->dst. That seems somewhat related... https://git.osmocom.org/osmo-bsc/commit/?id=74b2028167ddf04a867ae9f269bfa3435c93f252 But I'm not so familiar with the code, maybe laforge or fixeria know a better answer? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie61512f5690763fa380bdf0e7fb4763dbda019d2 Gerrit-Change-Number: 17569 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 12:45:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 ) Change subject: process: add stdin_write method to communicate with child on stdin .. Patch Set 2: > Patch Set 2: > > Regarding communicate(), it's not clear whether default timeout=None behavior > is to return immediately or wait forever, so we'd need to know that. > https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate > > According to > https://stackoverflow.com/questions/1191374/using-module-subprocess-with-timeout > it's waiting forever, so that's not what we want here. We should therefore > go for using Peopn.stdin directly. Fine by me. I can convert it. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Mon, 23 Mar 2020 12:34:51 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Reproduce and fix stack smashing bug receiving RA cap
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17548 ) Change subject: rlcmac: Reproduce and fix stack smashing bug receiving RA cap .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 12:22:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: rlcmac: Reproduce and fix stack smashing bug receiving RA cap
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 to look at the new patch set (#5). Change subject: rlcmac: Reproduce and fix stack smashing bug receiving RA cap .. rlcmac: Reproduce and fix stack smashing bug receiving RA cap RA cap struct placed in unit test is taken from a real android phone sending the value when attaching to the network. Then SGSN sends it back and osmo-pcu would crash similar to unit test: *** stack smashing detected ***: terminated Process terminating with default action of signal 6 (SIGABRT): dumping core at 0x4C62CE5: raise (in /usr/lib/libc-2.31.so) by 0x4C4C856: abort (in /usr/lib/libc-2.31.so) by 0x4CA62AF: __libc_message (in /usr/lib/libc-2.31.so) by 0x4D36069: __fortify_fail (in /usr/lib/libc-2.31.so) by 0x4D36033: __stack_chk_fail (in /usr/lib/libc-2.31.so) by 0x124706: testRAcap2(void*) (RLCMACTest.cpp:468) So it seems the assumptions regarding maximum number of RA capabilitites in one message were wrong. Doing some rough calculations, each RA capabilitiy value (without extensions) can take around 20ish bits, which means for a message containing up to 52 bytes that quite a lot of different values could be theoretically fed in. Let's be safe and increase the array size to be able to handle all different access technologies listed in See TS 24.008 table 10.5.146 following restrictions: * "The MS Radio Access capability is a type 4 information element, with a maximum length of 52 octets." * "Among the three Access Type Technologies GSM 900-P, GSM 900-E and GSM 900-R only one shall be present." * "the mobile station should provide the relevant radio access capability for either GSM 1800 band OR GSM 1900 band, not both". Wireshark requires similar fix (it's not important though because it currently uses another ad-hoc decoder for RAcap). Related: OS#4463 Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff --- M src/gsm_rlcmac.h M tests/rlcmac/RLCMACTest.cpp M tests/rlcmac/RLCMACTest.err M tests/rlcmac/RLCMACTest.ok 4 files changed, 153 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/48/17548/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: rlcmac: Reproduce and fix stack smashing bug receiving RA cap
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 to look at the new patch set (#4). Change subject: rlcmac: Reproduce and fix stack smashing bug receiving RA cap .. rlcmac: Reproduce and fix stack smashing bug receiving RA cap RA cap struct placed in unit test is taken from a real android phone sending the value when attaching to the network. Then SGSN sends it back and osmo-pcu would crash similar to unit test: *** stack smashing detected ***: terminated Process terminating with default action of signal 6 (SIGABRT): dumping core at 0x4C62CE5: raise (in /usr/lib/libc-2.31.so) by 0x4C4C856: abort (in /usr/lib/libc-2.31.so) by 0x4CA62AF: __libc_message (in /usr/lib/libc-2.31.so) by 0x4D36069: __fortify_fail (in /usr/lib/libc-2.31.so) by 0x4D36033: __stack_chk_fail (in /usr/lib/libc-2.31.so) by 0x124706: testRAcap2(void*) (RLCMACTest.cpp:468) So it seems the assumptions regarding maximum number of RA capabilitites in one message were wrong. Doing some rough calculations, each RA capabilitiy value (without extensions) can take around 20ish bits, which means for a message containing up to 52 bytes that quite a lot of different values could be theoretically fed in. Let's be safe and increase the array size to be able to handle all different access technologies listed in See TS 24.008 table 10.5.146 following restrictions: * "The MS Radio Access capability is a type 4 information element, with a maximum length of 52 octets." * "Among the three Access Type Technologies GSM 900-P, GSM 900-E and GSM 900-R only one shall be present." * "the mobile station should provide the relevant radio access capability for either GSM 1800 band OR GSM 1900 band, not both". Wireshark requires similar fix (it's not important though because it currently uses another ad-hoc decoder for RAcap). Related: OS#4463 Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff --- M src/gsm_rlcmac.h M tests/rlcmac/RLCMACTest.cpp M tests/rlcmac/RLCMACTest.err M tests/rlcmac/RLCMACTest.ok 4 files changed, 153 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/48/17548/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff Gerrit-Change-Number: 17548 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: abis_nm.c: rx_fail_evt_rep: fix sd.bts
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17569 ) Change subject: abis_nm.c: rx_fail_evt_rep: fix sd.bts .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie61512f5690763fa380bdf0e7fb4763dbda019d2 Gerrit-Change-Number: 17569 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 11:47:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_nm.c: rx_fail_evt_rep: fix sd.bts
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17569 ) Change subject: abis_nm.c: rx_fail_evt_rep: fix sd.bts .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c@402 PS1, Line 402: sd.bts = bts; The important question is: why does not it point to the BTS? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie61512f5690763fa380bdf0e7fb4763dbda019d2 Gerrit-Change-Number: 17569 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 23 Mar 2020 11:43:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_nm.c: rx_fail_evt_rep: fix sd.bts
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17569 ) Change subject: abis_nm.c: rx_fail_evt_rep: fix sd.bts .. abis_nm.c: rx_fail_evt_rep: fix sd.bts Use the extra bts pointer instead of mb->trx->bts, which does not point to an allocated bts. Related: OS#1605 Change-Id: Ie61512f5690763fa380bdf0e7fb4763dbda019d2 --- M src/osmo-bsc/abis_nm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/17569/1 diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index a874b53..2d181e8 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -399,7 +399,7 @@ rc = -EINVAL; } - sd.bts = mb->trx->bts; + sd.bts = bts; sd.msg = mb; sd.tp = if (e_type) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie61512f5690763fa380bdf0e7fb4763dbda019d2 Gerrit-Change-Number: 17569 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 ) Change subject: process: add stdin_write method to communicate with child on stdin .. Patch Set 2: Regarding communicate(), it's not clear whether default timeout=None behavior is to return immediately or wait forever, so we'd need to know that. https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate According to https://stackoverflow.com/questions/1191374/using-module-subprocess-with-timeout it's waiting forever, so that's not what we want here. We should therefore go for using Peopn.stdin directly. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Mon, 23 Mar 2020 10:19:58 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: process: add stdin_write method to communicate with child on stdin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 ) Change subject: process: add stdin_write method to communicate with child on stdin .. Patch Set 2: See https://docs.python.org/3/library/subprocess.html#subprocess.Popen.stdin -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I3e5d843911998bb50726d93e3dfd3de584dc81a5 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Mon, 23 Mar 2020 10:14:53 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
