Build failure of network:osmocom:nightly/libosmocore in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/armv7l

Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  744s] |   CONFIG_LINKS= 
[  744s] |   CONFIG_COMMANDS = 
[  744s] |   $ ./config.status Doxyfile.core
[  744s] | 
[  744s] | on obs-arm-5
[  744s] | 
[  744s] | config.status:1341: creating Doxyfile.core
[  744s] 
[  744s] # -*- compilation -*-
[  744s] 59. testsuite.at:372: testing exec ...
[  744s] ./testsuite.at:376: $abs_top_builddir/tests/exec/exec_test
[  744s] --- experr 2020-05-01 01:40:36.96000 +
[  744s] +++ /usr/src/packages/BUILD/tests/testsuite.dir/at-groups/59/stderr
2020-05-01 01:40:36.96000 +
[  744s] @@ -1 +0,0 @@
[  744s] -MAHLZEIT=spaet
[  744s] 59. testsuite.at:372: 59. exec (testsuite.at:372): FAILED 
(testsuite.at:376)
[  744s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  744s] make[1]: *** [override_dh_auto_test] Error 1
[  744s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  744s] debian/rules:15: recipe for target 'build' failed
[  744s] make: *** [build] Error 2
[  744s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  744s] ### VM INTERACTION START ###
[  746s] [  728.341575] sysrq: SysRq : Power Off
[  746s] [  728.343579] reboot: Power down
[  746s] ### VM INTERACTION END ###
[  746s] 
[  746s] obs-arm-5 failed "build libosmocore_1.3.0.72.d87d.dsc" at Fri May  1 
01:40:42 UTC 2020.
[  746s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..

pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data block

Even if we don't accept it, let's submit GSMTAP with correct channel.
We don't return error like in code below, because otherwise the generic
UNKNOWN gsmtap message will be sent.

Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
---
M src/pdch.cpp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/pdch.cpp b/src/pdch.cpp
index f46acc8..77be1b5 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -793,14 +793,14 @@
 * control blocks (see 44.060, section 10.3, 1st par.)
 */
if (mcs_is_edge(cs)) {
+   bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_EGPRS, true, trx_no(), 
ts_no, GSMTAP_CHANNEL_PDTCH, fn,
+  data, data_len);
if (!bts()->bts_data()->egprs_enabled) {
LOGP(DRLCMACUL, LOGL_ERROR,
"Got %s RLC block but EGPRS is not enabled\n",
mcs_name(cs));
-   return -EINVAL;
+   return 0;
}
-   bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_EGPRS, true, trx_no(), 
ts_no, GSMTAP_CHANNEL_PDTCH, fn,
-  data, data_len);
} else {
bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_GPRS, true, trx_no(), 
ts_no, GSMTAP_CHANNEL_PDTCH, fn,
   data, data_len);

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-MessageType: merged

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..


Patch Set 1: Code-Review+2

+1+1=+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Thu, 30 Apr 2020 19:11:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap...

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17982 )

Change subject: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown 
gsmtap blocks
..

pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap blocks

It's actually counter-productive when analyzing wireshark traces, since
one may not spot a decoding issue and assume PACCH is sent on the wrong
TS.

Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
---
M src/pcu_l1_if.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 37a0705..30d22bd 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -347,7 +347,7 @@

if (rc < 0 && (bts->gsmtap_categ_mask & (1 arfcn | 
GSMTAP_ARFCN_F_UPLINK, data_ind->ts_nr,
-   GSMTAP_CHANNEL_PACCH, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
+   GSMTAP_CHANNEL_UNKNOWN, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
}

return rc;

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17982
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: RLCMAC_Templates: Add functions to convert HeaderType<->MCS<->CPS

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17991

to look at the new patch set (#2).

Change subject: RLCMAC_Templates: Add functions to convert 
HeaderType<->MCS<->CPS
..

RLCMAC_Templates: Add functions to convert HeaderType<->MCS<->CPS

They will be used by tests, templates and RLCMAC_EncDec.cc itself.

MCS HEader Type 1 and 2 to CPS conversion lefts as a TODO with
placeholder functions to easily implement when needed.

Change-Id: I18ff55a8067165bf081bf21473b4f88af955bf5b
---
M library/RLCMAC_Templates.ttcn
M library/RLCMAC_Types.ttcn
2 files changed, 177 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/91/17991/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17991
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I18ff55a8067165bf081bf21473b4f88af955bf5b
Gerrit-Change-Number: 17991
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDEc.cc: Fix encoding of tfi and rsb fields in Egprs Ul Hdea...

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17988 )


Change subject: RLCMAC_EncDEc.cc: Fix encoding of tfi and rsb fields in Egprs 
Ul HdeaderType3
..

RLCMAC_EncDEc.cc: Fix encoding of tfi and rsb fields in Egprs Ul HdeaderType3

Change-Id: Id0f7cb29cf3a30aafdaaed2aca7d34277e3c975d
---
M library/RLCMAC_EncDec.cc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/88/17988/1

diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index 952e2e6..88138c6 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -1040,13 +1040,13 @@
egprs3.si = bs2uint8(si.foi__si());
egprs3.cv = si.countdown();
egprs3.tfi_hi = si.tfi() >> 0;
-   egprs3.tfi_lo = si.tfi() >> 1;
+   egprs3.tfi_lo = si.tfi() >> 2;
egprs3.bsn1_hi = si.bsn1() >> 0;
egprs3.bsn1_lo = si.bsn1() >> 5;
egprs3.cps_hi = si.cps() >> 0;
egprs3.cps_lo = si.cps() >> 2;
egprs3.spb = bs2uint8(si.spb());
-   egprs3.rsb = bs2uint8(si.spb());
+   egprs3.rsb = bs2uint8(si.rsb());
egprs3.pi = si.pfi__ind();
egprs3.spare = 0;
egprs3.dummy = 0;

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17988
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id0f7cb29cf3a30aafdaaed2aca7d34277e3c975d
Gerrit-Change-Number: 17988
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDEc.cc: Use copied structure as other parts of the function

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17989 )


Change subject: RLCMAC_EncDEc.cc: Use copied structure as other parts of the 
function
..

RLCMAC_EncDEc.cc: Use copied structure as other parts of the function

Change-Id: Iffe45b3d220c0f95f1fdb54e1b90f0a0cef88ee3
---
M library/RLCMAC_EncDec.cc
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/89/17989/1

diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index 88138c6..f5564d8 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -1078,13 +1078,13 @@

switch (in.mac__hdr().header__type()) {
case EgprsHeaderType::RLCMAC__HDR__TYPE__1:
-   enc__RlcmacUlEgprsDataHeader_type1(si.mac__hdr(), ttcn_buffer);
+   enc__RlcmacUlEgprsDataHeader_type1(in.mac__hdr(), ttcn_buffer);
break;
case EgprsHeaderType::RLCMAC__HDR__TYPE__2:
-   enc__RlcmacUlEgprsDataHeader_type2(si.mac__hdr(), ttcn_buffer);
+   enc__RlcmacUlEgprsDataHeader_type2(in.mac__hdr(), ttcn_buffer);
break;
case EgprsHeaderType::RLCMAC__HDR__TYPE__3:
-   enc__RlcmacUlEgprsDataHeader_type3(si.mac__hdr(), ttcn_buffer);
+   enc__RlcmacUlEgprsDataHeader_type3(in.mac__hdr(), ttcn_buffer);
default:
break; /* TODO: error */
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iffe45b3d220c0f95f1fdb54e1b90f0a0cef88ee3
Gerrit-Change-Number: 17989
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RLCMAC_Templates: Add functions to convert HeaderType<->MCS<->CPS

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17991 )


Change subject: RLCMAC_Templates: Add functions to convert 
HeaderType<->MCS<->CPS
..

RLCMAC_Templates: Add functions to convert HeaderType<->MCS<->CPS

They will be used by tests, templates and RLCMAC_EncDec.cc itself.

MCS HEader Type 1 and 2 to CPS conversion lefts as a TODO with
placeholder functions to easily implement when needed.

Change-Id: I18ff55a8067165bf081bf21473b4f88af955bf5b
---
M library/RLCMAC_Templates.ttcn
1 file changed, 176 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/91/17991/1

diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn
index 8fb6b0c..d2174d7 100644
--- a/library/RLCMAC_Templates.ttcn
+++ b/library/RLCMAC_Templates.ttcn
@@ -29,6 +29,22 @@
return 0;
}

+   function f_rlcmac_mcs2headertype(CodingScheme mcs) return 
EgprsHeaderType {
+   select (mcs) {
+   case (MCS_0) { return RLCMAC_HDR_TYPE_3; }
+   case (MCS_1) { return RLCMAC_HDR_TYPE_3; }
+   case (MCS_2) { return RLCMAC_HDR_TYPE_3; }
+   case (MCS_3) { return RLCMAC_HDR_TYPE_3; }
+   case (MCS_4) { return RLCMAC_HDR_TYPE_3; }
+   case (MCS_5) { return RLCMAC_HDR_TYPE_2; }
+   case (MCS_6) { return RLCMAC_HDR_TYPE_2; }
+   case (MCS_7) { return RLCMAC_HDR_TYPE_1; }
+   case (MCS_8) { return RLCMAC_HDR_TYPE_1; }
+   case (MCS_9) { return RLCMAC_HDR_TYPE_1; }
+   }
+   return RLCMAC_HDR_TYPE_3;
+   }
+
function f_rlcmac_cs_mcs2block_len(CodingScheme cs_mcs) return uint32_t 
{
select (cs_mcs) {
case (CS_1) { return 23; }
@@ -72,6 +88,166 @@
return CS_1;
}

+   /* Coding and Puncturing Scheme indicator field for Header type 1 in 
EGPRS TBF or EC TBF or downlink EGPRS2 TBF */
+   function f_rlcmac_cps_htype1_to_mcs(uint3_t cps) return CodingScheme {
+   var CodingSchemeArray 
egprs_Header_type1_coding_puncturing_scheme_to_mcs := {
+   MCS_9 /* 0x00, "(MCS-9/P1 ; MCS-9/P1)" */,
+   MCS_9 /* 0x01, "(MCS-9/P1 ; MCS-9/P2)" */,
+   MCS_9 /* 0x02, "(MCS-9/P1 ; MCS-9/P3)" */,
+   MCS_0 /* 0x03, "reserved" */,
+   MCS_9 /* 0x04, "(MCS-9/P2 ; MCS-9/P1)" */,
+   MCS_9 /* 0x05, "(MCS-9/P2 ; MCS-9/P2)" */,
+   MCS_9 /* 0x06, "(MCS-9/P2 ; MCS-9/P3)" */,
+   MCS_0 /* 0x07, "reserved" */,
+   MCS_9 /* 0x08, "(MCS-9/P3 ; MCS-9/P1)" */,
+   MCS_9 /* 0x09, "(MCS-9/P3 ; MCS-9/P2)" */,
+   MCS_9 /* 0x0A, "(MCS-9/P3 ; MCS-9/P3)" */,
+   MCS_8 /* 0x0B, "(MCS-8/P1 ; MCS-8/P1)" */,
+   MCS_8 /* 0x0C, "(MCS-8/P1 ; MCS-8/P2)" */,
+   MCS_8 /* 0x0D, "(MCS-8/P1 ; MCS-8/P3)" */,
+   MCS_8 /* 0x0E, "(MCS-8/P2 ; MCS-8/P1)" */,
+   MCS_8 /* 0x0F, "(MCS-8/P2 ; MCS-8/P2)" */,
+   MCS_8 /* 0x10, "(MCS-8/P2 ; MCS-8/P3)" */,
+   MCS_8 /* 0x11, "(MCS-8/P3 ; MCS-8/P1)" */,
+   MCS_8 /* 0x12, "(MCS-8/P3 ; MCS-8/P2)" */,
+   MCS_8 /* 0x13, "(MCS-8/P3 ; MCS-8/P3)" */,
+   MCS_7 /* 0x14, "(MCS-7/P1 ; MCS-7/P1)" */,
+   MCS_7 /* 0x15, "(MCS-7/P1 ; MCS-7/P2)" */,
+   MCS_7 /* 0x16, "(MCS-7/P1 ; MCS-7/P3)" */,
+   MCS_7 /* 0x17, "(MCS-7/P2 ; MCS-7/P1)" */,
+   MCS_7 /* 0x18, "(MCS-7/P2 ; MCS-7/P2)" */,
+   MCS_7 /* 0x19, "(MCS-7/P2 ; MCS-7/P3)" */,
+   MCS_7 /* 0x1A, "(MCS-7/P3 ; MCS-7/P1)" */,
+   MCS_7 /* 0x1B, "(MCS-7/P3 ; MCS-7/P2)" */,
+   MCS_7 /* 0x1C, "(MCS-7/P3 ; MCS-7/P3)" */,
+   MCS_0 /* 0x1D, "reserved" */,
+   MCS_0 /* 0x1E, "reserved" */,
+   MCS_0 /* 0x1F, "reserved" */
+   };
+   return egprs_Header_type1_coding_puncturing_scheme_to_mcs[cps];
+   }
+
+   /* Coding and Puncturing Scheme indicator field for Header type 2 in 
(EC-)EGPRS TBF or uplink EGPRS2-A TBF */
+   function f_rlcmac_cps_htype2_to_mcs(uint3_t cps) return CodingScheme {
+   var CodingSchemeArray 
egprs_Header_type2_coding_puncturing_scheme_to_mcs := {
+   MCS_6 /* {0x00, "MCS-6/P1"} */,
+   MCS_6 /* {0x01, "MCS-6/P2"} */,
+   MCS_6 /* {0x02, "MCS-6/P1 with 6 octet padding"} */,
+   MCS_6 /* {0x03, "MCS-6/P2 with 6 

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDEc.cc: Support decoding Egprs Ul Data HeaderType2

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17990 )


Change subject: RLCMAC_EncDEc.cc: Support decoding Egprs Ul Data HeaderType2
..

RLCMAC_EncDEc.cc: Support decoding Egprs Ul Data HeaderType2

Change-Id: I4dfc994beb7d0ee5522770651150c77701c573fe
---
M library/RLCMAC_EncDec.cc
1 file changed, 21 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/90/17990/1

diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index f5564d8..8f3ff2f 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -673,10 +673,30 @@
 static
 EgprsUlMacDataHeader dec__EgprsUlMacDataHeader_type3(const OCTETSTRING& stream)
 {
+   TTCN_Buffer ttcn_buffer(stream);
EgprsUlMacDataHeader ret_val;
+   const struct gprs_rlc_ul_header_egprs_3 *egprs3;
+   uint8_t tmp;

-   fprintf(stderr, "FIXME: Not implemented! %s (%s:%u)\n", __func__, 
__FILE__, __LINE__);
+   egprs3 = static_cast
+   ((const void *)ttcn_buffer.get_data());

+   ret_val.header__type() = EgprsHeaderType::RLCMAC__HDR__TYPE__3;
+   ret_val.tfi() = egprs3->tfi_lo << 2 | egprs3->tfi_hi << 0;
+   ret_val.countdown() = egprs3->cv;
+   tmp = egprs3->si;
+   ret_val.foi__si() = BITSTRING(1, );
+   tmp = egprs3->r;
+   ret_val.r__ri() = BITSTRING(1, );
+   ret_val.bsn1() = egprs3->bsn1_lo << 5 | egprs3->bsn1_hi << 0;
+   ret_val.cps() = egprs3->cps_lo << 2 | egprs3->cps_hi << 0;
+   ret_val.pfi__ind() = egprs3->pi;
+   tmp = egprs3->rsb;
+   ret_val.rsb() = BITSTRING(1, );
+   tmp = egprs3->spb;
+   ret_val.spb() = BITSTRING(2, );
+
+   ttcn_buffer.increase_pos(sizeof(*egprs3));
return ret_val;
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17990
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4dfc994beb7d0ee5522770651150c77701c573fe
Gerrit-Change-Number: 17990
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDEc.cc: Fix wrong descriptors passed to RAW encoder

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17987 )


Change subject: RLCMAC_EncDEc.cc: Fix wrong descriptors passed to RAW encoder
..

RLCMAC_EncDEc.cc: Fix wrong descriptors passed to RAW encoder

Change-Id: Ieb061d2914be086791e264a78ae14d3d55e10815
---
M library/RLCMAC_EncDec.cc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/87/17987/1

diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index d544e69..952e2e6 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -743,7 +743,7 @@
}
/* parse optional PFI */
if (ret_val.mac__hdr().pfi__ind()) {
-   ret_val.pfi().decode(RlcmacUlDataBlock_pfi_descr_, 
aligned_buffer, TTCN_EncDec::CT_RAW);
+   ret_val.pfi().decode(RlcmacUlEgprsDataBlock_pfi_descr_, 
aligned_buffer, TTCN_EncDec::CT_RAW);
} else {
ret_val.pfi() = OMIT_VALUE;
}
@@ -1130,7 +1130,7 @@
}

if (in.mac__hdr().pfi__ind()) {
-   in.pfi().encode(RlcmacUlDataBlock_pfi_descr_, ttcn_buffer, 
TTCN_EncDec::CT_RAW);
+   in.pfi().encode(RlcmacUlEgprsDataBlock_pfi_descr_, ttcn_buffer, 
TTCN_EncDec::CT_RAW);
}

if (in.blocks().is_bound()) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17987
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieb061d2914be086791e264a78ae14d3d55e10815
Gerrit-Change-Number: 17987
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: cosmetic: RLCMAC_EncDEc.cc: fix typos in comments

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17985 )


Change subject: cosmetic: RLCMAC_EncDEc.cc: fix typos in comments
..

cosmetic: RLCMAC_EncDEc.cc: fix typos in comments

Change-Id: Id91ed01759c3e1e2b52f1e35b1f4198fbc052408
---
M library/RLCMAC_EncDec.cc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/85/17985/1

diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index 777815f..f4735e9 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -279,7 +279,7 @@
 }

 /* bit-shift the entire 'src' of length 'length_bytes' by 'offset_bits'
- * and store the reuslt to caller-allocated 'buffer'.  The shifting is
+ * and store the result to caller-allocated 'buffer'.  The shifting is
  * done lsb-first. */
 static void clone_aligned_buffer_lsbf(unsigned int offset_bits, unsigned int 
length_bytes,
const uint8_t *src, uint8_t *buffer)
@@ -938,7 +938,7 @@
int i;

if (!in.blocks().is_bound()) {
-   /* we don't have nay blocks: Add length value (zero) */
+   /* we don't have any blocks: Add length value (zero) */
in.mac__hdr().e() = false; /* E=0: extension octet follows */
} else if (in.blocks().size_of() == 1 && in.blocks()[0].hdr() == 
OMIT_VALUE) {
/* If there's only a single block, and that block has no HDR 
value defined, */

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17985
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id91ed01759c3e1e2b52f1e35b1f4198fbc052408
Gerrit-Change-Number: 17985
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDEc.cc: dec_RlcmacUl(Egprs)DataBlock: fix tlli and pfi unin...

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17986 )


Change subject: RLCMAC_EncDEc.cc: dec_RlcmacUl(Egprs)DataBlock: fix tlli and 
pfi uninitialized instead of omit
..

RLCMAC_EncDEc.cc: dec_RlcmacUl(Egprs)DataBlock: fix tlli and pfi uninitialized 
instead of omit

Change-Id: Id63ae66cd715512f12eb87fd9ff0a9f5af93d5d2
---
M library/RLCMAC_EncDec.cc
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/86/17986/1

diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index f4735e9..d544e69 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -606,10 +606,14 @@
if (ret_val.mac__hdr().tlli__ind()) {
ret_val.tlli() = OCTETSTRING(4, ttcn_buffer.get_read_data());
ttcn_buffer.increase_pos(4);
+   } else {
+   ret_val.tlli() = OMIT_VALUE;
}
/* parse optional PFI */
if (ret_val.mac__hdr().pfi__ind()) {
ret_val.pfi().decode(RlcmacUlDataBlock_pfi_descr_, ttcn_buffer, 
TTCN_EncDec::CT_RAW);
+   } else {
+   ret_val.pfi() = OMIT_VALUE;
}

/* RLC blocks at end */
@@ -734,10 +738,14 @@
if (ret_val.tlli__ind()) {
ret_val.tlli() = OCTETSTRING(4, aligned_buffer.get_read_data());
aligned_buffer.increase_pos(4);
+   } else {
+   ret_val.tlli() = OMIT_VALUE;
}
/* parse optional PFI */
if (ret_val.mac__hdr().pfi__ind()) {
ret_val.pfi().decode(RlcmacUlDataBlock_pfi_descr_, 
aligned_buffer, TTCN_EncDec::CT_RAW);
+   } else {
+   ret_val.pfi() = OMIT_VALUE;
}

/* RLC blocks at end */

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id63ae66cd715512f12eb87fd9ff0a9f5af93d5d2
Gerrit-Change-Number: 17986
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-hlr[master]: 2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16459 )

Change subject: 2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union
..


Patch Set 11:

To summarize:

- keith had no time to look at this, says to go ahead and deal with the merged 
situation later.
- pespin would prefer an opaque data structure for peer id, for ABI compat 
reasons.
- I'm reluctant to add opaque data because that requires dynamic allocation.
  Concerning future ABI compatibility, I agree that it would be a nice thing 
but is not a hard requirement. IMHO it isn't worth adding dynamic allocation 
(and rewriting many patches on this branch) for it.
- laforge indicates slight preference of the patch staying as it is now.
- I would actually prefer a plain char string (the current real world usage).
  My gut feel is that this will remain API bloat forever, but it gives the 
benefit of the doubt to being able to expand the API compatibly in the future.

Seems like everyone is pointing in a slightly different direction.
But I think we need to come to a conclusion.

In the last patch set, I only renamed osmo_gsup_peer_id to osmo_cni_peer_id, 
added some API doc and tweaked some commit log messages, added a const.

So, essentially, these patches are still the same that they have been for months

I've probed the patches for desirable changes for a while and seem to hit 
reasons to not change anything in every direction. So we either find agreement 
on how to change these patches, or we merge them as they are. I think there is 
agreement that we don't want to keep this on a branch for much longer, so I'd 
ask reviewers to converge on a verdict, ideally one that says CR+2...


--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
Gerrit-Change-Number: 16459
Gerrit-PatchSet: 11
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 17:31:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-hlr[master]: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name

[neels]

Hello fixeria, pespin, laforge, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16205

to look at the new patch set (#31).

Change subject: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name
..

1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name

These are seemingly orthogonal changes in one patch, because they are in fact
sufficiently intertwined that we are not willing to spend the time to separate
them. They are also refactoring changes, unlikely to make sense on their own.

** lu_fsm:

Attempting to make luop.c keep state about incoming GSUP requests made me find
shortcomings in several places:
- since it predates osmo_fsm, it is a state machine that does not strictly
  enforce the order of state transitions or the right sequence of incoming
  events.
- several places OSMO_ASSERT() on data received from the network.
- modifies the subscriber state before a LU is accepted.
- dead code about canceling a subscriber in a previous VLR. That would be a
  good thing to actually do, which should also be trivial now that we record
  vlr_name and sgsn_name, but I decided to remove the dead code for now.

To both step up the LU game *and* make it easier for me to integrate
osmo_gsup_req handling, I decided to create a lu_fsm, drawing from my, by now,
ample experience of writing osmo_fsms.

** osmo_gsup_req:

Prepare for D-GSM, where osmo-hlr will do proxy routing for remote HLRs /
communicate with remote MSCs via a proxy:

a) It is important that a response that osmo-hlr generates and that is sent
back to a requesting MSC contains all IEs that are needed to route it back to
the requester. Particularly source_name must become destination_name in the
response to be able to even reach the requesting MSC. Other fields are also
necessary to match, which were so far taken care of in individual numerous code
paths.

b) For some operations, the response to a GSUP request is generated
asynchronously (like Update Location Request -> Response, or taking the
response from an EUSE, or the upcoming proxying to a remote HLR). To be able to
feed a request message's information back into the response, we must thus keep
the request data around. Since struct osmo_gsup_message references a lot of
external data, usually with pointers directly into the received msgb, it is not
so trivial to pass GSUP message data around asynchronously, on its own.

osmo_gsup_req is the combined solution for both a and b: it keeps all data for
a GSUP message by taking ownership of the incoming msgb, and it provides an
explicit API "forcing" callers to respond with osmo_gsup_req_respond(), so that
all code paths trivially are definitely responding with the correct IEs set to
match the request's routing (by using osmo_gsup_make_response() recently added
to libosmocore).

Adjust all osmo-hlr code paths to use *only* osmo_gsup_req to respond to
incoming requests received on the GSUP server (above LU code being one of
them).

In fact, the same should be done on the client side. Hence osmo_gsup_req is
implemented in a server/client agnostic way, and is placed in
libosmo-gsupclient. As soon as we see routing errors in complex GSUP setups,
using osmo_gsup_req in the related GSUP client is likely to resolve those
problems without much thinking required beyond making all code paths use it.

libosmo-gsupclient is hence added to osmo-hlr binary's own library
dependencies. It would have been added by the D-GSM proxy routing anyway, we
are just doing it a little sooner.

** cni_peer_id.c / osmo_ipa_name:

We so far handle an IPA unit name as pointer + size, or as just pointer with
implicit talloc size. To ease working with GSUP peer identification data, I
require:

- a non-allocated storage of an IPA Name. It brings the drawback of being
  size limited, but our current implementation is anyway only able to handle
  MSC and SGSN names of 31 characters (see struct hlr_subscriber).
- a single-argument handle for IPA Name,
- easy to use utility functions like osmo_ipa_name_to_str(), 
osmo_ipa_name_cmp(), and copying
  by simple assignment, a = b.

Hence this patch adds a osmo_ipa_name in cni_peer_id.h and cni_peer_id.c. 
Heavily
used in LU and osmo_gsup_req.

Depends: libosmocore Id9692880079ea0f219f52d81b1923a76fc640566
Change-Id: I3a8dff3d4a1cbe10d6ab08257a0138d6b2a082d9
---
M configure.ac
M include/Makefile.am
A include/osmocom/gsupclient/gsup_req.h
A include/osmocom/gsupclient/ipa_name.h
M include/osmocom/hlr/Makefile.am
M include/osmocom/hlr/db.h
M include/osmocom/hlr/gsup_router.h
M include/osmocom/hlr/gsup_server.h
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_ussd.h
M include/osmocom/hlr/logging.h
A include/osmocom/hlr/lu_fsm.h
D include/osmocom/hlr/luop.h
M src/Makefile.am
M src/db_hlr.c
M src/gsup_router.c
M src/gsup_send.c
M src/gsup_server.c
M src/gsupclient/Makefile.am
A src/gsupclient/gsup_req.c
A 

Change in osmo-hlr[master]: 2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union

[neels]

Hello pespin, fixeria, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16459

to look at the new patch set (#11).

Change subject: 2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union
..

2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union

To be prepared for the future in public API, wrap the new osmo_ipa_name struct
in an enum-type and union called osmo_cni_peer.

During code review it was requested to insert an ability to handle different
kinds of peer id, in order to be able to add a Global Title in the future.

Use the generic osmo_cni_peer only in the publicly visible API. For osmo-hlr
internal code, I intend to postpone implementing this into the future, when a
different peer identification actually gets introduced.

This way we don't need to implement it now in all osmo-hlr code paths (save
time now), but still make all external API users aware that this type may be
extended in the future.

Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
---
M include/Makefile.am
A include/osmocom/gsupclient/cni_peer_id.h
M include/osmocom/gsupclient/gsup_req.h
D include/osmocom/gsupclient/ipa_name.h
M include/osmocom/hlr/db.h
M include/osmocom/hlr/gsup_server.h
M src/Makefile.am
M src/db_hlr.c
M src/gsup_server.c
M src/gsupclient/Makefile.am
A src/gsupclient/cni_peer_id.c
M src/gsupclient/gsup_req.c
D src/gsupclient/ipa_name.c
M src/hlr.c
M src/hlr_ussd.c
M src/lu_fsm.c
M tests/db/Makefile.am
M tests/db/db_test.c
M tests/gsup_server/Makefile.am
19 files changed, 346 insertions(+), 181 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/59/16459/11
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
Gerrit-Change-Number: 16459
Gerrit-PatchSet: 11
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: gsup client: add up_down_cb(), add osmo_gsup_client_create3()

[neels]

Hello fixeria, pespin, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16206

to look at the new patch set (#31).

Change subject: gsup client: add up_down_cb(), add osmo_gsup_client_create3()
..

gsup client: add up_down_cb(), add osmo_gsup_client_create3()

For the GSUP clients in upcoming D-GSM enabled osmo-hlr, it will be necessary
to trigger an event as soon as a GSUP client connection becomes ready for
communication. Add the osmo_gsup_client->up_down_cb.

Add osmo_gsup_client_create3() to pass the up_down_cb in the arguments. Also
add a cb data argument to populate the already existing osmo_gsup_client->data
item directly from osmo_gsup_client_create3().

We need the callbacks and data pointer in the osmo_gsup_client_create()
function right before startup, because this function immediately starts up the
connection. Who knows whether callbacks might trigger right away.

Because there are so many arguments, and to prevent the need for ever new
versions of this function, pass the arguments as an extendable struct.

Change-Id: I6f181e42b678465bc9945f192559dc57d2083c6d
---
M include/osmocom/gsupclient/gsup_client.h
M src/gsupclient/gsup_client.c
2 files changed, 74 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/06/16206/31
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16206
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I6f181e42b678465bc9945f192559dc57d2083c6d
Gerrit-Change-Number: 16206
Gerrit-PatchSet: 31
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG@10
PS1, Line 10: otherwise the generic
: UNKNOWN gsmtap message will be sent.
> I am not asking you to do complete refactoring. […]
That will most probably break other code paths relying on GSMTAP submitting 
there on error, that's why I'm saying it's not really the task at hand.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Thu, 30 Apr 2020 15:25:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG@10
PS1, Line 10: otherwise the generic
: UNKNOWN gsmtap message will be sent.
> Well a lot of stuff shouldn't be done how it is in osmo-pcu right now, but it 
> does it this way. […]
I am not asking you to do complete refactoring. Just make it not depend on the 
returned value (in a separate change), so there will be no need to change 
return code in this patch.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Thu, 30 Apr 2020 15:11:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/17593 )

Change subject: mobile: add audio config, with unused audio loopback setting
..


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg
File doc/examples/mobile/multi_ms.cfg:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg@63
PS2, Line 63:   io-target none
> take a look at vadim's audio patch: that is all about redirecting audio to a 
> file, to a local sound  […]
I am fine with 'route', if you guys find it less confusing.


https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c
File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@1538
PS2, Line 1538: vty_out(vty, "  no io-target%s", VTY_NEWLINE);
> pespin: why there's a "no"? simply have io-target none.
> neels: the most widespread vty pattern in osmocom to switch something off is

Well, io-target (or io-route) is not something that we turn on and off. We 
always do something with received TCH frames, dropping is an action too ;) So 
yeah, 'io-target none' may be better. This way we could also avoid this switch 
and rely on audio_io_target_name().

> pespin: And if it's the default, then don't print it.
> osmith: It should probably be printed if !hide_default is set, to match the 
> code above.

ACK. This is a nice feature, and we should use it. I would also like to have 
such an option in other osmo-* projects.

> Seems that recent developments favor omitting default behavior, but that 
> isn't always
> helping the user to understand. Personally, I slightly favor printing the 
> defaults.

Agreeing with Neels here. But here, fortunately, the user can decide whether to 
print everything or the diff from defaults only.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 15:03:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: neels 
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: db v6: determine 3G AUC IND from VLR name

[neels]

Hello pespin, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16764

to look at the new patch set (#12).

Change subject: db v6: determine 3G AUC IND from VLR name
..

db v6: determine 3G AUC IND from VLR name

Each VLR requesting auth tuples should use a distinct IND pool for 3G auth.  So
far we tied the IND to the GSUP peer connection; MSC and SGSN were always
distinct GSUP peers, they ended up using distinct INDs.

However, we have implemented a GSUP proxy, so that, in a distributed setup, a
remotely roaming subscriber has only one direct GSUP peer proxying for both
remote MSC and SGSN. That means as soon as a subscriber roams to a different
site, we would use the GSUP proxy name to determine the IND instead of the
separate MSC and SGSN. The site's MSC and SGSN appear as the same client, get
the same IND bucket, waste SQNs rapidly and cause auth tuple generation load.

So instead of using the local client as IND, persistently keep a list of VLR
names and assign a different IND to each. Use the gsup_req->source_name as
indicator, which reflects the actual remote VLR's name (remote MSC or SGSN).

Persist the site <-> IND assignments in the database.

Add an IND test to db_test.c

There was an earlier patch version that separated the IND pools by cn_domain,
but it turned out to add complex semantics, while only solving one aspect of
the "adjacent VLR" problem. We need a solution not only for CS vs PS, but also
for 2,3G vs 4G, and for sites that are physically adjacent to each other. This
patch version does not offer any automatic solution for that -- as soon as more
than 2^IND_bitlen (usually 32) VLRs show up, it is the responsibility of the
admin to ensure the 'ind' table in the hlr.db does not have unfortunate IND
assignments. So far no VTY commands exist for that, they may be added in the
future.

Related: OS#4319
Change-Id: I6f0a6bbef3a27507605c3b4a0e1a89bdfd468374
---
M include/osmocom/hlr/db.h
M sql/hlr.sql
M src/db.c
M src/db_hlr.c
M src/hlr.c
M tests/db/db_test.c
M tests/db/db_test.err
M tests/db_upgrade/db_upgrade_test.ok
8 files changed, 292 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/64/16764/12
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16764
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I6f0a6bbef3a27507605c3b4a0e1a89bdfd468374
Gerrit-Change-Number: 16764
Gerrit-PatchSet: 12
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: D-GSM 3/n: implement roaming by mslookup in osmo-hlr

[neels]

Hello pespin, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16258

to look at the new patch set (#25).

Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr
..

D-GSM 3/n: implement roaming by mslookup in osmo-hlr

Add mslookup client to find remote home HLRs of unknown IMSIs, and
proxy/forward GSUP for those to the right remote HLR instances.

Add remote_hlr.c to manage one GSUP client per remote HLR GSUP address.

Add proxy.c to keep state about remotely handled IMSIs (remote GSUP address,
MSISDN, and probably more in future patches).  The mslookup_server that
determines whether a given MSISDN is attached locally now also needs to look in
the proxy record: it is always the osmo-hlr immediately peering for the MSC
that should respond to mslookup service address queries like SIP and SMPP.
(Only gsup.hlr service is always answered by the home HLR.)

Add dgsm.c to set up an mdns mslookup client, ask for IMSI homes, and to decide
which GSUP is handled locally and which needs to go to a remote HLR.

Add full VTY config and VTY tests.

For a detailed overview of the D-GSM and mslookup related files, please see the
elaborate comment at the top of mslookup.c (already added in an earlier patch).

Change-Id: I2fe453553c90e6ee527ed13a13089900efd488aa
---
M include/osmocom/hlr/Makefile.am
A include/osmocom/hlr/dgsm.h
M include/osmocom/hlr/gsup_server.h
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M include/osmocom/hlr/logging.h
M include/osmocom/hlr/mslookup_server.h
A include/osmocom/hlr/proxy.h
A include/osmocom/hlr/remote_hlr.h
M src/Makefile.am
A src/dgsm.c
M src/dgsm_vty.c
M src/gsup_server.c
M src/hlr.c
M src/hlr_vty.c
M src/logging.c
M src/mslookup_server.c
A src/proxy.c
A src/remote_hlr.c
M tests/gsup_server/Makefile.am
M tests/test_nodes.vty
21 files changed, 2,005 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/58/16258/25
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16258
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I2fe453553c90e6ee527ed13a13089900efd488aa
Gerrit-Change-Number: 16258
Gerrit-PatchSet: 25
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: D-GSM 2/n: implement mDNS method of mslookup server

[neels]

Hello pespin, keith, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16257

to look at the new patch set (#24).

Change subject: D-GSM 2/n: implement mDNS method of mslookup server
..

D-GSM 2/n: implement mDNS method of mslookup server

Implement the mslookup server's mDNS responder, to actually service remote
mslookup requests:
- VTY mslookup/server config with service names,
- the mslookup_mdns_server listening for mslookup requests,

For a detailed overview of the D-GSM and mslookup related files, please see the
elaborate comment at the top of mslookup.c (already added in an earlier patch).

Change-Id: I5cae6459090588b4dd292be90a5e8903432669d2
---
M include/osmocom/hlr/Makefile.am
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M include/osmocom/hlr/mslookup_server.h
A include/osmocom/hlr/mslookup_server_mdns.h
M src/Makefile.am
A src/dgsm_vty.c
M src/hlr.c
A src/mslookup_server_mdns.c
M tests/test_nodes.vty
M tests/test_subscriber.vty
11 files changed, 605 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/57/16257/24
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16257
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I5cae6459090588b4dd292be90a5e8903432669d2
Gerrit-Change-Number: 16257
Gerrit-PatchSet: 24
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name

[neels]

Hello fixeria, pespin, laforge, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16205

to look at the new patch set (#30).

Change subject: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name
..

1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name

These are seemingly orthogonal changes in one patch, because they are in fact
sufficiently intertwined that we are not willing to spend the time to separate
them. They are also refactoring changes, unlikely to make sense on their own.

** lu_fsm:

Attempting to make luop.c keep state about incoming GSUP requests made me find
shortcomings in several places:
- since it predates osmo_fsm, it is a state machine that does not strictly
  enforce the order of state transitions or the right sequence of incoming
  events.
- several places OSMO_ASSERT() on data received from the network.
- modifies the subscriber state before a LU is accepted.
- dead code about canceling a subscriber in a previous VLR. That would be a
  good thing to actually do, which should also be trivial now that we record
  vlr_name and sgsn_name, but I decided to remove the dead code for now.

To both step up the LU game *and* make it easier for me to integrate
osmo_gsup_req handling, I decided to create a lu_fsm, drawing from my, by now,
ample experience of writing osmo_fsms.

** osmo_gsup_req:

Prepare for D-GSM, where osmo-hlr will do proxy routing for remote HLRs /
communicate with remote MSCs via a proxy:

a) It is important that a response that osmo-hlr generates and that is sent
back to a requesting MSC contains all IEs that are needed to route it back to
the requester. Particularly source_name must become destination_name in the
response to be able to even reach the requesting MSC. Other fields are also
necessary to match, which were so far taken care of in individual numerous code
paths.

b) For some operations, the response to a GSUP request is generated
asynchronously (like Update Location Request -> Response, or taking the
response from an EUSE, or the upcoming proxying to a remote HLR). To be able to
feed a request message's information back into the response, we must thus keep
the request data around. Since struct osmo_gsup_message references a lot of
external data, usually with pointers directly into the received msgb, it is not
so trivial to pass GSUP message data around asynchronously, on its own.

osmo_gsup_req is the combined solution for both a and b: it keeps all data for
a GSUP message by taking ownership of the incoming msgb, and it provides an
explicit API "forcing" callers to respond with osmo_gsup_req_respond(), so that
all code paths trivially are definitely responding with the correct IEs set to
match the request's routing (by using osmo_gsup_make_response() recently added
to libosmocore).

Adjust all osmo-hlr code paths to use *only* osmo_gsup_req to respond to
incoming requests received on the GSUP server (above LU code being one of
them).

In fact, the same should be done on the client side. Hence osmo_gsup_req is
implemented in a server/client agnostic way, and is placed in
libosmo-gsupclient. As soon as we see routing errors in complex GSUP setups,
using osmo_gsup_req in the related GSUP client is likely to resolve those
problems without much thinking required beyond making all code paths use it.

libosmo-gsupclient is hence added to osmo-hlr binary's own library
dependencies. It would have been added by the D-GSM proxy routing anyway, we
are just doing it a little sooner.

** cni_peer_id.c / osmo_ipa_name:

We so far handle an IPA unit name as pointer + size, or as just pointer with
implicit talloc size. To ease working with GSUP peer identification data, I
require:

- a non-allocated storage of an IPA Name. It brings the drawback of being
  size limited, but our current implementation is anyway only able to handle
  MSC and SGSN names of 31 characters (see struct hlr_subscriber).
- a single-argument handle for IPA Name,
- easy to use utility functions like osmo_ipa_name_to_str(), 
osmo_ipa_name_cmp(), and copying
  by simple assignment, a = b.

Hence this patch adds a osmo_ipa_name in cni_peer_id.h and cni_peer_id.c. 
Heavily
used in LU and osmo_gsup_req.

Depends: libosmocore Id9692880079ea0f219f52d81b1923a76fc640566
Change-Id: I3a8dff3d4a1cbe10d6ab08257a0138d6b2a082d9
---
M configure.ac
M include/Makefile.am
A include/osmocom/gsupclient/gsup_req.h
A include/osmocom/gsupclient/ipa_name.h
M include/osmocom/hlr/Makefile.am
M include/osmocom/hlr/db.h
M include/osmocom/hlr/gsup_router.h
M include/osmocom/hlr/gsup_server.h
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_ussd.h
M include/osmocom/hlr/logging.h
A include/osmocom/hlr/lu_fsm.h
D include/osmocom/hlr/luop.h
M src/Makefile.am
M src/db_hlr.c
M src/gsup_router.c
M src/gsup_send.c
M src/gsup_server.c
M src/gsupclient/Makefile.am
A src/gsupclient/gsup_req.c
A 

Change in osmo-hlr[master]: gsup_server: send routing error back to the correct peer

[neels]

Hello pespin, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16336

to look at the new patch set (#16).

Change subject: gsup_server: send routing error back to the correct peer
..

gsup_server: send routing error back to the correct peer

If a peer attempts to add a route to an ipa-name that we already have in the
routing system, don't send the routing error to the peer that already has the
name, but to the peer that attempts to re-use it and would cause the collision.

This is fixing a situation where for example a locally attached MSC has name
'MSC-1', and a remote site is proxying GSUP here for a remote MSC that also has
the name 'MSC-1'. Send the routing error back to the proxy, not local 'MSC-1'.

Change-Id: Icafaedc11b5925149d338bdcb987ae985a7323d6
---
M src/gsup_server.c
1 file changed, 14 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/36/16336/16
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16336
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icafaedc11b5925149d338bdcb987ae985a7323d6
Gerrit-Change-Number: 16336
Gerrit-PatchSet: 16
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: 2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union

[neels]

Hello pespin, fixeria, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/16459

to look at the new patch set (#10).

Change subject: 2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union
..

2/2: wrap ipa_name in osmo_cni_peer_id with type enum and union

To be prepared for the future in public API, wrap the new osmo_ipa_name struct
in an enum-type and union called osmo_cni_peer.

During code review it was requested to insert an ability to handle different
kinds of peer id, in order to be able to add a Global Title in the future.

Use the generic osmo_cni_peer only in the publicly visible API. For osmo-hlr
internal code, I intend to postpone implementing this into the future, when a
different peer identification actually gets introduced.

This way we don't need to implement it now in all osmo-hlr code paths (save
time now), but still make all external API users aware that this type may be
extended in the future.

Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
---
M include/Makefile.am
A include/osmocom/gsupclient/cni_peer_id.h
M include/osmocom/gsupclient/gsup_req.h
D include/osmocom/gsupclient/ipa_name.h
M include/osmocom/hlr/db.h
M include/osmocom/hlr/gsup_server.h
M src/Makefile.am
M src/db_hlr.c
M src/gsup_server.c
M src/gsupclient/Makefile.am
A src/gsupclient/cni_peer_id.c
M src/gsupclient/gsup_req.c
D src/gsupclient/ipa_name.c
M src/hlr.c
M src/hlr_ussd.c
M src/lu_fsm.c
M tests/db/Makefile.am
M tests/db/db_test.c
M tests/gsup_server/Makefile.am
19 files changed, 346 insertions(+), 181 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/59/16459/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
Gerrit-Change-Number: 16459
Gerrit-PatchSet: 10
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[neels]

Hello pespin, fixeria, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/17593

to look at the new patch set (#4).

Change subject: mobile: add audio config, with unused audio loopback setting
..

mobile: add audio config, with unused audio loopback setting

The aim is to add configurable audio loopback to mobile. An existing patch on a
branch from fixeria [1] adds the audio config section. Add a reduced version of
this audio config to be compatible with the future merge.

Add the audio loopback setting, so far without functionality.
Subsequent patch adds the actual loopback.

[1] osmocom-bb branch fixeria/audio,
patch "mobile/vty_interface.c: add new 'audio' section"
Change-id I62cd5ef22ca2290fcafe65c78537ddbcb39fb8c6

Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
---
M doc/examples/mobile/default.cfg
M doc/examples/mobile/multi_ms.cfg
M src/host/layer23/include/osmocom/bb/mobile/settings.h
M src/host/layer23/include/osmocom/bb/mobile/vty.h
M src/host/layer23/src/mobile/settings.c
M src/host/layer23/src/mobile/vty_interface.c
6 files changed, 99 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/93/17593/4
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[neels]

Hello pespin, fixeria, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/17593

to look at the new patch set (#3).

Change subject: mobile: add audio config, with unused audio loopback setting
..

mobile: add audio config, with unused audio loopback setting

The aim is to add configurable audio loopback to mobile. An existing patch on a
branch from fixeria [1] adds the audio config section. Add a reduced version of
this audio config to be compatible with the future merge.

Add the audio loopback setting, so far without functionality.
Subsequent patch adds the actual loopback.

[1] osmocom-bb branch fixeria/audio,
patch "mobile/vty_interface.c: add new 'audio' section"
Change-id I62cd5ef22ca2290fcafe65c78537ddbcb39fb8c6

Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
---
M doc/examples/mobile/default.cfg
M doc/examples/mobile/multi_ms.cfg
M src/host/layer23/include/osmocom/bb/mobile/settings.h
M src/host/layer23/include/osmocom/bb/mobile/vty.h
M src/host/layer23/src/mobile/settings.c
M src/host/layer23/src/mobile/vty_interface.c
6 files changed, 101 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/93/17593/3
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 )

Change subject: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()
..


Patch Set 1:

hmm, interesting. So a CM Service Reject with "LU Required" should happen 
because the VLR doesn't know the IMSI yet, but not sure whether it should 
authenticate first. Probably not, right?


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I26fe18093e49bc9f53ac0234338c2b5cf9e4f07c
Gerrit-Change-Number: 16889
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 14:05:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/17593 )

Change subject: mobile: add audio config, with unused audio loopback setting
..


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg
File doc/examples/mobile/multi_ms.cfg:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg@63
PS2, Line 63:   io-target none
> Fine with me, but since this isn't my patch: […]
take a look at vadim's audio patch: that is all about redirecting audio to a 
file, to a local sound card etc. Setting it to loopback is added there by this 
patch (or rather, this patch does some of the preparations for vadim's patch 
already). Maybe just "target" then, but I don't mind "io-target".


https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c
File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@1538
PS2, Line 1538: vty_out(vty, "  no io-target%s", VTY_NEWLINE);
> > why there's a "no"? simply have io-target none. […]
the most widespread vty pattern in osmocom to switch something off is

  no foo

obviously we should stick to that pattern.
Vadim's original patch also has a 'no io-target'.

Whether or not to omit default behavior in vty write is varied in osmo programs.
Seems that recent developments favor omitting default behavior, but that isn't 
always helping the user to understand. Personally, I slightly favor printing 
the defaults.
Interesting, the hide_default is a static global that defaults to 0 (i.e. print 
the defaults) and can be changed by the vty command 'hide-default' :)


https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2776
PS2, Line 2776: argv[0]
> Now I'm sure: argv[0] can't be used here, because the config string 
> "io-target loopback" doesn't tak […]
thx! Came from copying code with multiple args and reducing it to one


https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2780
PS2, Line 2780: "no io-target", NO_STR "Disable TCH frame processing")
> You can drop this one, rather have a io-target none
disagree



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 12:42:09 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/17593 )

Change subject: mobile: add audio config, with unused audio loopback setting
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c
File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2776
PS2, Line 2776: argv[0]
> ...scratch that, I misread the get_string_value(). Sorry for the noise.
Now I'm sure: argv[0] can't be used here, because the config string "io-target 
loopback" doesn't take an argument, it is not like "io-target IO_TARGET".

So this should be:

 return set_audio_io_target(vty, ms, AUDIO_IO_LOOPBACK);

With that fix, the patch works for me, otherwise it does not.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 12:34:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

Build failure of network:osmocom:nightly/osmo-uecups in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-uecups failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-uecups

Last lines of build log:
[  797s]^~~
[  797s] main.c: In function 'main':
[  797s] main.c:776:23: error: implicit declaration of function 
'osmo_signalfd_setup' [-Werror=implicit-function-declaration]
[  797s]   g_daemon->signalfd = osmo_signalfd_setup(g_daemon, sigset, 
signal_cb, g_daemon);
[  797s]^~~
[  797s] main.c:776:21: warning: assignment makes pointer from integer without 
a cast [-Wint-conversion]
[  797s]   g_daemon->signalfd = osmo_signalfd_setup(g_daemon, sigset, 
signal_cb, g_daemon);
[  797s]  ^
[  797s] cc1: some warnings being treated as errors
[  797s] Makefile:469: recipe for target 'main.o' failed
[  797s] make[3]: *** [main.o] Error 1
[  797s] make[3]: Leaving directory '/usr/src/packages/BUILD/daemon'
[  797s] Makefile:402: recipe for target 'all-recursive' failed
[  797s] make[2]: *** [all-recursive] Error 1
[  797s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  797s] Makefile:349: recipe for target 'all' failed
[  797s] make[1]: *** [all] Error 2
[  797s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  797s] dh_auto_build: make -j1 returned exit code 2
[  797s] debian/rules:45: recipe for target 'build' failed
[  797s] make: *** [build] Error 2
[  797s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  797s] ### VM INTERACTION START ###
[  800s] [  731.649243] sysrq: SysRq : Power Off
[  800s] [  731.651746] reboot: Power down
[  800s] ### VM INTERACTION END ###
[  800s] 
[  800s] armbuild18 failed "build osmo-uecups_0.1.3.1.8362.dsc" at Thu Apr 30 
12:33:36 UTC 2020.
[  800s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/17593 )

Change subject: mobile: add audio config, with unused audio loopback setting
..


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c
File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2776
PS2, Line 2776: argv[0]
> This must be converted to "enum audio_io_target".
...scratch that, I misread the get_string_value(). Sorry for the noise.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:43:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/17593 )

Change subject: mobile: add audio config, with unused audio loopback setting
..


Patch Set 2: Code-Review-1

(1 comment)

string is not converted to enum value yet

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c
File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2776
PS2, Line 2776: argv[0]
This must be converted to "enum audio_io_target".



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:41:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:33:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-msc[master]: gsup_client_mux_tx_error_reply(): handle optional routing IEs

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17984 )

Change subject: gsup_client_mux_tx_error_reply(): handle optional routing IEs
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17984
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2694ea15d2cf57316f2eae845afb957a3e8067b6
Gerrit-Change-Number: 17984
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:30:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in docker-playground[master]: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/17976 )

Change subject: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming
..


Patch Set 1: Code-Review+2

Merging since the osmo-ttcn3-hacks related patches were merged.


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0710f52ddab8da8638970d28dc88f6882cc5f637
Gerrit-Change-Number: 17976
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:12:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in docker-playground[master]: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/17976 )

Change subject: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming
..

ttcn3-pcu: Fix cfgn content after ttcn3 module renaming

Required after osmo-ttcn3-hacks.git:
Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Iacaddb56e41012ba58ef6d1b9e79d2c012259bed

Change-Id: I0710f52ddab8da8638970d28dc88f6882cc5f637
---
M ttcn3-pcu-test/PCU_Tests.cfg
M ttcn3-pcu-test/sns/PCU_Tests.cfg
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  pespin: Looks good to me, approved; Verified



diff --git a/ttcn3-pcu-test/PCU_Tests.cfg b/ttcn3-pcu-test/PCU_Tests.cfg
index 8c75ca9..17ab6c6 100644
--- a/ttcn3-pcu-test/PCU_Tests.cfg
+++ b/ttcn3-pcu-test/PCU_Tests.cfg
@@ -9,8 +9,8 @@
 *.PCUVTY.PROMPT1 := "OsmoPCU> "

 [MODULE_PARAMETERS]
-PCU_Tests_RAW.mp_pcu_sock_path := "/data/unix/pcu_bts"
-PCU_Tests.mp_nsconfig := {
+PCU_Tests.mp_pcu_sock_path := "/data/unix/pcu_bts"
+SGSN_Components.mp_nsconfig := {
local_ip := "172.18.13.10",
local_udp_port := 23000,
remote_ip := "172.18.13.101",
@@ -23,5 +23,5 @@
 [MAIN_CONTROLLER]

 [EXECUTE]
-PCU_Tests_RAW.control
-PCU_Tests_RAW_NS.control
+PCU_Tests.control
+PCU_Tests_NS.control
diff --git a/ttcn3-pcu-test/sns/PCU_Tests.cfg b/ttcn3-pcu-test/sns/PCU_Tests.cfg
index 07db9b3..60f375b 100644
--- a/ttcn3-pcu-test/sns/PCU_Tests.cfg
+++ b/ttcn3-pcu-test/sns/PCU_Tests.cfg
@@ -7,8 +7,8 @@
 [TESTPORT_PARAMETERS]

 [MODULE_PARAMETERS]
-PCU_Tests_RAW.mp_pcu_sock_path := "/data/unix/pcu_bts"
-PCU_Tests.mp_nsconfig := {
+PCU_Tests.mp_pcu_sock_path := "/data/unix/pcu_bts"
+SGSN_Components.mp_nsconfig := {
local_ip := "172.18.14.10",
local_udp_port := 23000,
remote_ip := "172.18.14.101",
@@ -20,4 +20,4 @@
 [MAIN_CONTROLLER]

 [EXECUTE]
-PCU_Tests_RAW_SNS.control
+PCU_Tests_SNS.control

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0710f52ddab8da8638970d28dc88f6882cc5f637
Gerrit-Change-Number: 17976
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 4: Code-Review+2

+1+1=+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:12:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Rename PCU*RAW* content to PCU

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 )

Change subject: pcu: Rename PCU*RAW* content to PCU
..


Patch Set 3: Code-Review+2

+1+1=+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed
Gerrit-Change-Number: 17975
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:12:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG@10
PS1, Line 10: otherwise the generic
: UNKNOWN gsmtap message will be sent.
> See my comment to your previous change. Return code should not redefine the 
> GSMTAP channel type.
Well a lot of stuff shouldn't be done how it is in osmo-pcu right now, but it 
does it this way. Complete refactoring of all code paths to change that logic 
is out of the scope for this patch.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:07:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

[pespin]

pespin has removed fixeria from this change.  ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..


Removed reviewer fixeria with the following votes:

* Code-Review+1 by fixeria 
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: deleteReviewer

Change in osmocom-bb[master]: mobile: loopback voice frames

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/17381 )

Change subject: mobile: loopback voice frames
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17381
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83
Gerrit-Change-Number: 17381
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:56:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmocom-bb[master]: mobile: add audio config, with unused audio loopback setting

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/17593 )

Change subject: mobile: add audio config, with unused audio loopback setting
..


Patch Set 2:

(2 comments)

Somehow I've missed that we have this patch on gerrit already :\

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg
File doc/examples/mobile/multi_ms.cfg:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg@63
PS2, Line 63:   io-target none
> io-target sounds confusing. […]
Fine with me, but since this isn't my patch:

Vadim, Neels: what do you think about "route" instead of "io-target"?

I could do the rename.


https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c
File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@1538
PS2, Line 1538: vty_out(vty, "  no io-target%s", VTY_NEWLINE);
> why there's a "no"? simply have io-target none.

Agreed

> And if it's the default, then don't print it.

It should probably be printed if !hide_default is set, to match the code above.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a
Gerrit-Change-Number: 17593
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: osmith 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:55:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in mncc-python[master]: mncc_mt_loadgen.py: add codec arg

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17980 )

Change subject: mncc_mt_loadgen.py: add codec arg
..


Patch Set 3: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17980
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
Gerrit-Change-Number: 17980
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:07:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )

Change subject: rtpsource: CTRL call rtp_create: add codec arg
..


Patch Set 3: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: osmith 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:07:21 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

[osmith]

osmith has uploaded a new patch set (#3). ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )

Change subject: rtpsource: CTRL call rtp_create: add codec arg
..

rtpsource: CTRL call rtp_create: add codec arg

Instead of hardcoding FR in rtpsource, add an argument to set the codec
from mncc_mt_loadgen.py via CTRL call rtp_create. Hardcode FR in
mncc_mt_loadgen.py for now, a follow up patch will make it configurable
there, too.

Related: SYS#4924
Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
---
M mncc_mt_loadgen.py
M rtpsource/ctrl_if.c
M rtpsource/internal.h
M rtpsource/rtp_provider.c
M rtpsource/rtp_provider.h
M rtpsource/rtpsource.c
6 files changed, 60 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/79/17979/3
--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: osmith 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )

Change subject: rtpsource: CTRL call rtp_create: add codec arg
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/mncc-python/+/17979/2/rtpsource/rtpsource.c
File rtpsource/rtpsource.c:

https://gerrit.osmocom.org/c/mncc-python/+/17979/2/rtpsource/rtpsource.c@104
PS2, Line 104:  conn->local_host, conn->local_port, codec);
I should also display the name here, patching...



--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: osmith 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:03:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )

Change subject: rtpsource: CTRL call rtp_create: add codec arg
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: osmith 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:01:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: Modularize generation of RTP frames

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17978 )

Change subject: rtpsource: Modularize generation of RTP frames
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17978
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: Iad98e1753fef1927c0e8a7493372141372a38224
Gerrit-Change-Number: 17978
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:01:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: mncc_mt_loadgen.py: add codec arg

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17980 )

Change subject: mncc_mt_loadgen.py: add codec arg
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17980
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
Gerrit-Change-Number: 17980
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:01:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )

Change subject: rtpsource: CTRL call rtp_create: add codec arg
..


Patch Set 2:

> Patch Set 1:
>
> why use some magic integer number that requires python and C code to agre on 
> numbering and whihc will be difficult to understand/debug?  CTRL uses 
> strings, so you could juts as well send strings like fr/efr/...

Ack, that's better. Updated.


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: osmith 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:01:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

[osmith]

osmith has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )

Change subject: rtpsource: CTRL call rtp_create: add codec arg
..

rtpsource: CTRL call rtp_create: add codec arg

Instead of hardcoding FR in rtpsource, add an argument to set the codec
from mncc_mt_loadgen.py via CTRL call rtp_create. Hardcode FR in
mncc_mt_loadgen.py for now, a follow up patch will make it configurable
there, too.

Related: SYS#4924
Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
---
M mncc_mt_loadgen.py
M rtpsource/ctrl_if.c
M rtpsource/internal.h
M rtpsource/rtp_provider.c
M rtpsource/rtp_provider.h
M rtpsource/rtpsource.c
6 files changed, 60 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/79/17979/2
--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in mncc-python[master]: mncc_mt_loadgen.py: add codec arg

[osmith]

Hello laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/mncc-python/+/17980

to look at the new patch set (#2).

Change subject: mncc_mt_loadgen.py: add codec arg
..

mncc_mt_loadgen.py: add codec arg

Add codec parameter to start_call() and convenience functions mt_call()
and calls() with FR as default. While at it, update the help text.

Related: SYS#4924
Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
---
M mncc_mt_loadgen.py
1 file changed, 10 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/80/17980/2
--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17980
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
Gerrit-Change-Number: 17980
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 07:43:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-msc[master]: SMS-over-GSUP: notify sender about malformed GSUP messages

[fixeria]

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17874 )

Change subject: SMS-over-GSUP: notify sender about malformed GSUP messages
..

SMS-over-GSUP: notify sender about malformed GSUP messages

Change-Id: I27f00e69ff045cbf641ef21adf44fcd55cb8f889
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index cf9d11d..7c9b6fb 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -178,9 +178,8 @@
return 0;

 msg_error:
-   /* TODO: notify sender about that? */
-   LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n",
-   msg_name, msg_is_err ? "Err" : "Res");
+   LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n", msg_name, msg_is_err ? 
"Err" : "Res");
+   gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, 
GMM_CAUSE_INV_MAND_INFO);
return -EINVAL;
 }

@@ -269,8 +268,8 @@
return 0;

 msg_error:
-   /* TODO: notify sender about that? */
LOGP(DLSMS, LOGL_NOTICE, "RX malformed MT-forwardSM-Req\n");
+   gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, 
GMM_CAUSE_INV_MAND_INFO);
return -EINVAL;
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17874
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I27f00e69ff045cbf641ef21adf44fcd55cb8f889
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-msc[master]: SMS-over-GSUP: move net->sms_over_gsup check to gsm411_gsup_rx()

[fixeria]

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17871 )

Change subject: SMS-over-GSUP: move net->sms_over_gsup check to gsm411_gsup_rx()
..

SMS-over-GSUP: move net->sms_over_gsup check to gsm411_gsup_rx()

Change-Id: I89988b7148b164af304ecae1f53b74f322fdc7bd
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 8 insertions(+), 16 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index dfc90cc..1751655 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -149,14 +149,6 @@
OSMO_ASSERT(0);
}

-   /* Make sure that 'SMS over GSUP' is expected */
-   if (!net->sms_over_gsup) {
-   /* TODO: notify sender about that? */
-   LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO SMS over GSUP "
-   "(sms-over-gsup is not enabled), ignoring 
message...\n");
-   return -EIO;
-   }
-
/* Verify GSUP message */
if (!gsup_msg->sm_rp_mr)
goto msg_error;
@@ -241,14 +233,6 @@

LOGP(DLSMS, LOGL_DEBUG, "RX MT-forwardSM-Req\n");

-   /* Make sure that 'SMS over GSUP' is expected */
-   if (!net->sms_over_gsup) {
-   LOGP(DLSMS, LOGL_NOTICE, "Unexpected MT SMS over GSUP "
-   "(sms-over-gsup is not enabled), ignoring 
message...\n");
-   /* TODO: notify sender about that? */
-   return -EIO;
-   }
-
/**
 * Verify GSUP message
 *
@@ -296,6 +280,14 @@
struct vlr_subscr *vsub;
int rc;

+   /* Make sure that 'SMS over GSUP' is expected */
+   if (!net->sms_over_gsup) {
+   /* TODO: notify sender about that? */
+   LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO/MT SMS over GSUP "
+   "(sms-over-gsup is not enabled), ignoring 
message...\n");
+   return -EIO;
+   }
+
vsub = vlr_subscr_find_by_imsi(net->vlr, gsup_msg->imsi, __func__);
if (!vsub) {
LOGP(DLSMS, LOGL_ERROR, "Rx %s for unknown subscriber, 
rejecting\n",

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17871
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I89988b7148b164af304ecae1f53b74f322fdc7bd
Gerrit-Change-Number: 17871
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-msc[master]: SMS-over-GSUP: notify sender about unhandled GSUP messages

[fixeria]

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17873 )

Change subject: SMS-over-GSUP: notify sender about unhandled GSUP messages
..

SMS-over-GSUP: notify sender about unhandled GSUP messages

Change-Id: I7970349bd9d5c56a64c409e619e8b581682fef0b
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index a24c617..cf9d11d 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -315,6 +315,7 @@
default:
LOGP(DMM, LOGL_ERROR, "No handler found for %s, dropping 
message...\n",
osmo_gsup_message_type_name(gsup_msg->message_type));
+   gsup_client_mux_tx_error_reply(gcm, gsup_msg, 
GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL);
rc = -GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL;
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17873
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7970349bd9d5c56a64c409e619e8b581682fef0b
Gerrit-Change-Number: 17873
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-msc[master]: SMS-over-GSUP: respond with error if net->sms_over_gsup is false

[fixeria]

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17872 )

Change subject: SMS-over-GSUP: respond with error if net->sms_over_gsup is false
..

SMS-over-GSUP: respond with error if net->sms_over_gsup is false

Change-Id: If14f8a394e691f86e0acbffb283c3862fe62ffd2
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 1751655..a24c617 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -282,9 +282,9 @@

/* Make sure that 'SMS over GSUP' is expected */
if (!net->sms_over_gsup) {
-   /* TODO: notify sender about that? */
LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO/MT SMS over GSUP "
"(sms-over-gsup is not enabled), ignoring 
message...\n");
+   gsup_client_mux_tx_error_reply(gcm, gsup_msg, 
GMM_CAUSE_GPRS_NOTALLOWED);
return -EIO;
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17872
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If14f8a394e691f86e0acbffb283c3862fe62ffd2
Gerrit-Change-Number: 17872
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-msc[master]: SMS-over-GSUP: move net->sms_over_gsup check to gsm411_gsup_rx()

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17871 )

Change subject: SMS-over-GSUP: move net->sms_over_gsup check to gsm411_gsup_rx()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17871
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I89988b7148b164af304ecae1f53b74f322fdc7bd
Gerrit-Change-Number: 17871
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 07:35:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/4/pcu/PCU_selftest.ttcn
File pcu/PCU_selftest.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/4/pcu/PCU_selftest.ttcn@208
PS4, Line 208:  // Some octstrings are concatenated to avoid Atom editor 
hanging: https://github.com/karolwiniarski/language-ttcn-3/issues/3
lol



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 30 Apr 2020 07:22:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in pysim[master]: utils.py: Add helper method to parse ePDG Identifier from hex string

[herlesupreeth]

herlesupreeth has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/17883 )

Change subject: utils.py: Add helper method to parse ePDG Identifier from hex 
string
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@365
PS1, Line 365:  if o
> sure, i can have a look into such python libraries and get back on this
will it be okay to use the following file from python-pcsclite python library? 
please let me know your opinion on this.

http://python-pcsclite.sourceforge.net/doc/examples/iso7816.py

python-pcsclite is under GNU Affero General Public License, i hope it goes well 
with GPL License of pysim.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17883
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I96fb129d178cfd7ec037989526da77899ae8d344
Gerrit-Change-Number: 17883
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 07:17:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: herlesupreeth 
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in osmo-msc[master]: gsup_client_mux_tx_error_reply(): handle optional routing IEs

[fixeria]

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17984 )


Change subject: gsup_client_mux_tx_error_reply(): handle optional routing IEs
..

gsup_client_mux_tx_error_reply(): handle optional routing IEs

If received GSUP message contains at least the source name IE,
then the error message sent in response sould not omit the
routing information. Let's also include them.

Change-Id: I2694ea15d2cf57316f2eae845afb957a3e8067b6
---
M src/libmsc/gsup_client_mux.c
1 file changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/84/17984/1

diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c
index e425651..2e6f25d 100644
--- a/src/libmsc/gsup_client_mux.c
+++ b/src/libmsc/gsup_client_mux.c
@@ -161,6 +161,22 @@

OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi);

+   /* Handle optional routing IEs */
+   if (gsup_orig->source_name && gsup_orig->source_name_len) {
+   /* We respond to the sender of the original message */
+   gsup_reply.destination_name_len = gsup_orig->source_name_len;
+   gsup_reply.destination_name = gsup_orig->source_name;
+
+   /* We're sending an error, so we're the source */
+   const char *local_msc_name = gcm->gsup_client->ipa_dev->serno;
+   if (!local_msc_name)
+   local_msc_name = gcm->gsup_client->ipa_dev->unit_name;
+   if (local_msc_name) {
+   gsup_reply.source_name_len = strlen(local_msc_name) + 1;
+   gsup_reply.source_name = gsup_orig->source_name;
+   }
+   }
+
/* For SS/USSD, it's important to keep both session state and ID IEs */
if (gsup_orig->session_state != OSMO_GSUP_SESSION_STATE_NONE) {
gsup_reply.session_state = OSMO_GSUP_SESSION_STATE_END;

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17984
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2694ea15d2cf57316f2eae845afb957a3e8067b6
Gerrit-Change-Number: 17984
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in mncc-python[master]: update .gitignore with rtpsource object code file names

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17977 )

Change subject: update .gitignore with rtpsource object code file names
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I085d50bb60e4eebda5d92c6e5fbc5a1d56c0badb
Gerrit-Change-Number: 17977
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 30 Apr 2020 07:01:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: update .gitignore with rtpsource object code file names

[osmith]

osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17977 )

Change subject: update .gitignore with rtpsource object code file names
..

update .gitignore with rtpsource object code file names

Change-Id: I085d50bb60e4eebda5d92c6e5fbc5a1d56c0badb
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  osmith: Verified



diff --git a/.gitignore b/.gitignore
index b948985..77e974f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,5 @@
 *.swp
 *.pyc
+
+*.o
+rtpsource/rtpsource

--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I085d50bb60e4eebda5d92c6e5fbc5a1d56c0badb
Gerrit-Change-Number: 17977
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-MessageType: merged

Change in osmo-msc[master]: SMS-over-GSUP: notify sender in case of RPL delivery failure

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17875 )

Change subject: SMS-over-GSUP: notify sender in case of RPL delivery failure
..


Patch Set 1:

(1 comment)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-msc/+/17875/1/src/libmsc/gsm_04_11_gsup.c
File src/libmsc/gsm_04_11_gsup.c:

https://gerrit.osmocom.org/c/osmo-msc/+/17875/1/src/libmsc/gsm_04_11_gsup.c@264
PS1, Line 264: GMM_CAUSE_NET_FAIL
> is it a network failure if the MT-SMS could not be delivered? It could also 
> be a MS/UE failure, a ra […]
Actually at this point we initiate MT message delivery, i.e. creating SMR/SMC 
state machines and starting paging if needed. Thus if anything goes wrong, it's 
definitely on our side.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17875
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8436601c4314395e28829960dc753778c37b1125
Gerrit-Change-Number: 17875
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 06:47:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in pysim[master]: utils.py: Add helper method to parse ePDG Identifier from hex string

[herlesupreeth]

herlesupreeth has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/17883 )

Change subject: utils.py: Add helper method to parse ePDG Identifier from hex 
string
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@365
PS1, Line 365:  if o
> In that commit you linked you still hand-coded the TLV parsing instead of 
> using an existing parser. […]
sure, i can have a look into such python libraries and get back on this



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17883
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I96fb129d178cfd7ec037989526da77899ae8d344
Gerrit-Change-Number: 17883
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 06:29:31 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: herlesupreeth 
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment